From 1cdd0e8cd801aa1d6f04ab4d8e6097a46af8c951 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 22 Nov 2017 21:59:35 -0500 Subject: [PATCH] Disable history expansion in eshell (Bug#29157) History expansion is not so useful since interactive history commands are already provided. It can produce surprising errors when the user is not aware of the history designator syntax. * lisp/eshell/em-hist.el (eshell-hist-initialize): Don't add eshell-expand-history-references to eshell-expand-input-functions. * etc/NEWS: Announce it. --- etc/NEWS | 9 +++++++++ lisp/eshell/em-hist.el | 3 --- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 6b3e7fc244b..cbd50f02272 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -113,6 +113,15 @@ styles as configured by the variable 'completion-styles'. These macros are analogue to 'let' and 'let*', but create bindings that are evaluated lazily. +** Eshell + +--- +*** Expansion of history event designators is disabled by default. +To restore the old behavior, use + + (add-hook 'eshell-expand-input-functions + #'eshell-expand-history-references) + * New Modes and Packages in Emacs 27.1 diff --git a/lisp/eshell/em-hist.el b/lisp/eshell/em-hist.el index 8084c126530..df462a70587 100644 --- a/lisp/eshell/em-hist.el +++ b/lisp/eshell/em-hist.el @@ -218,9 +218,6 @@ Returns nil if INPUT is prepended by blank space, otherwise non-nil." (defun eshell-hist-initialize () "Initialize the history management code for one Eshell buffer." - (add-hook 'eshell-expand-input-functions - 'eshell-expand-history-references nil t) - (when (eshell-using-module 'eshell-cmpl) (add-hook 'pcomplete-try-first-hook 'eshell-complete-history-reference nil t)) -- 2.39.5