From 1917c51fe6881847e5e373b81d2330aa86b5b7bb Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Tue, 14 Feb 2023 07:29:25 -0800 Subject: [PATCH] ; Prevent ERC-induced false positive in JUnit report * test/lisp/erc/erc-scenarios-internal.el: Mimic other test files, like perl-mode-tests.el, in setting `ert-load-file-name' globally. This file formerly caused a false positive in the error detection logic of `ert-write-junit-test-summary-report'. It affected all scheduled pipelines, including those for the release branch, Emacs 29. --- test/lisp/erc/erc-scenarios-internal.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/lisp/erc/erc-scenarios-internal.el b/test/lisp/erc/erc-scenarios-internal.el index 8d38c2dde49..18eb94e24b0 100644 --- a/test/lisp/erc/erc-scenarios-internal.el +++ b/test/lisp/erc/erc-scenarios-internal.el @@ -21,6 +21,9 @@ (require 'ert-x) (eval-and-compile + (when (and (getenv "EMACS_TEST_DIRECTORY") + (getenv "EMACS_TEST_JUNIT_REPORT")) + (setq ert-load-file-name (or (macroexp-file-name) buffer-file-name))) (let ((load-path (cons (expand-file-name "erc-d" (ert-resource-directory)) load-path))) (load "erc-d-tests" nil 'silent))) -- 2.39.2