From 17ebb6e5ae9cdd2586d1b4d6f2347ae09c6f653f Mon Sep 17 00:00:00 2001 From: Michael Albinus Date: Fri, 13 Jul 2018 14:28:12 +0200 Subject: [PATCH] Use consistent function names in thread-tests.el * test/src/thread-tests.el (threads-call-error, threads-custom) (threads-errors, threads-sticky-point, threads-signal-early): Rename, using naming convention to prefix with "threads-". --- test/src/thread-tests.el | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/test/src/thread-tests.el b/test/src/thread-tests.el index 3c7fde33d8f..a00a9c84bd6 100644 --- a/test/src/thread-tests.el +++ b/test/src/thread-tests.el @@ -253,31 +253,32 @@ (string= "hi bob" (condition-name (make-condition-variable (make-mutex) "hi bob"))))) -(defun call-error () + +(defun threads-call-error () "Call `error'." (error "Error is called")) ;; This signals an error internally; the error should be caught. -(defun thread-custom () - (defcustom thread-custom-face 'highlight +(defun threads-custom () + (defcustom threads-custom-face 'highlight "Face used for thread customizations." :type 'face :group 'widget-faces)) -(ert-deftest thread-errors () +(ert-deftest threads-errors () "Test what happens when a thread signals an error." (skip-unless (featurep 'threads)) (let (th1 th2) - (setq th1 (make-thread #'call-error "call-error")) + (setq th1 (make-thread #'threads-call-error "call-error")) (should (threadp th1)) (while (thread-alive-p th1) (thread-yield)) (should (equal (thread-last-error) '(error "Error is called"))) - (setq th2 (make-thread #'thread-custom "thread-custom")) + (setq th2 (make-thread #'threads-custom "threads-custom")) (should (threadp th2)))) -(ert-deftest thread-sticky-point () +(ert-deftest threads-sticky-point () "Test bug #25165 with point movement in cloned buffer." (skip-unless (featurep 'threads)) (with-temp-buffer @@ -288,7 +289,7 @@ (sit-for 1) (should (= (point) 21)))) -(ert-deftest thread-signal-early () +(ert-deftest threads-signal-early () "Test signaling a thread as soon as it is started by the OS." (skip-unless (featurep 'threads)) (let ((thread -- 2.39.2