From 11562ddbde3962a43701ea4d334cffa72e0fe5b1 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sun, 4 Feb 2024 13:57:06 +0100 Subject: [PATCH] ; Fix remote shell file name selection * lisp/shell.el (shell): Cease providing 'file-remote-p' as completion predicate when reading remote shell file name. The completion predicate in 'read-file-name' gets the non-directory part of the file name, which in particular does not include the remote part, if any, so this predicate always fail in these settings. Moreover, this predicate didn't make a lot of sense to begin with. --- lisp/shell.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/shell.el b/lisp/shell.el index c5cfbd985ed..b02f5f117a9 100644 --- a/lisp/shell.el +++ b/lisp/shell.el @@ -905,8 +905,7 @@ Make the shell buffer the current buffer, and return it. (file-local-name (expand-file-name (read-file-name "Remote shell path: " default-directory - shell-file-name t shell-file-name - #'file-remote-p)))))))))) + shell-file-name t shell-file-name)))))))))) (setq buffer (if (or buffer (not (derived-mode-p 'shell-mode)) (comint-check-proc (current-buffer))) -- 2.39.5