From 101b3c81b657198ebaf9abdaa0875d1b09d66192 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Peter=20M=C3=BCnster?= Date: Wed, 18 Aug 2021 01:37:43 +0200 Subject: [PATCH] New placement of newline characters in image-dired-db-file It's more usual to have the newline at the end of the line, instead of the beginning. This change avoids missing newline at the end of the file, an empty line at the start and eventually a lot of empty lines when `require-final-newline' is not nil. * lisp/image-dired.el (image-dired-write-tags): Insert newline at the end of the line, instead of the beginning. (image-dired-remove-tag): Do not delete empty line at end of buffer. --- lisp/image-dired.el | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/lisp/image-dired.el b/lisp/image-dired.el index 9455ab1ff08..542701470e9 100644 --- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -1096,7 +1096,7 @@ FILE-TAGS is an alist in the following form: (end-of-line) (insert (format ";%s" tag)))) (goto-char (point-max)) - (insert (format "\n%s;%s" file tag)))) + (insert (format "%s;%s\n" file tag)))) (save-buffer)))) (defun image-dired-remove-tag (files tag) @@ -1123,11 +1123,7 @@ FILE-TAGS is an alist in the following form: (setq end (point)) (beginning-of-line) (when (not (search-forward ";" end t)) - (kill-line 1) - ;; If on empty line at end of buffer - (and (eobp) - (looking-at "^$") - (delete-char -1))))))) + (kill-line 1)))))) (save-buffer))) (defun image-dired-list-tags (file) @@ -2185,7 +2181,7 @@ FILE-COMMENTS is an alist on the following form: (insert (format "comment:%s;" comment))) ;; File does not exist in database - add it. (goto-char (point-max)) - (insert (format "\n%s;comment:%s" file comment)))) + (insert (format "%s;comment:%s\n" file comment)))) (save-buffer)))) (defun image-dired-update-property (prop value) -- 2.39.2