From 07edc28bdbfeeaeb1008b4fe21bfda586feae562 Mon Sep 17 00:00:00 2001 From: Lars Ingebrigtsen Date: Mon, 11 Oct 2021 11:14:26 +0200 Subject: [PATCH] Fix ert errors when there's a test that binds `debug-on-error' * lisp/emacs-lisp/ert.el (ert--run-test-internal): Don't infloop on errors when signalling errors (bug#51131). --- lisp/emacs-lisp/ert.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el index 98cb1fd1cf6..b7d984374cb 100644 --- a/lisp/emacs-lisp/ert.el +++ b/lisp/emacs-lisp/ert.el @@ -783,6 +783,10 @@ This mainly sets up debugger-related bindings." (ert--run-test-debugger test-execution-info args))) (debug-on-error t) + ;; Don't infloop if the error being called is erroring + ;; out, and we have `debug-on-error' bound to nil inside + ;; the test. + (backtrace-on-error-noninteractive nil) (debug-on-quit t) ;; FIXME: Do we need to store the old binding of this ;; and consider it in `ert--run-test-debugger'? -- 2.39.2