From 03b8cc3c6be32733d379486e36f027a39076a6b2 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Mattias=20Engdeg=C3=A5rd?= Date: Wed, 3 Apr 2024 11:27:16 +0200 Subject: [PATCH] Make lexical-binding cookie warning test more robust * test/lisp/emacs-lisp/bytecomp-tests.el (bytecomp-tests--lexical-binding-cookie): Run with lexical-binding both on and off. (cherry picked from commit 0c55261971b0fea62a8e94204e544ff8af714a2e) --- test/lisp/emacs-lisp/bytecomp-tests.el | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el b/test/lisp/emacs-lisp/bytecomp-tests.el index 26408e8685a..a943012e5fc 100644 --- a/test/lisp/emacs-lisp/bytecomp-tests.el +++ b/test/lisp/emacs-lisp/bytecomp-tests.el @@ -1348,12 +1348,14 @@ byte-compiled. Run with dynamic binding." (string-search "file has no `lexical-binding' directive on its first line" (bytecomp-tests--log-from-compilation source)))) - (let ((some-code "(defun my-fun () 12)\n")) - (should-not (cookie-warning - (concat ";;; -*-lexical-binding:t-*-\n" some-code))) - (should-not (cookie-warning - (concat ";;; -*-lexical-binding:nil-*-\n" some-code))) - (should (cookie-warning some-code))))) + (dolist (lb '(t nil)) + (let ((lexical-binding lb) + (some-code "(defun my-fun () 12)\n")) + (should-not (cookie-warning + (concat ";;; -*-lexical-binding:t-*-\n" some-code))) + (should-not (cookie-warning + (concat ";;; -*-lexical-binding:nil-*-\n" some-code))) + (should (cookie-warning some-code)))))) (ert-deftest bytecomp-tests--unescaped-char-literals () "Check that byte compiling warns about unescaped character -- 2.39.5