]> git.eshelyaron.com Git - emacs.git/commit
Fix default-port regression in erc-select-read-args
authorF. Jason Park <jp@neverwas.me>
Thu, 29 Dec 2022 14:43:19 +0000 (06:43 -0800)
committerF. Jason Park <jp@neverwas.me>
Mon, 2 Jan 2023 13:48:39 +0000 (05:48 -0800)
commitff35ac9dfabf7ac33199c42bc56c8bb0f53eebc4
treed9b8e9a8f20a71ab86dfef976da05ea92bb5739b
parentb7ad0b40148bd5905497a4c05fced4e0b9099812
Fix default-port regression in erc-select-read-args

* lisp/erc/erc.el (erc--warn-unencrypted): New function, likely
temporary, to warn new users connecting interactively to the default
server, "irc.libara.chat", via the default non-TLS port, 6667.
(erc-select-read-args): Remove stray code from incomplete feature
introduced by bug#56514.  Ensure connecting always works with default
port, which is non-TLS.  Respect `erc-prompt-for-password' when user
pastes URL containing password component into "server" prompt.  Maybe
add `erc--warn-unencrypted' as one-off hook for impending connection.
* test/lisp/erc/erc-tests.el (erc-select-read-args): Always expect
password prompt and sometimes a non-TLS port when `erc' called
interactively.  (Bug#60428.)
lisp/erc/erc.el
test/lisp/erc/erc-tests.el