]> git.eshelyaron.com Git - emacs.git/commit
Make OMake support slightly less expensive (bug#39595)
authorMattias Engdegård <mattiase@acm.org>
Sat, 15 Feb 2020 15:08:14 +0000 (16:08 +0100)
committerMattias Engdegård <mattiase@acm.org>
Mon, 17 Feb 2020 10:23:41 +0000 (11:23 +0100)
commitf765aad28baf946666eb225b97228038167fade8
tree0c32ae8b0077c7dd5a80e657aae9796e60d140d4
parent39410cfc5a7a2a721f9f50e36d2d48dc33980e08
Make OMake support slightly less expensive (bug#39595)

When run with -p or -P, OMake regurgitates error messages that
prevented further progress, indented by 6 spaces.  Use that fact
to ameliorate the modification done to other error message regexps.

* lisp/progmodes/compile.el (compilation-parse-errors):
When 'omake' is enabled, allow error messages to be indented by 0 or 6
spaces instead of any number of spaces, to avoid pathological
behaviour.
(compilation-error-regexp-alist-alist): Anchor the 'omake' pattern to
bol for performance.  Repair the 'ruby-Test::Unit' pattern, which
relied on the previously over-generous 'omake' hack.
* etc/compilation.txt (OMake): Add examples.
* test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data)
(compile-test-error-regexps): Add test for OMake (indented error).
etc/compilation.txt
lisp/progmodes/compile.el
test/lisp/progmodes/compile-tests.el