]> git.eshelyaron.com Git - emacs.git/commit
Speed up 'maven' compilation error message regexp
authorMattias Engdegård <mattiase@acm.org>
Fri, 14 Feb 2020 20:26:20 +0000 (21:26 +0100)
committerMattias Engdegård <mattiase@acm.org>
Mon, 17 Feb 2020 10:23:41 +0000 (11:23 +0100)
commit96a269d045091bcf7ed424a7a039385727f6e694
treee00db489aab4770550cd116e7d21f169e5540205
parentefc9d4fe3ef256e6c546c1690bf7dd968f1fdac8
Speed up 'maven' compilation error message regexp

Anchor the regexp at line-start to prevent quadratic behaviour when
it doesn't match (bug#39595).  It's unclear whether the type tag, like
[ERROR], is always present; we keep it optional just in case.

* lisp/progmodes/compile.el (compilation-error-regexp-alist-alist):
Rewrite 'maven' regexp, using rx for clarity.
* etc/compilation.txt (maven): More examples.
* test/lisp/progmodes/compile-tests.el
(compile-tests--test-regexps-data): No leading spaces; they seems to
stem from a misunderstanding in bug#11517.
etc/compilation.txt
lisp/progmodes/compile.el
test/lisp/progmodes/compile-tests.el