]> git.eshelyaron.com Git - emacs.git/log
emacs.git
5 years agoRework jit-lock-antiblink-grace after Stefan's comments scratch/jit-lock-antiblink
João Távora [Wed, 31 Jul 2019 21:07:41 +0000 (22:07 +0100)]
Rework jit-lock-antiblink-grace after Stefan's comments

* lisp/jit-lock.el (jit-lock--antiblink-l-b-p): Rename from
jit-lock--antiblink-l-l-b.
(jit-lock--antiblink-grace-timer): Add period to docstring.
(jit-lock--antiblink-post-command): Rework after Stefan's
comments.

5 years agoRevert "Consider jit-lock-antiblink when fontifying "on demand""
João Távora [Wed, 31 Jul 2019 14:03:59 +0000 (15:03 +0100)]
Revert "Consider jit-lock-antiblink when fontifying "on demand""

Couldn't reproduce the situation that led to this need.

This reverts commit d0abbf28576be00e33e56a6abf2e9e27ef02cb47.

5 years agoConsider jit-lock-antiblink when fontifying "on demand"
João Távora [Fri, 12 Jul 2019 18:42:43 +0000 (19:42 +0100)]
Consider jit-lock-antiblink when fontifying "on demand"

* lisp/jit-lock.el (jit-lock-function): Consider
jit-lock--antiblink-grace-timer.

5 years agoNew jit-lock-antiblink-grace feature
João Távora [Fri, 12 Jul 2019 18:27:53 +0000 (19:27 +0100)]
New jit-lock-antiblink-grace feature

* lisp/jit-lock.el (jit-lock-antiblink-grace): New user-visible variable.
(jit-lock--antiblink-grace-timer, jit-lock--antiblink-l-l-b)
(jit-lock--antiblink-i-s-o-c): New helpers.
(jit-lock-mode): Tweak post-command-hook and
jit-lock-context-timer.
(jit-lock--antiblink-post-command): New helper.

5 years agoRemove initial and trailing whitespace in message-fetch-field
Lars Ingebrigtsen [Fri, 12 Jul 2019 14:07:43 +0000 (16:07 +0200)]
Remove initial and trailing whitespace in message-fetch-field

* lisp/gnus/message.el (message-fetch-field): Remove initial and
trailing whitespace.

5 years agoFix breaking of rfc2047 headers with long words
Lars Ingebrigtsen [Fri, 12 Jul 2019 13:59:27 +0000 (15:59 +0200)]
Fix breaking of rfc2047 headers with long words

* lisp/mail/rfc2047.el (rfc2047-fold-region): Don't break lines
right after the Header: field, but wait until the next
whitespace.  (This only makes a difference for words that are very
long (i.e., longer than, say, 60 characters, depending on the
header name length.)

5 years agoRefactor rfc2047-fold-region slightly and add a couple of tests
Lars Ingebrigtsen [Fri, 12 Jul 2019 13:48:34 +0000 (15:48 +0200)]
Refactor rfc2047-fold-region slightly and add a couple of tests

* lisp/mail/rfc2047.el (rfc2047--break-line): Refactor out to
avoid code repetition...
(rfc2047-fold-region): ... from this function.

5 years agoAdd comments to rfc2047
Lars Ingebrigtsen [Fri, 12 Jul 2019 13:38:34 +0000 (15:38 +0200)]
Add comments to rfc2047

* lisp/mail/rfc2047.el (rfc2047-fold-region): Add comments to the
function.

5 years agoMerge from origin/emacs-26
Michael Albinus [Fri, 12 Jul 2019 13:13:20 +0000 (15:13 +0200)]
Merge from origin/emacs-26

305abae50e Raise required librsvg version so as to match the current use
c6775bc9ca * lisp/net/tramp-sh.el (tramp-inline-compress-start-size):...

5 years agoCheck directory in Tramp's {copy,rename}-file
Michael Albinus [Fri, 12 Jul 2019 13:10:57 +0000 (15:10 +0200)]
Check directory in Tramp's {copy,rename}-file

* lisp/net/tramp-adb.el (tramp-adb-handle-copy-file)
(tramp-adb-handle-rename-file):
* lisp/net/tramp-gvfs.el (tramp-gvfs-do-copy-or-rename-file):
* lisp/net/tramp-rclone.el (tramp-rclone-do-copy-or-rename-file):
* lisp/net/tramp-sh.el (tramp-do-copy-or-rename-file):
* lisp/net/tramp-smb.el (tramp-smb-handle-copy-file)
(tramp-smb-handle-rename-file):
* lisp/net/tramp-sudoedit.el (tramp-sudoedit-do-copy-or-rename-file):
Check, that NEWNAME is not a directory given as file name.

* test/lisp/net/tramp-tests.el (tramp-test11-copy-file)
(tramp-test12-rename-file): Extend tests.

5 years agoRe-add tramp-autoload cookie for all defcustoms
Michael Albinus [Fri, 12 Jul 2019 13:05:55 +0000 (15:05 +0200)]
Re-add tramp-autoload cookie for all defcustoms

* lisp/net/tramp-adb.el (tramp-adb-program)
(tramp-adb-connect-if-not-connected, tramp-adb-prompt):
* lisp/net/tramp-cache.el (tramp-persistency-file-name):
* lisp/net/tramp-gvfs.el (tramp-gvfs-zeroconf-domain):
* lisp/net/tramp-rclone.el (tramp-rclone-program):
* lisp/net/tramp-sh.el (tramp-copy-size-limit, tramp-histfile-override)
(tramp-use-ssh-controlmaster-options):
* lisp/net/tramp-smb.el (tramp-smb-program, tramp-smb-acl-program)
(tramp-smb-conf, tramp-smb-winexe-program)
(tramp-smb-winexe-shell-command)
(tramp-smb-winexe-shell-command-switch): Re-add tramp-autoload
cookie for all defcustoms.

* lisp/net/tramp-adb.el (tramp-adb-handle-copy-file)
(tramp-adb-handle-rename-file):
* lisp/net/tramp-gvfs.el (tramp-gvfs-do-copy-or-rename-file):
* lisp/net/tramp-rclone.el (tramp-rclone-do-copy-or-rename-file):
* lisp/net/tramp-sh.el (tramp-do-copy-or-rename-file):
* lisp/net/tramp-smb.el (tramp-smb-handle-copy-file)
(tramp-smb-handle-rename-file):
* lisp/net/tramp-sudoedit.el (tramp-sudoedit-do-copy-or-rename-file):
Check, that NEWNAME is not a directory given as file name.

5 years ago* doc/misc/tramp.texi (Inline methods): Precise about used external programs.
Michael Albinus [Fri, 12 Jul 2019 13:05:11 +0000 (15:05 +0200)]
* doc/misc/tramp.texi (Inline methods): Precise about used external programs.

5 years agoChange Tramp version to 2.4.3-pre
Michael Albinus [Fri, 12 Jul 2019 13:04:55 +0000 (15:04 +0200)]
Change Tramp version to 2.4.3-pre

* doc/misc/trampver.texi:
* lisp/net/trampver.el: Change version to "2.4.3-pre".

* lisp/net/tramp.el: Bump version to 2.4.3-pre.

5 years agoTweak builtin symbol order for speed
Paul Eggert [Fri, 12 Jul 2019 06:06:22 +0000 (23:06 -0700)]
Tweak builtin symbol order for speed

* lib-src/make-docfile.c (compare_globals):
Make symbols 1 through 4 be t, unbound, error, lambda.
This is in addition to symbol 0 being nil.
This change improved ‘make compile-always’ performance by 0.6%
on my platform.

5 years agoAvoid duplicate comparison in describe_map_compare
Paul Eggert [Fri, 12 Jul 2019 00:01:20 +0000 (17:01 -0700)]
Avoid duplicate comparison in describe_map_compare

* src/fns.c (string_version_cmp): New function.
This has most of the old Fstring_version_lessp,
with an assertion to make things a bit clearer.
* src/fns.c (Fstring_version_lessp):
* src/keymap.c (describe_map_compare): Use it (Bug#33237).

5 years agoRaise required librsvg version so as to match the current use
YAMAMOTO Mitsuharu [Fri, 12 Jul 2019 00:03:39 +0000 (09:03 +0900)]
Raise required librsvg version so as to match the current use

* configure.ac: Set RSVG_REQUIRED to 2.14.0 as rsvg_handle_get_dimensions
needs it.

5 years ago* lisp/progmodes/compile.el (compilation-filter): Use font-lock-ensure
Juri Linkov [Thu, 11 Jul 2019 21:46:12 +0000 (00:46 +0300)]
* lisp/progmodes/compile.el (compilation-filter): Use font-lock-ensure

to update the number of errors in compilation-mode-line-errors
displayed in the mode-line.  (Bug#36564)

5 years agoBetter match-data handling in perform-replace
Juri Linkov [Thu, 11 Jul 2019 21:35:21 +0000 (00:35 +0300)]
Better match-data handling in perform-replace

* lisp/replace.el (perform-replace): Don't wrap replace-highlight
in save-match-data.  Use `(nth 0 real-match-data)' instead of
`(match-beginning 0)' after replace-highlight.  (Bug#36328)

5 years agoRemove lisp/obsolete/xesam.el
Michael Albinus [Thu, 11 Jul 2019 18:22:40 +0000 (20:22 +0200)]
Remove lisp/obsolete/xesam.el

5 years ago* test/lisp/format-spec-tests.el (test-format-unknown): Use `should-error'.
Michael Albinus [Thu, 11 Jul 2019 18:01:57 +0000 (20:01 +0200)]
* test/lisp/format-spec-tests.el (test-format-unknown): Use `should-error'.

5 years agoAllow passing unknown specs to format-spec
Lars Ingebrigtsen [Thu, 11 Jul 2019 16:44:30 +0000 (18:44 +0200)]
Allow passing unknown specs to format-spec

* lisp/format-spec.el (format-spec): Allow passing through format
strings that have no specs (to be able to act as a filter).  Also
add an example.
* test/lisp/format-spec-tests.el (test-format-spec): Add tests for
the new functionality.

5 years agoAdd tests for format-spec
Lars Ingebrigtsen [Thu, 11 Jul 2019 16:37:55 +0000 (18:37 +0200)]
Add tests for format-spec

5 years agoAdd test to time-stamp.el
Lars Ingebrigtsen [Thu, 11 Jul 2019 16:27:06 +0000 (18:27 +0200)]
Add test to time-stamp.el

5 years agoSupport program switches in 'comint-run' command
Phil Sainty [Thu, 11 Jul 2019 15:33:12 +0000 (17:33 +0200)]
Support program switches in 'comint-run' command

* etc/NEWS:
* doc/emacs/misc.texi: Describe new behaviour (bug#33037).
* lisp/comint.el (comint-run): Add optional SWITCHES argument.
With prefix argument C-u, prompt for SWITCHES.

5 years agoClarify the expand-file-name doc string
Lars Ingebrigtsen [Thu, 11 Jul 2019 15:10:52 +0000 (17:10 +0200)]
Clarify the expand-file-name doc string

* src/fileio.c (Fexpand_file_name): Clarify that "~" in NAME is
expanded, and not just "~/".  Also clarify that ~USER is not
expanded if USER doesn't exist (bug#36490).

5 years agoTweak the order keystrokes are sorted in keymap listings
Lars Ingebrigtsen [Thu, 11 Jul 2019 14:53:43 +0000 (16:53 +0200)]
Tweak the order keystrokes are sorted in keymap listings

* src/keymap.c (describe_map_compare): Change the sorting order of
keystrokes, so that we get the order <f1> <f2> <f11> instead of
<f1> <f11> <f2> (bug#33237).

5 years agoTweak misterioso header line background color
Lars Ingebrigtsen [Thu, 11 Jul 2019 14:42:16 +0000 (16:42 +0200)]
Tweak misterioso header line background color

* etc/themes/misterioso-theme.el (class): Make the header line
background darker so that cedet function names and parameters are
legible (bug#33061).

5 years agoRemove misleading message in customize
Stefan Kangas [Thu, 11 Jul 2019 14:06:03 +0000 (16:06 +0200)]
Remove misleading message in customize

* lisp/cus-edit.el (custom-buffer-create-internal): Remove misleading
message about "Resetting customization items" (bug#22451).

5 years agoFix C-x C-e with defvars in comments preceding
Lars Ingebrigtsen [Thu, 11 Jul 2019 13:42:13 +0000 (15:42 +0200)]
Fix C-x C-e with defvars in comments preceding

* lisp/progmodes/elisp-mode.el (eval-sexp-add-defvars): When
collecting defvars in the current buffer, ignore the ones that are
in comments or strings (bug#34233).

5 years agoResurrect SVG support on MS-Windows
Eli Zaretskii [Thu, 11 Jul 2019 13:28:41 +0000 (16:28 +0300)]
Resurrect SVG support on MS-Windows

* src/image.c (syms_of_image) <Qgio> [HAVE_NTGUI]: New DEFSYM.
(init_svg_functions) [LIBRSVG_CHECK_VERSION >= 2.32.0]: Load
g_file_new_for_path and g_memory_input_stream_new_from_data
from libgio, not from libglib.  (Bug#35548)

* lisp/term/w32-win.el (dynamic-library-alist): Add the libgio
DLL.

5 years agoAvoid assertion violations when resize-mini-windows is nil
Eli Zaretskii [Thu, 11 Jul 2019 13:03:33 +0000 (16:03 +0300)]
Avoid assertion violations when resize-mini-windows is nil

* src/xdisp.c (resize_mini_window): Always reset the
mini-window's start point to the beginning of the buffer, even
if resizing is not needed.  This avoids assertion violations
when resize-mini-windows is nil.  (Bug#36595)

5 years agoAvoid functions deprecated in librsvg 2.45.1
Paul Eggert [Wed, 10 Jul 2019 19:37:55 +0000 (12:37 -0700)]
Avoid functions deprecated in librsvg 2.45.1

* src/image.c (init_svg_functions) [WINDOWSNT]:
Load the pre-2.32 or 2.32 functions,
depending on LIBRSVG_CHECK_VERSION.
(svg_load_image): In librsvg 2.32 or later, use
g_memory_input_stream_new_from_data, g_file_new_for_path and
rsvg_handle_new_from_stream_sync rather than the
deprecated-in-2.45 rsvg_handle_write and rsvg_handle_close.
From a patch by YAMAMOTO Mitsuharu (Bug#35548#11).

5 years agoFix trig simplification crash (bug#33052)
Mattias Engdegård [Wed, 10 Jul 2019 17:24:58 +0000 (19:24 +0200)]
Fix trig simplification crash (bug#33052)

* lisp/calc/calc-alg.el (calcFunc-sec, calcFunc-csc, calcFunc-cot):
Check that `math-known-sin' and `math-known-tan' succeeded before
using their value in arithmetic.
* test/lisp/calc/calc-tests.el (calc-test-trig): Add regression tests.

5 years ago; Update asm-mode docstring after last change
Basil L. Contovounesios [Wed, 10 Jul 2019 13:58:32 +0000 (14:58 +0100)]
; Update asm-mode docstring after last change

* lisp/progmodes/asm-mode.el (asm-mode): Display binding for
newline-and-indent instead of its obsolete alias
asm-newline (bug#36540).

5 years agoSmall cleanups in asm-mode.el (Bug#36540)
Stefan Kangas [Sun, 7 Jul 2019 14:27:26 +0000 (16:27 +0200)]
Small cleanups in asm-mode.el (Bug#36540)

* lisp/progmodes/asm-mode.el: Remove "tools" from "Keywords" header.
Doc fixes.
(asm-comment-char, asm-comment): Doc fixes.
(asm-newline): Redefine as an obsolete function alias for
'newline-and-indent' instead of using a defalias.

5 years agoAdd recursion check for comint password prompting
Lars Ingebrigtsen [Wed, 10 Jul 2019 13:23:27 +0000 (15:23 +0200)]
Add recursion check for comint password prompting

* lisp/comint.el (comint--prompt-recursion-depth): New variable
(bug#33252).
(comint-watch-for-password-prompt): Use it to avoid bugging out
and making Emacs unusable when a shell script is prompting for
passwords in an infloop.

5 years agoFold too-long headers in Message automatically
Lars Ingebrigtsen [Wed, 10 Jul 2019 13:03:12 +0000 (15:03 +0200)]
Fold too-long headers in Message automatically

* lisp/gnus/message.el (message--fold-long-headers): Header lines
should be no longer than 79 characters before folding
(bug#33313).  Previous comment about 998 octets is about maximum
allowed header field length.

5 years agoDoc clarification in abbrev-prefix-mark
Lars Ingebrigtsen [Wed, 10 Jul 2019 12:46:05 +0000 (14:46 +0200)]
Doc clarification in abbrev-prefix-mark

* lisp/abbrev.el (abbrev-prefix-mark): Clarify when the hyphen is
removed (bug#33382).

5 years agoFix problem with files like "~" in `directory-files-recursively'
Lars Ingebrigtsen [Wed, 10 Jul 2019 12:03:55 +0000 (14:03 +0200)]
Fix problem with files like "~" in `directory-files-recursively'

* lisp/files.el (directory-files-recursively): Don't bug out on
files like "~" that have special meaning to `expand-file-name'
(bug#36490).

5 years agoAdd new section on reading a bug to admin/notes/bugtracker
Stefan Kangas [Wed, 10 Jul 2019 11:45:12 +0000 (13:45 +0200)]
Add new section on reading a bug to admin/notes/bugtracker

* admin/notes/bugtracker: New section "How do I read a bug?" in
"Quickstart" (Bug#36560).

5 years agoFix pretty-printing of {}
Lars Ingebrigtsen [Wed, 10 Jul 2019 11:23:43 +0000 (13:23 +0200)]
Fix pretty-printing of {}

* lisp/json.el (json-pretty-print): Fix reading {}, which returns nil.

5 years agoFix warnings in todo-mode-tests.el (Bug#36569)
Stefan Kangas [Wed, 10 Jul 2019 01:45:15 +0000 (03:45 +0200)]
Fix warnings in todo-mode-tests.el (Bug#36569)

* test/lisp/calendar/todo-mode-tests.el (todo-test--insert-item):
Fix "Unused lexical argument" warnings.

5 years agoFix warning in electric-tests.el (Bug#36570)
Stefan Kangas [Wed, 10 Jul 2019 01:50:48 +0000 (03:50 +0200)]
Fix warning in electric-tests.el (Bug#36570)

* test/lisp/electric-tests.el (plainer-c-mode): Remove duplicate
definition.

5 years ago* lisp/net/tramp-sh.el (tramp-inline-compress-start-size): Set nil on w32.
Michael Albinus [Wed, 10 Jul 2019 08:34:02 +0000 (10:34 +0200)]
* lisp/net/tramp-sh.el (tramp-inline-compress-start-size): Set nil on w32.

5 years agoSimplify math-get-calendar-tzinfo
Paul Eggert [Wed, 10 Jul 2019 06:18:13 +0000 (23:18 -0700)]
Simplify math-get-calendar-tzinfo

* lisp/calc/calc-forms.el (calendar-current-time-zone-cache):
Remove defvar.
(math-get-calendar-tzinfo): Simplify and do not reach
into caldst’s cache.

5 years agoFix documentation of cl-member
Lars Ingebrigtsen [Tue, 9 Jul 2019 23:39:33 +0000 (01:39 +0200)]
Fix documentation of cl-member

* doc/misc/cl.texi (Lists as Sets): cl-member with no :test is not
equal to memq (because it uses eql) (bug#33655).

5 years agoauth-source does not support "host" in .netrc files
Lars Ingebrigtsen [Tue, 9 Jul 2019 23:18:39 +0000 (01:18 +0200)]
auth-source does not support "host" in .netrc files

* doc/misc/auth.texi (Help for users): Remove mention of "host" in
.netrc files, because it's not supported (bug#33826).

5 years agoWhite-space fix in fortune-compile
Lars Ingebrigtsen [Tue, 9 Jul 2019 22:53:39 +0000 (00:53 +0200)]
White-space fix in fortune-compile

* lisp/play/fortune.el (fortune-compile): Reindent function.

5 years agoSearch exec-path for fortune strfile program
Benjamin Ragheb [Tue, 9 Jul 2019 22:31:10 +0000 (00:31 +0200)]
Search exec-path for fortune strfile program

* lisp/play/fortune.el (fortune-compile): Search exec-path for
strfile program (bug#33984).

Copyright-paperwork-exempt: yes

5 years agoRemove json-pretty-print-max-secs introduced earlier this year
Lars Ingebrigtsen [Tue, 9 Jul 2019 22:09:24 +0000 (00:09 +0200)]
Remove json-pretty-print-max-secs introduced earlier this year

* lisp/json.el (json-pretty-print-max-secs): Remove the variable
as it's no longer used.

5 years agoFix timezone east of GMT in Calv
Lars Ingebrigtsen [Tue, 9 Jul 2019 22:04:55 +0000 (00:04 +0200)]
Fix timezone east of GMT in Calv

* lisp/calc/calc-forms.el (math-calendar-tzinfo): Make timezone
calculation work east of Greenwich.  Fix proposed by David O'Shea
(bug#34075).

5 years ago* src/fileio.c: Fix bug#36431
Stefan Monnier [Tue, 9 Jul 2019 21:04:07 +0000 (17:04 -0400)]
* src/fileio.c: Fix bug#36431

(decide_coding_unwind): Re-introduce.  Move text back to the gap.
Return the new `inserted` via the unwind_data.
(Finsert_file_contents): Use it.
Make sure `inserted` is always 0 when we jump straight to `notfound`.
Don't insert the text in the buffer until we know it's properly decoded
for the byteness of the buffer.

* test/src/fileio-tests.el (fileio-tests--insert-file-interrupt):
Allow insert-file-contents to return an empty buffer in case of
non-local exit in set-auto-coding-function.

5 years agoDefend fingerprint against even-smarter LTO
Paul Eggert [Tue, 9 Jul 2019 20:55:16 +0000 (13:55 -0700)]
Defend fingerprint against even-smarter LTO

* src/pdumper.c (Fdump_emacs_portable, pdumper_load):
Don’t cast volatile to non-volatile pointer, as that does not in
general suffice to prevent a compiler from optimizing away memcmp
and/or memcpy calls.  Instead, copy the fingerprint by hand.

5 years agoRevert "Turn off bytecode jumptables to avoid Bug#36447"
Stefan Monnier [Tue, 9 Jul 2019 20:16:37 +0000 (16:16 -0400)]
Revert "Turn off bytecode jumptables to avoid Bug#36447"

This reverts commit 122198d2f1aaf0b74c102874cc9b04ae4789f54f.
Should not be needed any more thanks to Pip Cet's patch to hash_table_rehash.

5 years agoDon't alter shared structure in dumped purecopied hash tables.
Pip Cet [Wed, 3 Jul 2019 11:48:22 +0000 (11:48 +0000)]
Don't alter shared structure in dumped purecopied hash tables.

* src/fns.c (hash_table_rehash): Make sure we're operating on
fresh copies of ->next, ->index, ->hash.

5 years agoMerge branch 'master' of git+ssh://git.sv.gnu.org/srv/git/emacs into trunk
Stefan Monnier [Tue, 9 Jul 2019 20:13:25 +0000 (16:13 -0400)]
Merge branch 'master' of git+ssh://git.sv.gnu.org/srv/git/emacs into trunk

5 years agoDo not alter match data in Fcapitalize etc.
Paul Eggert [Tue, 9 Jul 2019 20:10:27 +0000 (13:10 -0700)]
Do not alter match data in Fcapitalize etc.

Without this patch, (capitalize "x") can alter the match data,
which is not what users expect.  Problem found by running
morse-tests-unnato-region in a stripped-down Emacs.
Perhaps ‘load’ should also save and restore the match data?
That would be a simpler fix, though arguably incompatible.
* src/lread.c (save_match_data_load): New function.
* src/chartab.c (uniprop_table):
* src/doc.c (reread_doc_file):
* src/eval.c (Fautoload_do_load):
* src/fns.c (Frequire): Use it.

5 years agoPort image-type-from-file-header-test to non-SVG Emacs
Paul Eggert [Tue, 9 Jul 2019 20:02:51 +0000 (13:02 -0700)]
Port image-type-from-file-header-test to non-SVG Emacs

Problem reported privately by Michael Albinus.
* test/lisp/image-tests.el (image-type-from-file-header-test):
Don’t assume svg is a supported image type.

5 years agoMake fingerprint handling compatible with LTO
Andreas Schwab [Tue, 9 Jul 2019 19:12:14 +0000 (21:12 +0200)]
Make fingerprint handling compatible with LTO

Tell the compiler that the fingerprint variable is modified unpredictably.

* lib/fingerprint.h (fingerprint): Remove const.
* lib/fingerprint.c (fingerprint): Likewise.
* src/pdumper.c (Fdump_emacs_portable): Cast fingerprint variable.
(pdumper_load): Likewise.
* lib-src/make-fingerprint.c (main): Likewise.

5 years agoFix pretty-printing of multiple JSON objects
Lars Ingebrigtsen [Tue, 9 Jul 2019 19:32:41 +0000 (21:32 +0200)]
Fix pretty-printing of multiple JSON objects

* lisp/json.el (json-pretty-print-max-secs): Make obsolete.
(json-pretty-print): Pretty-print all JSON objects in the region
instead of just the first one (and then deleting all other
objects) (bug#34160).

5 years agoRevert "Fix pretty-printing of multiple JSON objects"
Lars Ingebrigtsen [Tue, 9 Jul 2019 19:23:18 +0000 (21:23 +0200)]
Revert "Fix pretty-printing of multiple JSON objects"

This reverts commit 48daf77a9d963c05ee198b3ab108c7f0b3686da6.

This apparently led to build errors.

5 years agoFix pretty-printing of multiple JSON objects
Lars Ingebrigtsen [Tue, 9 Jul 2019 18:40:23 +0000 (20:40 +0200)]
Fix pretty-printing of multiple JSON objects

* lisp/json.el (json-pretty-print-max-secs): Make obsolete.
(json-pretty-print): Pretty-print all JSON objects in the region
instead of just the first one (and then deleting all other
objects) (bug#34160).

5 years ago* lisp/simple.el (shell-command): Raise a user-error instead of an error.
Michael Albinus [Tue, 9 Jul 2019 18:48:35 +0000 (20:48 +0200)]
* lisp/simple.el (shell-command): Raise a user-error instead of an error.

5 years ago; * lisp/json.el (json-encode): Doc fix.
Eli Zaretskii [Tue, 9 Jul 2019 18:41:26 +0000 (21:41 +0300)]
; * lisp/json.el (json-encode): Doc fix.

5 years agoClarify json-read and json-encode parameters and return values
Lars Ingebrigtsen [Tue, 9 Jul 2019 17:41:06 +0000 (19:41 +0200)]
Clarify json-read and json-encode parameters and return values

* lisp/json.el (json-read): Try to clarify what's returned (bug#34242).
(json-encode): Refer to `json-read' about what the input is and
say what error is signalled.

5 years agoFix alternative-email-as-from with empty To headers in Message
Lars Ingebrigtsen [Tue, 9 Jul 2019 17:19:56 +0000 (19:19 +0200)]
Fix alternative-email-as-from with empty To headers in Message

* lisp/gnus/message.el (message-use-alternative-email-as-from):
Don't add a "," at the start of the address if the To header
doesn't exist (bug#34293).

5 years agoMake gnus-read-ephemeral-emacs-bug-group autoloadable
Lars Ingebrigtsen [Tue, 9 Jul 2019 16:52:54 +0000 (18:52 +0200)]
Make gnus-read-ephemeral-emacs-bug-group autoloadable

* lisp/gnus/gnus-group.el (gnus-read-ephemeral-emacs-bug-group):
Add an autoload cookie, because the command can be used from
without Gnus.

5 years agoCheckdoc would bug out on empty files
Lars Ingebrigtsen [Tue, 9 Jul 2019 16:24:26 +0000 (18:24 +0200)]
Checkdoc would bug out on empty files

* lisp/emacs-lisp/checkdoc.el (checkdoc--next-docstring): Don't
bug out on malformed Emacs Lisp (bug#34760).
(checkdoc-file-comments-engine): Don't bug out on empty buffers.

5 years agoClarify warning about unknown articles in Gnus
Lars Ingebrigtsen [Tue, 9 Jul 2019 16:11:27 +0000 (18:11 +0200)]
Clarify warning about unknown articles in Gnus

* lisp/gnus/gnus-sum.el (gnus-summary-mark-article-as-unread)
(gnus-mark-article-as-unread): Clarify warning (bug#34990).

5 years agoDon't try to save articles in Gnus that have disappeared
Lars Ingebrigtsen [Tue, 9 Jul 2019 15:30:22 +0000 (17:30 +0200)]
Don't try to save articles in Gnus that have disappeared

* lisp/gnus/gnus-sum.el (gnus-summary-save-article): Stop trying
to save articles if the articles have disappeared (bug#35188).

5 years agoRename font_driver member close -> close_font
Mattias Engdegård [Tue, 9 Jul 2019 16:18:44 +0000 (18:18 +0200)]
Rename font_driver member close -> close_font

* src/alloc.c (cleanup_vector):
* src/xftfont.c (xftfont_driver):
* src/xfont.c (xfont_driver):
* src/nsfont.m (nsfont_driver):
* src/macfont.m (macfont_driver):
* src/ftxfont.c (ftxfont_driver):
* src/ftfont.c (ftfont_driver):
* src/ftcrfont.c (ftcrfont_driver):
* src/font.h (struct font_driver):
* src/font.c (font_clear_cache, font_close_object):
Rename `close' member to `close_font', to avoid clash with preprocessor
define of `close' in nt/inc/ms-w32.h and for consistency with `open_font'.

5 years agoMention `call-process-region' in the `call-process' doc string
Lars Ingebrigtsen [Tue, 9 Jul 2019 15:59:37 +0000 (17:59 +0200)]
Mention `call-process-region' in the `call-process' doc string

* src/callproc.c (Fcall_process): Mention `call-process-region'
(bug#35187).

5 years agoRename font_driver member open -> open_font
Mattias Engdegård [Tue, 9 Jul 2019 14:44:24 +0000 (16:44 +0200)]
Rename font_driver member open -> open_font

* src/xftfont.c (xftfont_driver):
* src/xfont.c (xfont_driver):
* src/nsfont.m (nsfont_driver):
* src/macfont.m (macfont_driver):
* src/ftxfont.c (ftxfont_driver):
* src/ftfont.c (ftfont_driver):
* src/ftcrfont.c (ftcrfont_driver):
* src/font.h (struct font_driver):
* src/font.c (font_open_entity):
Rename `open' member to `open_font', to avoid clash with preprocessor
define of `open' in lib/fcntl.h and nt/inc/ms-w32.h.  Remove earlier
#undef hack.

5 years agoAdd a really simple nadvice example
Lars Ingebrigtsen [Tue, 9 Jul 2019 15:13:38 +0000 (17:13 +0200)]
Add a really simple nadvice example

* doc/lispref/functions.texi (Advising Functions): Add a really
trivial and simple example (bug#35250).

5 years agoMake two variables for extended command suggestions mention each other
Lars Ingebrigtsen [Tue, 9 Jul 2019 14:43:02 +0000 (16:43 +0200)]
Make two variables for extended command suggestions mention each other

* lisp/simple.el (suggest-key-bindings):
(extended-command-suggest-shorter): Mention each other, because
they are vaguely related (bug#35309).

5 years agoMake the manual say what undo-auto-amalgamate does
Lars Ingebrigtsen [Tue, 9 Jul 2019 14:28:57 +0000 (16:28 +0200)]
Make the manual say what undo-auto-amalgamate does

* doc/lispref/text.texi (Undo): Say what undo-auto-amalgamate does
in addition to describing what amalgamation is (bug#35344).

5 years agoUnbreak the MS-Windows build
Eli Zaretskii [Tue, 9 Jul 2019 15:04:29 +0000 (18:04 +0300)]
Unbreak the MS-Windows build

* src/font.c (open): Don't undef on WINDOWSNT, as ms-w32.h
redirects it to sys_open.

5 years ago.har files are JSON files
Lars Ingebrigtsen [Tue, 9 Jul 2019 14:34:20 +0000 (16:34 +0200)]
.har files are JSON files

* lisp/files.el (auto-mode-alist): Map .har files to
javascript-mode (bug#35407).

5 years agoFix for lisp tagbody indentation
Ryan Brown [Tue, 9 Jul 2019 13:51:50 +0000 (15:51 +0200)]
Fix for lisp tagbody indentation

* lisp/emacs-lisp/cl-indent.el (lisp-indent-259): Indent PROG
better (bug#36552).

5 years agoAdd more quote-end characters to sentence-end-base
Lars Ingebrigtsen [Tue, 9 Jul 2019 13:38:19 +0000 (15:38 +0200)]
Add more quote-end characters to sentence-end-base

* lisp/textmodes/paragraphs.el (sentence-end-base): Add › and »
(bug#36359).

5 years ago* lisp/progmodes/verilog-mode.el: Update Version:
Stefan Monnier [Tue, 9 Jul 2019 13:30:49 +0000 (09:30 -0400)]
* lisp/progmodes/verilog-mode.el: Update Version:

5 years agoMerge branch 'emacs-26' into trunk
Stefan Monnier [Tue, 9 Jul 2019 13:29:16 +0000 (09:29 -0400)]
Merge branch 'emacs-26' into trunk

5 years ago* lisp/progmodes/verilog-mode.el: One more ELPA Version:
Stefan Monnier [Tue, 9 Jul 2019 13:27:07 +0000 (09:27 -0400)]
* lisp/progmodes/verilog-mode.el: One more ELPA Version:

5 years agoRepair macOS build
Mattias Engdegård [Tue, 9 Jul 2019 11:38:10 +0000 (13:38 +0200)]
Repair macOS build

Avoid macro redefinition of `open' in lib/fcntl.h to break use of it as
a struct member in src/font.c.

* src/font.c: #undef open

5 years agoConditionalize result of a bytecomp test
Glenn Morris [Tue, 9 Jul 2019 10:25:13 +0000 (03:25 -0700)]
Conditionalize result of a bytecomp test

* test/lisp/emacs-lisp/bytecomp-tests.el
(bytecomp-test--switch-duplicates):
Apparently the result depends on byte-compile-cond-use-jump-table.

5 years agoMake delimit-columns-region say what it does
Lars Ingebrigtsen [Tue, 9 Jul 2019 02:50:37 +0000 (04:50 +0200)]
Make delimit-columns-region say what it does

* lisp/delim-col.el (delimit-columns-region): Make the doc string
say a bit more about what it does (bug#35651).
(delimit-columns-rectangle): Refer to the first function.

5 years agoAllow using @@ in @uref in texinfo
Katsumi Yamaoka [Tue, 9 Jul 2019 02:01:26 +0000 (04:01 +0200)]
Allow using @@ in @uref in texinfo

* lisp/textmodes/texinfmt.el (texinfo-format-uref): Allow using @@
in @uref (bug#36186) to allow things like
@uref{mailto:foo@@example.com}.

5 years agoTweak compilation face in the wheatgrass theme
Lars Ingebrigtsen [Tue, 9 Jul 2019 01:56:02 +0000 (03:56 +0200)]
Tweak compilation face in the wheatgrass theme

* etc/themes/wheatgrass-theme.el: The compilation info was too
light to be readable (bug#36203).

5 years agoDon't set url-mime-charset-string from set-language-environment
Lars Ingebrigtsen [Tue, 9 Jul 2019 01:44:06 +0000 (03:44 +0200)]
Don't set url-mime-charset-string from set-language-environment

* lisp/url/url-vars.el (url-set-mime-charset-string): Make
obsolete and don't add to set-language-environment-hook
(bug#36268).  If you loaded url-vars before calling
set-language-environment, you would suddenly get an unusable long
url-mime-charset-string.

5 years agoRemove compat code in url-mime-charset-string
Lars Ingebrigtsen [Tue, 9 Jul 2019 01:34:15 +0000 (03:34 +0200)]
Remove compat code in url-mime-charset-string

* lisp/url/url-vars.el (url-mime-charset-string): Remove compat code.

5 years agoTweak messaging in re-builder
Lars Ingebrigtsen [Tue, 9 Jul 2019 01:25:42 +0000 (03:25 +0200)]
Tweak messaging in re-builder

* lisp/emacs-lisp/re-builder.el (reb-copy): Say what we copied to
the kill ring.

5 years agoMention {la,}tex-run-command in the TeX Print info node
Lars Ingebrigtsen [Mon, 8 Jul 2019 23:27:33 +0000 (01:27 +0200)]
Mention {la,}tex-run-command in the TeX Print info node

* doc/emacs/text.texi (TeX Print): Mention {la,}tex-run-command,
too.  Suggested by Sebastian Urban (bug#36400).

5 years agoAvoid some unnecessary stdio.h includes
Paul Eggert [Tue, 9 Jul 2019 00:50:39 +0000 (17:50 -0700)]
Avoid some unnecessary stdio.h includes

* src/atimer.c, src/callproc.c, src/coding.c, src/dired.c, src/eval.c:
* src/fringe.c, src/ftcrfont.c, src/ftfont.c, src/ftxfont.c:
* src/gfilenotify.c, src/indent.c, src/kqueue.c, src/menu.c:
* src/scroll.c, src/terminal.c, src/unexcoff.c, src/window.c:
* src/xfont.c, src/xftfont.c:
Do not include stdio.h since it is unused.

5 years agoUse fewer locks when accessing stdio
Paul Eggert [Tue, 9 Jul 2019 00:50:39 +0000 (17:50 -0700)]
Use fewer locks when accessing stdio

* src/alloc.c, src/bidi.c, src/emacs-module.c, src/pdumper.c:
* src/regex-emacs.c, src/unexhp9k800.c, src/unexmacosx.c:
* src/widget.c, src/xdisp.c, src/xselect.c, src/xterm.c:
Include sysstdio.h instead of stdio.h, to avoid locking
stdio streams in many cases.
* src/alloc.c (test_setjmp):
* src/bidi.c (bidi_dump_cached_states):
* src/cm.c (calccost):
* src/dispnew.c (init_display_interactive):
* src/emacs.c (main):
* src/image.c (convert_mono_to_color_image):
* src/minibuf.c (read_minibuf_noninteractive):
* src/nsfont.m (ns_descriptor_to_entity)
(ns_dump_glyphstring):
* src/nsterm.h (NSTRACE_MSG_NO_DASHES):
* src/nsterm.m (ns_mouse_position)
(sendEvent:, keyDown:, performDragOperation:):
* src/pdumper.c (dump_fingerprint, print_paths_to_root_1):
* src/print.c (debug_print):
* src/regex-emacs.c (debug_putchar, print_fastmap)
(print_partial_compiled_pattern, print_compiled_pattern)
(print_double_string, regex_compile):
* src/term.c (vfatal):
* src/unexhp9k800.c (read_header):
* src/unexmacosx.c (unexec_error):
* src/widget.c (EmacsFrameInitialize):
* src/xdisp.c (message_to_stderr, vmessage, dump_glyph_row)
(Fdump_glyph_matrix, Fdump_frame_glyph_matrix, dump_glyph_string):
* src/xfaces.c (Fdump_colors, Fdump_face):
* src/xselect.c (x_clipboard_manager_error_2):
* src/xterm.c (x_initialize):
* src/xwidget.c (WEBKIT_FN_INIT):
Prefer unlocked calls like fputs to locked calls like fprintf.
* src/charset.c (read_hex):
* src/cm.c (cmputc, cmcheckmagic):
* src/dispnew.c (update_frame, update_frame_with_menu)
(update_frame_1, Fsend_string_to_terminal, Fding)
(bitch_at_user):
* src/emacs.c (main, Fdump_emacs):
* src/emacs-module.c (module_abort):
* src/fileio.c (Fdo_auto_save):
* src/image.c (slurp_file)
(png_read_from_file, png_load_body, our_stdio_fill_input_buffer):
* src/keyboard.c (record_char, kbd_buffer_get_event)
(handle_interrupt):
* src/lread.c (readbyte_from_stdio, read1):
* src/minibuf.c (read_minibuf_noninteractive):
* src/print.c (printchar_to_stream, strout)
(Fredirect_debugging_output):
* src/sysdep.c (reset_sys_modes, close_output_streams)
(procfs_ttyname, procfs_get_total_memory):
* src/term.c (tty_ring_bell, tty_send_additional_strings)
(tty_set_terminal_modes, tty_reset_terminal_modes)
(tty_update_end, tty_clear_end_of_line, tty_write_glyphs)
(tty_write_glyphs_with_face, tty_insert_glyphs)
(tty_menu_activate):
* src/xfaces.c (Fx_load_color_file):
Simplify by using ordinary calls like putc to explicitly-unlocked
calls like putc_unlocked, since the ordinary calls are now
unlocked anyway.
* src/emacs.c (main, Fdump_emacs):
* src/pdumper.c (Fdump_emacs_portable):
Coalesce adjacent printfs.
* src/nsterm.h: Include sysstdio.h as this file’s macros rely on it.
* src/regex-emacs.c (print_compiled_pattern):
Omit redundant fflush.
* src/sysstdio.h: Include unlocked-io.h.
(clearerr_unlocked, feof_unlocked, ferror_unlocked)
(fflush_unlocked, fgets_unlocked, fputc_unlocked)
(fputs_unlocked, fread_unlocked, fwrite_unlocked)
(getc_unlocked, getchar_unlocked, putc_unlocked)
(putchar_unlocked): Remove these macros; now done by unlocked-io.h.
* src/xwidget.c: Include sysstdio.h.

5 years agoTidy up sieve.el text formatting
Basil L. Contovounesios [Mon, 8 Jul 2019 20:05:14 +0000 (21:05 +0100)]
Tidy up sieve.el text formatting

* lisp/net/sieve.el (sieve-edit-script, sieve-upload): Do not pass
arbitrary string as first argument to 'message' (bug#25764).
(sieve-help): Split long string across multiple lines.
(sieve-refresh-scriptlist): Use ngettext.  Fix grammar.

5 years agoDelegate to rectangle version in delim-col when appropriate
Stefan Kangas [Mon, 8 Jul 2019 22:50:41 +0000 (00:50 +0200)]
Delegate to rectangle version in delim-col when appropriate

* lisp/delim-col.el (delimit-columns-region): Delegate to
`delimit-columns-rectangle' when called with a rectangular
region (bug#36453).

5 years agoFix minor typo in org-capture-templates
Ismail S [Mon, 8 Jul 2019 20:56:55 +0000 (22:56 +0200)]
Fix minor typo in org-capture-templates

* lisp/org/org-capture.el (org-capture-templates): Fix typo in doc
string (bug#36491).

Copyright-paperwork-exempt: yes

5 years agoEnsure that expand-file-name returns an absolute file name
Ken Brown [Mon, 8 Jul 2019 22:37:33 +0000 (18:37 -0400)]
Ensure that expand-file-name returns an absolute file name

* src/fileio.c (Fexpand_file_name): Don't directly use the current
buffer's default-directory if it is relative.  Instead replace it
by its expansion relative to invocation-directory.  (Bug#36502)
* test/src/fileio-tests.el
(fileio-tests--relative-default-directory): New test.

5 years agoTurn off bytecode jumptables to avoid Bug#36447
Noam Postavsky [Mon, 8 Jul 2019 22:06:21 +0000 (18:06 -0400)]
Turn off bytecode jumptables to avoid Bug#36447

* lisp/emacs-lisp/bytecomp.el (byte-compile-cond-use-jump-table): Set
to nil.  We can turn this back on again when Bug#36447 is solved and
we handle dumped hash tables correctly.

5 years agoRemove mention of :group in define-minor-mode info
Lars Ingebrigtsen [Mon, 8 Jul 2019 20:32:36 +0000 (22:32 +0200)]
Remove mention of :group in define-minor-mode info

* doc/lispref/modes.texi (Defining Minor Modes): The :group stuff
in the example and documentation isn't correct since this is not a
global mode and `hunger-mode' therefore isn't customizable
(bug#36501).