]> git.eshelyaron.com Git - emacs.git/log
emacs.git
3 years agoRemove spurious display-buffer call in eldoc--echo-area-substring scratch/eldoc-display-functions
João Távora [Sun, 4 Oct 2020 23:24:54 +0000 (00:24 +0100)]
Remove spurious display-buffer call in eldoc--echo-area-substring

* lisp/emacs-lisp/eldoc.el (eldoc--echo-area-substring): Remove
spurious display-buffer call.

3 years agoRework semantics of eldoc-echo-are-use-multiline-p
João Távora [Sun, 4 Oct 2020 18:31:02 +0000 (19:31 +0100)]
Rework semantics of eldoc-echo-are-use-multiline-p

* lisp/emacs-lisp/eldoc.el (eldoc-echo-area-use-multiline-p): Rework
semantics.
(eldoc--echo-area-substring): New helper.
(eldoc--echo-area-prefer-doc-buffer-p): New helper.
(eldoc-display-in-echo-area): Rework using new helpers.

3 years agoRename ElDoc user option controlling display of truncation notice
João Távora [Sun, 4 Oct 2020 11:19:47 +0000 (12:19 +0100)]
Rename ElDoc user option controlling display of truncation notice

The new name makes it consistent with other variables controlling the
display of ElDoc documentation in the echo area.

Per bug#43543.

* etc/NEWS (Eldoc): Rename eldoc-display-truncation-message to
eldoc-echo-area-display-truncation-message.

* lisp/emacs-lisp/eldoc.el
(eldoc-echo-area-display-truncation-message): Rename from
eldoc-display-truncation-message.
(eldoc-display-in-echo-area): Use new variable name.

3 years agoRework eldoc-echo-area-prefer-doc-buffer (bug#42532)
João Távora [Sat, 3 Oct 2020 16:27:05 +0000 (17:27 +0100)]
Rework eldoc-echo-area-prefer-doc-buffer (bug#42532)

* lisp/emacs-lisp/eldoc.el:
(eldoc-echo-area-prefer-doc-buffer): Rename from
eldoc-echo-area-prefer-doc-buffer
(eldoc-display-in-echo-area): Rework to honour
eldoc-echo-area-prefer-doc-buffer.

3 years agoIntroduce eldoc-display-functions
João Távora [Sun, 6 Sep 2020 14:37:02 +0000 (15:37 +0100)]
Introduce eldoc-display-functions

See bug#43609

* lisp/emacs-lisp/eldoc.el (eldoc--request-state): Add comment.
(eldoc--last-request-state): No longer buffer-local.
(eldoc--request-docs-p): Delete.
(eldoc-display-functions): New user variable.
(eldoc--doc-buffer-docs): New variable.
(eldoc-display-message-p): Rework.
(eldoc--format-doc-buffer): Rework from eldoc--handle-docs.
(eldoc-display-in-echo-area, eldoc-display-in-buffer): New
user-visible function.
(eldoc--invoke-strategy): Take INTERACTIVE arg.
Invoke eldoc-display-in-buffer
(eldoc-print-current-symbol-info): Simplify.
(Version): Bump to 1.11.0

* etc/NEWS: Mention eldoc-display-functions.

3 years ago; Fix more typos
Stefan Kangas [Fri, 2 Oct 2020 16:02:51 +0000 (18:02 +0200)]
; Fix more typos

3 years ago; Fix trivial typos in ChangeLogs
Stefan Kangas [Fri, 2 Oct 2020 15:56:41 +0000 (17:56 +0200)]
; Fix trivial typos in ChangeLogs

3 years agoEnhance syntax-tests.el to test comments in parse-partial-sexp
Alan Mackenzie [Fri, 2 Oct 2020 21:21:06 +0000 (21:21 +0000)]
Enhance syntax-tests.el to test comments in parse-partial-sexp

This now tests the interface between parse-partial-sexp and the low level
comment function in syntax.c

* test/src/syntax-tests.el (syntax-comments-midpoint): New function.
(syntax-pps-comments): New macro.
(top level): Two new syntax-br-comments tests and five new syntax-pps-comments
tests.

* test/data/syntax-comments.txt (top level): Amend some test fragments and add
some more.

3 years agoCalc: fix formatting and parsing Unix time (bug#43759)
Mattias Engdegård [Fri, 2 Oct 2020 16:50:50 +0000 (18:50 +0200)]
Calc: fix formatting and parsing Unix time (bug#43759)

The number of days from epoch to Jan 1, 1970 that was used in parsing
and formatting Unix time was incorrect.  The previous fix
(in e368697ce36) was incomplete.

Reported by Vincent Belaïche.

* lisp/calc/calc-forms.el (math-unix-epoch): New constant.
(math-format-date-part, math-parse-standard-date, calcFunc-unixtime):
Use math-unix-epoch instead of a constant that is sometimes wrong.
* test/lisp/calc/calc-tests.el (calc-unix-date): New test.

3 years agoEnhance syntax-tests.el to test comments in scan-lists
Alan Mackenzie [Fri, 2 Oct 2020 17:25:02 +0000 (17:25 +0000)]
Enhance syntax-tests.el to test comments in scan-lists

This now tests the interface between scan_lists and the comment functions.

* test/src/syntax-tests.el (syntax-br-comments): New macro.
({-in, ;-in, /*-in): Set parse-sexp-ignore-comments to t.
(top level): Add 15 tests for comments inside brace lists.

* test/data/syntax-comments.txt (top level): Amend some test fragments.

3 years ago; Merge from origin/emacs-27
Glenn Morris [Fri, 2 Oct 2020 16:38:24 +0000 (09:38 -0700)]
; Merge from origin/emacs-27

The following commit was skipped:

ef7bc1cc80 (origin/emacs-27) Fix electric-buffer-list buffer selection

3 years agoMerge from origin/emacs-27
Glenn Morris [Fri, 2 Oct 2020 16:38:24 +0000 (09:38 -0700)]
Merge from origin/emacs-27

78eacf31e8 ; Fix many typos in symbols in docs and comments
d5d12707d6 * doc/misc/flymake.texi (Using Flymake): Fix a typo.  (Bug...

# Conflicts:
# lisp/allout.el
# lisp/progmodes/ebrowse.el

3 years ago; Merge from origin/emacs-27
Glenn Morris [Fri, 2 Oct 2020 16:33:53 +0000 (09:33 -0700)]
; Merge from origin/emacs-27

The following commits were skipped:

9b47ae2304 Don't error if no GPG signing key configured
e274e3f44b 2020-03-29  Michael R. Mauger  <michael@mauger.com>

3 years agoMerge from origin/emacs-27
Glenn Morris [Fri, 2 Oct 2020 16:33:53 +0000 (09:33 -0700)]
Merge from origin/emacs-27

41dcbeccf3 Make aliases introduced in previous patch obsolete
4997032c05 Restore some public debugging functions removed in Emacs 27

3 years ago; Merge from origin/emacs-27
Glenn Morris [Fri, 2 Oct 2020 16:33:53 +0000 (09:33 -0700)]
; Merge from origin/emacs-27

The following commit was skipped:

08bda922b4 (emacs-27) ; Auto-commit of loaddefs files.

3 years agoMerge from origin/emacs-27
Glenn Morris [Fri, 2 Oct 2020 16:33:53 +0000 (09:33 -0700)]
Merge from origin/emacs-27

2af6b3147d Clarification in Tramp manual
8fbaca7d41 Check Emacs version used for Tramp compilation
90e5549f02 Don't signal an error when saving files on WdebDAV volumes
6f73cc3579 ; * lisp/net/eww.el (eww-search-words): Doc fix.
ce0842a165 * lisp/hi-lock.el (hi-lock-find-patterns): Autoload it.  (...

3 years agoFix electric-buffer-list buffer selection
Lars Ingebrigtsen [Fri, 2 Oct 2020 06:07:53 +0000 (08:07 +0200)]
Fix electric-buffer-list buffer selection

* lisp/ebuff-menu.el (electric-buffer-list): Ensure that point is
restored, which isn't always the case if
global-display-line-numbers-mode (bug#43755).  This enables
selecting buffers again.

3 years ago; Fix many typos in symbols in docs and comments
Stefan Kangas [Wed, 23 Sep 2020 11:35:55 +0000 (13:35 +0200)]
; Fix many typos in symbols in docs and comments

3 years ago* doc/misc/flymake.texi (Using Flymake): Fix a typo. (Bug#43758)
Eli Zaretskii [Fri, 2 Oct 2020 10:57:51 +0000 (13:57 +0300)]
* doc/misc/flymake.texi (Using Flymake): Fix a typo.  (Bug#43758)

3 years agoCC Mode: Convert the handling of c-special-indent-hook to standard usage
Stefan Monnier [Fri, 2 Oct 2020 10:34:37 +0000 (10:34 +0000)]
CC Mode: Convert the handling of c-special-indent-hook to standard usage

* lisp/progmodes/cc-styles.el (c-set-style): Use kill-local-variable rather
than copying the hook's global value to the local binding.
(c-make-styles-buffer-local): Remove redundant make-variable-buffer-local.

3 years agoDon't error if no GPG signing key configured
Robert Pluim [Fri, 2 Oct 2020 08:47:06 +0000 (10:47 +0200)]
Don't error if no GPG signing key configured

* lisp/gnus/mml-sec.el (mml-secure-epg-sign): Partially revert
"Make mml-secure-epg-sign bug out if we can't find an identity".
It causes signing to fail for people who have not set up
mml-secure-{smime,openpgp}-sign-with-sender, which is a regression
from Emacs-26 (Bug#40118).  In such a situation gpg will use its
default key.

Do not merge to master. On master Emacs will query the user.

3 years agoCalc: fix business days calculation (bug43677)
Mattias Engdegård [Wed, 30 Sep 2020 21:57:27 +0000 (23:57 +0200)]
Calc: fix business days calculation (bug43677)

The calculation of business days was broken in 2012 (probably
310e60d9454fe2 or thereabouts) when the date representation changed
epoch so that Jan 1, 1 AD became day number 1 instead of 0.  Repair
this, along with an unrelated bug that prevented arbitrary holiday
weekdays from working.

Reported by Aaron Zeng.

* lisp/calc/calc-forms.el (math-to-business-day)
(math-from-business-day): Correct calculation of weekdays using Calc's
current (Rata Die) chronology.  Modify loop condition to cope with odd
sets of holiday weekdays.
* test/lisp/calc/calc-tests.el (calc-business-days): New test.

3 years agoFix electric-buffer-list buffer selection
Lars Ingebrigtsen [Fri, 2 Oct 2020 06:07:53 +0000 (08:07 +0200)]
Fix electric-buffer-list buffer selection

* lisp/ebuff-menu.el (electric-buffer-list): Ensure that point is
restored, which isn't always the case if
global-display-line-numbers-mode (bug#43755).  This enables
selecting buffers again.

3 years agoMake xref work better on variables in shell-script-mode
Dmitry Gutov [Fri, 2 Oct 2020 05:11:56 +0000 (07:11 +0200)]
Make xref work better on variables in shell-script-mode

* lisp/progmodes/sh-script.el (sh-mode-syntax-table): Classify "/"
as punctuation so that `M-.' on $foo/bar works on the $foo part
(bug#25585).

3 years agoMake `C-c C-e' in Python buffers work
Lars Ingebrigtsen [Fri, 2 Oct 2020 03:30:37 +0000 (05:30 +0200)]
Make `C-c C-e' in Python buffers work

* lisp/progmodes/python.el (python-shell-send-statement): Don't
send a cookie, because that leads to the naked expression not
being evaled (bug#43450).
(python-shell-send-region): Allow not sending a cookie.
(python-shell-buffer-substring): Ditto.

3 years agopython-shell-send-defun doesn't find the (whole) definition
Per Starbäck [Fri, 2 Oct 2020 03:11:06 +0000 (05:11 +0200)]
python-shell-send-defun doesn't find the (whole) definition

* lisp/progmodes/python.el (python-shell-send-defun): Fix C-M-x
for definitions like @property\ndef bar(): (bug#37828).

3 years agoMake setting verify-hostname-error not make connections fail
Robert Pluim [Fri, 2 Oct 2020 02:49:39 +0000 (04:49 +0200)]
Make setting verify-hostname-error not make connections fail

* lisp/net/gnutls.el (gnutls-boot-parameters): If
verify-hostname-error was set, this would make verify-error a
non-proper list (bug#38602).

3 years agoStop using a dynamically bound 'generated-autoload-file' variable
Lars Ingebrigtsen [Fri, 2 Oct 2020 02:34:31 +0000 (04:34 +0200)]
Stop using a dynamically bound 'generated-autoload-file' variable

* doc/lispref/loading.texi (Autoload): Document change of name
(bug#39823).

* lisp/emacs-lisp/autoload.el (autoload-find-generated-file): Pass
the file name in.
(autoload-generated-file): Ditto.
(autoload-file-load-name): Ditto.
(generate-file-autoloads): Ditto.
(autoload--setup-output): Ditto.
(autoload-generate-file-autoloads): Ditto, and alter doc string to
reflect when `generated-autoload-file' is heeded.
(update-file-autoloads): Pass outfile in to functions.
(autoload-find-destination): Ditto.
(update-directory-autoloads): Make into an obsolete shim around
`make-directory-autoloads'.
(make-directory-autoloads): Renamed from
`update-directory-autoloads' with new semantics.
(batch-update-autoloads): Adjust caller.

* lisp/emacs-lisp/package.el (package-generate-autoloads): Adjust
caller.

3 years agoFix --with-json message
Shohei YOSHIDA [Fri, 2 Oct 2020 01:14:31 +0000 (03:14 +0200)]
Fix --with-json message

* configure.ac (WIDE_EMACS_INT): Fix --with-json help message
(bug#43754).

3 years agoFix check for derived modes in display-buffer-reuse-mode-window
Trevor Murphy [Thu, 1 Oct 2020 22:30:19 +0000 (00:30 +0200)]
Fix check for derived modes in display-buffer-reuse-mode-window

* lisp/window.el (display-buffer-reuse-mode-window): Make the
check for derived modes actually work (bug#38677).

3 years agoFix wdired-do-perm-changes when over Tramp
Tino Calancha [Thu, 1 Oct 2020 21:33:56 +0000 (23:33 +0200)]
Fix wdired-do-perm-changes when over Tramp

* lisp/wdired.el (wdired-do-perm-changes) Use set-file-modes
instead of external program (bug#39284).  This fixes the problem
of passing the wrong argument to the external chmod.

3 years agoFix bug in wdired-get-filename
Tino Calancha [Thu, 1 Oct 2020 21:25:15 +0000 (23:25 +0200)]
Fix bug in wdired-get-filename

* lisp/wdired.el (wdired-get-filename): Acknowledge the first
argument (bug#39280).
* test/lisp/wdired-tests.el (wdired-test-bug39280): Add test.

3 years agoEnhance syntax-tests.el to test some comment character handling.
Alan Mackenzie [Thu, 1 Oct 2020 20:35:40 +0000 (20:35 +0000)]
Enhance syntax-tests.el to test some comment character handling.

* test/src/syntax-tests: Add a new section testing some aspects of comment
  handling in syntax.c.  This needs further enhancement.  It uses ....

* test/data/syntax-comments.txt: A new test file.

3 years agoUse new faces isearch-group-odd and isearch-group-even (bug#43702)
Juri Linkov [Thu, 1 Oct 2020 19:17:40 +0000 (22:17 +0300)]
Use new faces isearch-group-odd and isearch-group-even (bug#43702)

* lisp/isearch.el (isearch-group-odd, isearch-group-even): New faces
instead of isearch-group-1 .. isearch-group-9.
(isearch-highlight): Use new faces.

3 years agoMake recentf daily cleanup repeat
Allen Li [Thu, 1 Oct 2020 18:53:27 +0000 (20:53 +0200)]
Make recentf daily cleanup repeat

* lisp/recentf.el (recentf-auto-cleanup): Fix wording.
* lisp/recentf.el (recentf-auto-cleanup): Make timer repeat,
update docstring.
* etc/NEWS: Update news (bug#39638).

3 years ago2020-03-29 Michael R. Mauger <michael@mauger.com>
Michael R. Mauger [Mon, 30 Mar 2020 00:52:10 +0000 (20:52 -0400)]
2020-03-29  Michael R. Mauger  <michael@mauger.com>

       * lisp/progmodes/sql.el (sql-add-product): Re-correct argument
       spec.  Previous change was due to my mistake; I have
       resolved back to the prior behavior (Bug#39960).
       * test/lisp/progmodes/sql-tests.el (sql-test-add-product): Added
       test to insure I don't make the same mistake again.

3 years agocommand-execute doc string clarification
Boruch Baum [Thu, 1 Oct 2020 18:26:13 +0000 (20:26 +0200)]
command-execute doc string clarification

* lisp/simple.el (command-execute): Doc string clarification
(bug#43749).

3 years agoMake aliases introduced in previous patch obsolete
Lars Ingebrigtsen [Thu, 1 Oct 2020 18:03:58 +0000 (20:03 +0200)]
Make aliases introduced in previous patch obsolete

* lisp/emacs-lisp/debug.el (debugger-toggle-locals):
(debug-help-follow): Make reinstated aliases obsolete.

3 years agoRestore some public debugging functions removed in Emacs 27
Gemini Lasswell [Thu, 1 Oct 2020 17:59:58 +0000 (19:59 +0200)]
Restore some public debugging functions removed in Emacs 27

* lisp/emacs-lisp/backtrace.el (backtrace--to-string): New function.
(backtrace-to-string): Use it.  Fix whitespace (bug#40728).
* lisp/emacs-lisp/debug.el (debugger-insert-backtrace): New function.
Mark it as obsolete.
(debugger-toggle-locals, debug-help-follow): New aliases.

3 years agoFix loading WSDL data again
Lars Ingebrigtsen [Thu, 1 Oct 2020 17:42:45 +0000 (19:42 +0200)]
Fix loading WSDL data again

* lisp/net/soap-client.el (soap-make-wsdl): Change the WSDL
namespace back again.

3 years agoFix restoring data in visual-line-mode
Lars Ingebrigtsen [Thu, 1 Oct 2020 16:49:45 +0000 (18:49 +0200)]
Fix restoring data in visual-line-mode

* lisp/simple.el (visual-line-mode): Only save values once, even
if the mode is switched on twice (bug#43730).  This makes both
previously set local values for variables like truncate-lines, as
well as default values for truncate-lines restorable.

* lisp/emulation/cua-base.el (cua-mode): Ditto.

3 years agoSilence byte-compiler in two tests
Stefan Kangas [Thu, 1 Oct 2020 13:34:08 +0000 (15:34 +0200)]
Silence byte-compiler in two tests

* test/lisp/obsolete/cl-tests.el (require):
* test/lisp/simple-tests.el (simple-test-count-words-bug-41761):
Silence byte-compiler.

3 years ago; Prefer https to http in many URLs
Stefan Kangas [Thu, 1 Oct 2020 13:24:21 +0000 (15:24 +0200)]
; Prefer https to http in many URLs

These were all tested with https and confirmed working.

3 years agoRemove some obsolete URLs
Stefan Kangas [Thu, 1 Oct 2020 13:18:43 +0000 (15:18 +0200)]
Remove some obsolete URLs

* lisp/net/newst-backend.el (newsticker--raw-url-list-defaults):
Remove some obsolete URLs.

3 years agoDon't quote lambdas in several places
Stefan Kangas [Wed, 30 Sep 2020 14:18:50 +0000 (16:18 +0200)]
Don't quote lambdas in several places

* admin/find-gc.el (find-gc-unsafe):
* lisp/align.el (align-rules-list):
* lisp/comint.el (comint-arguments):
* lisp/double.el (isearch-mode-map):
* lisp/ehelp.el (electric-help-command-loop):
* lisp/emacs-lisp/cl-macs.el (cl-defstruct):
* lisp/emulation/cua-rect.el (cua--copy-rectangle-as-kill)
(cua-copy-rectangle-as-text):
* lisp/eshell/esh-var.el (eshell-parse-variable-ref):
* lisp/hexl.el (hexl-insert-multibyte-char):
* lisp/international/titdic-cnv.el (tsang-quick-converter)
(ziranma-converter):
* lisp/language/tibet-util.el (tibetan-decompose-precomposition-alist):
* lisp/mail/mailalias.el (mail-get-names):
* lisp/mh-e/mh-e.el (mh-auto-fields-list, mh-identity-default):
* lisp/mouse.el (mouse-buffer-menu-map, mouse-buffer-menu-alist):
* lisp/play/gametree.el (gametree-make-heading-function):
* lisp/shell.el (shell--command-completion-data):
* lisp/talk.el (talk-update-buffers):
* lisp/tempo.el (tempo-insert-template, tempo-is-user-element)
(tempo-build-collection):
* lisp/term.el (term-input-filter, term-pager-help):
* lisp/textmodes/table.el (table-delete-column):
* lisp/url/url-cache.el (url-cache-create-filename-human-readable):
* lisp/textmodes/tex-mode.el (latex-imenu-create-index): Don't quote
lambdas.

3 years agoDon't recommend quoting lambdas
Stefan Kangas [Wed, 30 Sep 2020 14:02:22 +0000 (16:02 +0200)]
Don't recommend quoting lambdas

* doc/misc/calc.texi (Symbolic Lisp Functions):
* doc/misc/cl.texi (Obsolete Lexical Binding):
* lisp/master.el:
* lisp/progmodes/sql.el (sql-interactive-mode):
* lisp/textmodes/flyspell.el (flyspell-mode):
* lisp/textmodes/ispell.el (ispell-message):
* lisp/textmodes/table.el: Doc fixes; don't recommend quoting
lambdas.

3 years ago; Auto-commit of loaddefs files.
Glenn Morris [Thu, 1 Oct 2020 13:27:29 +0000 (06:27 -0700)]
; Auto-commit of loaddefs files.

3 years ago; Auto-commit of loaddefs files.
Glenn Morris [Thu, 1 Oct 2020 13:11:26 +0000 (06:11 -0700)]
; Auto-commit of loaddefs files.

3 years agoClarification in Tramp manual
Michael Albinus [Thu, 1 Oct 2020 12:23:20 +0000 (14:23 +0200)]
Clarification in Tramp manual

* doc/misc/tramp.texi: Harmonize "Git" spelling.
(Frequently Asked Questions): Describe Emacs version mismatch.

3 years agoCheck Emacs version used for Tramp compilation
Michael Albinus [Thu, 1 Oct 2020 10:16:59 +0000 (12:16 +0200)]
Check Emacs version used for Tramp compilation

* lisp/net/tramp-compat.el (tramp-compat-emacs-compiled-version):
New defconst.  Raise a warning, when it is not equal to the Emacs
version.

3 years agoUse Fkeywordp in dbusbind.c, again
Michael Albinus [Thu, 1 Oct 2020 09:20:38 +0000 (11:20 +0200)]
Use Fkeywordp in dbusbind.c, again

* src/dbusbind.c (XD_KEYWORDP): New macro.
(XD_DBUS_TYPE_P, Fdbus__init_bus, xd_read_queued_messages): Use it.

3 years agoRevert last change in dbusbind.c
Michael Albinus [Thu, 1 Oct 2020 08:32:50 +0000 (10:32 +0200)]
Revert last change in dbusbind.c

* src/dbusbind.c (XD_DBUS_TYPE_P, Fdbus__init_bus)
(xd_read_queued_messages): Revert last change.  (Bug#43724)

3 years agoRemove mml-sec-test that assumes the first signature
Lars Ingebrigtsen [Thu, 1 Oct 2020 03:19:49 +0000 (05:19 +0200)]
Remove mml-sec-test that assumes the first signature

This is no longer supported; the user is asked for what signature to
use.

3 years agoMake mml-sec-tests not hang waiting for input
Lars Ingebrigtsen [Thu, 1 Oct 2020 03:17:01 +0000 (05:17 +0200)]
Make mml-sec-tests not hang waiting for input

* lisp/gnus/mml-sec.el (mml-secure-epg-sign): Only query if we're
running interactively.  This makes a test not hang.

3 years agoDon't optimize away star patterns in minibuffer file name completion
Pip Cet [Thu, 1 Oct 2020 03:06:41 +0000 (05:06 +0200)]
Don't optimize away star patterns in minibuffer file name completion

* lisp/minibuffer.el (completion-pcm--optimize-pattern): Keep
'star in the pattern (bug#41705).

3 years agoFix the end-of-query prompt in multi-occur and multi-isearch when fido
Lars Ingebrigtsen [Thu, 1 Oct 2020 01:01:33 +0000 (03:01 +0200)]
Fix the end-of-query prompt in multi-occur and multi-isearch when fido

* lisp/misearch.el (multi-isearch-read-buffers): Ditto.

* lisp/replace.el (multi-occur--prompt): New function (bug#41633).
(multi-occur): Use it.

3 years agoMake gnus-base64-repad a bit stricter again
Alex Bochannek [Thu, 1 Oct 2020 00:44:58 +0000 (02:44 +0200)]
Make gnus-base64-repad a bit stricter again

* lisp/gnus/gnus-util.el (gnus-base64-repad): Make the code a bit
stricter again.

3 years agoQuery for the signer when sending signed mail (with unknown signer)
Robert Pluim [Thu, 1 Oct 2020 00:14:17 +0000 (02:14 +0200)]
Query for the signer when sending signed mail (with unknown signer)

* lisp/gnus/mml-sec.el (mml-secure-sender-sign-query): New
function (bug#40118).
(mml-secure-epg-sign): Use it to determine the signer (bug#40118).

* lisp/gnus/mml-sec.el
(mml-secure-allow-signing-with-unknown-recipient): Remove.

3 years agoFix segfault in some cases when restoring a selected window
martin rudalics [Thu, 1 Oct 2020 00:00:06 +0000 (02:00 +0200)]
Fix segfault in some cases when restoring a selected window

* src/xdisp.c (restore_selected_window): Fix the more grave
problems caused by a function deleting the previously selected
frame or window (bug#39977).

3 years agoSplit auto-revert-buffers into several functions
Boruch Baum [Wed, 30 Sep 2020 23:53:30 +0000 (01:53 +0200)]
Split auto-revert-buffers into several functions

* lisp/autorevert.el (auto-revert--buffer-candidates)
(auto-revert-buffer): Refactor out...
(auto-revert-buffers): ... from here.

3 years agoFix up previous window excursion patch in epa--select-keys
Lars Ingebrigtsen [Wed, 30 Sep 2020 23:44:05 +0000 (01:44 +0200)]
Fix up previous window excursion patch in epa--select-keys

* lisp/epa.el (epa--select-keys): Use save-window-excursion
instead of open-coding the macro.

3 years ago* lisp/term.el: Make C-/ undo in a nested Emacs subprocess
Stefan Monnier [Wed, 30 Sep 2020 23:17:26 +0000 (19:17 -0400)]
* lisp/term.el: Make C-/ undo in a nested Emacs subprocess

(term-send-C-_): New function.
(term-raw-map): Use it for `C-/`, as is done in xterm and friends.

3 years ago* doc/emacs/basic.texi (Basic Undo): Explain the C-/ situation in xterm
Stefan Monnier [Wed, 30 Sep 2020 23:08:47 +0000 (19:08 -0400)]
* doc/emacs/basic.texi (Basic Undo): Explain the C-/ situation in xterm

AFAICT, in ttys you can send a `C-_` to Emacs either by pressing
`C-/` (e.g. xterm, uxterm, rxvt, xfce4-terminal, gnome-terminal)
or by pressing `C--` (e.g. rxvt, Linux console).

3 years agoWhen recipient has no public key, make offer to skip it optional.
Richard M Stallman [Wed, 30 Sep 2020 22:44:42 +0000 (18:44 -0400)]
When recipient has no public key, make offer to skip it optional.

* epa-mail.el (epa-mail-offer-skip): New option.
(epa-mail-encrypt): If epa-mail-offer-skip is nil,
don't offer to skip a keyless recipient, just cause error.

3 years agoClarify previous undo keys change
Richard M Stallman [Wed, 30 Sep 2020 22:15:43 +0000 (18:15 -0400)]
Clarify previous undo keys change

Clarify which terminals allow C-/ and which make C-_ easy to type.

3 years agoFurther doc fixes for dotimes about RESULT
Lars Ingebrigtsen [Wed, 30 Sep 2020 18:29:16 +0000 (20:29 +0200)]
Further doc fixes for dotimes about RESULT

* lisp/subr.el (dotimes): Be even more explicit about RESULT
(bug#16206).

3 years agoMinor documentation copyedits
Eli Zaretskii [Wed, 30 Sep 2020 16:38:55 +0000 (19:38 +0300)]
Minor documentation copyedits

* etc/NEWS:
* doc/emacs/dired.texi (Dired Enter): Fix wording, punctuation,
and typos in doc of 'dired-switches-in-mode-line'.

3 years agoFix problem with parsing . as a symbol in bovine
Vladimir Nikishkin [Wed, 30 Sep 2020 16:32:32 +0000 (18:32 +0200)]
Fix problem with parsing . as a symbol in bovine

* lisp/cedet/semantic/bovine/scm.el (semantic-lex-scheme-symbol):
Symbols do not have to start with a word-constituent character
(bug#40034).  In particular, symbols like : and . are valid.

Copyright-paperwork-exempt: yes

3 years agoAllow controlling the Dired switches shown in the mode line
Drew Adams [Wed, 30 Sep 2020 15:59:59 +0000 (17:59 +0200)]
Allow controlling the Dired switches shown in the mode line

* doc/emacs/dired.texi (Dired Enter): Document it (bug#41250).

* lisp/dired.el (dired-switches-in-mode-line): New variable (bug#41250).
(dired-sort-set-mode-line): Use it.

3 years agoFix problem of having the wrong window selected after saving foo.gpg
Lars Ingebrigtsen [Wed, 30 Sep 2020 15:36:39 +0000 (17:36 +0200)]
Fix problem of having the wrong window selected after saving foo.gpg

* lisp/epa.el (epa--select-keys): Restore the window configuration
after selecting the key to use (bug#43703).  This also ensures
that the buffer we were editing ends up as the current buffer
after saving it, instead of selecting a different window.

3 years agoFix 'move-to-column' when invisible text follows a TAB
Eli Zaretskii [Wed, 30 Sep 2020 14:33:58 +0000 (17:33 +0300)]
Fix 'move-to-column' when invisible text follows a TAB

* src/indent.c (scan_for_column): Accept 2 more arguments, and
report through them the position corresponding to PREVCOL.  All
callers changed.
(Fmove_to_column): Use the prev_col's position to test for a TAB
instead of assuming that the TAB is just before point (which is
false when there's invisible text around).  (Bug#43587)

* test/src/indent-tests.el: New file.

3 years agoClarify the "Forgot to expand macro" message
Lars Ingebrigtsen [Wed, 30 Sep 2020 14:12:27 +0000 (16:12 +0200)]
Clarify the "Forgot to expand macro" message

* lisp/emacs-lisp/bytecomp.el (byte-compile-form): Make the
define-after-use warning for macros clearer (bug#43678).

3 years agoMinor fixes of recent changes
Eli Zaretskii [Wed, 30 Sep 2020 13:56:08 +0000 (16:56 +0300)]
Minor fixes of recent changes

* lisp/emacs-lisp/generic.el (define-generic-mode): Fix typos.

* etc/NEWS: Adjust an entry due to recent changes.

3 years agoStricter checks for D-Bus compound types.
Michael Albinus [Wed, 30 Sep 2020 13:28:53 +0000 (15:28 +0200)]
Stricter checks for D-Bus compound types.

* src/dbusbind.c (XD_DBUS_TYPE_P, Fdbus__init_bus)
(xd_read_queued_messages): Use Fkeywordp instead of SYMBOLP.
(xd_signature): Stricter checks for compound types.

* test/lisp/net/dbus-tests.el (dbus-test01-compound-types): Extend test.

3 years agoMinor code cleanup in dbus-tests.el
Michael Albinus [Wed, 30 Sep 2020 10:40:08 +0000 (12:40 +0200)]
Minor code cleanup in dbus-tests.el

* test/lisp/net/dbus-tests.el (dbus--tests-dir): Make it a defconst.
(dbus--test-method-reentry-handler): Mark args as unused.
(dbus-test04-method-reentry): Tag it :expensive-test.  Fix typo.
(dbus-test06-property-types): Remove duplicate test.
(dbus--test-introspect): Use `insert-file-contents-literally'.
(dbus--test-validate-property): Mark expected-annotations as unused.
(dbus--test-validate-m-or-s): Remove superfluous le-clause.

3 years agoAdd D-Bus method-call reentrant test
Hugh Daschbach [Wed, 30 Sep 2020 09:27:22 +0000 (11:27 +0200)]
Add D-Bus method-call reentrant test

* test/lisp/net/dbus-tests.el (dbus--tests-method-reentry-handler):
New defun.
(dbus-test04-method-reentry): New test.  (Bug#43251)

3 years ago* test/lisp/net/dbus-tests.el: Add timeout tests.
Hugh Daschbach [Wed, 30 Sep 2020 09:23:24 +0000 (11:23 +0200)]
* test/lisp/net/dbus-tests.el: Add timeout tests.

(dbus-test04-call-method-timeout, dbus-test07-introspection-timeout):
New tests.

3 years agoAdd D-Bus introspection tests
Hugh Daschbach [Wed, 30 Sep 2020 09:19:41 +0000 (11:19 +0200)]
Add D-Bus introspection tests

* lisp/net/dbus.el (dbus-annotation-deprecated): New defconst.

* test/lisp/net/dbus-tests.el  (dbus--tests-dir): New defvar.
(dbus--test-introspect, dbus--test-validate-interface)
(dbus--test-validate-annotations, dbus--test-validate-property)
(dbus--test-validate-m-or-s, dbus--test-validate-signal)
(dbus--test-validate-method): New defuns.
(dbus-test07-introspection): New test.

* test/lisp/net/dbus-resources/org.gnu.Emacs.TestDBus.xml:
New test data.

3 years ago* test/lisp/net/dbus-tests.el: Add property tests. (Bug#43252)
Hugh Daschbach [Wed, 30 Sep 2020 09:09:17 +0000 (11:09 +0200)]
* test/lisp/net/dbus-tests.el: Add property tests.  (Bug#43252)

(dbus--test-run-property-test, dbus--test-property): New defuns.
(dbus-test06-property-types): New test for property registration,
set, get.

3 years agoDon't have C-x = bug out in a "C" locale with non-ASCII chars
Stefan Monnier [Wed, 30 Sep 2020 03:43:07 +0000 (05:43 +0200)]
Don't have C-x = bug out in a "C" locale with non-ASCII chars

* lisp/simple.el (what-cursor-position): Ensure that we always
have a coding system here, even if the locale is "C" (bug#40702).

3 years agoFix whitespace regexp in gnus-base64-repad
Lars Ingebrigtsen [Wed, 30 Sep 2020 03:05:04 +0000 (05:05 +0200)]
Fix whitespace regexp in gnus-base64-repad

* lisp/gnus/gnus-util.el (gnus-base64-repad): Fix the whitespace
regexp.

3 years agoFix gnus-base64-repad test failures
Lars Ingebrigtsen [Wed, 30 Sep 2020 03:03:35 +0000 (05:03 +0200)]
Fix gnus-base64-repad test failures

3 years ago* lisp/emacs-lisp/cl-macs.el (hash-table): Define the type's typep test
Stefan Monnier [Wed, 30 Sep 2020 02:28:23 +0000 (22:28 -0400)]
* lisp/emacs-lisp/cl-macs.el (hash-table): Define the type's typep test

3 years agoFix isearch-group-* colours on low-colour displays
Lars Ingebrigtsen [Wed, 30 Sep 2020 02:06:28 +0000 (04:06 +0200)]
Fix isearch-group-* colours on low-colour displays

* lisp/isearch.el (isearch-group-1): On low-colour displays, just
use the normal isearch colour (bug#43702).
(isearch-group-2 etc): Ditto.

3 years agodefine-generic-mode doc string fix
Lars Ingebrigtsen [Wed, 30 Sep 2020 01:52:18 +0000 (03:52 +0200)]
define-generic-mode doc string fix

* lisp/emacs-lisp/generic.el (define-generic-mode): Say what a
generic mode is (bug#43713).

3 years agoGive better error feedback on wrong password in .gpg files
Lars Ingebrigtsen [Wed, 30 Sep 2020 01:47:47 +0000 (03:47 +0200)]
Give better error feedback on wrong password in .gpg files

* lisp/epa-file.el (epa-file--find-file-not-found-function): Do a
user-error when there's a wrong password (bug#43704).
(epa--wrong-password-p): New function.
(epa-file-insert-file-contents): Use it, and stash the error away
for later signalling.

* lisp/emacs-lisp/subr-x.el (if-let): Autoload.

3 years agosoap-client: Bump version to 3.2.0
Thomas Fitzsimmons [Tue, 29 Sep 2020 21:33:21 +0000 (17:33 -0400)]
soap-client: Bump version to 3.2.0

* lisp/net/soap-client.el: Bump version to 3.2.0.

3 years agosoap-client: Remove FIXME comment
Thomas Fitzsimmons [Tue, 29 Sep 2020 21:30:04 +0000 (17:30 -0400)]
soap-client: Remove FIXME comment

* lisp/net/soap-client.el (soap-encode-attributes): Remove
cl-defmethod FIXME comment; continue supporting Emacs 24.1.

3 years agosoap-client: Update soap-decode-date-time
Thomas Fitzsimmons [Tue, 29 Sep 2020 21:15:40 +0000 (17:15 -0400)]
soap-client: Update soap-decode-date-time

* lisp/net/soap-client.el (soap-decode-date-time): Add support for
Emacs versions that support fractional seconds.  Make DATATYPE
optional.  Remove FIXME comment.

Co-authored-by: Paul Eggert <eggert@cs.ucla.edu>
3 years agoMore strict D-Bus type checking
Michael Albinus [Tue, 29 Sep 2020 17:43:02 +0000 (19:43 +0200)]
More strict D-Bus type checking

* lisp/net/dbus.el (dbus-register-monitor): Register proper key.
(dbus-monitor-handler): Adapt docstring.  Use grave text-quoting-style.

* src/dbusbind.c (xd_signature, xd_append_arg): More strict tests.
(syms_of_dbusbind): Adapt docstring.

* test/lisp/net/dbus-tests.el (dbus-test01-basic-types): Extend test.

3 years agoDon't signal an error when saving files on WdebDAV volumes
Eli Zaretskii [Tue, 29 Sep 2020 15:21:23 +0000 (18:21 +0300)]
Don't signal an error when saving files on WdebDAV volumes

* src/w32.c (acl_get_file): If get_file_security raises the
ERROR_ACCESS_DENIED error, treat that like unsupported ACLs.

3 years ago; * lisp/net/eww.el (eww-search-words): Doc fix.
Eli Zaretskii [Tue, 29 Sep 2020 15:07:44 +0000 (18:07 +0300)]
; * lisp/net/eww.el (eww-search-words): Doc fix.

3 years agoFix emacsclient -c foo.txt behaviour with many frames
Lars Ingebrigtsen [Tue, 29 Sep 2020 14:21:17 +0000 (16:21 +0200)]
Fix emacsclient -c foo.txt behaviour with many frames

* lisp/server.el (server-execute): Pass in whether we opened a new
frame or not (bug#43645).
(server-switch-buffer): Use this to switch to the requested buffer
in the new frame if we have "emacsclient -c foo.txt", and retain
the old behaviour if it's "emacsclient foo.txt".

3 years agoMake M-x compile skip the header when looking for errors etc
Lars Ingebrigtsen [Tue, 29 Sep 2020 13:59:50 +0000 (15:59 +0200)]
Make M-x compile skip the header when looking for errors etc

* lisp/progmodes/compile.el (compilation--ensure-parse): Skip the
header when parsing (bug#43651).
(compilation-start): Mark the end.

3 years agoFix space parsing in gnus-base64-repad
Lars Ingebrigtsen [Tue, 29 Sep 2020 13:36:46 +0000 (15:36 +0200)]
Fix space parsing in gnus-base64-repad

* lisp/gnus/gnus-util.el (gnus-base64-repad): Get the separator
regexp right -- there will often be spaces around the newlines.

3 years ago* lisp/gnus/smime.el (smime-openssl-program): Allow nil value.
Mattias Engdegård [Tue, 29 Sep 2020 10:33:50 +0000 (12:33 +0200)]
* lisp/gnus/smime.el (smime-openssl-program): Allow nil value.

3 years agoFix custom-tests with non-GNU grep
Mattias Engdegård [Tue, 29 Sep 2020 09:24:38 +0000 (11:24 +0200)]
Fix custom-tests with non-GNU grep

* admin/cus-test.el (cus-test-get-lisp-files): Add path argument required
by standard grep (BSD, for instance).

3 years ago* src/eval.c (Fapply): Simplify last change
Stefan Monnier [Tue, 29 Sep 2020 03:14:03 +0000 (23:14 -0400)]
* src/eval.c (Fapply): Simplify last change

3 years agoImprove D-Bus monitor
Michael Albinus [Mon, 28 Sep 2020 12:47:46 +0000 (14:47 +0200)]
Improve D-Bus monitor

* lisp/net/dbus.el (dbus-monitor-method-call)
(dbus-monitor-method-return, dbus-monitor-error)
(dbus-monitor-signal): New defconsts.
(dbus-monitor-goto-serial): New defun.
(dbus-monitor-handler): Use them.  Add timestamp.  Make also links
between D-Bus messages with the same serial.

3 years agoSuggest region contents in highlight-regexp when region active
Earl [Mon, 28 Sep 2020 12:16:22 +0000 (14:16 +0200)]
Suggest region contents in highlight-regexp when region active

* lisp/hi-lock.el (hi-lock-face-buffer): Use the region in the
prompt if the region is active in transient-mark-mode (bug#43641).