]> git.eshelyaron.com Git - emacs.git/log
emacs.git
4 years agoDon't call Ffuncall directly from exec_byte_code feature/zach-soc-funcall-from-bytecode
Zach Shaftel [Thu, 18 Jun 2020 05:09:31 +0000 (01:09 -0400)]
Don't call Ffuncall directly from exec_byte_code

* src/bytecode.c (exec_byte_code): Do a good chunk of Ffuncall's
work in the Bcall ops, so Ffuncall no longer needs to be called. As
it stands, it's an ugly clone of the contents of Ffuncall (and
some of funcall_lambda). Work in progress.

* src/eval.c (record_in_backtrace_with_offset): New function. Like
record_in_backtrace but accepts the bytecode offset and stores it
in the pertinent backtrace frame.
(record_in_backtrace): Don't record the offset.
(funcall_lambda): Remove unnecessary SYMBOLP check.

* src/lisp.h (funcall_lambda, do_debug_on_call)
(record_in_backtrace_with_offset , backtrace_debug_on_exit):
Declare.

4 years agoRevert "Store bytecode offset within exec_byte_code"
Zach Shaftel [Sun, 14 Jun 2020 21:20:48 +0000 (17:20 -0400)]
Revert "Store bytecode offset within exec_byte_code"

This reverts commit f6ec28d7974785b625e395d57cb18d1f2110fe4c.

This commit was just a terrible idea. Caused segfaults, violated the
comment in lisp.h that only eval.c should access `union specbinding`,
and didn't even improve performance.

4 years agoStore bytecode offset within exec_byte_code
Zach Shaftel [Fri, 12 Jun 2020 21:01:00 +0000 (17:01 -0400)]
Store bytecode offset within exec_byte_code

* src/bytecode.c (exec_byte_code): Store offset in the backtrace frame
for the function being executed, before calling Ffuncall.

* src/eval.c (record_in_backtrace): Don't record the offset.
(backtrace_next, backtrace_top): Move declarations to lisp.h.

* src/lisp.h (backtrace_next, backtrace_top): Declare.

4 years agoProperly align offset in backtrace
Zach Shaftel [Fri, 5 Jun 2020 19:06:29 +0000 (15:06 -0400)]
Properly align offset in backtrace

* lisp/emacs-lisp/backtrace.el (backtrace--print-flags): Use format
width specifier to line up the flags and offset nicely.

4 years agoMerge branch 'master' into feature/soc-bytecode-in-traceback-specbinding
Zach Shaftel [Tue, 2 Jun 2020 20:36:38 +0000 (16:36 -0400)]
Merge branch 'master' into feature/soc-bytecode-in-traceback-specbinding

4 years ago; * src/composite.c (syms_of_composite): Fix last change.
Eli Zaretskii [Tue, 2 Jun 2020 17:46:26 +0000 (20:46 +0300)]
; * src/composite.c (syms_of_composite): Fix last change.

4 years agoFix Arabic composition rules
Eli Zaretskii [Tue, 2 Jun 2020 17:44:59 +0000 (20:44 +0300)]
Fix Arabic composition rules

* lisp/language/misc-lang.el (composition-function-table): Reorder
Arabic composition rules in descending order of lookback.

* src/composite.c (syms_of_composite): Document the order of rules
in 'composition-function-table'.

4 years agoWrite project list to file only when changed
Simen Heggestøyl [Tue, 2 Jun 2020 17:20:14 +0000 (19:20 +0200)]
Write project list to file only when changed

* lisp/progmodes/project.el (project--add-to-project-list-front):
Write the project list to file only when it has changed.

4 years agoRemove 'project--ensure-file-exists'
Simen Heggestøyl [Fri, 29 May 2020 14:58:09 +0000 (16:58 +0200)]
Remove 'project--ensure-file-exists'

* lisp/progmodes/project.el (project--ensure-file-exists): Remove.
(project--read-project-list): Set 'project--list' to nil when the
project list file doesn't exist.

4 years agoFix handling of CGJ in Hebrew text
Eli Zaretskii [Tue, 2 Jun 2020 15:42:09 +0000 (18:42 +0300)]
Fix handling of CGJ in Hebrew text

* lisp/language/hebrew.el (hebrew): Add CGJ U+034F to the
combining characters supported in Hebrew compositions. (Bug#41645)

4 years agoSimplify and regularize some offset tests in alloc.c
Paul Eggert [Tue, 2 Jun 2020 05:41:33 +0000 (22:41 -0700)]
Simplify and regularize some offset tests in alloc.c

* src/alloc.c (live_string_holding, live_cons_holding)
(live_symbol_holding, live_float_p): Simplify and regularize.

4 years agoMerge from origin/emacs-27
Paul Eggert [Tue, 2 Jun 2020 05:26:33 +0000 (22:26 -0700)]
Merge from origin/emacs-27

0260d2d2db Don't call 'mbrtowc' on WINDOWSNT

4 years ago; Merge from origin/emacs-27
Paul Eggert [Tue, 2 Jun 2020 05:26:33 +0000 (22:26 -0700)]
; Merge from origin/emacs-27

The following commit was skipped:

fb90f46f47 ; Auto-commit of loaddefs files.

4 years agoMerge from origin/emacs-27
Paul Eggert [Tue, 2 Jun 2020 05:26:32 +0000 (22:26 -0700)]
Merge from origin/emacs-27

44c0e074f7 * doc/emacs/buffers.texi (Icomplete): Mention icomplete-mi...
68b6dad1d8 Be more aggressive in marking objects during GC
36f508f589 ; * src/xdisp.c (find_last_unchanged_at_beg_row): Fix a typo.
cc340da1fe Fix bug #41618 "(byte-compile 'foo) errors when foo is a m...
41232e6797 Avoid crashes due to bidi cache being reset during redisplay
f72bb4ce36 * lisp/tab-bar.el (switch-to-buffer-other-tab): Normalize ...
d3e0023aaa ; * etc/TODO: Fix formatting.  (Bug#41497)
a8ad94cd2f Fix mingw.org's MinGW GCC 9 warning about 'execve'

# Conflicts:
# lisp/tab-bar.el
# nt/inc/ms-w32.h
# src/alloc.c

4 years ago* lisp/progmodes/project.el (project-vc-dir, project-shell): New commands.
Juri Linkov [Mon, 1 Jun 2020 23:01:25 +0000 (02:01 +0300)]
* lisp/progmodes/project.el (project-vc-dir, project-shell): New commands.

(project-compile): Add args and interactive spec like in 'compile'.
(project-switch-commands): Bind project-vc-dir to "v",
project-shell to "s", and rebind project-find-regexp from "s" to "r".

* doc/emacs/maintaining.texi (Project File Commands):
Describe project-vc-dir and project-shell.

4 years agoDon't call 'mbrtowc' on WINDOWSNT
Eli Zaretskii [Mon, 1 Jun 2020 15:57:39 +0000 (18:57 +0300)]
Don't call 'mbrtowc' on WINDOWSNT

* src/emacs.c (using_utf8): Don't call 'mbrtowc' on WINDOWSNT
systems, as it's not available on Windows 9X.

4 years ago; Fix some recent byte-compilation warnings
Basil L. Contovounesios [Mon, 1 Jun 2020 15:56:26 +0000 (16:56 +0100)]
; Fix some recent byte-compilation warnings

For discussion of the autoloaded function declaration, see
https://lists.gnu.org/archive/html/emacs-devel/2020-05/msg00910.html.

* lisp/dnd.el (dnd-handle-one-url): It is no longer necessary to
declare the autoloaded function browse-url-select-handler after
ldefs-boot.el was updated.
* lisp/progmodes/elisp-mode.el: Declare xref.el function to silence
byte-compiler.

4 years agoBug #41061 patch: Fix typos and amend code slightly
Alan Mackenzie [Mon, 1 Jun 2020 15:21:54 +0000 (15:21 +0000)]
Bug #41061 patch: Fix typos and amend code slightly

* lisp/progmodes/cc-align.el (c-lineup-ternary-bodies)
* doc/misc/cc-mode.texi (Operator Line-Up): Fix typos and amend code.

4 years ago; Auto-commit of loaddefs files.
Glenn Morris [Mon, 1 Jun 2020 13:27:51 +0000 (06:27 -0700)]
; Auto-commit of loaddefs files.

4 years ago; Auto-commit of loaddefs files.
Glenn Morris [Mon, 1 Jun 2020 13:11:55 +0000 (06:11 -0700)]
; Auto-commit of loaddefs files.

4 years agoChange xref-find-apropos to pass PATTERN to backend verbatim
Dmitry Gutov [Mon, 1 Jun 2020 01:44:33 +0000 (04:44 +0300)]
Change xref-find-apropos to pass PATTERN to backend verbatim

* lisp/progmodes/xref.el (xref-backend-apropos): Rename this
generic's second arg to PATTERN, to clarify that it should be
handled entirely in the backend, with no pre-processing by the
command.
(xref-find-apropos): Update accordingly, but keep compatibility
with backends in older Emacs versions.
(xref-apropos-regexp): Extract from xref-find-apropos.

* lisp/progmodes/etags.el (xref-backend-apropos): Use it here.

* lisp/progmodes/elisp-mode.el (xref-backend-apropos): And here.

4 years ago* doc/emacs/buffers.texi (Icomplete): Mention icomplete-minibuffer-setup-hook.
João Távora [Mon, 1 Jun 2020 00:29:50 +0000 (01:29 +0100)]
* doc/emacs/buffers.texi (Icomplete): Mention icomplete-minibuffer-setup-hook.

4 years agoBe more aggressive in marking objects during GC
Paul Eggert [Sun, 31 May 2020 22:29:23 +0000 (15:29 -0700)]
Be more aggressive in marking objects during GC

Simplified version of a patch from Pip Cet (Bug#41321#299).
* src/alloc.c (maybe_lisp_pointer): Remove.  All uses removed.
(mark_memory): Also look at the pointer offset by ‘lispsym’,
for symbols.

4 years agoUnbreak compilation with CHECK_STRUCTS defined.
Philipp Stephani [Sun, 31 May 2020 17:50:04 +0000 (19:50 +0200)]
Unbreak compilation with CHECK_STRUCTS defined.

* src/pdumper.c (dump_float): Update hash value after commit
9f7bfb6cb06f1480a0904184cabf187e03628e55.  The struct layout is still
compatible.

4 years ago; * src/xdisp.c (find_last_unchanged_at_beg_row): Fix a typo.
Eli Zaretskii [Sun, 31 May 2020 17:34:00 +0000 (20:34 +0300)]
; * src/xdisp.c (find_last_unchanged_at_beg_row): Fix a typo.

4 years agoFix bug #41618 "(byte-compile 'foo) errors when foo is a macro."
Alan Mackenzie [Sun, 31 May 2020 16:46:06 +0000 (16:46 +0000)]
Fix bug #41618 "(byte-compile 'foo) errors when foo is a macro."

* lisp/emacs-lisp/bytecomp.el (byte-compile): Disentangle the eval of the
final form from the pushing of 'macro onto it, doing the former first.

4 years agoRemove mhtml--extend-font-lock-region (Bug#41441)
Tom Tromey [Sun, 31 May 2020 16:20:12 +0000 (10:20 -0600)]
Remove mhtml--extend-font-lock-region (Bug#41441)

* lisp/textmodes/mhtml-mode.el (mhtml--extend-font-lock-region):
Remove.
(mhtml-mode): Don't set font-lock-extend-region-functions.

4 years agoProtect bidi cache from inadvertent resets
Eli Zaretskii [Sun, 31 May 2020 14:34:09 +0000 (17:34 +0300)]
Protect bidi cache from inadvertent resets

* src/xdisp.c (Fline_pixel_height, Fmove_point_visually): Save and
restore the bidi cache, to avoid inadvertently resetting it by
starting a new iteration through buffer text.  This could cause
trouble if these functions are called during a redisplay cycle,
especially while we were processing RTL text.

4 years agoAvoid crashes due to bidi cache being reset during redisplay
Eli Zaretskii [Sun, 31 May 2020 14:23:11 +0000 (17:23 +0300)]
Avoid crashes due to bidi cache being reset during redisplay

If automatic character composition triggers GC, and
'garbage-collection-messages' are turned on, we could have the
bidi cache reset while processing RTL text, which would then
consistently crash.
* src/xdisp.c (display_echo_area_1): Protect the bidi cache
against changes inside 'try_window'.

4 years agooccur: Add bindings for next-error-no-select
Tino Calancha [Sun, 31 May 2020 10:31:27 +0000 (12:31 +0200)]
occur: Add bindings for next-error-no-select

Make the navigation in the occur buffer closer
to the navigation in the compilation buffer.

Add bindings to navigate the occur matches (Bug#39121).
Honor `next-error-highlight' and `next-error-highlight-no-select'
when navigating the occurrences.

* lisp/replace.el (occur-highlight-regexp, occur-highlight-overlay):
New variables.
(occur-1): Set `occur-highlight-regexp' to the searched regexp.
(occur-goto-locus-delete-o, occur--highlight-occurrence): New defuns.
(occur-mode-display-occurrence, occur-mode-goto-occurrence):
Use `occur--highlight-occurrence'.
(occur-mode-map): Bind n to `next-error-no-select'
and p to `previous-error-no-select'

* etc/NEWS (Changes in Specialized Modes and Packages in Emacs 28.1):
Announce this change.

* test/lisp/replace-tests.el (replace-tests-with-highlighted-occurrence):
Add helper macro.
(occur-highlight-occurrence): Add test.

4 years ago* lisp/tab-bar.el (switch-to-buffer-other-tab): Normalize buffer.
Juri Linkov [Sat, 30 May 2020 22:30:34 +0000 (01:30 +0300)]
* lisp/tab-bar.el (switch-to-buffer-other-tab): Normalize buffer.

* lisp/tab-bar.el (switch-to-buffer-other-tab): Use
'window-normalize-buffer-to-switch-to' on 'buffer-or-name',
like does 'pop-to-buffer' used by 'switch-to-buffer-other-frame',
instead of raising the error "Invalid buffer" on a non-existent buffer name.

4 years agoDon't return transient projects with MAYBE-PROMPT=nil
Dmitry Gutov [Sat, 30 May 2020 16:57:06 +0000 (19:57 +0300)]
Don't return transient projects with MAYBE-PROMPT=nil

* lisp/progmodes/project.el (project-current): Only return
transient projects when called with non-nil MAYBE-PROMPT.
Also only update the known projects lists in this case.
(https://lists.gnu.org/archive/html/emacs-devel/2020-05/msg03375.html).

4 years ago; * etc/TODO: Fix formatting. (Bug#41497)
Eli Zaretskii [Sat, 30 May 2020 16:10:14 +0000 (19:10 +0300)]
; * etc/TODO: Fix formatting.  (Bug#41497)

4 years agoMinor fix in 'find-alternate-file'
immerrr [Sun, 17 May 2020 11:47:23 +0000 (13:47 +0200)]
Minor fix in 'find-alternate-file'

This fixes the use case when, for example, 'find-file-hooks'
fails.
* lisp/files.el (find-alternate-file): If buffer 'oname' exists,
kill it before renaming the new one.  (Bug#41359)

4 years agoRemove private prototype for 'execve' and its uses in MinGW build
Eli Zaretskii [Sat, 30 May 2020 10:56:20 +0000 (13:56 +0300)]
Remove private prototype for 'execve' and its uses in MinGW build

* src/sysdep.c (emacs_exec_file): Don't compile this function
anymore on WINDOWSNT, since it is not used there.  This function
was the only reason for having 'execve' prototype in ms-w32.h.

* nt/inc/ms-w32.h (execve): Remove prototype and the MinGW64 vs
ming.org mess that it causes.

4 years agoFix mingw.org's MinGW GCC 9 warning about 'execve'
Eli Zaretskii [Sat, 30 May 2020 10:19:13 +0000 (13:19 +0300)]
Fix mingw.org's MinGW GCC 9 warning about 'execve'

* nt/inc/ms-w32.h (execve) [__GNUC__ > 9]: Provide a different
prototype for mingw.org's MinGW as well, to match the GCC builtin.

4 years agoAnother fix of display of line-prefix with fringe bitmaps
Eli Zaretskii [Fri, 29 May 2020 20:02:10 +0000 (23:02 +0300)]
Another fix of display of line-prefix with fringe bitmaps

* src/xdisp.c (redisplay_internal): Don't use "optimization 1"
if a glyph row from which to start display begins with a display
property that draws into the fringes.  (Bug#41584)

4 years ago* lisp/emacs-lisp/package.elm lisp/emacs-lisp/smie.el: Fix indent
Stefan Monnier [Fri, 29 May 2020 19:01:58 +0000 (15:01 -0400)]
* lisp/emacs-lisp/package.elm lisp/emacs-lisp/smie.el: Fix indent

Use the new "space after paren" convention to get the desired indentation

4 years agoproject-prompt-project-dir: Use more consistent prompts
Dmitry Gutov [Fri, 29 May 2020 18:37:12 +0000 (21:37 +0300)]
project-prompt-project-dir: Use more consistent prompts

* lisp/progmodes/project.el (project-prompt-project-dir):
Use more consistent prompts.

4 years agoFix display of line-prefix with fringe bitmaps
Eli Zaretskii [Fri, 29 May 2020 14:00:52 +0000 (17:00 +0300)]
Fix display of line-prefix with fringe bitmaps

* src/xdisp.c (try_window_id): Don't use this optimization if a
glyph row from which to start display begins with a display
property that draws into the fringes.  (Bug#41584)

4 years agoCommit indian.el forgotten in previous change.
Eli Zaretskii [Fri, 29 May 2020 13:30:44 +0000 (16:30 +0300)]
Commit indian.el forgotten in previous change.

4 years ago* lisp/net/tramp-smb.el (tramp-smb-errors): Add "NT_STATUS_INVALID_PARAMETER".
Michael Albinus [Fri, 29 May 2020 09:41:54 +0000 (11:41 +0200)]
* lisp/net/tramp-smb.el (tramp-smb-errors): Add "NT_STATUS_INVALID_PARAMETER".

4 years ago* lisp/emacs-lisp/lisp-mode.el: Add new indentation convention
akater [Fri, 29 May 2020 04:26:09 +0000 (00:26 -0400)]
* lisp/emacs-lisp/lisp-mode.el: Add new indentation convention

(calculate-lisp-indent): To distinguish code and data when indenting,
introduce the convention that a space between an open paren and
a symbol indicate that this should be indented as a simple data list.

4 years agoCreate a buffer-local binding to improve performance
Arnold Noronha [Thu, 28 May 2020 23:35:58 +0000 (02:35 +0300)]
Create a buffer-local binding to improve performance

* lisp/ido.el (ido-make-buffer-list-1):
Create a buffer-local binding to improve performance when a lot of
buffers are open (bug#41029).

Copyright-paperwork-exempt: yes

4 years agonext-error-find-buffer-function: Back to #'ignore
Dmitry Gutov [Thu, 28 May 2020 23:03:41 +0000 (02:03 +0300)]
next-error-find-buffer-function: Back to #'ignore

* lisp/simple.el (next-error-find-buffer-function):
Change the default back, to simplify the default behavior
(bug#40919).

4 years ago; project.el: Update TODO
Dmitry Gutov [Thu, 28 May 2020 20:01:08 +0000 (23:01 +0300)]
; project.el: Update TODO

4 years agoImprove Malayalam language transliteration
James Thomas [Mon, 27 Apr 2020 02:36:48 +0000 (08:06 +0530)]
Improve Malayalam language transliteration

The existing ITRANS scheme did not support some characters and
language quirks like 'chillu's.  The Inscript method had errors.
* lisp/language/ind-util.el (indian-mlm-base-table): Add archaic
chars, Mozhi combos; cleanup.
(indian-mlm-mozhi-table): New scheme Mozhi.
* lisp/leim/quail/indian.el (inscript-mlm-keytable): Correct
errors.  Add Inscript chillus & zero-width chars, Mozhi scheme.
* etc/NEWS: Mention the changes.

4 years agoMerge branch 'feature/project-switching'
Simen Heggestøyl [Thu, 28 May 2020 15:02:17 +0000 (17:02 +0200)]
Merge branch 'feature/project-switching'

4 years agoDocument that {en,de}code-coding-string preserve match data
Mattias Engdegård [Thu, 28 May 2020 14:37:27 +0000 (16:37 +0200)]
Document that {en,de}code-coding-string preserve match data

* lisp/international/mule.el (define-coding-system):
Require :pre-write-conversion and :post-read-conversion functions
to leave the match data untouched.
* src/coding.c (Fdecode_coding_string, Fencode_coding_string):
Document functions as match-data-preserving.

Suggested by Stefan Monnier (see bug#41445).

4 years agoMerge from origin/emacs-27
Glenn Morris [Thu, 28 May 2020 14:50:26 +0000 (07:50 -0700)]
Merge from origin/emacs-27

bd7b681dc4 (origin/emacs-27) Tiny texinfo markup fixes
d0dd0e0612 ; Fix more @var/@code mixups in Elisp manual
313dc0439e ; Fix another format-spec typo in the Elisp manual
9d7fd78421 Make next-error behavior a bit more flexible
0691d25295 * etc/NEWS.25: Belatedly announce upcase-dwim and downcase...
df91c94ca8 Fix access to single-byte characters in buffer text

4 years ago; Merge from origin/emacs-27
Glenn Morris [Thu, 28 May 2020 14:50:26 +0000 (07:50 -0700)]
; Merge from origin/emacs-27

The following commit was skipped:

478638e470 Revert "Fix eshell-mode-map initialization"

4 years agoMerge from origin/emacs-27
Glenn Morris [Thu, 28 May 2020 14:50:25 +0000 (07:50 -0700)]
Merge from origin/emacs-27

e7a3ed8a6d Fix tab-bar-tab-name-ellipsis initialization
4737d0af75 Fix Elisp manual entry for format-spec
0195809bb6 Fix rare assertion violations in 'etags'
cddb0079ff ; * lisp/format-spec.el (format-spec): Fix typo.

4 years ago; * doc/emacs/maintaining.texi: Fix typo.
Simen Heggestøyl [Thu, 28 May 2020 14:40:30 +0000 (16:40 +0200)]
; * doc/emacs/maintaining.texi: Fix typo.

4 years agoTiny texinfo markup fixes
Glenn Morris [Wed, 27 May 2020 23:29:19 +0000 (16:29 -0700)]
Tiny texinfo markup fixes

* doc/lispref/edebug.texi (Edebug Views):
* doc/lispref/loading.texi (Library Search):
* doc/lispref/os.texi (User Identification): Markup fixes.

4 years ago; Fix more @var/@code mixups in Elisp manual
Basil L. Contovounesios [Wed, 27 May 2020 23:12:54 +0000 (00:12 +0100)]
; Fix more @var/@code mixups in Elisp manual

* doc/lispref/text.texi (Replacing): Fix markup for function
arguments.

4 years ago; Fix another format-spec typo in the Elisp manual
Basil L. Contovounesios [Wed, 27 May 2020 22:43:14 +0000 (23:43 +0100)]
; Fix another format-spec typo in the Elisp manual

* doc/lispref/text.texi (Interpolated Strings): Correct markup for
function argument.

4 years agoMake next-error behavior a bit more flexible
Dmitry Gutov [Wed, 27 May 2020 19:15:41 +0000 (22:15 +0300)]
Make next-error behavior a bit more flexible

* lisp/simple.el (next-error-no-navigation-try-current):
Extract from the case #2 in next-error-find-buffer (bug#40919).
(next-error-find-buffer-function): Use it as the default.

4 years ago* etc/NEWS.25: Belatedly announce upcase-dwim and downcase-dwim.
Noam Postavsky [Wed, 27 May 2020 18:04:46 +0000 (14:04 -0400)]
* etc/NEWS.25: Belatedly announce upcase-dwim and downcase-dwim.

4 years agoAdjust NEWS for revert of eshell fix on emacs-27 (Bug#41370)
Noam Postavsky [Wed, 27 May 2020 16:49:35 +0000 (12:49 -0400)]
Adjust NEWS for revert of eshell fix on emacs-27 (Bug#41370)

* etc/NEWS.27: Move "Eshell no longer re-initializes its keymap every
call" to...
* etc/NEWS: ... here.

4 years agoFix customizing of ido-mode (Bug#41557)
Noam Postavsky [Wed, 27 May 2020 15:44:18 +0000 (11:44 -0400)]
Fix customizing of ido-mode (Bug#41557)

lisp/ido.el (ido-mode): When setting the user option to nil, pass 0 to
the function, so that it will be disabled as intended.

4 years agoFix crash with invalid bytecode vectors
Paul Eggert [Wed, 27 May 2020 16:50:07 +0000 (09:50 -0700)]
Fix crash with invalid bytecode vectors

* src/lread.c (read_vector): If the vector is to short to be for
bytecodes don’t do bytecode processing for it, as the processing
might run past the end of the vector.

4 years ago--with-wide-int is a no-op on 64-bit hosts
Paul Eggert [Wed, 27 May 2020 16:45:49 +0000 (09:45 -0700)]
--with-wide-int is a no-op on 64-bit hosts

* configure.ac: Clarify wording for --with-wide-int help.
* src/pdumper.c (dump_vectorlike_generic):
Do the eassert even if --with-wide-int was specified unnecessarily.

4 years agoOmit unnecessary USE_LAB_TAG #if
Paul Eggert [Wed, 27 May 2020 16:05:12 +0000 (09:05 -0700)]
Omit unnecessary USE_LAB_TAG #if

* src/lisp.h: Omit unnecessary #if; the condition is always false now.

4 years agoSimplify the previous commit
Simen Heggestøyl [Wed, 27 May 2020 15:17:15 +0000 (17:17 +0200)]
Simplify the previous commit

* lisp/progmodes/project.el (project--read-project-list): Simplify the
previous commit by utilizing the optional OMIT-NULLS argument to
'split-string'.

4 years agoDon't clobber match data in utf-8-hfs conversion (bug#41445)
Mattias Engdegård [Fri, 22 May 2020 10:21:28 +0000 (12:21 +0200)]
Don't clobber match data in utf-8-hfs conversion (bug#41445)

Reported by Ture Pålsson.

* lisp/international/ucs-normalize.el
(ucs-normalize-hfs-nfd-post-read-conversion)
(ucs-normalize-hfs-nfd-pre-write-conversion):
Use save-match-data to avoid match data clobber in normalisation.
* test/lisp/international/ucs-normalize-tests.el
(ucs-normalize-save-match-data): New test.

4 years agoTweak GC performance if !USE_LSB_TAG
Paul Eggert [Tue, 26 May 2020 22:47:59 +0000 (15:47 -0700)]
Tweak GC performance if !USE_LSB_TAG

Performance issue reported by Eli Zaretskii (Bug#41321#149).
* src/alloc.c (GC_OBJECT_ALIGNMENT_MINIMUM): New constant.
(maybe_lisp_pointer): Use it instead of GCALIGNMENT.

4 years agoMerge branch 'master' into feature/soc-bytecode-in-traceback-specbinding
Zach Shaftel [Tue, 26 May 2020 20:26:26 +0000 (16:26 -0400)]
Merge branch 'master' into feature/soc-bytecode-in-traceback-specbinding

4 years agoIntroduce some Objective-C 2.0 keywords. This fixes bug #5953
Alan Mackenzie [Tue, 26 May 2020 20:08:15 +0000 (20:08 +0000)]
Introduce some Objective-C 2.0 keywords.  This fixes bug #5953

* lisp/progmodes/cc-langs.el (c-other-decl-kwds): New keywords @property,
@dynamic, @synthesize, @compatibility_alias.
(c-protection-kwds): New keywords @package, @required, @optional.
(c-block-stmt-1-kwds): New keyword @autoreleasepool.
(c-constant-kwds): New keywords IBAction, IBOutlet.

4 years agoAvoid adding the empty string to the project list
Simen Heggestøyl [Mon, 25 May 2020 19:29:02 +0000 (21:29 +0200)]
Avoid adding the empty string to the project list

* lisp/progmodes/project.el (project--read-project-list): Avoid adding
the empty string to the project list.

4 years agoAdapt project functions to the new 'project-root'
Simen Heggestøyl [Mon, 25 May 2020 19:10:03 +0000 (21:10 +0200)]
Adapt project functions to the new 'project-root'

* lisp/progmodes/project.el (project-dired, project-eshell)
(project--read-project-list, project--write-project-list)
(project--add-to-project-list-front)
(project--remove-from-project-list): Adapt to the new 'project-root'.

4 years agoSome copy edits
Dmitry Gutov [Mon, 18 May 2020 22:27:37 +0000 (01:27 +0300)]
Some copy edits

* doc/emacs/maintaining.texi (Switching Projects)
(Project File Commands): Copy edits.

* etc/NEWS: Same.

4 years agoTeach project-current to inhibit the prompt
Dmitry Gutov [Mon, 18 May 2020 22:00:43 +0000 (01:00 +0300)]
Teach project-current to inhibit the prompt

* lisp/progmodes/project.el:
(project-current-inhibit-prompt): New variable.
(project-current, project-switch-project): Use it.

4 years agoUpdate the Emacs manual with recent project.el changes
Simen Heggestøyl [Mon, 18 May 2020 16:17:10 +0000 (18:17 +0200)]
Update the Emacs manual with recent project.el changes

* doc/emacs/maintaining.texi (Projects): Add a menu.
(Project File Commands): New subsection describing project file
commands (moved here from 'Working with Projects').  Describe the new
commands 'project-dired' and 'project-eshell'.
(Switching Projects): New subsection.

* etc/NEWS: Mention project.el changes.

4 years agoRename 'project-switch-menu' to 'project-switch-commands'
Simen Heggestøyl [Sun, 17 May 2020 11:54:32 +0000 (13:54 +0200)]
Rename 'project-switch-menu' to 'project-switch-commands'

* lisp/progmodes/project.el (project-switch-commands): Rename from
'project-switch-menu'.
(project--keymap-prompt, project-switch-project): Update after the
renaming.

4 years agoSimplify 'project--keymap-prompt' a bit
Simen Heggestøyl [Sun, 17 May 2020 06:49:08 +0000 (08:49 +0200)]
Simplify 'project--keymap-prompt' a bit

* lisp/progmodes/project.el: Remove seq requirement.
(project--keymap-prompt): Simplify with 'mapconcat'.

4 years agoTurn project switch menu var into a public alist
Simen Heggestøyl [Sat, 16 May 2020 07:53:43 +0000 (09:53 +0200)]
Turn project switch menu var into a public alist

* lisp/progmodes/project.el: Require seq.
(project--switch-alist): Remove in favor of the public
'project-switch-menu'.
(project-add-switch-command): Remove; not needed now that
'project-switch-menu' is a public alist.
(project-switch-menu): New variable mapping keys to project switching
menu entries.
(project--keymap-prompt, project-switch-project): Adjust to the new
'project-switch-menu' format.

4 years agoChange dispatch binding of 'project-find-regexp'
Simen Heggestøyl [Sat, 16 May 2020 07:00:49 +0000 (09:00 +0200)]
Change dispatch binding of 'project-find-regexp'

* lisp/progmodes/project.el: Change default dispatch binding of
'project-find-regexp' to 's'.

4 years agoIntegrate project-switch-project with project-find-regexp
Dmitry Gutov [Tue, 12 May 2020 01:20:26 +0000 (04:20 +0300)]
Integrate project-switch-project with project-find-regexp

* lisp/progmodes/project.el:
(project-find-regexp): Add to the list of 'switch' commands.
(project-switch-project): Use call-interactively so that the
former can read its arguments.

4 years agoMove project-dired and project-eshell higher
Dmitry Gutov [Tue, 12 May 2020 01:17:23 +0000 (04:17 +0300)]
Move project-dired and project-eshell higher

* lisp/progmodes/project.el:
(project-dired, project-eshell): Move higher in the file,
according to their universal utility.

4 years agoUse an alist instead of a keymap
Dmitry Gutov [Tue, 12 May 2020 01:13:48 +0000 (04:13 +0300)]
Use an alist instead of a keymap

* lisp/progmodes/project.el:
(project--switch-alist): New variable to use instead of
project-switch-keymap, which remove.  Update all references.

4 years agoImprove project name completion
Dmitry Gutov [Tue, 12 May 2020 00:32:05 +0000 (03:32 +0300)]
Improve project name completion

* lisp/progmodes/project.el:
(project-prompt-project-dir): Use REQUIRE-MATCH=t.  Make sure the
'substring' completion style is used by default.

4 years agoSimplify a little, and avoid duplicate commands
Dmitry Gutov [Tue, 12 May 2020 00:22:30 +0000 (03:22 +0300)]
Simplify a little, and avoid duplicate commands

* lisp/progmodes/project.el:
(project--transient-p) Remove, not needed.
(project-current): Move project-find based on the directory here.
(project--remove-from-project-list): Only write if the list changed.
(project-find-project): Rename to project-prompt-project-dir.
Simply return the directory selected by the user.
(project-switch-project-find-file): Remove.
(project-switch-project-dired): Rename to project-dired and make
it follow the convention of existing projec tcommands.
(project-switch-project-eshell): Ditto.
(project-switch-project): Instead of passing the project instance
to the command, just bind default-directory.

4 years agoAdd project switching functionality
Simen Heggestøyl [Sat, 9 May 2020 15:27:06 +0000 (17:27 +0200)]
Add project switching functionality

* lisp/progmodes/project.el: Require subr-x.
(project--transient-p, project--ensure-file-exists)
(project--read-project-list, project--ensure-read-project-list)
(project--write-project-list)
(project--add-to-project-list-front)
(project--remove-from-project-list, project-find-project)
(project-switch-project-find-file, project-switch-project-dired)
(project-switch-project-eshell, project-add-switch-command)
(project--keymap-prompt, project-switch-project): New functions.
(project--list, project-switch-keymap): New variables.
(project-current): Call 'project-find-project' when no project is
current.

4 years agoPort struct Lisp_FLoat to oddball platforms
Paul Eggert [Tue, 26 May 2020 07:47:24 +0000 (00:47 -0700)]
Port struct Lisp_FLoat to oddball platforms

* src/lisp.h (struct Lisp_Float): Declare via
GCALIGNED_UNION_MEMBER, not via GCALIGNED_STRUCT, since alloc.c
creates these in arrays and GCALIGNED_STRUCT does not necessarily
suffice to align struct Lisp_Float when it’s used in an array.
This avoids undefined behavior on oddball machines where
sizeof (struct Lisp_Float) is not a multiple of 8 and the compiler
does not support __attribute__ ((aligned 8)).

4 years agoMove union emacs_align_type to alloc.c
Paul Eggert [Tue, 26 May 2020 06:24:47 +0000 (23:24 -0700)]
Move union emacs_align_type to alloc.c

* src/alloc.c (union emacs_align_type): Move to here ...
* src/lisp.h: ... from here, and uncomment out some of the
types that alloc.c can see but lisp.h cannot.

4 years agoFurther fix for aborts due to GC losing pseudovectors
Paul Eggert [Tue, 26 May 2020 06:06:07 +0000 (23:06 -0700)]
Further fix for aborts due to GC losing pseudovectors

* src/alloc.c (MALLOC_ALIGNMENT_BOUND): Remove.
(LISP_ALIGNMENT): Go back to yesterday’s version, except use
union emacs_align_type instead of max_align_t.
(MALLOC_IS_LISP_ALIGNED): Go back to yesterday’s version.
(maybe_lisp_pointer): Check against GCALIGNMENT, not LISP_ALIGNMENT.
* src/lisp.h (union emacs_align_type): Bring back.

4 years agoRefix aborts due to GC losing pseudovectors
Paul Eggert [Tue, 26 May 2020 05:06:25 +0000 (22:06 -0700)]
Refix aborts due to GC losing pseudovectors

This is simpler, and fixes a bug in the previous fix.
* src/alloc.c (MALLOC_ALIGNMENT_BOUND): Simplify by
using max_align_t, since the buggy implementations won’t
break this simpler implementation.
(LISP_ALIGNMENT): Simplify by just using GCALIGNMENT, since the
fancier implementation wasn’t correct anyway, and fixing it
isn’t worth the trouble on practical platforms.
* src/lisp.h (union emacs_align_type): Remove.

4 years agoFix aborts due to GC losing pseudovectors
Paul Eggert [Tue, 26 May 2020 03:26:14 +0000 (20:26 -0700)]
Fix aborts due to GC losing pseudovectors

Problem reported by Eli Zaretskii (Bug#41321).
* src/alloc.c (MALLOC_ALIGNMENT_BOUND): New constant.
(LISP_ALIGNMENT): Lower it to avoid crashes on MinGW and similarly
buggy platforms where malloc returns pointers not aligned to
alignof (max_align_t).  But keep it higher on platforms where this
is known to work, as it helps GC performance.
(MALLOC_IS_LISP_ALIGNED): Define in terms of the other two.
* src/alloc.c (stacktop_sentry):
* src/thread.c (run_thread):
Don’t overalign or oversize stack sentries; they need to be
aligned only for pointers and Lisp_Object, not for arbitrary
pseudovector contents.
* src/lisp.h (union emacs_align_type): New type, used for
LISP_ALIGNMENT.

4 years agoMark metamail.el as obsolete (Bug#41388)
Stefan Kangas [Tue, 26 May 2020 02:56:56 +0000 (04:56 +0200)]
Mark metamail.el as obsolete (Bug#41388)

The metamail package was last released in 1994, and has been removed
from most GNU/Linux distributions due to being buggy and unmaintained.

* lisp/mail/metamail.el: Move from here...
* lisp/obsolete/metamail.el: ...to here.
* etc/NEWS: Mention its obsoletion.

4 years agoBump project.el version
Dmitry Gutov [Mon, 25 May 2020 19:29:47 +0000 (22:29 +0300)]
Bump project.el version

* project.el: Bump the version

4 years ago; More the note about reporting problems further up
Dmitry Gutov [Mon, 25 May 2020 19:29:06 +0000 (22:29 +0300)]
; More the note about reporting problems further up

4 years ago; * lisp/files.el (auto-save-visited-mode): Fix typo in last commit.
Philipp Stephani [Mon, 25 May 2020 19:21:31 +0000 (21:21 +0200)]
; * lisp/files.el (auto-save-visited-mode): Fix typo in last commit.

4 years agoAllow inhibiting 'auto-save-visited-mode' on a per-buffer basis.
Philipp Stephani [Wed, 1 Apr 2020 17:54:01 +0000 (19:54 +0200)]
Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis.

At least for me, 'auto-save-visited-mode' is very slow and blocks user
interaction for files visited over TRAMP.  Therefore, I'd like a
mechanism to disable it for some buffers (namely, those visiting
remote files).

* (auto-save-visited-mode): Document that 'auto-save-visited-mode' can
be set to nil buffer-locally.

* etc/NEWS: Document new behavior.

4 years agoFix access to single-byte characters in buffer text
Eli Zaretskii [Mon, 25 May 2020 14:07:22 +0000 (17:07 +0300)]
Fix access to single-byte characters in buffer text

* src/xdisp.c (get_visually_first_element)
(Fbidi_find_overridden_directionality):
* src/cmds.c (Fend_of_line): Use FETCH_BYTE instead of FETCH_CHAR,
and byte position instead of character position, to access
individual bytes of buffer text.  This avoids producing invalid
characters and accessing wrong buffer positions.  (Bug#41520)

4 years agoDon't bug out in xml-escape-string if invalid characters aren't present
Lars Ingebrigtsen [Mon, 25 May 2020 13:03:37 +0000 (15:03 +0200)]
Don't bug out in xml-escape-string if invalid characters aren't present

* lisp/xml.el (xml-escape-string): Don't bug out if invalid
characters aren't present.

4 years agoAdd command ffap-other-tab (Bug#41410)
ej32u@protonmail.com [Tue, 19 May 2020 21:43:13 +0000 (21:43 +0000)]
Add command ffap-other-tab (Bug#41410)

* lisp/ffap.el (ffap-other-tab): New command, opens files at point in
another tab.
(ffap-bindings): Bind it to find-file-other-tab's binding.

4 years agoMake dedicated keymap and mode for eshell-command (Bug#41370)
Noam Postavsky [Mon, 25 May 2020 00:17:40 +0000 (20:17 -0400)]
Make dedicated keymap and mode for eshell-command (Bug#41370)

Otherwise, we end up permanently modifying eshell-mode-map when
running eshell-command.
* lisp/eshell/eshell.el (eshell-command-mode): New mode, with map to
contain the bindings previously set by eshell-return-exits-minibuffer.
(eshell-return-exits-minibuffer): Make into obsolete alias for
eshell-command-mode.
(eshell-command): Use eshell-command-mode instead of
eshell-return-exits-minibuffer.

4 years agoFix segfault on closing frame with tooltip (Bug#41239)
Noam Postavsky [Mon, 25 May 2020 00:14:48 +0000 (20:14 -0400)]
Fix segfault on closing frame with tooltip (Bug#41239)

* src/gtkutil.c (xg_free_frame_widgets): Empty and unreference the
tooltip widget before destroying its label.

4 years agoRevert "Fix eshell-mode-map initialization"
Noam Postavsky [Mon, 25 May 2020 00:12:30 +0000 (20:12 -0400)]
Revert "Fix eshell-mode-map initialization"

It makes eshell-return-exits-minibuffer permanently affect the
eshell-mode-map (Bug#41370).

Do not merge to master, we will fix it properly there.

4 years agoFix tab-bar-tab-name-ellipsis initialization
Matthias Meulien [Sun, 17 May 2020 22:32:47 +0000 (00:32 +0200)]
Fix tab-bar-tab-name-ellipsis initialization

* lisp/tab-bar.el (tab-bar-tab-name-truncated): Evaluate displayable
character when generating tab name.