]> git.eshelyaron.com Git - emacs.git/log
emacs.git
3 years agoTry another approach even simpler. feature/completions-highlight-modifications
Jimmy Aguilar Mena [Sun, 22 Nov 2020 22:14:18 +0000 (23:14 +0100)]
Try another approach even simpler.

Perform all the operations directly in the completions buffer.

3 years agoRenamed completions-highlight as zcomplete
Jimmy Aguilar Mena [Sun, 22 Nov 2020 11:27:10 +0000 (12:27 +0100)]
Renamed completions-highlight as zcomplete

3 years agoFix precious commit.
Jimmy Aguilar Mena [Fri, 20 Nov 2020 21:30:47 +0000 (22:30 +0100)]
Fix precious commit.

*
lisp/completions-highlight.el (completions-highlight--hide-completions-advise)
: New function to advise minibuffer-hide-completions.
(completions-highlight-select-near) : Unconditional recenter

3 years agoAdd try to close completions more often like zsh.
Jimmy Aguilar Mena [Fri, 20 Nov 2020 15:00:33 +0000 (16:00 +0100)]
Add try to close completions more often like zsh.

*
lisp/completions-highlight.el (completions-highlight-maybe-close-completions)
: New function to perform more actions on pre-command-hook.

3 years agoSimplify and add custom
Jimmy Aguilar Mena [Fri, 20 Nov 2020 12:37:33 +0000 (13:37 +0100)]
Simplify and add custom

* lisp/completions-highlight.el (completions-highlight-tab-no-scroll) :
New option to control if scroll or select with tab.
(completions-highlight--this-completion) : Removed
(completions-highlight-select-near) : Do search closer if not at point.
(with-minibuffer-scroll-window) : Changed to a function using Juri
Linkov
(minibuffer-choose-completion) : use
completions-highlight-from-minibuffer
(completions-highlight-minibuffer-map) : Use dolist and set only
completions-highlight-from-minibuffer
(completions-highlight--minibuffer-tab-through-completions) : Consider
the new custom to not scroll with tabs.

3 years agoOther changes:
Jimmy Aguilar Mena [Thu, 19 Nov 2020 06:27:37 +0000 (07:27 +0100)]
Other changes:

* lisp/completions-highlight.el (completions-highlight-this-completion) :
Rename as completions--highlight-this-completion
(completions-highlight-set-suffix) : New custom to control suffix in insertion

3 years agoNew command minibuffer-choose-completion
Jimmy Aguilar Mena [Thu, 19 Nov 2020 06:22:05 +0000 (07:22 +0100)]
New command minibuffer-choose-completion

This command uses *Completions* candidates only when highlighted.

3 years agoAdd ignore-errors when executing from minibuffer
Jimmy Aguilar Mena [Thu, 19 Nov 2020 06:19:14 +0000 (07:19 +0100)]
Add ignore-errors when executing from minibuffer

This asserts that the hooks are executed in some cases like when EOB.
*
lisp/completions-highlight (completions-highlight-completions-visible-p)
: New function

3 years agoFixes:
Jimmy Aguilar Mena [Thu, 19 Nov 2020 06:13:36 +0000 (07:13 +0100)]
Fixes:

* lisp/completions-highlight.el (minibuffer-completion-set-suffix) :
Renamed as minibuffer-completion--set-suffix.
(completions-highlight--clear-suffix) : New function
(completions-highlight-minibuffer-tab-through-completions) : Renamed as
completions-highlight--minibuffer-tab-through-completions
(completions-highlight-completions-pre-command-hook) :
(completions-highlight-minibuffer-pre-command-hook) : Removed and
references substituted with completions-highlight--clear-suffix.

3 years agoFix previous commit
Jimmy Aguilar Mena [Thu, 19 Nov 2020 03:31:27 +0000 (04:31 +0100)]
Fix previous commit

3 years agoAdd backtab commands.
Jimmy Aguilar Mena [Thu, 19 Nov 2020 03:25:31 +0000 (04:25 +0100)]
Add backtab commands.

3 years agoSimplify and rely more in the post-command-hook
Jimmy Aguilar Mena [Thu, 19 Nov 2020 03:01:21 +0000 (04:01 +0100)]
Simplify and rely more in the post-command-hook

* lisp/completions-highlight.el (completions-highlight-this-completion)
: Use the new function completions-highlight-select-near.
(completions-highlight-next-completion) : Removed
(completions-highlight-select-near) : New function to select and
highlight next candidate closer to point.
(completions-highlight-previous-completion) :
(completions-highlight-next-line-completion) :
(completions-highlight-previous-line-completion) : Removed as they are
not needed with the hook.
(with-minibuffer-scroll-window) : Add call to
completions-highlight-this-completion at the end.
(minibuffer-next-completion) :
(completions-highlight-previous-completion) :
(completions-highlight-next-line-completion) :
(minibuffer-previous-line-completion) : Remove reference to removed
functions.
(completions-highlight-completions-map) : Clear the bindings for the
removed functions.
(completions-highlight-setup) : Set
completions-highlight-this-completion in post-command-hook instead of
isearch-mode-end-hook.

3 years agoDefine completions-highlight face and group
Jimmy Aguilar Mena [Thu, 19 Nov 2020 02:24:48 +0000 (03:24 +0100)]
Define completions-highlight face and group

* lisp/completions-highlight.el (completions-highlight) : New face and
group.
(completions-highlight-mode) : Set new face to completions-highlight-overlay.

3 years agoAdd custom variable completions-highlight-autoselect.
Jimmy Aguilar Mena [Mon, 16 Nov 2020 10:01:11 +0000 (11:01 +0100)]
Add custom variable completions-highlight-autoselect.

* lisp/completions-highlight.el (completions-highlight-autoselect) : New
custom.
(completions-highlight-setup) : Auto selects the first candidate when
completions-highlight-autoselect is non nil.

3 years agoImprove completions-highlight description in file header.
Jimmy Aguilar Mena [Sun, 15 Nov 2020 22:31:43 +0000 (23:31 +0100)]
Improve completions-highlight description in file header.

3 years agoAdd # to function bindings
Jimmy Aguilar Mena [Sun, 15 Nov 2020 08:15:21 +0000 (09:15 +0100)]
Add # to function bindings

3 years agoAdd parent maps
Jimmy Aguilar Mena [Sun, 15 Nov 2020 07:43:14 +0000 (08:43 +0100)]
Add parent maps

When completions-highlight-mode is enabled use
minibuffer-local-must-match-map as parent keymap.
(completions-highlight-minibuffer-map) : Enforces parent
minibuffer-local-must-match-map unconditionally.
(completions-highlight-completions-map) : Enforces
completion-list-mode-map as parent just in case.

3 years agoAdd autoload decorator.
Jimmy Aguilar Mena [Sun, 15 Nov 2020 07:11:14 +0000 (08:11 +0100)]
Add autoload decorator.

* lisp/completions-highlight.el (completions-highlight-mode) : Added
autoload decorator.

3 years agoSimplify overlay handling
Jimmy Aguilar Mena [Sun, 15 Nov 2020 07:01:47 +0000 (08:01 +0100)]
Simplify overlay handling

* lisp/completions-highlight.el (completions-highlight-overlay) :
created on load.
(completions-highlight-completions-pre-command-hook) : Don't move
overlay here.
(completions-highlight-minibuffer-pre-command-hook) : Use delete overlay
instead of conditional
(completions-highlight-mode) : Use overlay-put here instead of the setup.

3 years agoSimplify setting keymaps.
Jimmy Aguilar Mena [Sun, 15 Nov 2020 05:58:51 +0000 (06:58 +0100)]
Simplify setting keymaps.

*
lisp/completions-highlight.el (completions-highlight-minibuffer-map-save)
(completions-highlight-completions-map-save)
(completions-highlight-minibuffer-bindings) :
(completions-highlight-completions-bindings) : Removed functions and
variables.
(completions-highlight-mode) : Remove extra
minibuffer-hide-completions-hook insertion and remove.

3 years agoSimplify numeric argument
Jimmy Aguilar Mena [Sun, 15 Nov 2020 05:42:22 +0000 (06:42 +0100)]
Simplify numeric argument

* lisp/completions-highlight.el (completions-highlight-this-completion)
: Use prefix-numeric-value instead of manually check.

3 years agoFix corner case when going out of bounds
Jimmy Aguilar Mena [Sun, 15 Nov 2020 03:42:49 +0000 (04:42 +0100)]
Fix corner case when going out of bounds

* lisp/completions-highlight.el : Don't go anywhere when in the fist or
last candidate.
* Remove some redundant calls to with-current-buffer

3 years agoFix recursive set-keymap-parent in completions-highlight.
Jimmy Aguilar Mena [Thu, 27 Aug 2020 00:34:13 +0000 (02:34 +0200)]
Fix recursive set-keymap-parent in completions-highlight.

*
lisp/completions-highlight.el (completions-highlight-minibuffer-bindings)
:
(completions-highlight-completions-bindings) : Condition
set-keymap-parent to avoid error.

3 years agoImprove keymap handling.
Jimmy Aguilar Mena [Wed, 26 Aug 2020 23:13:57 +0000 (01:13 +0200)]
Improve keymap handling.

*
lisp/completions-highlight.el (completions-highlight-minibuffer-map-save) :
(completions-highlight-completions-map-save) : New variables to store
the maps before enabling mode.

(completions-highlight-minibuffer-map) :
(completions-highlight-completions-map) : Maps for the mode in
minibuffer and Completions.
(completions-highlight-minibuffer-bindings) :
(completions-highlight-completions-bindings) : Modified to do maps
handling using maps parent.
(completions-highlight-minibuffer-tab-through-completions) : Add call to
completions-highlight-completions-bindings.
(completions-highlight-minibuffer-bindings) : Fix name.

3 years agoFix initial comment in completions-highlight file.
Jimmy Aguilar Mena [Wed, 26 Aug 2020 20:20:52 +0000 (22:20 +0200)]
Fix initial comment in completions-highlight file.

* lisp/completions-highlight.el : Remove and fix some comments.

3 years agoAdd completions-highlight-mode initial implementation.
Jimmy Aguilar Mena [Wed, 26 Aug 2020 05:46:26 +0000 (07:46 +0200)]
Add completions-highlight-mode initial implementation.

New mode to highlight candidates in *Completions* buffer and improve
navigation.
* lisp/completions-highlight.el : New file with the initial working
implementation. This is an initial version but functional for the moment.

3 years agoDocument the changes in the API for Completions.
Jimmy Aguilar Mena [Wed, 26 Aug 2020 05:39:03 +0000 (07:39 +0200)]
Document the changes in the API for Completions.

* doc/lispref/hooks.texi : Document completion-setup-hook and
minibuffer-hide-completions-hook.
* doc/lispref/minibuf.texi : Add entries for the hooks.
* etc/NEWS : Briefly comment the modifications and the API.

3 years agoInsert some modifications to implement completions highlighting.
Jimmy Aguilar Mena [Wed, 26 Aug 2020 04:59:26 +0000 (06:59 +0200)]
Insert some modifications to implement completions highlighting.

This are changes needed in the minibuffer API to do highlighting from a
different package.

* lisp/minibuffer.el (minibuffer-tab-through-completions-function) : New
variable containing the action to do when pressing tab in minibuffer
and *Completions* are shown.
(minibuffer-tab-through-completions-default) : Default function value
for minibuffer-tab-through-completions-function.
(completion--in-region-1) : Modification to funcall
minibuffer-tab-through-completions-function.
(minibuffer-hide-completions-hook) : New hook to call after
closing *Completions* buffer.
(minibuffer-hide-completions) : Modify to run hook
minibuffer-hide-completions-hook.

3 years agoRemove XEmacs compat code from idlw-shell.el
Stefan Kangas [Fri, 20 Nov 2020 15:22:35 +0000 (16:22 +0100)]
Remove XEmacs compat code from idlw-shell.el

* lisp/progmodes/idlw-shell.el:
(idlwave-shell-use-toolbar): Doc fix.
(idlwave-default-mouse-track-event-is-with-button): Declare obsolete.
(idlwave-shell-update-bp-overlays): Remove XEmacs compat code.

3 years agoRemove some XEmacs compat code from ediff-wind.el
Stefan Kangas [Fri, 20 Nov 2020 15:19:14 +0000 (16:19 +0100)]
Remove some XEmacs compat code from ediff-wind.el

* lisp/vc/ediff-wind.el (ediff-window)
(ediff-compute-toolbar-width): Remove some XEmacs compat code.

3 years agoRemove Emacs 20 compat code from org.el
Stefan Kangas [Fri, 20 Nov 2020 14:17:22 +0000 (15:17 +0100)]
Remove Emacs 20 compat code from org.el

* lisp/org/org.el (org-org-menu, org-create-customize-menu):
Remove Emacs 20 compat code.

3 years agoRemove Emacs 20 compat code from idlwave.el
Stefan Kangas [Fri, 20 Nov 2020 14:13:08 +0000 (15:13 +0100)]
Remove Emacs 20 compat code from idlwave.el

* lisp/progmodes/idlwave.el (idlwave-indent-line)
(idlwave-toggle-comment-region, idlwave-reset-sintern)
(idlwave-unit-name, idlwave-mode-menu-def)
(idlwave-create-customize-menu): Remove Emacs 20 compat code.

3 years agoProperly mark obsolete semantic functions as such
Stefan Kangas [Fri, 20 Nov 2020 13:57:22 +0000 (14:57 +0100)]
Properly mark obsolete semantic functions as such

* lisp/cedet/semantic/ia.el (semantic-ia-get-completions)
(semantic-ia-get-completions-deprecated): Make obsolete.

3 years agoMark compat alias in cus-face.el obsolete
Stefan Kangas [Fri, 20 Nov 2020 13:56:49 +0000 (14:56 +0100)]
Mark compat alias in cus-face.el obsolete

* lisp/cus-face.el (custom-facep): Mark compat alias obsolete.
* lisp/cus-dep.el (custom-make-dependencies):
* lisp/cus-edit.el (customize-changed-options)
(custom-unsaved-options, customize-saved, customize-apropos)
(custom-save-faces): Adjust callers.

3 years agoFix compilation on MS-Windows with librsvg > 2.46.0
Eli Zaretskii [Fri, 20 Nov 2020 15:00:36 +0000 (17:00 +0200)]
Fix compilation on MS-Windows with librsvg > 2.46.0

* src/image.c (rsvg_handle_get_dimensions, init_svg_functions):
Make 'rsvg_handle_get_dimensions' available and defined for all
versions of librsvg.  (Bug#44655)

3 years agoHide obsolete options in most customize commands
Stefan Kangas [Fri, 20 Nov 2020 13:33:25 +0000 (14:33 +0100)]
Hide obsolete options in most customize commands

* lisp/cus-edit.el (custom--filter-obsolete-variables): New defun.
* lisp/cus-edit.el (customize-changed-options)
(customize-apropos, custom-group-value-create): Hide obsolete user
options.  (Bug#44598)
* test/lisp/cus-edit-tests.el: New file.

3 years agoRevert unintended part of last change to jsonrpc-request
João Tãvora [Fri, 20 Nov 2020 10:02:52 +0000 (10:02 +0000)]
Revert unintended part of last change to jsonrpc-request

While playing around with the timing in this function, I left
this change that could freeze the function on some platforms.

* lisp/jsonrpc.el (jsonrpc-request): Use accept-process-output.
(Version): Bump to 1.0.14

3 years agoMove semantic/tag obsolete variables to avoid a warning
Lars Ingebrigtsen [Fri, 20 Nov 2020 02:33:38 +0000 (03:33 +0100)]
Move semantic/tag obsolete variables to avoid a warning

* lisp/cedet/semantic/tag.el (semantic-token-version): Move to
avoid a compilation warning.

3 years agoFix default timeout handling in jsonrpc-request
João Távora [Fri, 20 Nov 2020 01:18:16 +0000 (01:18 +0000)]
Fix default timeout handling in jsonrpc-request

* lisp/jsonrpc.el (jsonrpc-request): Use default timeout if not passed.
(Version): Bump to 1.0.13

3 years agoAvoid a compilation warning about an ambiguous else
Lars Ingebrigtsen [Thu, 19 Nov 2020 23:19:18 +0000 (00:19 +0100)]
Avoid a compilation warning about an ambiguous else

* src/data.c (set_internal): Avoid compilation warning.

data.c:1443:9: error: suggest explicit braces to avoid ambiguous ‘else’
 1443 |      if (idx > 0 && bindflag == SET_INTERNAL_SET
      |         ^

3 years ago* src/data.c (set_internal): Fix bug#44733
Stefan Monnier [Thu, 19 Nov 2020 22:13:04 +0000 (17:13 -0500)]
* src/data.c (set_internal): Fix bug#44733

Set the default value when `set` encounters a PER_BUFFER variable
which has been let-bound globally, to match the behavior seen with
`make-variable-buffer-local`.

* test/src/data-tests.el (binding-test--let-buffer-local):
Add corresponding test.
(data-tests--set-default-per-buffer): Add tentative test for the
performance problem encountered in bug#41029.

3 years agoRemove some XEmacs compat code from filesets.el
Stefan Kangas [Thu, 19 Nov 2020 19:58:26 +0000 (20:58 +0100)]
Remove some XEmacs compat code from filesets.el

* lisp/filesets.el (filesets-init): Remove some XEmacs compat code.
(filesets-error): Declare obsolete.
(filesets-directory-files, filesets-get-selection)
(filesets-spawn-external-viewer, filesets-get-filelist)
(filesets-open, filesets-close, filesets-get-menu-epilog)
(filesets-ingroup-collect-files, filesets-build-ingroup-submenu)
(filesets-update-pre010505): Adjust callers.

3 years agoRemove some compat code from ffap.el
Stefan Kangas [Thu, 19 Nov 2020 16:46:16 +0000 (17:46 +0100)]
Remove some compat code from ffap.el

* lisp/ffap.el (ffap-mouse-event, ffap-event-buffer): Make obsolete.
(ffap-menu-ask, ffap-at-mouse): Adjust callers.

3 years agoDeclare some compat aliases obsolete
Stefan Kangas [Thu, 19 Nov 2020 16:42:14 +0000 (17:42 +0100)]
Declare some compat aliases obsolete

* lisp/cedet/semantic/tag.el (semantic-token-version)
(semantic-token-incompatible-version):
* lisp/emulation/edt.el (edt-bind-standard-key): Make compat
aliases obsolete.

3 years agoRemove some compat code from url.el
Stefan Kangas [Thu, 19 Nov 2020 16:41:18 +0000 (17:41 +0100)]
Remove some compat code from url.el

* lisp/url/url.el (url-warn): Make into obsolete alias for
display-warning.
* lisp/url/url-auth.el (url-register-auth-scheme):
* lisp/url/url-news.el (url-news-open-host):
* lisp/url/url-proxy.el (url-find-proxy-for-url): Adjust callers.

3 years agoRemove some compat code for old versions and XEmacs
Stefan Kangas [Thu, 19 Nov 2020 05:42:46 +0000 (06:42 +0100)]
Remove some compat code for old versions and XEmacs

* lisp/ibuf-ext.el (ibuffer-old-saved-filters-warning)
(ibuffer-maybe-save-stuff): Assume customize-save-variable is
bound; it is autoloaded.
* lisp/cedet/semantic/symref/grep.el (semantic-symref-perform-search):
* lisp/password-cache.el (password-cache-remove):
* lisp/cedet/semantic/bovine/el.el (semantic-dependency-tag-file):
Remove Emacs 21 compat code.
* lisp/cedet/semantic/sort.el (semantic-string-lessp-ci):
Remove Emacs 20 compat code.
* test/lisp/cedet/semantic-utest.el (semantic-utest-temp-directory):
* lisp/mail/supercite.el (sc-ask): Remove XEmacs compat code.
* lisp/progmodes/idlw-shell.el (idlwave-shell-mode):
* lisp/progmodes/idlwave.el (idlwave-mode): Remove commented out
compat code.

3 years ago* src/buffer.h (struct buffer): Remove unused field `minor_modes`
Stefan Monnier [Thu, 19 Nov 2020 18:10:20 +0000 (13:10 -0500)]
* src/buffer.h (struct buffer): Remove unused field `minor_modes`

* src/buffer.c (bset_minor_modes): Remove function.
(reset_buffer_local_variables, init_buffer_once): Don't set `minor_modes`.

3 years agoUse decoding implementation from `insert-directory' in Tramp
Michael Albinus [Thu, 19 Nov 2020 16:18:36 +0000 (17:18 +0100)]
Use decoding implementation from `insert-directory' in Tramp

* lisp/net/tramp-sh.el (tramp-sh-handle-insert-directory):
Use decoding implementation from `insert-directory', it is more robust.

3 years agoMore string-search optimisations
Mattias Engdegård [Thu, 19 Nov 2020 13:24:24 +0000 (14:24 +0100)]
More string-search optimisations

All-ASCII strings cannot have substrings with non-ASCII characters in
them; use this fact to avoid searching entirely.

* src/fns.c (Fstring_search): For multibyte non-ASCII needle and
unibyte haystack, don't check if the haystack is all-ASCII; it's a
waste of time. For multibyte non-ASCII needle and multibyte
all-ASCII haystack, fail immediately.
* test/src/fns-tests.el (string-search): Add more test cases.

3 years ago* etc/NEWS: Restore entries accidentally removed by previous commit.
Alan Mackenzie [Thu, 19 Nov 2020 13:24:28 +0000 (13:24 +0000)]
* etc/NEWS: Restore entries accidentally removed by previous commit.

3 years agoIn attempted recursive minibuffer use, display error message in correct frame
Alan Mackenzie [Thu, 19 Nov 2020 10:31:50 +0000 (10:31 +0000)]
In attempted recursive minibuffer use, display error message in correct frame

This was problematic when minibuffer-follows-selected-frame was non-nil.
Introduce a new parameter DONT-SET-FRAME to set-window-configuration.

* doc/lispref/windows.texi (Window Configurations): Describe the new &optional
parameter to set-window-configuration.

* etc/NEWS (Lisp Changes): Note the new parameter to set-window-configuration.

* src/keyboard.c (read_char_help_form_unwind): Add a new Qnil argument to the
call of Fset_window_configuration.

* src/minibuf.c (read_minibuf): Cons up a Qt with the window configuration in
the argument to record_unwind_protect for the window configuration (twice).

* src/window.c (Fset_window_configuration): Add the new &optional parameter
and document it in the doc string.  At the final do_switch_frame operation,
restore the original frame when DONT-SET-FRAME is non-nil.
(restore_window_configuration): Handle the new parameter when the supplied
argument is a cons.

3 years agoRemove outdated comment about Emacs 20 from viper.el
Stefan Kangas [Thu, 19 Nov 2020 05:34:11 +0000 (06:34 +0100)]
Remove outdated comment about Emacs 20 from viper.el

* lisp/emulation/viper-util.el (viper-chars-in-region): Remove
outdated comment.

3 years agoAdd new variable cperl-tags-file-name
Stefan Kangas [Thu, 19 Nov 2020 05:12:25 +0000 (06:12 +0100)]
Add new variable cperl-tags-file-name

* lisp/progmodes/cperl-mode.el (cperl-tags-file-name): New variable.
(cperl-write-tags): Use above new variable instead of hardcoding
filename "TAGS".  (Bug#8802)

3 years agoDeclare XEmacs compat function in inversion.el obsolete
Stefan Kangas [Thu, 19 Nov 2020 02:14:19 +0000 (03:14 +0100)]
Declare XEmacs compat function in inversion.el obsolete

* lisp/cedet/inversion.el (inversion-require-emacs): Declare obsolete.

3 years agoAssume font-lock is provided; it's preloaded since 22.1
Stefan Kangas [Thu, 19 Nov 2020 01:56:34 +0000 (02:56 +0100)]
Assume font-lock is provided; it's preloaded since 22.1

* lisp/cedet/semantic/format.el (semantic--format-colorize-text):
* lisp/eshell/em-ls.el (eshell-ls--insert-directory):
* lisp/net/dig.el (dig-mode):
* lisp/progmodes/cperl-mode.el (cperl-pod-here-fontify):
* lisp/progmodes/idlw-help.el (idlwave-help-fontify):
* lisp/progmodes/idlwave.el (idlwave-completion-fontify-classes):
Don't check for feature 'font-lock; it has been preloaded since 22.1.
* lisp/cedet/semantic/format.el (font-lock):
* lisp/epa.el (font-lock):
* lisp/erc/erc.el (font-lock):
* lisp/generic-x.el (font-lock):
* lisp/net/sieve-mode.el (font-lock):
* lisp/progmodes/prolog.el (font-lock):
* lisp/textmodes/rst.el (font-lock): Remove unnecessary require.

3 years ago* lisp/progmodes/cperl-mode.el: Doc fix.
Stefan Kangas [Thu, 19 Nov 2020 01:54:26 +0000 (02:54 +0100)]
* lisp/progmodes/cperl-mode.el: Doc fix.

3 years agoRemove unnecessary load from idlwave
Stefan Kangas [Thu, 19 Nov 2020 01:39:09 +0000 (02:39 +0100)]
Remove unnecessary load from idlwave

* lisp/progmodes/idlw-shell.el:
* lisp/progmodes/idlwave.el: Remove unnecessary load; easy-menu-define
is autoloaded.

3 years agoMake compat alias add-submenu obsolete
Stefan Kangas [Thu, 19 Nov 2020 00:44:25 +0000 (01:44 +0100)]
Make compat alias add-submenu obsolete

* lisp/emacs-lisp/easymenu.el (add-submenu): Make compat alias
obsolete.
* lisp/filesets.el (filesets-build-menu-now): Don't use above
obsolete alias.
(filesets-menu-path, filesets-menu-before)
(filesets-menu-in-menu): Doc fix.

3 years agoFix SVG display again (bug#44655)
Alan Third [Sun, 15 Nov 2020 17:21:03 +0000 (17:21 +0000)]
Fix SVG display again (bug#44655)

* src/image.c (svg_load_image): Fall back to
rsvg_handle_get_dimensions if we can't calculate the size of the
image.

3 years agoClarify that 'diff-error' is part of Emacs 28.1
Protesilaos Stavrou [Wed, 18 Nov 2020 21:14:39 +0000 (23:14 +0200)]
Clarify that 'diff-error' is part of Emacs 28.1

* lisp/vc/diff-mode.el (diff-error): Add :version tag (bug#44727).

3 years agoTurn gdb-wait-for-pending into a plain function
Mattias Engdegård [Wed, 18 Nov 2020 09:55:41 +0000 (10:55 +0100)]
Turn gdb-wait-for-pending into a plain function

This avoids unnecessary body duplication in expansion and macro
recursion (causing macro-expansions at runtime), making it clearer
what is going on.

* lisp/progmodes/gdb-mi.el (gdb-wait-for-pending): Make it a function,
remove lambda quoting,  η-reduce and simplify.
(gdb-thread-exited, gdb-thread-selected): Adapt callers.

3 years agoDon't make bibtex-unify-case-convert buffer-local
Basil L. Contovounesios [Wed, 18 Nov 2020 11:47:54 +0000 (11:47 +0000)]
Don't make bibtex-unify-case-convert buffer-local

The :local tag does not currently work as intended (it results in a
default value of bibtex-unify-case-convert of nil rather than
identity), and no other bibtex.el user option is automatically
buffer-local, so revert this recent change.

For discussion, see the following emacs-devel thread:
https://lists.gnu.org/r/emacs-devel/2020-11/msg00734.html

* lisp/textmodes/bibtex.el (bibtex-unify-case-convert): Don't make
automatically buffer-local for consistency with other user options,
and because the :local tag doesn't have the intended results.

3 years agoPreserve `dired-filename' text properties in Tramp
Michael Albinus [Wed, 18 Nov 2020 10:32:38 +0000 (11:32 +0100)]
Preserve `dired-filename' text properties in Tramp

* lisp/net/tramp-sh.el (tramp-sh-handle-insert-directory):
Restore `dired-filename' text property, which has been destroyed
by `decode-coding-region'.  (Bug#44682)

3 years agoRemove redundant 'function's around lambdas
Stefan Kangas [Tue, 17 Nov 2020 17:42:38 +0000 (18:42 +0100)]
Remove redundant 'function's around lambdas

* lisp/allout.el (allout-latex-verb-quote):
* lisp/edmacro.el (edmacro-format-keys):
* lisp/ffap.el (ffap-all-subdirs-loop)
(ffap-kpathsea-expand-path, ffap-menu-rescan):
* lisp/files.el (save-buffers-kill-emacs):
* lisp/find-lisp.el (find-lisp-find-dired-internal)
(find-lisp-insert-directory):
* lisp/gnus/gnus-agent.el (gnus-agent-expire-unagentized-dirs):
* lisp/gnus/nnmairix.el (nnmairix-create-message-line-for-search)
(nnmairix-widget-get-values)
(nnmairix-widget-make-query-from-widgets)
(nnmairix-widget-build-editable-fields):
* lisp/international/mule-cmds.el (sort-coding-systems):
* lisp/international/mule-diag.el (list-character-sets-1):
* lisp/international/quail.el (quail-insert-decode-map):
* lisp/mail/reporter.el (reporter-dump-state):
* lisp/mail/supercite.el (sc-attribs-filter-namelist):
* lisp/pcmpl-gnu.el (pcmpl-gnu-zipped-files)
(pcmpl-gnu-bzipped-files):
* lisp/progmodes/cperl-mode.el (cperl-find-tags)
(cperl-write-tags, cperl-tags-hier-init, cperl-tags-treeify)
(cperl-menu-to-keymap, cperl-pod-spell):
* lisp/progmodes/gdb-mi.el (gdb-parent-mode):
* lisp/progmodes/make-mode.el (makefile-browser-fill):
* lisp/simple.el (transpose-lines):
* lisp/term.el:
* lisp/term/w32-win.el (w32-find-non-USB-fonts):
* lisp/textmodes/table.el (table--generate-source-scan-lines): Remove
redundant 'function's around lambdas.

3 years agoRemove redundant 'function's around lambdas in mh/*.el
Stefan Kangas [Tue, 17 Nov 2020 02:13:50 +0000 (03:13 +0100)]
Remove redundant 'function's around lambdas in mh/*.el

* lisp/mh-e/mh-alias.el (mh-alias-tstamp, mh-alias-filenames)
(mh-alias-address-to-alias):
* lisp/mh-e/mh-comp.el (mh-edit-again, mh-redistribute):
* lisp/mh-e/mh-identity.el (mh-identity-make-menu):
* lisp/mh-e/mh-utils.el (mh-help): Remove redundant 'function's around
lambdas.

3 years agoEnhance syntax-tests.el to test nestable comments (Lisp style)
Alan Mackenzie [Tue, 17 Nov 2020 16:51:49 +0000 (16:51 +0000)]
Enhance syntax-tests.el to test nestable comments (Lisp style)

Also add some tests for braces and parse-partial-sexp amongst Lisp style
comments.

* test/src/syntax-tests.el (\;-in, \;-out): Add syntax for { and }.
(top-level): Add new tests for Lisp style comments.
(\#|-in, \#|-out): New functions.
(top-level): Add new tests for nested Lisp style comments, and mixtures of
nested comments with "ordinary" comments.

* test/src/syntax-resources/syntax-comments.txt (top-level): Add new test
fragments for #|...|#, etc.

3 years agoDon't quote lambdas with 'function' in calc/*.el
Stefan Kangas [Tue, 17 Nov 2020 01:51:30 +0000 (02:51 +0100)]
Don't quote lambdas with 'function' in calc/*.el

* lisp/calc/calc-aent.el (calc-do-quick-calc)
(calc-do-calc-eval, math-build-parse-table):
* lisp/calc/calc-alg.el (math-polynomial-base):
* lisp/calc/calc-alg.el (math-is-poly-rec):
* lisp/calc/calc-arith.el (calcFunc-scf):
* lisp/calc/calc-arith.el (math-ceiling, math-round):
* lisp/calc/calc-arith.el (math-trunc-fancy, math-floor-fancy):
* lisp/calc/calc-ext.el (calc-init-extensions, calc-reset)
(calc-refresh-top, calc-z-prefix-help, calc-binary-op-fancy)
(calc-unary-op-fancy):
* lisp/calc/calc-forms.el (math-make-mod):
* lisp/calc/calc-frac.el (calcFunc-frac):
* lisp/calc/calc-funcs.el (calcFunc-euler):
* lisp/calc/calc-help.el (calc-full-help):
* lisp/calc/calc-lang.el (c, pascal, fortran, tex, latex, eqn)
(yacas, maxima, giac, math, maple):
* lisp/calc/calc-macs.el (calc-wrapper, calc-slow-wrapper):
* lisp/calc/calc-map.el (calc-get-operator, calcFunc-mapeqr)
(calcFunc-reducea, calcFunc-rreducea, calcFunc-reduced)
(calcFunc-rreduced, calcFunc-outer):
* lisp/calc/calc-misc.el (another-calc, calc-do-handle-whys):
* lisp/calc/calc-mode.el (calc-save-modes):
* lisp/calc/calc-mtx.el (math-col-matrix, math-mul-mat-vec):
* lisp/calc/calc-poly.el (math-sort-terms, math-poly-div-list)
(math-mul-list, math-sort-poly-base-list)
(math-partial-fractions):
* lisp/calc/calc-prog.el (calc-user-define-formula):
* lisp/calc/calc-rewr.el (math-rewrite, math-compile-patterns)
(math-compile-rewrites, math-parse-schedule)
(math-rwcomp-pattern):
* lisp/calc/calc-store.el (calc-var-name-map, calc-let)
(calc-permanent-variable, calc-insert-variables):
* lisp/calc/calc-stuff.el (calc-flush-caches, calcFunc-pclean)
(calcFunc-pfrac):
* lisp/calc/calc-units.el (math-build-units-table)
(math-decompose-units):
* lisp/calc/calc-vec.el (calcFunc-mrow, math-mat-col)
(calcFunc-mcol, math-mat-less-col, math-mimic-ident):
* lisp/calc/calc-yank.el (calc-edit):
* lisp/calc/calc.el
(calc-mode-var-list-restore-default-values)
(calc-mode-var-list-restore-saved-values, calc-mode, calc-quit):
* lisp/calc/calccomp.el (math-compose-expr)
(math-compose-matrix, math-vector-to-string): Don't quote lambdas with
'function'.

3 years agoAdd command to filter package menu by name or description
Stefan Kangas [Tue, 17 Nov 2020 11:13:13 +0000 (12:13 +0100)]
Add command to filter package menu by name or description

* lisp/emacs-lisp/package.el (package-menu-filter-by-description):
(package-menu-filter-by-name-or-description): New commands to filter
the package menu.  (Bug#44699)
(package-menu-mode-map): Bind the above new commands.
(package-menu-mode-menu): Add new commands to the menu.
* doc/emacs/package.texi (Package Menu): Document new commands.

3 years agoDon't quote lambdas with function macro in generic-x.el
Stefan Kangas [Tue, 17 Nov 2020 02:10:12 +0000 (03:10 +0100)]
Don't quote lambdas with function macro in generic-x.el

* lisp/generic-x.el (apache-conf-generic-mode, ini-generic-mode)
(reg-generic-mode, mailagent-rules-generic-mode)
(vrml-generic-mode, java-properties-generic-mode)
(alias-generic-mode, ansible-inventory-generic-mode)
(inetd-conf-generic-mode, etc-services-generic-mode)
(etc-passwd-generic-mode, etc-fstab-generic-mode)
(spice-generic-mode, astap-generic-mode): Don't quote lambdas with
function macro.

3 years agoTest that substitute-command-keys preserves text properties
Stefan Kangas [Tue, 17 Nov 2020 01:17:14 +0000 (02:17 +0100)]
Test that substitute-command-keys preserves text properties

* test/lisp/help-tests.el
(help-substitute-command-keys/preserves-text-properties): New test.
(Bug#17052)

3 years ago; Fix last change to bibtex.el
Basil L. Contovounesios [Mon, 16 Nov 2020 23:16:23 +0000 (23:16 +0000)]
; Fix last change to bibtex.el

* lisp/textmodes/bibtex.el (bibtex-unify-case-convert): Clarify
docstring and remove leading asterisk.  Use defcustom :local tag.

3 years agoperl-mode and cperl-mode: Recognize regex after "return"
Harald Jörg [Mon, 16 Nov 2020 23:20:26 +0000 (00:20 +0100)]
perl-mode and cperl-mode: Recognize regex after "return"

* lisp/progmodes/cperl-mode.el (cperl-find-pods-heres): Add
"return" to the keywords which start a regex.

* lisp/progmodes/perl-mode.el (defconst): Add "return" to
'perl--syntax-exp-intro-keywords' (Bug#26850).

* test/lisp/progmodes/cperl-mode-tests.el (cperl-test-bug-28650):
New test (bug#26850).

3 years agoMinor Edebug manual keystroke clarifications
Lars Ingebrigtsen [Mon, 16 Nov 2020 23:18:11 +0000 (00:18 +0100)]
Minor Edebug manual keystroke clarifications

* doc/lispref/edebug.texi (Edebug Misc): Also mention the `a'
binding to abort (bug#44697).  Also fix `d' function reference, and
add `P' reference.

3 years agoMake the handwrite.el PS valid again
Lars Ingebrigtsen [Mon, 16 Nov 2020 22:54:02 +0000 (23:54 +0100)]
Make the handwrite.el PS valid again

* lisp/play/handwrite.el (handwrite): Make the PS valid
(bug#44648).  Suggested by Omar Antolín <omar.antolin@gmail.com>.

3 years agoFix gnus-mime-display-alternative button natigation
Lars Ingebrigtsen [Mon, 16 Nov 2020 22:16:39 +0000 (23:16 +0100)]
Fix gnus-mime-display-alternative button natigation

* lisp/gnus/gnus-art.el (gnus-mime-display-alternative): Mark the
buttons correctly so that TAB can find them (bug#44690).

3 years agoUse 'eshell-find-alias-function' instead of fboundp
Ruthra Kumar [Mon, 16 Nov 2020 22:04:36 +0000 (23:04 +0100)]
Use 'eshell-find-alias-function' instead of fboundp

* lisp/eshell/esh-cmd.el (eshell-invoke-directly): Fix problem
with (require 'em-tramp) making password prompting from "sudo
bash" no longer work (bug#43772).

3 years agoAdd new user option bibtex-unify-case-convert
Francesco Potortì [Mon, 16 Nov 2020 21:36:05 +0000 (22:36 +0100)]
Add new user option bibtex-unify-case-convert

* lisp/textmodes/bibtex.el (bibtex-unify-case-convert): New
variable (bug#44614).
(bibtex-format-entry): Use it (bug#44614).

3 years agoUse lexical-binding in time-stamp.el
Stefan Kangas [Sun, 15 Nov 2020 19:12:45 +0000 (20:12 +0100)]
Use lexical-binding in time-stamp.el

* lisp/time-stamp.el: Use lexical-binding.  Remove redundant :group
args.

3 years agoDon't quote lambdas in net/*.el
Stefan Kangas [Mon, 16 Nov 2020 17:52:42 +0000 (18:52 +0100)]
Don't quote lambdas in net/*.el

* lisp/net/eudc-export.el (eudc-create-bbdb-record):
* lisp/net/eudc.el (eudc-print-attribute-value)
(eudc-display-records, eudc-process-form)
(eudc-filter-duplicate-attributes, eudc-filter-partial-records)
(eudc-add-field-to-records, eudc-query-with-words)
(eudc-query-form, eudc-menu):
* lisp/net/eudcb-bbdb.el (eudc-bbdb-extract-phones)
(eudc-bbdb-query-internal):
* lisp/net/mairix.el (mairix-widget-make-query-from-widgets)
(mairix-widget-build-editable-fields, mairix-widget-get-values):
Don't quote lambdas.

3 years agoDon't quote lambdas in emacs-lisp/*.el
Stefan Kangas [Mon, 16 Nov 2020 16:03:45 +0000 (17:03 +0100)]
Don't quote lambdas in emacs-lisp/*.el

* lisp/emacs-lisp/cl-seq.el (cl--parsing-keywords, cl-sort):
* lisp/emacs-lisp/cl-macs.el (cl-typecase):
* lisp/emacs-lisp/cl-extra.el (cl-some, cl-every)
(cl--map-keymap-recursively):
* lisp/emacs-lisp/advice.el (ad-insert-argument-access-forms):
* lisp/emacs-lisp/edebug.el (edebug-sort-alist)
(edebug-set-windows):
* lisp/emacs-lisp/pp.el (pp-display-expression):
* lisp/emacs-lisp/regi.el (regi-interpret): Don't quote lambdas.

3 years agoMerge from origin/emacs-27
Glenn Morris [Mon, 16 Nov 2020 17:05:31 +0000 (09:05 -0800)]
Merge from origin/emacs-27

75723ec212 (origin/emacs-27) ; * lisp/emacs-lisp/benchmark.el (benchm...
53e2a612ad ; * lib-src/make-fingerprint.c: Update commentary.
286c632772 Reformat argument commentary in etags.c
4ec740866a Make the invocation of combine-change-calls in comment-reg...
66bcec8838 * lisp/progmodes/cc-langs.el (c-<>-notable-chars-re): Fix ...
03eeab469e ; Update the expected result files in test/manual/etags.
d875a22bc6 Update the various INSTALL files

# Conflicts:
# INSTALL

3 years ago; Merge from origin/emacs-27
Glenn Morris [Mon, 16 Nov 2020 16:59:47 +0000 (08:59 -0800)]
; Merge from origin/emacs-27

The following commit was skipped:

e2c7b6372d Don't leave lock files after 'replace-buffer-contents'

3 years agoMerge from origin/emacs-27
Glenn Morris [Mon, 16 Nov 2020 16:59:47 +0000 (08:59 -0800)]
Merge from origin/emacs-27

19da602991 Fix input method translation near read-only text
5aabf2cc7f Fix display of truncated R2L lines on TTY frames
daff3bda10 Avoid crashes when a reversed glyph row starts with a comp...
b697bb91a1 ; * .gitignore: src/fingerprint.c not generated since 2019...

3 years agoDon't quote lambdas in calc/calcalg{2,3}.el
Stefan Kangas [Mon, 16 Nov 2020 15:53:24 +0000 (16:53 +0100)]
Don't quote lambdas in calc/calcalg{2,3}.el

* lisp/calc/calcalg2.el (calcFunc-inv\', calcFunc-sqrt\')
(calcFunc-deg\', calcFunc-rad\', calcFunc-ln\')
(calcFunc-log10\', calcFunc-lnp1\', calcFunc-log\')
(calcFunc-log\'2, calcFunc-exp\', calcFunc-expm1\')
(calcFunc-sin\', calcFunc-cos\', calcFunc-tan\', calcFunc-sec\')
(calcFunc-csc\', calcFunc-cot\', calcFunc-arcsin\')
(calcFunc-arccos\', calcFunc-arctan\', calcFunc-sinh\')
(calcFunc-cosh\', calcFunc-tanh\', calcFunc-sech\')
(calcFunc-csch\', calcFunc-coth\', calcFunc-arcsinh\')
(calcFunc-arccosh\', calcFunc-arctanh\', calcFunc-bern\'2)
(calcFunc-euler\'2, calcFunc-gammag\'2, calcFunc-gammaG\'2)
(calcFunc-gammaP\'2, calcFunc-gammaQ\'2, calcFunc-betaB\')
(calcFunc-betaI\', calcFunc-erf\', calcFunc-erfc\')
(calcFunc-besJ\'2, calcFunc-besY\'2, calcFunc-sum)
(calcFunc-prod, calcFunc-integ, calcFunc-if, calcFunc-subscr)
(math-do-integral, calcFunc-integ, math-decompose-poly)
(math-solve-system-rec, math-solve-system-subst, math-solve-for)
(calcFunc-inv, calcFunc-sqrt, calcFunc-conj, calcFunc-abs)
(calcFunc-deg, calcFunc-rad, calcFunc-ln, calcFunc-log10)
(calcFunc-lnp1, calcFunc-exp, calcFunc-expm1, calcFunc-sin)
(calcFunc-cos, calcFunc-tan, calcFunc-arcsin, calcFunc-arccos)
(calcFunc-arctan, calcFunc-sinh, calcFunc-cosh, calcFunc-tanh)
(calcFunc-arcsinh, calcFunc-arccosh, calcFunc-arctanh):
* lisp/calc/calcalg3.el (calc-get-fit-variables)
(calcFunc-polint, calcFunc-ratint, math-all-vars-but): Don't quote
lambdas.

3 years agoDon't quote lambdas in eshell/*.el
Stefan Kangas [Mon, 16 Nov 2020 13:43:55 +0000 (14:43 +0100)]
Don't quote lambdas in eshell/*.el

* lisp/eshell/em-basic.el (eshell-echo):
* lisp/eshell/em-cmpl.el (eshell-command-completion-function)
(eshell-default-completion-function, eshell-cmpl-initialize)
(eshell-complete-parse-arguments, eshell-complete-commands-list):
* lisp/eshell/em-dirs.el (eshell-complete-user-reference):
* lisp/eshell/em-hist.el (eshell-hist-unload-hook)
(eshell-hist-initialize):
* lisp/eshell/em-ls.el (eshell-ls-sort-entries):
* lisp/eshell/em-pred.el (eshell-modifier-alist)
(eshell-display-predicate-help, eshell-display-modifier-help)
(eshell-pred-substitute, eshell-split-members):
* lisp/eshell/em-prompt.el (eshell-prompt-function):
* lisp/eshell/em-smart.el (eshell-smart-unload-hook)
(eshell-smart-initialize, eshell-refresh-windows):
* lisp/eshell/em-unix.el (eshell-shuffle-files):
* lisp/eshell/esh-arg.el (eshell-parse-argument-hook):
* lisp/eshell/esh-cmd.el (eshell-cmd-initialize)
(eshell-parse-command):
* lisp/eshell/esh-mode.el (eshell-preinput-scroll-to-bottom)
(eshell-postoutput-scroll-to-bottom):
* lisp/eshell/esh-module.el (eshell-modules-list):
* lisp/eshell/esh-proc.el (eshell-read-process-name)
(eshell-round-robin-kill):
* lisp/eshell/esh-var.el (eshell-envvar-names)
(eshell-variables-list): Don't quote lambdas.

3 years ago; * lisp/emacs-lisp/benchmark.el (benchmark-run): Fix docstring
Philipp Stephani [Mon, 16 Nov 2020 11:48:54 +0000 (12:48 +0100)]
; * lisp/emacs-lisp/benchmark.el (benchmark-run): Fix docstring

3 years ago; * lib-src/make-fingerprint.c: Update commentary.
Glenn Morris [Sun, 15 Nov 2020 23:08:58 +0000 (15:08 -0800)]
; * lib-src/make-fingerprint.c: Update commentary.

3 years agoNew user options 'copy-region-blink-delay' and 'delete-pair-blink-delay'
Juri Linkov [Sun, 15 Nov 2020 20:32:39 +0000 (22:32 +0200)]
New user options 'copy-region-blink-delay' and 'delete-pair-blink-delay'

* lisp/emacs-lisp/lisp.el (delete-pair-blink-delay): New defcustom.
(delete-pair): Use it.  (Bug#4136)

* lisp/simple.el (copy-region-blink-delay): New defcustom.
(indicate-copied-region): Use it.  (Bug#42865)
Thanks to Sean Whitton <spwhitton@spwhitton.name>.
(indicate-copied-region): Use 'query-replace-descr' not to show
newlines literally.  Use "Copied text" instead of misleading
"Saved text" (bug#42865).

3 years agoReformat argument commentary in etags.c
Eli Zaretskii [Sun, 15 Nov 2020 17:26:38 +0000 (19:26 +0200)]
Reformat argument commentary in etags.c

* lib-src/etags.c (pfnote, consider_token, C_entries): Resurrect
original format of comments to function arguments.

3 years agoReformat comment for 'gnu' compilation rule
Mattias Engdegård [Sun, 15 Nov 2020 16:54:41 +0000 (17:54 +0100)]
Reformat comment for 'gnu' compilation rule

* lisp/progmodes/compile.el (compilation-error-regexp-alist-alist):
The comments above the regexp for the 'gnu' rule contained
references to the previous string regexp, which has been difficult
to follow ever since the translation to rx.  Move the comments
to their proper places, and add some guiding notes.

3 years agoMake the invocation of combine-change-calls in comment-region valid
Alan Mackenzie [Sun, 15 Nov 2020 13:23:15 +0000 (13:23 +0000)]
Make the invocation of combine-change-calls in comment-region valid

This fixes bug #44581.  The problem was that whitespace outside of the (BEG
END) region was being deleted, and this made the invocation of
combine-change-calls with (BEG END) invalid.

* lisp/newcomment.el (comment-region-default): Amend the second argument to
combine-change-calls.

3 years ago* lisp/progmodes/cc-langs.el (c-<>-notable-chars-re): Fix wrong '-' in regexp
Alan Mackenzie [Sun, 15 Nov 2020 10:34:54 +0000 (10:34 +0000)]
* lisp/progmodes/cc-langs.el (c-<>-notable-chars-re): Fix wrong '-' in regexp

3 years agoMake initial frame match frame-title-format
Stefan Kangas [Sun, 15 Nov 2020 01:41:36 +0000 (02:41 +0100)]
Make initial frame match frame-title-format

* src/xterm.c (x_term_init):
* src/w32term.c (w32_initialize_display_info): Sync initial frame
title with new value of Vframe_title_format.
Problem reported by Angelo Graziosi <angelo.g0@libero.it>.

3 years agoRun menu-item :filter function before showing binding
Stefan Kangas [Sat, 14 Nov 2020 23:53:32 +0000 (00:53 +0100)]
Run menu-item :filter function before showing binding

* lisp/help.el (describe-map): Fix running `menu-item' :filter
functions.  This fixes a mistake in the previous conversion of this
defun from the old C function describe_map.  See the discussion in
Bug#39149.
* test/src/keymap-tests.el
(keymap---get-keyelt/runs-menu-item-filter)
(describe-buffer-bindings/menu-item-filter-show-binding)
(describe-buffer-bindings/menu-item-filter-hide-binding):
New tests.
(keymap-tests--test-menu-item-filter): New defun.

3 years agoHandle negation of search keys in gnus-search minibuffer completion
Eric Abrahamsen [Sat, 14 Nov 2020 21:19:47 +0000 (13:19 -0800)]
Handle negation of search keys in gnus-search minibuffer completion

* lisp/gnus/gnus-search.el (gnus-search-get-active): Keys might start
with a leading "-": check for that and ignore it.

3 years ago* lisp/progmodes/xref.el (xref-goto-xref): Prefix arg quits the *xref* buffer.
Juri Linkov [Sat, 14 Nov 2020 20:36:13 +0000 (22:36 +0200)]
* lisp/progmodes/xref.el (xref-goto-xref): Prefix arg quits the *xref* buffer.

(bug#44611)

3 years ago* lisp/org/ob-ruby.el (org-babel-ruby-initiate-session): Use :ruby header arg.
Juri Linkov [Sat, 14 Nov 2020 20:18:38 +0000 (22:18 +0200)]
* lisp/org/ob-ruby.el (org-babel-ruby-initiate-session): Use :ruby header arg.

Allow specification of ruby command using the :ruby header arg.
https://lists.gnu.org/archive/html/emacs-orgmode/2020-11/msg00166.html

3 years agoFix `speedbar-directory-buttons' when using Tramp
Daniel Lenski [Sat, 14 Nov 2020 16:07:49 +0000 (17:07 +0100)]
Fix `speedbar-directory-buttons' when using Tramp

* lisp/speedbar.el (speedbar-directory-buttons): Make speedbar
work with directories accessed via Tramp (bug#44622).

Copyright-paperwork-exempt: yes

3 years agoDon't quote lambdas in several places
Stefan Kangas [Sat, 14 Nov 2020 16:04:23 +0000 (17:04 +0100)]
Don't quote lambdas in several places

* lisp/align.el (align-highlight-rule):
* lisp/bookmark.el (bookmark-maybe-sort-alist):
* lisp/emacs-lisp/advice.el (ad-read-advice-name)
(ad-retrieve-args-form, ad-make-hook-form, defadvice)
(ad-with-originals):
* lisp/foldout.el (foldout-inhibit-key-bindings):
* lisp/gnus/gnus-bookmark.el (gnus-bookmark-maybe-sort-alist):
* lisp/mail/rfc822.el (rfc822-addresses-1):
* lisp/net/eudcb-ldap.el (eudc-ldap-cleanup-record-simple):
* lisp/net/net-utils.el (network-connection-to-service):
* lisp/net/socks.el (socks-build-auth-list):
* lisp/org/ox-odt.el (org-odt--image-size):
* lisp/pcomplete.el (pcomplete-command-completion-function)
(pcomplete-default-completion-function, pcomplete-opt):
* lisp/progmodes/cperl-mode.el (cperl-highlight-charclass)
(cperl-tags-hier-init, cperl-tags-treeify)
(cperl-next-interpolated-REx, cperl-time-fontification):
* lisp/shadowfile.el (shadow-copy-files, shadow-shadows-of-1)
(shadow-save-buffers-kill-emacs):
* lisp/strokes.el (strokes-renormalize-to-grid):
* lisp/tempo.el (tempo-insert, tempo-forward-mark)
(tempo-backward-mark):
* lisp/textmodes/artist.el (artist-submit-bug-report):
* lisp/textmodes/ispell.el (ispell-complete-word):
* lisp/url/url-auth.el (url-get-authentication):
* lisp/url/url-cache.el (url-cache-create-filename-human-readable):
* lisp/vcursor.el (vcursor-find-window):
* test/lisp/textmodes/reftex-tests.el
(reftex-parse-bibtex-entry-test): Don't quote lambdas.

3 years agoWork around glib messing with signal handlers more than it should
Akira Kyle [Sat, 14 Nov 2020 15:39:41 +0000 (16:39 +0100)]
Work around glib messing with signal handlers more than it should

* src/process.c (init_process_emacs): force glib's g_unix_signal
handler into lib_child_handler where it should belong.

Copyright-paperwork-exempt: yes