Dmitry Gutov [Tue, 11 Feb 2020 22:19:25 +0000 (00:19 +0200)]
; Add a TODO
Dmitry Gutov [Tue, 11 Feb 2020 21:45:52 +0000 (23:45 +0200)]
vc-hg-dir-status-files: Fix when DIR is not repository root
* lisp/vc/vc-hg.el (vc-hg-dir-status-files):
Make sure it works correctly in a subdirectory of the repo root.
Bind default-directory to DIR and add 're: -I .' to the arguments
(bug#39380).
Alan Third [Tue, 11 Feb 2020 17:27:11 +0000 (17:27 +0000)]
Revert "Fix display of working text on NS (Bug#23412, Bug#1453)"
This reverts commit
ba042176d8931cdf9441b3b4919ec74b75019494.
Do not merge to master (bug#38851)
Alan Mackenzie [Mon, 10 Feb 2020 21:20:12 +0000 (21:20 +0000)]
c-end-of-macro: Handle block coment lines with unescaped NLs correctly
* lisp/progmodes/cc-langs.el (c-last-open-c-comment-start-on-line-re): Make
obsolete, and supersede by ...
(c-open-c-comment-on-logical-line-re): New language variable.
* lisp/progmodes/cc-engine.el (c-end-of-macro): Inside macros, handle
multiline block comments whose line ends are not escaped correctly.
Eli Zaretskii [Sun, 9 Feb 2020 17:18:38 +0000 (19:18 +0200)]
Fix set-fontset-font with ADD arg non-nil
* src/fontset.c (fontset_add): Fix off-by-one error at TO.
(Bug#39482)
Alan Mackenzie [Sun, 9 Feb 2020 14:33:14 +0000 (14:33 +0000)]
Correct "different than" to "different from" where appropriate
(doc/emacs/screen.texi)
(doc/lispintro/emacs-lisp-intro.texi)
(doc/misc/calc.texi)
(doc/misc/gnus.texi)
(doc/misc/sc.texi)
(lisp/align.el)
(lisp/allout-widgets.el)
(lisp/allout.el)
(lisp/emacs-lisp/gv.el)
(lisp/font-lock.el)
(lisp/gnus/mm-util.el)
(lisp/mail/feedmail.el)
(lisp/mail/sendmail.el)
(lisp/mail/supercite.el)
(lisp/org/org-attach.el)
(lisp/progmodes/cc-langs.el)
(lisp/progmodes/idlw-shell.el)
(lisp/ps-print.el)
(lisp/simple.el)
(src/cmds.c)
(src/editfns.c)
(src/frame.h)
(src/regex-emacs.c)
(src/xfaces.c): Replace "different than" by "different from".
Eli Zaretskii [Sat, 8 Feb 2020 09:38:52 +0000 (11:38 +0200)]
More accurate documentation of 'package-menu-hide-package'
* doc/emacs/package.texi (Package Menu): Improve the description
of the 'H' command.
* lisp/emacs-lisp/package.el (package-menu-mode-menu): More
accurate wording of the help-echo string.
(package-menu-hide-package): Make the doc string more accurate.
(Bug#39436)
Stefan Kangas [Thu, 6 Feb 2020 12:30:33 +0000 (13:30 +0100)]
Revert "Signal user-error on duplicate package refresh"
That commit caused errors when the connection was dropped in the
middle of a package refresh. To avoid any further issues this close
to the pretest, we simply remove this feature. (Bug#39187)
Don't merge to master, where we will instead try to fix the bug.
Juri Linkov [Wed, 5 Feb 2020 22:38:53 +0000 (00:38 +0200)]
Wrap some set-auto-mode calls with delay-mode-hooks (bug#39190)
* lisp/gnus/mm-view.el (mm-display-inline-fontify):
* lisp/vc/diff-mode.el (diff-syntax-fontify-props):
* lisp/vc/vc.el (vc-find-revision-no-save):
Add delay-mode-hooks around set-auto-mode calls
to not run hooks that might assume buffer-file-name
really associates buffer with a file.
Dmitry Gutov [Tue, 4 Feb 2020 23:50:12 +0000 (02:50 +0300)]
Support ido-vertical-mode better
* lisp/ido.el (ido-exhibit):
Prepend a space to INF if it starts with a newline (bug#39379).
Juri Linkov [Tue, 4 Feb 2020 23:27:30 +0000 (01:27 +0200)]
Fix faces tab-bar and tab-line.
* lisp/tab-bar.el (tab-bar) <
defface>:
* lisp/tab-line.el (tab-line) <
defface>:
Check for min-colors 88 instead of type x.
Robert Pluim [Fri, 31 Jan 2020 09:22:59 +0000 (10:22 +0100)]
Cater for 3-argument version of pthread_setname_np
Fixes Bug#39363.
* configure.ac: Add check for 3-argument version of
pthread_setname_np.
* src/systhread.c (sys_thread_set_name)
[HAVE_PTHREAD_SETNAME_NP_3ARG]: Call pthread_setname_np with
3 arguments.
Mattias Engdegård [Sun, 2 Feb 2020 11:48:51 +0000 (12:48 +0100)]
Clarify lexvar restrictions for add-to-ordered-list, add-to-history
* lisp/subr.el (add-to-ordered-list, add-to-history):
* doc/lispref/lists.texi (List Variables):
* doc/lispref/minibuf.texi (Minibuffer History):
Note in the doc string and manual that the variable arguments to
add-to-ordered-list and add-to-history cannot refer to a lexical
variable (bug#39373).
Mattias Engdegård [Sat, 1 Feb 2020 17:07:32 +0000 (18:07 +0100)]
Replace add-to-list to lexical variable with push (bug#39373)
Since 'add-to-list', being a plain function, cannot access lexical
variables, such use must be rewritten for correctness.
(Some instances actually do work thanks to a compiler macro,
but it's not something code should rely on.)
* lisp/autoinsert.el (auto-insert-alist):
* lisp/cedet/mode-local.el (mode-local-print-bindings):
* lisp/net/tramp-cache.el (tramp-flush-connection-properties)
(tramp-list-connections):
* lisp/net/zeroconf.el (zeroconf-list-service-names)
(zeroconf-list-service-types, zeroconf-list-services):
* lisp/org/org.el (org-reload):
* lisp/whitespace.el (whitespace-report-region):
* test/lisp/emacs-lisp/map-tests.el (test-map-do):
Replace add-to-list with push.
Mattias Engdegård [Sat, 1 Feb 2020 19:11:11 +0000 (20:11 +0100)]
Clarify add-to-list documentation (bug#39373)
While add-to-list often works with lexical variables, this is a hack
that isn't always effective; better tell the user not to try.
* doc/lispref/lists.texi (List Variables): Add a note about lexical
variables to the add-to-list description. Fix the equivalent code.
* lisp/subr.el (add-to-list): Amend doc string.
Stephen Gildea [Sat, 1 Feb 2020 17:28:30 +0000 (09:28 -0800)]
MH-E: alter content in mh-display-msg, not mh-show-mode
* lisp/mh-e/mh-show.el (mh-display-msg, mh-show-mode): buffer-altering
code formerly in mh-show-mode is moved to the location in mh-display-msg
where mh-show-mode used to be called before the fix to MH-E bug #470
moved the call earlier.
Stephen Gildea [Sat, 1 Feb 2020 17:18:46 +0000 (09:18 -0800)]
Update documentation for mh-show-mode-hook
* lisp/mh-e/mh-e.el, doc/misc/mh-e.texi (mh-show-mode-hook): Now that
the fix for MH-E bug #470 calls mh-show-mode-hook earlier, update the
documentation to no longer say that the message contents are available.
Stephen Gildea [Wed, 29 Jan 2020 17:21:19 +0000 (09:21 -0800)]
Example goto-addr hook: MH-E already uses goto-address
* lisp/net/goto-addr.el, doc/emacs/misc.texi: Do not use MH-E as the
example of how to add a hook to goto-address, because MH-E calls
goto-address internally.
Glenn Morris [Sat, 1 Feb 2020 14:11:46 +0000 (06:11 -0800)]
; Auto-commit of loaddefs files.
Ken Brown [Fri, 31 Jan 2020 02:58:33 +0000 (21:58 -0500)]
Extend workaround for Cygwin O_PATH bug
* configure.ac (HAVE_CYGWIN_O_PATH_BUG): Extend to Cygwin versions
3.1.0 through 3.1.2. (Bug#39371)
Paul Pogonyshev [Mon, 27 Jan 2020 03:54:32 +0000 (22:54 -0500)]
* lisp/emacs-lisp/debug.el (debug): Merge the non-interactive cases
bug#38927
(cherry picked from commit
502059433ce0e9699eb73d21656ce6e9e127d63b)
Ansgar Burchardt [Tue, 21 Jul 2015 11:05:39 +0000 (13:05 +0200)]
Add more blackboard bold characters to TeX input method
This patch adds all capital blackboard bold letters and those for "1"
and "2". Most characters are in common use in mathematics, but it does
not seem useful to exclude the few not widely used.
Reference: https://en.wikipedia.org/wiki/Blackboard_bold
* lisp/leim/quail/latin-ltx.el (latin-ltx--define-rules): Add all
the blackboard bold commands from AMSTeX. (Bug#21103)
Eli Zaretskii [Fri, 31 Jan 2020 09:41:14 +0000 (11:41 +0200)]
; * lisp/progmodes/gdb-mi.el (gdb-handle-reply): Fix commentary.
Yuan Fu [Mon, 7 Oct 2019 22:47:54 +0000 (18:47 -0400)]
Protect against errors in gdb-mi.el handlers
* lisp/progmodes/gdb-mi.el (gdb-handle-reply): Handle errors
in 'handler-function' so the cleanup code after it runs
safely. (Bug#39178)
Eli Zaretskii [Fri, 31 Jan 2020 09:34:50 +0000 (11:34 +0200)]
Allow exiting the Python interpreter of a GDB session
* lisp/progmodes/gdb-mi.el (gdb-delchar-or-quit): Send EOF to GDB
if we are in an embedded interpreter. This allows to exit from
"pi" cleanly. (Bug#39140)
Federico Tedin [Wed, 29 Jan 2020 21:24:40 +0000 (22:24 +0100)]
Ensure minibuffer input is added to history in read_minibuf
* src/minibuf.c (read_minibuf): Parse input string after saving
the string to the history list instead of before, in case parsing
signals an error or is interrupted by C-g. (Bug#39291)
Juri Linkov [Wed, 29 Jan 2020 23:22:19 +0000 (01:22 +0200)]
Tab-bar related fixes.
* lisp/cus-start.el (tab-bar-mode): Use dedicated group 'tab-bar'.
* lisp/tab-bar.el (tab-bar-history-mode): Add :group 'tab-bar'.
(tab-bar-get-buffer-tab): Add optional arg 'ignore-current-tab'.
* lisp/desktop.el (desktop-buffers-not-to-save-function): Add docstring.
Nicolas Petton [Wed, 29 Jan 2020 20:29:10 +0000 (21:29 +0100)]
; ChangeLog.3 fixes.
Nicolas Petton [Wed, 29 Jan 2020 20:27:52 +0000 (21:27 +0100)]
* admin/authors.el: Add missing entries.
Stephen Gildea [Tue, 28 Jan 2020 05:28:21 +0000 (21:28 -0800)]
dns-mode-soa-auto-increment-serial: safe if symbolp
* lisp/textmodes/dns-mode.el (dns-mode-soa-auto-increment-serial):
Mark variable as safe as a file local variable when symbolp.
Juri Linkov [Tue, 28 Jan 2020 00:11:59 +0000 (02:11 +0200)]
* lisp/wdired.el: Clean out isearch-filter-predicate (bug#37496)
* lisp/wdired.el (wdired-change-to-dired-mode): Use remove-function to
remove wdired-isearch-filter-read-only (whose value was added in
wdired-change-to-wdired-mode) from local value of isearch-filter-predicate.
Paul Eggert [Mon, 27 Jan 2020 19:30:10 +0000 (11:30 -0800)]
; Spelling and URL fixes
Alan Mackenzie [Mon, 27 Jan 2020 18:10:34 +0000 (18:10 +0000)]
Finish the documentation for c-noise-macro-{,with-parens-}names.
The doc strings and pertinent CC Mode manual page failed to mention that these
variables could also be regular expressions. Amend them.
* lisp/progmodes/cc-vars.el (c-noise-macro-names)
(c-noise-macro-with-parens-names): Amend the doc strings.
* doc/misc/cc-mode.texi (Noise Macros): Amend the descriptions of the two
variables.
Mattias Engdegård [Sun, 26 Jan 2020 18:04:31 +0000 (10:04 -0800)]
Correct regexp for flags in `format' doc string
* src/editfns.c (Fformat): Use the correct regexp for describing the
flags in a %-sequence (place the hyphen last).
Mattias Engdegård [Sat, 25 Jan 2020 15:16:37 +0000 (16:16 +0100)]
Moderate recommendation to escape '(' in doc strings
Thanks to
57e2ca5c50 and related changes, opening brackets at the
leftmost column inside doc strings are no longer mistaken for the
start of a defun.
* doc/lispref/tips.texi (Documentation Tips): Clarify recommendation
and move it down the list.
* etc/NEWS: Announce.
Alan Mackenzie [Sun, 26 Jan 2020 13:01:58 +0000 (13:01 +0000)]
Objective C Mode: Make c-forward-type work with "unsigned long", etc.
This allows the correct fontification of and correct functioning of C-c C-z
(c-display-defun-name) in ns_get_pixel in Emacs's src/nsimage.m.
* lisp/progmodes/cc-langs.el (c-primitive-type-prefix-kwds): For objc, use the
same value as for c and c++ rather than the default nil.
Marco Wahl [Sun, 26 Jan 2020 09:06:09 +0000 (01:06 -0800)]
Fix help text about configure module support
Stefan Kangas [Sat, 25 Jan 2020 03:55:51 +0000 (04:55 +0100)]
* doc/lispref/streams.texi (Output Functions): Improve indexing.
Stefan Kangas [Sat, 25 Jan 2020 15:21:06 +0000 (16:21 +0100)]
Improve doc string of 'newline'
* lisp/simple.el (newline): Doc fix. Move 'use-hard-newlines' down,
since it's less important than the meaning of the prefix argument, and
is less frequently used than 'electric-indent-mode' and
'auto-fill-mode'. Change the wording to no longer call it an
option.
Paul Eggert [Sat, 25 Jan 2020 00:57:31 +0000 (16:57 -0800)]
Improve doc of eq on bignums etc.
* doc/lispref/numbers.texi (Integer Basics):
* doc/lispref/objects.texi (Integer Type, Equality Predicates):
Be clearer about eq vs eql vs = on bignums, floats, and strings.
Mario Lang [Fri, 24 Jan 2020 17:24:19 +0000 (18:24 +0100)]
Do not refer to obsolete alias
Stephen Gildea [Fri, 24 Jan 2020 17:15:44 +0000 (09:15 -0800)]
; Clarify what time-stamp-active enables
Fix documentation strings and comments for time-stamp. Most notably:
* lisp/time-stamp.el (time-stamp-active): in the doc string, clarify
that time-stamp-active does not add time-stamp to any hook.
Alan Third [Tue, 14 Jan 2020 21:36:14 +0000 (21:36 +0000)]
Remove EmacsOpenPanel and EmacsSavePanel (bug#38031)
Eli Zaretskii [Fri, 24 Jan 2020 08:18:32 +0000 (10:18 +0200)]
* doc/emacs/files.texi (Auto Save Files): Improve indexing (bug#39259).
Eli Zaretskii [Fri, 24 Jan 2020 08:12:45 +0000 (10:12 +0200)]
Fix inaccurate wording in the Emacs manual
* doc/emacs/custom.texi (Modifier Keys):
* doc/emacs/basic.texi (Inserting Text): Fix minor inaccuracies in
describing the 'Alt' modifier. (Bug#39254)
Amin Bandali [Fri, 24 Jan 2020 06:09:43 +0000 (01:09 -0500)]
Update ERC module URLs
* lisp/erc/erc-autoaway.el, lisp/erc/erc-button.el,
lisp/erc/erc-compat.el, lisp/erc/erc-fill.el, lisp/erc/erc-imenu.el,
lisp/erc/erc-join.el, lisp/erc/erc-lang.el, lisp/erc/erc-match.el,
lisp/erc/erc-pcomplete.el, lisp/erc/erc-ring.el,
lisp/erc/erc-spelling.el, lisp/erc/erc-stamp.el,
lisp/erc/erc-track.el: Update URL to friendlier form, over https.
* lisp/erc/erc-ibuffer.el: Remove URL to nonexistent page.
* lisp/erc/erc-list.el, lisp/erc/erc-log.el, lisp/erc/erc-notify.el,
lisp/erc/erc-replace.el, lisp/erc/erc-services.el,
lisp/erc/erc-sound.el, lisp/erc/erc-speedbar.el,
lisp/erc/erc-truncate.el: Add URL to corresponding EmacsWiki page.
Lars Ingebrigtsen [Thu, 23 Jan 2020 13:02:12 +0000 (14:02 +0100)]
Minor doc string clarification in use-hard-newlines
* lisp/textmodes/paragraphs.el (use-hard-newlines): Clarify that
this minor mode isn't global (bug#20461).
Tino Calancha [Thu, 23 Jan 2020 09:56:02 +0000 (10:56 +0100)]
Backport: Fix bug 39218
* lisp/simple.el (shell-command):
Ensure a shell command ending with `&' is run asynchronously.
Stefan Kangas [Thu, 23 Jan 2020 01:25:31 +0000 (02:25 +0100)]
Prefer saying "Info manual" to "info page" in docs
Pointed out by Eli Zaretskii in:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39215#14
* doc/emacs/Makefile.in:
* doc/lispintro/Makefile.in:
* doc/lispref/Makefile.in:
* doc/misc/Makefile.in:
* lisp/dired-x.el (top-level):
* lisp/gnus/gnus-sum.el (gnus-summary-mode):
* lisp/progmodes/cperl-mode.el (cperl-info-page): Doc fix; prefer
saying "Info manual" over "info page".
Juri Linkov [Wed, 22 Jan 2020 23:23:17 +0000 (01:23 +0200)]
Tab-bar related finishing touches.
* lisp/tab-bar.el (tab-bar-tab-name-ellipsis): Use shorter name
instead of tab-bar-tab-name-truncated-ellipsis.
(tab-bar-new-tab-to) <defcustom>: Add 'function' option.
(tab-bar-new-tab-to) <function>: Use it.
* lisp/tab-line.el (tab-line-close-tab): Add missing arg 'tab' to
tab-line-close-tab-function funcall.
Alan Mackenzie [Wed, 22 Jan 2020 19:50:30 +0000 (19:50 +0000)]
Make call_process call signal_after_change. This fixes bug #38691.
Now, functions such as call-proess-region invoke after-change-functions
correctly.
* src/callproc.c (call_process): Call prepare_to_modify_buffer in a single
place, no longer delegating the task to insert_1_both, etc. Call
signal_after_change in each of two code branches, such that
before-change-functions and after-change-functions are always called in
balanced pairs.
Paul Eggert [Wed, 22 Jan 2020 19:03:22 +0000 (11:03 -0800)]
* lisp/simple.el: Minor fixes to commentary.
Eli Zaretskii [Wed, 22 Jan 2020 17:17:32 +0000 (19:17 +0200)]
Fix a few typos
* etc/NEWS: Fix a typo.
* src/xdisp.c (try_window_reusing_current_matrix, try_window_id):
* src/dispnew.c (scrolling_window): Fix typos in comments.
Christophe Deleuze [Wed, 22 Jan 2020 16:05:03 +0000 (17:05 +0100)]
Fix doc strings for image-dired rotation commands
* lisp/image-dired.el (image-dired-rotate-thumbnail-left)
(image-dired-rotate-thumbnail-right)
(image-dired-rotate-original-left)
(image-dired-rotate-original-right): Move the text in the doc
strings about rotating the originals to the correct commands
(bug#38928).
Dmitry Gutov [Wed, 22 Jan 2020 11:46:34 +0000 (14:46 +0300)]
Render Ido suggestions using an overlay
* lisp/ido.el (ido--overlay): New variable.
(ido-exhibit): Render with 'after-string' on an overlay
(bug#38457).
Michael Albinus [Wed, 22 Jan 2020 08:25:58 +0000 (09:25 +0100)]
* doc/misc/tramp.texi (Bug Reports): Encourage use of "emacs -Q".
Stefan Monnier [Tue, 21 Jan 2020 20:58:17 +0000 (15:58 -0500)]
* lisp/vc/smerge-mode.el (smerge-match-conflict): Fix bug#38456
This situation is not an internal error, but a perfectly normal occurrence,
so a `cl-assert` is not right
Robert Pluim [Tue, 21 Jan 2020 17:18:32 +0000 (18:18 +0100)]
Correct statement about ftcr and recommend HarfBuzz
* doc/lispref/frames.texi (Font and Color Parameters): Correct
statement about availability of ftcr in the presence of HarfBuzz.
Recommend HarfBuzz.
Eli Zaretskii [Tue, 21 Jan 2020 16:23:32 +0000 (18:23 +0200)]
Avoid leaving artifacts when the system caret is used on w32
* src/xdisp.c (try_window_reusing_current_matrix, try_window_id):
* src/dispnew.c (scrolling_window) [HAVE_NTGUI]: If
w32-use-visible-system-caret is non-nil, disallow scrolling the
display are in scroll_run_hook. This avoids copying traces of the
caret, about which Emacs knows nothing, and thus considers those
pixels show the default background. (Bug#39188)
(gui_update_window_end): Block input only around part of the code,
as we did before this code was extracted from backend-specific
implementations.
* src/w32term.c (w32_update_window_begin, w32_update_window_end):
Only hide/show the caret when redisplaying the window where the
caret is shown.
Eli Zaretskii [Tue, 21 Jan 2020 15:58:23 +0000 (17:58 +0200)]
Improve display of temporary echo messages
* lisp/minibuffer.el (set-minibuffer-message): Fix cursor position
for the temporary display of an echo-area message when minibuffer
is active. Ensure the message is visible even if the end of the
completion candidates presented by the likes of Icomplete mode is
not visible due to its length, under resize-mini-windows = nil.
(Bug#38457)
Juri Linkov [Mon, 20 Jan 2020 23:09:04 +0000 (01:09 +0200)]
* lisp/menu-bar.el: Remove desktop-save-mode from release branch (bug#37594)
; Not to be merged to master
Juri Linkov [Mon, 20 Jan 2020 23:03:37 +0000 (01:03 +0200)]
Allow optional truncation of tab names in tab-bar and tab-line (bug#38693)
* lisp/tab-line.el (tab-line-tab-name-truncated-max): New defcustom.
(tab-line-tab-name-truncated-buffer): Use tab-line-tab-name-truncated-max
consistently with similar options in tab-bar.el.
(tab-line-tabs-limit): Remove variable.
(tab-line-tabs-window-buffers): Remove use of tab-line-tabs-limit
that was an experimental feature before horizontal scrolling was implemented.
(tab-line-close-tab-function): Rename from tab-line-close-tab-action
and allow a customizaed function as option.
(tab-line-close-tab): Call function if tab-line-close-tab-function
is customized to a function.
* lisp/tab-bar.el (tab-bar-tab-name-function): Add option
tab-bar-tab-name-truncated.
(tab-bar-tab-name-truncated-max): New defcustom.
(tab-bar-tab-name-truncated-ellipsis): New variable.
(tab-bar-tab-name-truncated): New function.
Juri Linkov [Mon, 20 Jan 2020 22:50:15 +0000 (00:50 +0200)]
Small fixes in documentation.
* doc/emacs/dired.texi (Operating on Files): Fix name of dired-vc-rename-file.
* doc/emacs/fixit.texi (Undo): Update new values of undo limits
doubled in bug#31104.
Robert Pluim [Mon, 20 Jan 2020 16:59:38 +0000 (17:59 +0100)]
Improve explanation of available font backends under X
* frames.texi (Font and Color Parameters): Clarify that you can't
have HarfBuzz and non-HarfBuzz at the same time for xft and cairo
font backends.
Pip Cet [Mon, 20 Jan 2020 16:27:43 +0000 (17:27 +0100)]
Clear output data pointer on NS
* src/nsterm.m (ns_free_frame_resources): Clear the output data
pointer to prevent attempting to reuse freed resources (Bug#38748).
Michael Albinus [Mon, 20 Jan 2020 15:32:13 +0000 (16:32 +0100)]
* admin/release-process: Adapt bug numbers for release critical bugs.
Mention debbugs-gnu-emacs-release-blocking-reports.
Mattias Engdegård [Mon, 20 Jan 2020 14:52:27 +0000 (15:52 +0100)]
Fix shell-tests failures
* test/lisp/shell-tests.el (shell-tests-completion-before-semi):
Go back to actually testing completion before semicolon.
(shell-tests-completion-after-semi): Test completion after semicolon,
correctly (bug#39075).
Mattias Engdegård [Mon, 20 Jan 2020 13:27:38 +0000 (14:27 +0100)]
* test/lisp/simple-tests.el: Full path to Emacs binary (bug#39067).
Juri Linkov [Mon, 20 Jan 2020 00:35:53 +0000 (02:35 +0200)]
* lisp/tab-line.el (tab-line-auto-hscroll): Fix for long tab names.
Check for nil value returned by previous-single-property-change that
happens when tab name is longer than window width.
Juri Linkov [Mon, 20 Jan 2020 00:14:24 +0000 (02:14 +0200)]
* lisp/menu-bar.el (menu-bar-options-menu): Add desktop-save-mode (bug#37594)
Tino Calancha [Sun, 19 Jan 2020 21:01:17 +0000 (22:01 +0100)]
; Fix a test (Bug#39067)
* test/lisp/simple-tests.el (with-shell-command-dont-erase-buffer):
Use flag -Q to prevent from loading site-lisp files.
Michael Albinus [Sun, 19 Jan 2020 13:25:20 +0000 (14:25 +0100)]
; * etc/NEWS: Fix typo.
Tino Calancha [Sun, 19 Jan 2020 10:13:02 +0000 (11:13 +0100)]
Fix shell-command-dont-erase-buffer feature
* lisp/simple.el (shell-command-dont-erase-buffer):
The default, nil, is backward compatible, i.e. it erases the buffer
only if the output buffer is not the current one; the new value 'erase
always erases the output buffer.
Update docstring.
(shell-command-save-pos-or-erase):
Add optional arg output-to-current-buffer.
Rename it so that it's not internal. All callers updated.
(shell-command-set-point-after-cmd): Rename it so that it's not internal.
All callers updated.
Adjust it to cover a side case.
(shell-command): Adjust logic to match the specification (Bug#39067).
Enable the feature when the output buffer is the current one.
(shell-command-on-region): Little tweak to follow
`shell-command-dont-erase-buffer' specification.
* test/lisp/simple-tests.el (with-shell-command-dont-erase-buffer):
Add helper macro.
(simple-tests-shell-command-39067)
(simple-tests-shell-command-dont-erase-buffer): Add tests.
* doc/emacs/misc.texi (Single Shell): Update manual.
* etc/NEWS (Single shell commands): Announce the change.
Stefan Kangas [Sun, 19 Jan 2020 00:26:16 +0000 (01:26 +0100)]
Remove reference to Emacs 19 from FAQ
* doc/misc/efaq.texi (Emacs ignores X resources): Remove reference to
Emacs 19.
Stefan Kangas [Fri, 4 Oct 2019 16:30:34 +0000 (18:30 +0200)]
Doc fixes in package.el
* lisp/emacs-lisp/package.el (package-process-define-package)
(package-generate-description-file): Doc fixes.
(package-generate-autoloads, package--write-file-no-coding)
(package--archive-file-exists-p, package-desc-status): Add doc
strings.
Eric Abrahamsen [Sat, 18 Jan 2020 19:08:11 +0000 (11:08 -0800)]
Ensure that gnus-summary-attach-article finds the right articles
* lisp/gnus/gnus-msg.el (gnus-summary-attach-article): Before
iterating over the articles to attach, first close any open
article. Using `set-buffer' required `gnus-summary-select-article' to
re-set the buffer every time, meaning we never got off the original
article.
(cherry picked from commit
447bb1313a6abc07776d93ee78cd976ab43856e5)
Stefan Kangas [Sat, 18 Jan 2020 18:53:01 +0000 (19:53 +0100)]
Remove some doc references to old Emacs versions
* doc/misc/efaq.texi (Horizontal scrolling): Remove section
only relevant to Emacs 21 or older.
(Repeating commands, Editing MS-DOS files):
* lisp/progmodes/gdb-mi.el:
* lisp/woman.el: Doc fix - remove some references to Emacs 20 and older.
Pieter van Oostrum [Thu, 16 Jan 2020 19:21:37 +0000 (20:21 +0100)]
Fix infloop in shell.el
* test/lisp/shell-tests.el (shell-tests-completion-before-semi):
Amend the shell.el tests to catch errors such as bug#39057.
* lisp/shell.el (shell--parse-pcomplete-arguments): Skip the
semi-colon as well. This avoids inflooping when a semi-colon is
typed by the user. (Bug#39057)
Copyright-paperwork-exempt: yes
Amin Bandali [Sat, 18 Jan 2020 04:38:04 +0000 (23:38 -0500)]
Fix erc-notifications-notify for non-PRIVMSGs, broken in last commit
* lisp/erc/erc-desktop-notifications.el (erc-notifications-notify):
Take optional argument `privp', to be non-nil when notifying for a
PRIVMSG. This is to work around bug introduced in last commit, as
`erc-get-buffer' may return nil for non-PRIVMSG cases.
(erc-notifications-PRIVMSG): Call erc-notifications-notify with
non-nil `privp', as described above.
Amin Bandali [Sat, 18 Jan 2020 03:33:03 +0000 (22:33 -0500)]
Fix the notification action for PRIVMSG in erc-notifications-notify
* lisp/erc/erc-desktop-notifications.el (erc-notifications-notify):
explicitly request the buffer for `nick', rather than relying on
(current-buffer) returning it. That works fine for the very first
PRIVMSG sent by `nick', but ERC seems to handle subsequent PRIVMSGs
differently, where (current-buffer) would return the server buffer
rather than the existing buffer for PRIVMSGs from `nick'.
Amin Bandali [Sat, 18 Jan 2020 02:45:10 +0000 (21:45 -0500)]
ERC: New maintainer.
* admin/MAINTAINERS: Add entries for Amin Bandali, new maintainer for
ERC, and interested in maintaining Eshell.
* lisp/erc/*: New maintainer.
Paul Eggert [Fri, 17 Jan 2020 22:23:20 +0000 (14:23 -0800)]
; spelling fixes
Dmitry Gutov [Fri, 17 Jan 2020 21:14:24 +0000 (00:14 +0300)]
Honor tags-case-fold-search during xref identifer completion
* etc/NEWS: New entry.
* lisp/progmodes/etags.el (tags-case-fold-search):
Mark as safe-local.
(find-tag--completion-ignore-case):
Extract from tags-completion-at-point-function, find-tag-tag and
etags--xref-find-definitions.
(xref-backend-identifier-completion-ignore-case):
New method. Use it here as well.
* lisp/progmodes/xref.el
(xref-backend-identifier-completion-ignore-case): New generic.
(xref--read-identifier): Use it here.
Simen Heggestøyl [Fri, 17 Jan 2020 13:51:19 +0000 (14:51 +0100)]
; * src/lread.c (force_new_style_backquotes): Fix reference.
Eli Zaretskii [Fri, 17 Jan 2020 09:47:19 +0000 (11:47 +0200)]
; * etc/NEWS: Mention latest changes in checkdoc. (Bug#38583)
Eli Zaretskii [Fri, 17 Jan 2020 09:35:35 +0000 (11:35 +0200)]
Fix wording and punctuation of a recent commit
* lisp/textmodes/ispell.el (ispell-correct-p): Doc fix.
* lisp/emacs-lisp/checkdoc.el (checkdoc-ispell-init): Fix
capitalization and punctuation of comments.
Eli Zaretskii [Fri, 17 Jan 2020 09:30:55 +0000 (11:30 +0200)]
Merge branch 'emacs-27' of git.savannah.gnu.org:/srv/git/emacs into emacs-27
Damien Cassou [Fri, 27 Dec 2019 14:35:52 +0000 (15:35 +0100)]
Add unattended spell-checking to checkdoc
This commit makes checkdoc capable of spell-checking even when the
user isn't using it interactively. When TAKE-NOTES is non-nil,
checkdoc will run spell-checking (with ispell) and report spelling
mistakes.
Fixes: (bug#38583).
* lisp/textmodes/ispell.el (ispell-word): Extract part of it to
`ispell--run-on-word`.
(ispell--run-on-word): New function, extracted from `ispell-word`.
(ispell-error-checking-word): New function.
(ispell-correct-p): New function. Use `ispell--run-on-word` and
`ispell-error-checking-word`.
* lisp/emacs-lisp/checkdoc.el (checkdoc-current-buffer): Pass
TAKE-NOTES to `checkdoc-start`.
(checkdoc-continue): Pass TAKE-NOTES to `checkdoc-this-string-valid`.
(checkdoc-this-string-valid): Add optional argument TAKE-NOTES and
pass it to `checkdoc-this-string-valid-engine`.
(checkdoc-this-string-valid-engine): Add optional argument TAKE-NOTES
and pass it to `checkdoc-ispell-docstring-engine`.
(checkdoc-ispell-init): Call `ispell-set-spellchecker-params` and
`ispell-accept-buffer-local-defs`. These calls are required to
properly use ispell. The problem went unnoticed until now because
checkdoc was only using ispell through the high-level command
`ispell-word` which takes care of all the initialization for the user.
(checkdoc-ispell-docstring-engine): Add optional argument TAKE-NOTES
to force reporting of spell-checking errors. Throw error
when (checkdoc-ispell-init) fails configuring ispell. Replace a
few (if cond nil body) with (unless cond body). Replace (let ((var
nil))) with (let (var)). Replace (if (not (eq checkdoc-autofix-flag
'never)) body) with just body because `checkdoc-autofix-flag` is
checked at the beginning of the function.
(cherry picked from commit
25adbc4a5ecc3e16625c0171607e3153bbdf7ab1)
Robert Pluim [Fri, 17 Jan 2020 08:34:50 +0000 (09:34 +0100)]
; Minor edit in anti.texi
Lin Sun [Fri, 17 Jan 2020 00:08:54 +0000 (16:08 -0800)]
Fix the error message from makefile-move-to-macro
* lisp/cedet/ede/makefile-edit.el (makefile-macro-file-list):
regexp-quote the param in makefile-move-to-macro (Bug#39094).
(cherry picked from commit
a36495da1ec1419998c17fd64fb7439eaf940f36)
Robert Pluim [Fri, 17 Jan 2020 07:53:29 +0000 (08:53 +0100)]
; Fix recent markup change
* doc/emacs/custom.texi (Find Init): Fix variable markup.
Stefan Kangas [Fri, 17 Jan 2020 06:03:41 +0000 (07:03 +0100)]
; * lisp/obsolete/vc-arch.el: Add missing "Obsolete-since" tag.
Stefan Kangas [Fri, 17 Jan 2020 05:34:00 +0000 (06:34 +0100)]
; * lisp/ezimage.el: Fix typo.
Stefan Kangas [Thu, 16 Jan 2020 20:35:07 +0000 (21:35 +0100)]
Document feature requests in the Emacs manual
* doc/emacs/trouble.texi (Contributing): Document how to send feature
requests. (Bug20697)
Stefan Monnier [Thu, 16 Jan 2020 15:18:15 +0000 (10:18 -0500)]
* lisp/minibuffer.el (read-file-name-default): Fix bug#39057
Michael Albinus [Thu, 16 Jan 2020 15:17:26 +0000 (16:17 +0100)]
; * etc/NEWS: Fix some file name quotations.
Robert Pluim [Wed, 15 Jan 2020 11:24:43 +0000 (12:24 +0100)]
Make emacs prefer an existing ~/.emacs.d to an existing XDG location
* doc/emacs/custom.texi (Find Init): Update description of how Emacs
finds its init file directory and the interaction with
$XDG_CONFIG_HOME
(Early Init File): Correct XDG location of early-init.el
* etc/NEWS: Update description to make it clear the ~/.emacs.d is
preferred, even if the XDG location exists.
* lisp/startup.el: Prefer ~/.emacs.d even if the XDG location exists.
* lib-src/emacsclient.c (open_config): Prefer home directory the XDG
location.
Robert Pluim [Thu, 16 Jan 2020 09:39:40 +0000 (10:39 +0100)]
; etc/NEWS minor edits
Robert Pluim [Thu, 16 Jan 2020 09:34:37 +0000 (10:34 +0100)]
Describe --with-cairo non-support for bitmapped fonts.
* etc/NEWS: Mention Pango's removal of support for bitmapped fonts.
Robert Pluim [Thu, 16 Jan 2020 09:33:01 +0000 (10:33 +0100)]
Mention GTK font chooser changes in NEWS
* etc/NEWS: Mention GTK font chooser changes.