]> git.eshelyaron.com Git - emacs.git/log
emacs.git
5 years agospecial-mode doc string clarification
Hong Xu [Sat, 19 Oct 2019 08:43:37 +0000 (10:43 +0200)]
special-mode doc string clarification

* lisp/simple.el (special-mode): Make the doc string explain what
special modes are for (bug#37787).

5 years agoDon't have shr bug out if svg support isn't available
Lars Ingebrigtsen [Sat, 19 Oct 2019 08:23:19 +0000 (10:23 +0200)]
Don't have shr bug out if svg support isn't available

* lisp/net/shr.el (shr-put-image): Don't bug out if SVG support
isn't available.

5 years agoFix typo in tree-widget-lookup-image
Cédric Chépied [Sat, 19 Oct 2019 07:54:02 +0000 (09:54 +0200)]
Fix typo in tree-widget-lookup-image

* lisp/tree-widget.el (tree-widget-lookup-image): Fix typo
introduced by previous cleanup (bug#37809).

5 years agoA better fix for tab-line mouse highlight on TTY frames
Eli Zaretskii [Sat, 19 Oct 2019 07:42:14 +0000 (10:42 +0300)]
A better fix for tab-line mouse highlight on TTY frames

* src/dispnew.c (mode_line_string):
* src/xdisp.c (note_mode_line_or_margin_highlight): Remove
recently-added workarounds for incorrect TTY mouse highlight:
they are no longer needed.
(mark_window_display_accurate_1): Set the header_line_p and
tab_line_p flags of the window's current_matrix if the window
displays these.
(display_mode_line): Set the header_line_p and tab_line_p
flags of the window's desired_matrix if the window displays
these.  (Bug#37807)

5 years agoRemove XEmacs compat code from ezimage.el
Stefan Kangas [Fri, 18 Oct 2019 23:12:33 +0000 (01:12 +0200)]
Remove XEmacs compat code from ezimage.el

* lisp/ezimage.el (top-level): Remove XEmacs compat code.

5 years agoPacify x86 GCC 9 in tab bar code
Paul Eggert [Fri, 18 Oct 2019 22:33:13 +0000 (15:33 -0700)]
Pacify x86 GCC 9 in tab bar code

* src/xdisp.c (tty_get_tab_bar_item): Simplify a bit.  This
pacifies --enable-gcc-warnings with x86 GCC 9.2.1 20190827
(Red Hat 9.2.1-1) when combined with -fsanitize=undefined.

5 years agoRemove XEmacs compat code from edt-mapper.el
Stefan Kangas [Fri, 18 Oct 2019 21:32:30 +0000 (23:32 +0200)]
Remove XEmacs compat code from edt-mapper.el

* lisp/emulation/edt-mapper.el (edt-mapper, edt-xserver)
(edt-map-key): Remove XEmacs compat code.
(edt-window-system): Redefine as obsolete variable alias for
'window-system'.

5 years agoRemove XEmacs compat code from esh-arg.el
Stefan Kangas [Fri, 18 Oct 2019 21:26:46 +0000 (23:26 +0200)]
Remove XEmacs compat code from esh-arg.el

* lisp/eshell/esh-arg.el (eshell-quote-backslash): Remove XEmacs
compat code.

5 years agoGeneralize list1i etc. to all signed integer types
Paul Eggert [Fri, 18 Oct 2019 20:21:11 +0000 (13:21 -0700)]
Generalize list1i etc. to all signed integer types

* src/lisp.h (list1i, list2i, list3i, list4i):
Accept intmax_t instead of EMACS_INT, and use make_int instead
of make_fixnum.  This should help avoid integer-overflow
problems akin to the Time bug (Bug#37795).

5 years agoFix integer-overflow bug in Time conversion
Paul Eggert [Fri, 18 Oct 2019 20:07:49 +0000 (13:07 -0700)]
Fix integer-overflow bug in Time conversion

Problem reported by Stefan Monnier (Bug#37795).
* src/keyboard.c (make_lispy_position)
(make_scroll_bar_position, make_lispy_event):
* src/xterm.c (x_ewmh_activate_frame):
Use INT_TO_INTEGER to convert Time to a Lisp integer,
since the value might not be a fixnum.

5 years ago* test/lisp/net/tramp-tests.el (remote-file-name-inhibit-cache): Set to nil.
Michael Albinus [Fri, 18 Oct 2019 17:45:07 +0000 (19:45 +0200)]
* test/lisp/net/tramp-tests.el (remote-file-name-inhibit-cache): Set to nil.

5 years agoSupport old Samba versions in Tramp
Michael Albinus [Fri, 18 Oct 2019 17:44:49 +0000 (19:44 +0200)]
Support old Samba versions in Tramp

* doc/misc/tramp.texi (Relevant connection properties to override):
New subsection.

* lisp/net/tramp-smb.el (tramp-smb-get-cifs-capabilities): Check "posix"
connection property.

* lisp/net/tramp.el (with-tramp-progress-reporter): Fix docstring.

5 years agoFix mouse highlight with tab-line on TTY frames
Eli Zaretskii [Fri, 18 Oct 2019 15:48:31 +0000 (18:48 +0300)]
Fix mouse highlight with tab-line on TTY frames

* src/xdisp.c (note_mode_line_or_margin_highlight):
* src/dispnew.c (mode_line_string): Fix mouse highlight on TTY
frames when both header line and tab-line are displayed.
(Bug#37807)

5 years agoFix handling of mouse events on header line with tab-line
Eli Zaretskii [Fri, 18 Oct 2019 14:55:21 +0000 (17:55 +0300)]
Fix handling of mouse events on header line with tab-line

* src/window.c (coordinates_in_window): Fix conditions for
coordinates being on the window's header line when that
window also displays a tab-line.  (Bug#37807)

5 years agoUse [^z-a] for matching any character (anychar/anything) in rx
Mattias Engdegård [Wed, 9 Oct 2019 08:22:10 +0000 (10:22 +0200)]
Use [^z-a] for matching any character (anychar/anything) in rx

* lisp/emacs-lisp/rx.el (rx--translate-symbol):
* test/lisp/emacs-lisp/rx-tests.el (rx-any, rx-atoms):
Use [^z-a] instead of ".\\|\n" for anychar.

The new expression is faster (about 2×) and does not allocate regexp
stack space.  For example, (0+ anychar) now matches strings of any
size (bug#37659).

5 years agoAdd `unmatchable' as alias for (or) in rx (bug#37659)
Mattias Engdegård [Mon, 7 Oct 2019 16:28:18 +0000 (18:28 +0200)]
Add `unmatchable' as alias for (or) in rx (bug#37659)

* lisp/emacs-lisp/rx.el (rx--translate-symbol, rx--builtin-symbols, rx):
* test/lisp/emacs-lisp/rx-tests.el (rx-atoms):
* doc/lispref/searching.texi (Rx Constructs):
* etc/NEWS:
Add `unmatchable', more descriptive than (or), and corresponding to
the variable `regexp-unmatchable'.

5 years agoAdd `anychar' as alias to `anything' in rx (bug#37659)
Mattias Engdegård [Mon, 7 Oct 2019 16:07:16 +0000 (18:07 +0200)]
Add `anychar' as alias to `anything' in rx (bug#37659)

* lisp/emacs-lisp/rx.el (rx--translate-symbol, rx--builtin-symbols, rx):
* test/lisp/emacs-lisp/rx-tests.el (rx-atoms):
* doc/lispref/searching.texi (Rx Constructs):
* etc/NEWS:
Add `anychar', an alias for `anything'.  Since `anychar' is more
descriptive (and slightly shorter), treat it as the preferred name.

5 years agoExtend debug spec of cl-flet (Bug#34481)
Michael Heerdegen [Wed, 16 Oct 2019 11:07:05 +0000 (13:07 +0200)]
Extend debug spec of cl-flet (Bug#34481)

* lisp/emacs-lisp/cl-macs.el (cl-flet): Extend debug spec to cover
definitions of the form (FUNC EXP).

5 years agoPort snake menu to Emacs
Stefan Kangas [Thu, 17 Oct 2019 17:38:06 +0000 (19:38 +0200)]
Port snake menu to Emacs

* lisp/play/snake.el (snake--menu-def): New constant.
(snake-mode-menu, snake-null-menu): Add a menu.
(snake-mode): Remove XEmacs compat code.
(snake-mode-map, snake-null-map): Add docstring.

5 years agoIn 'bury-buffer' don't try to remove current buffer from minibuffer window
Martin Rudalics [Thu, 17 Oct 2019 17:35:29 +0000 (19:35 +0200)]
In 'bury-buffer' don't try to remove current buffer from minibuffer window

* lisp/window.el (bury-buffer): Don't try to remove current buffer
from minibuffer window.

5 years ago* lisp/recentf.el (recentf-mode): Doc fix. (Bug#37772)
Eli Zaretskii [Thu, 17 Oct 2019 17:10:35 +0000 (20:10 +0300)]
* lisp/recentf.el (recentf-mode): Doc fix.  (Bug#37772)

5 years ago* lisp/dired.el (dired-auto-revert-buffer): Doc fix. (Bug#37771)
Eli Zaretskii [Thu, 17 Oct 2019 17:07:16 +0000 (20:07 +0300)]
* lisp/dired.el (dired-auto-revert-buffer): Doc fix.  (Bug#37771)

5 years agoPort tetris menu to Emacs
Stefan Kangas [Thu, 17 Oct 2019 16:49:33 +0000 (18:49 +0200)]
Port tetris menu to Emacs

* lisp/play/tetris.el (tetris--menu-def): New constant.
(tetris-mode-menu, tetris-null-menu): Add a menu.
(tetris-mode): Remove XEmacs compat code.
(tetris-null-map, tetris-mode-map): Add docstring.

5 years ago* lisp/shell.el (shell): Make shell buffer the current buffer. (Bug#37745)
Michael Albinus [Thu, 17 Oct 2019 16:46:53 +0000 (18:46 +0200)]
* lisp/shell.el (shell): Make shell buffer the current buffer.  (Bug#37745)

5 years agoRemove XEmacs compat code from ffap.el
Stefan Kangas [Thu, 17 Oct 2019 13:25:07 +0000 (15:25 +0200)]
Remove XEmacs compat code from ffap.el

* lisp/ffap.el (ffap-what-domain): Remove XEmacs compat code.

5 years agoRemove XEmacs compat code from imap.el
Stefan Kangas [Thu, 17 Oct 2019 12:06:24 +0000 (14:06 +0200)]
Remove XEmacs compat code from imap.el

* lisp/net/imap.el (imap-disable-multibyte): Declare obsolete.
(imap-log, imap-open): Remove XEmacs compat code.

5 years agoRemove obsolete XEmacs references from manuals
Stefan Kangas [Thu, 17 Oct 2019 11:56:42 +0000 (13:56 +0200)]
Remove obsolete XEmacs references from manuals

* doc/misc/erc.texi:
* doc/misc/eshell.texi:
* doc/misc/htmlfontify.texi:
* doc/misc/remember.texi:
* doc/misc/sieve.texi:
* doc/misc/viper.texi: Remove obsolete XEmacs references.

5 years agoRemove XEmacs reference from viper refcard
Stefan Kangas [Thu, 17 Oct 2019 11:19:18 +0000 (13:19 +0200)]
Remove XEmacs reference from viper refcard

* etc/refcards/viperCard.tex: Remove reference to XEmacs.

5 years agoRemove XEmacs compat code from tcl.el
Stefan Kangas [Thu, 17 Oct 2019 11:13:05 +0000 (13:13 +0200)]
Remove XEmacs compat code from tcl.el

* lisp/progmodes/tcl.el (tcl-mode): Remove XEmacs compat code.
(tcl-popup-menu): Declare obsolete.

5 years agoRemove XEmacs reference from erc-button.el todo
Stefan Kangas [Thu, 17 Oct 2019 11:04:25 +0000 (13:04 +0200)]
Remove XEmacs reference from erc-button.el todo

* lisp/erc/erc-button.el: Remove reference to XEmacs from a todo item.

5 years agoRemove commented out XEmacs compat code from po.el
Stefan Kangas [Thu, 17 Oct 2019 11:03:52 +0000 (13:03 +0200)]
Remove commented out XEmacs compat code from po.el

* lisp/textmodes/po.el: Remove commented out XEmacs compat code.

5 years agoImprove documentation of shell-command-prompt-show-cwd
Stefan Kangas [Thu, 17 Oct 2019 10:55:25 +0000 (12:55 +0200)]
Improve documentation of shell-command-prompt-show-cwd

* doc/emacs/misc.texi (Single Shell):
* lisp/simple.el (shell-command): Document
'shell-command-prompt-show-cwd'.  (Bug#4987)

5 years agoAllow vc-sccs-diff to work with TRAMP
Peter Oliver [Thu, 17 Oct 2019 02:43:38 +0000 (04:43 +0200)]
Allow vc-sccs-diff to work with TRAMP

* lisp/vc/vc-sccs.el (vc-sccs-diff): If the diff command is to be
run remotely, then the temporary files it's acting on must be
remote too (bug#37777).

Copyright-paperwork-exempt: yes

5 years agoAdd ui.report_untrusted=0 to vc-hg log commands
Andrii Kolomoiets [Thu, 17 Oct 2019 02:25:10 +0000 (04:25 +0200)]
Add ui.report_untrusted=0 to vc-hg log commands

* lisp/vc/vc-hg.el (vc-hg-state-slow, vc-hg-merge-branch)
(vc-hg-command): Add "--config" "ui.report_untrusted=0" to the
log commands to avoid "Hg-not trusting file " messages in the mode
line (bug#31497).

Copyright-paperwork-exempt: yes

5 years agolisp/*.el, src/*.c: Doc fixes related to returning t vs non-nil
Juanma Barranquero [Thu, 17 Oct 2019 00:45:06 +0000 (02:45 +0200)]
lisp/*.el, src/*.c: Doc fixes related to returning t vs non-nil

* lisp/progmodes/flymake-proc.el (flymake-proc--find-buffer-for-file):
Doc fix; return value is a buffer, not t.

* lisp/progmodes/ebrowse.el (ebrowse-member-display-p):
Doc fix; return value is the MEMBER argument, not nil.

* lisp/files.el (hack-one-local-variable-eval-safep):
* lisp/play/doctor.el (doctor-nounp, doctor-pronounp):
* lisp/progmodes/flymake-proc.el (flymake-proc--check-include):
* lisp/progmodes/js.el (js--broken-arrow-terminates-line-p):
Doc fix; a non-nil return value is not always t.

* lisp/image.el (image-type-available-p):
* lisp/simple.el (region-active-p):
* lisp/window.el (frame-root-window-p):
* src/buffer.c (Fbuffer_live_p):
* src/image.c (Finit_image_library):
* src/window.c (Fwindow_minibuffer_p):
Doc fix; a non-nil return value is always t.

* doc/lispref/minibuf.texi (Minibuffer Windows): Doc fix.

5 years agolisp/*.el: Force non-nil result to t, to match docstring
Juanma Barranquero [Thu, 17 Oct 2019 00:08:43 +0000 (02:08 +0200)]
lisp/*.el: Force non-nil result to t, to match docstring

* lisp/emacs-lock.el (emacs-lock-live-process-p):
* lisp/shadowfile.el (shadow-file-match):
* lisp/emacs-lisp/edebug.el (edebug-basic-spec):
* lisp/mail/rmail.el (rmail-expunge-confirmed):
* lisp/net/soap-client.el (soap-should-encode-value-for-xs-element):
* lisp/progmodes/idlwave.el (idlwave-quoted):
* lisp/progmodes/idlw-shell.el (idlwave-shell-filename-string):
* lisp/textmodes/refbib.el (r2b-isa-proceedings):
* lisp/textmodes/texnfo-upd.el (texinfo-find-lower-level-node):
Normalize boolean result.

5 years ago* lisp/wid-edit.el (widget-default-active): Normalize boolean result.
Juanma Barranquero [Wed, 16 Oct 2019 13:42:41 +0000 (15:42 +0200)]
* lisp/wid-edit.el (widget-default-active): Normalize boolean result.

5 years agoAdd/fix documentation for widget-apply
Juanma Barranquero [Wed, 16 Oct 2019 13:39:42 +0000 (15:39 +0200)]
Add/fix documentation for widget-apply

* doc/misc/widget.texi (Widget Properties): Document `widget-apply'.

* src/fns.c (Fwidget_apply): Document return value (used in many
places).

5 years agoAdapt Tramp's sudo method for non-default shells (Bug#31924)
Michael Albinus [Wed, 16 Oct 2019 13:09:46 +0000 (15:09 +0200)]
Adapt Tramp's sudo method for non-default shells (Bug#31924)

* lisp/net/tramp-sh.el (tramp-methods) <sudo>: Change template.
(tramp-maybe-open-connection): Remove `tramp-login-env'.  (Bug#31924)

* lisp/net/tramp.el (tramp-methods): Remove docstring for `tramp-login-env'.

5 years agolisp/speedbar.el: Fix computation of boolean return values
Juanma Barranquero [Wed, 16 Oct 2019 12:37:06 +0000 (14:37 +0200)]
lisp/speedbar.el: Fix computation of boolean return values

* lisp/speedbar.el (speedbar-check-vc-this-line):
Normalize boolean result.
(speedbar-this-file-in-vc): Use `run-hook-with-args-until-success'
to check for files under versin control.  Doc fix.

5 years ago* etc/NEWS: Apply "user option" when possible. Fix other oddities.
Michael Albinus [Wed, 16 Oct 2019 10:15:29 +0000 (12:15 +0200)]
* etc/NEWS: Apply "user option" when possible.  Fix other oddities.

5 years agoHandle top margin change in adjust_frame_size
Martin Rudalics [Wed, 16 Oct 2019 09:02:56 +0000 (11:02 +0200)]
Handle top margin change in adjust_frame_size

* src/frame.c (adjust_frame_size): Handle case where only
pseudo windows changed height so the top margin has to be
adjusted.
* src/window.c (Fset_window_configuration): Call
adjust_frame_size with inhibit 4.

5 years agoExpand <<- heredocs in sh
Lars Ingebrigtsen [Wed, 16 Oct 2019 07:20:06 +0000 (09:20 +0200)]
Expand <<- heredocs in sh

* lisp/progmodes/sh-script.el (sh--maybe-here-document): Make <<-
expansion work, too.

5 years agoAllow event description to be empty
Robert Pluim [Tue, 15 Oct 2019 10:00:34 +0000 (12:00 +0200)]
Allow event description to be empty

The previous fix for this was incomplete.

* lisp/gnus/gnus-icalendar.el (gnus-icalendar-event->org-entry):
Allow description to be nil.

5 years agoFix some &rest body edebug specs
Lars Ingebrigtsen [Wed, 16 Oct 2019 02:44:22 +0000 (04:44 +0200)]
Fix some &rest body edebug specs

* lisp/ses.el (ses--letref):

* lisp/emacs-lisp/crm.el (crm--completion-command): Fix edebug
&rest body spec (bug#28747).

* lisp/emacs-lisp/easy-mmode.el (easy-mmode-define-navigation):

* lisp/emacs-lisp/inline.el (inline--leteval)
(inline--letlisteval, inline-letevals):

5 years agoTweak heredoc expansion in shell-script-mode
Lars Ingebrigtsen [Wed, 16 Oct 2019 01:47:12 +0000 (03:47 +0200)]
Tweak heredoc expansion in shell-script-mode

* lisp/progmodes/sh-script.el (sh--maybe-here-document): Allow
expanding <<E, too.

5 years agoDeclare tab-bar-tabs the single source of truth in regard to current tab name
Juri Linkov [Tue, 15 Oct 2019 21:42:31 +0000 (00:42 +0300)]
Declare tab-bar-tabs the single source of truth in regard to current tab name

* lisp/tab-bar.el: Replace all calls of tab-bar-tabs
with '(funcall tab-bar-tabs-function)'.
(tab-bar-tabs): Update the current tab name here
instead of tab-bar-make-keymap-1.
(tab-bar-make-keymap-1): Move the current tab name updating
to tab-bar-tabs.

5 years agoAllow tabs to have consistent given names
Robert Cochran [Mon, 7 Oct 2019 20:41:47 +0000 (13:41 -0700)]
Allow tabs to have consistent given names

* lisp/tab-bar.el (tab-bar--tab): Pull automatic name information from
current tab
(tab-bar--current-tab): Pull automatic name information from current
tab, or from new optional template argument
(tab-bar-select-tab): Pass the target tab as a template when setting
it as current tab
(tab-bar-rename-tab, tab-bar-rename-tab-by-name): New functions
* doc/emacs/frames.texi (Tab Bars): Document new tab rename functionality.

5 years ago* lisp/tab-bar.el (tab-bar-select-tab-modifiers): New defcustom.
Juri Linkov [Tue, 15 Oct 2019 20:38:18 +0000 (23:38 +0300)]
* lisp/tab-bar.el (tab-bar-select-tab-modifiers): New defcustom.

(tab-bar-mode): Use tab-bar-select-tab-modifiers to bind
tab-bar-select-tab.
Don't override user customized key bindings of C-TAB, C-S-TAB.
On disabling tab-bar-mode, unset only keys bound by tab-bar.

5 years agoDon't use expand-file-name to find images for tabs.
Juri Linkov [Tue, 15 Oct 2019 19:44:10 +0000 (22:44 +0300)]
Don't use expand-file-name to find images for tabs.

* lisp/tab-bar.el (tab-bar-mode):
* lisp/tab-line.el (tab-line-new-button, tab-line-close-button):
Remove expand-file-name with data-directory.

5 years agoNew variable tab-bar-position
Juri Linkov [Tue, 15 Oct 2019 19:41:40 +0000 (22:41 +0300)]
New variable tab-bar-position

* lisp/cus-start.el: Add customization for tab-bar-position.
* src/dispnew.c (syms_of_display): New variable Vtab_bar_position.
(adjust_frame_glyphs_for_window_redisplay): Use it.

5 years ago* lisp/rect.el (string-rectangle): Inherit input method in minibuffer
Stefan Monnier [Tue, 15 Oct 2019 15:08:03 +0000 (11:08 -0400)]
* lisp/rect.el (string-rectangle): Inherit input method in minibuffer

5 years agoFix test data broken by removing trailing whitespace.
Eric Ludlam [Tue, 15 Oct 2019 00:57:06 +0000 (20:57 -0400)]
Fix test data broken by removing trailing whitespace.

5 years agoAdapt the CEDET SRecoder getset tests to use ERT
Eric Ludlam [Tue, 15 Oct 2019 00:53:24 +0000 (20:53 -0400)]
Adapt the CEDET SRecoder getset tests to use ERT

These tests were copied from CEDET from SourceForge.
Author: Eric Ludlam <zappo@gnu.org>

5 years agoAdapt the CEDET SRecoder template test to use ERT
Eric Ludlam [Tue, 15 Oct 2019 00:52:52 +0000 (20:52 -0400)]
Adapt the CEDET SRecoder template test to use ERT

These tests were copied from CEDET from SourceForge.
Author: Eric Ludlam <zappo@gnu.org>

5 years agoCopy CEDET/Semantic's tag formatter test suite to be an
Eric Ludlam [Tue, 15 Oct 2019 00:48:16 +0000 (20:48 -0400)]
Copy CEDET/Semantic's tag formatter test suite to be an

automated test.
These tests were copied from CEDET on Sourceforge and adapted to use ERT.
Author: Eric Ludlam <zappo@gnu.org>

5 years agoUpdate CEDET manual tests so that they run.
Eric Ludlam [Tue, 15 Oct 2019 00:46:01 +0000 (20:46 -0400)]
Update CEDET manual tests so that they run.

To run visit test/manual/cedet/cedet-utests.el
M-x eval-buffer
M-x cedet-utest
Author: Eric Ludlam <zappo@gnu.org>

5 years agoConvert manual CEDET tests from test/manual/cedet to be
Eric Ludlam [Tue, 15 Oct 2019 00:43:28 +0000 (20:43 -0400)]
Convert manual CEDET tests from test/manual/cedet to be

automated tests in test/lisp/cedet.
Author: Eric Ludlam <zappo@gnu.org>

5 years agoFix duplicated words in lispref
Robert Pluim [Tue, 15 Oct 2019 12:41:43 +0000 (14:41 +0200)]
Fix duplicated words in lispref

* doc/lispref/text.texi (Base 64):
* doc/lispref/internals.texi (Window Internals): Remove duplicated
words.

5 years agoFix duplicated words in comments
Robert Pluim [Mon, 14 Oct 2019 18:31:33 +0000 (20:31 +0200)]
Fix duplicated words in comments

* src/coding.c (encode_string_utf_8):
* src/keyboard.c (syms_of_keyboard):
* src/mini-gmp.c (gmp_lucas_mod, mpz_export):
* src/pdumper.c (dump_set_referrer, dump_queue_compute_score):
* src/timefns.c (Ftime_convert): Remove duplicated words.

5 years agoFix recording keyboard macros in Calc
Eli Zaretskii [Tue, 15 Oct 2019 12:09:55 +0000 (15:09 +0300)]
Fix recording keyboard macros in Calc

* lisp/calc/calc.el (calc-unread-command): Prevent recording
key twice when defining a keyboard macro.  Patch by Christoph
Arenz <tiga.arenz@web.de>.

Copyright-paperwork-exempt: yes

5 years agoauth-source: Fix wrong-type-argument when searching plstore
Daiki Ueno [Tue, 15 Oct 2019 10:42:37 +0000 (12:42 +0200)]
auth-source: Fix wrong-type-argument when searching plstore

`auth-source-search' can be called with an integer port number from
`network-stream-certificate`, while the backend implementation doesn't
allow non-string attributes.

* lisp/auth-source.el (auth-source-plstore-search): Ensure attributes
are string.

5 years agoRevert "Remove XEmacs code from tetris.el"
Lars Ingebrigtsen [Tue, 15 Oct 2019 09:06:40 +0000 (11:06 +0200)]
Revert "Remove XEmacs code from tetris.el"

This reverts commit 68b91333d5a070c84afeadc273fd5c44df70f0a6.

This should be ported to Emacs instead.

5 years agoRevert "Remove XEmacs-only code from snake.el"
Lars Ingebrigtsen [Tue, 15 Oct 2019 09:06:14 +0000 (11:06 +0200)]
Revert "Remove XEmacs-only code from snake.el"

This reverts commit 7174a2b59f4cb883beb70bb3d182d59ab425e2f1.

This should be ported to Emacs instead.

5 years ago; Minor copyedits in recently installed documentation changes
Eli Zaretskii [Tue, 15 Oct 2019 08:20:22 +0000 (11:20 +0300)]
; Minor copyedits in recently installed documentation changes

* lisp/files.el (require-final-newline):
* etc/NEWS: Improve wording in recent documentation changes.

5 years agoMake auth-source work with non-ASCII passwords again
Lars Ingebrigtsen [Tue, 15 Oct 2019 06:42:28 +0000 (08:42 +0200)]
Make auth-source work with non-ASCII passwords again

* lisp/auth-source.el (auth-source--obfuscate): Convert the string
to bytes before obfuscating.
(auth-source--deobfuscate): Convert back into a string (bug#37758).

5 years agoAdd new macro `benchmark-progn'
Lars Ingebrigtsen [Tue, 15 Oct 2019 06:19:08 +0000 (08:19 +0200)]
Add new macro `benchmark-progn'

* doc/lispref/debugging.texi (Profiling): Mention it.

* lisp/emacs-lisp/benchmark.el (benchmark-progn): New macro.

5 years agoFix python-shell font-lock cleanup for unclosed quotes (Bug#32390)
Carlos Pita [Tue, 4 Dec 2018 22:35:09 +0000 (19:35 -0300)]
Fix python-shell font-lock cleanup for unclosed quotes (Bug#32390)

The problem originating this report was:

-------------
In [15]: "
  File "<ipython-input-15-3b7a06bb1102>", line 1
    "
     ^
SyntaxError: EOL while scanning string literal

In [16]:   string face still here"
-------------

This happens because
python-shell-font-lock-comint-output-filter-function is called twice,
first for the error output and then for the "In [16]: " part.  The
first time python-shell-comint-end-of-output-p returns nil since
we're *not* at the end of an input prompt.  The second time it returns
0 since we're at the end of *just* an input prompt.  So we don't call
python-shell-font-lock-cleanup-buffer either time.

The current code is relying in a very weak rule: it considers "just an
input prompt" to be a continuation prompt.  Another unreliable aspect
of the current rule is that sometimes

    (python-shell-comint-end-of-output-p (ansi-color-filter-apply output))

returns 1 and not 0 for continuation prompts.  In short, the rule does
a very poor job identifying continuations.

* lisp/progmodes/python.el (python-shell-font-lock-cleanup-buffer):
Don't check for empty OUTPUT since python-shell-comint-end-of-output-p
returns nil for that anyway.  Don't check for
python-shell-comint-end-of-output-p returning a specific number
because it's unreliable, just check for any non-nil.  Identify
continuation prompts by looking for "...".

5 years agoAdd images on tab-bar buttons the first time the tab bar is activated
Juri Linkov [Mon, 14 Oct 2019 22:43:45 +0000 (01:43 +0300)]
Add images on tab-bar buttons the first time the tab bar is activated

* lisp/tab-bar.el (tab-bar-mode): Set display property with image files
on tab-bar-new-button and tab-bar-close-button when tab-bar-mode is enabled
the first time.
(tab-bar-new-button, tab-bar-close-button): Use default values
without display image properties.  (Bug#37685)

5 years agolisp/*.el: Force non-nil result to t, to match docstring
Juanma Barranquero [Mon, 14 Oct 2019 21:52:21 +0000 (23:52 +0200)]
lisp/*.el: Force non-nil result to t, to match docstring

* lisp/ido.el (ido-ignore-item-p):
* lisp/simple.el (use-region-p):
* lisp/whitespace.el (whitespace-style-face-p)
(whitespace-style-mark-p):
* lisp/calendar/cal-islam.el (calendar-islamic-leap-year-p):
* lisp/mail/rmail.el (rmail-is-text-p):
* lisp/mh-e/mh-alias.el (mh-alias-for-from-p):
* lisp/net/imap.el (imap-message-flag-permanent-p):
* lisp/progmodes/tcl.el (tcl-real-comment-p):
* lisp/textmodes/table.el (table--point-in-cell-p):
Normalize boolean result.

5 years agoSet tab-line face height to 0.9.
Juri Linkov [Mon, 14 Oct 2019 21:50:24 +0000 (00:50 +0300)]
Set tab-line face height to 0.9.

* lisp/tab-line.el (tab-line): Set :height to 0.9.
* lisp/tab-bar.el (tab-bar): Remove :height.

5 years agoRemove the find-file-visit-truename safe-local-variable
Lars Ingebrigtsen [Mon, 14 Oct 2019 21:36:51 +0000 (23:36 +0200)]
Remove the find-file-visit-truename safe-local-variable

* lisp/files.el (find-file-visit-truename): Remove the
safe-local-variable put, because the variable is checked too late
to actually make a difference (bug#36830).

5 years agoquail/py-b5: Use U+3007 for ideographic zero (bug#3179)
Štěpán Němec [Mon, 14 Oct 2019 21:12:00 +0000 (23:12 +0200)]
quail/py-b5: Use U+3007 for ideographic zero (bug#3179)

* leim/leim-ext.el ("quail/PY-b5"): Use U+3007 instead of U+25CB for
ideographic zero.  U+25CB (used previously) is only one of the several
lookalikes (bug#3179).

5 years agorequire-final-newline doc string clarification
Lars Ingebrigtsen [Mon, 14 Oct 2019 20:49:22 +0000 (22:49 +0200)]
require-final-newline doc string clarification

* lisp/files.el (require-final-newline): Mention that the variable
applies to visited files (bug#34986).

5 years agoUse variable-pitch fonts in tab-bar and tab-line faces
Juri Linkov [Mon, 14 Oct 2019 20:07:23 +0000 (23:07 +0300)]
Use variable-pitch fonts in tab-bar and tab-line faces

* lisp/tab-bar.el (tab-bar):
* lisp/tab-line.el (tab-line):
Inherit face from variable-pitch.

5 years agoClarify C void type description in semantic
Stefan Kangas [Mon, 14 Oct 2019 19:36:14 +0000 (21:36 +0200)]
Clarify C void type description in semantic

* admin/grammars/c.by: Clarify void type.  (Bug#9222)

5 years agodired-do-shell-command doc string fix
Lars Ingebrigtsen [Mon, 14 Oct 2019 19:29:48 +0000 (21:29 +0200)]
dired-do-shell-command doc string fix

* lisp/dired-aux.el (dired-do-shell-command): Mention the guesser
variables (bug#16562).

5 years agoFix initial value of frame-inhibit-implied-resize
Juri Linkov [Mon, 14 Oct 2019 19:14:15 +0000 (22:14 +0300)]
Fix initial value of frame-inhibit-implied-resize

* src/frame.c (syms_of_frame): Update doc string and default value of
frame-inhibit-implied-resize in NS to include 'tab-bar-lines.

5 years agoMinor fixes in Introduction to Emacs Lisp
Eli Zaretskii [Mon, 14 Oct 2019 17:23:53 +0000 (20:23 +0300)]
Minor fixes in Introduction to Emacs Lisp

* doc/lispintro/emacs-lisp-intro.texi (if, save-excursion):
'defun' is a macro, not a special form anymore.  (Bug#37747)

5 years ago* lisp/tab-bar.el (tab-bar-tab-name-current): Fix with buffer-name.
Juri Linkov [Mon, 14 Oct 2019 16:51:51 +0000 (19:51 +0300)]
* lisp/tab-bar.el (tab-bar-tab-name-current): Fix with buffer-name.

5 years ago; Minor copyedits of recent documentation changes
Eli Zaretskii [Mon, 14 Oct 2019 14:35:42 +0000 (17:35 +0300)]
; Minor copyedits of recent documentation changes

* etc/NEWS:
* doc/lispref/display.texi (Face Attributes): Fix
documentation of the ':extend' face attribute.

5 years agoImprove documentation of dired-do-chmod
Stefan Kangas [Mon, 14 Oct 2019 14:00:05 +0000 (16:00 +0200)]
Improve documentation of dired-do-chmod

* lisp/dired-aux.el (dired-do-chmod): Doc fix.  The part about
MS-Windows was written by Eli Zaretskii.  (Bug#24897)

5 years agoEnable modules by default.
Philipp Stephani [Sun, 13 Oct 2019 15:26:10 +0000 (17:26 +0200)]
Enable modules by default.

The interface has been stable since Emacs 25, and most bugs are fixed
by now.

* configure.ac: Enable modules by default.

5 years agoSuppress eager completion on not connected hosts in Tramp
Michael Albinus [Mon, 14 Oct 2019 12:53:29 +0000 (14:53 +0200)]
Suppress eager completion on not connected hosts in Tramp

* lisp/net/tramp.el (tramp-completion-handle-file-name-completion):
Bind `non-essential' to t.

5 years agoMerge branch 'feature/extend_face_id'
Jimmy Aguilar Mena [Mon, 14 Oct 2019 12:29:47 +0000 (14:29 +0200)]
Merge branch 'feature/extend_face_id'

New face attribute :extend to control the face extension after
EOL.

necessary, # especially if it merges an updated upstream into a topic
branch.  # # Lines starting with '#' will be ignored, and an empty
message aborts # the commit.

5 years agoFix issue calling face_at_pos. feature/extend_face_id
Jimmy Aguilar Mena [Sun, 13 Oct 2019 21:20:22 +0000 (23:20 +0200)]
Fix issue calling face_at_pos.

*src/xdisp.c (extend_face_to_end_of_line): Add extra condition when
producing glyphs from a C string to not call face_at_pos.

5 years agoModify face_at_pos to not modify change IT.
Jimmy Aguilar Mena [Sun, 13 Oct 2019 14:56:50 +0000 (16:56 +0200)]
Modify face_at_pos to not modify change IT.

src/xdisp.c (face_at_pos): Removed code to that modified
it->start_of_box_run_p and it->face_box_p.  This function should not
modify it.
(handle_face_prop): Added code to update it->start_of_box_run_p and
it->face_box_p.
(underlying_face_id): Input IT made CONST.

5 years ago; extend_face_id and fill_column_indicator corrections
Jimmy Aguilar Mena [Wed, 9 Oct 2019 14:44:21 +0000 (16:44 +0200)]
; extend_face_id and fill_column_indicator corrections

*etc/NEWS: Correction for extend face and add some comments in the
code.

5 years ago*etc/NEWS: Added comment about :extend face attribute in NEWS.
Jimmy Aguilar Mena [Sun, 29 Sep 2019 19:41:00 +0000 (21:41 +0200)]
*etc/NEWS: Added comment about :extend face attribute in NEWS.

5 years agoDocument new :extend face attribute in manuals.
Jimmy Aguilar Mena [Sat, 21 Sep 2019 21:34:40 +0000 (23:34 +0200)]
Document new :extend face attribute in manuals.

Some stylistic corrections in src/xdisp.c and src/xfaces.c.

5 years agoFixed merge_face_ref recursive calls.
Jimmy Aguilar Mena [Sat, 21 Sep 2019 18:33:38 +0000 (20:33 +0200)]
Fixed merge_face_ref recursive calls.

* src/xfaces.c (merge_face_ref): Fixed recursive calls to consider
filter when CONSP (face_ref).

5 years agoOptimization in extend_face
Jimmy Aguilar Mena [Sat, 21 Sep 2019 17:57:17 +0000 (19:57 +0200)]
Optimization in extend_face

* src/xdisp.c (extend_face_to_end_of_line): Optimization to void
calls to face_at_pos.

5 years agoExtend_face simplify.
Jimmy Aguilar Mena [Sat, 21 Sep 2019 15:04:09 +0000 (17:04 +0200)]
Extend_face simplify.

* src/dispextern.h (struct it): Removed extend_face unneeded members.
* src/xdisp.c (handle_face_prop_general): renamed to face_at_pos and
removed input parameter initial_face_id. Updated all occurrences.

5 years agoAdded parameter attr_filter to face_at_string_position.
Jimmy Aguilar Mena [Sun, 15 Sep 2019 21:14:48 +0000 (23:14 +0200)]
Added parameter attr_filter to face_at_string_position.

Update all the occurrences in src/xdisp.c and src/xfaces.c

5 years agoExtend face hl-line after end-of-line
Jimmy Aguilar Mena [Sat, 14 Sep 2019 21:46:10 +0000 (23:46 +0200)]
Extend face hl-line after end-of-line

* lisp/hl-line.el (face hl-line): Added extend attribute to hl-line
face.

5 years agoFix last change in append_space_for_newline.
Jimmy Aguilar Mena [Sat, 14 Sep 2019 21:43:32 +0000 (23:43 +0200)]
Fix last change in append_space_for_newline.

 * src/xdisp.c (append_space_for_newline): Code refactor and
 simplification.

5 years agoAdd space for cursor to work also in terminal.
Jimmy Aguilar Mena [Sat, 14 Sep 2019 19:15:17 +0000 (21:15 +0200)]
Add space for cursor to work also in terminal.

* src/xdisp.c (append_space_for_newline): Modified to add the space
with the last face also in terminal interface.
(fill_column_indicator_column): Modified to group more conditions.
(extend_face_to_end_of_line): Simplified code in
fill_column_indicator to use the new function.

5 years agoChanged handle_face_prop_general prototype.
Jimmy Aguilar Mena [Mon, 9 Sep 2019 14:10:57 +0000 (16:10 +0200)]
Changed handle_face_prop_general prototype.

* src/xdisp.h (handle_face_prop_general): Changed function prototype
to receive different arguments.

5 years agoFixed extend face filtered for prop.
Jimmy Aguilar Mena [Sun, 8 Sep 2019 12:41:31 +0000 (14:41 +0200)]
Fixed extend face filtered for prop.

* src/xfaces.c (face_at_buffer_position): Pass ATTR_FILTER to
merge_face_ref in when !NILP (prop).

5 years agoCall handle_face_prop_general to extend face.
Jimmy Aguilar Mena [Sat, 12 Oct 2019 17:51:46 +0000 (19:51 +0200)]
Call handle_face_prop_general to extend face.

* src/xdisp.c (extend_face_to_end_of_line): Added a call to
handle_face_prop_general to extend face after EOL according to
parameter :extend in the faces.