]> git.eshelyaron.com Git - emacs.git/log
emacs.git
5 years agoAdd an ISO 8601 parsing library
Lars Ingebrigtsen [Mon, 29 Jul 2019 12:22:31 +0000 (14:22 +0200)]
Add an ISO 8601 parsing library

* doc/lispref/os.texi (Time Parsing): Document it.

* lisp/calendar/iso8601.el: New file.

* test/lisp/calendar/iso8601-tests.el: Test ISO8601 parsing functions.

5 years agoAdd support for dealing with decoded time structures
Lars Ingebrigtsen [Mon, 29 Jul 2019 12:15:03 +0000 (14:15 +0200)]
Add support for dealing with decoded time structures

* doc/lispref/os.texi (Time Conversion): Document the new
functions that work on decoded time.
(Time Calculations): Document new date/time functions.

* lisp/simple.el (decoded-time-second, decoded-time-minute)
(decoded-time-hour, decoded-time-day, decoded-time-month)
(decoded-time-year, decoded-time-weekday, decoded-time-dst)
(decoded-time-zone): New accessor functions for decoded time values.

* lisp/calendar/time-date.el (date-days-in-month)
(date-ordinal-to-time): New functions.
(decoded-time--alter-month, decoded-time--alter-day)
(decoded-time--alter-second, make-decoded-time): New functions
added to manipulate decoded time structures.

* src/timefns.c (Fdecode_time): Mention the new accessors.

* test/lisp/calendar/time-date-tests.el: New file to test the
decoded time functions and the other new functions.

5 years agoFix compilation warning in mh-*.el
Lars Ingebrigtsen [Mon, 29 Jul 2019 12:03:37 +0000 (14:03 +0200)]
Fix compilation warning in mh-*.el

* lisp/mh-e/mh-speed.el (mh-speed-parse-flists-output):
* lisp/mh-e/mh-search.el (mh-index-parse-search-regexp): Avoid
warning about `values-list' by using `cl-values-list' insead.

5 years agoAvoid error when killing rcirc buffer
Lars Ingebrigtsen [Sun, 28 Jul 2019 22:41:56 +0000 (00:41 +0200)]
Avoid error when killing rcirc buffer

* lisp/net/rcirc.el (rcirc-kill-buffer-hook): Delete the process
in the buffer when killing server buffers to avoid triggering
errors from the sentinel (bug#23168).

5 years ago* lisp/char-fold.el: Rename char-fold-make-table to char-fold--make-table.
Juri Linkov [Sun, 28 Jul 2019 22:55:34 +0000 (01:55 +0300)]
* lisp/char-fold.el: Rename char-fold-make-table to char-fold--make-table.

5 years agoMove some uncontroversial char-folding pairs from test data to default values
Juri Linkov [Sun, 28 Jul 2019 22:45:36 +0000 (01:45 +0300)]
Move some uncontroversial char-folding pairs from test data to default values

* lisp/char-fold.el (char-fold--default-include)
(char-fold--default-exclude): Add some default values.

* test/lisp/char-fold-tests.el (char-fold--test-without-customization)
(char-fold--test-with-customization): Move some test data to
default values.  Add more data for tests to pass.   (Bug#35689)

5 years agoRename the new `browse-url-external-browser' variable
Lars Ingebrigtsen [Sun, 28 Jul 2019 22:07:34 +0000 (00:07 +0200)]
Rename the new `browse-url-external-browser' variable

* lisp/net/shr.el (shr-external-browser, shr-browse-url):
* lisp/net/eww.el (eww-browse-with-external-browser)
(eww-follow-link):
* lisp/net/browse-url.el
(browse-url-secondary-browser-function)
(browse-url-button-open):
* lisp/gnus/gnus-sum.el (gnus-summary-browse-url): Rename from
`browse-url-external-browser' to
`browse-url-secondary-browser-function'.

5 years agoMake let-alist work with vectors
Lars Ingebrigtsen [Sun, 28 Jul 2019 21:28:18 +0000 (23:28 +0200)]
Make let-alist work with vectors

* lisp/emacs-lisp/let-alist.el (let-alist--deep-dot-search):
Descend into vectors, too, looking for dotted variables (bug#23244).

Test case:

(let-alist '((a . 1) (b . 2))
  `[,(+ .a) ,(+ .a .b .b)])

5 years agoMake the image keymaps not extend after the image
Lars Ingebrigtsen [Sun, 28 Jul 2019 20:48:18 +0000 (22:48 +0200)]
Make the image keymaps not extend after the image

* lisp/image.el (insert-image): Make all the properties
rear-nonsticky.  Before this change, the keymap would extend after
the image.

5 years agoFix when calling prettify-symbols-mode more than once
Lars Ingebrigtsen [Sun, 28 Jul 2019 20:14:30 +0000 (22:14 +0200)]
Fix when calling prettify-symbols-mode more than once

* lisp/progmodes/prog-mode.el (prettify-symbols-mode): Allow
calling this mode several times without the earlier symbol alist
shadowing the newer (bug#23255).

5 years agoAbbreviate directory names the same way as file names in C-x C-b
Lars Ingebrigtsen [Sun, 28 Jul 2019 15:31:56 +0000 (17:31 +0200)]
Abbreviate directory names the same way as file names in C-x C-b

* lisp/buff-menu.el (Buffer-menu--pretty-file-name): Abbreviate
directory file names, too (bug#23355).

5 years ago* admin/notes/git-workflow: Replace git-new-workdir with git
Andreas Schwab [Sun, 28 Jul 2019 15:43:34 +0000 (17:43 +0200)]
* admin/notes/git-workflow: Replace git-new-workdir with git
worktree and remove draft marker.

5 years agoTweak tango-dark-theme
Lars Ingebrigtsen [Sun, 28 Jul 2019 15:22:16 +0000 (17:22 +0200)]
Tweak tango-dark-theme

* etc/themes/tango-dark-theme.el: Add a lighter background color
to `header-line' (bug#23359).

5 years agoScale images in iimage-mode
Lars Ingebrigtsen [Sun, 28 Jul 2019 14:48:15 +0000 (16:48 +0200)]
Scale images in iimage-mode

* lisp/iimage.el (iimage-mode-buffer): Scale images down to the
width/height of the buffer (bug#23434).  Also add `image-map' to
the images so that they can be further scaled.

5 years agoMerge branch 'master' of git.sv.gnu.org:/srv/git/emacs
Vincent Belaïche [Sun, 28 Jul 2019 14:46:10 +0000 (16:46 +0200)]
Merge branch 'master' of git.sv.gnu.org:/srv/git/emacs

5 years agoMake atomic cell update in data area.
Vincent Belaïche [Sun, 28 Jul 2019 14:45:22 +0000 (16:45 +0200)]
Make atomic cell update in data area.

* lisp/ses.el (ses-write-cells): Set inhibit-quit to t during the data
  area write.

5 years ago; * lisp/emacs-lisp/derived.el (define-derived-mode): Doc fix.
Eli Zaretskii [Sun, 28 Jul 2019 14:31:17 +0000 (17:31 +0300)]
; * lisp/emacs-lisp/derived.el (define-derived-mode): Doc fix.

5 years agoMake URLs in package descriptions into links
Lars Ingebrigtsen [Sun, 28 Jul 2019 14:01:45 +0000 (16:01 +0200)]
Make URLs in package descriptions into links

* lisp/emacs-lisp/package.el (describe-package-1): Make the URLs
in package descriptions into links (bug#23480).

5 years agoEnable browse-url to buttonize buffers
Lars Ingebrigtsen [Sun, 28 Jul 2019 13:55:31 +0000 (15:55 +0200)]
Enable browse-url to buttonize buffers

This patch also moves the internal/external browser logic from
shr to browse-url, where it belongs more naturally.

* doc/misc/eww.texi (Basics): Adjust to browse-url-external-browser.

* doc/misc/gnus.texi (Article Commands): Ditto.

* lisp/gnus/gnus-art.el (gnus-button-url-regexp): Default to
`browse-url-button-regexp', which has taken over the definition
previously enjoyed by this variable.

* lisp/gnus/gnus-sum.el (gnus-summary-browse-url): Adjust usage.

* lisp/net/browse-url.el (browse-url--browser-defcustom-type): New
internal variable...
(browse-url-browser-function, browse-url-external-browser): Used
by these two; the latter of which is a new variable.
(browse-url-botton-regexp): New variable.
(browse-url-button-map): New keymap.
(browse-url-button): New face.
(browse-url-add-buttons): New function to add clickable browse-url
buttons to almost any buffer.
(browse-url-button-open): New command.
(browse-url-button-copy): New command.

* lisp/net/eww.el (eww-browse-with-external-browser)
(eww-follow-link): Adjust usage.

* lisp/net/shr.el (shr-external-browser): Make an obsolete alias
of `browse-url-external-browser'.
(shr-browse-url): Adjust usage.

5 years agoCC Mode. Fix (c-beginning-of-defun -1) getting stuck with structs.
Alan Mackenzie [Sun, 28 Jul 2019 13:30:38 +0000 (13:30 +0000)]
CC Mode.  Fix (c-beginning-of-defun -1) getting stuck with structs.

In particular, with an initialization such as struct foo {..} bar = {...};

* lisp/progmodes/cc-cmds.el (c-forward-to-nth-EOF-{): Rename to
c-forward-to-nth-EOF-\;-or-}, and when the starting (or ending) position is in
the "variable" part of a struct/class/union/enum/etc., move to after the
terminating semicolon.  Adjust the counting such that N only gets decremented
on a successful movement over {..}.
(c-beginning-of-defun, c-end-of-defun): Rename the calls to
c-forward-to-nth-EOF-}, as above.

5 years ago; Make etc/NEWS consistent
Michael Albinus [Sun, 28 Jul 2019 12:29:15 +0000 (14:29 +0200)]
; Make etc/NEWS consistent

5 years agoMake cl-values-list signal an error if its argument isn't a list
Lars Ingebrigtsen [Sun, 28 Jul 2019 12:14:46 +0000 (14:14 +0200)]
Make cl-values-list signal an error if its argument isn't a list

* lisp/emacs-lisp/cl-lib.el (cl-values-list): Signal an error if
LIST isn't a list (bug#23597).

5 years agoHave emacsbug only warn the user when sending to the bug address
Lars Ingebrigtsen [Sun, 28 Jul 2019 11:54:44 +0000 (13:54 +0200)]
Have emacsbug only warn the user when sending to the bug address

* lisp/mail/emacsbug.el (report-emacs-bug-hook): Only ask for
confirmation if we're really sending the bug report to the bug
address.  If the user is sending it somewhere else (to themselves,
for instance), the warning is misleading.

5 years agoAllow the user to send a bug report after initially saying "no"
Lars Ingebrigtsen [Sun, 28 Jul 2019 11:50:36 +0000 (13:50 +0200)]
Allow the user to send a bug report after initially saying "no"

* lisp/mail/emacsbug.el (report-emacs-bug-hook): Don't remove the
address in the To: header (or the hook) after the user has said
"no" (bug#23799).  This made it impossible for the user to do
touch-ups and then resent the bug report.

5 years agoAlways set the state of the "Show hidden files" gtk button
Lars Ingebrigtsen [Sun, 28 Jul 2019 10:49:30 +0000 (12:49 +0200)]
Always set the state of the "Show hidden files" gtk button

* src/gtkutil.c (xg_get_file_with_chooser): Always set the state
of the "Show hidden files" button (bug#23977).  If not, the
visible state and the actual state get out of sync.

5 years agoMake `ispell-change-dictionary' only list installed dictionaries
Lars Ingebrigtsen [Sun, 28 Jul 2019 10:26:01 +0000 (12:26 +0200)]
Make `ispell-change-dictionary' only list installed dictionaries

* lisp/textmodes/ispell.el (ispell-find-aspell-dictionaries): If
the backend (i.e., aspell/hunspell) provided a list of languages,
don't add the base list (bug#24050).
(ispell-set-spellchecker-params): Ditto.

5 years agoClean up conf-mode-syntax-table slightly
Lars Ingebrigtsen [Sun, 28 Jul 2019 09:48:32 +0000 (11:48 +0200)]
Clean up conf-mode-syntax-table slightly

* lisp/textmodes/conf-mode.el (conf-mode-syntax-table): Remove
superfluous backslash in ?\'.

5 years agoMark block/char devices the same as sockets in dired
Lars Ingebrigtsen [Sun, 28 Jul 2019 10:00:24 +0000 (12:00 +0200)]
Mark block/char devices the same as sockets in dired

* lisp/dired.el (dired-re-socket): Also mark block and char
devices with the socket face (bug#24547).

5 years ago`unknown' test case now works
Lars Ingebrigtsen [Sun, 28 Jul 2019 09:40:30 +0000 (11:40 +0200)]
`unknown' test case now works

5 years agoFix testcover.el usage of edebug.el symbols
Lars Ingebrigtsen [Sun, 28 Jul 2019 09:39:22 +0000 (11:39 +0200)]
Fix testcover.el usage of edebug.el symbols

* lisp/emacs-lisp/testcover.el (testcover-before)
(testcover-after, testcover-mark)
(testcover-analyze-coverage-edebug-after): Adjust usage of
`unknown' to `edebug-unknown' in testcover.el in addition to
edebug.el (bug#25471).

5 years ago* lisp/emacs-lisp/autoload.el: Make progress info more informative.
Stefan Monnier [Sat, 27 Jul 2019 21:53:46 +0000 (17:53 -0400)]
* lisp/emacs-lisp/autoload.el: Make progress info more informative.

(update-directory-autoloads): Include the name of the target file.

5 years ago* lisp/emacs-lisp/bytecomp.el (byte-compile-out-toplevel): Fix bug#34757
Stefan Monnier [Sat, 27 Jul 2019 21:28:10 +0000 (17:28 -0400)]
* lisp/emacs-lisp/bytecomp.el (byte-compile-out-toplevel): Fix bug#34757

This fix was provided by Pip Cet <pipcet@gmail.com>.  It tightens the
code that tries to recognize a bytecode sequence as being a simple
function call (to then decompile it), which occasionally misfired.

I added some minor changes found while investigating this issue.

(byte-compile): Handle corner case where byte-compile-top-level returns
a non-self-evaluating expression.
(byte-compile-out-toplevel): Remove support for `progn` and `t` values
of output-type which aren't used anywhere.

5 years agoFix stretch glyphs overlap with line above (bug#36633)
Alan Third [Tue, 16 Jul 2019 20:32:23 +0000 (21:32 +0100)]
Fix stretch glyphs overlap with line above (bug#36633)

* src/nsterm.m (ns_dumpglyphs_stretch): Move overwriting of the
clipping rectangle to after performing clipping.

5 years agoFix arithmetic overflow in GC consing count
Paul Eggert [Sat, 27 Jul 2019 17:24:19 +0000 (10:24 -0700)]
Fix arithmetic overflow in GC consing count

* src/alloc.c (allow_garbage_collection):
Redo expression to avoid signed arithmetic overflow
in an intermediate expression when CONSING is negative.

5 years agoJava Mode: Fix handling of nested generics ending in >>>.
Alan Mackenzie [Sat, 27 Jul 2019 16:28:48 +0000 (16:28 +0000)]
Java Mode: Fix handling of nested generics ending in >>>.

This fixes bug #24671.

* lisp/progmodes/cc-langs.el (c-multichar->-op-not->>-regexp): remove,
transforming into ...
(c-multichar->-op-not->>->>>-regexp) New lang const/var.

* lisp/progmodes/cc-engine.el (c-forward-<>-arglist-recur): use the new
c-multichar->-op-not->>->>>-regexp in place of the old
c-multichar->-op-not->>-regexp.

5 years agoAdjust location of Gnus group split setup process
Eric Abrahamsen [Sat, 27 Jul 2019 16:11:04 +0000 (09:11 -0700)]
Adjust location of Gnus group split setup process

Updating group splits requires the gnus-newsrc-hashtb to be
initialized. Previously this failed silently, now it errors.

* lisp/gnus/gnus-mlspl.el (gnus-group-split-setup): Don't call the
update when loading the user's init file, that's too early. Use
appropriate hooks depending on AUTO-UPDATE.
* doc/misc/gnus.texi (Group Mail Splitting): Change mention in docs.

5 years agoTouch of latin-ltx input method for long arrows
Lars Ingebrigtsen [Sat, 27 Jul 2019 14:55:30 +0000 (16:55 +0200)]
Touch of latin-ltx input method for long arrows

* lisp/leim/quail/latin-ltx.el: Map all the \\long.*arrow inputs
to the long characters instead of the normal ones (i.e., LONG
RIGHTWARDS ARROW instead of RIGHTWARDS ARROW) (bug#24302).

5 years agoFix documentation of 'redisplay-highlight-region-function'
Eli Zaretskii [Sat, 27 Jul 2019 14:52:47 +0000 (17:52 +0300)]
Fix documentation of 'redisplay-highlight-region-function'

* lisp/simple.el (redisplay-highlight-region-function): Fix
last change.  (Bug#24701)

5 years agoTweak font-locking in conf-mode for "#foo { bar" lines
Lars Ingebrigtsen [Sat, 27 Jul 2019 14:50:25 +0000 (16:50 +0200)]
Tweak font-locking in conf-mode for "#foo { bar" lines

* lisp/textmodes/conf-mode.el (conf-font-lock-keywords): Don't
font-lock comments as keywords (bug#24355).

5 years agoMake dired fontify pipes and sockets
Lars Ingebrigtsen [Sat, 27 Jul 2019 14:25:39 +0000 (16:25 +0200)]
Make dired fontify pipes and sockets

* lisp/dired.el (dired-socket): New face for pipes and sockets
(bug#24547).
(dired-re-socket): New regexp to match them.
(dired-font-lock-keywords): Use them.

5 years agoAdd a doc string to redisplay-highlight-region-function
Lars Ingebrigtsen [Sat, 27 Jul 2019 13:59:32 +0000 (15:59 +0200)]
Add a doc string to redisplay-highlight-region-function

* lisp/simple.el (redisplay-highlight-region-function): Add a doc
string (bug#24701).

5 years ago* lisp/progmodes/compile.el: Fix bug#36803.
Stefan Monnier [Sat, 27 Jul 2019 13:57:18 +0000 (09:57 -0400)]
* lisp/progmodes/compile.el: Fix bug#36803.

Make sure all mode-lines are updated when compilation-in-progress
is changed since it's visible globally.

(compilation--update-in-progress-mode-line): New function.
(compilation-start, compilation-sentinel): Use it.

5 years agoCC Mode: Stop /**/ spuriously fontifying as a doc comment under gtkdoc
Alan Mackenzie [Sat, 27 Jul 2019 12:55:53 +0000 (12:55 +0000)]
CC Mode: Stop /**/ spuriously fontifying as a doc comment under gtkdoc

Also fix infinite loops by correcting two regexps.

* lisp/progmodes/cc-langs.el (c-last-c-comment-end-on-line-re)
(c-last-open-c-comment-start-on-line-re): Correct the regexp fragments
"\\*+[^/]" to "\\*+\\([^*/]\\|$\\)".

* lisp/progmodes/cc-fonts.el (gtkdoc-font-lock-keywords): Disallow /**/ for
doc comment fontification.

5 years agoDoc fix for package-menu-filter
Lars Ingebrigtsen [Sat, 27 Jul 2019 12:38:40 +0000 (14:38 +0200)]
Doc fix for package-menu-filter

* lisp/emacs-lisp/package.el (package-menu-filter): Document the
use of arc:ARCHIVE and status:STATUS (bug#24883).

5 years agoAllow serial-term to take an optional argument for line-mode
Lars Ingebrigtsen [Sat, 27 Jul 2019 12:18:27 +0000 (14:18 +0200)]
Allow serial-term to take an optional argument for line-mode

* lisp/term.el (serial-term): Allow taking an optional argument to
avoid term-raw-mode (bug#24922).

* doc/lispref/processes.texi (Serial Ports): Document it.

5 years agoOnly insert XML declarations in nxml-mode when the buffer is empty
Lars Ingebrigtsen [Sat, 27 Jul 2019 12:01:10 +0000 (14:01 +0200)]
Only insert XML declarations in nxml-mode when the buffer is empty

* lisp/nxml/nxml-mode.el (nxml-mode): Don't insert the XML
declaration unless it's an empty buffer (bug#24978).  This avoids
the problem of the declaration being inserted by mistake when
opening XML files from archives and the like -- the file doesn't
exist on the file system there, either, so it would typically lead
to doubled XML declarations.

5 years agoedebug.el comment fix
Lars Ingebrigtsen [Sat, 27 Jul 2019 11:34:17 +0000 (13:34 +0200)]
edebug.el comment fix

* lisp/emacs-lisp/edebug.el: Fix comment referring to non-existent
variable (bug#25188).

5 years agoClarify yank-pop doc string
Lars Ingebrigtsen [Sat, 27 Jul 2019 11:15:03 +0000 (13:15 +0200)]
Clarify yank-pop doc string

* lisp/simple.el (yank-pop): Mention `kill-ring' to make it more
clear what the command is doing (bug#25196).

5 years agoMerge branch 'master' of git.savannah.gnu.org:/srv/git/emacs
Eli Zaretskii [Sat, 27 Jul 2019 11:11:59 +0000 (14:11 +0300)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

5 years agoMove tty-colors-tests.el to its proper directory.
Eli Zaretskii [Sat, 27 Jul 2019 11:10:20 +0000 (14:10 +0300)]
Move tty-colors-tests.el to its proper directory.

5 years agoUse the CSS convention for #RGB colors (bug#36304)
Pip Cet [Mon, 22 Jul 2019 02:40:35 +0000 (02:40 +0000)]
Use the CSS convention for #RGB colors (bug#36304)

* src/xterm.c (x_parse_color): Change interpretation of #RGB color
triplets to match CSS rather than X conventions.

* lisp/term/tty-colors.el (tty-color-standard-values): Change
interpretation of #RGB color triplets to match CSS rather than X
conventions.  Allow upper-case digits.  Fix rgb:R/G/B
interpretation.

* doc/emacs/display.texi (Colors): Specify the convention used for
"#RGB" color triplets.

* test/lisp/tty-colors-tests.el: New file.

* etc/NEWS: Mention the change.

5 years agoAllow global-auto-revert-ignore-buffer to be a predicate function
Lars Ingebrigtsen [Sat, 27 Jul 2019 11:04:33 +0000 (13:04 +0200)]
Allow global-auto-revert-ignore-buffer to be a predicate function

* lisp/autorevert.el (global-auto-revert-ignore-buffer): Allow
this to be a predicate function (bug#25277).
(auto-revert--global-add-current-buffer): Use it.

5 years agoDon't double-decompress cached HTTP responses (bug#36773)
Pip Cet [Thu, 25 Jul 2019 13:22:15 +0000 (13:22 +0000)]
Don't double-decompress cached HTTP responses (bug#36773)

* lisp/url/url-http.el (url-handle-content-transfer-encoding): Modify
the message headers as well as the message body to reflect
decompression.
* lisp/mail/mail-utils.el (mail-fetch-field): Add DELETE argument, to
delete header lines included in the result.

5 years agoRename coverage symbols in edebug to avoid collisions
Lars Ingebrigtsen [Sat, 27 Jul 2019 10:21:30 +0000 (12:21 +0200)]
Rename coverage symbols in edebug to avoid collisions

* lisp/emacs-lisp/edebug.el (edebug-clear-coverage): Use
edebug-unknown and edebug-ok-coverage instead of unknown and
ok-coverage to avoid naming collisions with packages that use
those two symbols (bug#25471).
(edebug--update-coverage, edebug-display-freq-count): Ditto.

5 years agoAllow directory-files-recursively to follow symlinks
Lars Ingebrigtsen [Fri, 26 Jul 2019 15:03:42 +0000 (17:03 +0200)]
Allow directory-files-recursively to follow symlinks

* doc/lispref/files.texi (Contents of Directories): Document it.

* lisp/files.el (directory-files-recursively): Allow following
symlinks.

5 years agodefine-derived-mode doc string clarification
Lars Ingebrigtsen [Sat, 27 Jul 2019 10:04:53 +0000 (12:04 +0200)]
define-derived-mode doc string clarification

* lisp/emacs-lisp/derived.el (define-derived-mode): Doc string
clarification about the keywords (bug#26301).

5 years agoClarify docstring of last-command-event.
Noam Postavsky [Fri, 26 Jul 2019 21:25:08 +0000 (17:25 -0400)]
Clarify docstring of last-command-event.

* src/keyboard.c (syms_of_keyboard) <last-command-event>: Reword docstring.

5 years agoAdjust remaining uses of `NILP (HASH_HASH)`.
Stefan Monnier [Fri, 26 Jul 2019 20:55:59 +0000 (16:55 -0400)]
Adjust remaining uses of `NILP (HASH_HASH)`.

* src/json.c (lisp_to_json_toplevel_1):
* src/pdumper.c (dump_hash_table_stable_p, hash_table_contents):
* src/print.c (print, print_vectorlike):
* src/minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
Use `EQ (HASH_KEY, Qunbound)` instead of `NILP (HASH_HASH)`.

5 years agoDon't dump the `hash` vector if it will need to be recomputed anyway
Stefan Monnier [Fri, 26 Jul 2019 18:59:15 +0000 (14:59 -0400)]
Don't dump the `hash` vector if it will need to be recomputed anyway

* src/fns.c (hash_table_rehash): Only set `hash` field at the end.
(sweep_weak_table): Only set slot of `hash` vector when that vector exists.
(Fhash_table_count): No need to hash_rehash_if_needed any more.

* src/lisp.h (hash_rehash_needed_p): Test the presence of `hash` instead.

* src/pdumper.c (check_hash_table_rehash, dump_hash_table):
Set `hash` to nil to indicate that the table needs to be rehashed.

5 years ago* src/fns.c: Use `EQ (key, Qunbound)` to check if a slot is in use
Stefan Monnier [Fri, 26 Jul 2019 18:24:02 +0000 (14:24 -0400)]
* src/fns.c: Use `EQ (key, Qunbound)` to check if a slot is in use

(make_hash_table): Use Qunbound for the key_and_value table.
(maybe_resize_hash_table): Set new key_and_value slots to Qunbound.
(hash_table_rehash): Don't bother copying the old table of hashes since
we're recomputing it completely.
(hash_table_rehash): Use hash_rehash_needed_p more.
(hash_put): Add assertion that the slot was indeed considered empty.
(hash_remove_from_table, hash_clear, sweep_weak_table): Set empty
slot's key to Qunbound.
(Fmaphash): Use `EQ (key, Qunbound)` to check if a slot is in use.

* src/lisp.h (struct Lisp_Hash_Table): Update comments.

5 years ago* src/fns.c (hash_index_size): New function, extracted from make_hash_table
Stefan Monnier [Fri, 26 Jul 2019 17:29:35 +0000 (13:29 -0400)]
* src/fns.c (hash_index_size): New function, extracted from make_hash_table

(make_hash_table, maybe_resize_hash_table): Use it.

* src/pdumper.c (check_hash_table_rehash): Use hash_rehash_needed_p.

5 years agoCC Mode. Create lang vars for certain skipping expressions at compile time
Alan Mackenzie [Fri, 26 Jul 2019 17:48:45 +0000 (17:48 +0000)]
CC Mode.  Create lang vars for certain skipping expressions at compile time

This saves repeated calculations at run time.

* lisp/progmodes/cc-langs.el (c-stmt-boundary-skip-chars)
(c-stmt-boundary-skip-list, c-stmt-boundary-skip-chars-with-comma)
(c-stmt-boundary-skip-list-with-comma): New lang constants/variables.

* lisp/progmodes/cc-engine.el (c-commas-bound-stmts): New variable
(c-beginning-of-statement-1): Set c-commas-bound-stmts rather than
c-stmt-delim-chars.
(c-crosses-statement-barrier-p): Remove the now unneeded calculations of
c-stmt-delim-chars.  Set skip chars to one of the new lang variables, and
later to a substring of it.
(c-at-statement-start-p): Set c-syntactic-skip-backward from the new
variables.
(c-at-expression-start-p): Bind c-commas-bound-stmts.  Use
c-stmt-delim-chars-with-comma rather than c-stmt-delim-chars in a backward
scan.
(c-guess-basic-syntax): Bind c-commas-bound-stmts rather than
c-stmt-delim-chars to itself.  Bind c-commas-bound-stmts to t at another place
rather than setting c-stmt-delim-chars to c-stmt-delim-chars-with-comma.

5 years ago* src/fns.c (maybe_resize_hash_table): Obey rehash_size (bug#25743)
Stefan Monnier [Fri, 26 Jul 2019 17:15:20 +0000 (13:15 -0400)]
* src/fns.c (maybe_resize_hash_table): Obey rehash_size (bug#25743)

5 years agoFix recently-introduced file-name-absolute-p typo
Paul Eggert [Fri, 26 Jul 2019 16:46:18 +0000 (09:46 -0700)]
Fix recently-introduced file-name-absolute-p typo

Fix a bug introduced in 2019-07-24T21:28:13!eggert@cs.ucla.edu.
* src/fileio.c (file_name_absolute_p):
~/foo is also absolute (Bug#36809).
* test/src/fileio-tests.el (fileio-tests--file-name-absolute-p):
Rename from fileio-tests--no-such-user and add more tests.

5 years agoFix ‘make check’ failure
Paul Eggert [Fri, 26 Jul 2019 16:41:30 +0000 (09:41 -0700)]
Fix ‘make check’ failure

Problem introduced in 2019-07-26T07:08:40!larsi@gnus.org.
* lisp/emacs-lisp/ert.el (ert-summarize-tests-batch-and-exit):
Don’t count "0 unexpected" as unexpected.

5 years agoTweak the display in gnus-summary-browse-url
Lars Ingebrigtsen [Fri, 26 Jul 2019 14:06:25 +0000 (16:06 +0200)]
Tweak the display in gnus-summary-browse-url

* lisp/gnus/gnus-sum.el (gnus-summary-browse-url): Don't force
article conf, because the command may be called from the article
buffer (which may be the only buffer displayed).

5 years ago* lisp/mail/footnote.el (footnote--local-advice): Add missing comma.
Noam Postavsky [Fri, 26 Jul 2019 12:47:39 +0000 (08:47 -0400)]
* lisp/mail/footnote.el (footnote--local-advice): Add missing comma.

5 years agoSeparate out the "/" prefix into a named keymap in ibuffer
Lars Ingebrigtsen [Fri, 26 Jul 2019 12:38:35 +0000 (14:38 +0200)]
Separate out the "/" prefix into a named keymap in ibuffer

* lisp/ibuffer.el (ibuffer--filter-map): Separate out into its own
keymap (bug#25797).
(ibuffer-mode-map): Bind the "/" key to it.

5 years agoAdd version tag to smtpmail-servers-requiring-authorization
Lars Ingebrigtsen [Fri, 26 Jul 2019 12:17:14 +0000 (14:17 +0200)]
Add version tag to smtpmail-servers-requiring-authorization

* lisp/mail/smtpmail.el
(smtpmail-servers-requiring-authorization): Add version tag.

5 years agoRemove interactive spec from eshell-source-file
Lars Ingebrigtsen [Fri, 26 Jul 2019 12:13:56 +0000 (14:13 +0200)]
Remove interactive spec from eshell-source-file

* lisp/eshell/em-script.el (eshell-source-file): This function
can't work as an interactive command, so remove the interactive
spec (bug#26057).

5 years agoClarify when gpg2 and gpg are used in the epg-gpg-program doc string
Lars Ingebrigtsen [Fri, 26 Jul 2019 12:03:11 +0000 (14:03 +0200)]
Clarify when gpg2 and gpg are used in the epg-gpg-program doc string

* lisp/epg-config.el (epg-gpg-program): Doc string clarification
(bug#26090).

5 years agoMake ffap find {/etc} files again
Lars Ingebrigtsen [Fri, 26 Jul 2019 11:38:51 +0000 (13:38 +0200)]
Make ffap find {/etc} files again

* lisp/ffap.el (ffap-string-at-point-mode-alist): Make
(ffap-file-at-point) work on {/etc} again (bug#26190).

5 years agoFix obsoletion notice in dired-pop-to-buffer
Lars Ingebrigtsen [Fri, 26 Jul 2019 11:10:13 +0000 (13:10 +0200)]
Fix obsoletion notice in dired-pop-to-buffer

* lisp/dired.el (dired-pop-to-buffer): `dired-mark-pop-up' doesn't
seem to have anything to do with this function, so saying that
it's a replacement seems misleading (bug#26243).

5 years agoMinor rewording of a couple of sentences in define-derived-mode doc
Lars Ingebrigtsen [Fri, 26 Jul 2019 11:05:08 +0000 (13:05 +0200)]
Minor rewording of a couple of sentences in define-derived-mode doc

* lisp/emacs-lisp/derived.el (define-derived-mode): Reword
documentation to be less whimsical (bug#26301).

5 years agoDoc clarification in time-stamp-pattern
Lars Ingebrigtsen [Fri, 26 Jul 2019 10:38:28 +0000 (12:38 +0200)]
Doc clarification in time-stamp-pattern

* lisp/time-stamp.el (time-stamp-pattern): Try to document what
the examples mean (bug#26335).

5 years agoAdd a NEWS item about smtpmail-servers-requiring-authorization
Lars Ingebrigtsen [Fri, 26 Jul 2019 10:18:58 +0000 (12:18 +0200)]
Add a NEWS item about smtpmail-servers-requiring-authorization

5 years agoAllow specifying that SMTP auth should always be used
Lars Ingebrigtsen [Fri, 26 Jul 2019 10:16:49 +0000 (12:16 +0200)]
Allow specifying that SMTP auth should always be used

* doc/misc/smtpmail.texi (Authentication): Document it.

* lisp/mail/smtpmail.el
(smtpmail-servers-requiring-authorization): New variable (bug#26359).
(smtpmail-via-smtp): Use it.

5 years agoClarify last-command-event doc string
Lars Ingebrigtsen [Fri, 26 Jul 2019 09:34:15 +0000 (11:34 +0200)]
Clarify last-command-event doc string

* src/keyboard.c (syms_of_keyboard): Clarify the doc string
(bug#26626).

5 years agoAdd an autoload cookie to package-upload-file
Lars Ingebrigtsen [Fri, 26 Jul 2019 09:18:37 +0000 (11:18 +0200)]
Add an autoload cookie to package-upload-file

* lisp/emacs-lisp/package-x.el (package-upload-file): Add an
autoload cookie (bug#26724).

5 years agoTweak prompt when symlinking in dired
Lars Ingebrigtsen [Fri, 26 Jul 2019 09:12:03 +0000 (11:12 +0200)]
Tweak prompt when symlinking in dired

* lisp/dired-aux.el (dired-do-create-files): Fix prompt when
sym/hardlinking (bug#26870).

5 years agoDon't infloop in url.el when sending invalid basic auth
Lars Ingebrigtsen [Fri, 26 Jul 2019 08:55:39 +0000 (10:55 +0200)]
Don't infloop in url.el when sending invalid basic auth

* lisp/url/url-http.el (url-http-handle-authentication): Bail out
if the wrong credentials were passed to the server instead of
inflooping (bug#27022).

5 years agoFurther tweak dired-compress error message
Lars Ingebrigtsen [Fri, 26 Jul 2019 08:34:02 +0000 (10:34 +0200)]
Further tweak dired-compress error message

* lisp/dired-aux.el (dired-compress): The function is called on
both compression and uncompression, so be more ambiguous in the
error message.

5 years agoTweak the error message on dired compression failures
Lars Ingebrigtsen [Fri, 26 Jul 2019 08:31:59 +0000 (10:31 +0200)]
Tweak the error message on dired compression failures

* lisp/dired-aux.el (dired-compress): Fix error message.

5 years agoRemove debugging left in previous patch
Lars Ingebrigtsen [Fri, 26 Jul 2019 08:00:47 +0000 (10:00 +0200)]
Remove debugging left in previous patch

* lisp/progmodes/elisp-mode.el (elisp-completion-at-point):
Provide completion for `ignore-error'.

5 years agoAdd new macro `ignore-error'
Lars Ingebrigtsen [Fri, 26 Jul 2019 07:58:23 +0000 (09:58 +0200)]
Add new macro `ignore-error'

* doc/lispref/control.texi (Handling Errors): Document
`ignore-error'.
* lisp/subr.el (ignore-error): New macro.

* lisp/progmodes/elisp-mode.el (elisp-completion-at-point):
Provide completion for `ignore-error'.

5 years agoAlways include the number of unexpected results here too
Lars Ingebrigtsen [Fri, 26 Jul 2019 07:08:40 +0000 (09:08 +0200)]
Always include the number of unexpected results here too

* lisp/emacs-lisp/ert.el (ert-run-tests-batch): Always include the
number of unexpected results here as well.

5 years agoDon't run gpg when loading package.el
Lars Ingebrigtsen [Fri, 26 Jul 2019 06:30:24 +0000 (08:30 +0200)]
Don't run gpg when loading package.el

* lisp/emacs-lisp/package.el (package-check-signature): Don't run
gpg on startup, but just default to `allow-unsigned'.
(package-check-signature): New function to check whether a OpenPGP
configuration is found when `allow-unsigned'.
(package--check-signature-content, package--check-signature)
(package--download-one-archive, package-refresh-contents)
(package-install-from-archive): Use function instead of variable
throughout.
* doc/emacs/package.texi (Package Installation): Document this.

5 years agoMinor pdumper tweaks
Paul Eggert [Fri, 26 Jul 2019 06:17:52 +0000 (23:17 -0700)]
Minor pdumper tweaks

* src/pdumper.c (dump_hash_table_stable_p):
Bool vectors and bignums are also stable keys.
(decode_emacs_reloc, drain_reloc_list, Fdump_emacs_portable):
(dump_bitset_clear): Simplify use of memset.

5 years agoTweak the behaviour of thing-at-point--end-of-sexp
Lars Ingebrigtsen [Fri, 26 Jul 2019 05:59:41 +0000 (07:59 +0200)]
Tweak the behaviour of thing-at-point--end-of-sexp

* lisp/thingatpt.el (thing-at-point--end-of-sexp): Don't return
nil when called with point between two parentheses (bug#29499).

5 years agoDon't crash when parsing bad SVG data
Paul Eggert [Thu, 25 Jul 2019 21:29:22 +0000 (14:29 -0700)]
Don't crash when parsing bad SVG data

Derived from a patch by Pip Cet (Bug#36773#47).
* src/image.c (svg_load_image): Work around librsvg 2.40.13 bug.

5 years agoFix mouse-1 in profiler-report-mode-map
Lars Ingebrigtsen [Thu, 25 Jul 2019 20:00:59 +0000 (22:00 +0200)]
Fix mouse-1 in profiler-report-mode-map

* lisp/profiler.el (profiler-report-mode-map): Make `mouse-1'
respect `mouse-1-click-follows-link' (bug#30515).

5 years agoMake cl-destructuring-bind errors a bit more understandable
Lars Ingebrigtsen [Thu, 25 Jul 2019 19:56:17 +0000 (21:56 +0200)]
Make cl-destructuring-bind errors a bit more understandable

* lisp/emacs-lisp/cl-macs.el (cl-destructuring-bind): Make errors
when giving the wrong number of arguments to the bindings form
more informational (bug#29345).

5 years agoDon't set marks on imap groups when there are no marks to set
Eric Abrahamsen [Thu, 25 Jul 2019 19:24:43 +0000 (12:24 -0700)]
Don't set marks on imap groups when there are no marks to set

* lisp/gnus/nnimap.el (nnimap-update-qresync-info): This code runs in
a fairly tight loop and shouldn't call all these functions if not
necessary.

5 years ago* lisp/progmodes/cc-awk.el (c-awk-var-num-ket-re): Remove /x80-/xff from it.
Alan Mackenzie [Thu, 25 Jul 2019 18:46:17 +0000 (18:46 +0000)]
* lisp/progmodes/cc-awk.el (c-awk-var-num-ket-re): Remove /x80-/xff from it.

5 years agoTweak the sizing of the shr placeholder images on HiDPI screens
Lars Ingebrigtsen [Thu, 25 Jul 2019 18:44:07 +0000 (20:44 +0200)]
Tweak the sizing of the shr placeholder images on HiDPI screens

* lisp/net/shr.el (shr-make-placeholder-image): We have already
computed the size of the placeholder including the scale, so force
the automatic scale to 1.  This will make the placeholder the
correct size on HiDPI screen.

5 years agoMake `C-u w' in the Gnus Summary buffer open externally
Lars Ingebrigtsen [Thu, 25 Jul 2019 18:11:33 +0000 (20:11 +0200)]
Make `C-u w' in the Gnus Summary buffer open externally

* doc/misc/gnus.texi (Article Commands): Document new behaviour.

* lisp/gnus/gnus-sum.el (gnus-shorten-url): New function.
(gnus-summary-browse-url): Change function to make `C-u' use the
external browser (as Gnus does when you hit URLs manually).  Don't
use an initial input.

5 years agoTweak previous footnote-mode patch
Lars Ingebrigtsen [Thu, 25 Jul 2019 17:38:17 +0000 (19:38 +0200)]
Tweak previous footnote-mode patch

* lisp/mail/footnote.el (footnote--local-advice): Ensure that the
variable really is local.

5 years agoFix setting fill-paragraph-function in footnote-mode
Lars Ingebrigtsen [Thu, 25 Jul 2019 17:35:17 +0000 (19:35 +0200)]
Fix setting fill-paragraph-function in footnote-mode

* lisp/mail/footnote.el (footnote--local-advice): New macro
refactored out from the code used to advice
footnote--adaptive-fill-function in footnote-mode.
(footnote-mode): Use it to advice both that variable and
fill-paragraph-function (the latter to avoid overwriting the major
mode's value) (bug#27775)
(footnote--fill-paragraph): Adjust calling convention now that
it's an :around advice.

5 years agoFix HarfBuzz support on MS-Windows
Eli Zaretskii [Thu, 25 Jul 2019 16:47:56 +0000 (19:47 +0300)]
Fix HarfBuzz support on MS-Windows

* src/w32uniscribe.c [HAVE_HARFBUZZ]: Include hb-ot.h.
(fn_hb_ot_font_set_funcs, hb_ot_font_set_funcs): Define.
(w32hb_get_font): Call hb_ot_font_set_funcs after creating the
hb_font_t object, to make the code work with versions of
HarfBuzz before 2.0.0.  Problem reported by Stephen Leake
<stephen_leake@stephe-leake.org>.  Solution suggested by
Khaled Hosny <dr.khaled.hosny@gmail.com> in
https://lists.freedesktop.org/archives/harfbuzz/2019-July/007412.html.

5 years agoFix many-compilations case of compilation-goto-in-progress-buffer
Lars Ingebrigtsen [Thu, 25 Jul 2019 16:44:13 +0000 (18:44 +0200)]
Fix many-compilations case of compilation-goto-in-progress-buffer

* lisp/progmodes/compile.el (compilation-goto-in-progress-buffer):
Fix thinko in initial version of the function in the
many-compilations case.