]> git.eshelyaron.com Git - emacs.git/log
emacs.git
2 weeks agovc-modify-change-comment: Revert Log View buffer
Sean Whitton [Fri, 25 Oct 2024 03:13:46 +0000 (11:13 +0800)]
vc-modify-change-comment: Revert Log View buffer

* lisp/vc/vc.el (vc-modify-change-comment): Revert the Log View
buffer after modifying the change comment.

(cherry picked from commit 9729353ba019d9e7f603515dbf88cbc8807bb120)

2 weeks agoFix error message in charset.c
Eli Zaretskii [Thu, 24 Oct 2024 14:41:02 +0000 (17:41 +0300)]
Fix error message in charset.c

* src/charset.c (Fdefine_charset_internal): Don't reference
uninitialized value in error message.  (Bug#73985)

(cherry picked from commit f33bc659c9110682174157086c60203d55725d20)

2 weeks ago; Touch up & fix documentation changes from last commit
Sean Whitton [Thu, 24 Oct 2024 13:15:28 +0000 (21:15 +0800)]
; Touch up & fix documentation changes from last commit

(cherry picked from commit fefc3005d46f4ac41af624d4591b052df92e4bd0)

2 weeks agovc-clone: Make interactive; call vc-guess-url-backend
Aleksandr Vityazev [Thu, 24 Oct 2024 12:19:34 +0000 (15:19 +0300)]
vc-clone: Make interactive; call vc-guess-url-backend

* lisp/vc/vc.el (vc-clone): Make interactive.  Call
vc-guess-url-backend.  Always return DIRECTORY if it names a
directory.  New optional argument OPEN-DIR.
(vc--remotes-history): New defvar.
* etc/NEWS: Announce these changes.

(cherry picked from commit be29879850028d316592ba82cd859d31a67c1ffe)

2 weeks agoMove package-vc-heuristic-alist and related to vc.el
Aleksandr Vityazev [Thu, 24 Oct 2024 12:11:44 +0000 (15:11 +0300)]
Move package-vc-heuristic-alist and related to vc.el

* lisp/emacs-lisp/package-vc.el (package-vc--backend-type)
(package-vc-heuristic-alist, package-vc--guess-backend): Rename
to vc-cloneable-backends-custom-type, vc-clone-heuristic-alist
and vc-guess-url-backend respectively, and move to
lisp/vc/vc.el.  Make package-vc-heuristic-alist an obsolete
alias.
(package-vc--clone, package-vc--read-package-name)
(package-vc-install, package-vc-checkout): Use
vc-guess-url-backend.
* lisp/vc/vc.el (vc-cloneable-backends-custom-type)
(vc-clone-heuristic-alist, vc-guess-url-backend): New defconst,
defcustom and defun, respectively: renamed and moved here from
lisp/emacs-lisp/package-vc.el.

(cherry picked from commit 98b02f56d12f2f39a6667d33d50f9e551a267d6d)

2 weeks ago; Drop two outdated calls to 'require'
Sean Whitton [Thu, 24 Oct 2024 09:19:41 +0000 (17:19 +0800)]
; Drop two outdated calls to 'require'

* lisp/emacs-lisp/backtrace.el (require):
* lisp/wid-edit.el (require): Don't require subr-x.  if-let,
when-let and friends have all been in subr.el for a while.

(cherry picked from commit db587ae8ba7d7b281f6935ed5d038b7ecf4abd5d)

2 weeks ago* doc/misc/tramp.texi (Bug Reports): Explain bisecting.
Michael Albinus [Thu, 24 Oct 2024 09:11:03 +0000 (11:11 +0200)]
* doc/misc/tramp.texi (Bug Reports): Explain bisecting.

(cherry picked from commit 767493ccb693f65cf8621cd82f0ecf92be976f55)

2 weeks ago; Skip commit 8903106bb783c2825233c149b6799960aacdea57
Eshel Yaron [Fri, 25 Oct 2024 05:08:16 +0000 (07:08 +0200)]
; Skip commit 8903106bb783c2825233c149b6799960aacdea57

2 weeks agoUpdate special conditionals documentation
Sean Whitton [Thu, 24 Oct 2024 04:10:09 +0000 (12:10 +0800)]
Update special conditionals documentation

* doc/lispref/control.texi (Conditionals): Document if-let* and
when-let*, not if-let and when-let.  Document and-let*.

(cherry picked from commit eae798486a965ec176bef3cc343625c164986c3f)

2 weeks agovc-allow-rewriting-published-history: Use nil->ask->t
Sean Whitton [Thu, 24 Oct 2024 03:26:27 +0000 (11:26 +0800)]
vc-allow-rewriting-published-history: Use nil->ask->t

* lisp/vc/vc.el (vc-allow-rewriting-published-history): Use
increasingly permissive values nil->ask->t rather than
nil->t->no-ask.  Recommend `ask' or nil.
* lisp/vc/vc-git.el (vc-git--assert-allowed-rewrite): Update
accordingly.

(cherry picked from commit 3bb1b85b78b8079e160dcb10774fe82c2daa1b4d)

2 weeks ago; Update the NEWS entry to mention project-prompter correctly
Dmitry Gutov [Wed, 23 Oct 2024 19:49:13 +0000 (22:49 +0300)]
; Update the NEWS entry to mention project-prompter correctly

(cherry picked from commit bc8f416ee97795e77a36d6dd25a2a037bdc4a5c4)

2 weeks agoproject-prompter: Update the docstring for the recent change
Dmitry Gutov [Wed, 23 Oct 2024 19:43:18 +0000 (22:43 +0300)]
project-prompter: Update the docstring for the recent change

* lisp/progmodes/project.el (project-prompter):
Update the docstring too (bug#70833).

(cherry picked from commit efaec5f61df967e2a4b85c5607f559f92f220ca9)

2 weeks ago; * test/lisp/proced-tests.el (proced--within-buffer): Instrument macro.
Michael Albinus [Wed, 23 Oct 2024 15:01:08 +0000 (17:01 +0200)]
; * test/lisp/proced-tests.el (proced--within-buffer): Instrument macro.

Do not merge with master

(cherry picked from commit 75584a3a9614541478cf05edc6223de8db3d350c)

2 weeks agoconfigure.ac: Fix FIONREAD check with gcc-14 on Solaris
Alan Coopersmith [Wed, 23 Oct 2024 13:41:08 +0000 (15:41 +0200)]
configure.ac: Fix FIONREAD check with gcc-14 on Solaris

Before this fix, it would fail to build with gcc-14 with the error:
conftest.c: In function 'main':
conftest.c:265:11: error: implicit declaration of function 'ioctl'
 [-Wimplicit-function-declaration]
  265 | int foo = ioctl (0, FIONREAD, &foo);
      |           ^~~~~

Solaris documents ioctl() as being defined in <unistd.h>.

* configure.ac: Fix FIONREAD check with gcc-14 on Solaris.
Ref:
https://lists.gnu.org/r/emacs-devel/2024-10/msg00195.html

Copyright-paperwork-exempt: yes
(cherry picked from commit 5e5689a2a40cd16d7593a0c7ddea5511adc3bf22)

2 weeks ago; Improve documentation of 'native-compile-directory' (bug#73303)
Eli Zaretskii [Wed, 23 Oct 2024 07:00:45 +0000 (10:00 +0300)]
; Improve documentation of 'native-compile-directory' (bug#73303)

* lisp/emacs-lisp/comp.el (native-compile-directory): Doc fix.

* doc/lispref/compile.texi (Native-Compilation Functions):
Document 'native-compile-directory'.

* etc/NEWS: Improve wording.

(cherry picked from commit c037b253975da883594f10f48e0be53d81a32756)

2 weeks ago; vc-git-modify-change-comment: Restore ignoring --amend
Sean Whitton [Wed, 23 Oct 2024 02:57:40 +0000 (10:57 +0800)]
; vc-git-modify-change-comment: Restore ignoring --amend

This was accidentally lost when installing this new feature on
master.

(cherry picked from commit e756d4373bdf1b076ee284c46637855908dd10d7)

2 weeks ago; Improve comment from last change
Sean Whitton [Wed, 23 Oct 2024 02:53:02 +0000 (10:53 +0800)]
; Improve comment from last change

(cherry picked from commit f5451b6a0668f4dc9992562b62ed37a199f1fdad)

2 weeks agovc-git-modify-change-comment: Check for other autosquashing
Sean Whitton [Wed, 23 Oct 2024 02:49:22 +0000 (10:49 +0800)]
vc-git-modify-change-comment: Check for other autosquashing

* lisp/vc/vc-git.el (vc-git-modify-change-comment): Check that a
rebase with --autosquash won't make any other changes and give
the user a chance to abort.

(cherry picked from commit c259db1d454a27cc79217f4740b1ecdb4bb28114)

2 weeks ago; Insert missing quotation in FIXME
Sean Whitton [Wed, 23 Oct 2024 01:36:41 +0000 (09:36 +0800)]
; Insert missing quotation in FIXME

(cherry picked from commit 87766c88d5f343017972558d364eff024884f71a)

2 weeks agoSupport modifying VC change comments for Git
Sean Whitton [Fri, 18 Oct 2024 09:19:45 +0000 (17:19 +0800)]
Support modifying VC change comments for Git

* lisp/vc/vc.el (vc-allow-rewriting-published-history): New option.
* lisp/vc/vc-git.el (vc-git--assert-allowed-rewrite)
(vc-git-modify-change-comment): New functions (bug#64055).

(vc-git--current-branch): Factor out of vc-git-dir--branch-headers.
(vc-git--log-edit-extract-headers): Factor out of vc-git-checkin.

* etc/NEWS: Announce the new support and option.

(cherry picked from commit 00149f18ea90c0c1dae525581ef4924201336be3)

2 weeks agoDocument and-let* vs. when-let* usage convention
Sean Whitton [Wed, 23 Oct 2024 01:07:06 +0000 (09:07 +0800)]
Document and-let* vs. when-let* usage convention

* lisp/subr.el (and-let*): Document and/and-let*
vs. when/when-let* usage convention (some discussion in
bug#73853).
(when-let*): Add cross-reference to and-let*.

(cherry picked from commit 09e05f7ee4de89f5f1dd95aa9498feccfa9a78d6)

2 weeks agoFix error when splicing Eshell globs and a glob expands to itself
Jim Porter [Tue, 22 Oct 2024 16:43:00 +0000 (09:43 -0700)]
Fix error when splicing Eshell globs and a glob expands to itself

This could happen when 'eshell-extended-glob' determines that a "glob"
is not really a glob.  This mainly happens for remote file names with a
"~" in them, like "/ssh:remote:~/file.txt".

* lisp/eshell/em-glob.el (eshell-extended-glob): Return a list when
'eshell-glob-splice-results' is non-nil.
* test/lisp/eshell/em-glob-tests.el
(em-glob-test/expand/splice-results)
em-glob-test/expand/no-splice-results): Extend tests.

(cherry picked from commit b7a375f5c49ac86399b9af7a6a74720ed294abd7)

2 weeks ago* etc/package-keyring.gpg: Update expiration and add new key
Stefan Monnier [Tue, 22 Oct 2024 16:35:18 +0000 (12:35 -0400)]
* etc/package-keyring.gpg: Update expiration and add new key

(cherry picked from commit 2289e162268b82d1d757c2354bf3fdf92316e91d)

2 weeks agoAvoid crashes when scrolling images under winner-mode
Eli Zaretskii [Mon, 21 Oct 2024 17:42:01 +0000 (20:42 +0300)]
Avoid crashes when scrolling images under winner-mode

* src/window.c (window_scroll_pixel_based): Fix calculation of a
window's vscroll.  (Bug#73933)

(cherry picked from commit 48024096fea5ccdeb79dab5793a6f7a293b95919)

2 weeks ago; * doc/lispref/display.texi (Fontsets): Clarify wording.
Eli Zaretskii [Mon, 21 Oct 2024 15:32:07 +0000 (18:32 +0300)]
; * doc/lispref/display.texi (Fontsets): Clarify wording.

(cherry picked from commit c35d6ba9f07b0a8417ef116359049c0dd63e12b5)

2 weeks ago; * doc/lispref/display.texi (Fontsets): Fix typo.
Eli Zaretskii [Mon, 21 Oct 2024 10:04:18 +0000 (13:04 +0300)]
; * doc/lispref/display.texi (Fontsets): Fix typo.

(cherry picked from commit 88a1a32fc57817d5e0e1f79b83ff23d7274cbace)

2 weeks ago; Add indexing for 'use-default-font-for-symbols'
Eli Zaretskii [Mon, 21 Oct 2024 10:01:53 +0000 (13:01 +0300)]
; Add indexing for 'use-default-font-for-symbols'

* doc/emacs/mule.texi (Modifying Fontsets):
* doc/lispref/display.texi (Fontsets): Index
'use-default-font-for-symbols'.

(cherry picked from commit 6be47058cd741e5868f5c2fdef0fd59e296f18b6)

2 weeks ago* src/lread.c (READ_AND_BUFFER): Reject negative chars (bug#73914).
Eli Zaretskii [Sun, 20 Oct 2024 19:39:53 +0000 (22:39 +0300)]
* src/lread.c (READ_AND_BUFFER): Reject negative chars (bug#73914).

(cherry picked from commit 681f70ea04a30bb43bb87448a6d71458d773d247)

2 weeks ago* test/Makefile.in: Do not show emacs-module-tests.log by default.
Michael Albinus [Sun, 20 Oct 2024 09:35:06 +0000 (11:35 +0200)]
* test/Makefile.in: Do not show emacs-module-tests.log by default.

(cherry picked from commit ac4151e0023f4bf17eb128036c006618332f1ac0)

2 weeks agoFix 'php-ts-mode': better indentation and font locking
Vincenzo Pupillo [Thu, 10 Oct 2024 14:06:37 +0000 (16:06 +0200)]
Fix 'php-ts-mode': better indentation and font locking

Incomplete compound_statement or colon_block (statement-group
without a closing brace or closing keyword) that are not inside
a function or method are not recognized as such by tree-sitter-php.
A new function 'php-ts-mode--open-statement-group-heuristic'
handles this case.  Font locking of magic methods and better
support for alternative control structure syntax.
Support for latest grammar version.
* lisp/progmodes/php-ts-mode.el
(php-ts-mode--language-source-alist): Updated grammar version.
(php-ts-mode--possibly-braceless-keyword-re): Regular expression
for braceless keyword.
(php-ts-mode--open-statement-group-heuristic): New function.
(php-ts-mode--parent-html-bol): Use the new function and doc fix.
(php-ts-mode--parent-html-heuristic): Use the new function and doc
fix.
(php-ts-mode--indent-styles): Use the new function and add
'colon_block' support.
(php-ts-mode--class-magic-methods): New predefined magic methods
list.
(php-ts-mode--test-namespace-name-as-prefix-p): Doc fix.
(php-ts-mode--test-namespace-aliasing-clause-p): Fix the test and
doc.
(php-ts-mode--test-namespace-use-group-clause-p): Doc fix.
(php-ts-mode--test-visibility-modifier-operation-clause-p): New
function for the new asymmetric property visibility feature of
PHP 8.4.
(php-ts-mode--font-lock-settings): Font lock for class magic methods
and alternative syntax.  Better font lock for 'instanceof'.  Use
'font-lock-function-call-face' for scoped and member call expression.
(bug#73779)

(cherry picked from commit 4e0cb960dbd95c8001b08c62682b085292184b87)

3 weeks ago* lisp/filet.el: Add Commentary
Eshel Yaron [Thu, 24 Oct 2024 19:29:28 +0000 (21:29 +0200)]
* lisp/filet.el: Add Commentary

3 weeks ago; Update lisp/ldefs-boot.el
Eshel Yaron [Thu, 24 Oct 2024 19:01:16 +0000 (21:01 +0200)]
; Update lisp/ldefs-boot.el

3 weeks agoImprove filet.el
Eshel Yaron [Thu, 24 Oct 2024 18:59:01 +0000 (20:59 +0200)]
Improve filet.el

3 weeks agoDrop flymake-proc.el
Eshel Yaron [Thu, 24 Oct 2024 12:12:10 +0000 (14:12 +0200)]
Drop flymake-proc.el

3 weeks agoDrop flymake-cc.el
Eshel Yaron [Thu, 24 Oct 2024 12:11:48 +0000 (14:11 +0200)]
Drop flymake-cc.el

3 weeks ago* filet.el: New file
Eshel Yaron [Thu, 24 Oct 2024 12:11:17 +0000 (14:11 +0200)]
* filet.el: New file

3 weeks agoDo not rely on package.el
Eshel Yaron [Thu, 24 Oct 2024 12:08:12 +0000 (14:08 +0200)]
Do not rely on package.el

3 weeks ago* lisp/dired-aux.el (dired-query): Simplify prompt
Eshel Yaron [Thu, 24 Oct 2024 12:07:53 +0000 (14:07 +0200)]
* lisp/dired-aux.el (dired-query): Simplify prompt

3 weeks ago(eglot--connect): Guard against dead buffers
Eshel Yaron [Thu, 24 Oct 2024 12:07:28 +0000 (14:07 +0200)]
(eglot--connect): Guard against dead buffers

3 weeks agoRemove debug message
Eshel Yaron [Thu, 24 Oct 2024 12:07:10 +0000 (14:07 +0200)]
Remove debug message

3 weeks agoFix bootstrap further
Eshel Yaron [Thu, 24 Oct 2024 12:06:51 +0000 (14:06 +0200)]
Fix bootstrap further

3 weeks agoFix bootstrap
Eshel Yaron [Thu, 24 Oct 2024 12:06:31 +0000 (14:06 +0200)]
Fix bootstrap

3 weeks agoDrop newly added 'dired-yank'
Eshel Yaron [Thu, 24 Oct 2024 12:05:38 +0000 (14:05 +0200)]
Drop newly added 'dired-yank'

3 weeks agoAdd 'native-compile-directory' (bug#73303)
Andrea Corallo [Tue, 22 Oct 2024 15:46:44 +0000 (17:46 +0200)]
Add 'native-compile-directory' (bug#73303)

* lisp/emacs-lisp/comp.el (native-compile-directory): New function.
* etc/NEWS (native-compile-directory): Add to NEWS.

(cherry picked from commit 246d68bd2a5468bd428a0406402e7ad2b3005314)

3 weeks ago* Rework 'comp-lookup-eln'
Andrea Corallo [Tue, 22 Oct 2024 14:40:12 +0000 (16:40 +0200)]
* Rework 'comp-lookup-eln'

* lisp/emacs-lisp/comp.el (comp-lookup-eln): Rework to use
'comp-eln-load-path-eff'.

(cherry picked from commit 202adfcfcc2ed20fa91d8377107618c8113f7106)

3 weeks ago; Fix a recent change to EWW
Jim Porter [Tue, 22 Oct 2024 15:36:23 +0000 (08:36 -0700)]
; Fix a recent change to EWW

* lisp/net/eww.el (eww--guess-content-type): Save excursion.

(cherry picked from commit f58652a41978974855be0993d42ace225b64efed)

3 weeks ago; Skip commit a9cf51d5f01cb7067c547af2905ab391979b18f4
Eshel Yaron [Tue, 22 Oct 2024 19:03:15 +0000 (21:03 +0200)]
; Skip commit a9cf51d5f01cb7067c547af2905ab391979b18f4

3 weeks ago; Improve documentation of 'eww-guess-content-type-functions'
Eli Zaretskii [Tue, 22 Oct 2024 06:38:09 +0000 (09:38 +0300)]
; Improve documentation of 'eww-guess-content-type-functions'

* lisp/net/eww.el (eww-guess-content-type-functions): Doc fix.

* etc/NEWS: Announce 'eww-guess-content-type-functions'.

Bug#73133

(cherry picked from commit 9fdc03e8f9868bb9253a0df9bf0c1b718e8576a8)

3 weeks agoAdd customization to let EWW guess content-type if needed
Sebastián Monía [Wed, 9 Oct 2024 03:26:42 +0000 (23:26 -0400)]
Add customization to let EWW guess content-type if needed

* lisp/net/eww.el (eww-guess-content-type-functions): New user option.
(eww--guess-content-type, eww--html-if-doctype): New functions.
(eww-render): Call 'eww--guess-content-type' (bug#73133).

(cherry picked from commit 9074a9f496b04ab58588b71f51d7830782fc7a29)

3 weeks ago* lisp/files.el (require-with-check): Provide more info in the error message
Stefan Monnier [Tue, 22 Oct 2024 00:21:10 +0000 (20:21 -0400)]
* lisp/files.el (require-with-check): Provide more info in the error message

Rather than only show the "new" file to be loaded, show also the
name of the currently loaded file, to clarify the conflict.

(cherry picked from commit 8a2fbddf17b4beb31d19161769066a4c1bd8bab0)

3 weeks agoFix a race condition when running Eshell startup scripts
Jim Porter [Mon, 21 Oct 2024 21:21:50 +0000 (14:21 -0700)]
Fix a race condition when running Eshell startup scripts

Previously, these scripts could run before all the Eshell modules had
fully-initialized.

* lisp/eshell/esh-mode.el (eshell-after-initialize-hook): New hook...
(eshell-mode): ... run it.

* lisp/eshell/em-script.el (eshell-run-startup-scripts): New function...
(eshell-script-initialize): ... add it to
'eshell-after-initialize-hook'.

* etc/NEWS: Announce 'eshell-after-initialize-hook'.

(cherry picked from commit 605f26cf70ab3d7c5ea635c19cd2a280812a4ddc)

3 weeks agoLet 'tex-view' show PDFs made without a DVI (bug#73854)
Stephen Berman [Mon, 21 Oct 2024 10:50:53 +0000 (12:50 +0200)]
Let 'tex-view' show PDFs made without a DVI (bug#73854)

* lisp/textmodes/tex-mode.el (tex-print-file): Update doc string
to mention 'tex-compile'.
(tex-compile-commands): Add entries for 'evince' and 'mupdf'.
(tex-compile): Set 'tex-print-file'.

(cherry picked from commit 1f8fbae8df764e9d24f1b824de7369d82e36abae)

3 weeks ago; Reapply a fix for recent change in eww.el
Eli Zaretskii [Mon, 21 Oct 2024 05:25:06 +0000 (08:25 +0300)]
; Reapply a fix for recent change in eww.el

* lisp/net/eww.el (eww--list-buffers-display-table)
(eww-buffers-mode): Fix coding conventions.

(cherry picked from commit e289f7dbb4f04776e8327e7865a9082078c084a9)

3 weeks agoRevert "; Fix last change."
Eli Zaretskii [Mon, 21 Oct 2024 05:22:56 +0000 (08:22 +0300)]
Revert "; Fix last change."

This reverts commit 75fa0cc1ae2b53fe169fdcfef52bee6719eb38a7.
The large part of it was committed by accident.

(cherry picked from commit 88a6a17adb7eff84e05d93ea357ae3eff9a84c48)

3 weeks ago; Make utility functions for getting the Eshell non-special regexps
Jim Porter [Sun, 20 Oct 2024 23:58:44 +0000 (16:58 -0700)]
; Make utility functions for getting the Eshell non-special regexps

* lisp/eshell/esh-arg.el (eshell-inside-quote-regexp)
(eshell-outside-quote-regexp): Rename to...
(eshell--non-special-inside-quote-regexp)
(eshell--non-special-outside-quote-regexp): ... these, and add
defsubsts.
(eshell-arg-initialize): Don't initialize regexp variables.
(eshell-parse-non-special): ... use them.

* lisp/eshell/em-glob.el (eshell-glob-chars-regexp): Use 'rx-to-string'.

(cherry picked from commit b573aaab76b55ec276b9190570b3ca3ae72cb416)

3 weeks agoMake all the entries in 'eshell-parse-argument-hook' named functions
Jim Porter [Fri, 18 Oct 2024 03:02:28 +0000 (20:02 -0700)]
Make all the entries in 'eshell-parse-argument-hook' named functions

* lisp/eshell/esh-arg.el (eshell-parse-number, eshell-parse-non-special)
(eshell-parse-whitespace, eshell-parse-comment): New functions...
(eshell-parse-argument-hook): ... use them.

(cherry picked from commit 212cf3125611b123707feac6f7ffd55a230bc568)

3 weeks ago; Undo WIP accidentally included in recent commit
Sean Whitton [Mon, 21 Oct 2024 01:44:20 +0000 (09:44 +0800)]
; Undo WIP accidentally included in recent commit

(cherry picked from commit 14624ff0fb7aec095a8846c3de5b089c93aa85da)

3 weeks ago; * lisp/eshell/esh-var.el (eshell-glob-function): Remove unused defvar.
Jim Porter [Sun, 20 Oct 2024 22:34:15 +0000 (15:34 -0700)]
; * lisp/eshell/esh-var.el (eshell-glob-function): Remove unused defvar.

(cherry picked from commit fc6854cbd4733ef4247f5d9fd99d88d7b79c4dc4)

3 weeks agoBe more careful about applying spliced arguments
Jim Porter [Sun, 20 Oct 2024 22:02:18 +0000 (15:02 -0700)]
Be more careful about applying spliced arguments

Previously, this could 'nonc' to a list that shouldn't be modified.

* lisp/eshell/esh-cmd.el (eshell-rewrite-named-command): Use 'append'
instead of 'nconc'.

* test/lisp/eshell/esh-var-tests.el (esh-var-test/interp-var-splice):
(esh-var-test/quoted-interp-var-splice): New tests.

(cherry picked from commit 183c5efc0fe80074a40ebebb684d787baf578ffe)

3 weeks ago; Fix last change.
Eli Zaretskii [Sun, 20 Oct 2024 18:02:07 +0000 (21:02 +0300)]
; Fix last change.

* lisp/net/eww.el (eww--list-buffers-display-table)
(eww-buffers-mode): Fix coding conventions.

(cherry picked from commit 75fa0cc1ae2b53fe169fdcfef52bee6719eb38a7)

3 weeks agoUse vtable in eww-list-buffers and add function eww-buffer-list
Sebastián Monía [Mon, 14 Oct 2024 01:00:03 +0000 (21:00 -0400)]
Use vtable in eww-list-buffers and add function eww-buffer-list

* lisp/net/eww.el (eww-buffer-list): New function.
(eww-list-buffers): Move logic to...
(eww--list-buffers-display-table, eww--list-buffers-get-data):
... these, and use 'vtable'.
(eww-buffer-select, eww-buffer-show, eww-buffer-kill)
(eww-buffers-mode-map): Use 'vtable-current-object'.
(eww-buffers-mode): Set 'revert-buffer-function'

(cherry picked from commit d3975cc925a856c872016df734563ce0709f3efc)

3 weeks ago; Skip commit 53e84f8cfa85bb53c92936a3be73ab1445a89459
Eshel Yaron [Tue, 22 Oct 2024 19:01:35 +0000 (21:01 +0200)]
; Skip commit 53e84f8cfa85bb53c92936a3be73ab1445a89459

3 weeks ago; Skip commit 2114a955c23c213168f012f5e480edae46561fd2
Eshel Yaron [Tue, 22 Oct 2024 19:01:32 +0000 (21:01 +0200)]
; Skip commit 2114a955c23c213168f012f5e480edae46561fd2

3 weeks ago; * lisp/vc/log-view.el (log-view-modify-change-comment): Add FIXME.
Sean Whitton [Sun, 20 Oct 2024 08:40:41 +0000 (16:40 +0800)]
; * lisp/vc/log-view.el (log-view-modify-change-comment): Add FIXME.

(cherry picked from commit 6c928e490d3347cc309eda51cefbc46fba955650)

3 weeks agoMinor changes of last commit
Michael Albinus [Sun, 20 Oct 2024 08:38:00 +0000 (10:38 +0200)]
Minor changes of last commit

* lisp/autorevert.el (auto-revert--last-time): Init with 0 (Epoch).
(auto-revert-notify-handler): Simplify.

(cherry picked from commit 0bdaab7655787d717d69581e30346233e293c6f2)

3 weeks agoEnhance the auto-revert to avoid revert a buffer in short time
Lin Sun [Sun, 20 Oct 2024 08:05:19 +0000 (10:05 +0200)]
Enhance the auto-revert to avoid revert a buffer in short time

* lisp/autorevert.el (auto-revert--last-time): New defvar.
(auto-revert-handler, auto-revert-notify-handler): Use it.
* test/lisp/autorevert-tests.el (with-auto-revert-test): Set
`auto-revert--lockout-interval' correctly.

(cherry picked from commit 545c54aea1ecccf84eaebbe3a3cb7b5fbc5716f8)

3 weeks ago; Avoid byte-compiler warning in mpc.el
Eli Zaretskii [Sun, 20 Oct 2024 05:03:08 +0000 (08:03 +0300)]
; Avoid byte-compiler warning in mpc.el

* lisp/mpc.el (mpc-cmd-crossfade): Move after definition of
'mpc-crossfade-time', because the function uses it.

(cherry picked from commit 80627a31c67b383393c53bd87dd21b7f0de3844e)

3 weeks agoFix 'min-width' calculation in 'visual-wrap-prefix-mode'
Jim Porter [Sat, 19 Oct 2024 23:12:43 +0000 (16:12 -0700)]
Fix 'min-width' calculation in 'visual-wrap-prefix-mode'

* lisp/visual-wrap.el (visual-wrap--content-prefix): Remove 'min-width'
before computing the pixel width to avoid miscalculation (bug#73882).

(cherry picked from commit 81a5beb8af020e4c92a77d61c8aa5e637e2dc945)

3 weeks agoAdd ability to crossfade between songs in 'mpc'
john muhl [Sun, 29 Sep 2024 00:11:03 +0000 (19:11 -0500)]
Add ability to crossfade between songs in 'mpc'

* lisp/mpc.el (mpc-cmd-crossfade):
(mpc-toggle-crossfade): New function.
(mpc-crossfade-time): New option.
(mpc-mode-menu): Add menu item to toggle crossfade.  (Bug#73891)

(cherry picked from commit 08f3bc1b8e6a3583c8ccda02a7cf1b59c8d3f514)

3 weeks ago; * lisp/vc/log-view.el (log-view-modify-change-comment): Add FIXME.
Sean Whitton [Sun, 20 Oct 2024 01:20:07 +0000 (09:20 +0800)]
; * lisp/vc/log-view.el (log-view-modify-change-comment): Add FIXME.

(cherry picked from commit de0800c511740de7ad4dcb7dda0a0083a094d749)

3 weeks agoLazily convert numeric strings to Lisp numbers in Eshell
Jim Porter [Sat, 19 Oct 2024 18:52:42 +0000 (11:52 -0700)]
Lazily convert numeric strings to Lisp numbers in Eshell

This should reduce the number of issues with Eshell converting strings
to numbers too aggressively and losing information (e.g. "001" -> 1)
while still allowing almost all of the beneficial uses, like summing a
list of numeric strings with '+'.

* lisp/eshell/esh-util.el (eshell--do-mark-numeric-string): New
function.
(eshell-convert-to-number): Make obsolete in favor of...
(eshell-mark-numeric-string): ... this.  Update callers.

* lisp/eshell/esh-arg.el (eshell--numberlike-p): New function...
(eshell-concat-1): ... use it.

* test/lisp/eshell/esh-util-tests.el:  Reimplement type conversion tests
to use 'eshell-convertible-to-number-p' instead.

* test/lisp/eshell/esh-var-tests.el
(esh-var-test/interp-var-splice-concat, esh-var-test/interp-concat-cmd)
(esh-var-test/interp-convert-var-split-indices)
(esh-var-test/interp-convert-quoted-var-split-indices)
(esh-var-test/interp-convert-cmd-multiline)
(esh-var-test/interp-convert-cmd-split-indices): Adjust tests to check
the new behavior.

* doc/misc/eshell.texi (Type Conversion): New section.
(Expansion): Clarify concatenation behavior.

(cherry picked from commit 43d5b7a04c4b1a8a7d57f25824df2e8720d2c567)

3 weeks ago; Skip commit 902029b1410ef9128380f9a307721ea6ab008529
Eshel Yaron [Tue, 22 Oct 2024 19:00:02 +0000 (21:00 +0200)]
; Skip commit 902029b1410ef9128380f9a307721ea6ab008529

3 weeks agoNew FAQ about Ctrl keys on xterm
Eli Zaretskii [Sat, 19 Oct 2024 09:14:06 +0000 (12:14 +0300)]
New FAQ about Ctrl keys on xterm

* doc/misc/efaq.texi
(Some Ctrl-modified keys do not work on xterm): New section
(bug#73813).

(cherry picked from commit a61bf74225737a7c87b95d604b6e8c2ce9686296)

3 weeks agoAutoload 'message-narrow-to-headers-or-head' in mml.el
Eli Zaretskii [Sat, 19 Oct 2024 08:57:09 +0000 (11:57 +0300)]
Autoload 'message-narrow-to-headers-or-head' in mml.el

* lisp/gnus/mml.el (message-narrow-to-headers-or-head): Autoload
it.  (Bug#73815)

(cherry picked from commit f353fcc8506f510401982ec148b94120422f28cd)

3 weeks ago; Skip commit c1791a2749468a120bbb8b1023b041f2370fc679
Eshel Yaron [Tue, 22 Oct 2024 18:59:51 +0000 (20:59 +0200)]
; Skip commit c1791a2749468a120bbb8b1023b041f2370fc679

3 weeks agoFix etags tagging by multiline regexps
Eli Zaretskii [Sat, 19 Oct 2024 08:18:45 +0000 (11:18 +0300)]
Fix etags tagging by multiline regexps

* lib-src/etags.c (regex_tag_multiline): Fix off-by-one error in
determining the end of the tag matched by a multiline regexp.
(Bug#73771)

* test/manual/etags/ETAGS.good_4:
* test/manual/etags/ETAGS.good_5:
* test/manual/etags/ETAGS.good_6: Adjust test results to the above
change.

(cherry picked from commit d0be0965ca344caab7879b2ac2373a68025c9ba2)

3 weeks agoHide default-directory absolute file name in dired-hide-details-mode
Álvaro Ramírez [Wed, 2 Oct 2024 10:36:57 +0000 (11:36 +0100)]
Hide default-directory absolute file name in dired-hide-details-mode

* lisp/dired.el (dired-hide-details-hide-absolute-location):
New user option.
(dired-insert-directory, dired-build-subdir-alist): Use it to
hide absolute file name of the directory.
(dired-hide-details-mode): Update doc string.
* test/lisp/dired-tests.el
(dired-test-hide-absolute-location-enabled)
(dired-test-hide-absolute-location-disabled): New tests

* etc/NEWS: Announce the new feature.

Bug#72272

(cherry picked from commit 7cbca90569472af5643905fca5b7ab2dea67f876)

3 weeks agoRewrite Speedbar expansion for all descendants (bug#73533)
Morgan Willcock [Sat, 5 Oct 2024 17:33:51 +0000 (18:33 +0100)]
Rewrite Speedbar expansion for all descendants (bug#73533)

Rewrite 'speedbar-expand-line-descendants' to avoid getting into
an infinite loop by reaching max-lisp-eval-depth.  The new
method avoids querying and displaying information for every
movement, instead using a single message to indicate that
expansion is in progress, and so is significantly faster.  The
narrowing per item introduced by the fix for bug#35014 is
removed because it prevented expanded descendant items when the
top-level item was already expanded.
* lisp/speedbar.el (speedbar--get-line-indent-level): New
function to return the indentation level of the current line.
(speedbar-expand-line-descendants): Use simpler line motion and
no recursion.  Output messages indicating when expansion is in
progress and when it is completed.  Fix expansion of descendants
where the top-level item was already expanded.

(cherry picked from commit bcc4e64fa7aab9f44e3a7bcdf651a32ec52866c2)

3 weeks agoAdd Speedbar tests (bug#73533)
Morgan Willcock [Tue, 8 Oct 2024 16:34:20 +0000 (17:34 +0100)]
Add Speedbar tests (bug#73533)

Add Speedbar tests which test the operation of
'speedbar-expand-line-descendants'.
* test/lisp/speedbar-tests.el (speedbar-tests-container)
(eieio-speedbar-object-children, speedbar-tests-item)
(speedbar-tests--make-object, speedbar-tests--setup-strings)
(speedbar-tests--object-hierarchy, speedbar-tests--base-items)
(speedbar-tests--clean-up, speedbar-tests--initialize)
(speedbar-tests--object-name-expanded)
(speedbar-tests--object-name-function)
(speedbar-tests--objects-as-strings)
(speedbar-tests--state-test)
(speedbar-tests--expand-descendants-single)
(speedbar-tests--expand-descendants-nested)
(speedbar-tests--expand-descendants-nested-wide)
(speedbar-tests--expand-descendants-of-first)
(speedbar-tests--expand-descendants-of-first-expanded)
(speedbar-tests--expand-descendants-of-last)
(speedbar-tests--expand-descendants-of-last-expanded)
(speedbar-tests--expand-descendants-of-middle)
(speedbar-tests--expand-descendants-of-middle-expanded):
New tests, test 'speedbar-expand-line-descendants'.

(cherry picked from commit 9dcc32f10cbae9497d6b33fcc739b75c1d5e411c)

3 weeks agoFix skeleton-related errors in sgml-mode.el
Eli Zaretskii [Sat, 19 Oct 2024 06:40:53 +0000 (09:40 +0300)]
Fix skeleton-related errors in sgml-mode.el

* lisp/textmodes/sgml-mode.el (sgml-mode-facemenu-add-face-function)
(sgml-attributes): Require 'skeleton before using its symbols.
(Bug#53710)

(cherry picked from commit b730c4acfcff20047a5c574fbf36c5ef1271b902)

3 weeks agoDon't autoload erc-modules
F. Jason Park [Tue, 15 Oct 2024 02:32:16 +0000 (19:32 -0700)]
Don't autoload erc-modules

* doc/misc/erc.texi (Modules): Recommend using `describe-variable'
instead of `customize-option' because the latter needs the symbol to be
loaded.
* lisp/erc/erc.el (erc-modules): Remove autoload cookie because it
caused customizations for this option to load the main library.  This
reverts the thrust of bb894845 "Teach customize-option about
erc-modules", which was added in ERC 5.6 and Emacs 30.  The motivation
for the original offending change was to allow new users to run M-x
customize-option RET erc-modules RET immediately after startup instead
of M-x customize-group RET, followed by an I-search.  (Bug#73812)

(cherry picked from commit 1854f2751e3f73e1e5f12f6de993b6357de1766b)

3 weeks agoMove experimental module querypoll to erc-notify
F. Jason Park [Mon, 14 Oct 2024 05:45:05 +0000 (22:45 -0700)]
Move experimental module querypoll to erc-notify

* etc/ERC-NEWS: Announce migration of misplaced `querypoll' module from
erc-goodies.el to erc-notify.el.
* lisp/erc/erc-goodies.el: Move all definitions associated with
experimental module `querypoll' to erc-notify.
* lisp/erc/erc-notify.el (erc--querypoll-ring)
(erc--querypoll-timer, erc-querypoll-exclude-regexp)
(erc-querypoll-mode, erc-querypoll-enable, erc-querypoll-disable)
(erc--queries-current-p, erc-querypoll-period-params)
(erc--querypoll-compute-period, erc--querypoll-target-in-chan-p)
(erc--querypoll-get-length, erc--querypoll-get-next)
(erc--querypoll-subscribe, erc--querypoll-on-352)
(erc--querypoll-send): Move here from erc-goodies.
* test/lisp/erc/erc-goodies-tests.el (erc--querypoll-compute-period)
(erc--querypoll-target-in-chan-p, erc--querypoll-get-length)
(erc--querypoll-get-next): Move to new file erc-notify-tests.el.
* test/lisp/erc/erc-notify-tests.el: New file.  The `querypoll' module
was first introduced as part of bug#70928 in ERC 5.6.

(cherry picked from commit be3318baddbcb3ff607c784a14c1f21a70e392de)

3 weeks agoFix trailing args bug in erc-d-i--parse-message
F. Jason Park [Sat, 12 Oct 2024 21:33:25 +0000 (14:33 -0700)]
Fix trailing args bug in erc-d-i--parse-message

* test/lisp/erc/resources/erc-d/erc-d-i.el: Require `subr-x'.
(erc-d-i--parse-message): Populate `contents' slot when lone trailing
arg lacks a preceding colon.
* test/lisp/erc/resources/erc-d/erc-d-tests.el (erc-d-i--parse-message):
Fix expected result.
(erc-d-i--parse-message/privmsg): New test.

(cherry picked from commit a5b2de8b54c3a2d7dcb84f7697e18b2257959dfc)

3 weeks ago; Undo erroneous change in ERC's sample configuration
F. Jason Park [Sat, 12 Oct 2024 01:12:16 +0000 (18:12 -0700)]
; Undo erroneous change in ERC's sample configuration

* doc/misc/erc.texi (Sample Configuration): Remove `erc-modules' from
the `:custom' section of the `use-package' declaration for feature `erc'
because its presence there depends on `:defer' being non-nil, and this
configuration is supposed to be `:defer' agnostic.  This reverts part of
3f1ce47f "; Add face customization to ERC's sample config".
* etc/ERC-NEWS: Mention `erc-modules' no longer being autoloaded.
* lisp/erc/erc-match.el (erc-text-matched-hooks): Explain expected
format of non-NUH matches.
* test/lisp/erc/erc-match-tests.el (test/lisp/erc/erc-match-tests.el):
Inhibit messages when running non-interactively.

(cherry picked from commit b00f400d1d3f954e460ea979f07f38f6bb31630e)

3 weeks agoFix the regression in dired-backup-diff's diff-goto-source behavior
Dmitry Gutov [Sat, 19 Oct 2024 01:25:52 +0000 (02:25 +0100)]
Fix the regression in dired-backup-diff's diff-goto-source behavior

* lisp/vc/diff-mode.el (diff-find-source-location): Undo part of
the previous change, so that 'reverse' does not affect whether the
"other file" is used (bug#62731).
(diff-apply-hunk): Make that choice here.

(cherry picked from commit 1374f20491bbf0c37760cdb84f6020f80fe4eadd)

3 weeks agoFix naming of buffers for tags ending in Y in 'mpc'
john muhl [Tue, 8 Oct 2024 17:24:27 +0000 (12:24 -0500)]
Fix naming of buffers for tags ending in Y in 'mpc'

* lisp/mpc.el (mpc-tagbrowser-buf): Use 'mpc-tagbrowser-tag-name'
to ensure buffers corresponding to tags that end in Y are
correctly pluralized; e.g. the tag "Directory" should create a
buffer named "*MPC Directories*" not "*MPC Directorys".

(cherry picked from commit 60e58be091bf075a03ac431444aa9c9b5832bb19)

3 weeks ago; Skip commit a815becb63b48c472ee0b405c00db6a188ad6ddc
Eshel Yaron [Tue, 22 Oct 2024 18:54:38 +0000 (20:54 +0200)]
; Skip commit a815becb63b48c472ee0b405c00db6a188ad6ddc

3 weeks ago(symbol-file): Fix `C-h v pcase` where `cl-struct` lacks file info
Stefan Monnier [Fri, 18 Oct 2024 18:51:13 +0000 (14:51 -0400)]
(symbol-file): Fix `C-h v pcase` where `cl-struct` lacks file info

* lisp/subr.el (symbol-file): Return an actual (and absolute) file name
for the autoload case, as is done for other cases.

(cherry picked from commit 0886ef01a8d7144771b5834c3ef6c3d44666ea76)

3 weeks ago(help-fns-short-filename): Fix bug#73766
Stefan Monnier [Fri, 18 Oct 2024 18:48:28 +0000 (14:48 -0400)]
(help-fns-short-filename): Fix bug#73766

* lisp/help-fns.el (help-fns--radix-trees): New var.
(help-fns--filename, help-fns--radix-tree): New functions.
(help-fns-short-filename): Use them.

(cherry picked from commit e807d62cdd12b8086d360114c10085f0c0cf4116)

3 weeks ago* admin/notes/git-workflow: Use emacs-30 in examples.
Michael Albinus [Fri, 18 Oct 2024 16:33:48 +0000 (18:33 +0200)]
* admin/notes/git-workflow: Use emacs-30 in examples.

(cherry picked from commit c437d7110b388a97ff6b67b2bc3138d05fbe3576)

3 weeks ago; Skip commit 7dbbd58d6c9cafde2136b83ff149aa608203e207
Eshel Yaron [Tue, 22 Oct 2024 18:53:40 +0000 (20:53 +0200)]
; Skip commit 7dbbd58d6c9cafde2136b83ff149aa608203e207

3 weeks ago; Fix last documentation change
Eli Zaretskii [Fri, 18 Oct 2024 12:46:17 +0000 (15:46 +0300)]
; Fix last documentation change

* doc/misc/efaq.texi (Colors on a TTY):
* doc/lispref/frames.texi (Font and Color Parameters):
* doc/emacs/cmdargs.texi (Colors X): More accurate documentation
of TTY color modes and 'tty-color-mode' frame parameter.
(Bug#73813)

(cherry picked from commit 19049efd30f5476baa4b69c4b79af15674c2650b)

3 weeks agoExplain tty-color-mode frame parameter more.
Robert Pluim [Fri, 18 Oct 2024 09:22:52 +0000 (11:22 +0200)]
Explain tty-color-mode frame parameter more.

* doc/emacs/cmdargs.texi (Colors X): Explain that tty color
support is dynamic.
* doc/lispref/frames.texi (Font and Color Parameters): Explain
that 'tty-color-mode' can be changed on the fly.
* doc/misc/efaq.texi (Colors on a TTY): Explain how to disable
'tty-color-mode', either at startup or dynamically.

(cherry picked from commit 2c640e63a8a6ea9f2fbbb55ff44d7a8a0ec0f4b4)

3 weeks agoReplace my recent change to vc-start-logentry
Sean Whitton [Fri, 18 Oct 2024 09:08:53 +0000 (17:08 +0800)]
Replace my recent change to vc-start-logentry

* lisp/vc/vc-dispatcher.el (vc-start-logentry): Restore previous
logic for determining the parent buffer from before my recent
change to this function.  If the attempt to determine the parent
buffer fails, signal an error immediately.
(vc-dispatcher-browsing): Consider derived modes of
log-view-mode, too, as indicating that we are in a directory
browser.

(cherry picked from commit 5c59ab56e67d1880bdec98a4319d6b4be45acf9b)

3 weeks agoMake djvused emit UTF-8 encoded text
Visuwesh [Thu, 17 Oct 2024 04:10:34 +0000 (09:40 +0530)]
Make djvused emit UTF-8 encoded text

* lisp/doc-view.el (doc-view--djvu-outline): Pass -u to djvused
to make it emit UTF-8 encoded text rather than using octal
escapes for non-ASCII string.  (bug#73846)

(cherry picked from commit 5f22c090b1ae87b516b132b36a5908a5e18c2d11)

3 weeks ago; Fix documentation of recent changes in mpc.el
Eli Zaretskii [Fri, 18 Oct 2024 05:52:02 +0000 (08:52 +0300)]
; Fix documentation of recent changes in mpc.el

* etc/NEWS: Fix entry for 'mpc-notifications'.

* lisp/mpc.el (mpc-status-callbacks, mpc-format)
(mpc-cover-image-find, mpc-cover-image-p, mpc-notifications)
(mpc-notifications-title, mpc-notifications-body): Doc fixes.

(cherry picked from commit 09e586b38352e1661ef96a47b89d835f0ff30bd2)

3 weeks ago; Skip commit d6ea735af8ed5e74f1cbc6d3e8285c6c7700239e
Eshel Yaron [Tue, 22 Oct 2024 18:51:20 +0000 (20:51 +0200)]
; Skip commit d6ea735af8ed5e74f1cbc6d3e8285c6c7700239e

3 weeks ago; Mark interactive Eshell output as such after inserting into the buffer
Jim Porter [Thu, 17 Oct 2024 21:30:31 +0000 (14:30 -0700)]
; Mark interactive Eshell output as such after inserting into the buffer

This avoids adding the "output" text properties to strings that may live
past the call to 'eshell-interactive-filter'.

* lisp/eshell/esh-mode.el (eshell-interactive-output-filter): New
function...
(eshell-interactive-print): ... call it.
(eshell-interactive-filter): Update docstring.

* lisp/eshell/esh-proc.el (eshell-interactive-process-filter)
(eshell-sentinel): Call 'eshell-interactive-output-filter'.

(cherry picked from commit 83e3ed651dca46214855552aa062cfbde019b04a)

3 weeks ago; * src/doc.c (Ftext_quoting_style): Make doc string agree with code.
Mattias Engdegård [Thu, 17 Oct 2024 12:06:20 +0000 (14:06 +0200)]
; * src/doc.c (Ftext_quoting_style): Make doc string agree with code.

(cherry picked from commit e5d600006e2b283923044d2c139b29dd69f5ac30)

3 weeks ago(track-changes--after): Fix problem found in bug#73041
Stefan Monnier [Thu, 17 Oct 2024 15:39:19 +0000 (11:39 -0400)]
(track-changes--after): Fix problem found in bug#73041

When calling `track-changes--before` (e.g. because of a missing
b-f-c or for some other reason), it sets `track-changes--before-end`
to the right value so we shouldn't increment it right after.
Also, we should update `track-changes--buffer-size` before
calling `track-changes--before` so it doesn't risk signaling
a spurious inconsistency.

* lisp/emacs-lisp/track-changes.el (track-changes--after):
Update `track-changes--buffer-size` earlier, and don't increment
`track-changes--before-end` when we call `track-changes--before`.

(cherry picked from commit 90c6880a922029ba6e57adb2afe00a6fa57ef7fe)