]> git.eshelyaron.com Git - emacs.git/log
emacs.git
5 years agoAdded correction in the texinfo manual.
Jimmy Aguilar Mena [Wed, 3 Apr 2019 10:05:01 +0000 (12:05 +0200)]
Added correction in the texinfo manual.

*doc/emacs/text.texi: Added a reference to the
display-fill-column-indicator section.

5 years agoAdded fill-column-indicator manual documentation
Jimmy Aguilar Mena [Tue, 2 Apr 2019 20:52:41 +0000 (22:52 +0200)]
Added fill-column-indicator manual documentation

*etc/NEWS: reduced the comments about fill-column-indicator
*doc/emacs/display.texi: Added documentation for fill-column-indicator
 in this section in the manual

5 years agoFixed fill-column-indicator for continuation lines
Jimmy Aguilar Mena [Tue, 2 Apr 2019 14:17:41 +0000 (16:17 +0200)]
Fixed fill-column-indicator for continuation lines

*src/xdisp.c: Grouped the test conditions for
display-fill-column-indicator mode in a macro to simplify future
modifications.

5 years agoDisplay-fill-column-indicator NEWS info.
Jimmy Aguilar Mena [Mon, 18 Mar 2019 23:03:12 +0000 (00:03 +0100)]
Display-fill-column-indicator NEWS info.

*etc/NEWS: Added information about the fill-column-indicator mode.
*lisp/faces.el: Added a face for the display fill column indicator.

5 years agoStart display-fill-column-indicator-mode.
Jimmy Aguilar Mena [Tue, 12 Mar 2019 19:06:28 +0000 (20:06 +0100)]
Start display-fill-column-indicator-mode.

5 years agoDescribe, how to adapt shell command output width in Tramp
Michael Albinus [Sun, 5 May 2019 14:20:14 +0000 (16:20 +0200)]
Describe, how to adapt shell command output width in Tramp

* doc/misc/tramp.texi (Quick Start Guide, GVFS based methods):
Fix @cindex.
(Remote processes): Add some @vindex.  Describe shell command
output width.

5 years agoAvoid compiler warning in print.c
Eli Zaretskii [Sun, 5 May 2019 14:17:24 +0000 (17:17 +0300)]
Avoid compiler warning in print.c

* src/print.c (print_vectorlike): Don't use %hh, as that is
not portable enough; we don't yet assume a C99-compliant
library.

5 years agoAvoid crashes in read_integer
Eli Zaretskii [Sun, 5 May 2019 14:06:01 +0000 (17:06 +0300)]
Avoid crashes in read_integer

* src/lread.c (read_integer): Always allocate a buffer, since
we need to use it even when the radix is invalid.  (Bug#35576)

5 years ago* lisp/files.el (hack-local-variables): Don't burp when files-x isn't loaded
Stefan Monnier [Sun, 5 May 2019 12:57:04 +0000 (08:57 -0400)]
* lisp/files.el (hack-local-variables): Don't burp when files-x isn't loaded

5 years ago; SOme changes in filenotify-tests.el for EMBA
Michael Albinus [Sun, 5 May 2019 11:34:26 +0000 (13:34 +0200)]
; SOme changes in filenotify-tests.el for EMBA

* test/lisp/filenotify-tests.el (file-notify-test03-events)
(file-notify-test05-file-validity)
(file-notify-test09-watched-file-in-watched-dir): Adapt for EMBA.

5 years agoAdapt tests for recent file-notification changes in Tramp
Michael Albinus [Sun, 5 May 2019 10:20:44 +0000 (12:20 +0200)]
Adapt tests for recent file-notification changes in Tramp

* lisp/net/tramp.el (tramp-file-notify-process-sentinel):
Pacify byte compiler.

* test/lisp/autorevert-tests.el
(auto-revert-test02-auto-revert-deleted-file):
* test/lisp/filenotify-tests.el (file-notify-test03-events)
(file-notify-test05-file-validity)
(file-notify-test09-watched-file-in-watched-dir): Adapt for remote
files.

5 years agoReorganise (auto-)revert nodes in the manual
Mattias Engdegård [Tue, 30 Apr 2019 20:35:56 +0000 (22:35 +0200)]
Reorganise (auto-)revert nodes in the manual

Put all information about auto-revert into a section of its own, and
organise the text in a more logical way.  Previously it was mainly
described in the section about reverting (bug#35418).

* doc/emacs/files.texi (Files): Adjust menu.
(Reverting, Auto Revert, Autorevert): Add node `Auto Revert' and move
text on that topic from `Reverting', rearranged.  Turn the old
`Autorevert' node into a subsection under `Auto Revert'.
* doc/emacs/arevert-xtra.texi (Autorevert): Rename and turn into
subsubsection.
* doc/emacs/buffers.texi (Several Buffers): Adjust references.
* doc/emacs/emacs.texi (Top): Adjust menu.
* doc/emacs/emacs-xtra.texi (Top): Adjust menu.
(Non-File Buffers): Add node and section lines.

5 years agoAvoid suppressing -Wcast-function-type warning.
Philipp Stephani [Sat, 4 May 2019 23:56:15 +0000 (01:56 +0200)]
Avoid suppressing -Wcast-function-type warning.

GCC special-cases the type ‘void (*)(void)’ to not emit warnings when
cast, see
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wcast-function-type.
Make use of this to remove a warning suppression.

* src/dynlib.h: Use void (*)(void) as generic function pointer type.

* src/emacs-module.c: Remove warning suppression.

5 years agoFix compilation of test module.
Philipp Stephani [Sat, 4 May 2019 23:30:23 +0000 (01:30 +0200)]
Fix compilation of test module.

Because all other objects are compiled without -fPIC, we can’t use
them when linking the test module.  Instead, use the source files
directly.

* test/Makefile.in (HYBRID_MALLOC, LIBEGNU_ARCHIVE): Remove.
($(test_module)): Use source files instead of objects and archives.

5 years agoUse extract_time in test module.
Philipp Stephani [Sat, 4 May 2019 23:23:44 +0000 (01:23 +0200)]
Use extract_time in test module.

* test/data/emacs-module/mod-test.c (Fmod_test_sleep_until): Use
extract_time for time argument.
(signal_wrong_type_argument): Remove unused function.

* test/src/emacs-module-tests.el (mod-test-sleep-until): Remove
unnecessary ‘float-time’.

5 years ago* test/Makefile.in (src/emacs-module-tests.elc): Require test module
Philipp Stephani [Sat, 4 May 2019 22:27:19 +0000 (00:27 +0200)]
* test/Makefile.in (src/emacs-module-tests.elc): Require test module

5 years agoRefactoring: Factor out a function to set an mpz_t from a Lisp int.
Philipp Stephani [Sat, 4 May 2019 21:31:40 +0000 (23:31 +0200)]
Refactoring: Factor out a function to set an mpz_t from a Lisp int.

* src/bignum.h (mpz_set_integer): New function.

* src/emacs-module.c (module_make_big_integer): Use it.

5 years agoAvoid undefined behavior when printing function pointers.
Philipp Stephani [Sat, 4 May 2019 20:59:46 +0000 (22:59 +0200)]
Avoid undefined behavior when printing function pointers.

* src/print.c (print_vectorlike): Don’t pass a function pointer to
‘snprintf’, as that is undefined behavior.  Instead, print the
individual bytes making up the function pointer.

5 years agoNotify broken file notification from Tramp
Michael Albinus [Sat, 4 May 2019 20:29:27 +0000 (22:29 +0200)]
Notify broken file notification from Tramp

* lisp/net/tramp.el (tramp-file-notify-process-sentinel): New defun.

* lisp/net/tramp-gvfs.el (tramp-gvfs-handle-file-notify-add-watch):
* lisp/net/tramp-sh.el (tramp-sh-handle-file-notify-add-watch):
Set process sentinel.

5 years agoPort new fingerprinting scheme to clang + LTO
Paul Eggert [Sat, 4 May 2019 20:15:29 +0000 (13:15 -0700)]
Port new fingerprinting scheme to clang + LTO

* lib-src/make-fingerprint.c (main): Don't consider multiple
instances of the fingerprint to be an error, as this can
happen with clang and -flto.  Instead, replace all instances
of the fingerprint.  There is a tiny chance that this will
silently corrupt the Emacs executable.

This patch suggests that we should go back to fingerprinting
the inputs to the linker instead of its output, as the new
fingerprinting scheme is unnecessarily complicated and this
complexity reduces reliability. The old scheme (i.e., before
commit 2019-05-14T23:31:24Z!eggert@cs.ucla.edu) was simpler
and more portable and good enough, and it's looking like it
would be less trouble in practice than the new scheme.

5 years agoAvoid slow overlay ansi coloring in eshell (Bug#29854)
Noam Postavsky [Sat, 4 May 2019 18:47:29 +0000 (14:47 -0400)]
Avoid slow overlay ansi coloring in eshell (Bug#29854)

* lisp/ansi-color.el (ansi-color-apply-on-region): Reset temporary
markers after finishing with them.
(ansi-color-apply-text-property-face): New function.
* lisp/eshell/esh-mode.el (eshell-handle-ansi-color):
* lisp/man.el (Man-fontify-manpage): Use it as the
`ansi-color-apply-face-function' while calling
`ansi-color-apply-on-region'.  Use `font-lock-face' to propertize
instead of `face'.

5 years agoFix bytecode optimization typo
Paul Eggert [Sat, 4 May 2019 17:16:46 +0000 (10:16 -0700)]
Fix bytecode optimization typo

Problem reported by Simon Frankau (Bug#35562).
* src/bytecode.c (exec_byte_code): Fix typo when optimizing varset.

5 years agoFix Bug#35506
John Shahid [Sat, 4 May 2019 16:25:51 +0000 (18:25 +0200)]
Fix Bug#35506

* lisp/net/tramp.el (tramp-interrupt-process): Kill the entire
process group.  (Bug#35506)

5 years agoMinor fix in .gdbinit
Eli Zaretskii [Sat, 4 May 2019 16:19:58 +0000 (19:19 +0300)]
Minor fix in .gdbinit

* src/.gdbinit (xprintsym): Don't attempt to print the
symbol's name if it is not yet set.  This happens with
built-in symbols at the beginning of 'main'.

5 years ago; * src/minibuf.c (Fread_buffer): Doc fix. (Bug#35361)
Eli Zaretskii [Sat, 4 May 2019 09:47:03 +0000 (12:47 +0300)]
; * src/minibuf.c (Fread_buffer): Doc fix.  (Bug#35361)

5 years ago; * src/xfaces.c (merge_face_ref): Improve commentary.
Eli Zaretskii [Sat, 4 May 2019 06:52:11 +0000 (09:52 +0300)]
; * src/xfaces.c (merge_face_ref): Improve commentary.

5 years agoSkip tests if test subdir is missing
Paul Eggert [Fri, 3 May 2019 21:19:26 +0000 (14:19 -0700)]
Skip tests if test subdir is missing

Problem reported by Jeffrey Walton in:
https://lists.gnu.org/r/emacs-devel/2019-05/msg00041.html
* Makefile.in (CHECK_TARGETS): New macro; use it
to simplify 'check' and similar rules.
($(CHECK_TARGETS)): If tests are missing, do not fail
after issuing a diagnostic.  Just skip the tests.

5 years agoModernize INSTALL a bit
Paul Eggert [Fri, 3 May 2019 20:58:09 +0000 (13:58 -0700)]
Modernize INSTALL a bit

* INSTALL: Omit filesystem space estimates.  These estimates
were (1) wrong and (2) no longer important nowadays, as people
have plenty of space.  Instead, start with how to get and
unpack an Emacs tarball.  Don’t say "disk" as it’s often not
disk nowadays.  Update URLs.

5 years agoSimplify use of NDEBUG in etags.c
Paul Eggert [Fri, 3 May 2019 19:38:28 +0000 (12:38 -0700)]
Simplify use of NDEBUG in etags.c

* lib-src/etags.c [!DEBUG]: Do not define NDEBUG,
as that’s conf_post.h’s job now.
[NDEBUG]: Do not redefine ‘assert’, as that works around
ancient bugs (e.g., sunos4 pcc) that don’t matter any more,
as can be seen that other Emacs source files that successfully
use assert.h without this workaround.

5 years agoPacify librsvg 2.45.1 and later
Paul Eggert [Fri, 3 May 2019 19:16:33 +0000 (12:16 -0700)]
Pacify librsvg 2.45.1 and later

* src/image.c (svg_load_image): Pacify librsvg 2.45.1 and later,
and add a FIXME comment about the deprecated librsvg functions.

5 years agoSimplify xd_signature to pacify GCC 9
Paul Eggert [Fri, 3 May 2019 19:14:38 +0000 (12:14 -0700)]
Simplify xd_signature to pacify GCC 9

* src/dbusbind.c (xd_signature): Use simpler way to set up
the subsignature.  This also pacifies GCC 9 on Fedora 30 x86-64.

5 years agoUpdate from Gnulib
Paul Eggert [Fri, 3 May 2019 19:12:43 +0000 (12:12 -0700)]
Update from Gnulib

This incorporates:
2019-05-03 Port manywarnings to GCC 9
* m4/manywarnings.m4: Copy from Gnulib.

5 years agoAdd tests for remote files in auto-revert-tests
Michael Albinus [Fri, 3 May 2019 15:18:13 +0000 (17:18 +0200)]
Add tests for remote files in auto-revert-tests

* lisp/autorevert.el (auto-revert-debug): New defvar.
(auto-revert-notify-handler): Write traces.

* lisp/filenotify.el (file-notify-debug): New defvar.
(file-notify-handle-event, file-notify-callback): Write traces.

* lisp/net/tramp-sh.el (tramp-sh-handle-vc-registered):
Handle nil `vc-handled-backends'.

* test/lisp/autorevert-tests.el
(auto-revert-test-remote-temporary-file-directory): New defconst.
Handle also $REMOTE_FILE_NOTIFY_LIBRARY.
(auto-revert--test-enabled-remote-checked): New defvar.
(auto-revert--test-enabled-remote): New defun.
(auto-revert--wait-for-revert): Rewrite without timeout.
(auto-revert--deftest-remote): New defmacro.
(auto-revert-test01-auto-revert-several-files):
(auto-revert-test02-auto-revert-deleted-file): Adapt for remote files.
(auto-revert-test02-auto-revert-deleted-file):
Use `auto-revert-debug' for debug messages.
(auto-revert-test00-auto-revert-mode-remote)
(auto-revert-test01-auto-revert-several-files-mode-remote)
(auto-revert-test02-auto-revert-deleted-file-mode-remote)
(auto-revert-test03-auto-revert-tail-mode-mode-remote)
(auto-revert-test04-auto-revert-mode-dired-mode-remote): New tests.

* test/lisp/filenotify-tests.el (file-notify--test-event-handler):
Use `file-notify-debug' for debug messages.

5 years agoFix Gnus inline attachment decoding (bug#35507)
Basil L. Contovounesios [Thu, 2 May 2019 21:06:02 +0000 (22:06 +0100)]
Fix Gnus inline attachment decoding (bug#35507)

Proposed by Andy Moreton <andrewjmoreton@gmail.com>
and Noam Postavsky <npostavs@gmail.com>.
* lisp/gnus/mm-view.el (mm-display-inline-fontify): Always decode
handle text, falling back on 'undecided' coding system.

5 years ago* lisp/server.el: Cosmetic changes
Stefan Monnier [Fri, 3 May 2019 13:49:38 +0000 (09:49 -0400)]
* lisp/server.el: Cosmetic changes

Remove redundant :group args.
(server-temp-file-regexp): Fix ^$ to  \`\'.

5 years agoImprove documentation of 'isearch-regexp-function'
Eli Zaretskii [Fri, 3 May 2019 09:22:55 +0000 (12:22 +0300)]
Improve documentation of 'isearch-regexp-function'

* lisp/isearch.el (isearch-regexp-function): Doc fix.
(Bug#35498)

5 years ago; Fix declaration in tramp-compat.el
Michael Albinus [Fri, 3 May 2019 08:05:15 +0000 (10:05 +0200)]
; Fix declaration in tramp-compat.el

5 years agoRefactor update_window_begin and update_window_end hooks
Alexander Gramiak [Sat, 27 Apr 2019 21:00:13 +0000 (15:00 -0600)]
Refactor update_window_begin and update_window_end hooks

Bug#35464.

* src/dispnew.c (gui_update_window_begin, gui_update_window_end): New
procedures implementing common functionality.

* src/nsterm.m: (ns_update_window_begin, ns_update_window_end):
* src/xterm.c: (x_update_window_begin, x_update_window_end): Remove in
favor of only using the new generic versions.

* src/w32term.c: (w32_update_window_begin, w32_update_window_end):
Remove duplicated and unused code.

5 years agoxref--find-ignores-arguments: Return "" if IGNORES is nil
Dmitry Gutov [Thu, 2 May 2019 23:48:44 +0000 (02:48 +0300)]
xref--find-ignores-arguments: Return "" if IGNORES is nil

5 years agoAllow project-find-regexp'ing inside an ignored dir
Dmitry Gutov [Thu, 2 May 2019 22:52:05 +0000 (01:52 +0300)]
Allow project-find-regexp'ing inside an ignored dir

* lisp/progmodes/project.el (project-find-regexp): Don't pass
project's ignores to project--files-in-directory.  The FILES glob
should be enough, and we don't want to prohibit searching inside
ignored directories this way (it can be counter-intuitive).

5 years ago(xref--mouse-2): Fix not to jump to the next line
Dmitry Gutov [Thu, 2 May 2019 22:47:15 +0000 (01:47 +0300)]
(xref--mouse-2): Fix not to jump to the next line

* lisp/progmodes/xref.el (xref--mouse-2): Fix not to jump to the
next line.

5 years agoFix an "empty identifier" problem
Dmitry Gutov [Thu, 2 May 2019 22:29:59 +0000 (01:29 +0300)]
Fix an "empty identifier" problem

* lisp/progmodes/xref.el (xref--read-identifier): Abort on empty
input if there is no default
(https://lists.gnu.org/archive/html/help-gnu-emacs/2019-05/msg00012.html).

5 years agoFix fontification of first item in CC Mode macro without parentheses
Alan Mackenzie [Thu, 2 May 2019 20:53:47 +0000 (20:53 +0000)]
Fix fontification of first item in CC Mode macro without parentheses

* lisp/progmodes/cc-engine.el (c-find-decl-prefix-search): Handle the new
matching possibility (of a #define construct) in the new
c-decl-prefix-or-start-re.
(c-find-decl-spots): Allow the initial search for an in-macro starting point
settle on the # of #define, to facilitate the regexp matching in
c-find-decl-prefix-search.

* lisp/progmodes/cc-langs.el (c-anchored-hash-define-no-parens): New lang
const.
(c-literal-start-regexp): Correct what was always supposed to be a "generic
string" regexp element.
(c-decl-prefix-or-start-re): Enhance also to match "#define <identifier>".
(c-dposr-cpp-macro-depth): New lang variable and lang constant.

5 years ago* lisp/mail/footnote.el: Add TEXT and POINTERS together
Stefan Monnier [Thu, 2 May 2019 15:00:20 +0000 (11:00 -0400)]
* lisp/mail/footnote.el: Add TEXT and POINTERS together

Rather than adding POINTERS and TEXT separately to footnote--markers-alist,
add them together, so we don't need footnote--first-text-marker because
the TEXT part is never nil.

(footnote--insert-numbered-footnote): Return marker.
(footnote--insert-text-marker, footnote--insert-pointer-marker):
Delete functions.
(footnote--insert-markers): New function to replace them.
(footnote--insert-footnote): Adjust accordingly.
Simplify pointless `unless`.
(footnote--first-text-marker): Remove.  Replace all calls by
(cadr (car footnote--markers-alist)) or just footnote--markers-alist.

5 years agoCC Mode: Fix multiline block comments in macros.
Alan Mackenzie [Thu, 2 May 2019 14:30:29 +0000 (14:30 +0000)]
CC Mode: Fix multiline block comments in macros.

In particulr, handle multiline block comments whose newlines are not escaped.
There is an example of this in #define EXTRA_CONTEXT_FIELDS in editfns.c.

* lisp/progmodes/cc-engine.el (c-beginning-of-macro, c-end-of-macro): Enclose
the loops scanning escaped newlines with outer loops which check
heuristically for, respectively, a block comment ender and a block comment
starter on the lines we end up on.  (A rigorous syntactic check would be too
slow, here.)

* lisp/progmodes/cc-langs.el (c-last-c-comment-end-on-line-re)
(c-last-open-c-comment-start-on-line-re): New language constants/variables.

5 years ago* lisp/mail/footnote.el: Tweak markers convention
Stefan Monnier [Thu, 2 May 2019 14:27:42 +0000 (10:27 -0400)]
* lisp/mail/footnote.el: Tweak markers convention

Instead of using markers that are sometimes before and sometimes after
the [...] and using `insert-before-markers` to make sure those that are
are before stay before, always place them before, and make them
"move after"so they stay with their [...] without the need for
insert-before-markers.

(footnote--current-regexp): Add arg to match previous style.
Include the start/end "tags" in the regexp.  Adjust all callers.
(footnote--markers-alist): Change position of POINTERS.
(footnote--refresh-footnotes, footnote--renumber)
(footnote--make-hole, footnote-delete-footnote)
(footnote-back-to-message): Adjust accordingly, mostly by using
`looking-at` instead of `looking-back`.
(footnote--make-hole): Always return footnote nb to use.
(footnote-add-footnote): Simplify call accordingly.

* test/lisp/mail/footnote-tests.el: New file.

5 years agouse view-mode on score file for ease of scrolling and quitting
Sam Steingold [Thu, 2 May 2019 14:17:56 +0000 (10:17 -0400)]
use view-mode on score file for ease of scrolling and quitting

5 years agotetris-null-map: bind "q" to `quit-window`
Sam Steingold [Thu, 2 May 2019 14:17:04 +0000 (10:17 -0400)]
tetris-null-map: bind "q" to `quit-window`

5 years agoSmall code clean-up of file-notify-add-watch
Mattias Engdegård [Mon, 29 Apr 2019 14:42:04 +0000 (16:42 +0200)]
Small code clean-up of file-notify-add-watch

* lisp/filenotify.el (file-notify-add-watch):
Clearly separate backend-specific code from the rest, and simplify.
(file-notify--add-watch-inotify, file-notify--add-watch-kqueue)
(file-notify--add-watch-w32notify, file-notify--add-watch-gfilenotify):
New functions.

5 years ago* lisp/mail/footnote.el: Use dolist and hoist regexps out of loops
Stefan Monnier [Thu, 2 May 2019 13:00:53 +0000 (09:00 -0400)]
* lisp/mail/footnote.el: Use dolist and hoist regexps out of loops

(footnote--refresh-footnotes): Use pcase-dolist; compute regexp once
outside of the loops.  Use less confusing `literal` arg to `replace-match`
and specify `fixedcase` since footnote--index-to-string already chose
the proper case for us.
(footnote--renumber): Use dolist; compute regexp once
outside of the loops; shortcircuit when number is unchanged.
(footnote--text-under-cursor): Rewrite.
(footnote--make-hole): Use dolist.
(footnote-add-footnote): CSE.
(footnote-delete-footnote): Use dolist; compute regexp once
outside of the loop.
(footnote-delete-footnote): Don't renumber if there's no footnote left.
(footnote-renumber-footnotes): Use dolist.

5 years agoFix tramp-compat-file-name-quoted-p
Michael Albinus [Thu, 2 May 2019 07:51:41 +0000 (09:51 +0200)]
Fix tramp-compat-file-name-quoted-p

* lisp/net/tramp-compat.el (tramp-compat-file-local-name)
(tramp-compat-file-name-quoted-p): Declare them.
(top): Do not use `eval-and-compile'.
(tramp-compat-file-name-quoted-p): Check also func-arity of
`file-name-quoted-p'.

5 years ago* lisp/mail/footnote.el: Consolidate the two marker-alists
Stefan Monnier [Wed, 1 May 2019 21:53:39 +0000 (17:53 -0400)]
* lisp/mail/footnote.el: Consolidate the two marker-alists

Consolidate footnote-text-marker-alist and footnote-pointer-marker-alist
into a single footnote--markers-alist.

(footnote--markers-alist): New var.
(footnote-text-marker-alist, footnote-pointer-marker-alist): Delete vars.
(footnote--refresh-footnotes, footnote--text-under-cursor)
(footnote--calc-fn-alignment-column, footnote-add-footnote)
(footnote-goto-footnote, footnote-back-to-message): Adjust accordingly.
(footnote--make-hole, footnote-delete-footnote)
(footnote-renumber-footnotes): Simplify accordingly.
(footnote-cycle-style): Indicate style name in echo area.
(footnote--renumber): Take a single `alist-elem` arg instead of
`pointer-alist` and `text-alist`.
(footnote--insert-text-marker, footnote--insert-pointer-marker):
Add to footnote--markers-alist instead.
(footnote--first-text-marker): New function.
(footnote--get-area-point-min): Use it.
footnote--goto-first): New function.
(footnote--insert-footnote): Use it.
(footnote-style-number): Use defvar-local.

5 years ago* lisp/mail/footnote.el: Minor simplifications
Stefan Monnier [Wed, 1 May 2019 17:14:31 +0000 (13:14 -0400)]
* lisp/mail/footnote.el: Minor simplifications

Remove redundant :group args.
(footnote-mode-hook): Let define-minor-mode define it.
(footnote--style-p): Delete function.
(footnote--index-to-string): Inline it instead, and simplify.
(footnote-cycle-style): Use a pointer into the alist as the "index"
instead of a number.
(footnote-set-style): Use footnote-style-alist as the completion table.
Prefer `assq` over `footnote--assoc-index`.
(footnote--assoc-index): Delete function.
(footnote--renumber): Remove first (unused) argument; Adjust all callers.
(footnote--sort): Use car-less-than-car.

5 years agoRestore previous calling signature of gnus-set-info
Lars Ingebrigtsen [Wed, 1 May 2019 17:04:36 +0000 (19:04 +0200)]
Restore previous calling signature of gnus-set-info

5 years ago* lisp/emacs-lisp/edebug.el: Better handle instrumentation of `end-of-defun`
Stefan Monnier [Wed, 1 May 2019 16:45:37 +0000 (12:45 -0400)]
* lisp/emacs-lisp/edebug.el: Better handle instrumentation of `end-of-defun`

Remove redundant :group args.
(edebug-read-top-level-form): Let-bind edebug-active.
(edebug-active): Move before this new first use.

5 years ago* lisp/help.el (function-called-at-point): Use Elisp's forward-sexp-function
Stefan Monnier [Wed, 1 May 2019 16:37:48 +0000 (12:37 -0400)]
* lisp/help.el (function-called-at-point): Use Elisp's forward-sexp-function

5 years ago; * etc/NEWS: Fix position of +++ marker
Basil L. Contovounesios [Wed, 1 May 2019 13:51:37 +0000 (14:51 +0100)]
; * etc/NEWS: Fix position of +++ marker

5 years ago; Auto-commit of loaddefs files.
Glenn Morris [Wed, 1 May 2019 13:27:17 +0000 (06:27 -0700)]
; Auto-commit of loaddefs files.

5 years agoMinor region-noncontiguous-p simplification
Basil L. Contovounesios [Tue, 30 Apr 2019 23:39:54 +0000 (00:39 +0100)]
Minor region-noncontiguous-p simplification

* lisp/simple.el (region-noncontiguous-p): Don't needlessly traverse
region-bounds.

5 years ago* lisp/progmodes/cc-engine.el: Silence minor compiler warnings
Stefan Monnier [Tue, 30 Apr 2019 18:56:29 +0000 (14:56 -0400)]
* lisp/progmodes/cc-engine.el: Silence minor compiler warnings

(c-restricted-<>-arglists, c-parse-and-markup-<>-arglists):
Move declaration before first use.
(c-after-change-unmark-raw-strings): Remove unused var `found-end`.

5 years agoFix decode-time/encode-time roundtrip on macOS
Paul Eggert [Tue, 30 Apr 2019 17:45:48 +0000 (10:45 -0700)]
Fix decode-time/encode-time roundtrip on macOS

* src/timefns.c (Fencode_time): Ignore DST flag when the zone is
numeric or is a cons, as the doc string says it’s ignored in that
case, and not ignoring it causes encode-time to not invert
decode-time on some platforms (Bug#35502).
* test/src/timefns-tests.el (encode-time-dst-numeric-zone):
New test.

5 years ago* lisp/progmodes/cc-fonts.el: Silence some compiler warnings
Stefan Monnier [Tue, 30 Apr 2019 17:42:44 +0000 (13:42 -0400)]
* lisp/progmodes/cc-fonts.el: Silence some compiler warnings

(c-font-lock-declarators): Mark `id_end` and `not-top` as unused.

5 years agoUpdate from Gnulib
Paul Eggert [Tue, 30 Apr 2019 16:44:38 +0000 (09:44 -0700)]
Update from Gnulib

* build-aux/config.guess, doc/misc/texinfo.tex:
* lib/mktime-internal.h, lib/mktime.c, lib/timegm.c:
Copy from Gnulib.
* lib/gnulib.mk.in: Regenerate.

5 years ago* lisp/autorevert.el (auto-revert-avoid-polling): Fix :set form.
Mattias Engdegård [Tue, 30 Apr 2019 13:53:56 +0000 (15:53 +0200)]
* lisp/autorevert.el (auto-revert-avoid-polling): Fix :set form.

5 years agoCC Mode: in certain font lock loops, check point is not beyond limit.
Alan Mackenzie [Tue, 30 Apr 2019 13:20:22 +0000 (13:20 +0000)]
CC Mode: in certain font lock loops, check point is not beyond limit.

* /lisp/progmodes/cc-fonts.el (c-font-lock-enum-body)
(autodoc-font-lock-line-markup): As part of the `while' condition, check that
the previous iteration of the loop hasn't moved point past `limit', thus
obviating "wrong side of point" errors in re-search-forward, etc.

5 years agoDon't poll auto-revert files that use notification (bug#35418)
Mattias Engdegård [Wed, 24 Apr 2019 16:39:05 +0000 (18:39 +0200)]
Don't poll auto-revert files that use notification (bug#35418)

It is a waste to periodically poll files that use change notification
in auto-revert mode; stop doing that.  If no files need polling,
turn off the periodic execution entirely to further avoid wasting power.
Use a timer to inhibit immediate reversion for some time after a
notification, for throttling.

This change does not apply to files in global-auto-revert-mode, where
polling is still necessary.  It is disabled by default, and enabled by
setting `auto-revert-avoid-polling' to non-nil.

* lisp/autorevert.el
(toplevel): Require cl-lib.
(auto-revert-avoid-polling, auto-revert--polled-buffers)
(auto-revert--need-polling-p, auto-revert--lockout-interval)
(auto-revert--lockout-timer, auto-revert--end-lockout): New.
(global-auto-revert-mode): Keep notifiers for buffers in auto-revert mode.
(auto-revert-set-timer): Use auto-revert--need-polling-p.
(auto-revert-notify-handler): Restart polling if notification stopped.
Use new lockout timer.
(auto-revert-buffers):
Use auto-revert--polled-buffers and auto-revert--need-polling-p.
(auto-revert-buffers-counter, auto-revert-buffers-counter-lockedout):
Remove.

* etc/NEWS (Changes in Specialized Modes and Packages):
Describe the new auto-revert-avoid-polling variable.

* doc/emacs/files.texi (Reverting):
Add paragraph describing auto-revert-avoid-polling.

5 years agoRefrain from splicing anonymous faces in text properties
Stefan Monnier [Mon, 29 Apr 2019 21:29:47 +0000 (17:29 -0400)]
Refrain from splicing anonymous faces in text properties

* lisp/font-lock.el (font-lock-prepend-text-property): Distinguish
list of faces from property lists.
(font-lock-ensure-function): Remove redundant code.

5 years ago* lisp/international/mule-util.el: Avoid setq; clarify meaning of -1.
Stefan Monnier [Mon, 29 Apr 2019 20:32:52 +0000 (16:32 -0400)]
* lisp/international/mule-util.el: Avoid setq; clarify meaning of -1.

5 years agoSync latest SKK-JISYO.L
Paul Eggert [Mon, 29 Apr 2019 19:56:44 +0000 (12:56 -0700)]
Sync latest SKK-JISYO.L

Problem reported by Tsuyoshi Kitamoto (Bug#35442).
* leim/SKK-DIC/README: Update to current URL.
* leim/SKK-DIC/SKK-JISYO.L: Sync to current upstream version.

5 years agoDisable __attribute__ ((cold)) on MinGW
Paul Eggert [Mon, 29 Apr 2019 19:27:04 +0000 (12:27 -0700)]
Disable __attribute__ ((cold)) on MinGW

* src/conf_post.h (ATTRIBUTE_COLD) [__MINGW32__]:
Define to empty on this platform.

5 years agoMerge from origin/emacs-26
Glenn Morris [Mon, 29 Apr 2019 16:12:53 +0000 (09:12 -0700)]
Merge from origin/emacs-26

c26d452 (origin/emacs-26) * src/macfont.m (macfont_shape): Use conven...
140e7f8 Recommend using font-lock-face over face (Bug#35044)
7cb5364 Check if mouse_face_overlay was deleted (Bug#35273)

# Conflicts:
# src/macfont.m

5 years ago; Merge from origin/emacs-26
Glenn Morris [Mon, 29 Apr 2019 16:08:19 +0000 (09:08 -0700)]
; Merge from origin/emacs-26

The following commit was skipped:

531c74e Port to platforms where tputs is in libtinfow

5 years agoMerge from origin/emacs-26
Glenn Morris [Mon, 29 Apr 2019 16:08:19 +0000 (09:08 -0700)]
Merge from origin/emacs-26

0e8d452 ; * doc/lispref/nonascii.texi (Coding System Basics): Fix gra...
25a2ff7 ; Add missing space in custom.texi
9ec18fb * admin/admin.el (set-version): Check for increase in version...
93912ba Be more careful about indent-sexp going over eol (Bug#35286)

5 years ago; Merge from origin/emacs-26
Glenn Morris [Mon, 29 Apr 2019 16:08:18 +0000 (09:08 -0700)]
; Merge from origin/emacs-26

The following commits were skipped:

3988e93 Backport: Improve pure and side-effect-free docs
7565d2d Backport: Avoid using obsolete indent-relative-maybe

5 years agoReplace ‘/* FALLTHROUGH! */’ with ‘break;’
Paul Eggert [Mon, 29 Apr 2019 15:39:34 +0000 (08:39 -0700)]
Replace ‘/* FALLTHROUGH! */’ with ‘break;’

* src/data.c (set_internal, set_default_internal):
Replace obsolescent /* FALLTHROUGH! */ comments with ‘break;’,
as ‘FALLTHROUGH;’ is not needed here.

5 years ago* test/lisp/net/tramp-tests.el (tramp--test-timeout-handler): Instrument.
Michael Albinus [Mon, 29 Apr 2019 15:24:53 +0000 (17:24 +0200)]
* test/lisp/net/tramp-tests.el (tramp--test-timeout-handler): Instrument.

5 years agoAvoid compilation warnings in w32.c
Eli Zaretskii [Mon, 29 Apr 2019 15:18:51 +0000 (18:18 +0300)]
Avoid compilation warnings in w32.c

* src/w32.c (unsetenv, readlink): Use memcpy instead of
strncpy, to avoid a compiler warning about calculating the
bound of the copy.

5 years ago* src/macfont.m (macfont_shape): Use convenient LGLYPH_NEW.
YAMAMOTO Mitsuharu [Sun, 28 Apr 2019 22:31:45 +0000 (07:31 +0900)]
* src/macfont.m (macfont_shape): Use convenient LGLYPH_NEW.

5 years agoRecommend using font-lock-face over face (Bug#35044)
Noam Postavsky [Fri, 19 Apr 2019 04:55:14 +0000 (00:55 -0400)]
Recommend using font-lock-face over face (Bug#35044)

* doc/lispref/modes.texi (Precalculated Fontification): Explain
advantages of using font-lock-face over face.

5 years agoReplace use of obsolete string-make-unibyte
Noam Postavsky [Sun, 28 Apr 2019 20:29:44 +0000 (16:29 -0400)]
Replace use of obsolete string-make-unibyte

* lisp/image-file.el (insert-image-file): Use encode-coding-region
instead of string-make-unibyte.
* test/lisp/image-file-tests.el: New test.

5 years ago; Add test for previous change
Noam Postavsky [Sat, 20 Apr 2019 19:31:51 +0000 (15:31 -0400)]
; Add test for previous change

* test/lisp/progmodes/python-tests.el (python-indent-hanging-close-paren):
New test.

5 years agopython.el: Fix close paren indentation to match pep8 (Bug#20742)
Tommi Komulainen [Fri, 19 Jun 2015 16:53:52 +0000 (18:53 +0200)]
python.el: Fix close paren indentation to match pep8 (Bug#20742)

* lisp/progmodes/python.el (python-indent--calculate-indentation):
When opening paren is followed by newline the closing paren should
follow the current indentation.  Otherwise the closing paren should be
aligned with the opening paren.  This fixes the latter case.

Copyright-paperwork-exempt: yes

5 years agoUpdate from GMP
Paul Eggert [Sun, 28 Apr 2019 20:14:49 +0000 (13:14 -0700)]
Update from GMP

* admin/update-copyright (updatable_files):
Don’t update copyright year on files copied from GMP, so that
they’re identical to upstream.
* src/mini-gmp.c, src/mini-gmp.h: Copy from GMP development
versions as of 2019-01-01 20:15:39 UTC.

5 years agoExport major version of latest Emacs supported by emacs-module.h.
Philipp Stephani [Wed, 24 Apr 2019 08:22:18 +0000 (10:22 +0200)]
Export major version of latest Emacs supported by emacs-module.h.

This is useful if module authors want to support multiple versions of
emacs-module.h.

* configure.ac (emacs_major_version): Define substitution.

* src/emacs-module.h.in (EMACS_MAJOR_VERSION): Define macro.

* doc/lispref/internals.texi (Module Initialization): Document
EMACS_MAJOR_VERSION preprocessor macro.

* test/data/emacs-module/mod-test.c (emacs_module_init): Verify
behavior of EMACS_MAJOR_VERSION.

5 years agoFix another compilation warning.
Philipp Stephani [Sun, 28 Apr 2019 17:21:03 +0000 (19:21 +0200)]
Fix another compilation warning.

* test/src/emacs-module-tests.el (multiply-string): Remove unused
variable ‘i’.

5 years agoAlso regenerate emacs-module.h if module-env-*.h changes.
Philipp Stephani [Sun, 28 Apr 2019 17:17:41 +0000 (19:17 +0200)]
Also regenerate emacs-module.h if module-env-*.h changes.

* Makefile.in (CONFIG_STATUS_FILES_IN): Add versioned environment
header fragments.

5 years ago* src/emacs-module.c (funcall_module): Add a nontrivial assertion
Philipp Stephani [Sun, 28 Apr 2019 15:40:41 +0000 (17:40 +0200)]
* src/emacs-module.c (funcall_module): Add a nontrivial assertion

5 years agoFix a few minor compilation and Checkdoc warnings.
Philipp Stephani [Sun, 28 Apr 2019 15:15:04 +0000 (17:15 +0200)]
Fix a few minor compilation and Checkdoc warnings.

* test/src/emacs-module-tests.el: Add package name and standard
sections.
(multiply-string): Add a docstring.

5 years ago* test/src/emacs-module-tests.el: Switch to lexical binding.
Philipp Stephani [Sun, 28 Apr 2019 14:49:13 +0000 (16:49 +0200)]
* test/src/emacs-module-tests.el: Switch to lexical binding.

5 years agoFix names of functions in last commit
Eli Zaretskii [Sun, 28 Apr 2019 14:14:39 +0000 (17:14 +0300)]
Fix names of functions in last commit

* src/coding.h (build_string_from_utf8): Rename from
build_utf8_string.  All callers changed.
* src/coding.c (make_string_from_utf8): Rename from
make_utf8_string.  All callers changed.

5 years agoCheck if mouse_face_overlay was deleted (Bug#35273)
Noam Postavsky [Sat, 27 Apr 2019 19:22:11 +0000 (15:22 -0400)]
Check if mouse_face_overlay was deleted (Bug#35273)

* src/xdisp.c (note_mouse_highlight): Check if the mouse_face_overlay
actually points to a buffer, before calling
mouse_face_overlay_overlaps on it.

5 years agoRefactoring: move UTF-8 decoding functions into coding.h.
Philipp Stephani [Sun, 28 Apr 2019 10:28:27 +0000 (12:28 +0200)]
Refactoring: move UTF-8 decoding functions into coding.h.

json_make_string and json_build_string are generally useful and not
JSON-specific.  Move them to coding.[ch].

* src/coding.h (build_utf8_string): Move from json.c.

* src/coding.c (make_utf8_string): Move from json.c.

* src/json.c (json_make_string, json_build_string): Move to
coding.[ch].  Split out JSON-specific comment.
(json_parse_error, Fjson_serialize, json_to_lisp): Fix callers.

* src/emacs-module.c (module_make_function, module_make_string): Use
new functions.
(module_decode, module_decode_copy): Remove.

5 years agoPort to platforms where tputs is in libtinfow
Paul Eggert [Sat, 5 Jan 2019 17:47:14 +0000 (09:47 -0800)]
Port to platforms where tputs is in libtinfow

* configure.ac (tputs_library): Also try tinfow, ncursesw (Bug#33977).

(cherry picked from commit a3d52b3057c98bce581bc94912ef3ced6fad6f14)

5 years agoFix slow scrolling in C++ buffers with lots of template delimiters.
Alan Mackenzie [Sat, 27 Apr 2019 17:17:10 +0000 (17:17 +0000)]
Fix slow scrolling in C++ buffers with lots of template delimiters.

* lisp/progmodes/cc-engine.el (c-update-brace-stack): bind
c-parse-and-markup-<>-arglists and c-restricted-<>-arglists to t around the
call to c-forward-<>-arglist, to force the marking of template delimiters with
syntax-table text properties.

5 years agoFix -nw sessions on MS-Windows broken by a recent commit
Eli Zaretskii [Sat, 27 Apr 2019 08:34:05 +0000 (11:34 +0300)]
Fix -nw sessions on MS-Windows broken by a recent commit

* src/w32console.c: Include dispextern.h.
(initialize_w32_display): Populate defined_color_hook.

5 years agoFix MS-Windows build broken by a recent commit
Eli Zaretskii [Sat, 27 Apr 2019 07:43:05 +0000 (10:43 +0300)]
Fix MS-Windows build broken by a recent commit

* src/w32term.c (w32_new_focus_frame): Fix a typo in a recent
commit.

5 years agoFix --with-x-toolkit=no build breakage
YAMAMOTO Mitsuharu [Sat, 27 Apr 2019 06:27:36 +0000 (15:27 +0900)]
Fix --with-x-toolkit=no build breakage

* oldXMenu/Create.c (XMenuCreate): Add const modifier to variable def_val.
* oldXMenu/Create.c:
* src/frame.h: Add const modifier to return type of x_get_resource_string.
* src/frame.c (x_get_resource_string): Exempt x_get_string_resource from
renaming generic x_* identifiers.

5 years agoUpdate multicolor font support status
YAMAMOTO Mitsuharu [Sat, 27 Apr 2019 05:43:19 +0000 (14:43 +0900)]
Update multicolor font support status

* etc/NEWS: Mention multicolor font support on Cairo and NS.
* src/macfont.m (macfont_list): Re-enable color bitmap fonts.

5 years ago* src/frame.c (x_get_resource_string): Fix typo
Alexander Gramiak [Sat, 27 Apr 2019 03:49:52 +0000 (21:49 -0600)]
* src/frame.c (x_get_resource_string): Fix typo

5 years ago* src/xdisp.c: Only check FRAME_RIF for graphical frames
Alexander Gramiak [Sat, 27 Apr 2019 03:32:06 +0000 (21:32 -0600)]
* src/xdisp.c: Only check FRAME_RIF for graphical frames