Lars Ingebrigtsen [Tue, 17 Apr 2018 18:34:12 +0000 (20:34 +0200)]
Tweak shr window width computation
* lisp/net/shr.el (shr-insert-document): The computation of the
window width is apparently one pixel too wide for the shr line
folding algorithm (bug#31196).
Lars Ingebrigtsen [Tue, 17 Apr 2018 18:09:28 +0000 (20:09 +0200)]
(gnus-summary-select-article-buffer): Further point placing tweak
* lisp/gnus/gnus-sum.el (gnus-summary-select-article-buffer):
Further tweak for the previous point-placing tweak.
Lars Ingebrigtsen [Tue, 17 Apr 2018 18:02:26 +0000 (20:02 +0200)]
Tweak point placement in gnus-summary-select-article-buffer
* lisp/gnus/gnus-sum.el (gnus-summary-select-article-buffer):
Ensure that point is where it's supposed to be after switching to
the article buffer.
Lars Ingebrigtsen [Tue, 17 Apr 2018 17:34:40 +0000 (19:34 +0200)]
Make the `c' command work in a single-article Gnus view
* lisp/gnus/gnus-art.el (gnus-article-read-summary-keys): Make `c'
work from the article buffer (bug#31195) when no summary buffer is
shown.
Lars Ingebrigtsen [Tue, 17 Apr 2018 17:21:42 +0000 (19:21 +0200)]
Place point consistently in the Gnus group buffer on exit
* lisp/gnus/gnus-sum.el (gnus-summary-exit): Place point correctly
when exiting with `q' (and the like) from the article buffer when
only the article buffer is displayed (bug#31195). This is
apparently yet another fall-out from the "preserve-visible-point-
in-windows" patches of yesteryear...
Lars Ingebrigtsen [Tue, 17 Apr 2018 16:53:09 +0000 (18:53 +0200)]
Reimplement `shr-next-link' and `shr-previous-link'
* lisp/net/shr.el (shr-next-link): Use
`text-property-search-forward'.
(shr-previous-link): Use `text-property-search-backward'.
Lars Ingebrigtsen [Tue, 17 Apr 2018 16:51:41 +0000 (18:51 +0200)]
Add `text-property-search-forward' and `-backward'
* doc/lispref/text.texi (Property Search): Document
`text-property-search-forward' and `text-property-search-backward'.
* lisp/emacs-lisp/text-property-search.el: New file.
Tino Calancha [Tue, 17 Apr 2018 13:20:28 +0000 (22:20 +0900)]
* lisp/textmodes/artist.el (artist-mode): Ensure we have a font
Katsumi Yamaoka [Tue, 17 Apr 2018 06:22:17 +0000 (06:22 +0000)]
* lisp/mail/sendmail.el (mail-sendmail-undelimit-header): Work for
the case where the mail header separator has already been deleted.
Lars Ingebrigtsen [Tue, 17 Apr 2018 00:11:02 +0000 (02:11 +0200)]
(gnus-group-goto-group): Return correct value after previous patch
* lisp/gnus/gnus-group.el (gnus-group-goto-group): Return the
correct value after the previous patch.
Lars Ingebrigtsen [Mon, 16 Apr 2018 21:10:03 +0000 (23:10 +0200)]
Fix inconsistent point movement in the Gnus group buffer
* lisp/gnus/gnus-group.el (gnus-group-goto-group): If we can't
find the group we're looking for, then don't move point at all
(bug#23021).
Lars Ingebrigtsen [Mon, 16 Apr 2018 19:20:08 +0000 (21:20 +0200)]
(artist-mode): Warn about proportional fonts
* lisp/textmodes/artist.el (artist-mode): Warn about proportional
fonts (bug#24175).
Lars Ingebrigtsen [Mon, 16 Apr 2018 11:58:39 +0000 (13:58 +0200)]
Make mail-sendmail-undelimit-header actually remove the delimiter
* lisp/mail/sendmail.el (mail-sendmail-undelimit-header): Actually
remove the mail header separator (bug#17488). In all the cases
where this is called, the separator will probably already have
been removed, so the only thing this does is place point at the
end of the headers.
Lars Ingebrigtsen [Mon, 16 Apr 2018 11:47:53 +0000 (13:47 +0200)]
(semantic-symref-results-mode-map): Fix typo in previous check-in
* lisp/cedet/semantic/symref/list.el
(semantic-symref-results-mode-map): Fix typo in previous check-in.
Philipp Stephani [Mon, 16 Apr 2018 06:45:27 +0000 (23:45 -0700)]
Avoid undefined behavior in 'defvar' (Bug#31072)
* src/eval.c (Fdefvar): Check that first argument is a symbol.
* test/src/eval-tests.el (defvar/bug31072): New unit test.
Stefan Monnier [Thu, 15 Mar 2018 00:06:47 +0000 (20:06 -0400)]
EUDC: Enable lexical binding and do some cleanups
* lisp/net/eudc.el: Enable lexical binding.
(cl-lib): Always require cl-lib, not only when byte compiling.
(eudc-mode-map): Set parent keymap within let form.
(eudc-update-local-variables): Use #' read syntax for function
argument to map function.
(eudc-select): Likewise.
(eudc-format-attribute-name-for-display): Likewise
(eudc-filter-duplicate-attributes): Likewise.
(eudc-format-query): Likewise.
(eudc-expand-inline): Likewise.
(eudc-query-form): Likewise.
(eudc-print-attribute-value): Use mapc instead of mapcar.
(eudc-filter-partial-records): Use cl-every.
(eudc-distribute-field-on-records): Use delete-dups to
simplify function.
(eudc-expand-inline): Replace while with dolist and let form.
(eudc-query-form): Set inhibit-read-only after switching
buffers. Remove useless and call.
(eudc-load-eudc): Add a FIXME comment.
Rüdiger Sonderfeld [Sun, 15 Apr 2018 21:56:24 +0000 (23:56 +0200)]
In HTML mode, don't match </ with the wrong /
* lisp/textmodes/sgml-mode.el (sgml-slash): In HTML mode, don't
match <br /><h1>...</ with the preceding / (bug#16508).
Lars Ingebrigtsen [Sun, 15 Apr 2018 21:44:56 +0000 (23:44 +0200)]
Use quit-buffer instead of semantic-symref-hide-buffer
* lisp/cedet/semantic/symref/list.el
(semantic-symref-hide-buffer): Removed (bug#15857).
(semantic-symref-results-mode-map): Use quit-buffer instead.
Lars Ingebrigtsen [Sun, 15 Apr 2018 21:12:26 +0000 (23:12 +0200)]
Doc string update for gnus-extract-address-components
* lisp/gnus/gnus-util.el (gnus-extract-address-components): Doc
update.
Lars Ingebrigtsen [Sun, 15 Apr 2018 20:48:28 +0000 (22:48 +0200)]
Add an undo command to url-cookie-mode
* lisp/url/url-cookie.el (url-cookie-undo): New command and
keystroke (bug#16650).
Lars Ingebrigtsen [Sun, 15 Apr 2018 20:36:16 +0000 (22:36 +0200)]
Tweak the look of the cookie buffer after cookie deletion
* lisp/url/url-cookie.el (url-cookie--generate-buffer): Factor out
into its own function.
(url-cookie-delete): Use it to make the buffer look consistent
after deleting a cookie.
Lars Ingebrigtsen [Sun, 15 Apr 2018 20:20:28 +0000 (22:20 +0200)]
Make eww handle "http://a/../../../g"
* lisp/net/eww.el (eww): Strip leading elements off URLs on the
form "http://a/../../../g", because that's what all the other
browsers do (bug#8622).
Lars Ingebrigtsen [Sun, 15 Apr 2018 19:50:38 +0000 (21:50 +0200)]
Make url-cookie-write-file be more permissive
* lisp/url/url-cookie.el (url-cookie-write-file): If
`url-cookie-file' isn't set (due to url.el not being used yet),
don't error out in this function (bug#23183).
Lars Ingebrigtsen [Sun, 15 Apr 2018 19:03:34 +0000 (21:03 +0200)]
Don't warn the user about large files if they are unreadable
* lisp/files.el (abort-if-file-too-large): There's no point in
warning the user about a too-large file if we're not able to read
it (bug#29549). Hopefully this doesn't introduce a race condition
between this test and the `file-readable-p' test later.
Lars Ingebrigtsen [Sun, 15 Apr 2018 18:42:44 +0000 (20:42 +0200)]
Only save the mailer choice after sending the mail
* lisp/mail/sendmail.el (sendmail-query-once): Only save the
mailer choice after we've sent the mail, so that if that fails,
the user has an easy way to back out of the choice and make
another (bug#14487).
(sendmail-query-user-about-smtp): Return the choice; don't save it.
Lars Ingebrigtsen [Sun, 15 Apr 2018 18:06:27 +0000 (20:06 +0200)]
(compose-mail): Give a better error message for `mail-user-agent'
* lisp/simple.el (compose-mail): Give a better error message for
invalid values for `mail-user-agent' (bug#17979).
Lars Ingebrigtsen [Sun, 15 Apr 2018 17:53:27 +0000 (19:53 +0200)]
Fix typo in gnus.texi
* doc/misc/gnus.texi (Summary Message Commands): Fix typo in last
change.
Lars Ingebrigtsen [Sun, 15 Apr 2018 17:49:47 +0000 (19:49 +0200)]
Update doc string after previous ietf-drums change
* lisp/mail/ietf-drums.el (ietf-drums-parse-address): Doc fix
after previous change.
Lars Ingebrigtsen [Sun, 15 Apr 2018 17:45:05 +0000 (19:45 +0200)]
mail-extr.el: Mention `mail-header-parse-address' in the doc string
* lisp/mail/mail-extr.el (mail-extract-address-components):
Mention `mail-header-parse-address' in the doc string.
Lars Ingebrigtsen [Sun, 15 Apr 2018 17:42:10 +0000 (19:42 +0200)]
Allow `mail-header-parse-address' to decode encoded words
* lisp/mail/ietf-drums.el (ietf-drums-parse-address): Take an
optional parameter to decode the display name.
Lars Ingebrigtsen [Sun, 15 Apr 2018 17:28:04 +0000 (19:28 +0200)]
Revert "Make mail-extract-address-components return the user name more"
This reverts commit
8b50ae8b2284b5652c2843a9d0d076f4f657be28.
According to tests in bug#27656 by OGAWA Hirofumi, this patch
led to wrong results when binding
(dolist (addr '("Rasmus <rasmus@gmx.us>" "Rasmus <mbox@gmx.us>"))
(dolist (ignore-single '(t nil))
(dolist (ignore-same '(t nil))
(let ((mail-extr-ignore-single-names ignore-single)
(mail-extr-ignore-realname-equals-mailbox-name ignore-same))
(message "%s" (mail-extract-address-components addr))))))
in combination.
Lars Ingebrigtsen [Sun, 15 Apr 2018 17:01:32 +0000 (19:01 +0200)]
Query the user whether to increase stack depth in shr
* lisp/net/shr.el (shr-insert-document): Bind `max-specpdl-size'
here... (bug#30675).
(shr-descend): So that we can increase it temporarily here if the
user wants to.
Lars Ingebrigtsen [Sun, 15 Apr 2018 16:33:37 +0000 (18:33 +0200)]
Minor copy edit of etc/NEWS
Lars Ingebrigtsen [Sun, 15 Apr 2018 16:14:49 +0000 (18:14 +0200)]
* src/lread.c (openp): Add a comment before the now-obscure loop.
Lars Ingebrigtsen [Sun, 15 Apr 2018 16:13:23 +0000 (18:13 +0200)]
Clarify menu entry in previous check-in
* lisp/gnus/gnus-sum.el (gnus-summary-make-menu-bar): Menu bar
entry for it.
Lars Ingebrigtsen [Sun, 15 Apr 2018 16:02:50 +0000 (18:02 +0200)]
Add new command `gnus-summary-attach-article'
* doc/misc/gnus.texi (Summary Message Commands): Document it.
* lisp/gnus/gnus-msg.el (gnus-summary-attach-article): New command
and keystroke (bug#19788).
* lisp/gnus/gnus-sum.el (gnus-summary-make-menu-bar): Menu bar
entry for it.
Daiki Ueno [Sun, 15 Apr 2018 14:11:46 +0000 (16:11 +0200)]
Divert to call `gnus-activate-group' with the SCAN argument set
* lisp/gnus/gnus-group.el (gnus-group-get-new-news-this-group):
Divert to call `gnus-activate-group' with the SCAN argument set,
if request-group-scan is not defined for the backend. Ensure that
the server is open when calling `gnus-request-group-scan'
(bug#22649).
Lars Ingebrigtsen [Sun, 15 Apr 2018 13:48:44 +0000 (15:48 +0200)]
Abort Gnus exit if we have unsaved Message buffers
* lisp/gnus/gnus-group.el
(gnus--abort-on-unsaved-message-buffers): New function (bug#28843).
(gnus-group-exit): Use it to abort exit if we have unsaved Message
buffers.
Lars Ingebrigtsen [Sun, 15 Apr 2018 13:17:15 +0000 (15:17 +0200)]
Avoid an infloop in shr filling when not using fonts
* lisp/net/shr.el (shr-fill-line): If we have an indentation
that's wider than the width of what we're trying to fill, just
give up. This avoids an infloop when `shr-use-fonts' in nil.
Lars Ingebrigtsen [Sat, 14 Apr 2018 23:07:38 +0000 (01:07 +0200)]
Remove calls from string-to-multibyte in nnheader/nntp
* lisp/gnus/nntp.el (nntp-copy-to-buffer): Apparently `insert' now
behaves more like string-make-multibyte, but it now behaves more
like string-to-multibyte, so remove that call here. I'm not quite
sure I follow that logic, but apparently there are no ill effects.
* lisp/gnus/nnheader.el (nnheader-insert-buffer-substring): Ditto.
Lars Ingebrigtsen [Sat, 14 Apr 2018 22:57:40 +0000 (00:57 +0200)]
Remove a string-to-multibyte from nnmh.el
* lisp/gnus/nnmh.el (nnmh-request-list-1): Remove superfluous
string-to-multibyte.
Lars Ingebrigtsen [Sat, 14 Apr 2018 22:48:27 +0000 (00:48 +0200)]
Remove call to string-to-multibyte from nndoc.el
* lisp/gnus/nndoc.el (nndoc-oe-dbx-type-p): My testing shows that
no matter whether we're in a unibyte or a multibyte buffer, doing
the looking-at here without the string-to-multibyte, we'll get a
match. We did not get a match with the call in and if we were in
a unibyte buffer, but we presumably never are.
Lars Ingebrigtsen [Sat, 14 Apr 2018 22:40:23 +0000 (00:40 +0200)]
Fix calculation in gnus-update-group-mark-positions
* lisp/gnus/gnus-group.el (gnus-update-group-mark-positions):
Rewrite a call to string-to-multibyte that didn't even work.
After the rewrite it gives the correct result and should allow
people to customise Gnus group process mark positions (but that's
a pretty obscure feature).
Lars Ingebrigtsen [Sat, 14 Apr 2018 22:32:10 +0000 (00:32 +0200)]
Removed outdated comment from nnweb.el
* lisp/gnus/nnweb.el (nnweb-insert-html): Removed ten year old
comment from Stefan about string-as-multibyte.
Lars Ingebrigtsen [Sat, 14 Apr 2018 22:30:14 +0000 (00:30 +0200)]
Rewrite Gnus calls to compat function mm-multibyte-p
Lars Ingebrigtsen [Sat, 14 Apr 2018 22:24:02 +0000 (00:24 +0200)]
Rewrite string-as-unibyte/string-as-multibyte logic in nnmail
* lisp/gnus/nnmail.el (nnmail-insert-xref): Rewrite
string-as-unibyte/string-as-multibyte logic and confirm that the
result is the same in both multibyte and unibyte buffers after the
change.
Lars Ingebrigtsen [Sat, 14 Apr 2018 22:17:28 +0000 (00:17 +0200)]
Remove call to string-as-unibyte from nnmail
* lisp/gnus/nnmail.el (nnmail-parse-active): Remove call to
string-as-unibyte; the alist before and after the change are
`equal' to each other, so it should presumably have no impact.
Lars Ingebrigtsen [Sat, 14 Apr 2018 22:14:30 +0000 (00:14 +0200)]
Remove calls to string-as-unibyte from nnir.el
* lisp/gnus/nnir.el (nnir-get-active): Remove two calls to
string-as-unibyte from code that seems cargo-culted from Gnus
functions where it is not needed, so it's presumably not needed
here, either.
Lars Ingebrigtsen [Sat, 14 Apr 2018 22:09:47 +0000 (00:09 +0200)]
Remove call to string-as-unibyte in gnus-start.el
* lisp/gnus/gnus-start.el (gnus-read-newsrc-el-file): Remove
string-as-unibyte call, which appears not to do anything much in
modern Emacsen.
Lars Ingebrigtsen [Sat, 14 Apr 2018 22:07:08 +0000 (00:07 +0200)]
Remove call to string-as-unibyte from gnus-start.el
* lisp/gnus/gnus-start.el (gnus-update-active-hashtb-from-killed):
Remove a string-as-unibyte call here, which appears not to be
necessary: I'm able to complete over non-ASCII names both before
and after.
Lars Ingebrigtsen [Sat, 14 Apr 2018 21:58:59 +0000 (23:58 +0200)]
Modernise a Gnus function a bit
* lisp/gnus/gnus-start.el (gnus-update-active-hashtb-from-killed):
Modernise code a bit.
Lars Ingebrigtsen [Sat, 14 Apr 2018 21:54:07 +0000 (23:54 +0200)]
Remove two string-as-unibyte in gnus-srvr.el
* lisp/gnus/gnus-srvr.el (gnus-browse-foreign-server): We do not
seem to need the string-as-unibyte here: We read a multibyte
string from the *nntpd* buffer and then decode it later, and this
apparently by some strange magic leads to the correct results in
my test cases.
Lars Ingebrigtsen [Sat, 14 Apr 2018 21:25:01 +0000 (23:25 +0200)]
Fix a `string-to-multibyte' in Gnus
* lisp/gnus/gnus-art.el (gnus-request-article-this-buffer): The
original article buffer is multibyte, and we're inserting into the
article buffer, which is also multibyte, so the `string-to-multibyte'
here should be unnecessary?
Lars Ingebrigtsen [Sat, 14 Apr 2018 21:17:24 +0000 (23:17 +0200)]
Fix a string-as-unibyte in Gnus
* lisp/gnus/gnus-art.el (gnus-article-browse-html-parts): Get rid
of a string-as-unibyte.
Lars Ingebrigtsen [Sat, 14 Apr 2018 20:38:53 +0000 (22:38 +0200)]
Further shr line folding/link continuation tweaks
* lisp/net/shr.el (shr-fill-line): Tweak the link continuations
further when folding lines.
Lars Ingebrigtsen [Sat, 14 Apr 2018 19:55:39 +0000 (21:55 +0200)]
Indent after transforming for loop into do/while
Lars Ingebrigtsen [Sat, 14 Apr 2018 19:55:08 +0000 (21:55 +0200)]
Make call-process work if exec-path is nil
* src/lread.c (openp): If exec-path is nil, no files would be
found to execute (bug#30564).
Test cases:
(let ((exec-path ()))
(call-process "/bin/ls" nil (current-buffer)))
This would previously fail, but now works.
(let ((exec-path '("/bin/")))
(call-process "ls" nil (current-buffer)))
This worked, and still works.
Lars Ingebrigtsen [Sat, 14 Apr 2018 19:18:51 +0000 (21:18 +0200)]
Make erc-current-logfile work with explicit parameter
* lisp/erc/erc-log.el (erc-current-logfile): This function
apparently refers to buffer-local variables, so switch to the
buffer given before calculating the file name (bug#16111).
Lars Ingebrigtsen [Sat, 14 Apr 2018 19:11:05 +0000 (21:11 +0200)]
Tweak shr link text property adjustments when folding
* lisp/net/shr.el (shr-fill-line): If a link starts at the first
word on a new folded line, then don't copy the link properties to
the newline inserted.
Lars Ingebrigtsen [Sat, 14 Apr 2018 18:56:16 +0000 (20:56 +0200)]
* lisp/erc/erc-button.el (erc-button-search-url): Doc fix.
Lars Ingebrigtsen [Sat, 14 Apr 2018 18:54:24 +0000 (20:54 +0200)]
erc build fix for the previous patch
Lars Ingebrigtsen [Sat, 14 Apr 2018 18:52:36 +0000 (20:52 +0200)]
erc-truncate-buffer-on-save doc string clarification
* lisp/erc/erc-log.el (erc-truncate-buffer-on-save): Doc
clarification (bug#18207) since "truncate" is a word used by
erc-truncate to mean something else.
Lars Ingebrigtsen [Sat, 14 Apr 2018 18:37:09 +0000 (20:37 +0200)]
Ignore all-whitespace topics in erc
* lisp/erc/erc.el (erc-cmd-TOPIC): Ignore all-whitespace topics
(bug#25153).
Lars Ingebrigtsen [Sat, 14 Apr 2018 18:32:05 +0000 (20:32 +0200)]
Rename url-button-google-url
* lisp/erc/erc-button.el (erc-button-search-url): Renamed from
url-button-google-url (bug#25717). Suggested by Andrew Robbins.
(erc-button-alist): Use it.
John Goerzen [Sat, 14 Apr 2018 18:10:53 +0000 (20:10 +0200)]
Subject: Fix problem with erc buffer renames after reconnect
* lisp/erc/erc.el (erc-generate-new-buffer-name): Solve problem
with renamed buffers on different servers after reconnect (bug#30639).
Copyright-paperwork-exempt: yes
Lars Ingebrigtsen [Sat, 14 Apr 2018 17:06:51 +0000 (19:06 +0200)]
(libxml-parse-html-region): Make DISCARD-COMMENTS obsolete
* lisp/subr.el (libxml-parse-xml-region)
(libxml-parse-html-region): Make DISCARD-COMMENTS obsolete.
* src/xml.c (Flibxml_parse_html_region)
(Flibxml_parse_xml_region): Don't mention DISCARD-COMMENTS, since
it's now no longer part of the advertised signature (bug#27178).
Lars Ingebrigtsen [Sat, 14 Apr 2018 15:18:53 +0000 (17:18 +0200)]
Revert "Revert "Give better errors in signing failures in Gnus""
This reverts commit
42141da5b0885b199636524c1e57f08ee1723aea.
This patch was reverted in error. I misinterpreted an email saying that
it didn't work, but apparently it worked as it should.
Lars Ingebrigtsen [Sat, 14 Apr 2018 15:14:01 +0000 (17:14 +0200)]
Make DISCARD-COMMENTS in `libxml-parse-{html,xml}-region' obsolete
* doc/lispref/text.texi (Parsing HTML/XML): Mention that
discard-comments is obsolete.
* lisp/xml.el (xml-remove-comments): New function (bug#27178).
* src/xml.c (Flibxml_parse_html_region): Clarify what
DISCARD-COMMENTS actually does, and say that the parameter is
obsolete.
(Flibxml_parse_xml_region): Ditto.
Glenn Morris [Sat, 14 Apr 2018 14:50:45 +0000 (07:50 -0700)]
Merge from origin/emacs-26
5a6bb01 (origin/emacs-26) Fix building etc/DOC in the MSDOS port
274c979 * lisp/select.el (gui-get-selection): Doc fix.
ad731b0 ; * doc/lispref/display.texi (Temporary Displays): Fix typos.
f1450e9 Complete documentation of syntax flags by adding `c'
6bdcaec Fix typos and minor wording issues in ELisp manual
febac27 Merge branch 'emacs-26' of git.savannah.gnu.org:/srv/git/emac...
6c2e21e Avoid segfault in processes of type 'pipe'
60e10c5 Remove repetitions in documentation strings
208e752 * lisp/image.el (image-load-path): Doc fix.
92e0fd8 ; * etc/NEWS: Remove a FIXME. (Bug#31122)
Conflicts:
etc/NEWS
Lars Ingebrigtsen [Sat, 14 Apr 2018 13:52:16 +0000 (15:52 +0200)]
Change the default From style to `angles' and make obsolete
* lisp/gnus/message.el (message-from-style): Make `angles' the
default (bug#29309) and mark as obsolete.
* lisp/mail/sendmail.el (mail-from-style): Ditto.
Lars Ingebrigtsen [Sat, 14 Apr 2018 13:36:53 +0000 (15:36 +0200)]
Make image-mode respect `imagemagick-types-inhibit'
* lisp/image-mode.el (image--imagemagick-wanted-p): New function
(bug#29584).
(image-toggle-display-image): Use it to see whether we want to use
imagemagick.
Lars Ingebrigtsen [Sat, 14 Apr 2018 13:12:48 +0000 (15:12 +0200)]
Revert "Give better errors in signing failures in Gnus"
This reverts commit
ef2059e877d104bfe5abd24df05bb09c7295e4fa.
Apparently this test triggered both when signing was successful
and unsuccessful (bug#26298).
Eli Zaretskii [Sat, 14 Apr 2018 12:52:40 +0000 (15:52 +0300)]
Fix building etc/DOC in the MSDOS port
* msdos/sed1v2.inp (lisp.mk): Fix escaping in Sed commands.
Lars Ingebrigtsen [Sat, 14 Apr 2018 12:50:14 +0000 (14:50 +0200)]
Tweak mailcap precedence so that Emacs values are heeded better
* lisp/net/mailcap.el (mailcap-parse-mailcaps): Place entries from
system-wide mailcap files after the values that are distributed
with Emacs, and the ones from ~/.mailcap before.
(mailcap-parse-mailcap): Take an optional `after' parameter to
achieve that.
(mailcap-add-mailcap-entry): Ditto.
Tino Calancha [Sat, 14 Apr 2018 10:56:22 +0000 (12:56 +0200)]
Subject: Fix circular dependency for mm-decode
* lisp/gnus/mm-decode.el: Do not require shr.el at the top
of the file; `mm-shr' already requires shr.el in its body, and
this function is the only `mm-convert-shr-links' caller (Bug#31151).
Eli Zaretskii [Sat, 14 Apr 2018 07:53:34 +0000 (10:53 +0300)]
* lisp/select.el (gui-get-selection): Doc fix.
Noam Postavsky [Sat, 14 Apr 2018 05:58:38 +0000 (01:58 -0400)]
; * doc/misc/url.texi (file/ftp): Remove stray '@end defopt'.
Basil L. Contovounesios [Fri, 13 Apr 2018 11:47:30 +0000 (12:47 +0100)]
Do not destructively modify interprogram paste
* simple.el (kill-new, current-kill): Non-destructively reverse list
returned by interprogram-paste-function. (bug#31097)
Lars Ingebrigtsen [Fri, 13 Apr 2018 22:17:36 +0000 (00:17 +0200)]
Don't bind image commands on eww non-image links
* lisp/net/eww.el (eww-link-keymap): Only inherit the normal shr
keymap.
(eww-image-link-keymap): New keymap with the image bindings.
(eww-tag-a): Use the appropriate one on links (bug#30148).
Lars Ingebrigtsen [Fri, 13 Apr 2018 22:15:15 +0000 (00:15 +0200)]
Move utility function to mm-util.el
* lisp/gnus/mm-util.el (mm-images-in-region-p): Move from
mm-decode.el and renamed, since it is generally useful.
Lars Ingebrigtsen [Fri, 13 Apr 2018 22:08:26 +0000 (00:08 +0200)]
Make the url file: handler be less clever
* doc/misc/url.texi (file/ftp): Remove mention of the
url-directory-index-file variable, which is no longer consulted.
* lisp/url/url-file.el (url-file-build-filename): Remove the DWIM
code from the file: handler (bug#30195): It would look for
index.html in a directory if we asked it to fetch the directory.
Determining what to do in a directory should be left up to the
programs that use this low-level library. If the library decides
to load a different file than we specified, then things start
falling apart, as demonstrated by this bug report.
Lars Ingebrigtsen [Fri, 13 Apr 2018 21:49:58 +0000 (23:49 +0200)]
Don't bind image commands on non-image links in Gnus
* lisp/gnus/mm-decode.el (mm--images-in-region-p): New utility
function.
(mm-convert-shr-links): Only use the shr image map on links that
contain images. This avoids binding commands like `r' on links
that don't need it.
Lars Ingebrigtsen [Fri, 13 Apr 2018 20:52:16 +0000 (22:52 +0200)]
Revert "Add colors to faces that lack them."
This reverts commit
16748a5f6bd57ec0967ecb5e14ffe8af5f43d888.
From the discussion on the ding mailing list, I said:
I think the colours should be reverted back to what they were before the
change. Normal text should be white on black (if you have a dark
background), and colours should be used to emphasise or de-emphasise
certain text. Following that principle, normal Gnus groups should be
white, not ... er... what are they now? Teal?
Lars Ingebrigtsen [Fri, 13 Apr 2018 20:27:21 +0000 (22:27 +0200)]
Tweak the fonts applied to shr indentation
* lisp/net/shr.el (shr-fill-line): Don't use fonts (especially
link fonts) over indentation, because that's ugly..
Lars Ingebrigtsen [Fri, 13 Apr 2018 19:58:25 +0000 (21:58 +0200)]
Further tweak point placement on gnus-summary-select-article-buffer
* lisp/gnus/gnus-sum.el (gnus-summary-select-article-buffer):
Place point in the empty space between headers and body.
Lars Ingebrigtsen [Fri, 13 Apr 2018 19:33:37 +0000 (21:33 +0200)]
Tweak point placement in *Group* on `Q' exit
* lisp/gnus/gnus-sum.el (gnus-summary-exit-no-update): When
exiting the summary buffer with `Q', move point to the next unread
group (which is the same thing that happens on `q' exit.)
Lars Ingebrigtsen [Fri, 13 Apr 2018 19:18:51 +0000 (21:18 +0200)]
Tweak point placement in gnus-summary-select-article-buffer
* lisp/gnus/gnus-sum.el (gnus-summary-select-article-buffer):
Tweak where point is placed because when the user selects the
article buffer, it's probably to cite something or click on
something, and not do anything with the headers.
Lars Ingebrigtsen [Fri, 13 Apr 2018 18:24:04 +0000 (20:24 +0200)]
Compute erc line lengths correctly for utf-8 (etc.)
* lisp/erc/erc-backend.el (erc-split-line): Fold the lines
according to octet length, not the number of characters (bug#23047).
Lars Ingebrigtsen [Fri, 13 Apr 2018 17:54:22 +0000 (19:54 +0200)]
Clean up some defvoo doc strings
* lisp/gnus/nndiary.el: Remove "*" from doc strings from defvoo
elements (bug#23392).
* lisp/gnus/nndir.el: Ditto
* lisp/gnus/nndoc.el: Ditto.
* lisp/gnus/nnrss.el: Ditto.
* lisp/gnus/nnspool.el: Ditto.
* lisp/gnus/nntp.el: Ditto.
Eric Abrahamsen [Sun, 8 Apr 2018 23:49:20 +0000 (16:49 -0700)]
Further fix to eieio-persistent
* lisp/emacs-lisp/eieio-base.el (eieio-persistent-validate/fix-slot-value):
Make handling of hash tables and vectors recursive. This is
necessary because the write process, in `eieio-override-prin1' is
also recursive. With any luck, this will be the last fix of its
kind. If that's true, cherry-pick to Emacs 26.2 later on.
Lars Ingebrigtsen [Fri, 13 Apr 2018 17:28:17 +0000 (19:28 +0200)]
Make nnimap parse pathological spam headers better
* lisp/gnus/nnimap.el (nnimap-transform-headers): Unfold certain
pathological IMAP headers more correctly (bug#25502). Perhaps
this function should be re-implemented.
Eli Zaretskii [Fri, 13 Apr 2018 17:19:17 +0000 (20:19 +0300)]
; * doc/lispref/display.texi (Temporary Displays): Fix typos.
Lars Ingebrigtsen [Fri, 13 Apr 2018 17:09:03 +0000 (19:09 +0200)]
Fix syntax error in emacs-mime.texi in last check-in
Lars Ingebrigtsen [Fri, 13 Apr 2018 17:08:16 +0000 (19:08 +0200)]
Prefer settings from ~/.mailcap over system and Emacs settings
* doc/misc/emacs-mime.texi (mailcap): Document the variable and
how mailcap chooses which viewer to use.
* lisp/net/mailcap.el (mailcap-prefer-mailcap-viewers): New variable.
(mailcap-mime-info): Use it.
Lars Ingebrigtsen [Fri, 13 Apr 2018 16:35:07 +0000 (18:35 +0200)]
Fix bug in shr-urlify introduced in previous patch
* lisp/net/shr.el (shr-urlify): Not all URLs have domains, so
check for that before doing IDNA.
Lars Ingebrigtsen [Fri, 13 Apr 2018 15:30:59 +0000 (17:30 +0200)]
Make shr support inline <div>s
* lisp/net/shr.el (shr-tag-div): Support display: inline; for
<div>, since that's a very common thing (bug#25588).
Lars Ingebrigtsen [Fri, 13 Apr 2018 15:11:07 +0000 (17:11 +0200)]
Notify the user a bit more before clicking IDNA links
* lisp/net/shr.el (shr-urlify): Show the puny-encoded domain name
in the mouseover string (bug#25600).
Lars Ingebrigtsen [Fri, 13 Apr 2018 14:50:45 +0000 (16:50 +0200)]
(nnimap-sequence): Add comment
* lisp/gnus/nnimap.el (nnimap-sequence): Add comment.
Lars Ingebrigtsen [Fri, 13 Apr 2018 14:41:13 +0000 (16:41 +0200)]
(url-http): Ensure that the referrer is all-ASCII
* lisp/url/url-http.el (url-http): Ensure that the referrer is all-ASCII.
Lars Ingebrigtsen [Fri, 13 Apr 2018 14:39:17 +0000 (16:39 +0200)]
gnutls.el now needs punycode
* lisp/net/gnutls.el (puny): Require punycode.