Merge pull request from matzebond/master

GitHub-reference: https://github.com/jwiegley/use-package/issues/787

Merge pull request from wcy123/master

GitHub-reference: https://github.com/jwiegley/use-package/issues/822

Merge pull request from phst/lex

GitHub-reference: https://github.com/jwiegley/use-package/issues/848

Merge pull request from phst/flet

GitHub-reference: https://github.com/jwiegley/use-package/issues/849

Merge pull request from conao3/add-custom-face-description

GitHub-reference: https://github.com/jwiegley/use-package/issues/863

Merge pull request from iaeerfung/master

GitHub-reference: https://github.com/jwiegley/use-package/issues/912

Merge pull request from wyuenho/set-default-use-package-enable-imenu-support

GitHub-reference: https://github.com/jwiegley/use-package/issues/920

Merge pull request from wyuenho/statistics-sorting

GitHub-reference: https://github.com/jwiegley/use-package/issues/921

Merge pull request from Hugo-Heagren/bind-keys-repeat-map

GitHub-reference: https://github.com/jwiegley/use-package/issues/974

Merge pull request from danielpza/add-update-custom-package

GitHub-reference: https://github.com/jwiegley/use-package/issues/930

Merge pull request from tarsiiformes/silencio

GitHub-reference: https://github.com/jwiegley/use-package/issues/936

Merge pull request from DamienCassou/update-texi

GitHub-reference: https://github.com/jwiegley/use-package/issues/979

Merge pull request from skangas/fix-typo

GitHub-reference: https://github.com/jwiegley/use-package/issues/987

Add: 'local' keyword

Avoid positional arguments to define-minor-mode

Back in Emacs-21.1, `define-minor-mode' grew keyword arguments to
replace its old positional arguments.  Starting with Emacs-28.1
a warning will be omitted if positional arguments are still used.

Fix typo in use-package docstring

Update use-package.texi

optimization: constand folding for read-kbd-macro

to boost startup performance, it is better to avoid invoking
`read-kbd-macro` at run time which requires 'cl-lib.

it takes ~20ms to load cl-lib

Copyright-paperwork-exempt: yes

bind-keys-form: error for repeat sub-keywords without :repeat-map

Error descriptively if :continue or :exit is specified without
:repeat-map.

bind-key-form: allow :continue keyword inside repeat map

Purely syntactic sugar, using :continue is the same as not using any
keyword inside :repeat-map at all.

Amend end of function to pass repeat-map value onto next invocation in
recursive uses. This allows for the same repeat map to be used for
:exit and :continue.

bind-key-form: allow :exit keyword inside repeat map

Keys bound inside the scope of :exit are bound inside the repeat map,
but do not have their repeat-map property set (so they run a function,
but 'exit' the map).

bind-keys-form: new keyword :repeat-map, for defining repeat maps

use-package-normalize/:bind: allow keyword :repeat-map.

bind-keys-form: Add keyword :repeat-map. Specifying a symbol as the
repeat-map defines a keymap with that name (and with the docstring
`repeat-doc', if specified). Symbols for functions bound to keys under
the scope of :repeat-map have their 'repeat-map property set to this
map. Update docstring (and that of `bind-keys') to reflect changes.

Rename `doc' to `prefix-doc' for clarity and consistency with
'repeat-doc'.

feat: add update custom packages command

Copyright-paperwork-exempt: yes

Properly sort use-package-statistics-report

Fix void-variable use-package-enable-imenu-support

Remove uses of deprecated ‘flet’ macro

Instead, use the non-deprecated ‘cl-flet’ and ‘cl-letf’ macros from the
‘cl-lib’ package.

This also allows us to remove the ‘plist-delete’ helper function, which was
only used to effectively un-deprecate ‘flet’.

fix docstring. was: invalid function name

Copyright-paperwork-exempt: yes

Merge pull request from minad/improved-unbind

GitHub-reference: https://github.com/jwiegley/use-package/issues/910

unbind-key: Ensure that keys are removed from the keymap

* The removal from the keymap is performed by bind-key--remove
* Use the same argument normalization as bind-key

bind-key: Use new symbols for kmapvar

Merge pull request from tzz/tzz/use-package-use-theme

Add use-package-use-theme and avoid missing theme errors
GitHub-reference: https://github.com/jwiegley/use-package/issues/907

Add use-package-use-theme and avoid missing theme errors

Merge pull request from kljohann/custom-use-single-let

Use a single let binding when expanding consecutive :custom forms
GitHub-reference: https://github.com/jwiegley/use-package/issues/906

Use a single let binding when expanding consecutive :custom forms

Copyright-paperwork-exempt: yes

Merge pull request from tzz/tzz/remove-use-package-from-custom-enabled-themes

Remove use-package theme from global list of custom-enabled-themes
GitHub-reference: https://github.com/jwiegley/use-package/issues/899

Remove use-package theme from global list of custom-enabled-themes

* eval-when-compile for cases where use-package is only required at
  compile time

* remove the 'use-package theme from custom-enabled-themes so e.g.
  (mapc #'disable-theme custom-enabled-themes)
  won't kill user settings.

Merge pull request from tzz/tzz/set-comment-and-synthetic-theme

GitHub-reference: https://github.com/jwiegley/use-package/issues/881

Create new "use-package" themse and use it for :custom with custom-theme-set-variables

set property theme-value to avoid saving variable

Revert "use-package-core.el: use the Emacs set-default function to avoid saving :custom vars twice"

This reverts commit 8c31c57106e2938d627bf4107627c003620d2dd5.

set saved-variable-comment from :custom

GitHub-reference: https://github.com/jwiegley/use-package/issues/861

Update version to 2.4.1

add multiple and eval :custom-face usage

This commit follows suggestion at https://github.com/jwiegley/use-package/issues/696, https://github.com/jwiegley/use-package/issues/821

Merge pull request from wyuenho/patch-1

GitHub-reference: https://github.com/jwiegley/use-package/issues/846

Migrate remaining files to lexical binding

Merge branch 'master' into patch-1

Merge pull request from tzz/custom-set-default

GitHub-reference: https://github.com/jwiegley/use-package/issues/855

Update the documentation for :custom as per

GitHub-reference: https://github.com/jwiegley/use-package/issues/850

Fix broken test due to

GitHub-reference: https://github.com/jwiegley/use-package/issues/850

better tests

add test for

GitHub-reference: https://github.com/jwiegley/use-package/issues/845

Support keymap symbol in bind-key

GitHub-reference: fix https://github.com/jwiegley/use-package/issues/845

Merge pull request from tzz/custom-set-default

use-package-core.el: use the Emacs set-default function to avoid saving :custom vars twice
GitHub-reference: https://github.com/jwiegley/use-package/issues/850

use-package-core.el: use the Emacs set-default function to avoid saving :custom vars twice

Merge pull request from jjlee/call-hooks-even-if-no-config

GitHub-reference: https://github.com/jwiegley/use-package/issues/840

Merge branch 'master' into call-hooks-even-if-no-config

Merge pull request from nahuel/patch-1

GitHub-reference: https://github.com/jwiegley/use-package/issues/843

typo, should be a vector, not a bytecode object

Solves https://github.com/jwiegley/use-package/issues/842

Add special value back again, in case needed for backwards compat

I don't know why this special value exists, but perhaps old client code uses it.

The additional `t' in the macro expansion is accidental but not harmful I guess.

Copyright-paperwork-exempt: yes

Even when there's no :config, run any pre/post config hooks

i.e., following the existing docs for use-package-inject-hooks, these hooks are
run:

use-package--foo--pre-config-hook
use-package--foo--post-config-hook

This should make config customisations more predictable (for example, spacemacs
uses these hooks extensively to allow 'layers' to be customised).

I got rid of the "special" default value for :config, because it doesn't seem to
be treated any differently than nil.

Fixes https://github.com/jwiegley/use-package/issues/785

Copyright-paperwork-exempt: yes

Merge pull request from jwiegley/johnw/clarify

Clarify the documentation for :after
GitHub-reference: https://github.com/jwiegley/use-package/issues/820

Clarify the documentation for :after

Merge pull request from DamienCassou/typos

Fix typos
GitHub-reference: https://github.com/jwiegley/use-package/issues/808

Fix typos

Typos found with codespell.

Merge pull request from tarsiiformes/typos

Fix typos
GitHub-reference: https://github.com/jwiegley/use-package/issues/804

Fix typos

Use `require', not `load', when byte-compiling ()

Use `require', not `load', when byte-compiling
GitHub-reference: https://github.com/jwiegley/use-package/issues/783

Update tests

Switch from `require' to `load' + `featurep'

Use `require', not `load', when byte-compiling

Make custom-face evaluate elisp. ()

Make custom-face evaluate elisp.
GitHub-reference: https://github.com/jwiegley/use-package/issues/773

Make custom-face evaluate elisp

Fix https://github.com/jwiegley/use-package/issues/696.

Copyright-paperwork-exempt: yes

Merge pull request from stribb/master

Add a line of documentation for (use-pacakage ... :hook).
GitHub-reference: https://github.com/jwiegley/use-package/issues/759

Add a line of documentation for (use-pacakage ... :hook)

Copyright-paperwork-exempt: yes

Merge pull request from conao3/fix_default_value

fix gethash default value for use-package-statistics-time
GitHub-reference: https://github.com/jwiegley/use-package/issues/681

Merge pull request from tarsiiformes/silencio

Silence byte-compiler on Emacs 25
GitHub-reference: https://github.com/jwiegley/use-package/issues/733

Silence byte-compiler on Emacs 25

Emacs 25 defined a global variable `features', which triggers a
warning "Lexical argument shadows the dynamic variable features".
That's not `use-package's fault, but we should suppress the warning
anyway, so that there is no additional noise that would cause us to
potentially overlook warnings that absolutely have to be addressed.

Merge pull request from jwiegley/use-package-chords-suppress-compiler-message

prefix argument with _ to suppress Unused lexical argument warning
GitHub-reference: https://github.com/jwiegley/use-package/issues/713

Merge pull request from lrochfort/ensure-system-package_use-sudo

[Fix https://github.com/jwiegley/use-package/issues/720] Install system packages using system-packages-install
GitHub-reference: https://github.com/jwiegley/use-package/issues/721

[] Install system packages using system-packages-install

:ensure-system-package was installing packages by running
system-packages-get-command via async-shell-command. This meant that
system-packages-use-sudo wasn't being honoured.

This patch makes :ensure-system-package use system-packages-install
for all cases, except where a custom install command is supplied, in
which case async-shell-command is used.

This issue was introduced in 9f034a0bcfdd8c4 [https://github.com/jwiegley/use-package/issues/673], as a fix for
[https://github.com/jwiegley/use-package/issues/661]. Prior to that commit, system-packages-use-sudo was being
honoured.

This patch also fixes a bug where a cons containing a lone symbol in a
list of conses causes nil to used as the package to install.
GitHub-reference: fix https://github.com/jwiegley/use-package/issues/720
Copyright-paperwork-exempt: yes

prefix argument with _ to suppress Unused lexical argument warning

per @tarsius’s comment
https://github.com/jwiegley/use-package/commit/5d9c854a6cf12fff2326ee5653e87e2d3d550a8d#commitcomment-29996666

Merge pull request from justbur/autoload-keymap

Correct prefix keys after use-package-autoload-keymap
GitHub-reference: https://github.com/jwiegley/use-package/issues/686

Merge pull request from jwiegley/ensure-system-package-filepath

allow :ensure-system-package to check the presence of files at path
GitHub-reference: https://github.com/jwiegley/use-package/issues/703

allow :ensure-system-package to check the presence of files at path

closes https://github.com/jwiegley/use-package/issues/660

Merge pull request from killdash9/patch-1

Place :chords at beginning of use-package-keywords
GitHub-reference: https://github.com/jwiegley/use-package/issues/697

Place :chords at beginning of use-package-keywords

When it is at the end, the keys don't get bound until after the package has been loaded, which is bad.  Placing it at the beginning allows the key bindings to be mapped to auto-loaded functions before the package is loaded, so that a key chord press triggers the package load.

Merge pull request from killdash9/patch-1

New style of auto-deferral for chords
GitHub-reference: https://github.com/jwiegley/use-package/issues/658

Merge branch 'master' into patch-1

Merge pull request from jabranham/enable-lexical-binding

Enable lexical binding
GitHub-reference: https://github.com/jwiegley/use-package/issues/657

Fix use-package-normalize-function

Fix use-package-normalize-function tests

Enable lexical binding

This supersedes https://github.com/jwiegley/use-package/issues/617 and closes https://github.com/jwiegley/use-package/issues/648

Merge pull request from taingra/master

Added an Introduction taken from the README
GitHub-reference: https://github.com/jwiegley/use-package/issues/692

Update use-package.texi

Added an Introduction taken from the README

Copyright-paperwork-exempt: yes

Correct prefix keys after use-package-autoload-keymap

By adding events of the form (cons t event) to unread-command-events, Emacs
correctly updates this-command-keys for the subsequent use of the prefix.

Before this change, packages like my which-key were not getting the correct
prefix after use-package-autoload-keymap loaded the relevant package.

See https://github.com/justbur/emacs-which-key/issues/192

Merge pull request from akhramov/fix/ensure-system-package-cleanup

ensure-system-package cleanup
GitHub-reference: https://github.com/jwiegley/use-package/issues/683

Ensure system package cleanup

The function introduced in https://github.com/jwiegley/use-package/issues/673 wasn't declared at compile time, and
it made byte compiler unhappy. Moreover, it was forgotten to remove
redundant compile time variables. Thanks @tarsius for pointing that
out.

This change
* Removes redundant variable declarations
* Adds `system-packages-get-command` function declaration.

Copyright-paperwork-exempt: yes

fix gethash default value for use-package-statistics-time

float-time expect list like (HIGH LOW USEC PSEC)
> HIGH has the most significant bits of the seconds, while LOW has the
> least significant 16 bits.  USEC and PSEC are the microsecond and
> picosecond counts.
by `current-time` in editfns.c

Merge pull request from andschwa/remap-command

Document that remapping commands is supported with bind-key
GitHub-reference: https://github.com/jwiegley/use-package/issues/674