]> git.eshelyaron.com Git - emacs.git/log
emacs.git
2 years agoRevert "Don’t assume openat"
Eli Zaretskii [Sun, 17 Apr 2022 19:03:52 +0000 (22:03 +0300)]
Revert "Don’t assume openat"

This reverts commit 3cccf0a9107d585173e527550bbc45253624ca2e.

This is a change with far-reaching effects on MS-Windows at the least,
where file-related APIs are shadowed to support transparent support
for UTF-8 encoded file names.  Making such changes on a stable branch
for the benefit of a proprietary platform with a 13-year old OS is a
tail wagging the dog.  Please don't do that without discussing first.

2 years agoDon’t assume openat
Paul Eggert [Sun, 17 Apr 2022 17:41:17 +0000 (10:41 -0700)]
Don’t assume openat

Use openat only on platforms with O_PATH.
This ports to OS X 10.9 and earlier.
Problem reported by Keith David Bershatsky in:
https://lists.gnu.org/r/emacs-devel/2022-04/msg00805.html
* lib-src/emacsclient.c (local_sockname): Use open, not openat.
* src/sysdep.c (sys_openat): New static function,
which uses openat only if O_PATH is defined.
(emacs_openat): Use it instead of openat.
(emacs_openat_noquit): Remove.
(emacs_open_noquit): Reimplement as per the old emacs_openat_noquit,
but use plain 'open'.

2 years agoFix GC bug in filelock.c
Paul Eggert [Sun, 17 Apr 2022 08:06:46 +0000 (01:06 -0700)]
Fix GC bug in filelock.c

Fix a bug where if GC occurred at the wrong moment when locking a
file, the lock file’s name was trashed so file locking did not work.
This bug was introduced in Emacs 28.1.  The bug sometimes caused
filelock-tests-detect-external-change test failures on Fedora 35
x86-64 in an en_US.utf8 locale.
* src/filelock.c (lock_file_1, current_lock_owner, lock_if_free)
(lock_file, unlock_file, Ffile_locked_p):
Use Lisp_Object, not char *, for string, so that GC doesn’t trash
string contents.
(make_lock_file_name): Return the encoded name, not the original.
All callers changed.

2 years agoClarify when mode tagging is used
Lars Ingebrigtsen [Sat, 16 Apr 2022 14:24:39 +0000 (16:24 +0200)]
Clarify when mode tagging is used

* etc/NEWS: Clarify when mode tagging is used (bug#54964).

2 years agoFurther vcs-cvs/rcs-responsible-p updates from master
Lars Ingebrigtsen [Thu, 14 Apr 2022 14:51:39 +0000 (16:51 +0200)]
Further vcs-cvs/rcs-responsible-p updates from master

* lisp/vc/vc-bzr.el (vc-bzr-responsible-p):
* lisp/vc/vc-sccs.el (vc-sccs-responsible-p):
* lisp/vc/vc-dav.el (vc-dav-responsible-p): Update doc string.

* lisp/vc/vc-rcs.el (vc-rcs-responsible-p):
* lisp/vc/vc-cvs.el (vc-cvs-responsible-p): Further fixes from
master.

* lisp/vc/vc-src.el (vc-src-responsible-p): Return the directory.

* lisp/vc/vc.el: Update comments.

2 years ago; * src/sysdep.c: Fix mistake in previous commit
Mattias Engdegård [Sat, 16 Apr 2022 10:16:45 +0000 (12:16 +0200)]
; * src/sysdep.c: Fix mistake in previous commit

2 years agoFix builds on older versions of macOS
Mattias Engdegård [Sat, 16 Apr 2022 09:33:14 +0000 (11:33 +0200)]
Fix builds on older versions of macOS

This adds back macOS-specific code replaced earlier (bug#48548),
specifically to fix build errors on macOS 10.7.5.  See discussion at
https://lists.gnu.org/archive/html/emacs-devel/2022-04/msg00779.html .

* src/sysdep.c (HAVE_RUSAGE_INFO_CURRENT, HAVE_PROC_PIDINFO): New.
(system_process_attributes): Use alternative code or exclude features
when building on older macOS versions.

2 years agoFix documentation of Outline minor mode options
Eli Zaretskii [Sat, 16 Apr 2022 07:56:01 +0000 (10:56 +0300)]
Fix documentation of Outline minor mode options

* lisp/outline.el (outline-minor-mode-cycle-filter)
(outline-minor-mode-cycle, outline-minor-mode-highlight)
(outline-cycle, outline-cycle-buffer): Doc fixes.  (Bug#54967)

2 years agoImprove discoverability of 'insert-directory-program'
Eli Zaretskii [Fri, 15 Apr 2022 20:03:15 +0000 (23:03 +0300)]
Improve discoverability of 'insert-directory-program'

* lisp/files.el (insert-directory-program): Mention 'dired' in the
doc string.
* lisp/dired.el (dired): Mention 'insert-directory-program' in the
doc string.  (Bug#54962)

2 years ago; * etc/PROBLEMS: Describe MS-Windows issues with fonts. (Bug#54685)
Eli Zaretskii [Fri, 15 Apr 2022 12:38:06 +0000 (15:38 +0300)]
; * etc/PROBLEMS: Describe MS-Windows issues with fonts.  (Bug#54685)

2 years agoFix cursor motion under truncate-lines with Flymake fringe indicator
Eli Zaretskii [Fri, 15 Apr 2022 09:03:36 +0000 (12:03 +0300)]
Fix cursor motion under truncate-lines with Flymake fringe indicator

* src/indent.c (Fvertical_motion): Don't consider fringe bitmaps
as "images" for the purpose of vertical-motion logic dealing with
overshooting buffer positions.  (Bug#54946)

2 years agoMake all vc-*-responsible-p functions return a string
Lars Ingebrigtsen [Sun, 14 Nov 2021 01:38:48 +0000 (02:38 +0100)]
Make all vc-*-responsible-p functions return a string

* lisp/vc/vc-sccs.el (vc-sccs-responsible-p):
* lisp/vc/vc-rcs.el (vc-rcs-responsible-p):
* lisp/vc/vc-dav.el (vc-dav-responsible-p):
* lisp/vc/vc-cvs.el (vc-cvs-responsible-p): Return a file name
instead of t when we get a match (which is what
vc-backend-for-registration expects) (bug#51800).

This fixes the regression reported in bug#54935.

Do not merge to master.

2 years agoDescribe problems with invoking Python on MS-Windows
Eli Zaretskii [Thu, 14 Apr 2022 06:17:01 +0000 (09:17 +0300)]
Describe problems with invoking Python on MS-Windows

* etc/PROBLEMS: Describe problems with running an inferior Python
interpreter due to the MS-Windows "App Execution Aliases" feature.
(Bug#54860)

2 years agoA better fix for bug#54800
Eli Zaretskii [Wed, 13 Apr 2022 13:07:40 +0000 (16:07 +0300)]
A better fix for bug#54800

* lisp/calc/calc.el (calc-align-stack-window): Improve scrolling
when windows have non-integral dimensions.

2 years agoAdd a comment about cl-concatenate
Lars Ingebrigtsen [Wed, 13 Apr 2022 04:11:43 +0000 (06:11 +0200)]
Add a comment about cl-concatenate

* lisp/emacs-lisp/cl-extra.el (cl-concatenate): Add a comment.

2 years agoRevert "Make cl-concatenate an alias of seq-concatenate"
Lars Ingebrigtsen [Wed, 13 Apr 2022 04:07:32 +0000 (06:07 +0200)]
Revert "Make cl-concatenate an alias of seq-concatenate"

This reverts commit 78f76fe16e2737b40694f82af28d17a90a21ed7b.

The commit made calls to cl-concatenate bug out, since
autoloading defalises doesn't work very well (bug#54901).

2 years agoFix 'window-text-pixel-width' when starting from display property
Eli Zaretskii [Tue, 12 Apr 2022 14:05:15 +0000 (17:05 +0300)]
Fix 'window-text-pixel-width' when starting from display property

* src/xdisp.c (Fwindow_text_pixel_size): Handle the case where
there's a display property at START, and move_it_to overshoots.
Do not merge to master.  (Bug#54862)

2 years ago* lisp/gnus/mm-encode.el (mm-default-file-encoding): Fix "when" arg
Stefan Monnier [Mon, 11 Apr 2022 18:24:23 +0000 (14:24 -0400)]
* lisp/gnus/mm-encode.el (mm-default-file-encoding): Fix "when" arg

2 years agoFix default-directory of buffers visiting files in renamed directories
Eli Zaretskii [Mon, 11 Apr 2022 11:31:04 +0000 (14:31 +0300)]
Fix default-directory of buffers visiting files in renamed directories

* lisp/dired-aux.el (dired-rename-file): Take note of whether FILE
is a directory before it is renamed, which makes it impossible to
determine if it was a directory.
(dired-rename-subdir, dired-rename-subdir-1): Revert to using
dired-in-this-tree-p instead of file-in-directory-p, for the
benefit of files that were renamed/removed, because
file-in-directory-p returns nil in those cases.  (Bug#54838)

2 years agoFix a kill-append regression
Lars Ingebrigtsen [Mon, 11 Apr 2022 10:40:50 +0000 (12:40 +0200)]
Fix a kill-append regression

* lisp/simple.el (kill-append): Fix a regression when
kill-ring-max is zero (bug#54842).

2 years ago* doc/misc/eww.texi (Advanced): Correct outdated info (bug#54839).
Eli Zaretskii [Sun, 10 Apr 2022 17:19:01 +0000 (20:19 +0300)]
* doc/misc/eww.texi (Advanced): Correct outdated info (bug#54839).

2 years agoClean up the MSDOS port
Eli Zaretskii [Sun, 10 Apr 2022 12:44:11 +0000 (15:44 +0300)]
Clean up the MSDOS port

* src/msdos.h (tcdrain): Redirect to '_dos_commit'.
(openat, fchmodat, futimens, utimensat): Add prototypes.

* msdos/sed1v2.inp (MAKE_PDUMPER_FINGERPRINT): Fix indentation, so
that Make won't consider this line a command.
($(etc)/DOC): Chdir back to ../src, since "make-docfile -d" leaves
us in a wrong directory.
* msdos/sedlibmk.inp (GL_GNULIB_GETRANDOM, GL_GNULIB_MEMMEM)
(GL_GNULIB_SIGDESCR_NP): Define to 1, to get the prototypes from
Gnulib headers.

2 years agoFix typo in next-error-find-buffer-function
Daniel Martín [Sun, 10 Apr 2022 12:31:36 +0000 (14:31 +0200)]
Fix typo in next-error-find-buffer-function

* lisp/simple.el (next-error-find-buffer-function): Fix typo
(bug#54830).

2 years agoRevert "Make shell-resync-dirs handle whitespace in directory names"
Lars Ingebrigtsen [Sun, 10 Apr 2022 11:48:46 +0000 (13:48 +0200)]
Revert "Make shell-resync-dirs handle whitespace in directory names"

This reverts commit 90e65c826fab2092ad2099d7763538194c93e021.

This change led to hangs (bug#54776).

Do not merge to master; it has been fixed in a more encompassing way there.

2 years agoFix scrolling of the stack window in Calc
Eli Zaretskii [Sat, 9 Apr 2022 13:30:23 +0000 (16:30 +0300)]
Fix scrolling of the stack window in Calc

* lisp/calc/calc.el (calc-align-stack-window): Fix off-by-one
error in computing the window-start point.  (Bug#54800)

2 years ago; * src/window.c (Fset_window_start): Clarify the effect of NOFORCE.
Eli Zaretskii [Sat, 9 Apr 2022 09:17:49 +0000 (12:17 +0300)]
; * src/window.c (Fset_window_start): Clarify the effect of NOFORCE.

2 years agoUpdate and fix instructions and scripts for updating the Web pages
Eli Zaretskii [Fri, 8 Apr 2022 18:11:16 +0000 (21:11 +0300)]
Update and fix instructions and scripts for updating the Web pages

* admin/admin.el (manual-html-fix-index-2): Support Texinfo 6.8
and later by not converting TOC menus into tables.  (Bug#49719)
* admin/upload-manuals (New directory): Invoke "cvs add" in
$webdir, to pick up the correct CVSROOT.
* admin/make-tarball.txt: Update the section about the Emacs Web
pages.

* etc/refcards/Makefile (pl-refcard.dvi): If mex.fmt cannot be
found, invoke 'mex' instead of 'tex'.

2 years agoExtend tramp-archive-test45-auto-load
Michael Albinus [Fri, 8 Apr 2022 11:12:26 +0000 (13:12 +0200)]
Extend tramp-archive-test45-auto-load

* test/lisp/net/tramp-archive-tests.el (tramp-archive-test45-auto-load):
Extend test.

2 years agoEnsure local `default-directory' in Tramp when needed
Michael Albinus [Fri, 8 Apr 2022 11:12:03 +0000 (13:12 +0200)]
Ensure local `default-directory' in Tramp when needed

* lisp/net/tramp.el (tramp-process-running-p): Ensure local
`default-directory' when calling `list-system-processes' and
`process-attributes'.

2 years agoClarify "idleness" in the ELisp manual
Eli Zaretskii [Fri, 8 Apr 2022 06:48:15 +0000 (09:48 +0300)]
Clarify "idleness" in the ELisp manual

* doc/lispref/os.texi (Idle Timers): Clarify that waiting for
input with timeout doesn't make Emacs idle.  Suggested by Ignacio
<ignaciocasso@hotmail.com>.  (Bug#54371)

2 years agoUse correct signal oldset in posix_spawn implementation
Jürgen Hötzel [Fri, 4 Mar 2022 09:08:14 +0000 (10:08 +0100)]
Use correct signal oldset in posix_spawn implementation

posix_spawn was restoring the wrong signal set, which still had
SIGCHLD and SIGINT masked, causing problems with child processes that
spawned child processes.  (Bug#54667)

See the thread ending at
https://lists.gnu.org/archive/html/emacs-devel/2022-03/msg00067.html
for more details.

* src/callproc.c (emacs_spawn): Pass oldset parameter.
(emacs_posix_spawn_init_attributes): Use correct oldset.
(emacs_posix_spawn_init): Remove intermediate function.

(cherry picked from commit 8103b060d89ac63a12c439087bd46c30da72cd97)

2 years agoFix error in tramp-archive-autoload-file-name-handler
Felix Dietrich [Thu, 7 Apr 2022 10:04:22 +0000 (12:04 +0200)]
Fix error in tramp-archive-autoload-file-name-handler

* lisp/net/tramp-archive.el (tramp-archive-autoload-file-name-handler):
Always call `tramp-autoload-file-name'.  Otherwise, when
`tramp-archive-enabled’ is nil and
`tramp-archive-autoload-file-name-handler’ is in the
`file-name-handler-alist’ results in an error “Invalid handler in
`file-name-handler-alist” once Emacs calls
`tramp-archive-autoload-file-name-handler’ with a handler that
does not expect nil.  Always returning nil is also false in
general.

Copyright-paperwork-exempt: yes

2 years agoMerge branch 'emacs-28' of git.sv.gnu.org:/srv/git/emacs into emacs-28
Michael Albinus [Thu, 7 Apr 2022 09:57:40 +0000 (11:57 +0200)]
Merge branch 'emacs-28' of git.sv.gnu.org:/srv/git/emacs into emacs-28

2 years agoCommit missing file from previous commit (Do not merge with master)
Michael Albinus [Thu, 7 Apr 2022 09:18:48 +0000 (11:18 +0200)]
Commit missing file from previous commit (Do not merge with master)

2 years agoCommit missing file from previous commit
Michael Albinus [Thu, 7 Apr 2022 09:18:48 +0000 (11:18 +0200)]
Commit missing file from previous commit

2 years agoMerge with Tramp 2.5.2.3 (Do not merge with master)
Michael Albinus [Thu, 7 Apr 2022 09:17:52 +0000 (11:17 +0200)]
Merge with Tramp 2.5.2.3 (Do not merge with master)

* doc/misc/tramp.texi (Archive file names): Explicitly say how to
open an archive with Tramp (Bug#25076).

* doc/misc/trampver.texi:
* lisp/net/trampver.el: Change version to "2.5.3-pre".

* lisp/net/tramp-adb.el (tramp-adb-handle-process-file)
* lisp/net/tramp-sh.el (tramp-sh-handle-process-file):
* lisp/net/tramp-smb.el (tramp-smb-handle-process-file):
* lisp/net/tramp-sshfs.el (tramp-sshfs-handle-process-file):
Improve implementation.  (Bug#53854)

* lisp/net/tramp-adb.el (tramp-adb-tolerate-tilde):
* lisp/net/tramp-sshfs.el (tramp-sshfs-tolerate-tilde):
New defuns.  Advice `shell-mode' with them.

* lisp/net/tramp.el (tramp-register-autoload-file-name-handlers):
* lisp/net/tramp-archive.el (tramp-register-archive-file-name-handler):
Check, whether the real file name handler is already registered.
rules.  (Bug#54542)

* lisp/net/tramp.el (tramp-autoload-file-name-handler)
(tramp-register-autoload-file-name-handlers)
(tramp-unload-file-name-handlers, tramp-unload-tramp):
* lisp/net/tramp-archive.el (tramp-archive-autoload-file-name-regexp)
(tramp-archive-autoload-file-name-handler)
(tramp-register-archive-file-name-handler):
Add `tramp-autoload' property.

* lisp/net/tramp-crypt.el (tramp-crypt-file-name-handler-alist):
* lisp/net/tramp-rclone.el (tramp-rclone-file-name-handler-alist):
* lisp/net/tramp-sudoedit.el (tramp-sudoedit-file-name-handler-alist):
* lisp/net/tramp-sshfs.el (tramp-sshfs-file-name-handler-alist):
Use `tramp-handle-file-notify-add-watch',
`tramp-handle-file-notify-rm-watch' and
`tramp-handle-file-notify-valid-p'.

* lisp/net/tramp-crypt.el (tramp-crypt-file-name-handler-alist):
Use `tramp-handle-insert-file-contents'.

* lisp/net/tramp-gvfs.el (tramp-gvfs-maybe-open-connection):
* lisp/net/tramp-rclone.el (tramp-rclone-maybe-open-connection):
* lisp/net/lisp/net/tramp-sshfs.el (tramp-sshfs-maybe-open-connection):
* tramp-sudoedit.el (tramp-sudoedit-maybe-open-connection): Do not
set "lock-pid" connection-property.
(tramp-sudoedit-handle-delete-file): Use "rm -f".

* lisp/net/tramp-gvfs.el (tramp-gvfs-handle-file-executable-p):
* lisp/net/tramp-sh.el (tramp-sh-handle-file-executable-p):
Check also for setuid/setgid bit.
(tramp-gvfs-handle-expand-file-name):
Respect `tramp-tolerate-tilde'.

* lisp/net/tramp-sh.el (tramp-sh-handle-insert-directory):
* lisp/net/tramp-smb.el (tramp-smb-handle-insert-directory):
Do not modify disk space information when
`dired--insert-disk-space' is available.  (Bug#54512)

* lisp/net/tramp-sh.el (tramp-maybe-open-connection): Extend suppression
(tramp-get-remote-dev-tty): New defun.
(tramp-sh-handle-make-process): Use it.

* lisp/net/tramp-sshfs.el (tramp-methods) <sshfs>:
Add "-t -t" to `tramp-login-args'.
Add "-o dir_cache=no" to `tramp-mount-args'.  (Bug#54126)
Add "-o transform_symlinks" to `tramp-mount-args'.
(tramp-sshfs-file-name-handler-alist):
Use `tramp-sshfs-handle-file-writable-p'.
(tramp-sshfs-handle-file-writable-p): New defun.  (Bug#54130)
(tramp-sshfs-handle-write-region): Set file modification time.
(Bug#54016)
(tramp-sshfs-file-name-handler-alist):
Use `tramp-sshfs-handle-set-file-times'.
(tramp-sshfs-handle-set-file-times): New defun.

* test/lisp/net/tramp-tests.el (tramp--test-expensive-test-p):
Rename from `tramp--test-expensive-test'.  Make it a defun.  Adapt
all callees.
(tramp-test07-file-exists-p, tramp-test14-delete-directory)
(tramp-test18-file-attributes, tramp-test20-file-modes)
(tramp-test28-process-file, tramp-test29-start-file-process)
(tramp-test30-make-process, tramp-test32-shell-command)
(tramp-test33-environment-variables, tramp--test-check-files)
(tramp--test-special-characters, tramp-test46-unload): Adapt tests.
(tramp-test39-detect-external-change): New test.
(tramp-test29-start-file-process)
(tramp--test--deftest-direct-async-process)
(tramp-test30-make-process, tramp-test31-interrupt-process)
(tramp-test34-explicit-shell-file-name)
(tramp-test44-asynchronous-requests):
Add :tramp-asynchronous-processes tag.
(tramp--test-asynchronous-processes-p): New defun.
(tramp--test-hpux-p, tramp--test-macos-p): Protect against errors.

2 years agocl-generic.el: Fix bug#46722
Stefan Monnier [Wed, 5 Jan 2022 19:28:08 +0000 (14:28 -0500)]
cl-generic.el: Fix bug#46722

Fix longstanding bug due to unexpected interference via side-effect.

* lisp/emacs-lisp/cl-generic.el (cl--generic-get-dispatcher):
Copy the `dispatch` arg before storing it into the hash-table.

Backport from `master` (cherrypick from commit 61f8f7f68f).

2 years agoFix fallout from lexical-binding in vhdl-mode.el
Eli Zaretskii [Tue, 5 Apr 2022 18:15:32 +0000 (21:15 +0300)]
Fix fallout from lexical-binding in vhdl-mode.el

* lisp/progmodes/vhdl-mode.el (vhdl-update-sensitivity-list): Fix
production of a list with embedded function calls.  (Bug#54730)

2 years ago; Prepare the release branch for Emacs-28.2 development
Eli Zaretskii [Sun, 3 Apr 2022 13:09:11 +0000 (16:09 +0300)]
; Prepare the release branch for Emacs-28.2 development

* README:
* configure.ac:
* nt/README.W32:
* msdos/sed2v2.inp: Bump Emacs version to 28.1.50.

* etc/NEWS: Add Emacs-28.2 sections.

2 years agoUpdate logs and HISTORY for Emacs 28.1 emacs-28.1
Eli Zaretskii [Sun, 3 Apr 2022 12:26:02 +0000 (08:26 -0400)]
Update logs and HISTORY for Emacs 28.1

* ChangeLog.3:
* etc/HISTORY:
* etc/AUTHORS: Update for Emacs 28.1 release.

2 years agoBump Emacs version to 28.1
Eli Zaretskii [Sun, 3 Apr 2022 11:38:15 +0000 (07:38 -0400)]
Bump Emacs version to 28.1

* README:
* configure.ac:
* nt/README.W32:
* msdos/sed2v2.inp: Bump Emacs version to 28.1

2 years ago; * etc/NEWS: Remove temporary notes and marks.
Eli Zaretskii [Sun, 3 Apr 2022 11:16:10 +0000 (07:16 -0400)]
; * etc/NEWS: Remove temporary notes and marks.

2 years ago; * lisp/font-lock.el (font-lock-keywords): Doc fix.
Eli Zaretskii [Sat, 2 Apr 2022 10:20:56 +0000 (13:20 +0300)]
; * lisp/font-lock.el (font-lock-keywords): Doc fix.

2 years agodired: implement feature from 7b50ed553f differently
Tassilo Horn [Wed, 30 Mar 2022 17:49:01 +0000 (19:49 +0200)]
dired: implement feature from 7b50ed553f differently

* lisp/dired.el (dired-buffers-for-dir): Restore to emacs-27 version.
(dired-buffers-for-dir-or-subdir): New function.
(dired-clean-up-after-deletion): Use dired-buffers-for-dir-or-subdir
instead dired-buffers-for-dir.

2 years agoFix regression in 'dired-buffers-for-dir'
Eli Zaretskii [Wed, 30 Mar 2022 13:21:02 +0000 (16:21 +0300)]
Fix regression in 'dired-buffers-for-dir'

* lisp/dired.el (dired-buffers-for-dir): Fix inadvertently swapped
arguments.  (Bug#54636)

2 years ago* lisp/desktop.el (desktop-read): Clarify warning text.
Eli Zaretskii [Sun, 27 Mar 2022 05:10:27 +0000 (08:10 +0300)]
* lisp/desktop.el (desktop-read): Clarify warning text.

2 years ago* doc/emacs/anti.texi (Antinews): Unannounce removal of Motif.
Po Lu [Sat, 26 Mar 2022 06:46:00 +0000 (14:46 +0800)]
* doc/emacs/anti.texi (Antinews): Unannounce removal of Motif.

2 years agoFix eshell-explicit-command-char doc string typo
Lars Ingebrigtsen [Fri, 25 Mar 2022 18:01:51 +0000 (19:01 +0100)]
Fix eshell-explicit-command-char doc string typo

* lisp/eshell/esh-ext.el (eshell-explicit-command-char): Fix typo
in doc string (bug#54567).

2 years agoClarify the description of "selected tags table"
Eli Zaretskii [Thu, 24 Mar 2022 15:22:43 +0000 (17:22 +0200)]
Clarify the description of "selected tags table"

* doc/emacs/maintaining.texi (Select Tags Table): Clarify the
distinction between the "selected tags table" and the "current
list of tags tables".  (Bug#54543)

2 years agoAdd notes about command modes and nativecomp interaction
Lars Ingebrigtsen [Mon, 21 Mar 2022 14:53:25 +0000 (15:53 +0100)]
Add notes about command modes and nativecomp interaction

* doc/lispref/commands.texi (Command Modes): Note interaction with
native-compile (bug#54437).

* src/data.c: Add comment about not being supported.

Do not merge to master.

2 years agoUpdate to Org 9.5.2-25-gaf6f12
Kyle Meyer [Mon, 21 Mar 2022 01:31:32 +0000 (21:31 -0400)]
Update to Org 9.5.2-25-gaf6f12

2 years agoImprove doc strings of read-char-from-minibuffer-insert-* commands
Eli Zaretskii [Sun, 20 Mar 2022 16:21:44 +0000 (18:21 +0200)]
Improve doc strings of read-char-from-minibuffer-insert-* commands

* lisp/subr.el (read-char-from-minibuffer-insert-char)
(read-char-from-minibuffer-insert-other): Clarify the doc strings.
(Bug#54479)

2 years agoFix region highlight in non-selected windows
Eli Zaretskii [Sat, 19 Mar 2022 07:19:53 +0000 (09:19 +0200)]
Fix region highlight in non-selected windows

* src/xdisp.c (prepare_menu_bars): Include in the windows passed
to pre-redisplay-functions windows whose point was moved from the
last recorded position.  (Bug#54450)

2 years agoFix a regression in 'decipher-digram-list'
Eli Zaretskii [Fri, 18 Mar 2022 11:54:46 +0000 (13:54 +0200)]
Fix a regression in 'decipher-digram-list'

* lisp/play/decipher.el (decipher-stats-buffer): Don't assume the
statistics buffer always exists.  (Bug#54443)

2 years agoImprove documentation of bookmark default sorting
Karl Fogel [Fri, 18 Mar 2022 02:18:26 +0000 (21:18 -0500)]
Improve documentation of bookmark default sorting

* lisp/bookmark.el (bookmark-alist, bookmark-store,
  bookmark-maybe-sort-alist): Update doc strings and comments.

2 years ago; * doc/lispref/display.texi (Overlay Arrow): More accurate text.
Eli Zaretskii [Thu, 17 Mar 2022 12:55:59 +0000 (14:55 +0200)]
; * doc/lispref/display.texi (Overlay Arrow): More accurate text.

2 years ago* doc/misc/transient.texi: Fix @dircategory to "Emacs misc features" for dir.
Juri Linkov [Tue, 15 Mar 2022 17:28:50 +0000 (19:28 +0200)]
* doc/misc/transient.texi: Fix @dircategory to "Emacs misc features" for dir.

2 years agoFix evaluation of negated argument predicates in Eshell
Jim Porter [Sun, 13 Mar 2022 14:36:37 +0000 (15:36 +0100)]
Fix evaluation of negated argument predicates in Eshell

* lisp/eshell/em-pred.el (eshell-add-pred-func): Let-bind 'pred' so
the lambdas see the original value (bug#54369).

Committed on the wrong branch.

Do not merge to master.

2 years ago; * admin/make-tarball.txt: Minor updates.
Eli Zaretskii [Sun, 13 Mar 2022 07:53:59 +0000 (09:53 +0200)]
; * admin/make-tarball.txt: Minor updates.

2 years agoEmacs pretest 28.0.92 emacs-28.0.92
Eli Zaretskii [Sat, 12 Mar 2022 09:44:46 +0000 (04:44 -0500)]
Emacs pretest 28.0.92

* README:
* configure.ac:
* nt/README.W32:
* msdos/sed2v2.inp: Bump Emacs version to 28.0.92.

* etc/AUTHORS:
* lisp/ldefs-boot.el: Update for pretest 28.0.92.

* ChangeLog.3: Regenerate.

2 years ago; * admin/authors.el (authors-canonical-file-name): Remove debug leftover.
Eli Zaretskii [Sat, 12 Mar 2022 08:32:47 +0000 (03:32 -0500)]
; * admin/authors.el (authors-canonical-file-name): Remove debug leftover.

2 years ago; Fix data structures in authors.el
Eli Zaretskii [Sat, 12 Mar 2022 08:28:45 +0000 (03:28 -0500)]
; Fix data structures in authors.el

* admin/authors.el (authors-aliases, authors-renamed-files-alist):
Update and correct the databases.
(authors-renamed-files-alist): Add commentary explaining how to
add entries for renamed/moved files.
(authors-canonical-file-name): Clarify the semantics of the
arguments.

2 years agoFix regression in 'custom-prompt-customize-unsaved-options'
Eli Zaretskii [Thu, 10 Mar 2022 18:26:13 +0000 (20:26 +0200)]
Fix regression in 'custom-prompt-customize-unsaved-options'

* lisp/cus-edit.el (custom-prompt-customize-unsaved-options):
Don't depend on the value returned by 'customize-unsaved'.  Fix
the doc string.  Patch by Sebastian Miele <iota@whxvd.name>.
(Bug#54329)

2 years agoImprove documentation of 'map-charset-chars'
Eli Zaretskii [Thu, 10 Mar 2022 07:29:29 +0000 (09:29 +0200)]
Improve documentation of 'map-charset-chars'

* doc/lispref/nonascii.texi (Character Sets):
* src/charset.c (Fmap_charset_chars): Clarify the codepoint issue
in using 'map-charset-chars'.

2 years agoAvoid assertion violations in 'bidi_resolve_brackets'
Eli Zaretskii [Tue, 8 Mar 2022 13:35:39 +0000 (15:35 +0200)]
Avoid assertion violations in 'bidi_resolve_brackets'

* src/bidi.c (bidi_resolve_brackets): Move assertion to where it
really matters.  (Bug#54295)

2 years agoFix which-func-update doc string
Lars Ingebrigtsen [Mon, 7 Mar 2022 15:19:19 +0000 (16:19 +0100)]
Fix which-func-update doc string

* lisp/progmodes/which-func.el (which-func-update): Make the doc
string match the code (bug#54288).

2 years agoImprove wording of 'dired-jump's description
Eli Zaretskii [Mon, 7 Mar 2022 12:38:01 +0000 (14:38 +0200)]
Improve wording of 'dired-jump's description

* doc/emacs/dired.texi (Dired Enter): Clarify wording.  Reported
by Natalie <batalie@riseup.net>.

2 years agoAdd a comment for previous browse-url-of-dired-file change
Lars Ingebrigtsen [Mon, 7 Mar 2022 04:15:58 +0000 (05:15 +0100)]
Add a comment for previous browse-url-of-dired-file change

* lisp/net/browse-url.el (browse-url-of-dired-file): Add a comment
for previous change.

2 years agoRestore documented Emacs 27.2 behaviour of browse-url-of-dired-file
Lars Ingebrigtsen [Mon, 7 Mar 2022 04:13:19 +0000 (05:13 +0100)]
Restore documented Emacs 27.2 behaviour of browse-url-of-dired-file

* lisp/net/browse-url.el (browse-url-of-dired-file): Restore the
documented behaviour -- open a web browser instead of passing to
the various handlers.

2 years agoUpdate to Org 9.5.2-24-g668205
Kyle Meyer [Mon, 7 Mar 2022 01:18:26 +0000 (20:18 -0500)]
Update to Org 9.5.2-24-g668205

2 years ago* lib-src/seccomp-filter.c (main): Use faccessat2 only if defined.
Andreas Schwab [Sat, 5 Mar 2022 12:44:08 +0000 (13:44 +0100)]
* lib-src/seccomp-filter.c (main): Use faccessat2 only if defined.

2 years agoFix regression in derived-mode-init-mode-variables
Lars Ingebrigtsen [Fri, 4 Mar 2022 15:19:42 +0000 (16:19 +0100)]
Fix regression in derived-mode-init-mode-variables

* lisp/emacs-lisp/derived.el (derived-mode-init-mode-variables):
Fix regression caused by lexical-binding derived.el (bug#54240).

2 years agoAvoid crashes when fringe bitmaps are defined in daemon mode
Eli Zaretskii [Thu, 3 Mar 2022 18:31:33 +0000 (20:31 +0200)]
Avoid crashes when fringe bitmaps are defined in daemon mode

* src/dispextern.h (gui_define_fringe_bitmap): Add prototype.
(max_used_fringe_bitmap): Add declaration.
* src/fringe.c (gui_define_fringe_bitmap): New function.
* src/w32term.c (w32_draw_fringe_bitmap):
* src/xterm.c (x_draw_fringe_bitmap) [USE_CAIRO]: Call
'gui_define_fringe_bitmap' if the terminal-specific bitmap data is
not available when a fringe bitmap is about to be drawn.  Don't
try to draw a bitmap that is not known to fringe.c.  (Bug#54183)

2 years agoOne more fix of the BPA implementation
Eli Zaretskii [Thu, 3 Mar 2022 13:53:04 +0000 (15:53 +0200)]
One more fix of the BPA implementation

* src/bidi.c (bidi_find_bracket_pairs): Disable BPA optimization
when there are no strong directional characters inside the
bracketed pair.  (Bug#54219)

2 years agoFix handling of brackets in BPA
Eli Zaretskii [Thu, 3 Mar 2022 12:46:20 +0000 (14:46 +0200)]
Fix handling of brackets in BPA

* src/bidi.c (bidi_resolve_brackets): Fix implementation of UBA's
N0 rule when there are no strong directional characters inside the
bracketed pair.  (Bug#54219)

2 years agoCorrect etc/NEWS entry about bitmapped fonts
Po Lu [Wed, 2 Mar 2022 08:22:18 +0000 (09:22 +0100)]
Correct etc/NEWS entry about bitmapped fonts

* etc/NEWS: Don't say that bitmap font issues are due to Pango, that's
not accurate.

2 years ago; * doc/misc/eshell.texi (Dollars Expansion): Fix markup.
Eli Zaretskii [Tue, 1 Mar 2022 13:08:38 +0000 (15:08 +0200)]
; * doc/misc/eshell.texi (Dollars Expansion): Fix markup.

2 years agoImprove/correct documentation about Eshell variable expansion
Jim Porter [Sun, 27 Feb 2022 21:20:51 +0000 (13:20 -0800)]
Improve/correct documentation about Eshell variable expansion

* lisp/eshell/esh-var.el: Correct documentation comment.
(eshell-parse-variable-ref): Correct docstring.

* doc/misc/eshell.texi (Dollars Expansion): Add documentation for
$"var"/$'var' and $<command> syntaxes.

2 years agoPartially revert b03f74e0f2a578b1580e8b1c368665850ee7f808
Jim Porter [Mon, 28 Feb 2022 17:31:22 +0000 (09:31 -0800)]
Partially revert b03f74e0f2a578b1580e8b1c368665850ee7f808

That commit regressed '$<command>' forms in Eshell, due to a
limitation/bug in how 'eshell-do-eval' works.  This fixes
bug#54190.

* lisp/eshell/esh-var.el (eshell-parse-variable-ref): Quote a lambda.

* test/lisp/eshell/eshell-tests.el (eshell-test/interp-temp-cmd):
New test.

2 years agoBackport: Port pre-commit hook to Git 2.35.0
Paul Eggert [Wed, 23 Feb 2022 19:29:56 +0000 (11:29 -0800)]
Backport: Port pre-commit hook to Git 2.35.0

* build-aux/git-hooks/pre-commit: Use LC_ALL=C grep -E instead of
sane_egrep (removed in Git 2.35.0).

(cherry picked from commit b8a96f055624f86fe965a0d1b7b2495b2db80e63)

2 years agoFix :tag for eol in tab-first-completion
Lars Ingebrigtsen [Mon, 28 Feb 2022 09:14:03 +0000 (10:14 +0100)]
Fix :tag for eol in tab-first-completion

* lisp/indent.el (tab-first-completion): Fix the :tag description
(bug#54179).

2 years agoUpdate to Org 9.5.2-22-g33543d
Kyle Meyer [Mon, 28 Feb 2022 05:11:01 +0000 (00:11 -0500)]
Update to Org 9.5.2-22-g33543d

2 years ago; * lisp/help.el (with-help-window): Doc fix. (Bug#54170)
Eli Zaretskii [Sun, 27 Feb 2022 13:54:27 +0000 (15:54 +0200)]
; * lisp/help.el (with-help-window): Doc fix.  (Bug#54170)

2 years agoAdd explicit '--no-heading' for ripgrep
Dmitry Gutov [Sun, 27 Feb 2022 13:28:04 +0000 (15:28 +0200)]
Add explicit '--no-heading' for ripgrep

* lisp/progmodes/xref.el (xref-search-program-alist):
Add explicit '--no-heading' for ripgrep (bug#54177).

2 years agoFollow OpenSSH changes in Tramp
Michael Albinus [Sat, 26 Feb 2022 11:51:26 +0000 (12:51 +0100)]
Follow OpenSSH changes in Tramp

* lisp/net/tramp-sh.el (tramp-ssh-controlmaster-options):
Reimplement.  OpenSSH has changed its diagnostics messages.

2 years agoDocument better how to reset attributes of faces for new frames
Eli Zaretskii [Sat, 26 Feb 2022 07:41:05 +0000 (09:41 +0200)]
Document better how to reset attributes of faces for new frames

* doc/lispref/display.texi (Attribute Functions):
* lisp/faces.el (set-face-attribute): Explain how to reset an
attribute's value for future frames.  (Bug#54156)

2 years ago* lisp/net/tramp-sh.el (tramp-ssh-controlmaster-options): Adapt test.
Michael Albinus [Fri, 25 Feb 2022 09:11:40 +0000 (10:11 +0100)]
* lisp/net/tramp-sh.el (tramp-ssh-controlmaster-options): Adapt test.

2 years agoMention flyspell-prog-mode in flyspell-mode doc string
Lars Ingebrigtsen [Thu, 24 Feb 2022 09:10:40 +0000 (10:10 +0100)]
Mention flyspell-prog-mode in flyspell-mode doc string

* lisp/textmodes/flyspell.el (flyspell-mode): Mention
flyspell-prog-mode (bug#54131).

2 years agoReword face-remap-add-relative manual entry
Lars Ingebrigtsen [Wed, 23 Feb 2022 11:58:37 +0000 (12:58 +0100)]
Reword face-remap-add-relative manual entry

* doc/lispref/display.texi (Face Remapping): Clarify the
face-remap-add-relative (bug#54114).

2 years agoFix indexing of module functions that return enumeration types.
Philipp Stephani [Tue, 22 Feb 2022 20:39:32 +0000 (21:39 +0100)]
Fix indexing of module functions that return enumeration types.

Return types that consist of more than one word need to be enclosed in
braces, see Info node `(texinfo) Typed Functions'.  Otherwise they are
indexed incorrectly.

* doc/lispref/internals.texi (Module Misc, Module Nonlocal): Enclose
multi-word return types in braces.

2 years ago* doc/misc/transient.texi (Other Options): Fix a @ref. (Bug#54108)
Eli Zaretskii [Tue, 22 Feb 2022 14:37:22 +0000 (16:37 +0200)]
* doc/misc/transient.texi (Other Options): Fix a @ref.  (Bug#54108)

2 years agotramp.texi texinfo 4.13 compatibility
Glenn Morris [Tue, 22 Feb 2022 14:08:07 +0000 (14:08 +0000)]
tramp.texi texinfo 4.13 compatibility

* doc/misc/tramp.texi (Frequently Asked Questions):
Restore compatibility with Texinfo < 5.

2 years agoExplain "Tramp" spelling in its manual
Michael Albinus [Tue, 22 Feb 2022 13:45:59 +0000 (14:45 +0100)]
Explain "Tramp" spelling in its manual

* doc/misc/tramp.texi (Frequently Asked Questions):
Explain "Tramp" spelling.

2 years agoFix 'display-line-numbers-mode' in hide-show buffers
Eli Zaretskii [Mon, 21 Feb 2022 20:12:57 +0000 (22:12 +0200)]
Fix 'display-line-numbers-mode' in hide-show buffers

* src/xdisp.c (redisplay_internal): Disable redisplay
optimizations that consider just the current line, when
'display-line-numbers-mode' is turned on in the buffer.
(Bug#54091)

2 years agoDon't check whether a deleted window is deletable (Bug#54028)
Martin Rudalics [Mon, 21 Feb 2022 15:46:23 +0000 (16:46 +0100)]
Don't check whether a deleted window is deletable (Bug#54028)

* lisp/window.el (window-state-put): Make sure window is live
before calling 'window-deletable-p' on it (Bug#54028).

2 years agoA friendlier error message from image-mode in an empty buffer
Eli Zaretskii [Mon, 21 Feb 2022 12:51:37 +0000 (14:51 +0200)]
A friendlier error message from image-mode in an empty buffer

* lisp/image-mode.el (image-mode): Handle the case where the empty
buffer doesn't visit a file  (Bug#54084)

2 years agoUpdate to Org 9.5.2-17-gea6b74
Kyle Meyer [Sun, 20 Feb 2022 19:04:28 +0000 (14:04 -0500)]
Update to Org 9.5.2-17-gea6b74

2 years ago; Don't reference obsolete variables in edebug.el
Raffael Stocker [Sun, 20 Feb 2022 15:13:46 +0000 (16:13 +0100)]
; Don't reference obsolete variables in edebug.el

* lisp/emacs-lisp/edebug.el (edebug-mode, edebug-eval-mode):
Don't reference obsolete variables in the doc strings.
(Bug#54070)

2 years ago; * doc/emacs/files.texi (Comparing Files): Fix a reference.
Philipp Stephani [Fri, 18 Feb 2022 17:53:49 +0000 (18:53 +0100)]
; * doc/emacs/files.texi (Comparing Files): Fix a reference.

2 years ago; Fix a typo in filesets.el's doc string
Eli Zaretskii [Fri, 18 Feb 2022 13:46:57 +0000 (15:46 +0200)]
; Fix a typo in filesets.el's doc string

* lisp/filesets.el (filesets-remove-buffer, filesets-add-buffer):
Doc fixes.  Reported by Иванов Дмитрий <d.ivanov@1001tur.ru>.