]> git.eshelyaron.com Git - emacs.git/log
emacs.git
4 years ago`g' in *Help* doesn't require confirmation
Lars Ingebrigtsen [Tue, 27 Oct 2020 07:23:31 +0000 (08:23 +0100)]
`g' in *Help* doesn't require confirmation

* lisp/help-mode.el (help-mode-revert-buffer): Don't require
confirmation before reverting (bug#44202).  This mimics how most
other non-file reverting functions work.

4 years agoDefine backtab in text fields in eww
Nicolas Graner [Tue, 27 Oct 2020 07:15:22 +0000 (08:15 +0100)]
Define backtab in text fields in eww

* lisp/net/eww.el (eww-text-map):
(eww-textarea-map): Define backtab, as in the main mode map
(bug#44247).

4 years ago; * etc/NEWS: Fix a recent change.
Eli Zaretskii [Tue, 27 Oct 2020 03:25:17 +0000 (05:25 +0200)]
; * etc/NEWS: Fix a recent change.

4 years ago* lisp/mail/mail-prsvr.el: Use lexical-binding.
Stefan Kangas [Tue, 27 Oct 2020 02:53:02 +0000 (03:53 +0100)]
* lisp/mail/mail-prsvr.el: Use lexical-binding.

4 years ago* lisp/mail/mail-parse.el: Use lexical-binding.
Stefan Kangas [Tue, 27 Oct 2020 02:51:57 +0000 (03:51 +0100)]
* lisp/mail/mail-parse.el: Use lexical-binding.

4 years agoAllow pcomplete/gzip to complete on files in subdirectories
Stefan Kangas [Tue, 27 Oct 2020 02:09:44 +0000 (03:09 +0100)]
Allow pcomplete/gzip to complete on files in subdirectories

* lisp/pcmpl-gnu.el (pcmpl-gnu-zipped-files): Allow "gzip" to complete
on files in subdirectories.  (Bug#30271)

4 years agoAdd some missing docstrings in cua-rect.el
Boruch Baum [Tue, 27 Oct 2020 01:30:29 +0000 (02:30 +0100)]
Add some missing docstrings in cua-rect.el

* lisp/emulation/cua-rect.el (cua--rectangle)
(cua--last-rectangle, cua--restored-rectangle)
(cua--rectangle-overlays, cua--rectangle-operation)
(cua--tabify-start, cua--tabify-start, cua--insert-rectangle):
Add docstrings, in several cases by converting existing
comments.  (Bug#30085)
(cua--last-killed-rectangle): Update comment.

4 years agoUse lexical-binding in tool-bar.el
Stefan Kangas [Tue, 27 Oct 2020 00:29:43 +0000 (01:29 +0100)]
Use lexical-binding in tool-bar.el

* lisp/tool-bar.el: Use lexical-binding.
(tool-bar-add-item, tool-bar-add-item-from-menu): Quote function
symbols as such.

4 years agoDon't use obsolete variable write-contents-hooks
Stefan Kangas [Mon, 26 Oct 2020 23:49:28 +0000 (00:49 +0100)]
Don't use obsolete variable write-contents-hooks

* lisp/mh-e/mh-show.el (mh-display-msg):
* lisp/textmodes/rst.el: Don't use obsolete variable
write-contents-hooks.
Problem reported by Stefan Monnier <monnier@iro.umontreal.ca>.

4 years agoRemove XEmacs compat code from hashcash.el
Stefan Kangas [Mon, 26 Oct 2020 23:35:46 +0000 (00:35 +0100)]
Remove XEmacs compat code from hashcash.el

* lisp/mail/hashcash.el (hashcash-point-at-bol)
(hashcash-point-at-eol): Make obsolete.
(hashcash-token-substring): Don't use the above now obsolete aliases.

4 years agoFix an unbound variable in html skeletons
Stephen Berman [Mon, 26 Oct 2020 21:21:07 +0000 (22:21 +0100)]
Fix an unbound variable in html skeletons

* lisp/skeleton.el (skeleton-internal-list): Fix an unbound
variable in html skeletons (bug#44157).

4 years agovc-git-root: Remove unnecessary caching
Dmitry Gutov [Mon, 26 Oct 2020 21:01:08 +0000 (23:01 +0200)]
vc-git-root: Remove unnecessary caching

* lisp/vc/vc-git.el (vc-git-root): Simplify (bug#42966).

4 years agoMake vc-responsible-backend choose the most specific backend
Lars Ingebrigtsen [Mon, 26 Oct 2020 20:10:36 +0000 (21:10 +0100)]
Make vc-responsible-backend choose the most specific backend

* lisp/vc/vc.el (vc-responsible-backend): Search through all the
VC backends instead of the first one, and choose the one that's
most specific (bug#42966).

4 years agoFix time-test error on machines with mail
Lars Ingebrigtsen [Mon, 26 Oct 2020 20:23:50 +0000 (21:23 +0100)]
Fix time-test error on machines with mail

* test/lisp/time-tests.el (time-tests-display-time-update): There
may be mail on the machine (bug#44241).

4 years agoMake the -modes variable autoloaded
Lars Ingebrigtsen [Mon, 26 Oct 2020 19:44:15 +0000 (20:44 +0100)]
Make the -modes variable autoloaded

* lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode):
Make the -modes variable be autoloaded.

4 years ago; * etc/NEWS: Fix a recently-added entry.
Eli Zaretskii [Mon, 26 Oct 2020 18:38:42 +0000 (20:38 +0200)]
; * etc/NEWS: Fix a recently-added entry.

4 years agoTweak where global-display-fill-column-indicator-modes is on
Lars Ingebrigtsen [Mon, 26 Oct 2020 18:15:30 +0000 (19:15 +0100)]
Tweak where global-display-fill-column-indicator-modes is on

* lisp/display-fill-column-indicator.el
(global-display-fill-column-indicator-mode): Don't switch on in
special-mode buffers (bug#44232).

4 years agoImplement a :predicate parameter for globalized minor modes
Lars Ingebrigtsen [Mon, 26 Oct 2020 18:13:14 +0000 (19:13 +0100)]
Implement a :predicate parameter for globalized minor modes

* doc/lispref/modes.texi (Defining Minor Modes): Describe the new
:predicate keyword (bug#44232).

* lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode):
Allow a new :predicate keyword.
(easy-mmode--globalized-predicate-p): New function.

4 years agoMake delete-selection-helper more resilient
Lars Ingebrigtsen [Mon, 26 Oct 2020 14:14:53 +0000 (15:14 +0100)]
Make delete-selection-helper more resilient

* lisp/delsel.el (delete-selection-helper): Don't bug out on `C-g'
(bug#40357).

4 years agoTweak how shortdocs are displayed
Lars Ingebrigtsen [Mon, 26 Oct 2020 12:12:34 +0000 (13:12 +0100)]
Tweak how shortdocs are displayed

* lisp/emacs-lisp/shortdoc.el (shortdoc-example): Removed.
(shortdoc-section): Remove colors.
(shortdoc-separator): New face.
(shortdoc-display-group, shortdoc--display-function): Don't use
background colours, because that makes things harder to read.
Separate with a horizontal line instead.

4 years agoMerge branch 'master' of git.savannah.gnu.org:/srv/git/emacs
Eli Zaretskii [Mon, 26 Oct 2020 16:15:37 +0000 (18:15 +0200)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

4 years agoAvoid segfaults due to using fonts that were closed
Eli Zaretskii [Mon, 26 Oct 2020 16:14:32 +0000 (18:14 +0200)]
Avoid segfaults due to using fonts that were closed

* src/composite.c (composition_gstring_cache_clear_font): New
function.
* src/composite.h (composition_gstring_cache_clear_font): Add
prototype.
* src/font.c (font_clear_cache): When we are about to close a
font, remove from the gstring cache any lgstring that uses this
font.  (Bug#42943)

4 years agoRevert "Don't consider play-sound-file to be a 'safe' function (bug#44018)"
Mattias Engdegård [Mon, 26 Oct 2020 16:10:06 +0000 (17:10 +0100)]
Revert "Don't consider play-sound-file to be a 'safe' function (bug#44018)"

This reverts commit cdb3c9d662c772ce25ea4d803eccd2c9e6a6ae99.

4 years agoDon't consider play-sound-file to be a 'safe' function (bug#44018)
Mattias Engdegård [Mon, 26 Oct 2020 11:40:51 +0000 (12:40 +0100)]
Don't consider play-sound-file to be a 'safe' function (bug#44018)

While there are currently no known security holes in play-sound-file,
the attack surface is considerable and historically audio file
processing has had more than its share of security problems; the
benefit to risk ratio is low.

* lisp/emacs-lisp/unsafep.el: Don't mark play-sound-file as safe.

4 years agoAdd section "Replacing Match" to the regexp shortdoc group
Stefan Kangas [Sun, 25 Oct 2020 18:18:27 +0000 (19:18 +0100)]
Add section "Replacing Match" to the regexp shortdoc group

* lisp/emacs-lisp/shortdoc.el (regexp): New section "Replacing Match".

4 years agoRemove some Emacs 19 compat code and references
Stefan Kangas [Tue, 20 Oct 2020 17:31:40 +0000 (19:31 +0200)]
Remove some Emacs 19 compat code and references

* lisp/progmodes/sql.el:
* lisp/mh-e/mh-show.el (mh-display-msg): Remove Emacs 19 compat code.
* lisp/emacs-lisp/edebug.el (edebug-mark-marker): Make into
obsolete alias for mark-marker.
(edebug--display-1, edebug-bounce-point)
(edebug-outside-excursion): Adjust callers.
* lisp/net/snmp-mode.el:
* lisp/forms.el: Remove references to Emacs 19.
(forms-use-text-properties): Doc fix.

4 years agoImprove support for shaping Egyptian Hieroglyphs
Eli Zaretskii [Sun, 25 Oct 2020 16:05:37 +0000 (18:05 +0200)]
Improve support for shaping Egyptian Hieroglyphs

* src/composite.c (composition_gstring_lookup_cache): Renamed from
gstring_lookup_cache and made external.  All callers changed.
* src/composite.h (composition_gstring_lookup_cache): Add
prototype.
* src/font.c (Ffont_shape_gstring): Call
composition_gstring_lookup_cache and return the cached composition
if it is already in the cache.

* lisp/language/misc-lang.el (egyptian-shape-grouping): New
function.
(composition-function-table): Use egyptian-shape-grouping in
setting up compositions for Egyptian Hieroglyphs.  Fix the
composition setup for horizontal and vertical joiners.

4 years agoBetter file name in dynvars-check example
Mattias Engdegård [Sun, 25 Oct 2020 15:41:31 +0000 (16:41 +0100)]
Better file name in dynvars-check example

* doc/lispref/variables.texi (Converting to Lexical Binding):
Don't suggest an aggregate file name that matches the glob used when
generating it.

4 years agoFix syntax error in message-add-openpgp-header
Lars Ingebrigtsen [Sun, 25 Oct 2020 14:16:05 +0000 (15:16 +0100)]
Fix syntax error in message-add-openpgp-header

* lisp/gnus/message.el (message-add-openpgp-header): Remove
redundant (and syntactically wrong) check.

4 years agoFix problem when replacing the final char in checkdoc
Lars Ingebrigtsen [Sun, 25 Oct 2020 13:34:47 +0000 (14:34 +0100)]
Fix problem when replacing the final char in checkdoc

* lisp/emacs-lisp/checkdoc.el (checkdoc-autofix-ask-replace):
Ensure that the end-of-doc-string marker is really at the end,
even if we replace the final " char in the string (bug#44201).

4 years agoRevert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for XRef.
Philipp Stephani [Sun, 25 Oct 2020 10:24:11 +0000 (11:24 +0100)]
Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for XRef.

XRef supports Emacs versions back to Emacs 26.3, so it can’t use newer
functions such as ‘ert-resource-directory’.

* test/lisp/progmodes/xref-tests.el (xref-tests-data-dir): Don’t use
‘ert-resource-directory’

4 years agoRevert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake.
Philipp Stephani [Sun, 25 Oct 2020 09:59:11 +0000 (10:59 +0100)]
Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake.

Flymake supports all Emacs versions back to 26.1, so it can’t use
‘ert-resource-file’.

* test/lisp/progmodes/flymake-tests.el (flymake-tests-data-directory):
Recreate.
(flymake-tests--call-with-fixture): Stop using ‘ert-resource-file’.

4 years agoAdd shortdoc group for alist
Stefan Kangas [Sat, 24 Oct 2020 23:40:27 +0000 (01:40 +0200)]
Add shortdoc group for alist

* lisp/emacs-lisp/shortdoc.el (alist): New shortdoc group.

4 years agoAdd shortdoc group for hash-table
Stefan Kangas [Sat, 24 Oct 2020 22:51:23 +0000 (00:51 +0200)]
Add shortdoc group for hash-table

* lisp/emacs-lisp/shortdoc.el (hash-table): New shortdoc group.

4 years agoMinor doprnt cleanup: remove memchr call
Paul Eggert [Sat, 24 Oct 2020 20:50:29 +0000 (13:50 -0700)]
Minor doprnt cleanup: remove memchr call

* src/doprnt.c (doprnt): Remove unnecessary call to memchr.

4 years agoRename doprnt_nul to doprnt_non_null_end
Paul Eggert [Sat, 24 Oct 2020 20:46:46 +0000 (13:46 -0700)]
Rename doprnt_nul to doprnt_non_null_end

* src/doprnt.c (doprnt_non_null_end): Rename from doprnt_nul,
as the old name was misleading (left over from a previous proposal).
Caller changed.

4 years agoImprove doprnt performance
Paul Eggert [Sat, 24 Oct 2020 20:41:01 +0000 (13:41 -0700)]
Improve doprnt performance

This patch implements some of my suggestions in Bug#8545,
with further changes suggested by Eli Zaretskii (Bug#43439).
* src/doprnt.c: Improve comments.
(SIZE_BOUND_EXTRA): Now at top level, for parse_format_integer.
(parse_format_integer): New static function, containing some of
the old doprnt.  Fix a bug that caused doprnt to infloop on
formats like "%10s" that Emacs does not use.  We could simplify
doprnt further if we dropped support for these never-used formats.
(doprnt_nul): New function.
(doprnt): Use it.  Change doprnt API to exit when either it finds NUL
or reaches the character specified by FORMAT_END.  In the typical case
where FORMAT_END is null, take just one pass over FORMAT, not two.
Assume C99 to make code clearer.  Do not use malloc or alloca to
allocate a copy of the format FMTCPY; instead, use a small fixed-size
array FMTSTAR, and use '*' in that array to represent width and
precision, passing them as separate int arguments.  Use eassume to
pacify GCC in switch statements.

4 years agoWarn about a bad default value in restricted-sexp widget
Mauro Aranda [Sat, 24 Oct 2020 19:40:42 +0000 (21:40 +0200)]
Warn about a bad default value in restricted-sexp widget

* lisp/wid-edit.el (restricted-sexp widget): New :value-to-external
function.  If value is not in the internal format, then we might be
dealing with a bad default value for the widget, so display a warning
about that (bug#25152).

4 years ago; Prefer https to http in more URLs
Stefan Kangas [Sat, 24 Oct 2020 18:22:33 +0000 (20:22 +0200)]
; Prefer https to http in more URLs

These were all tested and confirmed working.

4 years agoRework semantics of eldoc-echo-are-use-multiline-p
João Távora [Sun, 4 Oct 2020 18:31:02 +0000 (19:31 +0100)]
Rework semantics of eldoc-echo-are-use-multiline-p

Per bug#43543.  Now uses logical lines, not visual lines.

* lisp/emacs-lisp/eldoc.el (eldoc-echo-area-use-multiline-p): Rework
semantics.
(eldoc--echo-area-substring): New helper.
(eldoc--echo-area-prefer-doc-buffer-p): New helper.
(eldoc-display-in-echo-area): Rework using new helpers.

4 years agoRename ElDoc user option controlling display of truncation notice
João Távora [Sun, 4 Oct 2020 11:19:47 +0000 (12:19 +0100)]
Rename ElDoc user option controlling display of truncation notice

The new name makes it consistent with other variables controlling the
display of ElDoc documentation in the echo area.

Per bug#43543.

* etc/NEWS (Eldoc): Rename eldoc-display-truncation-message to
eldoc-echo-area-display-truncation-message.

* lisp/emacs-lisp/eldoc.el
(eldoc-echo-area-display-truncation-message): Rename from
eldoc-display-truncation-message.
(eldoc-display-in-echo-area): Use new variable name.

4 years agoRework eldoc-echo-area-prefer-doc-buffer (bug#42532)
João Távora [Sat, 3 Oct 2020 16:27:05 +0000 (17:27 +0100)]
Rework eldoc-echo-area-prefer-doc-buffer (bug#42532)

* lisp/emacs-lisp/eldoc.el:
(eldoc-echo-area-prefer-doc-buffer): Rename from
eldoc-echo-area-prefer-doc-buffer
(eldoc-display-in-echo-area): Rework to honour
eldoc-echo-area-prefer-doc-buffer.

4 years agoIntroduce eldoc-display-functions
João Távora [Sun, 6 Sep 2020 14:37:02 +0000 (15:37 +0100)]
Introduce eldoc-display-functions

See bug#43609.

* lisp/emacs-lisp/eldoc.el (eldoc--request-state): Add comment.
(eldoc--last-request-state): No longer buffer-local.
(eldoc--request-docs-p): Delete.
(eldoc-display-functions): New user variable.
(eldoc--doc-buffer-docs): New variable.
(eldoc-display-message-p): Rework.
(eldoc--format-doc-buffer): Rework from eldoc--handle-docs.
(eldoc-display-in-echo-area, eldoc-display-in-buffer): New
user-visible function.
(eldoc--invoke-strategy): Take INTERACTIVE arg.
Invoke eldoc-display-in-buffer
(eldoc-print-current-symbol-info): Simplify.
(Version): Bump to 1.11.0

* etc/NEWS: Mention eldoc-display-functions.

4 years ago; Fix last change
Basil L. Contovounesios [Sat, 24 Oct 2020 14:50:16 +0000 (15:50 +0100)]
; Fix last change

4 years agoRe-introduce variable for world clock timer
Stefan Kangas [Sat, 24 Oct 2020 13:47:26 +0000 (15:47 +0200)]
Re-introduce variable for world clock timer

* lisp/time.el (world-clock--timer): New variable.
(world-clock): Save timer to above variable when it is started.
(world-clock-cancel-timer): Delete timer saved in variable instead of
searching for the function name.

4 years agoUse lexical-binding in several language support libraries
Stefan Kangas [Sat, 24 Oct 2020 13:34:52 +0000 (15:34 +0200)]
Use lexical-binding in several language support libraries

* lisp/language/burmese.el:
* lisp/language/cham.el:
* lisp/language/czech.el:
* lisp/language/georgian.el:
* lisp/language/greek.el:
* lisp/language/khmer.el:
* lisp/language/romanian.el:
* lisp/language/sinhala.el:
* lisp/language/slovak.el:
* lisp/language/tai-viet.el:
* lisp/language/vietnamese.el: Use lexical-binding.

4 years agoAccept nil COMMAND in tramp-sh-handle-make-process (Bug#44151)
Michael Albinus [Sat, 24 Oct 2020 12:36:34 +0000 (14:36 +0200)]
Accept nil COMMAND in tramp-sh-handle-make-process (Bug#44151)

* lisp/net/tramp-sh.el (tramp-sh-handle-make-process): Accept nil
COMMAND.  (Bug#44151)

* test/lisp/net/tramp-tests.el (tramp-test29-start-file-process):
Extend test.

4 years agoRevert "Use lexical-binding in bindat.el"
Stefan Kangas [Sat, 24 Oct 2020 12:22:58 +0000 (14:22 +0200)]
Revert "Use lexical-binding in bindat.el"

This reverts commit a497b8e4a41e3223089654da4b36d0fdd51ce555.

This conversion to lexical-binding broke the eval specification,
documented in the ELisp manual.  We will probably want to add tests
for that before we can confidently convert this to lexical-binding.
Problem reported by Mattias Engdegård <mattiase@acm.org>.

4 years agoUse lexical-binding in most term libraries
Stefan Kangas [Sat, 24 Oct 2020 12:17:35 +0000 (14:17 +0200)]
Use lexical-binding in most term libraries

* lisp/term/AT386.el:
* lisp/term/internal.el:
* lisp/term/iris-ansi.el:
* lisp/term/lk201.el:
* lisp/term/news.el:
* lisp/term/rxvt.el:
* lisp/term/sun.el:
* lisp/term/tvi970.el:
* lisp/term/wyse50.el: Use lexical-binding.

4 years agoUse lexical-binding in copyright.el and add tests
Stefan Kangas [Sat, 24 Oct 2020 11:35:04 +0000 (13:35 +0200)]
Use lexical-binding in copyright.el and add tests

* lisp/emacs-lisp/copyright.el: Use lexical-binding.  Remove
redundant :group args.
* test/lisp/emacs-lisp/copyright-tests.el: New file.

4 years ago* test/manual/image-transforms-tests.el: Use lexical-binding.
Stefan Kangas [Sat, 24 Oct 2020 10:34:23 +0000 (12:34 +0200)]
* test/manual/image-transforms-tests.el: Use lexical-binding.

4 years agoMove faces.el test data to follow our conventions
Stefan Kangas [Sat, 24 Oct 2020 01:45:48 +0000 (03:45 +0200)]
Move faces.el test data to follow our conventions

* test/lisp/faces-tests.el (ert-x): Require.
(faces--test-data-dir): Remove variable.
(faces--test-extend-with-themes): Use ert-resource-directory.
* test/lisp/faces-resources/*: Moved from test/data/themes/*.

4 years agoFix a bug where the wrong menu would be triggered by mouse
Jared Finder [Mon, 12 Oct 2020 03:16:00 +0000 (20:16 -0700)]
Fix a bug where the wrong menu would be triggered by mouse

For layouts such as the following, clicking the "l" in Tools with the
right window focused would trigger the File menu, not the Tools menu.
This is because the event would have window coordinate (1 . 0).
Similarly, clicking the "p" in Help would trigger the Edit menu.

Example Emacs frame:
+--------------------------------------------------------+
|File Edit Options Buffers Tools Help                    |
|;; This buffer is for text$|;; This buffer is for text $|
|;; To create a file, visit$|;; To create a file, visit $|
|                           |                            |
|                           |                            |
|-UUU:----F1  *scratch*     |-UUU:----F1  *scratch*      |
|                                                        |
+--------------------------------------------------------+
* lisp/menu-bar.el (menu-bar-open-mouse): Reject clicks not on
the menu bar.
*lisp/xt-mouse.el (xterm-mouse-event): Pass the current frame to
'posn-at-x-y', to make the effect consistent with other mouse-handling
features.

4 years agoEnable TTY menus with xterm-mouse-mode
Jared Finder [Wed, 7 Oct 2020 03:04:12 +0000 (20:04 -0700)]
Enable TTY menus with xterm-mouse-mode

* lisp/tmm.el: No need to bind 'tmm-menubar-mouse' to mouse clicks
on the menu bar.
* lisp/menu-bar.el (global-map): Bind 'menu-bar-open-mouse' to
mouse click on menu bar.  This is needed in xt-mouse.

* etc/NEWS: Announce TTY menu support in xterm-mouse-mode.

4 years agoMake TTY menus work with xterm-mouse-mode
Jared Finder [Sat, 3 Oct 2020 21:46:30 +0000 (14:46 -0700)]
Make TTY menus work with xterm-mouse-mode

* src/term.c (mouse_get_xy): Call 'mouse_position' passing it the
value of 'tty-menu-calls-mouse-position-function' as the
argument.
(syms_of_term) <tty-menu-calls-mouse-position-function>: New
DEFVAR_BOOL.
* src/frame.c (mouse_position): New function, with most of the
code from Fmouse_position, but call 'mouse-position-function' only
if called with non-zero argument.
(Fmouse_position): Call 'mouse_position' to do the job.

* lisp/xt-mouse.el (xterm-mouse-translate-1): Respect
'track-mouse'.
(xterm-mouse-mode): Set 'tty-menu-calls-mouse-position-function'
when setting 'mouse-position-function'.
(xterm-mouse-tracking-enable-sequence): Use SET_ANY_EVENT_MOUSE
(0x1003) so that mouse movement can be reported even if no buttons
are pressed.  Doc fix.
* lisp/menu-bar.el (menu-bar-define-mouse-key): New function.
(tty-menu-navigation-map): Call it.

* doc/lispref/frames.texi (Mouse Position): Document
'tty-menu-calls-mouse-position-function'.

* etc/NEWS: Announce 'tty-menu-calls-mouse-position-function'.

4 years agoAdding mouse controls to menu-bar.el.
Jared Finder [Sat, 19 Sep 2020 07:43:29 +0000 (00:43 -0700)]
Adding mouse controls to menu-bar.el.

* lisp/isearch.el (tmm-menubar-keymap): Remove declare-function.
* lisp/menu-bar.el (menu-bar-open-mouse, menu-bar-keymap)
(menu-bar-current-active-maps, menu-bar-item-at-x): New functions.
*lisp.tmm.el (tmm-menubar-keymap, tmm-get-keybind): Functions
deleted.
(tmm-menubar): Call 'menu-bar-item-at-x'.

4 years agoFix last change in image.c for MS-Windows
Eli Zaretskii [Sat, 24 Oct 2020 07:07:44 +0000 (10:07 +0300)]
Fix last change in image.c for MS-Windows

* src/image.c [LIBRSVG_CHECK_VERSION (2, 46, 0)]: Define
prototype for rsvg_handle_get_geometry_for_layer.
(init_svg_functions) [LIBRSVG_CHECK_VERSION (2, 46, 0)]: Load
rsvg_handle_get_geometry_for_layer from the DLL, instead of
rsvg_handle_get_dimensions.
(rsvg_handle_get_geometry_for_layer) [LIBRSVG_CHECK_VERSION (2, 46, 0)]:
Define macro.  (Bug#44065)

4 years agoFix a broken unsafep test
Stefan Kangas [Sat, 24 Oct 2020 00:56:00 +0000 (02:56 +0200)]
Fix a broken unsafep test

* test/lisp/emacs-lisp/unsafep-tests.el
(test-unsafep/message): Fix test case.

(unsafep-tests--safe): Rename from testcover-unsafep-safe.
(unsafep-tests--unsafe): Rename from testcover-unsafep-unsafe.
(test-unsafep/safe, test-unsafep/unsafe): Doc fix.  Adjust usage
of above renamed variables.

4 years agoMove epg.el test data to follow our conventions
Stefan Kangas [Sat, 24 Oct 2020 00:36:33 +0000 (02:36 +0200)]
Move epg.el test data to follow our conventions

* test/lisp/epg-tests.el (ert-x): Require.
(epg-tests-data-directory): Remove variable.
(with-epg-tests): Use ert-resource-file.
* test/lisp/epg-resources/*: Moved from test/data/epg/.

4 years agoMove shr.el test data to follow our conventions
Stefan Kangas [Sat, 24 Oct 2020 00:28:45 +0000 (02:28 +0200)]
Move shr.el test data to follow our conventions

* test/lisp/net/shr-tests.el (ert, ert-x): Require.
(shr-tests--datadir): Remove variable.
(shr-test, rendering): Use ert-resource-directory.
* test/lisp/net/shr-resources/*: Move from test/data/shr/.

4 years agoMove mml-sec.el test data to follow our conventions
Stefan Kangas [Sat, 24 Oct 2020 00:17:37 +0000 (02:17 +0200)]
Move mml-sec.el test data to follow our conventions

* test/lisp/gnus/mml-sec-tests.el (ert-x): Require.
(mml-secure-test-fixture, mml-sec-test--kill-gpg-agent):
Use ert-resource-directory.
* test/lisp/gnus/mml-sec-resources/*: Moved from test/data/mml-sec/.
* .gitignore: Update location of moved file "random_seed".

4 years agoMove more test data to follow our conventions
Stefan Kangas [Fri, 23 Oct 2020 19:07:26 +0000 (21:07 +0200)]
Move more test data to follow our conventions

* test/data/minibuffer-test-cttq$tion: Move from here...
* test/lisp/minibuffer-resources/data/minibuffer-test-cttq$tion:
...to here.
* test/lisp/minibuffer-resources/lisp/cedet/semantic-utest-c.test:
* test/lisp/minibuffer-resources/lisp/cedet/semantic-utest.test:
New files.
* test/lisp/minibuffer-tests.el (ert, ert-x): Require.
(completion-table-test-quoting): Use ert-resource-directory.

* test/data/net/cert.pem:
* test/data/net/key.pem: Move frome here...
* test/lisp/net/network-stream-resources/cert.pem:
* test/lisp/net/network-stream-resources/key.pem: ...to here.
* test/lisp/net/network-stream-tests.el (ert, ert-x): Require.
(network-stream-tests--datadir): Remove variable.
(make-tls-server): Use ert-resource-file.

* test/data/vc/diff-mode/hello_emacs.c:
* test/data/vc/diff-mode/hello_emacs_1.c:
* test/data/vc/diff-mode/hello_world.c:
* test/data/vc/diff-mode/hello_world_1.c: Move from here...
* test/lisp/vc/diff-mode-resources/hello_emacs.c:
* test/lisp/vc/diff-mode-resources/hello_emacs_1.c:
* test/lisp/vc/diff-mode-resources/hello_world.c:
* test/lisp/vc/diff-mode-resources/hello_world_1.c: ...to here.
* test/lisp/vc/diff-mode-tests.el (ert, ert-x): Require.
(diff-mode-tests--datadir): Remove variable.
(diff-mode-test-font-lock-syntax-one-line)
(diff-mode-test-font-lock): Use ert-resource-directory.

* test/data/xdg/l10n.desktop:
* test/data/xdg/malformed.desktop:
* test/data/xdg/mimeapps.list:
* test/data/xdg/mimeinfo.cache:
* test/data/xdg/test.desktop: Move from here...
* test/lisp/xdg-resources/l10n.desktop:
* test/lisp/xdg-resources/malformed.desktop:
* test/lisp/xdg-resources/mimeapps.list:
* test/lisp/xdg-resources/mimeinfo.cache:
* test/lisp/xdg-resources/test.desktop: ...to here.
* test/lisp/xdg-tests.el (ert-x): Require.
(xdg-tests-data-dir): Remove variable.
(xdg-desktop-parsing, xdg-mime-associations): Use ert-resource-file.

4 years agoFix error in tramp-sh-handle-make-process
Michael Albinus [Fri, 23 Oct 2020 14:31:56 +0000 (16:31 +0200)]
Fix error in tramp-sh-handle-make-process

* lisp/net/tramp-sh.el (tramp-sh-handle-make-process): Don't use heredoc
script whent the argument contains a string.

4 years agoMove some test data to follow our conventions
Stefan Kangas [Fri, 23 Oct 2020 14:29:46 +0000 (16:29 +0200)]
Move some test data to follow our conventions

* test/data/emacs-module/mod-test.c: Move from here...
* test/src/emacs-module-resources/mod-test.c: ...to here.
* test/src/emacs-module-tests.el (ert-x): Require.
(mod-test-file, module/describe-function-1):
* test/Makefile.in (test_module_dir): Adjust for move.

* test/data/files-bug18141.el.gz: Move from here...
* test/lisp/files-resources/files-bug18141.el.gz: ... to here.
* test/lisp/files-tests.el (ert-x): Require.
(files-test-bug-18141-file): Use ert-resource-file.

* test/data/mailcap/mime.types: Move from here...
* test/lisp/net/mailcap-resources/mime.types: ...to here.
* test/lisp/net/mailcap-tests.el (ert-x): Require.
(mailcap-tests-path): Use ert-resource-file.

* test/data/somelib.el:
* test/data/somelib2.el: Move from here...
* test/src/lread-resources/somelib.el:
* test/src/lread-resources/somelib2.el: ...to here.
* test/src/lread-tests.el (ert, ert-x): Require.
(lread-test-bug26837): Use ert-resource-directory.

* test/data/syntax-comments.txt: Move from here....
* test/src/syntax-resources/syntax-comments.txt: ...to here.
* test/src/syntax-tests.el (ert-x): Require.
(syntax-comments, syntax-br-comments, syntax-pps-comments):
Use ert-resource-file.

* test/data/xref/file1.txt:
* test/data/xref/file2.txt: Move from here...
* test/lisp/progmodes/xref-resources/file1.txt:
* test/lisp/progmodes/xref-resources/file2.txt: ...to here.
* test/lisp/progmodes/xref-tests.el (ert, ert-x): Require.
(xref-tests-data-dir): Use ert-resource-directory.

4 years agoSet up composition-function-table for Egyptian
Eli Zaretskii [Fri, 23 Oct 2020 14:23:23 +0000 (17:23 +0300)]
Set up composition-function-table for Egyptian

* lisp/language/misc-lang.el (composition-function-table): Set up
for Egyptian Hieroglyphs.

4 years agoRemove most of charset markup from etc/HELLO
Eli Zaretskii [Fri, 23 Oct 2020 13:59:37 +0000 (16:59 +0300)]
Remove most of charset markup from etc/HELLO

For the reasons, see the discussion that started in
https://lists.gnu.org/archive/html/emacs-devel/2018-12/msg00407.html
and its conclusion in
https://lists.gnu.org/archive/html/emacs-devel/2019-01/msg00144.html.
The only markup left is in the preamble, just to show the example
of this facility.

4 years agoERC: Fix ERC's IBuffer format "crash" on killed server buffer
Olivier Certner [Fri, 23 Oct 2020 12:39:04 +0000 (14:39 +0200)]
ERC: Fix ERC's IBuffer format "crash" on killed server buffer

* lisp/erc/erc-ibuffer.el (erc-server-name): Fix a crash when
displaying (or updating) an IBuffer buffer using ERC's first IBuffer
format.  This happens when one ERC buffer has its associated server
buffer killed, e.g., voluntarily or automatically after server
disconnection when `erc-kill-server-buffer-on-quit' is set to t.  The
culprit is the "Server" column, which returns nil in this case.
Display "(closed)" instead (bug#44156).
Copyright-paperwork-exempt: yes

4 years agoAdd support for squashfs files in archive mode
Ruthra Kumar [Fri, 23 Oct 2020 11:02:55 +0000 (13:02 +0200)]
Add support for squashfs files in archive mode

* lisp/arc-mode.el (archive-squashfs-extract): New variable
(bug#43827).
(archive-find-type): Identify squashfs.
(archive-squashfs-summarize, archive-squashfs-extract-by-stdout):
New functions to parse/extract squashfs.

* lisp/files.el (auto-mode-alist): Add squashfs.

4 years agoMove icalendar test data to test/lisp/calendar/icalendar-resources
Ulf Jasper [Fri, 23 Oct 2020 12:48:49 +0000 (14:48 +0200)]
Move icalendar test data to test/lisp/calendar/icalendar-resources

* test/lisp/calendar/icalendar-tests.el (ert-x): Required for
'ert-resource-file'.
(icalendar-tests--data-dir): Removed.
(icalendar-tests--get-file-contents): Use 'ert-resource-file' for
finding test data files.
* test/data/icalendar/*: Moved to test/lisp/calendar/icalendar-resources/.
* test/lisp/calendar/icalendar-resources/*: Moved from test/data/icalendar.

4 years agoClean up temporary files after package tests
Stefan Kangas [Fri, 23 Oct 2020 10:56:39 +0000 (12:56 +0200)]
Clean up temporary files after package tests

* test/lisp/emacs-lisp/package-tests.el (with-package-test): Remove
temporary files after test.  (Bug#43359)

4 years agoUse lexical binding in ffap.el
Mattias Engdegård [Fri, 23 Oct 2020 09:11:51 +0000 (11:11 +0200)]
Use lexical binding in ffap.el

* lisp/ffap.el (ffap-search-backward-file-end): Remove binding for
variable shadowing an optional (and never used) argument.
(ffap--gopher-var-on-line): Remove unused variable.

4 years ago* lisp/emacs-lisp/pcase.el: Add "extensions" to keyword header.
Stefan Kangas [Fri, 23 Oct 2020 03:25:22 +0000 (05:25 +0200)]
* lisp/emacs-lisp/pcase.el: Add "extensions" to keyword header.

4 years agoMerge branch 'scratch/substitute-command-keys'
Stefan Kangas [Thu, 22 Oct 2020 22:33:19 +0000 (00:33 +0200)]
Merge branch 'scratch/substitute-command-keys'

4 years ago* etc/HELLO: Use JavaScript for Javanese script (bug#43887)
Juri Linkov [Thu, 22 Oct 2020 20:09:24 +0000 (23:09 +0300)]
* etc/HELLO: Use JavaScript for Javanese script (bug#43887)

4 years agoFix SVG image dimension calculations (bug#44065)
Alan Third [Mon, 19 Oct 2020 20:19:57 +0000 (21:19 +0100)]
Fix SVG image dimension calculations (bug#44065)

* src/image.c (svg_load_image): Calculate the image size by using the
viewBox size and applying it to the image.
* etc/PROBLEMS: Describe the problem with librsvg 2.45 and below.

4 years agoFix crash when no face is defined (bug#44058, bug#43973)
Alan Third [Thu, 22 Oct 2020 18:47:17 +0000 (19:47 +0100)]
Fix crash when no face is defined (bug#44058, bug#43973)

* src/nsterm.m (ns_clear_under_internal_border): If face is null,
don't try drawing anything.

4 years agoRemove incorrect use of decode-coding-string
Stefan Kangas [Thu, 22 Oct 2020 18:32:32 +0000 (20:32 +0200)]
Remove incorrect use of decode-coding-string

* test/lisp/emacs-lisp/bindat-tests.el
(bindat-test-pack/multibyte-string-fails)
(bindat-test-unpack/multibyte-string-fails): Don't use
decode-coding-string.
Problem pointed out by Stefan Monnier <monnier@iro.umontreal.ca>.

4 years agoeww: don't add keymap to <a> without href
Andreas Schwab [Thu, 22 Oct 2020 18:07:24 +0000 (20:07 +0200)]
eww: don't add keymap to <a> without href

* lisp/net/eww.el (eww-tag-a): Only add keymap if the href
attribute is present.  (Bug#44147)

4 years agoAdd missed file needed by time-tests.el
Stefan Kangas [Thu, 22 Oct 2020 16:28:21 +0000 (18:28 +0200)]
Add missed file needed by time-tests.el

* test/lisp/time-resources/non-empty: New file.  This file is needed
by time-tests.el but was missed when it was committed.

4 years ago; * lisp/progmodes/fortran.el: Call 'eval' with lexical binding.
Mattias Engdegård [Thu, 22 Oct 2020 16:31:31 +0000 (18:31 +0200)]
; * lisp/progmodes/fortran.el: Call 'eval' with lexical binding.

4 years agoRemove useless uses of bindat-get-field
Mattias Engdegård [Thu, 22 Oct 2020 16:26:24 +0000 (18:26 +0200)]
Remove useless uses of bindat-get-field

* lisp/progmodes/gdb-mi.el (gdb-var-list-children-handler)
(gdb-edit-register-value): bindat-get-field with a single argument is
identity; remove.

4 years agoAdd tests for perl-mode.el
Stefan Kangas [Thu, 22 Oct 2020 16:23:40 +0000 (18:23 +0200)]
Add tests for perl-mode.el

* test/lisp/progmodes/perl-mode-tests.el: New file.

4 years agoMerge branch 'master' of git.savannah.gnu.org:/srv/git/emacs into master
Ulf Jasper [Thu, 22 Oct 2020 15:47:29 +0000 (17:47 +0200)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs into master

4 years agoMove test data for icalendar tests to separate files.
Ulf Jasper [Thu, 22 Oct 2020 15:45:59 +0000 (17:45 +0200)]
Move test data for icalendar tests to separate files.

* test/lisp/calendar/icalendar-tests.el
(icalendar-tests--data-dir, icalendar-tests--get-file-contents):
New.
(icalendar-tests--test-import, icalendar-tests--do-test-import):
Read input and expected results from files.
(icalendar-import-non-recurring, icalendar-import-rrule)
(icalendar-import-duration, icalendar-import-bug-6766)
(icalendar-import-bug-24199, icalendar-import-bug-33277)
(icalendar-import-multiple-vcalendars, icalendar-import-with-uid)
(icalendar-import-with-timezone, icalendar-real-world): Move test
data (input and expected result) to separate files.

* test/calendar/icalendar/*
New files containing test data for icalendar tests.

4 years agoUse lexical-binding in time-date.el and expand tests
Stefan Kangas [Thu, 22 Oct 2020 14:34:11 +0000 (16:34 +0200)]
Use lexical-binding in time-date.el and expand tests

* lisp/calendar/time-date.el: Use lexical-binding.
* test/lisp/calendar/time-date-tests.el
(test-obsolete-with-decoded-time-value)
(test-obsolete-encode-time-value, test-format-seconds)
(test-days-to-time, test-seconds-to-string): New tests.
(test-days-in-month, test-time-since, test-time-decoded-period):
Expand test with a few more values.

4 years agoMake State button interaction less confusing
Mauro Aranda [Thu, 22 Oct 2020 14:55:03 +0000 (16:55 +0200)]
Make State button interaction less confusing

* lisp/cus-edit.el (custom-variable-current-value): New function.
(custom-variable-backup-value): Use it.
(custom-variable-set, custom-variable-mark-to-reset-standard): Check
that old value is different than the new one.  If it is, make a
backup.  This way, we avoid offering the Set to Backup Value
unnecesarily.
(custom-variable-reset-saved): Reset the variable-comment property for
the variable, to help custom-variable-state be more correct.  Also
check if we should backup old value.
(custom-variable-state): If a variable was set to the standard value,
say its state is standard rather than set, which is more correct.
Getting the right variable state is important for menu options to be
enabled/disabled, and for displaying the right message to the user
(bug#12864).

4 years ago; fix docstring typo in last commit
Robert Pluim [Thu, 22 Oct 2020 14:49:10 +0000 (16:49 +0200)]
; fix docstring typo in last commit

4 years agoUse HTTP instead of Tramp for the ffap rfc path (and also fix it)
Lars Ingebrigtsen [Thu, 22 Oct 2020 13:36:59 +0000 (15:36 +0200)]
Use HTTP instead of Tramp for the ffap rfc path (and also fix it)

* lisp/ffap.el (ffap-rfc-path): Use an URL instead of an FTP tramp
file, since that's more widely supported (bug#41663).

4 years agoComment JSX lines using JSX syntax
Lars Ingebrigtsen [Thu, 22 Oct 2020 13:20:04 +0000 (15:20 +0200)]
Comment JSX lines using JSX syntax

* lisp/progmodes/js.el (js-jsx--comment-region): New function
(bug#41696).
(js-jsx-mode): Use it.

4 years agoTest for error with multibyte strings in bindat.el
Stefan Kangas [Wed, 21 Oct 2020 16:23:38 +0000 (18:23 +0200)]
Test for error with multibyte strings in bindat.el

* test/lisp/emacs-lisp/bindat-tests.el
(bindat-test-pack/multibyte-string-fails)
(bindat-test-unpack/multibyte-string-fails): New tests.

4 years agoPretty print restricted sexp values too
Mauro Aranda [Thu, 22 Oct 2020 12:30:13 +0000 (14:30 +0200)]
Pretty print restricted sexp values too

* lisp/wid-edit.el (restricted-sexp widget): Use
widget-sexp-value-to-internal to pretty print the widget's value, when
it is a valid one (bug#7524).

4 years agoRemove reference HP-UX 8.0 and 9.x bug from FAQ
Stefan Kangas [Thu, 22 Oct 2020 11:58:23 +0000 (13:58 +0200)]
Remove reference HP-UX 8.0 and 9.x bug from FAQ

* doc/misc/efaq.texi (Meta key does not work in xterm): Remove section
about a bug on HP-UX 8.0 and 9.x.  Support for these platforms were
removed in 23.1.

4 years agoRemove two references to Emacs 21 from the FAQ
Stefan Kangas [Thu, 22 Oct 2020 11:52:42 +0000 (13:52 +0200)]
Remove two references to Emacs 21 from the FAQ

* doc/misc/efaq.texi (Turning on syntax highlighting): Remove some
references to Emacs 21 and older.

4 years agoAllow moving members of editable-list widget, via delete+insert
Mauro Aranda [Thu, 22 Oct 2020 11:52:42 +0000 (13:52 +0200)]
Allow moving members of editable-list widget, via delete+insert

* etc/NEWS (Widget): Announce the feature (bug#6419).
* lisp/wid-edit.el (widget-editable-list-delete-at): Save into a new
widget property, :last-deleted, the WIDGET to be deleted.  Add
docstring.
(widget-editable-list-insert-before): If there is a recently deleted
child for the editable list, insert that one, instead of a new default
widget.  Add docstring.
(insert-button widget): Make :help-echo a function to avoid the
help-echo string become too long.
(delete-button widget): Tweak the :help-echo string, to document this
behavior.

* test/lisp/wid-edit-tests.el (widget-test-moving-editable-list-item):
Test the feature.

4 years agoHandle Cairo errors in ftcrfont_open
Pip Cet [Thu, 22 Oct 2020 11:40:34 +0000 (13:40 +0200)]
Handle Cairo errors in ftcrfont_open

* src/ftcrfont.c (ftcrfont_open): Handle Cairo errors (bug#41627).

4 years agoUse lexical binding in fortran.el
Mattias Engdegård [Thu, 22 Oct 2020 10:18:16 +0000 (12:18 +0200)]
Use lexical binding in fortran.el

* lisp/progmodes/fortran.el: Use lexical binding.
(fortran-make-syntax-propertize-function): Hoist use of lexical
variable to outside the 'eval' call.

4 years ago* lisp/progmodes/cpp.el: Use lexical binding.
Mattias Engdegård [Thu, 22 Oct 2020 09:46:09 +0000 (11:46 +0200)]
* lisp/progmodes/cpp.el: Use lexical binding.

4 years agoUpdate TUTORIAL.de
Werner Lemberg [Thu, 22 Oct 2020 05:27:45 +0000 (07:27 +0200)]
Update TUTORIAL.de

This also includes the minor fix for bug #44123.

4 years agounload-feature: Correct doc string to match info manual and reality
Štěpán Němec [Mon, 6 Apr 2020 15:05:33 +0000 (17:05 +0200)]
unload-feature: Correct doc string to match info manual and reality

'unload-feature' doesn't try to "undo any additions the library has
made" to hooks, it tries to remove functions defined by the library
from hooks, no matter how they got there.

* lisp/loadhist.el (unload-feature): Correct the doc string.
* doc/lispref/loading.texi (Unloading): Clarify, fix typo.

4 years agounload-feature: Handle local hooks (bug#5293)
Štěpán Němec [Mon, 6 Apr 2020 11:30:11 +0000 (13:30 +0200)]
unload-feature: Handle local hooks (bug#5293)

Buffer-local hooks were introduced in

1994-09-30T20:47:13+00:00!rms@gnu.org
0e4d378b32 (add-hook): Initialize default value and local value.

but 'unload-feature' has not been updated to handle them.

* lisp/loadhist.el (unload-feature): Handle local hooks (bug#5293).