]> git.eshelyaron.com Git - emacs.git/log
emacs.git
4 years agoTweak previous mailcap patch (for external viewers)
Lars Ingebrigtsen [Fri, 11 Sep 2020 13:36:55 +0000 (15:36 +0200)]
Tweak previous mailcap patch (for external viewers)

* lisp/net/mailcap.el (mailcap-view-mime): Delete contents of the
buffer in the external case, too.

4 years agoD-Bus: Implement other compound types of properties
Michael Albinus [Fri, 11 Sep 2020 13:34:33 +0000 (15:34 +0200)]
D-Bus: Implement other compound types of properties

* doc/misc/dbus.texi (Errors and Events):
* etc/NEWS: Mention dbus-show-dbus-errors.

* lisp/net/dbus.el (dbus-compound-types): New defconst.
(dbus): New defgroup.
(dbus-show-dbus-errors): New defcustom.
(dbus-ignore-errors): Use it.
(dbus-set-property): Simplify.
(dbus-property-handler): Implement other compound types of properties.

* test/lisp/net/dbus-tests.el (dbus--test-register-service)
(dbus-test05-register-property): Extend tests.

4 years agoFix up eldef shortening of the minibuffer
Lars Ingebrigtsen [Fri, 11 Sep 2020 12:52:25 +0000 (14:52 +0200)]
Fix up eldef shortening of the minibuffer

* lisp/minibuf-eldef.el (minibuffer-default--in-prompt-regexps):
Don't include the ": " bit in the portion to be replaced
(bug#12443).

4 years agoImprove diff-no-select doc string
Lars Ingebrigtsen [Fri, 11 Sep 2020 12:26:15 +0000 (14:26 +0200)]
Improve diff-no-select doc string

* lisp/vc/diff.el (diff-no-select): Improve the doc string somewhat.

4 years agoFix viewing PDFs from eww with external viewers
Lars Ingebrigtsen [Fri, 11 Sep 2020 12:06:02 +0000 (14:06 +0200)]
Fix viewing PDFs from eww with external viewers

* lisp/net/mailcap.el (mailcap-view-mime): Most MIME viewers can't
take input on stdin (and in any case, "-" is not how many of them
designate stdin) (bug#43318).  So rewrite to put the data on a
file and feed the file name to the viewer.

4 years agoCalc: regularise test names
Mattias Engdegård [Fri, 11 Sep 2020 11:11:43 +0000 (13:11 +0200)]
Calc: regularise test names

* test/lisp/calc/calc-tests.el (calc-remove-units, calc-extract-units)
(calc-convert-units, calc-bug-23889, calc-trig, calc-format-radix)
(calc-calendar, calc-solve-linear-system):
Use a uniform naming convention (calc- prefix) to simplify test running.

4 years agoSimplify big integer constants in Calc
Mattias Engdegård [Fri, 11 Sep 2020 11:02:59 +0000 (13:02 +0200)]
Simplify big integer constants in Calc

* lisp/calc/calc-comb.el (math-small-factorial-table):
* lisp/calc/calc-funcs.el (math-bernoulli-b-cache):
* lisp/calc/calc.el (math-2-word-size, math-half-2-word-size):
No need for math-read-number-simple.

4 years agoFix calc tests when running noninteractively
Mattias Engdegård [Fri, 11 Sep 2020 10:54:00 +0000 (12:54 +0200)]
Fix calc tests when running noninteractively

This error was introduced in 8e1376a39125c3ffc0484077b502444d853eca79.

* lisp/calc/calc.el (calc--header-line): Prevent size from being negative.

4 years ago* lisp/simple.el (undo-redo): Doc fix.
Eli Zaretskii [Fri, 11 Sep 2020 05:56:51 +0000 (08:56 +0300)]
* lisp/simple.el (undo-redo): Doc fix.

4 years agoAllow an info structure as argument for gnus-group-get-parameter
Andrew G Cohen [Fri, 11 Sep 2020 02:31:47 +0000 (10:31 +0800)]
Allow an info structure as argument for gnus-group-get-parameter

* lisp/gnus/gnus.el (gnus-group-get-parameter): Allow the group
argument to be either a group name or a group info structure. This is
then parallel to gnus-group-set-parameter.

4 years ago* lisp/loadup.el ("button"): Move to after loaddefs.el
Stefan Monnier [Fri, 11 Sep 2020 02:10:02 +0000 (22:10 -0400)]
* lisp/loadup.el ("button"): Move to after loaddefs.el

4 years agoClean up group-finding in Gnus nnir search
Andrew G Cohen [Fri, 11 Sep 2020 01:02:09 +0000 (09:02 +0800)]
Clean up group-finding in Gnus nnir search

This is part of removing code from nnir.el that isn't related to
searching backends and therefore belongs somewhere else.

* lisp/gnus/gnus-group.el (gnus-group-make-search-group)
(gnus-group-read-ephemeral-search-group): Put the logic for
determining the groups to search here, rather than in nnir. Improve
documentation.
* lisp/gnus/gnus-int.el (gnus-server-get-active): Renamed from
'nnir-get-active.
* lisp/gnus/nnir.el (nnir-run-imap, nnir-run-find-grep): Use it.
(nnir-get-active): Remove.
(nnir-make-specs): Make obsolete.
* lisp/gnus/nnselect.el (nnselect-group-server):  Make obsolete in
favor of 'gnus-group-server.

4 years agoAllow editing articles in Gnus nnselect groups
Andrew G Cohen [Thu, 10 Sep 2020 23:31:56 +0000 (07:31 +0800)]
Allow editing articles in Gnus nnselect groups

* lisp/gnus/nnselect.el (nnselect-request-replace-article): New function.

4 years agoFix QNX build
Elad Lahav [Thu, 10 Sep 2020 22:01:06 +0000 (00:01 +0200)]
Fix QNX build

* configure.ac: The __NO_EXT_QNX flag is no longer needed, and is
masking the declaration of memset_s() (bug#43234).
Copyright-paperwork-exempt: yes

4 years agoUse a header line in calc mode instead of a regular in-buffer line
Boruch Baum [Thu, 10 Sep 2020 21:44:16 +0000 (23:44 +0200)]
Use a header line in calc mode instead of a regular in-buffer line

* lisp/calc/calc.el (calc-trail-here): Use a header line.
(calc--header-line): New function.
(calc-trail-mode): Use a header line.

4 years agoTweak how `M-RET' in Message mode fills paragraphs
Lars Ingebrigtsen [Thu, 10 Sep 2020 21:26:30 +0000 (23:26 +0200)]
Tweak how `M-RET' in Message mode fills paragraphs

* lisp/gnus/message.el (message-newline-and-reformat): Pick up any
longer white-space prefix before starting to fill (bug#43299).
This fixes the problem of hitting M-RET on a line that's just ">".

4 years agoDoc fix for diff-no-select
Lars Ingebrigtsen [Thu, 10 Sep 2020 21:03:50 +0000 (23:03 +0200)]
Doc fix for diff-no-select

* lisp/vc/diff.el (diff-no-select): Document the BUF argument
(bug#43307).

4 years agoAdd a "Redo" entry to the menu
Caio Henrique [Thu, 10 Sep 2020 20:57:48 +0000 (22:57 +0200)]
Add a "Redo" entry to the menu

* lisp/menu-bar.el (menu-bar-edit-menu): Add "Redo" under "Undo"
in the Edit menu (bug#43315).

Copyright-paperwork-exempt: yes

4 years ago* lisp/textmodes/artist.el: Remove obsolete comments.
Stefan Kangas [Thu, 10 Sep 2020 18:56:46 +0000 (20:56 +0200)]
* lisp/textmodes/artist.el: Remove obsolete comments.

4 years ago; Fix typos in format-prompt
Juri Linkov [Thu, 10 Sep 2020 18:58:26 +0000 (21:58 +0300)]
; Fix typos in format-prompt

4 years agoConvert indent test for css-mode into automatic test
Stefan Kangas [Thu, 10 Sep 2020 18:40:34 +0000 (20:40 +0200)]
Convert indent test for css-mode into automatic test

* test/lisp/textmodes/css-mode-tests.el (css-mode-test-indent): New
test.
(css-mode-tests-data-dir): New variable.
* test/manual/indent/css-mode.css: Move from here...
* test/lisp/textmodes/css-mode-resources/test-indent.css: ...to here.

4 years ago; * test/manual/indent/elisp.el: Use lexical-binding.
Stefan Kangas [Thu, 10 Sep 2020 18:31:42 +0000 (20:31 +0200)]
; * test/manual/indent/elisp.el: Use lexical-binding.

4 years agoMark some tests as expensive
Stefan Kangas [Thu, 10 Sep 2020 18:25:19 +0000 (20:25 +0200)]
Mark some tests as expensive

* test/lisp/autorevert-tests.el
(auto-revert-test00-auto-revert-mode)
(auto-revert-test03-auto-revert-tail-mode)
(auto-revert-test04-auto-revert-mode-dired):
* test/lisp/cedet/semantic-utest-c.el
(semantic-test-c-preprocessor-simulation):
* test/lisp/cedet/srecode-utest-getset.el
(srecode-utest-getset-output):
* test/lisp/emacs-lisp/cl-seq-tests.el (cl-seq-test-bug24264):
* test/lisp/emacs-lisp/package-tests.el
(package-test-update-archives-async):
* test/lisp/filenotify-tests.el (file-notify-test03-events)
(file-notify-test04-autorevert)
(file-notify-test05-file-validity, file-notify-test08-backup):
* test/lisp/net/gnutls-tests.el (test-gnutls-005-aead-ciphers):
* test/lisp/shadowfile-tests.el (shadow-test00-clusters)
(shadow-test09-shadow-copy-files):

4 years agoUse lexical-binding in mml-sec-tests.el
Stefan Kangas [Thu, 10 Sep 2020 17:32:33 +0000 (19:32 +0200)]
Use lexical-binding in mml-sec-tests.el

* test/lisp/gnus/mml-sec-tests.el: Use lexical-binding.
(mml-secure-test-mail-fixture)
(mml-secure-test-en-decrypt-with-passphrase): Fix warnings.

4 years ago* test/lisp/org/org-tests.el: Use lexical-binding.
Stefan Kangas [Thu, 10 Sep 2020 16:55:54 +0000 (18:55 +0200)]
* test/lisp/org/org-tests.el: Use lexical-binding.

4 years agoUse lexical-binding in url-future-tests.el
Stefan Kangas [Thu, 10 Sep 2020 16:54:12 +0000 (18:54 +0200)]
Use lexical-binding in url-future-tests.el

* test/lisp/url/url-future-tests.el: Use lexical-binding.
(url-future-tests--saver): New variable.
(url-future-tests): Use new variable.

4 years agoUse lexical-binding in semantic-utest-c.el
Stefan Kangas [Thu, 10 Sep 2020 16:47:07 +0000 (18:47 +0200)]
Use lexical-binding in semantic-utest-c.el

* test/lisp/cedet/semantic-utest-c.el: Use lexical-binding.
(semantic-test-gcc-output-parser): Fix warning.

4 years agoImplement D-Bus properties with compound type.
Michael Albinus [Thu, 10 Sep 2020 16:49:22 +0000 (18:49 +0200)]
Implement D-Bus properties with compound type.

* lisp/net/dbus.el (dbus-set-property): Fix thinko.
(dbus-register-property, dbus-property-handler): Support compound
properties.

* src/dbusbind.c (dbus-registered-objects-table): Fix docstring.

* test/lisp/net/dbus-tests.el (dbus--test-interface): Make it
different to `dbus--test-service'.
(dbus-test05-register-property)
(dbus-test05-register-property-several-paths): Adapt tests.

4 years agoOpen describe-function NEWS links in view-mode
Nick Savage [Thu, 10 Sep 2020 13:18:46 +0000 (15:18 +0200)]
Open describe-function NEWS links in view-mode

* lisp/help-mode.el (help-news): Open describe-function NEWS links in
view-mode (Bug#39912)

Copyright-paperwork-exempt: yes

4 years agoFix up < and > "date" scoring rules in Gnus
Alex Bochannek [Thu, 10 Sep 2020 13:16:04 +0000 (15:16 +0200)]
Fix up < and > "date" scoring rules in Gnus

* lisp/gnus/gnus-score.el (gnus-score-date): The previous < and >
"date" scoring rules (added in the previous patch) had reversed
logic (bug#43270).

Copyright-paperwork-exempt: yes

4 years agoFix :match function for the file widget
Mauro Aranda [Thu, 10 Sep 2020 13:12:50 +0000 (15:12 +0200)]
Fix :match function for the file widget

* lisp/wid-edit.el (file widget): Return nil if value is not a
string (bug#25678).

4 years agoRevert back to using ESC as viper-ESC-key again
Lars Ingebrigtsen [Thu, 10 Sep 2020 12:21:07 +0000 (14:21 +0200)]
Revert back to using ESC as viper-ESC-key again

* lisp/emulation/viper-keym.el (viper-ESC-key): Revert back to
using ESC instead of `escape' (bug#18182).  This allows using
`C-[' again on terminals for ESC.  The key should be mapped back
to `escape' by `function-key-map'.

4 years agoFix new summary-line after editing an article in Gnus
Andrew G Cohen [Thu, 10 Sep 2020 12:23:34 +0000 (20:23 +0800)]
Fix new summary-line after editing an article in Gnus

* lisp/gnus/gnus-sum.el (gnus-summary-edit-article-done): Strip ^M
from the ends of lines after saving an edited article. Otherwise the
new header isn't always parsed properly, resulting in an incorrect
subject line in the summary buffer.

4 years agoSet `generated-autoload-file' in erc-status-sidebar.el
Amin Bandali [Thu, 10 Sep 2020 03:03:06 +0000 (23:03 -0400)]
Set `generated-autoload-file' in erc-status-sidebar.el

* lisp/erc/erc-status-sidebar.el: Set `generated-autoload-file' to
ERC's dedicated "erc-loaddefs.el", since we don't need this file's
autoloaded functions to be available before ERC itself is loaded.

4 years ago; Silence byte-compilation warning in last change
Basil L. Contovounesios [Wed, 9 Sep 2020 23:20:24 +0000 (00:20 +0100)]
; Silence byte-compilation warning in last change

* lisp/tab-line.el (tab-line-switch-cycling): Move definition before
first use.

4 years ago; Fix typo in last change
Basil L. Contovounesios [Wed, 9 Sep 2020 23:15:09 +0000 (00:15 +0100)]
; Fix typo in last change

4 years agoIntroduce a new variable tab-line-switch-cycling
Kiso Katsuyuki [Wed, 9 Sep 2020 19:22:49 +0000 (22:22 +0300)]
Introduce a new variable tab-line-switch-cycling

If it is set t, enable cycling tab switch.  Default is nil.

Copyright-paperwork-exempt: yes

4 years agoSuppress errors of tab-line-switch functions
Kiso Katsuyuki [Wed, 9 Sep 2020 19:16:34 +0000 (22:16 +0300)]
Suppress errors of tab-line-switch functions

Traget errors occurs when tab-line-switch-to-prev-tab or
tab-line-switch-to-next-tab is invoked in a buffer which is not in
tabs

Copyright-paperwork-exempt: yes

4 years agoFix up fix for bug#19032
João Távora [Wed, 9 Sep 2020 19:12:45 +0000 (20:12 +0100)]
Fix up fix for bug#19032

* lisp/icomplete.el (icomplete-ret): Call
minibuffer-icomplete-and-exit, not minibuffer-exit.

4 years agoMinor clean ups and doc fixes in find-dired
Stefan Kangas [Wed, 9 Sep 2020 18:14:54 +0000 (20:14 +0200)]
Minor clean ups and doc fixes in find-dired

* lisp/find-dired.el (find-ls-option, find-dired): Doc fixes.
(find-dired, kill-find): Minor clean ups.

4 years agoMake flyspell-prog-text-faces into defcustom
Stefan Kangas [Thu, 27 Aug 2020 19:56:26 +0000 (21:56 +0200)]
Make flyspell-prog-text-faces into defcustom

* lisp/textmodes/flyspell.el (flyspell-prog-text-faces):
Make into defcustom.  (Bug#32136)

4 years agoAdd gv-define-expander for plist-get
Naoya Yamashita [Wed, 9 Sep 2020 00:52:39 +0000 (09:52 +0900)]
Add gv-define-expander for plist-get

It is necessary to make plist-get as a generalized variable, and this
definition allows user to use setf and other useful functions on
plist-get.

* lisp/emacs-lisp/gv.el: Add gv-define-expander for plist-get

* lisp/emacs-lisp/gv-tests.el: Add new tests for plist-get

4 years ago* lisp/dnd.el: Use lexical-binding. Remove redundant :group
Stefan Monnier [Wed, 9 Sep 2020 17:33:15 +0000 (13:33 -0400)]
* lisp/dnd.el: Use lexical-binding.  Remove redundant :group

(dnd--unescape-uri): Mark it internal, but don't mark it inlinable.

* lisp/cus-edit.el (dnd): Move the group to dnd.el.

4 years ago(define-minor-mode): Don't compute a default :group (bug#41145)
Stefan Monnier [Wed, 9 Sep 2020 17:29:59 +0000 (13:29 -0400)]
(define-minor-mode): Don't compute a default :group (bug#41145)

* lisp/emacs-lisp/easy-mmode.el (define-minor-mode): Rely on the
`defcustom`s own defaulting for the :group.

* lisp/display-fill-column-indicator.el
(global-display-fill-column-indicator-mode): Remove now redundant :group.

* lisp/cus-dep.el (custom--get-def): New function.
(custom-make-dependencies): Use it.

4 years agoAdapt Tramp doc
Michael Albinus [Wed, 9 Sep 2020 17:29:18 +0000 (19:29 +0200)]
Adapt Tramp doc

* doc/misc/tramp.texi (Remote shell setup):
Mention password-word-equivalents.

* lisp/net/tramp.el (tramp-password-prompt-regexp): Fix docstring.

4 years agoMerge from origin/emacs-27
Glenn Morris [Wed, 9 Sep 2020 14:51:14 +0000 (07:51 -0700)]
Merge from origin/emacs-27

366a97c980 (origin/emacs-27) Avoid crashes when trying to load bad GI...
7938713105 C++ Mode: handle comma separated brace initializers.
2b95300cf8 * lisp/display-fill-column-indicator.el: Fix bug#41145

4 years ago; Merge from origin/emacs-27
Glenn Morris [Wed, 9 Sep 2020 14:51:14 +0000 (07:51 -0700)]
; Merge from origin/emacs-27

The following commits were skipped:

5489524ab0 Backport recent change in tramp-tests.el from master, don'...
c9708e5ba2 Fix bug in dbus.el; do not merge with master

4 years agoMerge from origin/emacs-27
Glenn Morris [Wed, 9 Sep 2020 14:51:14 +0000 (07:51 -0700)]
Merge from origin/emacs-27

9b35b0c99c ; * lisp/man.el (Man-mode): Fix formatting.
abca75d2e9 ; Fix typos; change "Emacs-Lisp" to "Emacs Lisp"

4 years ago; Merge from origin/emacs-27
Glenn Morris [Wed, 9 Sep 2020 14:51:14 +0000 (07:51 -0700)]
; Merge from origin/emacs-27

The following commit was skipped:

e0a8a7e94c (emacs-27) ; Auto-commit of loaddefs files.

4 years agoMerge from origin/emacs-27
Glenn Morris [Wed, 9 Sep 2020 14:51:12 +0000 (07:51 -0700)]
Merge from origin/emacs-27

302f71e55d Fix help message with help-window-select
0fb3fc92b3 Remove obsolete "Wide Characters" section of Gnus manual

4 years agoFix thinko in dbus.el
Michael Albinus [Wed, 9 Sep 2020 12:53:26 +0000 (14:53 +0200)]
Fix thinko in dbus.el

* doc/misc/dbus.texi (Register Objects): Rename from "Receiving
Method Calls".  Add reference to D-Bus API Design document.

* lisp/net/dbus.el (dbus-managed-objects-handler): Fix thinko.

* test/lisp/net/dbus-tests.el (dbus-test05-register-property)
(dbus-test05-register-property-several-paths): Extend tests.

4 years agoAdd the (hopefully) correct debbugs header for patches
Lars Ingebrigtsen [Wed, 9 Sep 2020 11:06:50 +0000 (13:06 +0200)]
Add the (hopefully) correct debbugs header for patches

* lisp/mail/emacsbug.el (submit-emacs-patch): Mark the submission
as a patch.

4 years agoImplement a new `submit-emacs-patch' command
Lars Ingebrigtsen [Wed, 9 Sep 2020 10:59:23 +0000 (12:59 +0200)]
Implement a new `submit-emacs-patch' command

* doc/emacs/trouble.texi (Checklist): Mention the new command.

* doc/lispref/intro.texi (Caveats): Ditto.

* lisp/mail/emacsbug.el (emacs-bug--system-description): Factor
out into own function.
(report-emacs-bug): ... from here.
(submit-emacs-patch): New command.

4 years agoMake the button navigation commands available via a minor mode
Lars Ingebrigtsen [Wed, 9 Sep 2020 10:40:36 +0000 (12:40 +0200)]
Make the button navigation commands available via a minor mode

* lisp/button.el (button-mode): New minor mode.

* doc/lispref/display.texi (Button Buffer Commands): Mention it.

4 years agoMake Gnus cache work with nnselect
Andrew G Cohen [Wed, 9 Sep 2020 09:01:44 +0000 (17:01 +0800)]
Make Gnus cache work with nnselect

* lisp/gnus/gnus-cache.el (gnus-cache-possibly-enter-article)
(gnus-cache-possibly-remove-articles)
(gnus-cache-possibly-remove-article): Use originating article info for
nnselect groups.

4 years agoAdd Gnus function to make a persistent group from a search result
Andrew G Cohen [Wed, 9 Sep 2020 01:58:39 +0000 (09:58 +0800)]
Add Gnus function to make a persistent group from a search result

* lisp/gnus/gnus-sum.el (gnus-summary-make-group-from-search): New
command (bound to C-c C-p in summary buffers).
* doc/misc/gnus.texi (What is nnir?): Document it. Correct previous
errors.
* etc/NEWS (Gnus): Mention it.

4 years agoAllow DEFAULT in format-prompt to be a list
Lars Ingebrigtsen [Tue, 8 Sep 2020 21:10:50 +0000 (23:10 +0200)]
Allow DEFAULT in format-prompt to be a list

* doc/lispref/minibuf.texi (Text from Minibuffer): Document it.

* lisp/minibuffer.el (format-prompt): Allow DEFAULT to be a list
(and use the first element).  This is how many of the prompting
functions interpret their default parameters.

4 years agoFix crash from clicking on menu bar (bug#34762, bug#26982)
Win Treese [Tue, 8 Sep 2020 19:32:15 +0000 (15:32 -0400)]
Fix crash from clicking on menu bar (bug#34762, bug#26982)

* src/nsmenu.m (ns_update_menubar): Remove extraneous use of
autorelease pool.

4 years agoRevert "Use format-prompt in calls to read-from-minibuffer with default value"
Lars Ingebrigtsen [Tue, 8 Sep 2020 20:41:33 +0000 (22:41 +0200)]
Revert "Use format-prompt in calls to read-from-minibuffer with default value"

This reverts commit 1921d2176bb9127d2483a1c8a470abfc3f4eec33.

The DEFAULT-VALUE here isn't really a default value (since READ is nil), so
don't say there's a default.

4 years agoDoc string update for tramp-password-prompt-regexp
Lars Ingebrigtsen [Tue, 8 Sep 2020 20:07:17 +0000 (22:07 +0200)]
Doc string update for tramp-password-prompt-regexp

* lisp/net/tramp.el (tramp-password-prompt-regexp): Mention
password-word-equivalents in the doc string.

4 years agoUse mouse-wheel-up-event in mwheel-tests.el
Daniel Martín [Tue, 8 Sep 2020 12:18:17 +0000 (14:18 +0200)]
Use mouse-wheel-up-event in mwheel-tests.el

Enabling mouse-wheel-mode binds two different mouse events, depending
on the operating system. The correct way to check for those events is
by checking mouse-wheel-up-event, as explained in the ELisp manual.

* test/lisp/mwheel-tests.el (mwheel-test-enable/disable): Check
mouse-wheel-up-event instead of mouse-4 to make the test work
irrespective of the platform it's running.

4 years agoAvoid crashes when trying to load bad GIF files
Eli Zaretskii [Tue, 8 Sep 2020 16:17:23 +0000 (19:17 +0300)]
Avoid crashes when trying to load bad GIF files

* src/image.c (gif_load): Handle the case when GifErrorString
returns NULL.  (Bug#43281)

4 years agoSkip failing cperl test on hydra
Glenn Morris [Tue, 8 Sep 2020 14:43:53 +0000 (07:43 -0700)]
Skip failing cperl test on hydra

* test/lisp/progmodes/cperl-mode-tests.el (cperl-mode-test-bug-10483):
Skip on hydra.nixos.org.

4 years ago* etc/NEWS: Add D-Bus changes.
Michael Albinus [Tue, 8 Sep 2020 14:24:22 +0000 (16:24 +0200)]
* etc/NEWS: Add D-Bus changes.

4 years agoImplement typed D-Bus properties (Bug#43252)
Michael Albinus [Tue, 8 Sep 2020 14:24:11 +0000 (16:24 +0200)]
Implement typed D-Bus properties (Bug#43252)

* doc/misc/dbus.texi (Properties and Annotations)
(Receiving Method Call): Document optional type symbol in
`dbus-set-property' and `dbus-register-property'.

* lisp/net/dbus.el (dbus-error-unknown-interface)
(dbus-error-unknown-method, dbus-error-unknown-object)
(dbus-error-unknown-property): New defconsts.
(dbus-peer-handler): Improve error handling.
(dbus-introspect-get-signature): Handle also properties.
(dbus-set-property, dbus-register-property): Allow optional TYPE
symbol for VALUE.  (Bug#43252)
(dbus-property-handler): Implement property types.  Improve error
handling.

* src/dbusbind.c (dbus-message-internal, dbus-registered-objects-table):
Fix docstring.

* test/lisp/net/dbus-tests.el (dbus-test05-register-property):
Extend test.
(dbus-test05-register-property-several-paths): New test.

4 years agoRevert "Explain in the tab-always-indent doc how to make TAB insert a TAB"
Lars Ingebrigtsen [Tue, 8 Sep 2020 10:34:42 +0000 (12:34 +0200)]
Revert "Explain in the tab-always-indent doc how to make TAB insert a TAB"

This reverts commit 4b2371631167e509668b6268334e324fdd2f0327.

overriding-terminal-local-map should apparently not be used for minor stuff like this.

4 years agoIntroduce a new Gnus scoring method (for article age)
Alex Bochannek [Tue, 8 Sep 2020 09:47:28 +0000 (11:47 +0200)]
Introduce a new Gnus scoring method (for article age)

* doc/misc/gnus.texi (Score File Format): Document it.

* lisp/gnus/gnus-score.el (gnus-score-check-syntax): Add support
for the new date methods < and > (bug#43270).
(gnus-score-date): Allow scoring on dates by age.

4 years agoChange icomplete-show-matches-on-no-input behaviour for Icomplete only
João Távora [Sun, 6 Sep 2020 18:03:52 +0000 (19:03 +0100)]
Change icomplete-show-matches-on-no-input behaviour for Icomplete only

Fixes: bug#19032, bug#43120
Previous fixes to bug#19032 introduced bugs in Fido mode.  This fix
relies on a new command bound to RET.

* etc/NEWS (Miscellaneous): Mention icomplete-show-matches-on-no-input.

* lisp/icomplete.el (icomplete-show-matches-on-no-input): Add comment.
(icomplete-minibuffer-map): Rebind minibuffer-complete-and-exit to
icomplete-ret.
(icomplete-ret): New command.

4 years agoRevert two commits for bug#19032
João Távora [Sun, 6 Sep 2020 17:17:13 +0000 (18:17 +0100)]
Revert two commits for bug#19032

This reverts:

- commit 585fe00557489e49188b6a301f001ef01ff15dcb, which is titled
  "Fix up previous icomplete-show-matches-on-no-input change"

- commit 1b8d369c381b5a63e40529d0d95dfa75d94b8e09, which is titled
  "Change icomplete-show-matches-on-no-input behavior".

A simpler, less intrusive fix follows shortly after this commit.

4 years ago* etc/NEWS: Mention the new erc-status-sidebar.el
Amin Bandali [Mon, 7 Sep 2020 23:07:24 +0000 (19:07 -0400)]
* etc/NEWS: Mention the new erc-status-sidebar.el

4 years ago* lisp/erc/erc-status-sidebar.el: Fix header and make small tweaks
Amin Bandali [Mon, 7 Sep 2020 23:05:39 +0000 (19:05 -0400)]
* lisp/erc/erc-status-sidebar.el: Fix header and make small tweaks

4 years ago* lisp/erc/erc-status-sidebar.el: New file
Andrew Barbarello [Mon, 7 Sep 2020 23:04:22 +0000 (19:04 -0400)]
* lisp/erc/erc-status-sidebar.el: New file

Taken from commit 87210a3ccc16a86e6b5992744b68daabed3b2d11
of https://github.com/drewbarbs/erc-status-sidebar.

4 years agoUse format-prompt in read-file-name calls that have a default
Lars Ingebrigtsen [Mon, 7 Sep 2020 20:10:01 +0000 (22:10 +0200)]
Use format-prompt in read-file-name calls that have a default

* lisp/xwidget.el (xwidget-webkit-save-as-file):
* lisp/vc/vc.el (vc-backend-for-registration, vc-delete-file)
(vc-rename-file):
* lisp/vc/ediff-ptch.el (ediff-prompt-for-patch-file):
* lisp/vc/diff-mode.el (diff-tell-file-name):
* lisp/progmodes/etags.el (visit-tags-table)
(visit-tags-table-buffer):
* lisp/misearch.el (multi-isearch-read-files):
* lisp/mail/rmailmm.el (rmail-mime-save):
* lisp/help-fns.el (doc-file-to-man, doc-file-to-info):
* lisp/gnus/gnus-bookmark.el (gnus-bookmark-load):
* lisp/files.el (write-file, basic-save-buffer):
* lisp/dired.el (dired-read-dir-and-switches):
* lisp/bookmark.el (bookmark-save, bookmark-load):
* lisp/abbrev.el (write-abbrev-file, abbrev-edit-save-to-file):
Use format-prompt in read-file-name calls that have a default.

4 years agoFix Enchant dictionary finding routine
Reuben Thomas [Mon, 7 Sep 2020 19:56:58 +0000 (20:56 +0100)]
Fix Enchant dictionary finding routine

* lisp/textmodes/ispell.el (ispell-find-enchant-dictionaries): Don’t
  pass `buffer-string' to enchant-lsmod. Remove zero-length substrings
  from the split output of `enchant-lsmod`, as the output ends with a
  separator. Pass the current language to
  `ispell--get-extra-word-characters', so we get the result for the
  current language, not the default language. (Patch from Jorge P. de
  Morais Neto.)

4 years ago* lisp/char-fold.el (char-fold-to-regexp): Handle lax-whitespace (bug#38539)
Juri Linkov [Mon, 7 Sep 2020 18:33:13 +0000 (21:33 +0300)]
* lisp/char-fold.el (char-fold-to-regexp): Handle lax-whitespace (bug#38539)

4 years agoFix test failure in custom--test-theme-variables
Lars Ingebrigtsen [Mon, 7 Sep 2020 16:19:40 +0000 (18:19 +0200)]
Fix test failure in custom--test-theme-variables

* test/lisp/custom-tests.el (custom--test-theme-variables): "make
check" in the main directory didn't work because the path was
wrong.  Use EMACS_TEST_DIRECTORY to find the test directory
instead.

4 years agoRequire ert in the cperl tests, since it's reloading itself
Lars Ingebrigtsen [Mon, 7 Sep 2020 16:13:58 +0000 (18:13 +0200)]
Require ert in the cperl tests, since it's reloading itself

4 years agoUse auth-source for passwords in rmail
Viktor Slavkovikj [Mon, 7 Sep 2020 15:57:42 +0000 (17:57 +0200)]
Use auth-source for passwords in rmail

* lisp/mail/rmail.el (rmail-get-remote-password): Use auth-source for
passwords (bug#24274).
(rmail-parse-url): Pass in user/host.

Copyright-paperwork-exempt: yes

4 years agoAdd support for horizontal scrolling in tab-line
Daniel Martín [Mon, 7 Sep 2020 15:10:30 +0000 (17:10 +0200)]
Add support for horizontal scrolling in tab-line

* lisp/tab-line.el ([tab-line wheel-left]): Bind left and right tab
line scrolling to the 'wheel-left' and 'wheel-right' mouse events.
([tab-line S-wheel-right]): Analogous change for the functions that
switch tabs.
* etc/NEWS: Announce the new feature (bug#43224).
Copyright-paperwork-exempt: yes

4 years agoShow the status of signed + encrypted S/MIME messages in Gnus
Lars Ingebrigtsen [Mon, 7 Sep 2020 14:29:59 +0000 (16:29 +0200)]
Show the status of signed + encrypted S/MIME messages in Gnus

* lisp/gnus/mm-decode.el (mm-possibly-verify-or-decrypt): Use the
data to tell the caller (i.e., Gnus) something about the
validation of signed + encrypted S/MIME messages.

* lisp/gnus/mm-view.el (mm-view-pkcs7-verify): Pass along details
about whether we could validate the signature or not (bug#42637).

4 years agoBetter explain behaviour of icomplete--sorted-completions
João Távora [Mon, 7 Sep 2020 09:52:46 +0000 (10:52 +0100)]
Better explain behaviour of icomplete--sorted-completions

* lisp/icomplete.el (icomplete--sorted-completions): Overhaul comment

4 years agoRemove debugging code inadvertently checked in
Lars Ingebrigtsen [Mon, 7 Sep 2020 09:19:29 +0000 (11:19 +0200)]
Remove debugging code inadvertently checked in

* lisp/gnus/gnus-fun.el (gnus-face-from-file): Remove debugging
code inadvertently checked in.

4 years agoAdd aliases for recent Gnus nnselect changes
Andrew G Cohen [Mon, 7 Sep 2020 00:58:42 +0000 (08:58 +0800)]
Add aliases for recent Gnus nnselect changes

* lisp/org/ol-gnus.el (org-gnus-store-link): Change 'nnir to
'nnselect.
* lisp/gnus/gnus-group.el: Define obsolete function alias for
'gnus-group-make-nnir-group to
'gnus-group-read-ephemeral-search-group.
* lisp/gnus/gnus-sum.el: Define obsolete variable alias for
'gnus-refer-thread-use-nnir to 'gnus-refer-thread-use-search.
* lisp/gnus/nnselect.el: Define obsolete variable alias for
'nnir-retrieve-headers-override-function to
'nnselect-retrieve-headers-override-function.
* lisp/gnus/nnir.el: Restore definition of 'nnir-summary-line-format
and mark obsolete.

4 years agoUse variable-pitch fonts in the eww headers
Lars Ingebrigtsen [Mon, 7 Sep 2020 00:26:02 +0000 (02:26 +0200)]
Use variable-pitch fonts in the eww headers

* lisp/net/eww.el (eww--limit-string-pixelwise)
(eww--pixel-column): New functions.
(eww-update-header-line-format): Use variable pitch fonts in the
header line.

4 years agoAdd edebug form to subr--with-wrapper-hook-no-warnings
Lars Ingebrigtsen [Sun, 6 Sep 2020 22:45:04 +0000 (00:45 +0200)]
Add edebug form to subr--with-wrapper-hook-no-warnings

* lisp/subr.el (subr--with-wrapper-hook-no-warnings): Add a debug
form to allow edebugging some stuff.

4 years ago; Fix typos
Stefan Kangas [Mon, 7 Sep 2020 00:02:21 +0000 (02:02 +0200)]
; Fix typos

4 years agoAdd enchant-2 to list of default spelling checker programs
Reuben Thomas [Fri, 4 Sep 2020 00:58:04 +0000 (01:58 +0100)]
Add enchant-2 to list of default spelling checker programs

* lisp/textmodes/ispell.el (ispell-program-name): Check `enchant-2',
as it is likely to be a suitable version.

4 years agoAllow CSS completion with multiple rules on one line
Philip K [Sun, 6 Sep 2020 22:17:15 +0000 (00:17 +0200)]
Allow CSS completion with multiple rules on one line

* css-mode.el (css--complete-property-value): Check for semi-colon
when completing property values (bug#43242).

4 years agoUse format-prompt in some read-string calls
Lars Ingebrigtsen [Sun, 6 Sep 2020 21:44:09 +0000 (23:44 +0200)]
Use format-prompt in some read-string calls

* lisp/progmodes/prolog.el (prolog-help-on-predicate):
* lisp/cmuscheme.el (scheme-trace-procedure):
* lisp/calendar/todo-mode.el (todo-convert-legacy-files): Use
format-prompt in some read-string calls (that have default values).

* lisp/printing.el (pr-interactive-regexp): No need to use "" as
the default value, because that's the default default value.
(pr-interactive-n-up): Use read-number instead of read-string and
then parsing the string.

4 years agoMake list-processes--refresh work for pipe processes, too
dickmao [Sun, 6 Sep 2020 21:19:34 +0000 (23:19 +0200)]
Make list-processes--refresh work for pipe processes, too

* lisp/simple.el (list-processes--refresh): Don't bug out in the
presence of a `pipe' process (bug#43202).

4 years agoUse format-prompt in calls to read-from-minibuffer with default value
Lars Ingebrigtsen [Sun, 6 Sep 2020 21:11:17 +0000 (23:11 +0200)]
Use format-prompt in calls to read-from-minibuffer with default value

* lisp/tab-bar.el (tab-bar-rename-tab)
(tab-bar-rename-tab-by-name):
* lisp/simple.el (next-matching-history-element): Use
format-prompt in calls to read-from-minibuffer with at default
value.

4 years agoUse format-prompt in read-string calls (that have default values)
Lars Ingebrigtsen [Sun, 6 Sep 2020 20:59:48 +0000 (22:59 +0200)]
Use format-prompt in read-string calls (that have default values)

* lisp/vc/vc-annotate.el (vc-annotate):
* lisp/vc/log-edit.el (log-edit-comment-search-backward)
(log-edit-comment-search-forward):
* lisp/textmodes/rst.el (rst-insert-list-new-item):
* lisp/server.el (server-force-delete):
* lisp/mpc.el (mpc):
* lisp/frame.el (set-frame-name):
* lisp/emulation/cua-rect.el (cua-sequence-rectangle):
* lisp/cedet/semantic/symref/list.el (semantic-symref-regexp):
* lisp/calendar/todo-mode.el (todo-read-time): Use `format-prompt'
in `read-string' calls that have defaults.

4 years agoAdd autoload cookie to eshell-bookmark-jump
Stefan Kangas [Sun, 6 Sep 2020 15:56:26 +0000 (17:56 +0200)]
Add autoload cookie to eshell-bookmark-jump

* lisp/eshell/esh-mode.el (eshell-bookmark-jump): Add autoload
cookie, so we can jump to bookmarks before having used eshell.
Problem noted by Stefan Monnier.

4 years agoMerge branch 'master' of git.sv.gnu.org:/srv/git/emacs
Michael Albinus [Sun, 6 Sep 2020 18:45:45 +0000 (20:45 +0200)]
Merge branch 'master' of git.sv.gnu.org:/srv/git/emacs

4 years agoMore work on D-Bus error messages
Michael Albinus [Sun, 6 Sep 2020 18:45:29 +0000 (20:45 +0200)]
More work on D-Bus error messages

* lisp/net/dbus.el (dbus-get-property): Adapt docstring.
(dbus-set-property): Handle case of `:write' access type.
(dbus-get-other-registered-properties): Rename from
`dbus-get-other-registered-property'.
(dbus-property-handler): Fix thinkos.

* src/dbusbind.c (xd_read_message_1): Add error_name to event args
in case of DBUS_MESSAGE_TYPE_ERROR.

* test/lisp/net/dbus-tests.el (dbus--test-enabled-session-bus)
(dbus--test-enabled-system-bus): Make them defconst.
(dbus--test-service, dbus--test-path, dbus--test-interface):
New defconst.  Replace all occurences of `dbus-service-emacs' by
`dbus--test-service'.
(dbus--test-method-handler): New defun.
(dbus-test04-register-method, dbus-test05-register-property): New tests.

4 years agoUse format-prompt in calls to completing-read with a default value
Lars Ingebrigtsen [Sun, 6 Sep 2020 18:35:11 +0000 (20:35 +0200)]
Use format-prompt in calls to completing-read with a default value

* lisp/textmodes/rst.el (rst-insert-list-new-item):
* lisp/tab-bar.el (tab-bar-switch-to-tab):
* lisp/profiler.el (profiler-start):
* lisp/frame.el (set-frame-font):
* lisp/erc/erc.el (erc-join-channel):
* lisp/emacs-lock.el (emacs-lock--set-mode):
* lisp/emacs-lisp/elp.el (elp-set-master):
* lisp/emacs-lisp/checkdoc.el ()
(checkdoc-this-string-valid-engine):
* lisp/calendar/todo-mode.el (todo-find-filtered-items-file):
* lisp/calendar/calendar.el (calendar-set-date-style): Use
`format-prompt' in calls to completing-read that has a default
value, but didn't mention that in the prompt.

4 years agoUse a popup menu for <select>s in eww
Lars Ingebrigtsen [Sun, 6 Sep 2020 17:04:00 +0000 (19:04 +0200)]
Use a popup menu for <select>s in eww

* lisp/net/eww.el (eww-change-select): Use a popup menu for the
select (bug#43218).
(eww--form-items): New utility function.
(eww-select-map): Allow using a mouse to click on select buttons.

4 years agoDisable display-warning buttons when doing batch compiles
Lars Ingebrigtsen [Sun, 6 Sep 2020 16:34:18 +0000 (18:34 +0200)]
Disable display-warning buttons when doing batch compiles

* lisp/emacs-lisp/warnings.el (display-warning): Don't output the
buttons when we're not interactive (bug#43244).

4 years agoFix formatting of recent Gnus nnselect changes
Basil L. Contovounesios [Sun, 6 Sep 2020 14:56:32 +0000 (15:56 +0100)]
Fix formatting of recent Gnus nnselect changes

* doc/misc/gnus.texi (Finding the Parent, Selection Groups)
(Searching, Basic Usage): Heed sentence-end-double-space.  Fix
formatting of prose and examples.
* etc/NEWS: Fix typo.
* lisp/gnus/gnus-srvr.el: Remove disabled autoload.
* lisp/gnus/gnus-cloud.el (gnus-cloud-available-chunks):
* lisp/gnus/gnus-group.el (gnus-group-read-ephemeral-search-group):
* lisp/gnus/gnus-sum.el (gnus-refer-thread-use-search)
(gnus-summary-refer-thread):
* lisp/gnus/gnus.el (gnus-kill-ephemeral-group):
* lisp/gnus/nnheader.el (nnheader-head-make-header)
(nnheader-parse-head):
* lisp/gnus/nnir.el:
(nnir-hyrex-remove-prefix, nnir-run-notmuch):
* lisp/gnus/nnselect.el: Fix formatting/indentation of commentary,
docstring, and/or code.

4 years agoUse `format-prompt' when prompting with default values
Lars Ingebrigtsen [Sun, 6 Sep 2020 14:56:44 +0000 (16:56 +0200)]
Use `format-prompt' when prompting with default values

* lisp/woman.el (woman-file-name):
* lisp/wid-edit.el (widget-file-prompt-value)
(widget-coding-system-prompt-value):
* lisp/w32-fns.el (w32-set-system-coding-system):
* lisp/vc/vc.el (vc-print-root-log):
* lisp/vc/vc-annotate.el (vc-annotate):
* lisp/vc/emerge.el (emerge-read-file-name):
* lisp/vc/ediff.el (ediff-directories)
(ediff-directory-revisions, ediff-directories3)
(ediff-merge-directories, )
(ediff-merge-directories-with-ancestor)
(ediff-merge-directory-revisions)
(ediff-merge-directory-revisions-with-ancestor)
(ediff-merge-revisions, ediff-merge-revisions-with-ancestor)
(ediff-revision):
* lisp/vc/ediff-util.el (ediff-toggle-regexp-match):
* lisp/vc/ediff-mult.el (ediff-filegroup-action):
* lisp/vc/add-log.el (prompt-for-change-log-name):
* lisp/textmodes/table.el (table-insert-row-column)
(table-span-cell, table-split-cell-horizontally)
(table-split-cell, table-justify, table-generate-source)
(table-insert-sequence, table-capture)
(table--read-from-minibuffer, table--query-justification):
* lisp/textmodes/sgml-mode.el (sgml-tag, sgml-tag-help):
* lisp/textmodes/reftex-ref.el (reftex-goto-label):
* lisp/textmodes/refer.el (refer-get-bib-files):
* lisp/textmodes/css-mode.el (css-lookup-symbol):
* lisp/term.el (serial-read-name, serial-read-speed):
* lisp/speedbar.el (speedbar-change-initial-expansion-list):
* lisp/simple.el (previous-matching-history-element)
(set-variable):
* lisp/ses.el (ses-read-cell, ses-set-column-width):
* lisp/replace.el (query-replace-read-from)
(occur-read-primary-args):
* lisp/rect.el (string-rectangle, string-insert-rectangle):
* lisp/progmodes/tcl.el (tcl-help-on-word):
* lisp/progmodes/sh-script.el (sh-set-shell):
* lisp/progmodes/python.el (python-eldoc-at-point):
* lisp/progmodes/octave.el (octave-completing-read)
(octave-update-function-file-comment, octave-insert-defun):
* lisp/progmodes/inf-lisp.el (lisp-symprompt):
* lisp/progmodes/cperl-mode.el (cperl-info-on-command)
(cperl-perldoc):
* lisp/progmodes/compile.el (compilation-find-file):
* lisp/net/rcirc.el (rcirc-prompt-for-encryption):
* lisp/net/eww.el (eww):
* lisp/net/browse-url.el (browse-url-with-browser-kind):
* lisp/man.el (man):
* lisp/mail/sendmail.el (sendmail-query-user-about-smtp):
* lisp/mail/mailalias.el (build-mail-aliases):
* lisp/mail/mailabbrev.el (merge-mail-abbrevs)
(rebuild-mail-abbrevs):
* lisp/locate.el (locate-prompt-for-search-string):
* lisp/isearch.el (isearch-occur):
* lisp/international/ogonek.el (ogonek-read-encoding)
(ogonek-read-prefix):
* lisp/international/mule.el (read-buffer-file-coding-system)
(set-terminal-coding-system, set-keyboard-coding-system)
(set-next-selection-coding-system, recode-region):
* lisp/international/mule-cmds.el ()
(universal-coding-system-argument, search-unencodable-char)
(select-safe-coding-system-interactively):
* lisp/info.el (Info-search, Info-search-backward, Info-menu):
* lisp/info-look.el (info-lookup-interactive-arguments):
* lisp/imenu.el (imenu--completion-buffer):
* lisp/ibuf-ext.el (mode, used-mode, ibuffer-mark-by-mode):
* lisp/hi-lock.el (hi-lock-unface-buffer)
(hi-lock-read-face-name):
* lisp/help.el (view-emacs-news, where-is):
* lisp/help-fns.el (describe-variable, describe-symbol)
(describe-keymap):
* lisp/gnus/mm-decode.el (mm-save-part):
* lisp/gnus/gnus-sum.el (gnus-summary-browse-url):
* lisp/gnus/gnus-group.el (gnus-group--read-bug-ids)
(gnus-group-set-current-level):
* lisp/frame.el (make-frame-on-monitor)
(close-display-connection, select-frame-by-name):
* lisp/format.el (format-encode-buffer, format-encode-region):
* lisp/files.el (recode-file-name):
* lisp/files-x.el (read-file-local-variable)
(read-file-local-variable-value, )
(read-file-local-variable-mode):
* lisp/ffap.el (ffap-menu-ask):
* lisp/faces.el (face-read-string):
* lisp/facemenu.el (facemenu-set-charset):
* lisp/erc/erc-dcc.el (erc-dcc-do-GET-command):
* lisp/emulation/edt-mapper.el (edt-mapper):
* lisp/emacs-lisp/trace.el (trace--read-args)
(trace-function-foreground, trace-function-background):
* lisp/emacs-lisp/smie.el (smie-config-set-indent):
* lisp/emacs-lisp/re-builder.el (reb-change-syntax):
* lisp/emacs-lisp/package.el (describe-package):
* lisp/emacs-lisp/find-func.el (read-library-name)
(find-function-read):
* lisp/emacs-lisp/ert.el (ert-read-test-name)
(ert-run-tests-interactively):
* lisp/emacs-lisp/disass.el (disassemble):
* lisp/emacs-lisp/debug.el (debug-on-entry)
(debug-on-variable-change):
* lisp/emacs-lisp/advice.el (ad-read-advised-function)
(ad-read-advice-class, ad-read-advice-name, ad-read-regexp):
* lisp/dired-x.el (dired--mark-suffix-interactive-spec):
* lisp/dired-aux.el (dired-diff):
* lisp/cus-edit.el (custom-variable-prompt, customize-mode)
(customize-changed-options):
* lisp/completion.el (interactive-completion-string-reader):
* lisp/calendar/timeclock.el (timeclock-ask-for-project):
* lisp/calc/calcalg3.el (calc-get-fit-variables):
* lisp/calc/calc-store.el (calc-edit-variable):
* lisp/calc/calc-bin.el (calc-word-size):
* lisp/bookmark.el (bookmark-set-internal):
* lisp/abbrev.el (read-abbrev-file): Use `format-prompt' for
prompting (bug#12443).