Make mailcap-prefer-mailcap-viewers work as documented

* lisp/emacs-lisp/seq.el (seq-find): Autoload.

* lisp/net/mailcap.el (mailcap-parse-mailcaps): Note where all the
entries come from so that we can later distinguish between user
values and system values (bug#36771).
(mailcap-parse-mailcap): Take a source parameter.
(mailcap-possible-viewers): No need to sort wildcards/exact
matches; these are later sorted anyway.
(mailcap-add-mailcap-entry): Remove `after' parameter.
(mailcap-mime-info): Make mailcap-prefer-mailcap-viewers work as
documented.

Only complete words inside of the string widget

* lisp/wid-edit.el ('string widget): Peek the word that
ispell-complete-word will try to complete, and only offer completions
when the word is inside of the field (bug#11046).

; * doc/misc/eww.texi (Advanced): Fix recent typo.

Fix message when no completions available for editable field

* lisp/wid-edit.el (widget-completions-at-point): Detect here if point
is not in an editable field.
(widget-complete): And here say there are no completions available
(bug#11562).

Allow using last_tab_bar_item on no-x builds.

* src/frame.h (struct frame): Remove HAVE_WINDOW_SYSTEM
around last_tab_bar_item.

Implement tab-close-other bound to C-x 6 1 by analogy with C-x 5 1.

* lisp/tab-bar.el (tab-close-other): New command bound to C-x 6 1.

* doc/emacs/frames.texi (Tab Bars): Document it.

Use tabs in EWW (bug#37592)

* lisp/net/eww.el (eww-open-in-new-buffer): Call tab-new when tab-bar-mode
is enabled.
(eww-browse-url): Add docstring.  Call tab-new when tab-bar-mode
is enabled.

* lisp/net/shr.el (shr-map): Bind [C-down-mouse-1] to
shr-mouse-browse-url-new-window.
(shr-mouse-browse-url-new-window): New command.
(shr-browse-url): Add optional arg new-window.

* doc/misc/eww.texi (Basics): Mention opening tabs on M-RET.

* eieio-core.el (eieio--full-class-object): New function.

Rather than explicitly call eieio-class-un-autoload, the autoloading is
now performed on-demand if you use eieio--full-class-object.

* lisp/emacs-lisp/eieio-core.el (eieio-class-un-autoload): Remove.
(eieio--full-class-object): New function, to replace it.
(eieio-oref, eieio--class-precedence-list):
* lisp/emacs-lisp/eieio-base.el (eieio-persistent-convert-list-to-object):
Use it instead of eieio-class-un-autoload.
* lisp/emacs-lisp/eieio.el (eieio-class-parents, child-of-class-p):
Load the class if needed.

Support changing font size using mouse wheel

* lisp/mwheel.el (mouse-wheel-mode): Support changing font size (text
scaling) using mouse wheel.  (Bug#28182)
(mouse-wheel-scroll-amount): Bind the Ctrl modifier to text scaling.
(mwheel-installed-text-scale-bindings): New variable.
(mouse-wheel--remove-bindings): New helper function for
'mouse-wheel-mode'.

* doc/emacs/frames.texi (Mouse Commands): Document this feature.
* etc/NEWS: Announce it.

Set alternate faces for some line numbers (bug#27734)

* lisp/faces.el (line-number-major-tick, line-number-minor-tick):
New faces.
* lisp/cus-start.el (display-line-numbers-major-tick)
(display-line-numbers-minor-tick): Add customization info.
* lisp/frame.el: Add `display-line-numbers-major-tick' and
`display-line-numbers-minor-tick' to list of variables which
should trigger redisplay of the current buffer.

* src/xdisp.c (syms_of_xdisp) <display-line-numbers-major-tick>
<display-line-numbers-major-tick>: Defvar new options.
(syms_of_xdisp) <line-number-major-tick, line-number-minor-tick>:
Defsym new faces.
(maybe_produce_line_number): Use new faces for line numbers
that are multiple of `display-line-numbers-major-tick' and
`display-line-numbers-minor-tick'.

* etc/NEWS (value): Announce new feature.
* doc/emacs/display.texi (Display Custom): Describe it.  Wording by
Robert Pluim <rpluim@gmail.com>

Don't bind 'C-x 6' to '2C-mode-map' globally by default.

* lisp/textmodes/two-column.el: Don't autoload global setting of
"\C-x6" to 2C-command.

* lisp/ldefs-boot.el: Update to remove setting "\C-x6" to 2C-command.

* doc/emacs/commands.texi (Keys):
* doc/emacs/text.texi (Two-Column):
* doc/lispref/keymaps.texi (Prefix Keys):
* doc/lispref/maps.texi (Standard Keymaps):
Unbind 'C-x 6' from '2C-mode-map'.

* lisp/emacs-lisp/package.el (package--get-deps): Rewrite.

Avoid inf-recursion with dependency cycles.
Remove unused `only` arg.  Prune duplicates early rather than late.
(package--removable-packages): Simplify code accordingly.

Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

Port file-acl errno checking to non-GNU

Problem reported privately for FreeBSD 12 by Ashish Shukla.
* src/fileio.c (Ffile_acl): Treat EINVAL etc. like ENOTSUP if
acl_get_file fails, to port to FreeBSD 12 and other non-GNU
platforms.

Support mouse clicks on tab bar on TTY frames

This for now doesn't work on GPM.
* src/xdisp.c (display_tab_bar): Make the loop over tab-bar
items more efficient.
(tab_bar_item_info, tool_bar_item_info): Correct data type for
CHARPOS.
(tty_get_tab_bar_item, tty_handle_tab_bar_click): New functions.
(note_mouse_highlight): Handle help-echo of tab-bar tabs on
TTY frames.
* src/w32inevt.c (do_mouse_event): Call
tty_handle_tab_bar_click to process mouse clicks on the tab bar.
* src/termchar.h (tty_handle_tab_bar_click): Add prototype.
* src/w32console.c (w32con_set_terminal_modes): Disable Quick
Edit mode on entry, to make sure mouse events get reported to
us.

Fix off-by-one bug in ISO 8601 BC years

* lisp/calendar/iso8601.el (iso8601--year-match)
(iso8601--full-date-match, iso8601--without-day-match)
(iso8601--week-date-match, iso8601--ordinal-date-match)
(iso8601-parse-date):
Don’t bother to separate the year’s sign from the year,
as that distinction is not needed: ISO 8601 uses
astronomical year numbering with a year zero, which
is what the Emacs time functions use, so there’s no
need to treat nonpositive years specially.
(iso8601--adjust-year): Remove; no longer needed
since callers can just use string-to-number.
* test/lisp/calendar/iso8601-tests.el (test-iso8601-date-years):
Adjust test case to match fixed behavior.

Improve documentation for year-zero issues

* doc/emacs/calendar.texi (Calendar Systems)
* doc/lispref/os.texi (Time Conversion):
Prefer "BC" to "B.C." since the documentation generally uses "BC".
* doc/misc/emacs-mime.texi (time-date):
* lisp/calendar/time-date.el (date-to-day, time-to-days):
In the doc string, state the day origin more clearly, and more
consistently with the rest of the documentation.
* src/timefns.c (Fdecode_time): State the year origin in
the doc string.

More tab bar related key bindings.

* lisp/subr.el (ctl-x-6-map, ctl-x-6-prefix): Move here from tab-bar.el
to make it available to other modes like dired for 'C-x 6 d'.

* lisp/dired.el (dired-other-tab): New command bound to 'C-x 6 d'.

* lisp/tab-bar.el: Bind 'C-x 6 o' to tab-next.

* doc/emacs/frames.texi (Tab Bars): Describe C-x 6 prefix key bindings.

* lisp/tab-bar.el: In tab switching allow absolute and relative args.

* lisp/tab-bar.el (tab-bar-tab-hints): New defcustom.
(tab-bar-make-keymap-1): Use tab-bar-tab-hints.
(tab-bar--tab, tab-bar--current-tab, tab-bar--current-tab-index)
(tab-bar--tab-index, tab-bar--tab-index-by-name): New internal functions.
(tab-bar-select-tab): Use arg as absolute position of tab to select.
(tab-bar-switch-to-next-tab, tab-bar-switch-to-prev-tab): Use arg
as offset relative to the current tab.
(tab-bar-switch-to-tab): New command.
(tab-bar-new-tab): Simplify by using cl-pushnew.
(tab-bar-close-current-tab): Remove (the current tab is closed
by nil arg of tab-bar-close-tab).
(tab-bar-close-tab): Use arg as absolute position of tab to close.
(tab-bar-close-tab-by-name): New command.

Include new permission settings for macOS 10.15 (bug#37551)

* nextstep/templates/Info.plist.in
(NSDesktopFolderUsageDescription):
(NSDocumentsFolderUsageDescription):
(NSDownloadsFolderUsageDescription):
(NSRemovableVolumesUsageDescription): Add description to enable
setting in macOS 10.15.

Copyright-paperwork-exempt: yes

Support GNU make error messages in compile mode.

* lisp/progmodes/compile.el (compilation-error-regexp-alist-alist):
Match GNU make error messages.
* test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data):
Test GNU make error message matching.
(compile-test-error-regexps): Update count of infos found.

Remove some XEmacs compat code from the CEDET tests

Remove some XEmacs compat code from esh*.el

* lisp/eshell/esh-util.el: Remove some XEmacs compat functions.

Remove more XEmacs compat code from ezimage.el

* lisp/ezimage.el (ezimage-use-images)
(ezimage-insert-over-text): Remove XEmacs compat code.

Fix typo in frames.texi xref

* doc/emacs/frames.texi (Tab Bars): Fix typo in xref.

Remove most of the XEmacs compat code from ediff*.el

* lisp/vc/ediff-diff.el (ediff-word-1): Remove XEmacs compat code
and declare compatibility functions for obsolete.  Adjust all callers.

* lisp/vc/ediff-help.el (ediff-set-help-overlays):

* lisp/vc/ediff-hook.el:
(menu-bar-ediff-misc-menu, menu-bar-ediff-merge-menu)
(menu-bar-ediff-menu, menu-bar-ediff-merge-menu)
(menu-bar-epatch-menu, menu-bar-ediff-misc-menu):

* lisp/vc/ediff-init.el (ediff-device-type)
(ediff-window-display-p, ediff-has-face-support-p)
(ediff-has-toolbar-support-p, ediff-has-gutter-support-p)
(ediff-BAD-INFO, ediff-coding-system-for-write)
(ediff-read-event, ediff-overlayp, ediff-make-overlay)
(ediff-delete-overlay, ediff-color-display-p)
(ediff-display-pixel-width, ediff-display-pixel-height)
(ediff-region-help-echo, ediff-set-face-pixmap)
(ediff-paint-background-regions-in-one-buffer)
(ediff-clear-fine-diff-vector, ediff-mouse-event-p)
(ediff-key-press-event-p, ediff-event-point, )
(ediff-event-buffer, ediff-event-key, ediff-last-command-char)
(ediff-frame-iconified-p, ediff-frame-char-width)
(ediff-reset-mouse, ediff-frame-char-height)
(ediff-overlay-start, ediff-overlay-end, ediff-overlay-buffer)
(ediff-overlay-get, ediff-move-overlay, ediff-overlay-put)
(ediff-abbreviate-file-name):

* lisp/vc/ediff-mult.el (ediff-next-meta-item)
(ediff-previous-meta-item)
(ediff-replace-session-activity-marker-in-meta-buffer)
(ediff-replace-session-status-in-meta-buffer)
(ediff-redraw-directory-group-buffer)
(ediff-update-markers-in-dir-meta-buffer)
(ediff-update-session-marker-in-dir-meta-buffer)
(ediff-redraw-registry-buffer, ediff-set-meta-overlay)
(ediff-update-meta-buffer, ediff-get-meta-info)
(ediff-get-meta-overlay-at-pos, )
(ediff-get-session-number-at-pos, )
(ediff-next-meta-overlay-start)
(ediff-previous-meta-overlay-start, )
(ediff-meta-mark-equal-files):

* lisp/vc/ediff-util.el:
(ediff-setup, ediff-setup-control-buffer, ediff-recenter)
(ediff-recenter-one-window, ediff-toggle-read-only)
(ediff-file-checked-out-p, ediff-file-checked-in-p)
(ediff-toggle-wide-display, ediff-toggle-multiframe)
(ediff-toggle-use-toolbar, ediff-kill-bottom-toolbar)
(ediff-visible-region, ediff-scroll-vertically)
(ediff-scroll-horizontally, ediff-jump-to-difference-at-point)
(ediff-diff-to-diff, ediff-restore-diff)
(ediff-toggle-regexp-match, ediff-really-quit)
(ediff-cleanup-mess, ediff-highlight-diff-in-one-buffer)
(ediff-unhighlight-diffs-totally-in-one-buffer)
(ediff-save-buffer, ediff-make-cloned-buffer)
(ediff-make-indirect-buffer, ediff-remove-flags-from-buffer)
(ediff-place-flags-in-buffer1, ediff-get-diff-posn)
(ediff-clear-diff-vector, ediff-make-bullet-proof-overlay)
(ediff-submit-report, ediff-deactivate-mark)
(ediff-activate-mark, ediff-profile, ediff-print-diff-vector):

* lisp/vc/ediff-wind.el (ediff-control-frame-parameters)
(ediff-get-window-by-clicking, ediff-select-lowest-window)
(ediff-setup-windows-plain-merge)
(ediff-setup-windows-plain-compare, ediff-setup-control-frame)
(ediff-destroy-control-frame, ediff-make-frame-position)
(ediff-make-wide-display, ediff-get-visible-buffer-window):

* lisp/vc/ediff.el (ediff-version, ediff-documentation):

Improve documentation of Tab bars

* doc/emacs/frames.texi (Menu Bars, Tool Bars, Tab Bars):
Don't start index entries from a capital letter.
(Tab Bars): Improve wording and indexing.

* etc/NEWS: Improve documentation of Tab bars.

Fix display of cursor in obscure use case on MS-Windows

* src/xdisp.c (redisplay_internal): Detect when the frame
becomes garbaged inside the call to update_frame, and redraw
the frame in that case.  (Bug#37579)

* src/fns.c (Flocale_info): Avoid fixnum overflow under ASan.

* src/pdumper.c (dump_buffer): Update structure hash.

Omit one more superfluous "-" in regexp

Problem reported by Mattias Engdegård.
* lisp/language/indian.el (gurmukhi-composable-pattern):
Omit unnecessary "-".

(project--vc-list-files): Make sure to expand file names

* lisp/progmodes/project.el (project--vc-list-files): Make sure to
expand file names.  Turns out, Grep doesn't like abbreviated ones.

Fix vertical scrolling in image-mode

* lisp/image-mode.el (image-set-window-vscroll): Interpret the
argument VSCROLL value in pixel units.
(image-mode-reapply-winprops): Interpret the 'vscroll'
property value in pixel units.
(image-next-line): Scroll the image with pixel resolution.
(image-eob): Set the image vscroll in pixels.  (Bug#37578)

Improve docstrings auto-generated by `define-minor-mode'

* lisp/emacs-lisp/easy-mmode.el (easy-mmode--mode-docstring):
When using `easy-mmode--arg-docstring' to auto-generate a
docstring, refill it up to `emacs-lisp-docstring-fill-column'.

Don't manipulate gnus-newsrc-alist if it hasn't been initalized

* lisp/gnus/gnus-group.el (gnus-group-set-info): Packages that use
Gnus summary mode without actually booting Gnus might end up in this
situation. See bug#36903

Fix bugs found by 2019-09-29 regexp scanner

Problems reported by Mattias Engdegård in:
https://lists.gnu.org/r/emacs-devel/2019-09/threads.html
* lisp/calendar/iso8601.el (iso8601--year-match)
(iso8601--full-date-match, iso8601--without-day-match)
(iso8601--week-date-match, iso8601--ordinal-date-match)
(iso8601--zone-match):
* lisp/textmodes/rst.el (rst-re-alist-def):
Put ‘-’ at the end of bracketed ranges, following the style
suggestion in the Elisp manual.
(iso8601--time-match): Use \([0-9]*\) instead of \([0-9]+\)?
to pacify the regexp scanner.
(iso8601-parse-time): Adjust accordingly.
* lisp/language/burmese.el (burmese-composable-pattern):
* lisp/language/indian.el (devanagari-composable-pattern)
(bengali-composable-pattern, gurmukhi-composable-pattern)
(gujarati-composable-pattern, oriya-composable-pattern)
(telugu-composable-pattern, kannada-composable-pattern)
(malayalam-composable-pattern):
Prefer [ab] to [a-b] when the characters differ by 1,
to pacify the regexp scanner.
* lisp/language/burmese.el (burmese-composable-pattern):
Fix missing-‘\u’ typos.
* lisp/language/indian.el (gurmukhi-composable-pattern):
Fix missing-‘\’ typo.
* lisp/language/tibetan.el (tibetan-regexp):
Quote ‘+’ in regexp to pacify the regexp scanner.  Simplify.
* lisp/textmodes/rst.el (rst-re-alist-def): Fix ‘[]-'...]’
typo by putting the ‘-’ at end of the bracketed expression.

Minor style tweaks for recent tab changes

* src/dispextern.h (MR_PARTIALLY_VISIBLE_AT_TOP):
* src/window.c (Fwindow_mode_line_height)
(Fwindow_header_line_height, Fwindow_tab_line_height)
(Fwindow_right_divider_width, Fwindow_bottom_divider_width)
(Fwindow_scroll_bar_width, Fwindow_scroll_bar_height):
(Fset_window_configuration, Fcurrent_window_configuration):
Omit unnecessary parens.
* src/dispextern.h (CURRENT_MODE_LINE_HEIGHT)
(CURRENT_HEADER_LINE_HEIGHT, CURRENT_TAB_LINE_HEIGHT):
Add parens needed to make these macros function-like.
* src/window.c (window_resize_check):
* src/window.h (WINDOW_TAB_BAR_P):
* src/xdisp.c (tab_bar_item_info): Reindent.
* src/window.c (window_wants_mode_line)
(window_wants_header_line, window_wants_tab_line):
Simplify (a && b ? 1 : 0) to (a && b).

Make mouse scroll show a message instead of dinging at buffer limits

* lisp/mwheel.el (mwheel-scroll): Show a message instead of dinging at
end of buffer and beginning of buffer.  This should be less intrusive,
especially when using a trackpad.  (Bug#16196)

Bind Scroll_Lock to scroll-lock-mode globally

* lisp/bindings.el (global-map): Bind Scroll_Lock to
scroll-lock-mode.  (Bug#6861)
* lisp/scroll-lock.el (scroll-lock-mode): Note that the binding will
not work if 'w32-scroll-lock-modifier' is non-nil.
* etc/NEWS: Announce it.

Add tests for secure-hash and improve doc string (Bug#37420)

* src/fns.c (Fsecure_hash_algorithms): Fix typo.
(Fsecure_hash): Add algorithm list to doc string.
* test/src/fns-tests.el (test-secure-hash): New test.

Declare unused vhdl code in align.el obsolete

* lisp/align.el (align-vhdl-rules-list, align-set-vhdl-rules): Declare
obsolete.  (Bug#6207)
(align-dq-string-modes, align-open-comment-modes): Move vhdl-mode to
definition instead of adding it later.

Fix error in gnu compilation-mode regexp (bug#37582)

* lisp/progmodes/compile.el (compilation-error-regexp-alist-alist):
Fix a mistake introduced when the regexp was translated to rx.
* test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data)
(compile-test-error-regexps): Add test case.
* etc/compilation.txt: Add example.

Make compile-tests re-runnable

* test/lisp/progmodes/compile-tests.el (compile-test-error-regexps):
Don't rely on compilation-num-errors (etc) all being zero, which they
aren't if the test has been run before.
(compile-tests--test-regexps-data): Change defvar to defconst.

Remove semantic-make-local-hook call from CEDET

* lisp/cedet/semantic/wisent/grammar.el
(wisent-grammar-setupcode-builder):
* lisp/cedet/semantic/util-modes.el (semantic-highlight-edits-mode)
(semantic-show-unmatched-syntax-mode)
(semantic-show-parser-state-mode):
* lisp/cedet/semantic/mru-bookmark.el (semantic-mru-bookmark-mode):
* lisp/cedet/semantic/imenu.el (semantic-create-imenu-index):
* lisp/cedet/semantic/grammar.el (semantic-grammar-mode):
* lisp/cedet/semantic/grammar-wy.el
(semantic-grammar-wy--install-parser):
* lisp/cedet/semantic/decorate/mode.el
(semantic-decorate-add-pending-decoration)
(semantic-decoration-mode):
* lisp/cedet/semantic.el (semantic--set-buffer-cache): Remove all
calls to the function.

* lisp/cedet/semantic/fw.el (semantic-make-local-hook): Made
obsolete alias for #'ignore by removing XEmacs compat code.

Remove some XEmacs compat code from ispell.el

* lisp/textmodes/ispell.el (ispell-word): Remove XEmacs compat code.

Remove some XEmacs compat code from ezimage.el

* lisp/ezimage.el (defezimage): Remove XEmacs compat code.

Remove XEmacs compat code from re-builder.el

* lisp/emacs-lisp/re-builder.el (top-level)
(reb-color-display-p): Remove XEmacs compat code.

Remove some XEmacs compat code from ediff*.el

* lisp/vc/ediff-diff.el (ediff-goto-word): Ditto.

* lisp/vc/ediff-init.el (ediff-has-face-support-p)
(ediff-current-diff-A, ediff-current-diff-B)
(ediff-current-diff-C, ediff-current-diff-Ancestor)
(ediff-fine-diff-A, ediff-fine-diff-B, ediff-fine-diff-C)
(ediff-fine-diff-Ancestor, ediff-even-diff-A)
(ediff-even-diff-B, ediff-even-diff-C)
(ediff-even-diff-Ancestor, ediff-odd-diff-A, ediff-odd-diff-B)
(ediff-odd-diff-C, ediff-odd-diff-Ancestor)
(ediff-with-syntax-table): Ditto.

* lisp/vc/ediff-mult.el (ediff-dir-diffs-buffer-map)
(ediff-setup-meta-map, ediff-set-meta-overlay): Ditto.

* lisp/vc/ediff-util.el (ediff-setup-keymap)
(ediff-toggle-wide-display, ediff-toggle-multiframe)
(ediff-toggle-use-toolbar, ediff-really-quit)
(ediff-good-frame-under-mouse)
(ediff-make-bullet-proof-overlay): Ditto.

* lisp/vc/ediff-wind.el (ediff-setup-control-frame)
(ediff-refresh-control-frame): Remove XEmacs compat code.

* lisp/subr.el (generate-new-buffer): Move (from files.el) before first use

(with-temp-file, with-output-to-string): Use it.

* lisp/files.el (generate-new-buffer): Move to subr.el.

(project--vc-list-files): Optimize the Hg implementation

* lisp/progmodes/project.el (project--vc-list-files):
Optimize the Hg implementation.

Remove some more XEmacs compat code from viper*.el

* lisp/emulation/viper-ex.el (viper-ex-read-file-name): Ditto.

* lisp/emulation/viper-init.el (viper-ms-style-os-p)
(viper-has-face-support-p, viper-deactivate-input-method)
(viper-activate-input-method, viper-set-input-method): Ditto.

* lisp/emulation/viper-util.el
(viper-get-saved-cursor-color-in-replace-mode)
(viper-get-saved-cursor-color-in-insert-mode)
(viper-get-saved-cursor-color-in-emacs-mode)
(viper-set-replace-overlay, viper-key-to-emacs-key)
(viper-set-unread-command-events): Ditto.

* lisp/emulation/viper.el (viper-go-away, viper-set-hooks)
(viper-non-hook-settings): Remove XEmacs compat code.

Remove more XEmacs compat code from viper-*.el

* lisp/emulation/viper-cmd.el (viper-special-read-and-insert-char)
(viper-next-line-carefully, viper-next-line)
(viper-previous-line): Ditto.

* lisp/emulation/viper-mous.el (viper-surrounding-word)
(viper-parse-mouse-key): Remove XEmacs compat code.

Remove XEmacs-only code from snake.el

* lisp/play/snake.el (snake-mode): Remove XEmacs-only code.

Remove XEmacs code from tetris.el

* lisp/play/tetris.el (tetris-mode): Remove XEmacs-only code.

Remove XEmacs compat code from idlw-shell.el

* lisp/progmodes/idlw-shell.el (idlwave-shell-make-temp-file):
Make into obsolete alias.
(idlwave-shell-temp-file): Adjust callers.

Revert "Improve docstrings auto-generated by `define-minor-mode'"

This reverts commit a397fa06d18d6ae37a3a1288f269e1ae9eb3b569.
The original change breaks bootstrapping because of a circular dependency.

; Fix reported warnings

Use file-name-as-directory

* lisp/progmodes/project.el (project--vc-list-files): Use
file-name-as-directory, to be on the safe side.

Remove more XEmacs compat code in cperl-mode.el

* lisp/progmodes/cperl-mode.el (condition-case, cperl-problems)
(cperl-problems-old-emaxen, cperl-init-faces)
(cperl-word-at-point): Remove more XEmacs compat code.

Improve docstrings auto-generated by `define-minor-mode'

* lisp/emacs-lisp/easy-mmode.el (easy-mmode--mode-docstring):
When using `easy-mmode--arg-docstring' to auto-generate a
docstring, refill it up to `emacs-lisp-docstring-fill-column'.

More doc fixes in package.el (Bug#37544)

* lisp/emacs-lisp/package.el (package-menu-hide-low-priority)
(package-pinned-packages, package-load-descriptor)
package-archive-version, package-archive-contents)
package--read-archive-file, package-read-archive-contents)
(package-unsigned-archives, package-read-all-archive-contents)
(package--download-and-read-archives, package-install):
* lisp/subr.el (package--description-file):
* test/lisp/emacs-lisp/package-tests.el: Doc fixes.

Speed up project-files for Git projects

* lisp/progmodes/project.el (project-files): New method.
Implementation for VC projects that uses 'git ls-files' or 'hg
status --all' for listing.  With gratitude to Tassilo Horn who has
done most of the legwork and wrote the first version of the code
(https://lists.gnu.org/archive/html/emacs-devel/2019-10/msg00069.html).
(project--vc-list-files): New function, to be used by the above.
(project--find-regexp-in-files):
Silence warnings about nonexistent files.

Further improve button.el support for help-echo

The last change to forward-button added support for help-echo values
that are functions.  This patch fixes the arguments passed to such
functions and further adds support for help-echo values that are
forms (bug#37515).
* doc/lispref/display.texi (Button Properties): Fix description of
help-echo button property.
* lisp/button.el (button--help-echo): New function.
(forward-button): Use it.
(backward-button): Clarify help-echo reference in docstring.
* test/lisp/button-tests.el (button--help-echo-string)
(button--help-echo-form, button--help-echo-function): New tests.

Use lexical-binding in button.el

* lisp/button.el: Use lexical-binding.  Expand Keywords header.
Quote function symbols as such.  Use ;;;-comments where appropriate.
(button): Remove outdated commentary of defface.
(define-button-type, make-button, insert-button, make-text-button)
(insert-text-button): Clarify in docstring that PROPERTIES argument
is a plist.
(button-type-subtype-p, button-has-type-p): Do not overspecify
return value in docstring.
(button-put): Fix typo in commentary.

Preserve point better in hs-hide-comment-region

* lisp/progmodes/hideshow.el (hs-hide-comment-region): Preserve point
better when collapsing the region (bug#10856).

Copyright-paperwork-exempt: yes

Make lisp-do-defun do the right thing with trailing comments

* lisp/progmodes/inf-lisp.el (lisp-do-defun): Avoid including
trailing comments in the region (bug#7974).

Fix bytecomp.el warning a different way than the previous patch

* lisp/emacs-lisp/bytecomp.el (emacs-lisp-compilation-mode-map):
No need to use set-keymap-parent here; `define-derived-mode' will
do that automatically.

Fix comment in previous doc-view patch

* lisp/doc-view.el (doc-view-open-text): Comment fix.

In doc-view, keep point on the equivalent page in the text version

* lisp/doc-view.el (doc-view-open-text): After opening the text
version, put point on the page the user was reading (bug#16541).

* lisp/pcomplete.el: Mark 'pcomplete' command as obsolete

Remove redundant ':group's.
(pcomplete, pcomplete-help): Mark as obsolete.

Mention the vc diff switches in diff-switches

* lisp/vc/diff.el (diff-switches): Mention the vc diff switches in
the doc string (bug#4422).

C++ Mode: Correct the fontification of const auto foo

* lisp/progmodes/cc-engine.el (c-forward-decl-or-cast-1): Correct a coding
error involving `and' and `or'.

Touch up previous shr-dom-to-xml encoding change

* lisp/net/shr.el (shr-dom-to-xml): Include an XML declaration if
we're encoding the data.
(shr-parse-image-data): Add comment about why encoding is necessary.

Fix up previous SVG-multibyte fix

* lisp/net/shr.el (shr-dom-to-xml): For SVG images, take an
optional charset parameter to return unibyte data.
(shr-parse-image-data): Use it.
(shr-tag-svg): Ditto.
(svg--wrap-svg): Revert previous kludge.

C++ Mode: Fontify correctly declarators with identifier preceded by &

The problem was bar in the following being spuriously recognised as a
function, and foo as a type, as though the & were a *: Foo foo (&bar);.

* lisp/progmodes/cc-engine.el (c-forward-decl-or-cast-1): New variable
got-function-name-prefix, which is set when an operator like * (but not &)
precedes the putative identifer in parentheses.  Test this variable when
deciding whether or not to "move the type backwards" to the previous
identifier.

* lisp/progmodes/cc-langs.el (c-type-decl-operator-prefix-key): New lang const
and var.

Fix typo in last commit

Further adaptions for shadowfile-tests.el

* test/lisp/shadowfile-tests.el: Change some traces.
(shadow-test-remote-temporary-file-directory): Adapt also remote
home directory.
(shadow--tests-cleanup): Cleanup Tramp.

Don't use obsolete name in em-cmpl.el

* lisp/eshell/em-cmpl.el (eshell-complete-lisp-symbol): Update
reference to 'elisp-completion-at-point' from its obsolete name.
Reported by Carlos Pita <carlosjosepita@gmail.com>.  (Bug#31906)

* lisp/tab-bar.el (tab-bar-show): New defcustom.

* lisp/tab-bar.el (tab-bar-close-current-tab, tab-bar-close-tab):
(tab-bar-new-tab): Use tab-bar-show.

* doc/emacs/frames.texi (Tab Bars): Add tab-bar-show.

* lisp/speedbar.el (speedbar-mode): Set buffer-local tab-bar-mode
and tab-line-format to nil to not show in dedicated speedbar frame.

* src/w32inevt.c: Take into account FRAME_TAB_BAR_LINES.

* src/w32inevt.c (resize_event, maybe_generate_resize_event):
Subtract FRAME_TAB_BAR_LINES from FRAME_MENU_BAR_LINES.

Fix MS-Windows error when a directory on PATH doesn't exist

* src/w32.c (faccessat): Support more MS-Windows native error
codes that should be translated to ENOENT.  (Bug#37576)

Don't mention server-socket-dir in FAQ

server-socket-dir is a defvar, and users should use the defcustom
server-name instead.

* doc/misc/efaq.texi (Using an already running Emacs process): Remove
details on server-socket-dir, refer to Emacs Manual.  (Bug#20675)

Fix a typo in url-http.el

* lisp/url/url-http.el (url-http-parse-headers): Fix a typo.
Reported by Mattias Engdegård <mattiase@acm.org>.

Don't add trailing whitespace when passing argument to GDB

* lisp/progmodes/gdb-mi.el (gdb-send): Don't append whitespace to
'gdb-continuation'.  (Bug#25488)

Update a substitute-command-keys test

* test/src/doc-tests.el (doc-test-substitute-command-keys):
Update for recent minibuffer map change.

Gnus registry shutdown should also run the unload-hook

* lisp/gnus/gnus-registry.el (gnus-registry-clear): Clearing the
registry should also run the unload hooks.
  (gnus-registry-article-marks-to-names,
  gnus-registry-article-marks-to-chars): Now we can use a more general
  test here.

Merge branch 'feature/tabs'

Remove unused code and reformat to 70 columns.

Avoid bugging out on multibyte SVG data in shr

* lisp/net/shr.el (svg--wrap-svg): Ensure that the SVG data is
unibyte.

Respect buffer-local values in comint-read-input-ring

* lisp/comint.el (comint-read-input-ring): Use the buffer-local
values (bug#6432).

Remove old commented out XEmacs compat code from syntax.el (Bug#37524)

* lisp/emacs-lisp/syntax.el: Remove ancient commented out XEmacs
compat code.  This code has been commented out since 2001.

Remove XEmacs compat code from url-*.el (Bug#37524)

* lisp/url/url-file.el (url-file-build-filename, url-file)
* lisp/url/url-privacy.el (url-setup-privacy-info): Remove XEmacs
compat code.
(url-device-type): Declare obsolete.

Remove XEmacs compat code from winner.el (Bug#37524)

* lisp/winner.el (winner-active-region, winner-edges)
(winner-window-list, winner-sorted-window-list, winner-win-data)
(winner-make-point-alist): Remove XEmacs compat code.

Remove XEmacs compat code from term.el (Bug#37524)

* lisp/term.el (term-mode-map, term-raw-map, term-mouse-paste):
Remove XEmacs compat code.

Add support for Dired file marking from image-mode

* doc/emacs/files.texi (File Conveniences): Document them.

* lisp/image-mode.el (image-mode--mark-file): New function.
(image-mode-unmark-file, image-mode-mark-file)
(image-mode-copy-file-name-as-kill): New commands and keystrokes.

Move url-ns.el to obsolete/

* lisp/url/url-ns.el: Move from here...
* lisp/obsolete/url-ns.el: ...to here.  (Bug#19822)

Tweak mouse highlights in ediff-help

* lisp/vc/ediff-help.el (ediff-set-help-overlays): Only put the
mouse-face overlay on the actual commands (bug#5079).  This avoids
a problem when you have very wide frames: The leading blank
portion of the buffer would get the mouse highlights.

Remove XEmacs compat code from ediff-help.el

* lisp/vc/ediff-help.el (ediff-help-region-map)
(ediff-set-help-overlays, ediff-help-for-quick-help): Remove
XEmacs compat code.

Make the help page mention the customizeable global mode variable

* lisp/help-fns.el (help-fns--customize-variable): Factor out into
own function for reuse.
(help-fns--globalized-minor-mode): Use it to mention the
equivalent variable.

* lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode):
Mark globalized minor modes as such (bug#7177).

Fix build error in bytecomp.el from previous change