]> git.eshelyaron.com Git - emacs.git/log
emacs.git
6 years agoIndex profiler commands in elisp manual
Noam Postavsky [Tue, 28 Aug 2018 11:49:49 +0000 (07:49 -0400)]
Index profiler commands in elisp manual

* doc/lispref/debugging.texi (Profiling): Add index entries for
profiler-start, profiler-report, profiler-stop.

6 years agoFix math-imaginary-i check
Noam Postavsky [Wed, 15 Aug 2018 03:26:50 +0000 (23:26 -0400)]
Fix math-imaginary-i check

Reported by Bastian Erdnüß at
<https://lists.gnu.org/archive/html/emacs-devel/2018-08/msg00300.html>.
* lisp/calc/calc-cplx.el (math-imaginary-i): Check for a value
of (polar 1 <quarter-circle>).

6 years ago; Let pre-commit git hook check merged in changes (Bug#29197)
Noam Postavsky [Thu, 15 Feb 2018 00:58:07 +0000 (19:58 -0500)]
; Let pre-commit git hook check merged in changes (Bug#29197)

* build-aux/git-hooks/pre-commit: If GIT_MERGE_CHECK_OTHER is 'true',
check changes against the merge target, rather than the current
branch.  Include file name when giving error message about
non-standard characters.

6 years agoAvoid infinite hscrolling loops when line numbers are displayed
Eli Zaretskii [Tue, 28 Aug 2018 11:11:12 +0000 (14:11 +0300)]
Avoid infinite hscrolling loops when line numbers are displayed

* src/xdisp.c (maybe_produce_line_number): Don't produce line
numbers if we don't have enough screen estate.  (Bug#32351)

6 years agoAvoid crashes in malformed defvar
Eli Zaretskii [Tue, 28 Aug 2018 07:20:46 +0000 (10:20 +0300)]
Avoid crashes in malformed defvar

* src/eval.c (Fdefvar): Don't call XSYMBOL on something that
might not be a symbol.  This avoids crashes due to malformed
'defvar' forms.  (Bug#32552)

6 years ago* configure.ac (emacs_config_features): Add GLIB, XDBE, XIM.
Glenn Morris [Tue, 28 Aug 2018 01:46:14 +0000 (21:46 -0400)]
* configure.ac (emacs_config_features): Add GLIB, XDBE, XIM.

6 years ago* configure.ac: Doc fixes related to --with-xim.
Glenn Morris [Tue, 28 Aug 2018 01:44:29 +0000 (21:44 -0400)]
* configure.ac: Doc fixes related to --with-xim.

6 years agoSmall checkdoc quoting fix (bug#32546)
Glenn Morris [Mon, 27 Aug 2018 22:27:01 +0000 (18:27 -0400)]
Small checkdoc quoting fix (bug#32546)

* lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine):
Fix quoting thinko.

6 years agoFix detection of freed emacs_values (Bug#32479)
Sergey Vinokurov [Sun, 19 Aug 2018 20:31:01 +0000 (21:31 +0100)]
Fix detection of freed emacs_values (Bug#32479)

* src/emacs-module.c (module_free_global_ref): Compare a value to be
freed with all entries of the list.

* test/data/emacs-module/mod-test.c (Fmod_test_globref_free): New
function.
(emacs_module_init): Make it accessible from Lisp.
* test/src/emacs-module-tests.el (mod-test-globref-free-test): New
test which uses it.

6 years ago; Fix out-of-tree build for mod-test.so
Noam Postavsky [Sat, 25 Aug 2018 22:55:11 +0000 (18:55 -0400)]
; Fix out-of-tree build for mod-test.so

* test/Makefile.in: Don't look for emacs-module.h in $(srcdir), since
it is generated.

6 years agoAvoid crashes with very wide TTY frames on MS-Windows
Eli Zaretskii [Sat, 25 Aug 2018 12:26:41 +0000 (15:26 +0300)]
Avoid crashes with very wide TTY frames on MS-Windows

* src/w32console.c <glyph_base>: Reduce the number of elements
to 80.
<glyphs, glyphs_len>: New static variables.
(w32con_clear_end_of_line): If the line is wider than the
current size of the "empty row" in 'glyphs', reallocate
'glyphs' to support the full width of the frame.  This
avoids segfaults when the frame is wider than 256 columns.
(Bug#32445)

6 years agoPrevent `modify-file-local-variable-prop-line' from adding extra ';'
Wenjamin Petrenko [Tue, 14 Aug 2018 08:44:18 +0000 (11:44 +0300)]
Prevent `modify-file-local-variable-prop-line' from adding extra ';'

* lisp/files-x.el (modify-file-local-variable-prop-line): Handle
whitespace when checking if there's already a ';' before the
variable (Bug#23294).

Copyright-paperwork-exempt: yes

6 years agoUpdate GNOME bugtracker URLs
Glenn Morris [Fri, 24 Aug 2018 17:13:08 +0000 (13:13 -0400)]
Update GNOME bugtracker URLs

* configure.ac, admin/notes/multi-tty, etc/PROBLEMS:
* src/emacs.c (main):
* src/xterm.c (x_connection_closed): Update GNOME bugtracker URLs.
; * src/gtkutil.c (xg_display_close):
; * src/image.c (svg_load_image): Update URLs in comments.

6 years agoClarify in the Emacs manual that ChangeLog files are not used
Eli Zaretskii [Thu, 23 Aug 2018 17:02:27 +0000 (20:02 +0300)]
Clarify in the Emacs manual that ChangeLog files are not used

* doc/emacs/trouble.texi (Sending Patches): Use "commit log"
instead of "change log", to avoid the interpretation that we
are talking about literal ChangeLog files.  (Bug#32359)

6 years agoRecognize codepage 65001 as a valid encoding
Eli Zaretskii [Tue, 21 Aug 2018 16:35:31 +0000 (19:35 +0300)]
Recognize codepage 65001 as a valid encoding

* lisp/international/mule-conf.el (cp65001): Define it as an
alias for UTF-8.

6 years ago; * etc/NEWS: Fix format of first lines of some entries.
Eli Zaretskii [Tue, 21 Aug 2018 15:58:15 +0000 (18:58 +0300)]
; * etc/NEWS: Fix format of first lines of some entries.

6 years agoAvoid compilation warning in nt/addpm.c
Eli Zaretskii [Sat, 18 Aug 2018 13:10:28 +0000 (16:10 +0300)]
Avoid compilation warning in nt/addpm.c

* nt/addpm.c [!MINGW_W64]: Undefine _WIN32_IE before
redefining it, to avoid compilation warnings.

6 years agoFix duplicate custom group names in bibtex.el
Basil L. Contovounesios [Wed, 15 Aug 2018 07:03:23 +0000 (10:03 +0300)]
Fix duplicate custom group names in bibtex.el

* lisp/textmodes/bibtex.el (bibtex-BibTeX-entry-alist):
Change :group from BibTeX to bibtex.  (bug#32436)

6 years agoFix outdated text in the Calc manual
Eli Zaretskii [Fri, 17 Aug 2018 14:22:44 +0000 (17:22 +0300)]
Fix outdated text in the Calc manual

* doc/misc/calc.texi (Internals): Don't advertise
'calc-extensions' which no longer exists.  Reported by Francis
Wright <francis.j.wright@gmail.com>.

6 years agoPort better to x86 -fexcess-precision=fast
Paul Eggert [Sun, 12 Aug 2018 22:28:20 +0000 (15:28 -0700)]
Port better to x86 -fexcess-precision=fast

Problem reported by Eli Zaretskii in:
https://lists.gnu.org/r/emacs-devel/2018-08/msg00380.html
* src/data.c (arithcompare): Work around incompatibility
between gcc -fexcess-precision=fast and the C standard on x86,
by capturing the results of floating-point comparisons before
the excess precision spontaneously decays.  Although this fix
might not work in general, it does work here and is probably
good enough for the platforms we care about.

(cherry picked from commit a84cef90957f2379cc0df6bd908317fc441971ce)

6 years agoAdd comment about floating point test
Paul Eggert [Mon, 13 Aug 2018 16:36:11 +0000 (09:36 -0700)]
Add comment about floating point test

* test/src/data-tests.el (data-tests--float-greater-than-fixnums):
New constant.
(data-tests-=, data-tests-<, data-tests->, data-tests-<=)
(data-tests->=, data-tests-min): Use it.

6 years agoIbuffer: Add toggle ibuffer-do-toggle-lock
Tino Calancha [Mon, 13 Aug 2018 10:24:31 +0000 (19:24 +0900)]
Ibuffer: Add toggle ibuffer-do-toggle-lock

Toggle the locked status in marked buffers or the buffer
at point (Bug#32421).
* lisp/ibuffer.el (ibuffer-do-toggle-lock): New command.
(ibuffer-mode-map): Bind it to 'L'.
(ibuffer-mode-operate-map): Add entries for
`ibuffer-do-toggle-read-only' and `ibuffer-do-toggle-lock'.
* etc/NEWS (Changes in Specialized Modes and Packages in Emacs 26.2):
Announce the change.

6 years agoIbuffer: Detect correctly the buffers running a process
Tino Calancha [Mon, 13 Aug 2018 10:22:49 +0000 (19:22 +0900)]
Ibuffer: Detect correctly the buffers running a process

* lisp/ibuffer.el (filename-and-process): Store the process buffer
as a text property; check for such property to detect a buffer
with a process (Bug#32420).

6 years agoBackport fix for Bug#32226
Michael Albinus [Sun, 12 Aug 2018 16:15:24 +0000 (18:15 +0200)]
Backport fix for Bug#32226

* test/lisp/shadowfile-tests.el: Set Tramp variables for hydra.
(shadow-test06-literal-groups, shadow-test07-regexp-groups)
(shadow-test08-shadow-todo, shadow-test09-shadow-copy-files):
Use `set-visited-file-name' instead of setting the value in
`buffer-file-name' directly.
(shadow-test08-shadow-todo, shadow-test09-shadow-copy-files):
Test for writable temporary directory.  Suppress errors in
cleanup.  (Bug#32226)

6 years ago; * lisp/simple.el (line-move-visual): Fix typo.
Charles A. Roelli [Sun, 12 Aug 2018 11:05:27 +0000 (13:05 +0200)]
; * lisp/simple.el (line-move-visual): Fix typo.

6 years agoDo not consider external packages to be removable (Bug#27822)
Yuri D'Elia [Tue, 17 Jul 2018 10:59:35 +0000 (12:59 +0200)]
Do not consider external packages to be removable (Bug#27822)

Packages which are not directly user-installed shouldn't be autoremoved,
since they can be setup through a different path (via
`package-directory-list') where we have no authority over.
* lisp/emacs-lisp/package.el (package--user-installed-p): New
function.
(package--removable-packages): Use it.

6 years ago* src/alloc.c: Remove obsolete comments.
Paul Eggert [Sat, 11 Aug 2018 19:13:53 +0000 (12:13 -0700)]
* src/alloc.c: Remove obsolete comments.

6 years agoBetter support utf-8-with-signature and utf-8-hfs in HTML
Eli Zaretskii [Sat, 11 Aug 2018 09:01:37 +0000 (12:01 +0300)]
Better support utf-8-with-signature and utf-8-hfs in HTML

* lisp/international/mule.el (sgml-html-meta-auto-coding-function):
Support UTF-8 with BOM and utf-8-hfs as variants of UTF-8, and
obey the buffer's encoding if it is one of these variants, instead
of re-encoding in UTF-8 proper.  (Bug#20623)

6 years agoDon't use -Wabi compiler option
Eli Zaretskii [Sat, 11 Aug 2018 08:38:43 +0000 (11:38 +0300)]
Don't use -Wabi compiler option

* configure.ac: Add -Wabi to the list of disabled warning
options.  For the details, see
http://lists.gnu.org/archive/html/emacs-devel/2018-08/msg00123.html.

6 years agoFix bugs in `auth-source-netrc-parse-one'.
Filipp Gunbin [Tue, 15 May 2018 00:02:49 +0000 (03:02 +0300)]
Fix bugs in `auth-source-netrc-parse-one'.

* lisp/auth-source.el (auth-source-netrc-parse-one): Ensure that match
  data is not overwritten in `auth-source-netrc-parse-next-interesting'.
  Ensure that blanks are skipped before and after going over comments
  and eols.
* test/lisp/auth-source-tests.el (auth-source-test-netrc-parse-one): New test.

(cherry picked from commit 60ff8101449eea3a5ca4961299501efd83d011bd)

6 years agoFix copying text properties by 'format'
Eli Zaretskii [Thu, 9 Aug 2018 15:08:35 +0000 (18:08 +0300)]
Fix copying text properties by 'format'

* src/editfns.c (styled_format): Add the spec beginning index
to the info recorded for each format spec, and use it to
detect the case that a format spec and its text property end
where the next spec with another property begins.  (Bug#32404)

* test/src/editfns-tests.el (format-properties): Add tests for
bug#32404.

6 years agoImprove error messages regarding initial-buffer-choice (Bug#29098)
Alexander Gramiak [Wed, 1 Nov 2017 03:10:52 +0000 (21:10 -0600)]
Improve error messages regarding initial-buffer-choice (Bug#29098)

* lisp/startup.el (command-line-1) <initial-buffer-choice>: Make the
messages conform to Emacs conventions, and show the invalid return
value in the message.

6 years ago* test/lisp/wdired-tests.el (wdired-test-unfinished-edit-01): Fix typo.
Glenn Morris [Wed, 8 Aug 2018 23:58:29 +0000 (19:58 -0400)]
* test/lisp/wdired-tests.el (wdired-test-unfinished-edit-01): Fix typo.

6 years agoMake async :family 'local failures fail correctly again
Lars Ingebrigtsen [Sun, 22 Jul 2018 11:39:10 +0000 (13:39 +0200)]
Make async :family 'local failures fail correctly again

* src/fileio.c (get_file_errno_data): Refactor out into its own
function so that we can reuse the error handling from an async
context (bug#31901).

* src/process.c (connect_network_socket): When an async :family
'local client fails (with a file error, for instance), mark the
process as failed.

(cherry picked from commit 92ba34d89ac4f5b5bbb818e1c39a3cc12a405790)

6 years agoFix emacsclient check for term.el buffer (Bug#21041)
Noam Postavsky [Tue, 24 Jul 2018 01:01:01 +0000 (21:01 -0400)]
Fix emacsclient check for term.el buffer (Bug#21041)

* lib-src/emacsclient.c (find_tty): Check for any TERM value with
prefix of "eterm", not just "eterm" itself.  Also check for ",term:"
in INSIDE_EMACS value.

6 years agoImprove documentation of 'set-fontset-font'
Eli Zaretskii [Wed, 8 Aug 2018 15:24:45 +0000 (18:24 +0300)]
Improve documentation of 'set-fontset-font'

* doc/lispref/display.texi (Fontsets): Fix description of
'set-fontset-font'.
* src/fontset.c (Fset_fontset_font): Doc fix.  (Bug#32401)

6 years agoImprove documentation of M-?
Eli Zaretskii [Tue, 7 Aug 2018 16:15:41 +0000 (19:15 +0300)]
Improve documentation of M-?

* doc/emacs/maintaining.texi (Identifier Search):
* lisp/progmodes/xref.el (xref-find-references): Improve
documentation of xref-find-references and
xref-prompt-for-identifier.  (Bug#32389)

6 years agoReinterpret Esperanto characters in iso-transl as iso-8859-3.
Ivan Shmakov [Sun, 5 Aug 2018 21:45:46 +0000 (21:45 +0000)]
Reinterpret Esperanto characters in iso-transl as iso-8859-3.

* lisp/international/iso-transl.el (iso-transl-language-alist):
Reinterpret Esperanto characters as iso-8859-3 (were: iso-8859-1).
(Bug#32371)

6 years agoFix Flyspell mode when several languages are mixed in a buffer
Eli Zaretskii [Tue, 7 Aug 2018 15:35:12 +0000 (18:35 +0300)]
Fix Flyspell mode when several languages are mixed in a buffer

* lisp/textmodes/flyspell.el (flyspell-external-point-words):
Handle "misspelled" words that actually belong to a language
unsupported by the current dictionary.  (Bug#32280)  Fix the test
for Ispell the program.

6 years agoNew function read-answer (Bug#31782)
Juri Linkov [Sun, 21 Jan 2018 21:45:43 +0000 (23:45 +0200)]
New function read-answer (Bug#31782)

* lisp/emacs-lisp/map-ynp.el (read-answer-short): New defcustom.
(read-answer): New function.
* lisp/subr.el (assoc-delete-all): New function.
* etc/NEWS: Announce them.

* lisp/dired.el (dired-delete-file): Use read-answer.
(dired--yes-no-all-quit-help): Remove function.
(dired-delete-help): Remove defconst.

(backported from master, "New function read-answer (bug#30073)" and
"Respect non-saved value of `read-short-answer' (Bug#31782)")

6 years agoAvoid assertion violations in maybe_produce_line_number
Eli Zaretskii [Thu, 2 Aug 2018 13:58:44 +0000 (16:58 +0300)]
Avoid assertion violations in maybe_produce_line_number

* src/xdisp.c (redisplay_window): Make sure desired_matrix is
cleared before calling try_window.  This is important when
display-line-numbers is non-nil, because line-number display code
assumes each glyph row is completely cleared when it is called to
produce a line number.  (Bug#32358)

6 years agoAvoid assertion violations in set_text_properties_1
Eli Zaretskii [Thu, 2 Aug 2018 13:29:54 +0000 (16:29 +0300)]
Avoid assertion violations in set_text_properties_1

* src/textprop.c (set_text_properties): If the call to
modify_text_properties modifies the interval tree as side effect,
recalculate the correct interval for START and END.  (Bug#32265)

6 years ago; Auto-commit of loaddefs files.
Glenn Morris [Wed, 1 Aug 2018 10:28:34 +0000 (06:28 -0400)]
; Auto-commit of loaddefs files.

6 years agoFix wdired test failure when byte compiled (bug#32318)
Stephen Berman [Mon, 30 Jul 2018 22:42:52 +0000 (00:42 +0200)]
Fix wdired test failure when byte compiled (bug#32318)

* test/lisp/wdired-tests.el: Require wdired.  Defvar dired-query
to silence byte-compiler.

6 years ago* test/lisp/wdired-tests.el (wdired-test-symlink-name): New test.
Stephen Berman [Mon, 30 Jul 2018 12:12:50 +0000 (14:12 +0200)]
* test/lisp/wdired-tests.el (wdired-test-symlink-name): New test.

6 years agoFix url's thing-at-point beginning-op (Bug#32028)
Raimon Grau [Sun, 1 Jul 2018 20:31:08 +0000 (21:31 +0100)]
Fix url's thing-at-point beginning-op (Bug#32028)

* lisp/thingatpt.el (url): Fix beginning-op making.

6 years agoFix last change in 'char_width'
Eli Zaretskii [Sun, 29 Jul 2018 14:42:11 +0000 (17:42 +0300)]
Fix last change in 'char_width'

* src/character.c (char_width): Make sure variable C is always
initialized.  (Bug#32276)

6 years agoAdd initial tests for wdired.el
Stephen Berman [Sat, 28 Jul 2018 22:22:02 +0000 (00:22 +0200)]
Add initial tests for wdired.el

* test/lisp/wdired-tests.el: New file.

6 years agoFix use of non-nil wdired-use-interactive-rename
Stephen Berman [Sat, 28 Jul 2018 21:58:15 +0000 (23:58 +0200)]
Fix use of non-nil wdired-use-interactive-rename

This is a fairly minimal fix for the release branch; a more
comprehensive fix is on master, so do not merge this to master.

* lisp/wdired.el (wdired-search-and-rename): Remove dired-filename
text property in order to find new filename when it only partially
replaces old filename (bug#32173).  If user quits before renaming
succeeds, restore the dired-filename text property.

6 years ago; Fix last change: only MinGW runtime 5.0.2 and later needs that.
Eli Zaretskii [Sat, 28 Jul 2018 14:21:53 +0000 (17:21 +0300)]
; Fix last change: only MinGW runtime 5.0.2 and later needs that.

6 years agoFix compilation with mingw.org's MinGW 5.x headers
Eli Zaretskii [Sat, 28 Jul 2018 12:34:00 +0000 (15:34 +0300)]
Fix compilation with mingw.org's MinGW 5.x headers

6 years agoUpdate the list of special forms in the ELisp manual
Eli Zaretskii [Sat, 28 Jul 2018 07:22:04 +0000 (10:22 +0300)]
Update the list of special forms in the ELisp manual

* doc/lispref/eval.texi (Special Forms):
* doc/lispref/frames.texi (Mouse Tracking): 'track-mouse' is
nowadays a macro.  (Bug#32284)

6 years agoDon't fail to indent-sexp before a full sexp (Bug#31984)
Noam Postavsky [Fri, 27 Jul 2018 23:41:39 +0000 (19:41 -0400)]
Don't fail to indent-sexp before a full sexp (Bug#31984)

* lisp/emacs-lisp/lisp-mode.el (indent-sexp): Only signal error if the
initial forward-sexp fails.  Suppress scan-error forn any of the
forward-sexp calls after that.
* test/lisp/emacs-lisp/lisp-mode-tests.el (indent-sexp-cant-go): New
test.

6 years agoFix calls to modifications hooks in replace-buffer-contents
Eli Zaretskii [Fri, 27 Jul 2018 10:04:19 +0000 (13:04 +0300)]
Fix calls to modifications hooks in replace-buffer-contents

* src/editfns.c (Freplace_buffer_contents): Call the modification
hooks on the entire region where replacements could have taken
place.  The previous attempts of being more accurate just
introduced bugs.  (Bug#32278)

6 years ago* src/character.c (char_width): Support glyphs with faces. (Bug#32276)
Eli Zaretskii [Fri, 27 Jul 2018 09:33:29 +0000 (12:33 +0300)]
* src/character.c (char_width): Support glyphs with faces.  (Bug#32276)

6 years agoDisplay raw bytes as belonging to 'eight-bit' charset
Eli Zaretskii [Fri, 27 Jul 2018 06:47:37 +0000 (09:47 +0300)]
Display raw bytes as belonging to 'eight-bit' charset

* lisp/descr-text.el (describe-char):
* lisp/simple.el (what-cursor-position): Display characters in the
range #x3FFF80..#x3FFF9F as belonging to charset 'eight-bit', not
'tis620-2533'.
* lisp/international/mule-diag.el (describe-character-set):
Improve description of :supplementary-p.

6 years ago; * doc/emacs/mule.texi (International Chars): Fix last change.
Eli Zaretskii [Fri, 27 Jul 2018 05:54:44 +0000 (08:54 +0300)]
; * doc/emacs/mule.texi (International Chars): Fix last change.

6 years agoFix inaccurate text in the user manual
Eli Zaretskii [Thu, 26 Jul 2018 18:38:09 +0000 (21:38 +0300)]
Fix inaccurate text in the user manual

* doc/emacs/mule.texi (International Chars): Correct inaccurate
description of raw bytes display by "C-x =".

6 years agoCopyedits in tramp.texi, improved example with bash's readline
Michael Albinus [Thu, 26 Jul 2018 09:54:33 +0000 (11:54 +0200)]
Copyedits in tramp.texi, improved example with bash's readline

* doc/misc/tramp.texi (all): Unify some wordings.
(Frequently Asked Questions): Update example with bash's readline.

6 years agoMinor Tramp doc update
Michael Albinus [Wed, 25 Jul 2018 18:26:22 +0000 (20:26 +0200)]
Minor Tramp doc update

* doc/misc/tramp.texi (Frequently Asked Questions): Disable bash's
INPUTRC.

6 years agoFile Shadowing is not available on MS Windows
Michael Albinus [Wed, 25 Jul 2018 15:34:55 +0000 (17:34 +0200)]
File Shadowing is not available on MS Windows

* doc/emacs/files.texi (File Shadowing): File Shadowing is not
available on MS Windows.

* test/lisp/shadowfile-tests.el (shadow-test00-clusters)
(shadow-test01-sites, shadow-test02-files)
(shadow-test03-expand-cluster-in-file-name)
(shadow-test04-contract-file-name, shadow-test05-file-match)
(shadow-test06-literal-groups, shadow-test07-regexp-groups)
(shadow-test08-shadow-todo, shadow-test09-shadow-copy-files):
Skip under MS Windows.

6 years ago; Minor markup change in indent.texi
Eli Zaretskii [Wed, 25 Jul 2018 14:22:29 +0000 (17:22 +0300)]
; Minor markup change in indent.texi

* doc/emacs/indent.texi (Indentation Commands): Use
@kbd{@key{...}} for better looks.  (Bug#32248)

6 years ago; bookmark-jump: Add comment about last change.
Noam Postavsky [Tue, 24 Jul 2018 22:45:43 +0000 (18:45 -0400)]
; bookmark-jump: Add comment about last change.

6 years agoLet bookmark-jump override window-point (Bug#31751)
Noam Postavsky [Tue, 24 Jul 2018 01:49:00 +0000 (21:49 -0400)]
Let bookmark-jump override window-point (Bug#31751)

* lisp/bookmark.el (bookmark-jump): Use pop-to-buffer-same-window
instead of switch-to-buffer, the latter obeys
switch-to-buffer-preserve-window-point and so loses the bookmark's
point.

6 years agoOmit keymap from subword-mode docstring (Bug#32212)
Noam Postavsky [Sun, 22 Jul 2018 20:15:43 +0000 (16:15 -0400)]
Omit keymap from subword-mode docstring (Bug#32212)

* lisp/progmodes/subword.el (subword-mode): Remove listing of
subword-mode-map bindings, since it is empty as of 2014-03-23 "Merge
capitalized-words-mode and subword-mode".

6 years agoPrevent line-mode term from showing user passwords
Tino Calancha [Thu, 15 Feb 2018 00:09:50 +0000 (09:09 +0900)]
Prevent line-mode term from showing user passwords

For buffers whose mode derive from comint-mode, the user password is
read from the minibuffer and it's hidden.  A buffer in term-mode and
line submode, instead shows the passwords.  Make buffers in line
term-mode to hide passwords too (Bug#30190).

* lisp/term.el (term-send-invisible): Prefer the more robust
`read-passwd' instead of `term-read-noecho'.
(term-watch-for-password-prompt): New function.
(term-emulate-terminal): Call it each time we receive non-escape
sequence output.

Co-authored-by: Noam Postavsky <npostavs@gmail.com>
6 years agoCheck for special filenames in eshell (Bug#30724)
Jonathan Kyle Mitchell [Tue, 17 Jul 2018 02:46:20 +0000 (21:46 -0500)]
Check for special filenames in eshell (Bug#30724)

* lisp/eshell/esh-cmd.el (eshell-lisp-command): Check for "~"
in lisp commands with the eshell-filename-arguments property
(Bug#30724).

* lisp/eshell/em-dirs.el (eshell/cd, eshell/pushd, eshell/popd):
* lisp/eshell/em-ls.el (eshell/ls):
* lisp/eshell/em-unix.el (eshell/rm, eshell/mkdir, eshell/rmdir)
(eshell/mv, eshell/cp, eshell/ln, eshell/cat, eshell/du, eshell/diff):
* lisp/eshell/esh-ext.el (eshell/addpath): Add
eshell-filename-arguments to symbol plist.

6 years agoFix indent-sexp of #s(...) (Bug#31984)
Noam Postavsky [Thu, 19 Jul 2018 10:40:54 +0000 (06:40 -0400)]
Fix indent-sexp of #s(...) (Bug#31984)

* lisp/emacs-lisp/lisp-mode.el (indent-sexp): Look for a sexp that
ends after the current line.
* test/lisp/emacs-lisp/lisp-mode-tests.el (indent-sexp-go): New test.

6 years agoAdd save-match-data to abbreviate-file-name (Bug#32201)
Noam Postavsky [Wed, 18 Jul 2018 22:45:47 +0000 (18:45 -0400)]
Add save-match-data to abbreviate-file-name (Bug#32201)

* lisp/files.el (abbreviate-file-name): Save match-data around
expand-file-name; it is not guaranteed to preserve match-data, and may
well do so depending on what file handlers and hooks are in effect.

6 years agoFix last change in editfns.c
Eli Zaretskii [Sat, 21 Jul 2018 19:27:33 +0000 (22:27 +0300)]
Fix last change in editfns.c

* src/editfns.c (Freplace_buffer_contents): Fix last change: always
call buffer modification hooks, even if nothing was deleted/inserted.
(bug#32237)

6 years agoFix calls to buffer modification hooks from replace-buffer-contents
Eli Zaretskii [Sat, 21 Jul 2018 18:05:52 +0000 (21:05 +0300)]
Fix calls to buffer modification hooks from replace-buffer-contents

* src/editfns.c (Freplace_buffer_contents): Don't call buffer
modification hooks if nothing was deleted/inserted.  (Bug#32237)

6 years ago; etc/NEWS: Remove unnecessary reference to a bug number.
Eli Zaretskii [Sat, 21 Jul 2018 16:44:38 +0000 (19:44 +0300)]
; etc/NEWS: Remove unnecessary reference to a bug number.

6 years agoFix Bug#32226
Michael Albinus [Sat, 21 Jul 2018 10:29:06 +0000 (12:29 +0200)]
Fix Bug#32226

* lisp/shadowfile.el (shadow-site-name, shadow-name-site):
Use "[-.[:word:]]+" as hostname regexp.  (Bug#32226)

* test/lisp/shadowfile-tests.el (shadow-test06-literal-groups)
(shadow-test07-regexp-groups, shadow-test08-shadow-todo)
(shadow-test09-shadow-copy-files): Skip if needed.

6 years agoImprove doc strings of several variables in keyboard.c
Eli Zaretskii [Sat, 21 Jul 2018 09:28:11 +0000 (12:28 +0300)]
Improve doc strings of several variables in keyboard.c

* src/keyboard.c (syms_of_keyboard) <debug-on-event>
<attempt-stack-overflow-recovery>
<attempt-orderly-shutdown-on-fatal-signal>: Make sure the first
sentence of the doc string fits on a single line.

6 years agoFix (Bug#32218). Do not merge with master
Michael Albinus [Fri, 20 Jul 2018 08:56:41 +0000 (10:56 +0200)]
Fix (Bug#32218).  Do not merge with master

* doc/misc/trampver.texi:
* lisp/net/trampver.el: Change version to "2.3.4.26.2".
(customize-package-emacs-version-alist): Add Tramp version
integrated in Emacs 26.2.

* lisp/net/tramp.el (tramp-handle-file-truename):
* lisp/net/tramp-adb.el (tramp-adb-handle-file-truename):
* lisp/net/tramp-sh.el (tramp-sh-handle-file-truename): Fix problem
with trailing slash.  (Bug#32218)

* test/lisp/net/tramp-tests.el (tramp-test21-file-links):
Remove `tramp--test-emacs27-p' check.

6 years agoImprove documentation of 'pcase-defmacro rx'
Eli Zaretskii [Fri, 20 Jul 2018 08:44:36 +0000 (11:44 +0300)]
Improve documentation of 'pcase-defmacro rx'

* lisp/emacs-lisp/rx.el (rx): Clarify and improve the doc string.
For the details, see the discussion starting at
http://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00399.html.

6 years agoFix TTY colors breakage by 'clear-face-cache'
Eli Zaretskii [Thu, 19 Jul 2018 17:44:32 +0000 (20:44 +0300)]
Fix TTY colors breakage by 'clear-face-cache'

Without examining the right frame, 'tty-color-24bit' was erroneously
treating a GUI frame as a 24-bit TTY frame.
* lisp/term/tty-colors.el (tty-color-24bit): Accept optional
argument DISPLAY and pass it to display-color-cells.  Doc fix.
(tty-color-define, tty-color-desc): Pass the FRAME argument to
tty-color-24bit.  (Bug#32072)

6 years ago* admin/MAINTAINERS: Add files maintained by me (Michael Albinus).
Michael Albinus [Wed, 18 Jul 2018 14:52:12 +0000 (16:52 +0200)]
* admin/MAINTAINERS: Add files maintained by me (Michael Albinus).

6 years agoAdapt shadowfile.el for Tramp (Bug#4526, Bug#4846)
Michael Albinus [Wed, 18 Jul 2018 14:51:56 +0000 (16:51 +0200)]
Adapt shadowfile.el for Tramp  (Bug#4526, Bug#4846)

* etc/NEWS: Mention changes in shadowfile.el.

* lisp/shadowfile.el (top): Require 'tramp instead of 'ange-ftp.
(shadow-cluster): New defstruct.
(shadow-make-cluster, shadow-cluster-name, shadow-cluster-primary)
(shadow-cluster-regexp, shadow-get-user)
(shadow-parse-fullname): Remove.
(shadow-info-file, shadow-todo-file, shadow-system-name)
(shadow-homedir, shadow-regexp-superquote, shadow-suffix)
(shadow-set-cluster, shadow-get-cluster, shadow-site-name)
(shadow-name-site, shadow-site-primary, shadow-site-cluster)
(shadow-read-site, shadow-parse-name, shadow-make-fullname)
(shadow-replace-name-component, shadow-local-file)
(shadow-expand-cluster-in-file-name, shadow-contract-file-name)
(shadow-same-site, shadow-file-match, shadow-define-cluster)
(shadow-define-literal-group, shadow-define-regexp-group)
(shadow-make-group, shadow-shadows-of-1, shadow-read-files)
(shadow-write-info-file, shadow-write-todo-file)
(shadow-initialize): Adapt variables and functions.

* test/lisp/shadowfile-tests.el: New file.

6 years agoFix auth-source-delete (Bug#26184)
Noam Postavsky [Wed, 18 Jul 2018 01:00:27 +0000 (21:00 -0400)]
Fix auth-source-delete (Bug#26184)

* lisp/auth-source.el (auth-source-delete): Fix `auth-source-search'
call.
* test/lisp/auth-source-tests.el (auth-source-delete): New test.

6 years agoAvoid assertion violations in gnutls.c
Eli Zaretskii [Tue, 17 Jul 2018 16:58:27 +0000 (19:58 +0300)]
Avoid assertion violations in gnutls.c

* src/gnutls.c (Fgnutls_hash_digest, gnutls_symmetric)
(Fgnutls_hash_mac): Check CONSP before invoking XCDR.  (Bug#32187)
Report values of invalid arguments when signaling an error.

6 years agoDon't use a literal "C-u" in ispell.el help message text
Eli Zaretskii [Sat, 14 Jul 2018 15:53:40 +0000 (18:53 +0300)]
Don't use a literal "C-u" in ispell.el  help message text

* lisp/textmodes/ispell.el (ispell-command-loop): Use
"\\[universal-argument]" instead of a literal "C-u".  (Bug#32142)

6 years agoImprove documentation of 'seqp'
Eli Zaretskii [Sat, 14 Jul 2018 08:18:04 +0000 (11:18 +0300)]
Improve documentation of 'seqp'

* doc/lispref/sequences.texi (Sequence Functions): Add text to
explain the relation between 'seqp' and 'sequencep'.  (Bug#32125)

6 years agoClarify usage and dependencies between several Flyspell features
Eli Zaretskii [Sat, 14 Jul 2018 07:43:32 +0000 (10:43 +0300)]
Clarify usage and dependencies between several Flyspell features

* lisp/textmodes/flyspell.el (flyspell-region)
(flyspell-small-region, flyspell-persistent-highlight):
Documentation improvements.  (Bug#32142)

6 years agoUse consistent function names in thread-tests.el
Michael Albinus [Fri, 13 Jul 2018 12:28:12 +0000 (14:28 +0200)]
Use consistent function names in thread-tests.el

* test/src/thread-tests.el (threads-call-error, threads-custom)
(threads-errors, threads-sticky-point, threads-signal-early):
Rename, using naming convention to prefix with "threads-".

6 years agoFix format error in Faccept_process_output
Michael Albinus [Fri, 13 Jul 2018 12:27:33 +0000 (14:27 +0200)]
Fix format error in Faccept_process_output

* src/process.c (Faccept_process_output): Do not use format spec
"%p", it isn't valid for error().

6 years agoLessen stack consumption in recursive read1
Paul Eggert [Fri, 13 Jul 2018 03:23:07 +0000 (20:23 -0700)]
Lessen stack consumption in recursive read1

* src/lread.c (read1): Shrink local buffer size from
MAX_ALLOCA to 128 (Bug#31995).

6 years agoMatch w32 paths in grep sans --null hits (Bug#32051)
Noam Postavsky [Mon, 9 Jul 2018 20:56:47 +0000 (16:56 -0400)]
Match w32 paths in grep sans --null hits (Bug#32051)

* lisp/progmodes/grep.el (grep-regexp-alist): Add an optional part to
match paths starting with C: (other drive letters).
* test/lisp/progmodes/compile-tests.el
(compile-tests--grep-regexp-testcases)
(compile-tests--grep-regexp-tricky-testcases)
(compile-test-grep-regexps): New tests.
(compile--test-error-line): Return `compilation-message'.

6 years agoFix previous make-network-process change
Noam Postavsky [Thu, 12 Jul 2018 23:41:03 +0000 (19:41 -0400)]
Fix previous make-network-process change

* src/process.c (Fmake_network_process): On 2018-07-09 "Explicitly
reject :server and :nowait (Bug#31903)", the sense of the SERVER check
was accidentally reversed so that we ended up looking for the wrong
ADDRESS.  Reported by T.V Raman in
<https://lists.gnu.org/archive/html/emacs-devel/2018-07/msg00437.html>.

6 years agoAnother documentation improvement in flyspell.el
Eli Zaretskii [Thu, 12 Jul 2018 16:24:06 +0000 (19:24 +0300)]
Another documentation improvement in flyspell.el

* lisp/textmodes/flyspell.el (flyspell-persistent-highlight): Doc
fix.

6 years agoImprove documentation of Flyspell
Eli Zaretskii [Thu, 12 Jul 2018 15:59:18 +0000 (18:59 +0300)]
Improve documentation of Flyspell

For the background, see
http://lists.gnu.org/archive/html/help-gnu-emacs/2018-07/msg00099.html.

* doc/emacs/fixit.texi (Spelling): Add a couple of caveats.
* lisp/textmodes/flyspell.el: Update commentary.

6 years agoProvide feature 'threads
Michael Albinus [Thu, 12 Jul 2018 08:49:06 +0000 (10:49 +0200)]
Provide feature 'threads

* src/thread.c (syms_of_threads): Provide feature "threads".

* test/src/thread-tests.el (top): Declare the functions.
(all): Use (featurep 'threads) check.

6 years agoSave the server alias on reconnect (Bug#29657)
Miciah Masters [Mon, 11 Dec 2017 01:14:09 +0000 (20:14 -0500)]
Save the server alias on reconnect (Bug#29657)

rcirc does not retain the server alias on reconnect.  As a result, rcirc
fails to re-use server and channel buffers when an alias is used.  Further
problems may ensue when aliases are used to differentiate multiple
connections to the same host, for example when using a single IRC bouncer
or proxy to connect to multiple IRC networks.

Save the server alias when connecting to a server so that reconnect will
retain the alias.
* lisp/net/rcirc.el (rcirc-connect): Include server-alias when setting
rcirc-connection-info.

Copyright-paperwork-exempt: yes

6 years agoRefer to "proper lists" instead of "true lists"
Basil L. Contovounesios [Wed, 11 Jul 2018 02:51:28 +0000 (19:51 -0700)]
Refer to "proper lists" instead of "true lists"

* doc/lispref/lists.texi (Cons Cells, Building Lists):
* doc/lispref/sequences.texi (Vector Functions): Use the more
popular term "proper", rather than "true", to qualify nil-terminated
lists.

For discussion, see the following emacs-devel subthreads:
https://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00112.html
https://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00138.html

6 years agoAvoid turning on the global-minor-mode recursively
John Shahid [Sat, 23 Jun 2018 15:12:44 +0000 (11:12 -0400)]
Avoid turning on the global-minor-mode recursively

* lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Clear
the buffer-list inside MODE-enable-in-buffers to avoid enabling the
mode recursively.  (Bug#31793)

6 years agoFix Bug#32085
Michael Albinus [Tue, 10 Jul 2018 07:49:49 +0000 (09:49 +0200)]
Fix Bug#32085

* doc/misc/tramp.texi (GVFS based methods): `dav' and `davs' do
not support paths in the volume name.  (Bug#32085)

6 years agoStop using indent-line-to in lisp-indent-line (Bug#32014)
Noam Postavsky [Fri, 29 Jun 2018 23:58:58 +0000 (19:58 -0400)]
Stop using indent-line-to in lisp-indent-line (Bug#32014)

This is partial revert of "Remove ignored argument from
lisp-indent-line", because `indent-line-to' doesn't respect field
boundaries.
* lisp/emacs-lisp/lisp-mode.el (lisp-indent-line): Use delete-region
and indent-to instead of `indent-line-to'.
* test/lisp/emacs-lisp/lisp-mode-tests.el
(lisp-indent-with-read-only-field): Expect to pass.

Don't merge to master, we will fix indent-line-to there instead.

6 years ago; Test for Bug#32014
Noam Postavsky [Sat, 30 Jun 2018 00:15:10 +0000 (20:15 -0400)]
; Test for Bug#32014

* test/lisp/emacs-lisp/lisp-mode-tests.el
(lisp-indent-with-read-only-field): New test.

6 years agoExplicitly reject :server and :nowait (Bug#31903)
Noam Postavsky [Thu, 5 Jul 2018 23:37:28 +0000 (19:37 -0400)]
Explicitly reject :server and :nowait (Bug#31903)

* src/process.c (Fmake_network_process): Explicitly check for and
signal an error when passed both :server and :nowait non-nil.  In
Emacs 25, :nowait would be ignored in this case, but as of Emacs 26.1
this gives an error, albeit an unclear one.  Also remove obsolete
comment regarding configurations lacking non-blocking mode, the
corresponding code was removed in 2012-11-17 "Assume POSIX 1003.1-1988
or later for fcntl.h."

6 years agoFix Bug#32090
Michael Albinus [Mon, 9 Jul 2018 14:03:49 +0000 (16:03 +0200)]
Fix Bug#32090

* lisp/files-x.el (connection-local-normalize-criteria): Do not
use PROPERTIES anymore.
(connection-local-get-profiles): Rewrite, in order to accept any
property as optional.  (Bug#32090)
(connection-local-set-profiles):
Adapt ´connection-local-normalize-criteria' call.

* test/lisp/files-x-tests.el
(files-x-test-connection-local-set-profiles)
(files-x-test-hack-connection-local-variables-apply): Extend tests.