Remove compat functions from smime.el

* lisp/gnus/smime.el (smime-replace-in-string): Remove.
(smime-make-temp-file): Remove.

Remove compat code from smiley

* lisp/gnus/smiley.el (smiley-style): Remove compat code.

Remove compat code from rfc2047

* lisp/gnus/rfc2047.el (rfc2047-encode-message-header): Remove
compat code.
(rfc2047-decode-string): Ditto.

Remove compat function from pop3

* lisp/gnus/pop3.el (pop3-set-process-query-on-exit-flag): Remove.

Remove compat code in Gnus backends

* lisp/gnus/nndiary.el (nndiary-error): Remove.

* lisp/gnus/nndraft.el (nndraft-request-associate-buffer): Ditto.

* lisp/gnus/nnfolder.el (nnfolder-read-folder): Ditto.

* lisp/gnus/nnheader.el (nnheader-find-file-noselect): Ditto.

* lisp/gnus/nnimap.el (nnimap-log-buffer): Remove compat code.

Remove compat code from some mml files

* lisp/gnus/mml-sec.el (mml-secure-passphrase-cache-expiry):
Remove compat code.

* lisp/gnus/mml-smime.el (mml-smime-openssl-sign-query):
Always use `mail-extract-address-components', since this isn't
time critical.
(mml-smime-get-dns-cert): Ditto.

* lisp/gnus/mml.el (mml-preview): Remove compat code.

Remove compat code and compat functions from mm-util.el

* lisp/gnus/mm-util.el (mm-mime-mule-charset-alist): Remove
compat code.
(mm-coding-system-priorities)
(mm-mule-charset-to-mime-charset, mm-charset-after)
(mm-mime-charset, mm-iso-8859-x-to-15-region): Remove compat code.
(mm-detect-coding-region): Define unconditionally.
(mm-detect-mime-charset-region): Ditto.
(mm-coding-system-to-mime-charset): It's 'mime-charset now.
(coding-system-name)
(find-file-coding-system-for-read-from-filename)
(find-operation-coding-system): Remove aliases.

Remove some compat code from mm-*.el

* lisp/gnus/mm-bodies.el (mm-decode-body): Ditto.

* lisp/gnus/mm-decode.el (mm-tmp-directory)
(mm-valid-image-format-p): Remove compat code.

* lisp/gnus/mm-url.el (mm-url-insert-file-contents): Remove
"Connection" "Close" workaround for older Emacsen.

Remove compat code and functions from message.el

* lisp/gnus/message.el (message-send-mail-function): Remove
compat code.
(message-dont-reply-to-names, message-mode)
(message-setup-fill-variables, message-fill-paragraph)
(message-remove-blank-cited-lines, message-make-from)
(message-forward-rmail-make-body, message-tool-bar-gnome)
(message-tab): Remove compat code.
(message-completion-in-region): Remove.
(message-read-from-minibuffer): Remove compat code.

Declare rfc1843 instead of autoloading

* lisp/gnus/gnus-art.el (rfc1843-decode-region): Declare
instead of autoload.

Avoid signaling an error in 'dired-do-find-regexp-and-replace'

* lisp/dired-aux.el: Require cl-lib, so that 'cl-mapcan' is
autoloaded correctly.  (Bug#22613)

Fix network-stream-tests.el for MS-Windows

* test/lisp/net/network-stream-tests.el
(connect-to-tls-ipv6-nowait): Skip for MS-Windows builds.
(connect-to-tls-ipv4-wait): Add a 0.1 sleep-for.

Remove some Message compat functions

* lisp/gnus/message.el (message-kill-all-overlays): Define
unconditionally.
(message-window-inside-pixel-edges): Remove.
(mail-dont-reply-to): Remove.

Remove some Gnus compat code

* lisp/gnus/gnus-art.el (gnus-mime-inline-part): Remove compat code.
(gnus-mm-display-part): Ditto.

* lisp/gnus/gnus-start.el (gnus-dribble-read-file): Remove
compat code.

Sort groups before inserting them into the group buffer

* lisp/gnus/gnus-group.el (gnus-group-describe-all-groups):
Sort groups before inserting them.

Make "unseen" tracking work again in Gnus

* lisp/gnus/gnus-sum.el (gnus-update-marks): Make "unseen"
tracking work again.

Remove Gnus compat functions defined in gnus.el

* lisp/gnus/gnus.el (gnus-extent-detached-p): Remove.
(gnus-extent-start-open, gnus-character-to-event)
(gnus-assq-delete-all, gnus-add-text-properties)
(gnus-put-text-property, gnus-key-press-event-p):

Remove compat code from gnus-uu and win

* lisp/gnus/gnus-util.el (gnus-image-type-available-p): Remove
compat code.

* lisp/gnus/gnus-uu.el (gnus-uu-tmp-dir): Remove compat code.

* lisp/gnus/gnus-win.el (gnus-frames-on-display-list): Remove.

Remove several gnus-util compat functions

* lisp/gnus/gnus-util.el (gnus-set-process-query-on-exit-flag): Remove.
(gnus-read-shell-command): Remove.
(gnus-match-substitute-replacement): Remove.
(gnus-string-match-p): Remove.
(gnus-string-prefix-p): Remove.

Remove the gnus-merge alias

* lisp/gnus/gnus-util.el (gnus-merge): Remove.

Remove the gnus-union alias

* lisp/gnus/gnus-util.el (gnus-union): Remove.

Remove the gnus-delete-alist alias

* lisp/gnus/gnus-util.el (gnus-run-mode-hooks): Remove compat code.
(gnus-delete-alist): Remove.

Remove the gnus-float-time alias

* lisp/gnus/gnus-util.el (gnus-completion-styles): Remove
compat code.
(gnus-float-time): Remove.

Remove compat code from gnus-srvr, start and sum

* lisp/gnus/gnus-srvr.el (gnus-browse-foreign-server): Remove
compat code.

* lisp/gnus/gnus-start.el (gnus-check-reasonable-setup):
Remove compat code.

* lisp/gnus/gnus-sum.el (gnus-summary-display-arrow)
(gnus-summary-make-menu-bar, gnus-summary-make-tool-bar)
(gnus-recenter)
(gnus-summary-limit-strange-charsets-predicate)
(gnus-summary-show-thread): Remove compat code.

Remove compat code from gnus-spec.el

* lisp/gnus/gnus-spec.el (gnus-lrm-string-p): Remove compat code.
(gnus-balloon-face-function): Remove compat code.

Fix compat change in last check-in

* lisp/gnus/gnus-group.el
(gnus-group-name-charset-group-alist): `find-coding-system'
doesn't exist in Emacs.

Always use url-queue

* lisp/gnus/gnus-html.el (gnus-html-schedule-image-fetching):
Always use url-queue.

Remove compat functions from gnus-html.el

* lisp/gnus/gnus-html.el (gnus-html-encode-url-chars): Remove.

Remove compat code from gnus-group.el

* lisp/gnus/gnus-group.el (gnus-group-name-charset-group-alist)
(gnus-group-make-tool-bar, gnus-group-update-tool-bar): Remove compat code.

Define gnus-diary-kill-entire-line unconditionally

* lisp/gnus/gnus-diary.el (gnus-diary-kill-entire-line):
Define unconditionally.

Remove compat code from gnus-cache and gnus-bookmark

* lisp/gnus/gnus-bookmark.el (gnus-bookmark-bmenu-mode-map): Ditto.

* lisp/gnus/gnus-cache.el (gnus-cache-decoded-group-name):
Remove compat code.

Remove compat code from gnus-art.el

* lisp/gnus/gnus-art.el (gnus-article-prepare)
(gnus-mime-copy-part, gnus-output-to-file)
(gnus-article-reply-with-original)
(gnus-button-handle-apropos-variable)
(gnus-button-handle-apropos-documentation):

Remove compat code from gnus-agent.el

* lisp/gnus/gnus-agent.el (gnus-agent-make-mode-line-string):
Remove compat code.

Rewrite gmm-labels usage to use cl-labels

* lisp/gnus/gmm-utils.el (gmm-tool-bar-style): Remove compat code.
(gmm-labels): Remove.

Remove compat code from canlock.el

* lisp/gnus/canlock.el (defmacro): Remove

Remove compat code from auth-source

* lisp/gnus/auth-source.el (auth-source-read-char-choice):
Remove compat code.

Fix gnus-group.el compilation warnings about unprefixed variables

* lisp/gnus/gnus-group.el (gnus-group-update-eval-form): Avoid
compilation warnings by passing in the dynamic variables as
explicit lexical parameters to `eval'.

Fix the :tracker slot name

* lisp/gnus/registry.el (registry-lookup-secondary): The
`tracker' slot is called `tracker', not `:tracker'.

Fix compilation warnings in gnus-art.el

* lisp/gnus/gnus-art.el (rfc1843-decode-region): Autoload.
(gnus-article-hide): Avoid compilation warnings.

Fix compilation warning in gnus-score.el

* lisp/gnus/gnus-score.el (gnus-art): Require to silence byte
compiler.

Revert "Fix gnus-group-get-new-news-this-group on group with closed server"

This reverts commit 9dc77e37aa84c6df9b3ddb4609f3c09201b0580e.

This makes nnimap groups not be activated.

Fix encoding problem introduced by previous patch series

* lisp/gnus/rfc2047.el: Ditto (bug#22648).

* lisp/gnus/rfc2231.el: Fix problem created by the
mm-replace-in-string conversion.

Revert "Avoid defvarring prefix-less variables"

This reverts commit 303390bda34f98b400798d5383cf0d722e35ba19.

The defvars are needed if we're doing lexical-binding

* test/lisp/url/url-auth-tests.el (url-auth-test-digest-auth):
Make it pass.

; * test/lisp/url/url-auth-tests.el: More whitespace.

; * test/lisp/url/url-auth-tests.el: Whitespace.

* test/lisp/url/url-auth-tests.el
(url-auth-test-digest-auth-retrieve-cache): Fix obvious typo.

; How do people add tests without, y'know, testing them?

Finish up cl-defmethoding registry,el

* lisp/gnus/registry.el (initialize-instance): Use cl-defmethod.

Revert the gnus-replace-in-string change, fix arguments, reapply

Silence more message.el compilation warnings

* lisp/gnus/message.el (message-generate-headers): Don't use
variable values directly to get the header values, because
that breaks with lexical binding (without unprefixed defvars).

Fix various compilation warnings in message.el

* lisp/gnus/message.el (message-fix-before-sending): Use
read-multiple-choice instead of gnus-multiple-choice.
(mm-util): Require.
(rfc2047): Require.
(message-remove-blank-cited-lines): Use message instead of
gnus-message.
(message-send): Use y-or-n-p instead of gnus-y-or-n-p.

Silence compilation warning in mm-view

* lisp/gnus/mm-view.el (mm-display-inline-fontify): Silence
compilation warning.

Fix epg-related compilation warnings in mml-sec

* lisp/gnus/mml-sec.el: Fix compilation warnings from the epg
library.

rmail-dont-reply-to-names is obsolete

* lisp/gnus/nnmail.el (nnmail-fancy-expiry-target): Don't bind
the obsolete `rmail-dont-reply-to-names' variable.

Partially revert the defmethod->cl-defmethod change in registry.el

* lisp/gnus/registry.el (initialize-instance): Use defmethod,
since cl-defmethod doesn't work with :after.
(initialize-instance): Ditto, but with :before.

Avoid obsolete function in plstore

* lisp/gnus/plstore.el (plstore--insert-buffer): Use setf
instead of the obsolete epg-context-set-armor.

Use cl-defmethod in registry.el

* lisp/gnus/registry.el: Use cl-defmethod instead of the
obsolete defmethod.

Make sieve-manage require sasl

* lisp/gnus/sieve-manage.el: Fix compilation warning by
requiring sasl.

Avoid defvarring prefix-less variable

* lisp/gnus/mm-uu.el (mm-uu-entry): Rename from `entry'.

* lisp/gnus/mailcap.el: Remove usage of mailcap-delete-duplicates.

Don't use the obsolete char-valid-p function

* lisp/gnus/mm-url.el (mm-url-decode-entities): Don't use the
obsolete char-valid-p function.

Fix missed translation in a previous commit

* lisp/gnus/mailcap.el (mailcap-mime-types): Fix missed
translation of mailcap-delete-duplicates.

Avoid using mm-make-temp-file

* lisp/gnus/mail-source.el (mail-source-delete-crash-box): Ditto.

* lisp/gnus/mm-decode.el (mm-display-external): Ditto.

* lisp/gnus/mml-smime.el (mml-smime-openssl-encrypt): Ditto.

Fix compilation warning in gnus-start

* lisp/gnus/gnus-start.el (gnus-slave-save-newsrc): Avoid
mm-make-temp-file.

Avoid the obsoleted defmethod

* lisp/gnus/gnus-icalendar.el: Use cl-defmethod instead of
defmethod.

Avoid defvarring prefix-less variables

* lisp/gnus/gnus-group.el (gnus-group-update-eval-form): We
don't need to `defvar' the short variables to allow `eval' to
use them.

nnweb doesn't need unibyte buffers

* lisp/gnus/nnweb.el (nnweb-retrieve-headers)
(nnweb-read-overview, nnweb-request-article)
(nnweb-google-reference): Unibyte buffers are not needed here.

Encode before sending from nnspool

* lisp/gnus/nnspool.el (nnspool-request-post): Encode data
before sending it to the news server.

nnrss buffers don't have to be unibyte

* lisp/gnus/nnrss.el (nnrss-insert): The buffer doesn't have
to be unibyte just to receive data, I think.

Don't use mm-with-unibyte-current-buffer in mml2015

* lisp/gnus/mml2015.el (mml2015-mailcrypt-encrypt): Don't use
mm-with-unibyte-current-buffer.

Don't use mm-with-unibyte-current in mml1991

* lisp/gnus/mml1991.el (mml1991-epg-sign): Don't use
mm-with-unibyte-current.

Don't use mm-with-unibyte-current in mml1991

* lisp/gnus/mml1991.el (mml1991-pgg-sign): Don't use
mm-with-unibyte-current.

Don't use mm-with-unibyte-buffer in utf7

* lisp/gnus/utf7.el (utf7-fragment-encode): Don't use
mm-with-unibyte-buffer.

Remove XEmacs compat code from Gnus helper libraries

* lisp/gnus/plstore.el (plstore-called-interactively-p): Remove.

* lisp/gnus/pop3.el (pop3-make-date): Remove XEmacs compat.

* lisp/gnus/sieve-mode.el: Remove XEmacs compat.

* lisp/gnus/spam-stat.el (spam-stat-called-interactively-p): Remove.

Remove XEmacs compat code from Gnus backends

* lisp/gnus/mm-view.el (mm-inline-image-xemacs): Remove.
(mm-inline-image): Rename from mm-inline-image-emacs.

* lisp/gnus/mml.el: Remove XEmacs compat code.

* lisp/gnus/nnheader.el: Remove XEmacs compat code.

* lisp/gnus/nnimap.el (nnimap-open-connection-1): Remove
XEmacs compat code.

* lisp/gnus/nnir.el (nnir-run-gmane): Remove XEmacs compat code.

* lisp/gnus/nnmail.el (nnmail-pathname-coding-system): Remove
XEmacs compat code.

* lisp/gnus/nnmairix.el: Remove XEmacs compat code.

* lisp/gnus/nnrss.el: Remove XEmacs compat code.

* lisp/gnus/nntp.el: Remove XEmacs compat code.

Remove XEmacs compat functions from mm-util.el

* lisp/gnus/mm-util.el (mm-special-display-p): Remove.
(mm-decode-coding-string, mm-encode-coding-string)
(mm-decode-coding-region, mm-encode-coding-region): Remove.
(mm-string-to-multibyte): Remove.
(mm-char-or-char-int-p): Remove.
(mm-ucs-to-char): Remove compat versions of the function.
(mm-read-coding-system): Remove.
(mm-coding-system-p): Remove compat code.
(mm-enrich-utf-8-by-mule-ucs): Remove.
(mm-enable-multibyte, mm-disable-multibyte): Remove compat versions.
(mm-delete-duplicates): Remove.
(mm-multibyte-p): Remove compat versions.
(mm-xemacs-find-mime-charset-1): Remove.
(mm-xemacs-find-mime-charset): Remove.
(mm-make-temp-file): Made obsolete.
(mm-find-buffer-file-coding-system): Remove XEmacs compat.

Remove Message and mm-decode XEmacs compat code

* lisp/gnus/message.el: Remove XEmacs compat code.

* lisp/gnus/mm-decode.el (mm-create-image-xemacs): Remove.

* lisp/gnus/mm-util.el: Remove some XEmacs compat code.

Remove som XEmacs compat code from message.el

* lisp/gnus/message.el: Remove some XEmacs compat code.

Remove XEmacs compat code from ietf-drums.el

* lisp/gnus/ietf-drums.el (ietf-drums-syntax-table): Drop
XEmacs compat.

Remove XEmacs compat code from gravatar.el

* lisp/gnus/gravatar.el: Remove XEmacs compat code from
gravatar.el.

Remove more XEmacs compat code from Gnus

* lisp/gnus/gnus-util.el (gnus-bound-and-true-p): Remove.
(gnus-timer--function): Remove.

* lisp/gnus/gnus-uu.el (gnus-uu-save-article): Remove XEmacs
19.2 compat.

* lisp/gnus/gnus-win.el: Remove XEmacs compat code.

Remove more XEmacs compat functions from gnus-util.el

* lisp/gnus/gnus-util.el (gnus-put-display-table): Remove.
(gnus-get-display-table): Remove.
(gnus-format-message): Remove.

Remove more XEmacs compat functions from Gnus

* lisp/gnus/gnus-util.el (gnus-next-char-property-change): Remove.
(gnus-previous-char-property-change): Remove.
(gnus-graphic-display-p): Remove.
(gnus-select-frame-set-input-focus): Remove.

Remove more XEmacs compat code from gnus-util

* lisp/gnus/gnus-util.el (gnus-make-local-hook): Remove (and
all its usages).
(gnus-invisible-p): Remove.

Remove gnus-make-local-hook

* lisp/gnus/gnus-util.el (gnus-make-local-hook): Remove (and
all its usages).

gnus-replace-in-string -> replace-regexp-in-string

* lisp/gnus/gnus-util.el (gnus-replace-in-string): Declare
obsolete.  Transform all usages of it into
replace-regexp-in-string.

* lisp/gnus/mailcap.el (mailcap-replace-in-string): Remove.

Remove Gnus XEmacs compat

* lisp/gnus/gnus-start.el (gnus-dribble-enter): Remove comment
about code that doesn't work in XEmacs.

* lisp/gnus/gnus-sum.el: Remove XEmacs compat.

* lisp/gnus/gnus-topic.el: Remove XEmacs compat.

Remove compat functions in gnus-spec.el

* lisp/gnus/gnus-spec.el (gnus-string-width-function): Remove.
(gnus-substring-function): Remove.
(gnus-use-correct-string-widths): Remove.
(gnus-make-format-preserve-properties): Remove.
(gnus-xmas-format): Remove.

* lisp/gnus/gnus-srvr.el (gnus-server-mode): Remove XEmacs compat.

Remove Gnus XEmacs compat functions

* lisp/gnus/gnus-registry.el: Remove XEmacs compat.

* lisp/gnus/gnus-salt.el: Remove XEmacs compat.

* lisp/gnus/gnus-score.el (gnus-decay-score): Remove XEmacs compat.

Remove Gnus XEmacs compatibility

* lisp/gnus/gnus-demon.el (gnus-demon-idle-since): Remove
XEmacs compat.

* lisp/gnus/gnus-dired.el: Remove XEmacs compat.

* lisp/gnus/gnus-draft.el: Remove XEmacs compat.

* lisp/gnus/gnus-gravatar.el (gnus-gravatar-insert): Remove
XEmacs compat.

* lisp/gnus/gnus-group.el: Remove XEmacs compat.

* lisp/gnus/gnus-html.el: Remove XEmacs compat.

* lisp/gnus/gnus-ml.el: Remove XEmacs compat.

* lisp/gnus/gnus-picon.el (gnus-picon-style): Remove XEmacs comment.

Don't use image-map if it isn't defined

* lisp/net/shr.el (shr-image-map): Only use image-map as a
parent if it's defined (bug#22614).

Check for MagickAutoOrientImage

* configure.ac: Check for MagickAutoOrientImage.

* src/image.c (imagemagick_load_image): Don't use
MagickAutoOrientImage unless it's available.

Document EXIF image rotation

* doc/lispref/display.texi (ImageMagick Images): Mention EXIF rotation.

Support integer image rotation and respect EXIF rotations

* src/image.c (imagemagick_load_image): Allow integer rotations in
addition to floating point rotations (bug#22591).
* src/image.c (imagemagick_load_image): Images that have an
orientation given in EXIF and have no explicit :rotation tag are now
pre-rotated.  All information such as width/height is reported for the
rotated image.

* lisp/net/shr.el (image-map): Defvar it.  (Bug#22614)

* lisp/gnus/gnus-cite.el: Remove XEmacs compat code.

Remove compat code from gnus-bookmark.el

* lisp/gnus/gnus-bookmark.el (gnus-bookmark-mouse-available-p): Remove.
(gnus-bookmark-remove-properties): Remove.

Remove XEmacs compat code from gnus-a*.el

* lisp/gnus/gnus-agent.el: Remove compat code.

* lisp/gnus/gnus-art.el: Remove compat code.

* lisp/gnus/gnus-async.el: Remove compat code.

Remove gmm compat functions

* lisp/gnus/gmm-utils.el (gmm-image-search-load-path): Remove.
(gmm-write-region): Remove.
(gmm-called-interactively-p): Remove.

* lisp/gnus/ecomplete.el: Remove XEmacs compat code.