Don't remove highlight of misspelled word on pdict save

* lisp/textmodes/ispell.el (ispell-pdict-save): Don't restart
flyspell-mode, as bug#11963, which this was supposed to fix, is
fixed better by ispell-command-loop, when the user types 'i' or
'a'.  Restarting Flyspell mode when the personal dictionary is
saved caused bug#31372 as side effect.
(ispell-command-loop): Test 'flyspell-mode', not whether
flyspell-unhighlight-at is fboundp, to determine whether Flyspell
mode is turned on in the current buffer.
(flyspell-unhighlight-at): Add declare-function form for it.

Fix Bug#31272

* lisp/net/tramp-sh.el (tramp-do-file-attributes-with-ls)
(tramp-do-directory-files-and-attributes-with-stat)
(tramp-sh-handle-insert-directory): Use "--show-control-chars".
(tramp-convert-file-attributes): Decode multibyte strings,
produced by "stat".  (Bug#31272)

* test/lisp/net/tramp-tests.el (tramp--test-utf8): Extend test.

Include narrowing indication in describe-mode

* lisp/help.el (describe-mode): Include "Narrow", if narrowing is
active.  (Bug#31139)

Copyright-paperwork-exempt: yes

Fix some problems in the Cairo build

* src/xterm.c (x_begin_cr_clip): Create image surface.
(x_update_end) [USE_CAIRO]: Remove GTK3-specific code.
(x_scroll_run) [USE_CAIRO]: Implement scrolling.
* src/image.c (lookup_rgb_color) [USE_CAIRO]: Support Cairo.
(jpeg_load_body) [USE_CAIRO]: Support Cairo.  Use USE_CAIRO
instead of CAIRO for #ifdef's.
(imagemagick_load_image) [USE_CAIRO]: Support Cairo.
(Bug#31288)

Avoid infloops in font_open_entity

* src/font.c (font_open_entity): Fail after 15 iterations through
the loop that looks for a font whose average_width and height are
both positive.  This avoids infinite loops for fonts that, e.g.,
report average_width of zero for any possible size we try.
(Bug#31316)

Fix encoding of characters when using GB18030 fonts

* lisp/international/fontset.el (font-encoding-alist): Fix the
GB18030 entry to encode characters correctly when passing them to
the xfont back-end.  (Bug#31315)  See also
http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00754.html.

* make-dist: Don't fail if building --without-makeinfo.

Fix windows snapshot building

* admin/nt/dist-build/build-zips.sh: Fix broken if statement

* admin/nt/dist-build/build-zips.sh: Support building of branches

More porting to GCC 8 of --enable-gcc-warnings

* lwlib/lwlib-Xaw.h (xaw_update_one_value, xaw_popup_menu):
* lwlib/lwlib-Xlw.h (xlw_update_one_value, xlw_pop_instance):
* lwlib/lwlib.h (lw_allow_resizing, lw_set_main_areas) [!USE_MOTIF]:
No longer const.
* src/emacs-module.c: Ignore -Wcast-function-type.

Fix next-page for dired (Bug#31061)

* lisp/textmodes/page-ext.el (next-page): Don't go back any pages if
COUNT is 0.  For negative COUNT, end with point just after the last
delimiter.

Co-authored-by: Noam Postavsky <npostavs@gmail.com>

Minor simple.el simplifications (Bug#31211)

* lisp/simple.el (kill-append, push-mark, pop-mark):
Simplify conditionals and surrounding code.

Fix off-by-one history pruning (bug#31211)

* lisp/subr.el (add-to-history): Clarify docstring.
Protect against negative history-length and unnecessary variable
modification, as per read_minibuf.

* lisp/ido.el (ido-record-command):
* lisp/international/mule-cmds.el (deactivate-input-method):
(set-language-environment-input-method):
* lisp/isearch.el (isearch-done):
* lisp/minibuffer.el (read-file-name-default):
* lisp/net/eww.el (eww-save-history):
* lisp/simple.el (edit-and-eval-command, repeat-complex-command):
(command-execute, kill-new, push-mark):
* src/callint.c (Fcall_interactively):
* src/minibuf.c (read_minibuf): Delegate to add-to-history.

* test/lisp/simple-tests.el (command-execute-prune-command-history):
* test/src/callint-tests.el
(call-interactively-prune-command-history): New tests.

* lisp/textmodes/ispell.el (ispell-use-framepop-p): Doc fix.

; * lisp/auth-source.el (auth-sources): Fix a comment.

Adapt Tramp for auth-source

* lisp/net/tramp.el (tramp-read-passwd): auth-source could return
cascaded functions.

Fix some edge cases of tramp-smb

* lisp/net/tramp-smb.el (tramp-smb-errors):
Add "NT_STATUS_REVISION_MISMATCH".
(tramp-smb-handle-delete-directory): Check, that the directory
has been removed indeed.
(tramp-smb-get-localname): Add further checks on filename syntax.

* lisp/net/tramp.el (tramp-localname-regexp): Do not allow linefeeds.

* test/lisp/net/tramp-tests.el (tramp-smb-get-localname): Declare.
(auth-source-save-behavior): Set it to nil.
(tramp-test01-file-name-syntax): Extend, checking for linefeeds.
(tramp-test03-file-name-host-rules, tramp--test-utf8): Refine tests.
(tramp-test03-file-name-method-rules): New test.
(tramp--test-ignore-add-name-to-file-error): New defmacro.
(tramp-test21-file-links): Use it.

; Merge from origin/emacs-26

The following commits were skipped:

65ac277 (origin/emacs-26) Port --enable-gcc-warnings to GCC 8
4b10800 Advise CFLAGS= operand, not in environment, when configuring

Merge from origin/emacs-26

71be806 ; * etc/DEBUG: Minor clarification.
4403f89 Update the Emacs FAQ
40b3317 * etc/DEBUG: Minor copyedits.
850ff18 Clarify wording of NS drag n drop documentation
343d70b1 Improve kill-related documentation (bug#31209)
0b43224 * lisp/simple.el (region-extract-function): Don't hide the 'n...
d6e2c59 Fix pre- and post-command-hook errors in term.el
6cf83131e * doc/lispref/display.texi (Glyphless Chars): Fix grammar.
88d178c Fix macOS drag n drop event documentation

`url-domain' doc clarification

* lisp/url/url-util.el (url-domain): Add an example to the doc
string.

Rewrite `url-domain' to avoid network traffic

* lisp/url/url-util.el (url-domain): Don't talk DNS to determine
the domain, because this is slow.

* test/lisp/url/url-util-tests.el (url-domain-tests): Add tests
for `url-domain'.

; Auto-commit of loaddefs files.

Port --enable-gcc-warnings to GCC 8

Backport from master.
* lib-src/emacsclient.c (fail):
Do not dereference a null pointer.
* src/frame.c (delete_frame):
Add a decl with UNINIT to work around GCC bug 85563.
* src/menu.h (finish_menu_items):
Do not use attribute const.
* src/regex.c (analyze_first): Use FALLTHROUGH, not a comment.

Advise CFLAGS= operand, not in environment, when configuring

Backport from master.

* test/src/process-tests.el (make-process/mix-stderr): Skip on hydra.

* lisp/net/socks.el: Use lexical-binding and process properties

Remove unneeded requires.  Better following commenting conventions.
(socks-connections): Remove (use process properties instead).
(socks-wait-for-state-change): Make it a function.
(open-network-stream): Use an advice when overriding.
(socks-send-command): Avoid string-make-unibyte.
(socks--open-network-stream): New function (extracted from
socks-open-network-stream).
(socks-open-network-stream): Rewrite using it.

Advise CFLAGS= operand, not in environment, when configuring

; * etc/DEBUG: Minor clarification.

Replace epg--gv-nreverse with (cl-callf nreverse ...)

* lisp/epg.el (epg--gv-nreverse): Remove.
(epg-list-keys): Replace it with (cl-callf nreverse ...).

Port --enable-gcc-warnings to GCC 8

* configure.ac: Do not use GCC 8’s new -Wcast-align flag.
* lib-src/ebrowse.c (xmalloc):
* lib-src/emacsclient.c (xmalloc, xstrdup):
* lib-src/etags.c (xmalloc):
* lib-src/make-docfile.c (xmalloc):
* lib-src/movemail.c (xmalloc):
* src/dispnew.c (new_glyph_pool):
* src/regex.c (xmalloc):
* src/term.c (tty_menu_create):
* src/tparam.h (tparam):
Use ATTRIBUTE_MALLOC.  Also see GCC bug 85562.
* lib-src/emacsclient.c (fail):
Do not dereference a null pointer.
* src/frame.c (delete_frame):
Add a decl with UNINIT to work around GCC bug 85563.
* src/menu.h (finish_menu_items):
Do not use attribute const.
* src/regex.c (analyze_first): Use FALLTHROUGH, not a comment.

Update from Gnulib

This incorporates:
2018-04-27 manywarnings: port to GCC 8.0
* build-aux/config.sub, m4/manywarnings.m4: Copy from Gnulib.

* lisp/vc/add-log.el (change-log-mode-syntax-table): New defvar

that redefines syntax of quotes to "expression quote or prefix operator".
(Bug#31231)

* lisp/subr.el (dotimes): Deprecate RESULT field.  (Bug#16206)

* doc/lispref/control.texi (Iteration):
* doc/misc/cl.texi (Iteration): Document deprecation of its use.
* doc/lispintro/emacs-lisp-intro.texi (dotimes):
* test/src/emacs-module-tests.el (multiply-string):
* test/lisp/filenotify-tests.el (file-notify-test07-many-events):
Place RESULT field after the form.

Update the Emacs FAQ

* doc/misc/efaq.texi (Latest version of Emacs): Update versions.
(New in Emacs 26): New node.

* admin/release-process: Mention the FAQ update as part of the
release.

* etc/DEBUG: Minor copyedits.

* src/fns.c (Fstring_distance): Minor code reformatting.

Fix documentation and tests for 'string-distance'

* src/fns.c (Fstring_distance): Doc fix.

* doc/lispref/strings.texi (Text Comparison): Document
'string-distance'.

* etc/NEWS: Fix wording and mark as documented in the manuals.

* test/src/fns-tests.el (test-string-distance): Move from
subr-tests.el and rename.

New function 'string-distance'

* src/fns.c (Fstring_distance): New primitive.
(syms_of_fns): Defsubr it.

* test/lisp/subr-tests.el (subr-tests--string-distance): New test.

* etc/NEWS: Mention 'string-distance'.

; Copyedits in etc/NEWS

Manual update for Tramp

* doc/misc/tramp.texi (Password handling): Explain, how passwords
are saved permanently.

* etc/NEWS: auth-source Secret Service backend supports :create.
Tramp saves validated passwords.

* lisp/epa.el (epa-decrypt-file): Apply epa-pinentry-mode (Bug#30363).

Clarify wording of NS drag n drop documentation

* doc/emacs/macos.texi (Mac / GNUstep Events): Clarify wording of
ns-drag-n-drop description.

Strip most headers when forwarding messages

* lisp/gnus/message.el (message-forward-included-headers): Change
the default to exclude most messages.
(message-remove-ignored-headers): Make
message-forward-included-headers actually work -- it's a list of
regexps, not a list of strings.

* etc/NEWS: Fix minor quoting and spacing bugs.

Add missing calendar-dlet* (Bug#31267)

* lisp/calendar/calendar.el (calendar-generate-month): Use
calendar-dlet* around evaluation of calendar-date-echo-text.

Ensure woman2-roff-buffer restores functions on error (Bug#30908)

* lisp/woman.el (woman2-roff-buffer): Put the fallback paragraph
processing inside the protected part of the unwind-protect form,
rather than the cleanup forms.  Attempting to format paragraphs again
after an error has been signaled is unlikely to be helpful.  The
fallback processing should be triggered only in case the loop
terminated normally, but did not reach the end of the buffer for some
reason.

Fix cl-print for circular sublists (Bug#31146)

* lisp/emacs-lisp/cl-print.el (cl-print-object) <cons>: Push each
element of list being printed onto cl-print--currently-printing.
* test/lisp/emacs-lisp/cl-print-tests.el (cl-print-circle-2): New
test.

Don’t set print-escape-newlines in the minibuffer

This appears to be an unnecessary and possibly-confusing
revenant from ancient code (Bug#31251).  See thread containing:
https://lists.gnu.org/r/emacs-devel/2018-04/msg00654.html
* src/minibuf.c (read_minibuf): Do not set print-escape-newlines.
* src/print.c (syms_of_print): Do not defsym print-escape-newlines
or print-escape-control-characters, as these symbols are not used
in C code.

* lisp/foldout.el (outline-minor-mode): Remove pointless check.

speedbar: remove support for missing custom.el

* lisp/speedbar.el (speedbar-file-regexp)
(speedbar-ignored-directory-regexp): Remove support for no custom.el.

* lisp/progmodes/sql.el (comint-line-beginning-position):
Remove pre-21 fallback definition.

* lisp/net/eudc.el (split-string): Remove pre-21 fallback definition.

Do not call interprogram-paste-function repeatedly

* lisp/simple.el (current-kill): Disable interprogram-paste-function
so that kill-new doesn't call it repeatedly when
save-interprogram-paste-before-kill is enabled.  (bug#31209)

socks.el: remove pre-21 compatibility code

* lisp/net/socks.el (socks-split-string): Remove.
(socks-nslookup-host): Just use split-string.

Improve kill-related documentation (bug#31209)

* doc/lispref/text.texi (Low-Level Kill Ring): Fix typo under
current-kill.  Mention interprogram-paste-function under kill-new
and kill-append.
* lisp/simple.el (save-interprogram-paste-before-kill, kill-new)
(kill-append-merge-undo, kill-append): Touch-up docstrings.

* src/minibuf.c (read_minibuf): Add a FIXME comment.

* lisp/simple.el (region-extract-function): Don't hide the 'nil' case.

; * etc/NEWS: Fix typo.

(add-to-invisibility-spec): Further doc tweak

* lisp/subr.el (add-to-invisibility-spec): Tweak doc fix from
previous patch.

Doc fix for `*-*-invisibility-spec'

* lisp/subr.el (add-to-invisibility-spec)
(remove-from-invisibility-spec): Make the doc string say what
happens if `buffer-invisibility-spec' is an atom (bug#30171).

libxml-parse-*-region calling convention fix

* lisp/subr.el (libxml-parse-xml-region)
(libxml-parse-html-region): Adjust the calling convention to note
that the final parameter is optional.

Make url-http-create-request work with non-ASCII data again

* lisp/url/url-http.el (url-http-create-request): Ensure that the
entire request string is unibyte (bug#31248).

Fix recent change in lread.c

* src/lread.c (openp): Avoid assertion violations in XCDR when
PATH is nil.  (Bug#31229)

Backspace is not a paragraph separator in Texinfo files

* lisp/textmodes/texinfo.el (texinfo-mode): Omit backspace from
paragraph separator and start.  Perhaps there was some confusion
about .texi vs .info files long ago?

* etc/NEWS: Improve wording of next-error entries.

Let Tramp save passwords

* lisp/auth-source.el (auth-source-secrets-saver): New defun.
(auth-source-secrets-create): Use it.

* lisp/net/secrets.el (secrets-struct-secret-content-type):
(secrets-create-item): Do not hard-code :xdg:schema.

* lisp/net/tramp.el (tramp-password-save-function): New defvar.
(tramp-read-passwd): Set it properly.
(tramp-process-actions):
* lisp/net/tramp-gvfs.el (tramp-gvfs-maybe-open-connection):
Save password.

* lisp/net/tramp-cmds.el (tramp-bug): Don't report
`tramp-password-save-function'.

* test/lisp/net/secrets-tests.el (secrets-test03-items):
Extend test with another :xdg:schema.

Ensure proper EOL handling for Tramp on macOS

* lisp/net/tramp-sh.el (tramp-open-connection-setup-interactive-shell):
Ensure proper EOL handling for Darwin.

Improve Isearch error handling

* lisp/isearch.el (isearch--momentary-message): Propertize message
suffix with minibuffer-prompt face.
(isearch--describe-regexp-mode): Do not omit description in case
of error in default non-literal search.
(isearch-message-prefix): Display “case-sensitive” in case of error.
(isearch-message-suffix): Propertize message suffix with
minibuffer-prompt face.
(isearch-search-fun-default): Remove unused error handling.

* lisp/vc/add-log.el (change-log-next-buffer): Better handle
errors during wrapping.

(text-property-search-forward): Copy edits in doc string

* lisp/emacs-lisp/text-property-search.el
(text-property-search-forward): Copy edits in doc string.

Minor improvements of next-error docs

* lisp/simple.el (next-error-find-buffer-function)
(previous-error, next-error-select-buffer): Doc fixes.
* doc/emacs/maintaining.texi (Change Log Commands):
* doc/emacs/building.texi (Compilation Mode): Index the new
commands and variables.  Improve wording.
(Bug#20493)

Fix pre- and post-command-hook errors in term.el

Before this patch, after the terminal process dies the command
hooks added in term-mode's char mode would produce errors.
This fix removes these hooks when the process dies.
* lisp/term.el (term-handle-exit): Remove pre-command-hook and
post-command-hook because the process is dead.  (Bug#31236)

Copyright-paperwork-exempt: yes

(text-property-search-forward): Doc string tweak

* lisp/emacs-lisp/text-property-search.el
(text-property-search-forward): Doc string tweak.

(text-property-search-forward): Fix search at the end

* lisp/emacs-lisp/text-property-search.el
(text-property-search-forward): Fix search at the end of the
buffer with no text properties.

Add a test suite for text-property-search

* doc/lispref/display.texi (Glyphless Chars): Fix grammar.

Update documentation for more next-error features

* doc/emacs/maintaining.texi (Change Log Commands): Mention
change-log-goto-source.

* doc/emacs/building.texi (Compilation Mode): Document
next-error-find-buffer-function and next-error-select-buffer.

* doc/emacs/building.texi (Grep Searching):
* doc/emacs/files.texi (Diff Mode):
* doc/emacs/search.texi (Other Repeating Search):
* doc/emacs/windows.texi (Displaying Buffers):
Prefer ‘M-g M-n’ over ‘C-x `’.

* lisp/simple.el (next-error-find-buffer-function, next-error)
(next-error-select-buffer): Elaborate docstrings.  (Bug#20493)

Fix macOS drag n drop event documentation

* doc/emacs/macos.texi (Mac / GNUstep Customization): Remove
references to color panel.
(Mac / GNUstep Events): Remove ns-drag-file, and add ns-drag-n-drop.

Tweak recent bytecomp defvaralias change

* lisp/emacs-lisp/bytecomp.el (byte-compile-file-form-defvar-function):
Respect with-no-warnings.

More alias-related tedium

* lisp/comint.el (comint-scroll-to-bottom-on-output):
* lisp/completion.el (cmpl-syntax-table):
* lisp/erc/erc-button.el (erc-button-google-url):
* lisp/font-lock.el (font-lock-reference-face):
* lisp/hfy-cmap.el (hfy-fallback-colour-map, hfy-rgb-txt-colour-map):
* lisp/isearch.el (isearch-regexp-function, isearch-new-word):
* lisp/startup.el (argv):
* lisp/version.el (emacs-bzr-version):
* lisp/org/org.el (org-CUA-compatible)
(org-popup-calendar-for-date-prompt):
Move aliases before targets, to silence new compiler warning.

The tedious game of whack-a-mole with compiler warnings continues

* lisp/abbrev.el (edit-abbrevs-map):
* lisp/emacs-lock.el (emacs-lock-from-exiting):
* lisp/htmlfontify.el (hfy-optimisations):
* lisp/ielm.el (inferior-emacs-lisp-mode-hook)
(inferior-emacs-lisp-mode-map):
* lisp/isearch.el (isearch-lazy-highlight-word):
* lisp/select.el (x-select-enable-clipboard, x-select-enable-primary):
* lisp/shell.el (shell-dirtrack-mode):
* lisp/skeleton.el (skeleton-transformation, skeleton-filter):
* lisp/startup.el (inhibit-splash-screen, inhibit-startup-message):
* lisp/window.el (even-window-heights):
* lisp/calendar/timeclock.el (timeclock-modeline-display):
* lisp/cedet/semantic/db-mode.el (semanticdb-mode-hook)
(semanticdb-global-mode):
* lisp/emacs-lisp/edebug.el (gud-inhibit-global-bindings):
* lisp/emacs-lisp/warnings.el (display-warning-minimum-level)
(log-warning-minimum-level):
* lisp/erc/erc-dcc.el (erc-dcc-chat-filter-hook):
* lisp/gnus/nnspool.el (news-path):
* lisp/org/org-agenda.el (org-agenda-search-view-search-words-only)
(org-agenda-remove-tags-when-in-prefix)
(org-agenda-align-tags-to-column, org-agenda-keymap):
* lisp/org/org.el (org-special-ctrl-a)
(org-log-state-notes-into-drawer)
(org-agenda-multi-occur-extra-files):
* lisp/progmodes/flymake-proc.el (flymake-err-line-patterns)
(flymake-check-file-limit):
* lisp/progmodes/make-mode.el (makefile-query-one-target-method):
* lisp/progmodes/octave.el (inferior-octave-startup-hook):
* lisp/progmodes/python.el (python-buffer)
(python-preoutput-result):
* lisp/progmodes/sql.el (sql-dialect):
* lisp/textmodes/artist.el (artist-text-renderer):
* lisp/textmodes/bibtex.el (bibtex-autokey-name-case-convert)
(bibtex-autokey-titleword-case-convert):
* lisp/textmodes/flyspell.el (flyspell-generic-check-word-p):
* lisp/textmodes/ispell.el (ispell-format-word):
* lisp/textmodes/rst.el (rst-preferred-decorations):
* lisp/textmodes/sgml-mode.el (sgml-transformation):
Move aliases before targets, to silence new compiler warning.
* lisp/term/ns-win.el (ns-option-modifier, ns-right-option-modifier):
Silence warning.

* lisp/emacs-lisp/bytecomp.el (byte-compile-file-form-defvar-function):

Warn about defvaralias that follows instead of precedes its var.

* lisp/url/url-file.el: Use lexical-binding.

* lisp/net/newst-backend.el (newsticker--sentinel-work):
Replace obsolete form of libxml-parse-xml-region.

* lisp/replace.el (query-replace-descr): Silence compiler.

Revert "* etc/HELLO: Add langugae Emoji.  Use utf-8 coding."

This reverts commit c4cfb5d20487f9912f5896b3f1d291fe7ccc9804.

Revert "* admin/notes/unicode: HELLO is now UTF-8."

This reverts commit 0585bd643dae2592214e77998b875347e6e59bab.

* admin/notes/unicode: HELLO is now UTF-8.

Merge from origin/emacs-26

5de608f (origin/emacs-26) Update the documentation of 'perform-replace'
06245b6 * etc/NEWS: Another fix for the last change (noted by Juri Li...
8f6293c Fix use of @key in Texinfo manuals
f4c9894 Improve documentation of actual arglist
ce0e253 ; * etc/NEWS: Improve last change as proposed by Phil Sainty
b89ff0e Don't assume term-current-row cache is valid (Bug#31193)
326a296 ; * etc/NEWS: Mention 'display-buffer-in-major-side-window' c...
3bdc9a1 Fix flyspell-auto-correct-previous-word broken by recent change
a539eb5 * test/src/lread-tests.el (lread-test-bug-31186): New test.
3fa472b Fix undefined behaviour while looking for lexical-binding fil...
4341aac Minor wording improvement in "Bookmarks"

Conflicts:
test/src/lread-tests.el

* lisp/international/mule-cmds.el (view-hello-file): Avoid duplicate

Don't hardcode the coding-system, now that it's specified with a "coding:" tag

* lisp/international/mule-cmds.el (view-hello-file):  Use utf-8 coding.

* etc/HELLO: Add langugae Emoji.  Use utf-8 coding.

; * etc/NEWS: Minor reformatting of a recent entry.

Update the documentation of 'perform-replace'

* doc/lispref/searching.texi (Search and Replace): Update the
documentation of 'perform-replace'.

* etc/NEWS: Another fix for the last change (noted by Juri Linkov)

* lisp/url/url-util.el (puny-encode-domain): Autoload it.

Mention next-error-select-buffer in etc/NEWS

Amend c-colon-type-list-re also to handle compound identifiers

* lisp/progmodes/cc-langs.el (c-colon-type-list-re): Amend to recognize and
skip over "::" in C++ and "." in Java.

Use text properties to save search parameters.  (Bug#22479)

* lisp/isearch.el (isearch-update-ring): Call isearch-string-propertize.
Delete duplicates with possibly different text properties.
(isearch-string-propertize)
(isearch-update-from-string-properties): New functions.
(with-isearch-suspended, isearch-ring-adjust1):
Call isearch-update-from-string-properties.
(isearch-edit-string): Let-bind minibuffer-allow-text-properties to t.
(isearch-query-replace): Use propertized isearch-string.
(isearch--lax-regexp-function-p): Simplify.

* lisp/replace.el (query-replace-descr): Rewrite to keep text properties
non-destructively in the replacement string.
(query-replace--split-string): Don't remove text properties
by substring-no-properties.
(query-replace-read-args): Try to get isearch-regexp-function
from text-properties.
(perform-replace): Display parameters in the replacement message.

* lisp/desktop.el (desktop--v2s): Check if text properties are unreadable.
(Bug#30786)

* lisp/isearch.el (isearch-mode-map): Restore advertised bindings.

Remove obsolete comments and code.

* lisp/replace.el (occur-find-match): Use user-error instead of error.
(Bug#14912)

Add REGION-NONCONTIGUOUS-P arg to other replace.el commands

* lisp/replace.el (query-replace, query-replace-regexp): Doc fix.
(query-replace-regexp-eval, map-query-replace-regexp)
(replace-string, replace-regexp): Add REGION-NONCONTIGUOUS-P arg.
(perform-replace): Doc fix.  (Bug#27897)