]> git.eshelyaron.com Git - emacs.git/log
emacs.git
7 years agoEnsure that user-mail-address always has a value
Glenn Morris [Sat, 18 Feb 2017 00:06:15 +0000 (19:06 -0500)]
Ensure that user-mail-address always has a value

* lisp/startup.el (user-mail-address): Initialize in the normal way.
(command-line): Reset user-mail-address if needed using
standard custom machinery.
* lisp/mail/feedmail.el (feedmail-fiddle-from):
* lisp/mail/rmail.el (rmail-unknown-mail-followup-to):
* lisp/mail/rmailsum.el (rmail-header-summary):
Simplify now that user-mail-address is always set.
; * doc/lispref/os.texi (System Environment): Remove fixme comment.

7 years agoTurn on lexical-binding in ruby-mode
Mark Oteiza [Sat, 18 Feb 2017 00:01:11 +0000 (19:01 -0500)]
Turn on lexical-binding in ruby-mode

* lisp/progmodes/ruby-mode.el: Turn on lexical-binding.
(ruby-font-lock-syntax-table): Use make-syntax-table.
(ruby-mode): 'define-derived-mode' writes the keys for us.

7 years agoTurn on lexical-binding in elint.el
Mark Oteiza [Fri, 17 Feb 2017 23:52:12 +0000 (18:52 -0500)]
Turn on lexical-binding in elint.el

* lisp/emacs-lisp/elint.el: Quote entry point commands in commentary.
(elint-running, elint-current-pos): Move these dynamic vars to toward
the top of the file.
(elint-check-quote-form): Ignore unused argument.
(elint-check-conditional-form): Remove unused binding.

7 years ago* lisp/emacs-lisp/subr-x.el (if-let*): Fix Edebug spec (Bug#24748)
Gemini Lasswell [Sun, 5 Feb 2017 00:16:11 +0000 (16:16 -0800)]
* lisp/emacs-lisp/subr-x.el (if-let*): Fix Edebug spec (Bug#24748)

7 years agoEnable erc-accidental-paste-threshold-seconds by default
Mark Oteiza [Fri, 17 Feb 2017 23:38:09 +0000 (18:38 -0500)]
Enable erc-accidental-paste-threshold-seconds by default

* lisp/erc/erc.el (erc-accidental-paste-threshold-seconds): Set
default to 0.2 (Bug#25709).

7 years agoFix build failure caused by ‘Generate upcase and downcase tables from Unicode’
Michal Nazarewicz [Fri, 17 Feb 2017 15:36:44 +0000 (16:36 +0100)]
Fix build failure caused by ‘Generate upcase and downcase tables from Unicode’

The [5ec3a584: Generate upcase and downcase tables from Unicode data]
commit broke bootstrap from a truly clean tree (e.g. a fresh clone or
one created with ‘make extraclean’), see
<http://hydra.nixos.org/build/48774928>.

The failure was caused by characters.el trying to read Unicode
property tables which aren’t available so early in the build process.

Wrap the part that requires Unicode property tables in a condition
checking if those are available.  If they aren’t they case and syntax
tables won’t be fully set but later on, the characters.el file will be
evaluated again and this time with Unicode properties available so
final Emacs ends up with the exact same case and syntax tables.

7 years agomm-add-meta-html-tag: Improve regexp
Katsumi Yamaoka [Fri, 17 Feb 2017 10:05:56 +0000 (10:05 +0000)]
mm-add-meta-html-tag: Improve regexp

* lisp/gnus/mm-decode.el (mm-add-meta-html-tag):
Improve regexp to search html meta tag.

7 years agomm-shr: Prefer charset specified in html meta tag
Katsumi Yamaoka [Fri, 17 Feb 2017 09:52:09 +0000 (09:52 +0000)]
mm-shr: Prefer charset specified in html meta tag

* lisp/gnus/mm-decode.el (mm-shr): Prefer charset specified in html
meta tag than mail-parse-charset in the case there is no charset spec
in MIME header.

7 years agoStop duplicating some custom-types in message.el
Glenn Morris [Fri, 17 Feb 2017 05:43:23 +0000 (21:43 -0800)]
Stop duplicating some custom-types in message.el

* lisp/gnus/message.el (user-mail-address, user-full-name):
No need to re-specify custom-type.

7 years agoWhitespace trivia in dunnet.el
Glenn Morris [Fri, 17 Feb 2017 04:33:24 +0000 (20:33 -0800)]
Whitespace trivia in dunnet.el

* lisp/play/dunnet.el (dun-special-object, dun-put-objs)
(dun-rlogin-endgame): Whitespace trivia.

7 years agoExplicit error on changing case of negative integers
Glenn Morris [Fri, 17 Feb 2017 04:24:37 +0000 (20:24 -0800)]
Explicit error on changing case of negative integers

* src/casefiddle.c (casify_object): Reject negative integers:
Emacs characters are positive integers.  (Bug#25684)

7 years agoFix buffers update in vc-retrieve-tag
Dmitry Gutov [Fri, 17 Feb 2017 01:00:46 +0000 (03:00 +0200)]
Fix buffers update in vc-retrieve-tag

* lisp/vc/vc.el (vc-retrieve-tag): When the granularity is
`repository', use the repository root and pass it to
vc-resynch-buffer (bug#25714).

7 years ago; Spelling, punctuation and minor wording fixes
Paul Eggert [Thu, 16 Feb 2017 17:17:45 +0000 (09:17 -0800)]
; Spelling, punctuation and minor wording fixes

7 years ago* src/buffer.h: Fix indenting.
Paul Eggert [Thu, 16 Feb 2017 15:55:28 +0000 (07:55 -0800)]
* src/buffer.h: Fix indenting.

7 years agoAdd sanity checks for Bswitch hash tables
Paul Eggert [Thu, 16 Feb 2017 15:52:57 +0000 (07:52 -0800)]
Add sanity checks for Bswitch hash tables

* src/bytecode.c (exec_byte_code) [BYTE_CODE_SAFE]:
Check that operand is a hash table and hashes to ints.

7 years ago* src/keyboard.c (read_key_sequence): Fix integer-overflow glitch.
Paul Eggert [Thu, 16 Feb 2017 15:49:03 +0000 (07:49 -0800)]
* src/keyboard.c (read_key_sequence): Fix integer-overflow glitch.

7 years agobytecomp.el: Avoid unnecessary calculation for jump table addresses.
Vibhav Pant [Thu, 16 Feb 2017 14:48:55 +0000 (20:18 +0530)]
bytecomp.el: Avoid unnecessary calculation for jump table addresses.

* lisp/emacs-lisp/bytecomp.el (byte-compile-lapcode): Don't do
  redundant operations while calculating the correct jump addresses
  from TAGs in jump tables.

7 years agoMinor changes in json.el
Mark Oteiza [Thu, 16 Feb 2017 01:43:55 +0000 (20:43 -0500)]
Minor changes in json.el

* lisp/json.el (json-advance): Simpler docstring.
(json-read-escaped-char): Use xdigit subform in rx expression.
(json-read-string): Just use = for char comparison.

7 years agoDon't expand body inside a let-binding when there are no bindings
Mark Oteiza [Thu, 16 Feb 2017 01:40:46 +0000 (20:40 -0500)]
Don't expand body inside a let-binding when there are no bindings

* lisp/emacs-lisp/pcase.el (pcase-codegen): Only let-bind if VARS
is non-nil.

7 years agoHandle user-mail-address being the empty string
Glenn Morris [Thu, 16 Feb 2017 01:23:07 +0000 (20:23 -0500)]
Handle user-mail-address being the empty string

* lisp/mail/feedmail.el (feedmail-fiddle-from):
* lisp/mail/rmail.el (rmail-unknown-mail-followup-to):
* lisp/mail/rmailsum.el (rmail-header-summary):
Belated update for 2002-09-29 startup.el change, 680ebfa, where
the value of user-mail-address during initialization was changed
from nil to the empty string.

7 years agoContinue to fix bug#25607
Michael Albinus [Wed, 15 Feb 2017 18:42:34 +0000 (19:42 +0100)]
Continue to fix bug#25607

* lisp/ido.el (ido-complete): Let-bind `non-essential' to nil.
(ido-file-name-all-completions-1): Do not bind `non-essential'.

* lisp/net/tramp.el: (tramp-completion-file-name-handler):
Improve autoloaded version.
(tramp-completion-file-name-handler): Remove old compat code.
Check only for `tramp-completion-mode-p'.
(tramp-completion-mode-p): Autoload.  Do not check any longer
for `last-input-event'.
(tramp-completion-handle-expand-file-name): Simplify.  (Bug#25607)

7 years agocasing: don’t assume letters are *either* upper- or lower-case (bug#24603)
Michal Nazarewicz [Wed, 7 Sep 2016 19:00:57 +0000 (21:00 +0200)]
casing: don’t assume letters are *either* upper- or lower-case  (bug#24603)

A compatibility digraph characters, such as Dž, are neither upper- nor
lower-case.  At the moment however, those are reported as upper-case¹
despite the fact that they change when upper-cased.

Stop checking if a character is upper-case before trying to up-case it
so that title-case characters are handled correctly.  This fixes one of
the issues mentioned in bug#24603.

¹ Because they change when converted to lower-case.  Notice an asymmetry
  in that for a character to be considered lower-case it must not be
  upper-case (plus the usual condition of changing when upper-cased).

* src/buffer.h (upcase1): Delete.
(upcase): Change to upcase character unconditionally just like downcase
does it.  This is what upcase1 was.

* src/casefiddle.c (casify_object, casify_region): Use upcase instead
of upcase1 and don’t check !uppercasep(x) before calling upcase.

* src/keyboard.c (read_key_sequence): Don’t check if uppercase(x), just
downcase(x) and see if it changed.

* test/src/casefiddle-tests.el (casefiddle-tests--characters,
casefiddle-tests-casing): Update test cases which are now passing.

7 years agoGenerate upcase and downcase tables from Unicode data (bug#24603)
Michal Nazarewicz [Sun, 18 Sep 2016 22:23:40 +0000 (00:23 +0200)]
Generate upcase and downcase tables from Unicode data  (bug#24603)

Use Unicode data to generate case tables instead of mostly repeating
them in lisp code.  Do that in a way which maps ‘Dz’ (and similar)
digraph to ‘dz’ when down- and ‘DZ’ when upcasing.

https://debbugs.gnu.org/cgi/bugreport.cgi?msg=89;bug=24603 lists all
changes to syntax table and case tables introduced by this commit.

* lisp/international/characters.el: Remove case-pairs defined with
explicit Lisp code and instead use Unicode character properties.

* test/src/casefiddle-tests.el (casefiddle-tests--characters,
casefiddle-tests-casing): Update test cases which are now working
as they should.

7 years agoAdd tests for casefiddle.c (bug#24603)
Michal Nazarewicz [Wed, 7 Sep 2016 20:17:21 +0000 (22:17 +0200)]
Add tests for casefiddle.c  (bug#24603)

Fixes cases marked FIXME upcoming in followup commits.

* test/src/casefiddle-tests.el (casefiddle-tests-char-properties,
casefiddle-tests-case-table, casefiddle-tests-casing-character,
casefiddle-tests-casing, casefiddle-tests-casing-byte8,
casefiddle-tests-casing-byte8-with-changes): New tests.
(casefiddle-tests--test-casing): New helper function for runnig
some of the tests.

7 years agooldXMenu: add missing #include <string.h>
Michal Nazarewicz [Fri, 10 Feb 2017 18:14:39 +0000 (19:14 +0100)]
oldXMenu: add missing #include <string.h>

Some of the files in oldXMenu use functions from string.h without
including that header which results in compile warnings:

ChgPane.c:46:5: warning: implicit declaration of function ‘strlen’
ChgPane.c:46:20: warning: incompatible implicit declaration of
built-in function ‘strlen’
ChgSel.c:62:2: warning: implicit declaration of function ‘strlen’
ChgSel.c:62:17: warning: incompatible implicit declaration of built-in
function ‘strlen’
Create.c:220:5: warning: implicit declaration of function ‘strcmp’
InsPane.c:65:5: warning: implicit declaration of function ‘strlen’
InsPane.c:65:20: warning: incompatible implicit declaration of
built-in function ‘strlen’
InsSel.c:68:5: warning: implicit declaration of function ‘strlen’
InsSel.c:68:20: warning: incompatible implicit declaration of built-in
function ‘strlen’
InsSel.c:75:5: warning: implicit declaration of function ‘strcmp’

Add the necessary ‘#include <string.h>’.

oldXMenu/ChgPane.c, oldXMenu/ChgSel.c, oldXMenu/Create.c, oldXMenu/InsPane.c,
oldXMenu/InsSel.c: add missing #include <string.h>

7 years agoFixup recent rmail patch
Paul Eggert [Wed, 15 Feb 2017 15:47:27 +0000 (07:47 -0800)]
Fixup recent rmail patch

* lisp/mail/rmail.el (rmail-epa-decrypt): Remove unused local.

7 years agoRmail fix
Richard Stallman [Wed, 15 Feb 2017 15:45:51 +0000 (07:45 -0800)]
Rmail fix

* lisp/mail/rmail.el (rmail-epa-decrypt-1): Include the just-decrypted text
as element 4 of the value.
(rmail-epa-decrypt): Take the text to insert from that element.

7 years agobytecomp-tests.el: Store all test forms in one constant.
Vibhav Pant [Wed, 15 Feb 2017 15:33:05 +0000 (21:03 +0530)]
bytecomp-tests.el: Store all test forms in one constant.

* test/lisp/emacs-lisp/bytecomp-tests.el: Store all test expressions
in a single constant (byte-opt-testsuite-arith-data), add new forms
which generate lapcode with adjacent/redundant tags.

7 years agoSmall lispref edit
Glenn Morris [Wed, 15 Feb 2017 07:34:49 +0000 (23:34 -0800)]
Small lispref edit

* doc/lispref/os.texi (User Identification):
Remove extraneous detail about user-mail-address.

7 years agoDocument fill-separate-heterogeneous-words-with-space (bug#25685)
Katsumi Yamaoka [Wed, 15 Feb 2017 05:59:29 +0000 (05:59 +0000)]
Document fill-separate-heterogeneous-words-with-space (bug#25685)

* doc/lispref/text.texi (Filling):
Document fill-separate-heterogeneous-words-with-space (bug#25685).

7 years agoTest comment-multi-line = nil auto fill case too
Noam Postavsky [Sun, 12 Feb 2017 04:15:13 +0000 (23:15 -0500)]
Test comment-multi-line = nil auto fill case too

* test/lisp/progmodes/js-tests.el (js-mode-auto-fill): Test with
`comment-multi-line' both nil and non-nil.
* lisp/newcomment.el (comment-multi-line): Mark safe if it's a
boolean.
* etc/NEWS: Mention that `js-mode' now sets `comment-multi-line'.

7 years agoDon't delete leading and trailing space from CJK word (bug#25685)
Katsumi Yamaoka [Wed, 15 Feb 2017 01:26:59 +0000 (01:26 +0000)]
Don't delete leading and trailing space from CJK word (bug#25685)

* lisp/textmodes/fill.el (fill-delete-newlines):
Don't delete leading and trailing space from CJK word.
(fill-separate-heterogeneous-words-with-space):
New user option that controls it (bug#25685).

7 years ago‘M-s w RET word C-s’ repeats incremental search.
Juri Linkov [Tue, 14 Feb 2017 23:28:15 +0000 (01:28 +0200)]
‘M-s w RET word C-s’ repeats incremental search.

* lisp/isearch.el (isearch-new-nonincremental): New variable.
(with-isearch-suspended): Bind isearch-new-nonincremental to
isearch-nonincremental, and restore it afterwards.
(isearch-forward-exit-minibuffer, isearch-reverse-exit-minibuffer):
Set isearch-new-nonincremental to nil.  (Bug#25562)

7 years agoMake vc-git detect conflict state for vc-dir
Tom Tromey [Tue, 14 Feb 2017 01:09:36 +0000 (18:09 -0700)]
Make vc-git detect conflict state for vc-dir

* lisp/vc/vc-git.el (vc-git-dir-status-state): New struct.
(vc-git-dir-status-update-file): New function.
(vc-git-after-dir-status-stage, vc-git-dir-status-goto-stage): Use
vc-git-dir-status-state; add 'ls-files-conflict state.
(vc-git-dir-status-files): Create a vc-git-dir-status-state.

7 years agobyte-opt: Replace merged tags in jump tables too. (bug#25716)
Vibhav Pant [Tue, 14 Feb 2017 16:17:59 +0000 (21:47 +0530)]
byte-opt: Replace merged tags in jump tables too. (bug#25716)

* lisp/emacs-lisp/byte-opt.el (byte-optimize-lapcode): While merging
  adjacent tags, make sure that the old tag is replaced in all jump
  tables, if any. This fixes the bytecode VM jumping to the wrong
  address in compiled cond forms where the body of a clause was a loop
  of any sort.

7 years ago; * test/file-organization.org: Minor copyedits.
Eli Zaretskii [Tue, 14 Feb 2017 16:17:51 +0000 (18:17 +0200)]
; * test/file-organization.org: Minor copyedits.

7 years agoRemove overly broad element from default mail-dont-reply-to-names
Glenn Morris [Tue, 14 Feb 2017 07:36:17 +0000 (23:36 -0800)]
Remove overly broad element from default mail-dont-reply-to-names

* lisp/mail/mail-utils.el (mail-dont-reply-to):
Do not include just "user@" in mail-dont-reply-to-names, and simplify.
Ref: lists.gnu.org/archive/html/help-gnu-emacs/2017-02/msg00049.html
* lisp/gnus/message.el (message-dont-reply-to-names): Doc fix.
* doc/misc/message.texi (Wide Reply): Tiny fix re dont-reply-to-names.

7 years ago* etc/NEWS: Mention query-replace-from-to-separator. (Bug#25482)
Juri Linkov [Tue, 14 Feb 2017 00:04:28 +0000 (02:04 +0200)]
* etc/NEWS: Mention query-replace-from-to-separator.  (Bug#25482)

7 years ago; etc/TODO: Remove 'switch' item, as it is now implemented.
Vibhav Pant [Mon, 13 Feb 2017 17:24:05 +0000 (22:54 +0530)]
; etc/TODO: Remove 'switch' item, as it is now implemented.

7 years agoMatch all characters in optional argument of \documentclass
Arash Esbati [Mon, 13 Feb 2017 08:22:12 +0000 (09:22 +0100)]
Match all characters in optional argument of \documentclass

* lisp/textmodes/reftex.el (reftex-TeX-master-file): Match all
characters in optional argument containing name of the main file.

7 years agoMerge branch 'master' into feature/byte-switch feature/byte-switch
Vibhav Pant [Mon, 13 Feb 2017 11:37:36 +0000 (17:07 +0530)]
Merge branch 'master' into feature/byte-switch

7 years ago; Add more documentation for byte-switch related code.
Vibhav Pant [Mon, 13 Feb 2017 11:14:06 +0000 (16:44 +0530)]
; Add more documentation for byte-switch related code.

7 years agoFix non-ASCII text encoding (bug#25658)
Katsumi Yamaoka [Mon, 13 Feb 2017 08:30:28 +0000 (08:30 +0000)]
Fix non-ASCII text encoding (bug#25658)

* lisp/gnus/mm-bodies.el (mm-encode-body):
Fix non-ASCII text encoding (bug#25658).

7 years agotest/lisp/emacs-lisp/bytecomp-tests.el: Add more tests for switch.
Vibhav Pant [Mon, 13 Feb 2017 07:48:54 +0000 (13:18 +0530)]
test/lisp/emacs-lisp/bytecomp-tests.el: Add more tests for switch.

7 years agoFix recent bootstrap issue by moving string-to-list
Glenn Morris [Mon, 13 Feb 2017 03:02:56 +0000 (19:02 -0800)]
Fix recent bootstrap issue by moving string-to-list

* lisp/international/mule-util.el (string-to-list, string-to-vector):
Move from here...
* lisp/subr.el (string-to-list, string-to-vector): ...to here.
The implementation is trivial and at least string-to-list
has ended up being needed early during bootstrap.

7 years agoDoc fixes related to mail-host-address
Glenn Morris [Mon, 13 Feb 2017 01:53:13 +0000 (17:53 -0800)]
Doc fixes related to mail-host-address

* lisp/startup.el (mail-host-address): Doc fix.
* doc/lispref/os.texi (System Environment):
Remove extraneous details of mail-host-address.

7 years agoSimplify time-stamp mail host usage
Glenn Morris [Mon, 13 Feb 2017 01:44:46 +0000 (17:44 -0800)]
Simplify time-stamp mail host usage

* lisp/time-stamp.el (time-stamp-mail-host-name): Remove function.
(time-stamp-string-preprocess): Handle "h" (mail host) directly.

7 years agoDoc fix for vhdl-mode re mail-host-address
Glenn Morris [Mon, 13 Feb 2017 01:36:33 +0000 (17:36 -0800)]
Doc fix for vhdl-mode re mail-host-address

* lisp/progmodes/vhdl-mode.el (vhdl-file-header): Doc fix.
(mail-host-address): Do not add to vhdl-related custom group,
since vhdl-template-replace-header-keywords doesn't use it.

7 years agoSubstitute leading $HOME/ in xdg-user-dirs
Mark Oteiza [Mon, 13 Feb 2017 01:25:57 +0000 (20:25 -0500)]
Substitute leading $HOME/ in xdg-user-dirs

* lisp/xdg.el (xdg--substitute-home-env): New function.
(xdg--user-dirs-parse-line): Use it.
(xdg-user-dir): Expand ~/ in xdg-user-dirs values.

7 years ago* lisp/buff-menu.el: Turn on lexical-binding.
Mark Oteiza [Mon, 13 Feb 2017 01:02:26 +0000 (20:02 -0500)]
* lisp/buff-menu.el: Turn on lexical-binding.

7 years ago* lisp/replace.el (query-replace-from-to-separator): Move propertize
Juri Linkov [Mon, 13 Feb 2017 00:37:52 +0000 (02:37 +0200)]
* lisp/replace.el (query-replace-from-to-separator): Move propertize

and char-displayable-p test to query-replace-read-from.
Add choice nil to disable this feature.
(query-replace-read-from): Don't reevaluate custom setting.
Use char-displayable-p to test the first non-whitespace character
in query-replace-from-to-separator, use " -> " when fails.
Add prompt for the case when separator is nil but
query-replace-defaults is non-nil.
Remove unused test for regexp-flag.
Thanks to Thierry Volpiatto <thierry.volpiatto@gmail.com>

7 years agoConvert more uses of `looking-at' to `following-char'
Karl Fogel [Sun, 12 Feb 2017 23:21:06 +0000 (17:21 -0600)]
Convert more uses of `looking-at' to `following-char'

This follows up to Mark Oteiza's commit of 12 Feb 2017, 14:46:03 UTC
(commit 91478f46238a) with more of the same.

* lisp/bookmark.el (bookmark-send-edited-annotation):
  (bookmark-bmenu-execute-deletions): Replace instances of looking-at
  with char comparisons using following-char.

7 years agoFix typos in tests for lax-plist-get etc.
Paul Eggert [Sun, 12 Feb 2017 20:55:11 +0000 (12:55 -0800)]
Fix typos in tests for lax-plist-get etc.

Problem reported by Eli Zaretskii (Bug#25606#62).
* test/src/fns-tests.el (test-cycle-lax-plist-get)
(test-cycle-plist-put, test-cycle-lax-plist-put):
Fix tests to match behavior.

7 years agoFix bug#25607
Michael Albinus [Sun, 12 Feb 2017 17:19:32 +0000 (18:19 +0100)]
Fix bug#25607

* lisp/net/tramp.el (tramp-completion-file-name-handler):
Improve autoloaded version.
(tramp-autoload-file-name-handler): Avoid recursive load.
(tramp-completion-handle-expand-file-name): Handle empty NAME.
(Bug#25607)

7 years agoRemove server-buffer-clients string from minor-mode-alist
Mark Oteiza [Sun, 12 Feb 2017 16:51:19 +0000 (11:51 -0500)]
Remove server-buffer-clients string from minor-mode-alist

* lisp/server.el: Don't put an element for server-buffer-clients into
minor-mode-alist. (Bug#20201)

7 years agoNix some useless uses of looking-at, looking-back
Mark Oteiza [Sun, 12 Feb 2017 14:46:03 +0000 (09:46 -0500)]
Nix some useless uses of looking-at, looking-back

* lisp/allout.el (allout-kill-topic):
(allout-next-topic-pending-encryption):
* lisp/bookmark.el (bookmark-kill-line):
* lisp/cus-edit.el (custom-save-variables, custom-save-faces):
* lisp/cus-theme.el (custom-theme-write-variables):
(custom-theme-write-faces):
* lisp/emacs-lisp/autoload.el (autoload-generate-file-autoloads):
* lisp/emacs-lisp/bytecomp.el (byte-compile-from-buffer):
* lisp/emacs-lisp/checkdoc.el (checkdoc-interactive-loop):
(checkdoc-interactive-ispell-loop):
(checkdoc-message-interactive-ispell-loop, checkdoc-this-string-valid):
(checkdoc-this-string-valid-engine):
* lisp/emacs-lisp/elint.el (elint-get-top-forms):
* lisp/emulation/viper-cmd.el (viper-backward-indent):
* lisp/image-dired.el (image-dired-delete-char):
* lisp/simple.el (kill-visual-line): Replace instances of looking-at,
looking-back with char comparisons using following-char, preceding-char.

7 years ago; lisp/emacs-lisp/bytecomp.el: Fix indentation.
Vibhav Pant [Sun, 12 Feb 2017 07:54:55 +0000 (13:24 +0530)]
; lisp/emacs-lisp/bytecomp.el: Fix indentation.

7 years agoRecognize JS regexp literals more correctly
Tom Tromey [Sun, 5 Feb 2017 18:40:18 +0000 (11:40 -0700)]
Recognize JS regexp literals more correctly

Bug#25529
* lisp/progmodes/js.el (js--syntax-propertize-regexp-regexp): New
constant.
(js-syntax-propertize-regexp): Use it.  Remove "end" argument.
(js--syntax-propertize-regexp-syntax-table): Remove.
(js-syntax-propertize): Update.
* test/lisp/progmodes/js-tests.el (js-mode-regexp-syntax-bug-25529):
New test.

7 years agosrc/bytecode.c (exec_byte_code): Make hash_code a Lisp_Object.
Vibhav Pant [Sat, 11 Feb 2017 18:11:56 +0000 (23:41 +0530)]
src/bytecode.c (exec_byte_code): Make hash_code a Lisp_Object.

This avoids using XUINT every time while comparing it with
HASH_HASH (h, i), replacing it with EQ.

7 years agosrc/bytecode.c (exec_byte_code): Remove unnecessary (e)assert.
Vibhav Pant [Sat, 11 Feb 2017 17:39:47 +0000 (23:09 +0530)]
src/bytecode.c (exec_byte_code): Remove unnecessary (e)assert.

7 years agoFix bug in css--mdn-find-symbol
Tom Tromey [Sat, 11 Feb 2017 15:43:33 +0000 (08:43 -0700)]
Fix bug in css--mdn-find-symbol

* lisp/textmodes/css-mode.el (css--mdn-find-symbol): Skip whitespace
before skipping word characters.
test/lisp/textmodes/css-mode-tests.el (css-mdn-symbol-guessing): Add
regression test.

7 years ago; src/bytecode.c (exec_byte_code): Refactor byte-switch code.
Vibhav Pant [Sat, 11 Feb 2017 15:06:30 +0000 (20:36 +0530)]
; src/bytecode.c (exec_byte_code): Refactor byte-switch code.

Remove unnecessary asserts, remove duplicate code.

7 years agosrc/bytecode.c: Add optional sanity check for jump tables.
Vibhav Pant [Sat, 11 Feb 2017 14:43:54 +0000 (20:13 +0530)]
src/bytecode.c: Add optional sanity check for jump tables.

* src/bytecode.c (exec_byte_code): When sanity checks are enabled,
  check that the jump table's size is equal to it's count.

7 years agoMerge branch 'master' into feature/byte-switch
Vibhav Pant [Sat, 11 Feb 2017 14:24:37 +0000 (19:54 +0530)]
Merge branch 'master' into feature/byte-switch

7 years ago* src/bytecode.c: Refactor to follow GNU coding standards
Vibhav Pant [Sat, 11 Feb 2017 12:47:57 +0000 (18:17 +0530)]
* src/bytecode.c: Refactor to follow GNU coding standards

7 years agoFix handling of XBM images on MS-Windows
Eli Zaretskii [Sat, 11 Feb 2017 09:55:11 +0000 (11:55 +0200)]
Fix handling of XBM images on MS-Windows

* src/image.c (xbm_load) [HAVE_NTGUI]: Fix calculation of
'nbytes' when inverting XBM data bits.  (Bug#25661)

7 years ago; Fix typo in etc/NEWS
Michael Albinus [Sat, 11 Feb 2017 09:29:29 +0000 (10:29 +0100)]
; Fix typo in etc/NEWS

7 years agoFix handling of PBM data
Eli Zaretskii [Sat, 11 Feb 2017 09:09:33 +0000 (11:09 +0200)]
Fix handling of PBM data

* src/image.c (pbm_load): Handle PBM data with no blanks between
individual pixel values correctly.  (Bug#25660)

7 years agoFix warnings in debug tracing code
Noam Postavsky [Fri, 10 Feb 2017 20:33:05 +0000 (15:33 -0500)]
Fix warnings in debug tracing code

* src/xdisp.c (dump_glyph, dump_glyph_string):
* src/xfaces.c (dump_realized_face): Cast arguments or adjust format
specifiers to match signedness.

7 years agoExtract grep-find-ignored-directories processing from rgrep-default-command
Sam Steingold [Fri, 10 Feb 2017 19:53:02 +0000 (14:53 -0500)]
Extract grep-find-ignored-directories processing from rgrep-default-command

(rgrep-find-ignored-directories): Extract from `rgrep-default-command'.
Some Emacs packages use `grep-find-ignored-directories' to ignore some
directories, so will use this function instead of custom code.
(rgrep-default-command): Use `rgrep-find-ignored-directories'.

7 years agosrc/bytecode.c: Avoid comparing values unnecessarily in Bswitch
Vibhav Pant [Fri, 10 Feb 2017 17:55:42 +0000 (23:25 +0530)]
src/bytecode.c: Avoid comparing values unnecessarily in Bswitch

* src/bytecode.c: (exec_byte_code) While linear searching the jump
  table, compare the value's hash table first to avoid calling
  h->test.cmpfn every time.

7 years agoFix a few integer-overflow glitches
Paul Eggert [Fri, 10 Feb 2017 16:34:57 +0000 (08:34 -0800)]
Fix a few integer-overflow glitches

* src/composite.c (composition_compute_stop_pos, composition_reseat_it):
* src/dispextern.h (struct composition_it.rule_idx):
* src/keyboard.c (Fset__this_command_keys):
* src/xwidget.c (webkit_js_to_lisp):
Don’t assume object sizes fit in ‘int’.
* src/xwidget.c (Fxwidget_resize):
Don’t assume Emacs integers fit in ‘int’.

7 years agoFix a bug with displaying an image after a TAB
Eli Zaretskii [Fri, 10 Feb 2017 16:19:11 +0000 (18:19 +0200)]
Fix a bug with displaying an image after a TAB

* src/xdisp.c (display_line): Handle TAB at end of screen line
specially only when we are displaying characters.  (Bug#25662)

7 years agoMove cyclic tests to fns-tests.el
Paul Eggert [Fri, 10 Feb 2017 09:52:41 +0000 (11:52 +0200)]
Move cyclic tests to fns-tests.el

* test/src/fns-tests.el (cyc1, cyc2, dot1, dot2): New functions.
(test-cycle-length, test-cycle-safe-length, test-cycle-member)
(test-cycle-memq, test-cycle-memql, test-cycle-assq)
(test-cycle-assoc, test-cycle-rassq, test-cycle-rassoc)
(test-cycle-delq, test-cycle-delete, test-cycle-reverse)
(test-cycle-plist-get, test-cycle-lax-plist-get)
(test-cycle-plist-member, test-cycle-plist-put)
(test-cycle-lax-plist-put, test-cycle-equal, test-cycle-nconc):
New tests.
* test/manual/cyclic-tests.el: File deleted.

7 years agoFix instrumenting code with propertized strings in Edebug
Gemini Lasswell [Fri, 10 Feb 2017 09:35:20 +0000 (11:35 +0200)]
Fix instrumenting code with propertized strings in Edebug

* lisp/emacs-lisp/edebug.el (edebug-read-function): Allow
'read' to decide what is and isn't a syntax error.  (Bug#25068)

7 years agoImprove fontification in bat-mode
Vladimir Panteleev [Fri, 10 Feb 2017 09:23:24 +0000 (11:23 +0200)]
Improve fontification in bat-mode

* lisp/progmodes/bat-mode.el (bat-font-lock-keywords): Match
word and symbol constituents when looking for variable names
to fontify; also, correct the syntax table and mark the equal
sign (=) character as punctuation.  Improve fontification
accuracy of iteration/positional variables.
(bat-mode): Set comment-start-skip.  (Bug#25541)

* test/lisp/progmodes/bat-mode-tests.el: New file, tests for
bat-mode.el.

7 years agoRestore special setting of this-command-keys by M-x
Eli Zaretskii [Fri, 10 Feb 2017 08:57:41 +0000 (10:57 +0200)]
Restore special setting of this-command-keys by M-x

It was lost when execute-extended-command was reimplemented in Lisp.

* src/keyboard.c (Fset__this_command_keys): New function.
(syms_of_keyboard): Defsubr it.

* lisp/simple.el (execute-extended-command): Set this-command-keys
as novice.el expects.  (Bug#25612)

7 years ago* lisp/isearch.el (isearch-search-fun-default): Set isearch-adjusted
Juri Linkov [Thu, 9 Feb 2017 22:35:22 +0000 (00:35 +0200)]
* lisp/isearch.el (isearch-search-fun-default): Set isearch-adjusted

to t to display "Pending" in the search prompt for lax
word/symbol search (bug#25562).  Don't use lax for lazy-highlighting
when 'bound' is non-nil.
(word-search-regexp, isearch-symbol-regexp): Don't depend on lax
at the beginning of regexp (bug#22589).

* lisp/info.el (Info-isearch-search):
Use isearch--lax-regexp-function-p.

* doc/emacs/search.texi (Word Search, Symbol Search):
Mention "Pending" prompt for lax word/symbol search.

7 years agosrc/bytecode.c (exec_byte_code): Remove unneeded assert.
Vibhav Pant [Thu, 9 Feb 2017 16:26:57 +0000 (21:56 +0530)]
src/bytecode.c (exec_byte_code): Remove unneeded assert.

7 years agobytecode.c (exec_byte_code): Use h->count instead of HASH_TABLE_SIZE
Vibhav Pant [Thu, 9 Feb 2017 13:42:59 +0000 (19:12 +0530)]
bytecode.c (exec_byte_code): Use h->count instead of HASH_TABLE_SIZE

7 years agobytecode.c (exec_byte_code): don't check hash code in linear search.
Vibhav Pant [Thu, 9 Feb 2017 13:13:31 +0000 (18:43 +0530)]
bytecode.c (exec_byte_code): don't check hash code in linear search.

* src/bytecode.c (exec_byte_code): Don't check that the hash code is
  not nil when linear scanning the jump table. Hash tables for are
  declared with :size as the exact number of cases, so each entry i
  should have a hash code. When BYTE_CODE_SAFE, do it as a sanity
  check.

7 years agoIbuffer: Update mode documentation
Tino Calancha [Thu, 9 Feb 2017 12:36:32 +0000 (21:36 +0900)]
Ibuffer: Update mode documentation

* lisp/ibuffer.el (ibuffer-mode): List newest commands in mode documentation.

7 years agoFix environment variable for xdg-data-dirs
Steven Allen [Thu, 9 Feb 2017 06:08:09 +0000 (22:08 -0800)]
Fix environment variable for xdg-data-dirs

* lisp/xdg.el (xdg-data-dirs): Use XDG_DATA_DIRS, not XDG_CONFIG_DIRS

Copyright-paperwork-exempt: yes

7 years ago; Theme updates
Tassilo Horn [Thu, 9 Feb 2017 11:02:43 +0000 (12:02 +0100)]
; Theme updates

; * etc/themes/tsdh-light-theme.el (tsdh-light): Theme updates.

7 years agoIbuffer: Erase output buffer before shell commands
Tino Calancha [Thu, 9 Feb 2017 09:14:10 +0000 (18:14 +0900)]
Ibuffer: Erase output buffer before shell commands

* lisp/ibuf-macs.el (define-ibuffer-op): Add keyword arguments
BEFORE and AFTER; they are forms to run before/after the operation.
* lisp/ibuf-ext.el (ibuffer--maybe-erase-shell-cmd-output):
New defun; if shell-command-dont-erase-buffer is nil, then
erase shell command output buffer.
(ibuffer-do-shell-command-pipe, ibuffer-do-shell-command-file): Use it.

7 years agoIbuffer: Don't truncate shell command output
Tino Calancha [Thu, 9 Feb 2017 09:13:59 +0000 (18:13 +0900)]
Ibuffer: Don't truncate shell command output

* lisp/ibuf-ext.el (ibuffer-do-shell-command-pipe)
(ibuffer-do-shell-command-pipe-replace)
Use 'call-shell-region' (Bug#22679).
(ibuffer-do-shell-command-file): Use call-process-shell-command.
If FILE, the file that the buffer object is visiting,
exists and the buffer is up-to-date, then use
FILE instead of creating a temporary file (Bug#22679).

7 years agoImprove byte-switch execution.
Vibhav Pant [Thu, 9 Feb 2017 06:48:54 +0000 (12:18 +0530)]
Improve byte-switch execution.

* lisp/emacs-lisp/byte-opt.el,
  lisp/emacs-lisp/bytecomp.el (byte-decompile-bytecode-1),
  (byte-compile-lapcode): Calculate the actual jump address while
  compiling, store it in the jump table.

* src/bytecode.c: Jump to the looked up value directly, do a linear
  search when the number of elements is <= 5.

7 years agoMake sure eshell pipelines don't drop data
Noam Postavsky [Thu, 2 Feb 2017 14:19:43 +0000 (09:19 -0500)]
Make sure eshell pipelines don't drop data

* lisp/eshell/esh-proc.el (eshell-sentinel): If called while still
handling output of the process, make sure to close the pipes only later,
so that the next process in the pipeline recieves EOF only after getting
all its input (Bug#25549).

7 years agoMake mm-shr use mail-parse-charset by default
Katsumi Yamaoka [Thu, 9 Feb 2017 00:41:19 +0000 (00:41 +0000)]
Make mm-shr use mail-parse-charset by default

* lisp/gnus/mm-decode.el (mm-shr): Use mail-parse-charset by default.
This helps an html message with no charset spec to be decoded.

7 years agodescribe-char: unambiguous name for inserting ASCII 7
Stephen Berman [Wed, 8 Feb 2017 21:38:39 +0000 (22:38 +0100)]
describe-char: unambiguous name for inserting ASCII 7

* lisp/descr-text.el (describe-char): Make the input
suggestion for inserting ASCII character 7 by name use the
unambiguous name "BELL (BEL)" (bug#25641).

7 years agoModify suppressing `vc-refresh-state' in filenotify-tests.el
Michael Albinus [Wed, 8 Feb 2017 18:33:52 +0000 (19:33 +0100)]
Modify suppressing `vc-refresh-state' in filenotify-tests.el

* test/lisp/filenotify-tests.el (file-notify-test03-autorevert):
Use an advice rather than an alias for suppressing `vc-refresh-state'.

7 years agoSuppress undesired error messages in filenotify-tests.el
Michael Albinus [Tue, 7 Feb 2017 20:42:12 +0000 (21:42 +0100)]
Suppress undesired error messages in filenotify-tests.el

* test/lisp/filenotify-tests.el (file-notify-test03-autorevert):
Suppress `vc-refresh-state', it produces undesired error messages.

7 years agoEnsure that Gnus bugs show up in the Emacs tracker
Lars Ingebrigtsen [Tue, 7 Feb 2017 14:52:36 +0000 (15:52 +0100)]
Ensure that Gnus bugs show up in the Emacs tracker

* lisp/gnus/gnus.el (gnus-bug-package): Include Emacs in the
package spec.

7 years agoRevert "Don't tag Gnus bugs with "gnus""
Lars Ingebrigtsen [Tue, 7 Feb 2017 14:50:39 +0000 (15:50 +0100)]
Revert "Don't tag Gnus bugs with "gnus""

This reverts commit b6fa58072304c2a24f1fe8a0e06a4739a7f8211b.

The debbugs syntax requires a package name

7 years agoAdd tests for checking byte-switch code.
Vibhav Pant [Tue, 7 Feb 2017 14:05:20 +0000 (19:35 +0530)]
Add tests for checking byte-switch code.

* test/lisp/emacs-lisp/bytecomp-tests.el (bytecomp-cond): New test,
  test byte-switch bytecode.

7 years agoAdd xdg library
Mark Oteiza [Tue, 7 Feb 2017 04:27:47 +0000 (23:27 -0500)]
Add xdg library

* etc/NEWS: Mention new library.
* lisp/xdg.el: New file.

7 years agoDo not trick info/dir’s timestamp
Paul Eggert [Tue, 7 Feb 2017 02:00:13 +0000 (18:00 -0800)]
Do not trick info/dir’s timestamp

* Makefile.in (${srcdir}/info/dir): When making this file, do not
do anything special about its timestamp.  Previously this rule
used move-if-change, which meant that this file’s timestamp could
end up being older than the files it depends on, and this caused
‘make --question info’ to fail, which caused ‘make-dist’ to fail
now that ‘make-dist’ invokes ‘make --question info’.

7 years agoMake FOR_EACH_TAIL more like other FOR_EACH macros
Paul Eggert [Tue, 7 Feb 2017 01:15:14 +0000 (17:15 -0800)]
Make FOR_EACH_TAIL more like other FOR_EACH macros

See comments by Stefan Monnier in:
http://lists.gnu.org/archive/html/emacs-devel/2017-02/msg00181.html
and by Eli Zaretskii in:
http://lists.gnu.org/archive/html/emacs-devel/2017-02/msg00207.html
* src/fns.c (internal_equal): Do not bypass check for depth
overflow when tail-recursing via a dotted list tail or an overlay
plist, to avoid a rare infloop.
* src/lisp.h (FOR_EACH_TAIL, FOR_EACH_TAIL_SAFE): Take TAIL as an
arg, and update it at each iteration, rather than have callers
access it.tail.  All callers changed.
(FOR_EACH_TAIL): Do not check for dotted lists, as this is now
the caller’s responsibility.  All callers changed.
(FOR_EACH_TAIL_CONS): Remove.  All callers changed.
(struct for_each_tail_internal.tail): Remove; no longer needed.
(FOR_EACH_TAIL_INTERNAL): Remove dotted arg, and set the tail
arg each time through the loop.  All callers changed.

7 years ago; bytecomp.el (byte-compile-cond-jump-table): Add TODO note
Vibhav Pant [Mon, 6 Feb 2017 14:03:01 +0000 (19:33 +0530)]
; bytecomp.el (byte-compile-cond-jump-table): Add TODO note

7 years ago; byte(-opt, comp).el: Add more documentation for byte-switch code.
Vibhav Pant [Mon, 6 Feb 2017 07:56:25 +0000 (13:26 +0530)]
; byte(-opt, comp).el: Add more documentation for byte-switch code.