]> git.eshelyaron.com Git - emacs.git/log
emacs.git
3 years ago; Stylistic docfixes in htmlfontify.el found by checkdoc
Stefan Kangas [Tue, 21 Sep 2021 16:12:07 +0000 (18:12 +0200)]
; Stylistic docfixes in htmlfontify.el found by checkdoc

3 years agoDon't use `format' on strings without % format directives
Lars Ingebrigtsen [Tue, 21 Sep 2021 15:52:53 +0000 (17:52 +0200)]
Don't use `format' on strings without % format directives

* lisp/vc/ediff-init.el (ediff-BAD-INFO):
* lisp/url/url-ldap.el (url-ldap):
* lisp/url/url-http.el (url-http--user-agent-default-string):
* lisp/textmodes/reftex.el (reftex-access-parse-file):
* lisp/textmodes/reftex-index.el (reftex-index-phrases-info):
* lisp/textmodes/ispell.el (ispell-create-debug-buffer):
* lisp/term.el (serial-read-speed):
* lisp/progmodes/verilog-mode.el (verilog-scan-debug):
* lisp/progmodes/idlwave.el (idlwave-find-module):
* lisp/progmodes/compile.el (compilation-revert-buffer):
* lisp/org/org-agenda.el (org-search-view):
* lisp/net/telnet.el (telnet-revert-buffer):
* lisp/net/soap-inspect.el (soap-sample-value-for-xs-simple-type):
* lisp/net/newst-backend.el (newsticker--cache-read):
* lisp/mh-e/mh-seq.el (mh-msg-is-in-seq):
* lisp/mail/smtpmail.el (smtpmail-via-smtp):
* lisp/mail/emacsbug.el (report-emacs-bug):
* lisp/jsonrpc.el (jsonrpc-error):
* lisp/help-fns.el (describe-variable):
* lisp/gnus/mm-decode.el (mm-possibly-verify-or-decrypt):
* lisp/gnus/gnus.el (gnus-group-startup-message):
(gnus-group-startup-message):
* lisp/gnus/gnus-group.el (gnus-group-restart):
* lisp/frame.el (make-frame-on-display):
* lisp/emulation/viper-ex.el (ex-help):
* lisp/calendar/icalendar.el (icalendar--convert-ical-to-diary):
(icalendar--add-diary-entry):
* lisp/calendar/cal-tex.el (cal-tex-end-document):
* lisp/calc/calcalg3.el (math-ninteg-romberg): Don't use `format'
on strings that have no % format directives in them.

3 years agoFix usage of `format' in mm-uu-pgp-encrypted-extract
Lars Ingebrigtsen [Tue, 21 Sep 2021 15:47:55 +0000 (17:47 +0200)]
Fix usage of `format' in mm-uu-pgp-encrypted-extract

* lisp/gnus/mm-uu.el (mm-uu-pgp-encrypted-extract): Use
`substring' instead of `format' to ensure a fresh string.

3 years agoFix usage of `format' in `article-verify-x-pgp-sig'
Lars Ingebrigtsen [Tue, 21 Sep 2021 15:46:10 +0000 (17:46 +0200)]
Fix usage of `format' in `article-verify-x-pgp-sig'

* lisp/gnus/gnus-art.el (article-verify-x-pgp-sig): Use
`substring' instead of `format' to ensure a fresh string.

3 years agoFix PGP verification buttons (which would have cached results)
Lars Ingebrigtsen [Tue, 21 Sep 2021 15:41:26 +0000 (17:41 +0200)]
Fix PGP verification buttons (which would have cached results)

* lisp/gnus/mm-uu.el (mm-uu-pgp-signed-extract): `format' was used
here to guarantee a new, fresh string (since it's destructively
modified), but that's apparently not the case any more.  Use
`substring' instead, which is documented to do this.

3 years agoDon't inhibit redisplay in the mml* functions
Lars Ingebrigtsen [Tue, 21 Sep 2021 15:39:02 +0000 (17:39 +0200)]
Don't inhibit redisplay in the mml* functions

* lisp/gnus/mml-smime.el (inhibit-redisplay): Removed.
(mml-smime-epg-encrypt):
(mml-smime-epg-verify): Don't inhibit.

* lisp/gnus/mml1991.el (mml1991-epg-sign): Ditto.

* lisp/gnus/mml2015.el (inhibit-redisplay): Removed
(mml2015-epg-decrypt):
(mml2015-epg-clear-decrypt):
(mml2015-epg-verify):
(mml2015-epg-clear-verify):
(mml2015-epg-sign):
(mml2015-epg-encrypt): Don't bind `inhibit-redisplay', because it
makes debugging very odd, and doesn't seem to help much with anything.

3 years ago* python.el (python-syntax-stringify): Extend comment about last change
Stefan Monnier [Tue, 21 Sep 2021 15:39:24 +0000 (11:39 -0400)]
* python.el (python-syntax-stringify): Extend comment about last change

3 years agoFix emoji-zwj.awk dolist
Robert Pluim [Tue, 21 Sep 2021 15:32:20 +0000 (17:32 +0200)]
Fix emoji-zwj.awk dolist

* admin/unidata/emoji-zwj.awk: Fix typo, the dolist should end
after the first set-char-table-range.

3 years agoMake recent dired tests check for external executables
Glenn Morris [Tue, 21 Sep 2021 15:14:01 +0000 (08:14 -0700)]
Make recent dired tests check for external executables

* test/lisp/dired-aux-tests.el (dired-test-bug47058-tar)
(dired-test-bug47058-zip): Add skip conditions.

3 years agoRename project-remove-known-project to project-forget-project
Dmitry Gutov [Tue, 21 Sep 2021 13:07:39 +0000 (16:07 +0300)]
Rename project-remove-known-project to project-forget-project

* doc/emacs/maintaining.texi (Managing Projects): Ditto.

* etc/NEWS: Update accordingly.

* lisp/progmodes/project.el (project-forget-project):
Rename from 'project-remove-known-project', for consistency with
'project-remember-project' (discussed in bug#50297).

3 years agoConsistently test alist keys with equal in map.el
Basil L. Contovounesios [Tue, 14 Sep 2021 23:17:26 +0000 (00:17 +0100)]
Consistently test alist keys with equal in map.el

* etc/NEWS: Announce new default behavior of map-elt and map-delete
on alists.

* lisp/emacs-lisp/map.el: Bump to version 3.2.
(map-elt): Test alist keys with equal by default.  Betray a little
bit more information in the docstring on which functions are used
for which map types.  (Bug#47368)
(map-put): Update docstring accordingly.
(map--plist-delete): Consistently test plist keys with eq.
(map-delete): Consistently test alist keys with equal.

* test/lisp/emacs-lisp/map-tests.el (test-map-elt-testfn): Update
for new map-elt behavior.
(test-map-put!-alist, test-map-delete-alist): New tests.

3 years agoRemove the emoji script overrides for U+2xxx codepoints
Robert Pluim [Tue, 21 Sep 2021 11:50:41 +0000 (13:50 +0200)]
Remove the emoji script overrides for U+2xxx codepoints

* admin/unidata/blocks.awk: Remove the overrides for U+261D, U+26F9,
U+270C..U+270D, and U+2764.  They don't belong in the emoji script.

3 years agoFix the UK flag sequence composition regexp
Robert Pluim [Tue, 21 Sep 2021 11:50:10 +0000 (13:50 +0200)]
Fix the UK flag sequence composition regexp

* admin/unidata/emoji-zwj.awk: Fix the regexp for UK flags.
Thanks to Mattias Engdegård <mattiase@acm.org> and his magic
regexp checker.

3 years agoSilence byte-compiler warning for network-stream-tests.el
Robert Pluim [Tue, 21 Sep 2021 08:20:10 +0000 (10:20 +0200)]
Silence byte-compiler warning for network-stream-tests.el

The api specifically requires a symbol here, so we can't just replace
nowait with nil.

* test/lisp/net/network-stream-tests.el
(open-gnutls-stream-old-api-wait): Add explicit value for nowait
to silence byte-compiler warning due to Bug#47080.

3 years agoAvoid double argument evaluation in vc-call macro
Basil L. Contovounesios [Sun, 19 Sep 2021 21:39:20 +0000 (22:39 +0100)]
Avoid double argument evaluation in vc-call macro

* lisp/vc/vc-hooks.el (vc-call): Ensure second argument is evaluated
only once (bug#50690).
* etc/NEWS (Change Logs and VC): Announce this change in behavior.

3 years agoMake syntax-ppss more accurate for Python triple quotes (bug#49518)
João Távora [Sun, 19 Sep 2021 10:42:20 +0000 (11:42 +0100)]
Make syntax-ppss more accurate for Python triple quotes (bug#49518)

By putting delimiter syntax on the last character of Python
triple-quoted strings, this makes syntax-ppss be more accurate.

Previously:

    emacs -Q something.py
    type two single quotes
    M-: (nth 3 (syntax-ppss))
    notice how the return value says you're outside a string, correctly
    type another quote
    M-: (nth 3 (syntax-ppss))
    notice how the return value says you're inside a string, correctly
    backspace the quote just entered
    M-: (nth 3 (syntax-ppss))
    notice how the return value says you're inside a string, incorrectly

With this patch the last step is corrected.  This helps things like
electric-pair-mode.  Also, the test
python-syntax-after-python-backspace now passes, again.

* lisp/progmodes/python.el (python-syntax-stringify): Put
delimiter syntax in "inner" of the surrouding triple quotes.

* test/lisp/progmodes/python-tests.el
(python-syntax-after-python-backspace): Passes again.

3 years agoExpand and improve electric-pair-mode and Python testing (bug#49518)
João Távora [Sun, 19 Sep 2021 16:08:41 +0000 (17:08 +0100)]
Expand and improve electric-pair-mode and Python testing (bug#49518)

In python-tests.el, the triple-quote pairing tests are passing
incorrectly, i.e. the auto-pairing functionality they purport to guard
isn't really working for users trying it interactively.  Added a new
failing test, soon to be fixed.

In electric-tests.el, added tests for Python, too.

* test/lisp/electric-tests.el (define-electric-pair-test): Also run
main tests for python-mode.  (pair-some-quotes-skip-others): Test
another slightly different pairing.

* test/lisp/progmodes/python-tests.el
(python-triple-double-quote-pairing): Rename from
python-triple-quote-pairing.
(python-triple-single-quote-pairing): New test.

3 years agoAdd docstring for 'electric-pair-p-s-i-f' and minor refactor
João Távora [Sun, 19 Sep 2021 15:16:31 +0000 (16:16 +0100)]
Add docstring for 'electric-pair-p-s-i-f' and minor refactor

Extract the "open newline between pairs behaviour" into its own
function, electric-pair-open-newline-between-pairs-psif.

* lisp/elec-pair.el (electric-pair-post-self-insert-function): Add
docstring.
(electric-pair-open-newline-between-pairs-psif): New function.
(electric-pair-mode): Add/remove electric-pair-open-newline-between-pairs-psif

3 years agoSpeed up test/lisp/electric-tests.el when run interactively
João Távora [Sun, 19 Sep 2021 09:25:36 +0000 (10:25 +0100)]
Speed up test/lisp/electric-tests.el when run interactively

'blink-paren-function' and its timers could sometimes interfere with
the tests and slow them down significantly.

* test/lisp/electric-tests.el (call-with-saved-electric-modes):
Bind blink-paren-function to nil.

3 years ago; Minor checkdoc fixes in url/*.el
Stefan Kangas [Tue, 21 Sep 2021 09:14:14 +0000 (11:14 +0200)]
; Minor checkdoc fixes in url/*.el

3 years agoFix whitespace-report window creation
Lars Ingebrigtsen [Tue, 21 Sep 2021 05:29:55 +0000 (07:29 +0200)]
Fix whitespace-report window creation

* lisp/whitespace.el (whitespace-display-window): Avoid creating
many buffers if called many times (bug#50716).

3 years agoUse `special-mode' for whitespace-report
Lars Ingebrigtsen [Tue, 21 Sep 2021 05:23:09 +0000 (07:23 +0200)]
Use `special-mode' for whitespace-report

* lisp/whitespace.el (whitespace-report-region): Use
`special-mode' instead of `fundamental-mode' (bug#50715).

3 years agoInhibit warning in mm-inline-wash-with-file from previous change
Lars Ingebrigtsen [Tue, 21 Sep 2021 05:16:37 +0000 (07:16 +0200)]
Inhibit warning in mm-inline-wash-with-file from previous change

* lisp/gnus/mm-view.el (mm-inline-wash-with-file): Inhibit warning
about previous lexical fixup.

3 years agoFix problems with non-ASCII non-encoded PGP names
Lars Ingebrigtsen [Tue, 21 Sep 2021 05:12:35 +0000 (07:12 +0200)]
Fix problems with non-ASCII non-encoded PGP names

* lisp/epg.el (epg-signature-to-string): User IDs may be
non-encoded, non-ASCII (bug#50706).

3 years agoFix typo in tex--prettify-symbols-alist
Lars Ingebrigtsen [Tue, 21 Sep 2021 04:48:44 +0000 (06:48 +0200)]
Fix typo in tex--prettify-symbols-alist

* lisp/textmodes/tex-mode.el (tex--prettify-symbols-alist): Fix
varsigma typo (bug#50710).

3 years agoFix lexical fallout in mm-inline-wash-with-file
Lars Ingebrigtsen [Tue, 21 Sep 2021 04:43:16 +0000 (06:43 +0200)]
Fix lexical fallout in mm-inline-wash-with-file

* lisp/gnus/mm-view.el (mm-inline-wash-with-file): This is only
called from the `links' handler, and it passes in `file' expecting
that to be dynamically bound.  Which is a very, very confusing
interface, but make that work again, anyway.

3 years agoMake dired-compress-file query for a directory to uncompress to
Michalis V [Tue, 21 Sep 2021 04:30:58 +0000 (06:30 +0200)]
Make dired-compress-file query for a directory to uncompress to

* lisp/dired-aux.el (dired-compress-file-suffixes): Specify the
directory in the tar targets.
(dired-uncompress-file): New function (bug#47058).  This asks what
directory to uncompress to.
(dired-compress-file): Use it.

3 years agoClear netrc cache in auth-source test
Lars Ingebrigtsen [Tue, 21 Sep 2021 03:59:11 +0000 (05:59 +0200)]
Clear netrc cache in auth-source test

* test/lisp/auth-source-tests.el
(auth-source-test-netrc-create-secret): Clear the netrc cache, too.

3 years agoOnly search netrc in the netrc tests
Lars Ingebrigtsen [Tue, 21 Sep 2021 03:28:40 +0000 (05:28 +0200)]
Only search netrc in the netrc tests

* test/lisp/auth-source-tests.el
(auth-source-test-netrc-create-secret): Only search netrc.

3 years agoRemove some last calls to Gnus group name encoding
Eric Abrahamsen [Tue, 21 Sep 2021 01:13:10 +0000 (18:13 -0700)]
Remove some last calls to Gnus group name encoding

This should have been part of cb12a84f2c

* lisp/gnus/gnus-msg.el (gnus-summary-resend-message-insert-gcc,
gnus-inews-do-gcc): Don't encode group names.

3 years ago; Mention it in NEWS too
Dmitry Gutov [Tue, 21 Sep 2021 01:01:21 +0000 (04:01 +0300)]
; Mention it in NEWS too

3 years agoNew command: project-find-dir
Dmitry Gutov [Tue, 21 Sep 2021 00:34:00 +0000 (03:34 +0300)]
New command: project-find-dir

* doc/emacs/maintaining.texi (Project File Commands):
Mention the new command and update the bindings information.

* lisp/progmodes/project.el (project-find-dir):
New command (bug#43153).
(project-prefix-map): Use 'd' as its binding.
Move 'project-dired' to 'D'.
(project-switch-commands):
Replace 'project-dired' with 'project-find-dir'.

3 years agoSupport for Unicode emoji sequences
Robert Pluim [Mon, 20 Sep 2021 10:41:15 +0000 (12:41 +0200)]
Support for Unicode emoji sequences

This covers both sequences using Zero-Width-Joiner codepoints and
those without. Bug#39799, I hope.

* .gitignore: Add emoji-zwj.el
* admin/notes/unicode: Add emoji-zwj-sequences.txt and
emoji-sequences.txt references.  Describe how to test after updating
to a newer Unicode version.
* admin/unidata/Makefile.in (all): add emoji-zwj.el as a dependency.
(emoji-zwj.el): Add target plus rules for building.
(gen-clean): Add emoji-zwj.el.
* admin/unidata/README: Add emoji-zwj-sequences.txt and
emoji-sequences.txt references.
* admin/unidata/blocks.awk: Force emoji script to be used for certain
codepoints that are used by the Unicode sequences.
* admin/unidata/emoji-sequences.txt: New file.
* admin/unidata/emoji-zwj-sequences.txt: New file.
* admin/unidata/emoji-zwj.awk: New file.  Derives
composition-function-table rules from emoji-zwj-sequences.txt, plus
hardcodes some derived manually from emoji-sequences.txt.
* etc/NEWS: Announce change.
* lisp/international/characters.el: Load the generated emoji-zwj.el
* src/Makefile.in (emoji-zwj): New target.
(temacs): Add emoji-zwj as a dependency.

3 years agoNo longer raise error when http authentication failed
Jonas Bernoulli [Thu, 16 Sep 2021 18:24:30 +0000 (20:24 +0200)]
No longer raise error when http authentication failed

* lisp/url/url-http.el (url-http-handle-authentication): Return t
instead of raising an error, instructing the caller to invoke the
request specific error handler (bug#50511).

3 years ago; admin/unidata/README: remove mistaken addition of local file
Glenn Morris [Mon, 20 Sep 2021 17:47:02 +0000 (10:47 -0700)]
; admin/unidata/README: remove mistaken addition of local file

3 years agoAdd a note about testing out-of-tree builds
Robert Pluim [Mon, 20 Sep 2021 15:18:40 +0000 (17:18 +0200)]
Add a note about testing out-of-tree builds

* CONTRIBUTE: Ask contributors to test out-of-tree builds when
making build system changes.

3 years agoBase emoji script membership on Emoji_Presentation
Robert Pluim [Sun, 19 Sep 2021 19:07:36 +0000 (21:07 +0200)]
Base emoji script membership on Emoji_Presentation

The Emoji property describes which codepoints can be displayed as
emoji, but Emoji_Presentation governs which are displayed as emoji by
default.

* admin/notes/unicode: Adjust check-emoji-coverage to look in the
Emoji_Presentation sections of emoji-data.txt
* admin/unidata/blocks.awk: Assign emoji script using the
Emoji_Presentation section.

3 years ago; admin/unidata/README: sort entries
Glenn Morris [Mon, 20 Sep 2021 15:43:10 +0000 (08:43 -0700)]
; admin/unidata/README: sort entries

3 years ago; admin/unidata/README: update file dates
Glenn Morris [Mon, 20 Sep 2021 15:41:56 +0000 (08:41 -0700)]
; admin/unidata/README: update file dates

I'm not sure how useful it is to keep this information in the README.
Also, add missing EastAsianWidth.txt.

3 years agoFix VC repo URL detection in bug-reference-mode
Basil L. Contovounesios [Sun, 19 Sep 2021 20:13:17 +0000 (21:13 +0100)]
Fix VC repo URL detection in bug-reference-mode

* lisp/progmodes/bug-reference.el (bug-reference-try-setup-from-vc):
Pass file or directory name in question as the first argument to the
backend's repository-url implementation (bug#50689).  Use when-let
and seq-some to flatten nested conditionals.

3 years agoFix assertion violation with zero-width :box attributes
Eli Zaretskii [Mon, 20 Sep 2021 12:22:07 +0000 (15:22 +0300)]
Fix assertion violation with zero-width :box attributes

* src/xfaces.c (merge_face_ref): Don't allow :box attribute with a
zero value.  (Bug#50699)

3 years agoRemove superfluous skip in auth-source-tests.el
Michael Albinus [Mon, 20 Sep 2021 08:21:30 +0000 (10:21 +0200)]
Remove superfluous skip in auth-source-tests.el

* test/lisp/auth-source-tests.el
(auth-source-test-netrc-create-secret): Remove superfluous skip.

3 years agoDump with `lexical-binding` bound to nil
Mattias Engdegård [Sun, 19 Sep 2021 18:07:11 +0000 (20:07 +0200)]
Dump with `lexical-binding` bound to nil

* lisp/loadup.el (dump-mode): Temporarily bind `lexical-binding` to
nil while dumping.  Otherwise, it will be t in Emacs by default
and that is not our intention (yet).

3 years ago; * src/keyboard.c (Frecursive_edit): Minor fixes of the doc string.
Eli Zaretskii [Mon, 20 Sep 2021 07:50:53 +0000 (10:50 +0300)]
; * src/keyboard.c (Frecursive_edit): Minor fixes of the doc string.

3 years ago* lisp/tab-bar.el (tab-bar-new-tab): Add optional arg 'from-number'.
Juri Linkov [Mon, 20 Sep 2021 07:20:32 +0000 (10:20 +0300)]
* lisp/tab-bar.el (tab-bar-new-tab): Add optional arg 'from-number'.

(tab-bar-mouse-context-menu): Use tab-number as an arg for
'tab-bar-duplicate-tab'.
(tab-bar-duplicate-tab): Add optional arg 'from-number'.

3 years agoAdd support for url-retrieve-synchronously to eww-retrieve-command (bug#50680)
Juri Linkov [Mon, 20 Sep 2021 07:16:09 +0000 (10:16 +0300)]
Add support for url-retrieve-synchronously to eww-retrieve-command (bug#50680)

* doc/misc/eww.texi (Advanced): Mention url-retrieve-synchronously
for eww-retrieve-command.

* lisp/net/eww.el (eww-retrieve-command): Add choice 'sync' for
url-retrieve-synchronously.
(eww-retrieve): Use value 'sync' for url-retrieve-synchronously.
(eww-isearch-next-buffer): Let-bind eww-retrieve-command to 'sync'.

3 years agoImprove documentation of exiting recursive editing
Miha Rihtaršič [Mon, 20 Sep 2021 06:00:08 +0000 (08:00 +0200)]
Improve documentation of exiting recursive editing

* doc/lispref/commands.texi (Recursive Editing): Mention what happens
when throwing a string or any other value to 'exit.
* src/keyboard.c (Frecursive_edit): Document throwing a function
to 'exit (bug#49700).

3 years agoRefactor minibuffer aborting
Miha Rihtaršič [Mon, 20 Sep 2021 05:59:29 +0000 (07:59 +0200)]
Refactor minibuffer aborting

* lisp/minibuffer.el (minibuffer-quit-recursive-edit): New optional
argument to specify how many levels of recursion to quit.

* src/eval.c (internal_catch): Remove special handling of 'exit
tag (bug#49700).
* src/minibuf.c (Fabort_minibuffers): Use
minibuffer-quit-recursive-edit to quit multiple levels of minibuffer
recursion.

3 years agoFix dolist-with-progress-reporter behaviour
Philip Kaludercic [Mon, 12 Jul 2021 15:26:43 +0000 (17:26 +0200)]
Fix dolist-with-progress-reporter behaviour

* subr.el (dolist-with-progress-reporter): Use the length of list
  argument as maximal value the reporter with reach

3 years agoRevert "Flag checkdoc-symbol-words as a :safe variable"
Stefan Kangas [Sun, 19 Sep 2021 20:28:46 +0000 (22:28 +0200)]
Revert "Flag checkdoc-symbol-words as a :safe variable"

There was no need for this change, as this variable was already marked
as :safe.

This reverts commit 222a7a1a8afdf6921e5981133c605c2d695e9281.

3 years agoAvoid segfaults due to 'bug-reference-mode'
Eli Zaretskii [Sun, 19 Sep 2021 18:39:18 +0000 (21:39 +0300)]
Avoid segfaults due to 'bug-reference-mode'

* src/xdisp.c (handle_fontified_prop): Set the frame's
inhibit_clear_image_cache flag around calls to
'fontification-functions', to avoid Lisp triggering the clearing
of image and/or face caches behind redisplay's back.  (Big#50571)

3 years agoFix blocks.awk wrt to Emoji characters
Eli Zaretskii [Sun, 19 Sep 2021 18:33:02 +0000 (21:33 +0300)]
Fix blocks.awk wrt to Emoji characters

* admin/unidata/blocks.awk: Fix emoji-data.txt processing for
older Awks.

3 years agoDo not save empty passwords in auth-source-search
Michael Albinus [Sun, 19 Sep 2021 17:59:05 +0000 (19:59 +0200)]
Do not save empty passwords in auth-source-search

* lisp/auth-source.el (auth-source-netrc-create)
(auth-source-secrets-create): Set :save-function only for non
empty passwords.

* lisp/net/tramp.el (tramp-read-passwd): Don't save empty passwords.

* test/lisp/auth-source-tests.el
(auth-source-test-secrets-create-secret): Adapt test.
(auth-source-test-netrc-create-secret): New test.

3 years agoBe explicit about missing sections in eshell manual
Stefan Kangas [Sun, 19 Sep 2021 16:33:35 +0000 (18:33 +0200)]
Be explicit about missing sections in eshell manual

* doc/misc/eshell.texi (Writing a module, Module testing)
(Directory handling, Key rebinding, Smart scrolling)
(Terminal emulation): Explicitly say that these sections remain to
be written.  (Bug#49306)

3 years ago* lisp/progmodes/elisp-mode.el (elisp-context-menu): Improve menu items.
Juri Linkov [Sun, 19 Sep 2021 16:21:27 +0000 (19:21 +0300)]
* lisp/progmodes/elisp-mode.el (elisp-context-menu): Improve menu items.

3 years agoFix build with native compilation on Cygwin
Ken Brown [Sat, 18 Sep 2021 18:03:41 +0000 (14:03 -0400)]
Fix build with native compilation on Cygwin

* src/Makefile.in (emacs$(EXEEXT)) [CYGWIN]: Rebase the *.eln
files after they are all created, to avoid fork problems later
in the build.  (Bug#50666)

3 years ago; Fix typo in package.el doc string
王滋涵 Zephyr Wang [Sun, 19 Sep 2021 15:39:26 +0000 (17:39 +0200)]
; Fix typo in package.el doc string

* lisp/emacs-lisp/package.el (package-archive-column-width): Fix
copy-paste in doc string (bug#50678).

Copyright-paperwork-exempt: yes

3 years agoClarify docstring of pcase-exhaustive
Stefan Kangas [Sun, 19 Sep 2021 15:25:39 +0000 (17:25 +0200)]
Clarify docstring of pcase-exhaustive

* lisp/emacs-lisp/pcase.el (pcase-exhaustive): Clarify docstring
by contrasting with pcase.  (Bug#44166)

3 years agoMake two unused variables obsolete
Stefan Kangas [Sun, 19 Sep 2021 14:55:10 +0000 (16:55 +0200)]
Make two unused variables obsolete

* lisp/progmodes/idlw-help.el (idlwave-help-directory)
(idlwave-help-use-hh): Make unused variables obsolete.

3 years ago; Delete a spurious comment
Stefan Kangas [Sun, 19 Sep 2021 14:54:38 +0000 (16:54 +0200)]
; Delete a spurious comment

3 years ago; Stylistic docfixes in net/*.el found by checkdoc
Stefan Kangas [Sun, 19 Sep 2021 14:48:35 +0000 (16:48 +0200)]
; Stylistic docfixes in net/*.el found by checkdoc

3 years ago* etc/NEWS: Add section on recent checkdoc changes.
Stefan Kangas [Sun, 19 Sep 2021 14:28:29 +0000 (16:28 +0200)]
* etc/NEWS: Add section on recent checkdoc changes.

3 years agoInitialise unread buffer
Mattias Engdegård [Sun, 19 Sep 2021 14:16:34 +0000 (16:16 +0200)]
Initialise unread buffer

The reader has an extra 1-char unread buffer that was incorrectly
initialised to 0, which means that the first character read would
always be NUL.  As this is often the code that looks for the
lexical-binding cookie, the first loaded source module would be
treated as dynamically bound.  During bootstrapping this is loadup.el
and so its local variables got dumped into the global environment.

* src/lread.c (unread_char): Initialise to empty.
(Fload): Initialise here too just in case.

3 years agocheckdoc: Verify format of yes-or-no-p and format-message
Stefan Kangas [Sun, 19 Sep 2021 12:09:20 +0000 (14:09 +0200)]
checkdoc: Verify format of yes-or-no-p and format-message

* lisp/emacs-lisp/checkdoc.el (checkdoc-message-text-next-string):
Check also for "yes-or-no-p" and "format-message".  Convert regexps to
use rx.

3 years ago; Some more docfixes for erc/*.el
Stefan Kangas [Sun, 19 Sep 2021 11:21:56 +0000 (13:21 +0200)]
; Some more docfixes for erc/*.el

3 years ago; Stylistic docfixes in language/*.el found by checkdoc
Stefan Kangas [Sun, 19 Sep 2021 11:15:41 +0000 (13:15 +0200)]
; Stylistic docfixes in language/*.el found by checkdoc

3 years agoFlag checkdoc-symbol-words as a :safe variable
Stefan Kangas [Sun, 19 Sep 2021 11:13:56 +0000 (13:13 +0200)]
Flag checkdoc-symbol-words as a :safe variable

* lisp/emacs-lisp/checkdoc.el (checkdoc-symbol-words): Flag as a safe
file local variable.

3 years ago; Stylistic docfixes in erc/*.el found by checkdoc
Stefan Kangas [Sun, 19 Sep 2021 10:59:01 +0000 (12:59 +0200)]
; Stylistic docfixes in erc/*.el found by checkdoc

3 years ago; Stylistic docfixes in eshell/*.el found by checkdoc
Stefan Kangas [Sun, 19 Sep 2021 10:45:56 +0000 (12:45 +0200)]
; Stylistic docfixes in eshell/*.el found by checkdoc

3 years ago; * lisp/subr.el (setq-local): Fix docstring quotes (bug#50646)
Phil Sainty [Sun, 19 Sep 2021 10:25:37 +0000 (22:25 +1200)]
; * lisp/subr.el (setq-local): Fix docstring quotes (bug#50646)

3 years agoTeach Mail mode to request Disposition Notifications
Eli Zaretskii [Sun, 19 Sep 2021 08:44:22 +0000 (11:44 +0300)]
Teach Mail mode to request Disposition Notifications

* lisp/mail/sendmail.el (mail-insert-disposition-notification-to):
New function.
(mail-mode-map): Add it to key bindings and menu bar.

3 years ago; * lisp/cedet/semantic/symref/grep.el: Use grep quoting, not egrep.
Mattias Engdegård [Sun, 19 Sep 2021 07:29:33 +0000 (09:29 +0200)]
; * lisp/cedet/semantic/symref/grep.el: Use grep quoting, not egrep.

Kindly noticed by Dmitry Gutov.

3 years agoAdd new '/opme' and '/deopme' convenience ERC commands
Amin Bandali [Sun, 19 Sep 2021 03:29:44 +0000 (23:29 -0400)]
Add new '/opme' and '/deopme' convenience ERC commands

* lisp/erc/erc.el (erc-cmd-OPME, erc-cmd-DEOPME): Add convenience
commands for setting and unsetting the operator status on the current
nick in the current channel.  'erc-cmd-OPME' relies on ChanServ for
obtaining the operator status (see doc string for more details).

* etc/NEWS: Announce the addition of the commands.

3 years agoRevert previous mode-line-modes change to unbreak bootstrap
Stefan Kangas [Sat, 18 Sep 2021 23:08:30 +0000 (01:08 +0200)]
Revert previous mode-line-modes change to unbreak bootstrap

* lisp/bindings.el (mode-line-modes): Revert previous change to
unbreak bootstrap.

3 years agoViper doc string fix
Lars Ingebrigtsen [Sat, 18 Sep 2021 22:14:42 +0000 (00:14 +0200)]
Viper doc string fix

* lisp/emulation/viper-keym.el (viper-want-ctl-h-help): Fold
over-long first line.

3 years agoFix viper-util compilation warning
Lars Ingebrigtsen [Sat, 18 Sep 2021 22:13:21 +0000 (00:13 +0200)]
Fix viper-util compilation warning

* lisp/emulation/viper-util.el (cl-lib): Require for cl-subseq.

3 years ago; Stylistic docfixes in emulation/*.el found by checkdoc
Stefan Kangas [Sat, 18 Sep 2021 21:39:01 +0000 (23:39 +0200)]
; Stylistic docfixes in emulation/*.el found by checkdoc

3 years ago* etc/NEWS: Shorten entry on move to Libera.Chat.
Stefan Kangas [Sat, 18 Sep 2021 17:09:35 +0000 (19:09 +0200)]
* etc/NEWS: Shorten entry on move to Libera.Chat.

3 years agoUse command substitution in checkdoc-recursive-edit
Stefan Kangas [Sat, 18 Sep 2021 13:38:36 +0000 (15:38 +0200)]
Use command substitution in checkdoc-recursive-edit

* lisp/emacs-lisp/checkdoc.el (checkdoc-recursive-edit): Use command
substitution.
(checkdoc--help-buffer): New variable.  Use it instead of hard-coded
string.

3 years agoUse command substitution for exit-recursive-edit
Stefan Kangas [Sat, 18 Sep 2021 12:54:04 +0000 (14:54 +0200)]
Use command substitution for exit-recursive-edit

* lisp/bindings.el (mode-line-modes):
* lisp/emacs-lisp/checkdoc.el (checkdoc-recursive-edit): Use command
substitution for 'exit-recursive-edit'.

3 years ago* lisp/subr.el (string-replace): Add dashes to arg names (bug#50644)
Juri Linkov [Sat, 18 Sep 2021 18:42:17 +0000 (21:42 +0300)]
* lisp/subr.el (string-replace): Add dashes to arg names (bug#50644)

* lisp/net/tramp-compat.el (tramp-compat-string-replace): Idem.
* doc/lispref/searching.texi (Search and Replace): Idem.

3 years ago; Clarify recently added documentation
Eli Zaretskii [Sat, 18 Sep 2021 18:04:07 +0000 (21:04 +0300)]
; Clarify recently added documentation

* etc/NEWS:
* doc/emacs/help.texi (Name Help): Clarify documentation of
'help-enable-symbol-autoload'.

3 years agoAdd new help-enable-symbol-autoload user option
Arthur Miller [Sat, 18 Sep 2021 17:51:47 +0000 (19:51 +0200)]
Add new help-enable-symbol-autoload user option

* lisp/help-fns.el (help-fns--analyze-function): Use it.
* lisp/help-fns.el (help-enable-symbol-autoload): New user option.
* doc/emacs/help.texi (Name Help): Document it.

3 years agoMention xref-quit-and-pop-marker-stack in the manual
Lars Ingebrigtsen [Sat, 18 Sep 2021 16:32:22 +0000 (18:32 +0200)]
Mention xref-quit-and-pop-marker-stack in the manual

* doc/emacs/maintaining.texi (Xref Commands): Mention
xref-quit-and-pop-marker-stack in the manual.

3 years agoDo some xwidget NEWS markup (and adjust doc string)
Lars Ingebrigtsen [Sat, 18 Sep 2021 16:18:02 +0000 (18:18 +0200)]
Do some xwidget NEWS markup (and adjust doc string)

* lisp/xwidget.el (xwidget-webkit-bookmark-make-record): Mention
`xwidget-webkit-bookmark-jump-new-session' in the doc string.

3 years agoMake argument optional in pulse-momentary-highlight-one-line
Lars Ingebrigtsen [Sat, 18 Sep 2021 14:12:56 +0000 (16:12 +0200)]
Make argument optional in pulse-momentary-highlight-one-line

* lisp/cedet/pulse.el (pulse-momentary-highlight-one-line): Make
POINT optional (bug#50642) so that the function can be used more
easily from some hook functions.

3 years ago; * lisp/so-long.el (so-long-mode): Use `so-long-mode-line-active' face
Phil Sainty [Thu, 9 Sep 2021 07:53:25 +0000 (19:53 +1200)]
; * lisp/so-long.el (so-long-mode): Use `so-long-mode-line-active' face

3 years ago; * lisp/so-long.el: Documentation
Phil Sainty [Sat, 18 Sep 2021 02:16:13 +0000 (14:16 +1200)]
; * lisp/so-long.el: Documentation

Clarify things which are only relevant to 'global-so-long-mode', and
not when the 'so-long' command, or one of its actions, is invoked
directly.

Use the new "customization group" hyperlink syntax.

Only quote 'so-long' as a symbol when it specifically refers to the
command (or will otherwise generate a hyperlink which is appropriate
to the context).  When referring to the library more generally, leave
it unquoted.

Changes from commit 63f419f1339cbd0a7d1e64586854a4f01b3f80d1 are
reverted or improved.

3 years agoUse the newest gcc installed by Macports
Dan Ports [Sat, 18 Sep 2021 14:04:38 +0000 (16:04 +0200)]
Use the newest gcc installed by Macports

* configure.ac: There may be more than one gcc version installed
in Macports (bug#50649).  Use the newest.

Copyright-paperwork-exempt: yes

3 years agoFontify Libtool macros in autoconf-mode
Basil L. Contovounesios [Sat, 18 Sep 2021 10:49:07 +0000 (11:49 +0100)]
Fontify Libtool macros in autoconf-mode

* lisp/progmodes/autoconf.el (autoconf-font-lock-keywords): Apply
font-lock-keyword-face also to Libtool's LT_* macros (bug#50659).

3 years agoImprove doc strings of a recent commit
Eli Zaretskii [Sat, 18 Sep 2021 11:56:55 +0000 (14:56 +0300)]
Improve doc strings of a recent commit

* lisp/emacs-lisp/generator.el (iter-defun):
* lisp/emacs-lisp/comp.el (comp-clean-up-stale-eln):
* lisp/emacs-lisp/bytecomp.el (byte-compile-lapcode):
* lisp/emacs-lisp/autoload.el (autoload-insert-section-header):
Include description of arguments in the doc string's first line.

3 years agoRegexp-quote literal symbols when grepping
Mattias Engdegård [Sat, 18 Sep 2021 11:39:09 +0000 (13:39 +0200)]
Regexp-quote literal symbols when grepping

`xref-find-references` was unable to find symbols like
`backquote-list*-macro`.

* lisp/cedet/semantic/symref/grep.el
(semantic-symref-grep--quote-extended): New function.
(semantic-symref-perform-search): Call it.

3 years ago; More stylistic docfixes in emacs-lisp/*.el found by checkdoc
Stefan Kangas [Sat, 18 Sep 2021 11:12:41 +0000 (13:12 +0200)]
; More stylistic docfixes in emacs-lisp/*.el found by checkdoc

3 years agoFix performance degradation in commands that describe key bindings
Eli Zaretskii [Sat, 18 Sep 2021 10:23:48 +0000 (13:23 +0300)]
Fix performance degradation in commands that describe key bindings

* src/keymap.c (syms_of_keymap)
<describe-bindings-check-shadowing-in-ranges>: New variable.
(describe_vector): Check shadowing of consecutive keys only if
'describe-bindings-check-shadowing-in-ranges' is non-nil.  Remove
redundant second loop when VECTOR is a char-table.  Improve
comments.  Patch by Stefan Kangas <stefan@marxist.se>.  (Bug#45379)

* test/src/keymap-tests.el
(help--describe-vector/bug-9293-one-shadowed-in-range): Adapt the
test case for the new variable.

3 years ago* lisp/emacs-lisp/checkdoc.el: Doc fix; mention flymake.
Stefan Kangas [Sat, 18 Sep 2021 09:24:22 +0000 (11:24 +0200)]
* lisp/emacs-lisp/checkdoc.el: Doc fix; mention flymake.

3 years agoDo interactive mode tagging for checkdoc.el
Stefan Kangas [Sat, 18 Sep 2021 09:21:32 +0000 (11:21 +0200)]
Do interactive mode tagging for checkdoc.el

3 years agocheckdoc: Only look for commonly used modifier keys
Stefan Kangas [Sat, 18 Sep 2021 08:39:35 +0000 (10:39 +0200)]
checkdoc: Only look for commonly used modifier keys

* lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine):
Search for the modifier key "s-", but not the modifier key "A-".
The latter is very uncommon and leads to false positives.

3 years agoSkip "fast" tests on emba CI
Michael Albinus [Sat, 18 Sep 2021 08:23:32 +0000 (10:23 +0200)]
Skip "fast" tests on emba CI

* test/infra/gitlab-ci.yml (stages): Comment "fast" stage out.
(test-fast-inotify): Comment out.

3 years ago; * lisp/loadup.el: Fix "Eager macro-expansion error" on w32.
Eli Zaretskii [Sat, 18 Sep 2021 07:56:05 +0000 (10:56 +0300)]
; * lisp/loadup.el: Fix "Eager macro-expansion error" on w32.

3 years agoAdd indent declaration to emerge-defvar-local
Stefan Kangas [Sat, 18 Sep 2021 07:40:29 +0000 (09:40 +0200)]
Add indent declaration to emerge-defvar-local

* lisp/vc/emerge.el (emerge-defvar-local): Add indent declaration
for docstring.  Fix wrongly indented callers.