]> git.eshelyaron.com Git - emacs.git/log
emacs.git
3 years agoDocument shorthands in the Elisp manual section on Symbols
João Távora [Thu, 23 Sep 2021 16:45:24 +0000 (17:45 +0100)]
Document shorthands in the Elisp manual section on Symbols

* doc/lispref/symbols.texi (Symbol Components): Mentione "Shorthands".
(Creating Symbols): Mention shorthands.  Correct references to Common
Lisp.
(Shorthands): New section.

* etc/NEWS (Shorthands): New entry.

3 years agoAdd #_ reader macro to escape shorthand renaming
João Távora [Wed, 22 Sep 2021 22:53:15 +0000 (23:53 +0100)]
Add #_ reader macro to escape shorthand renaming

* src/lread.c (read1): Add skip_shorthand variable.  Add a '#_'
case.  If skip_shorthand call oblookup instead of
oblookup_considering_shorthand.

* test/lisp/progmodes/elisp-mode-tests.el
(elisp-shorthand-escape): New test.

* test/lisp/progmodes/elisp-resources/simple-shorthand-test.el
(#_f-test4---): New fixture function.

3 years agoConsider shorthands in Elisp's elisp-completion-at-point
João Távora [Tue, 21 Sep 2021 21:20:17 +0000 (22:20 +0100)]
Consider shorthands in Elisp's elisp-completion-at-point

Instead of referencing obarray directly, that function has to consider
a collection of completions which includes the shorthand versions of
some of the symbols.  That collection changes from buffer to buffer,
depending on the choice of elisp-shorthands.

To make this process efficient, and avoid needless recalculation of
the above collection, a new obarray-specific cache was invented.  The
Elisp variable obarray-cache is immediately nullified if something
touches the obarray.

* lisp/progmodes/elisp-mode.el : New helper.
(elisp-completion-at-point): Use new helpers.
(elisp--completion-local-symbols)
(elisp--fboundp-considering-shorthands)
(elisp--bboundp-considering-shorthands): New helpers

* src/lread.c (intern_driver): Nullify Qobarray_cache.
(syms_of_lread): Add Qobarray_cache.

* test/lisp/progmodes/elisp-mode-tests.el
(elisp-shorthand-completion-at-point): New test.

* test/lisp/progmodes/elisp-resources/simple-shorthand-test.el
(f-test-complete-me): New fixture.

3 years agoRework Elisp shorthands to only allow only prefix substitution
João Távora [Wed, 23 Dec 2020 19:57:27 +0000 (19:57 +0000)]
Rework Elisp shorthands to only allow only prefix substitution

This simplification in requirements makes for more complex C code but
that code is much less wasteful in Lisp strings than the previous
implementation.

* src/lread.c (read1): Rework.
(Fintern): Rework.
(Fintern_soft): Rework.
(Funintern): Rework.
(oblookup_considering_shorthand): Rewrite.

* test/lisp/progmodes/elisp-mode-tests.el (elisp-shorthand-read-buffer)
(elisp-shorthand-read-from-string): Use new format of
elisp-shorthands.

* test/lisp/progmodes/elisp-resources/simple-shorthand-test.el (f-test)
(f-test2, f-test3): Use new form of elisp-shorthands.

3 years agoMove most of the shorthand implementation to C code
João Távora [Sat, 19 Sep 2020 21:16:38 +0000 (22:16 +0100)]
Move most of the shorthand implementation to C code

It passes the tests designed for the previous Elisp implementation.

Likely, this isn't the final form of the implementation.  For one, the
reader is much slower and allocates a Lisp string for every atom read,
regardless if its already interned or not.  This has the potential to
be catastrophic in terms of GC.

Also rename the main variable to elisp-shorthands, from the
repetitive shorthand-shorthands.

For some reason, I had to put 'hack-elisp-shorthands' and
'load-with-shorthands-and-code-conversion', the new source-file
loading functions, in lisp/international/mule.el.

Otherwise, lisp/loadup.el wouldn't see them, for some reason that I
didn't investigate.  This should probably be fixed.

* lisp/shorthand.el: Remove.

* test/lisp/shorthand-tests.el: Remove.

* src/lread.c:
(read1, Fintern, Fintern_soft, Funintern): Use
oblookup_considering_shorthand.
(oblookup_considering_shorthand): New helper.
(syms_of_lread): Declare elisp-shorthands.

* lisp/progmodes/elisp-mode.el (elisp-shorthands):
Put a safe-local-variable spec.

* test/lisp/progmodes/elisp-mode-tests.el (elisp-shorthand-read-buffer)
(elisp-shorthand-read-from-string)
(elisp-shorthand-byte-compile-a-file)
(elisp-shorthand-load-a-file): New tests.

* test/lisp/progmodes/elisp-resources/simple-shorthand-test.el: New file

* lisp/loadup.el (load-source-file-function): Set to
load-with-shorthands-and-code-conversion.

* lisp/international/mule.el (hack-elisp-shorthands): Move here.
(load-with-shorthands-and-code-conversion): And here.

3 years agoFirst Elisp version of lisp/shorthand.el, failing some tests
João Távora [Wed, 26 Aug 2020 20:29:15 +0000 (21:29 +0100)]
First Elisp version of lisp/shorthand.el, failing some tests

* lisp/shorthand.el: New file

* test/lisp/shorthand-tests.el: New file

3 years agoAdd 'doc-string' declaration to defcalcmodevar
Stefan Kangas [Sun, 26 Sep 2021 18:56:36 +0000 (20:56 +0200)]
Add 'doc-string' declaration to defcalcmodevar

* lisp/calc/calc.el (defcalcmodevar): Add 'doc-string' declaration.

3 years agoMove two incorrectly named test files
Stefan Kangas [Sun, 26 Sep 2021 18:34:34 +0000 (20:34 +0200)]
Move two incorrectly named test files

* test/lisp/emacs-lisp/tabulated-list-test.el: Move from here...
* test/lisp/emacs-lisp/tabulated-list-tests.el: ...to here.
* test/lisp/url/url-handlers-test.el: Move from here...
* test/lisp/url/url-handlers-tests.el: ...to here.

3 years agocheckdoc: Don't add "Commentary" header to test files
Stefan Kangas [Sun, 26 Sep 2021 18:20:20 +0000 (20:20 +0200)]
checkdoc: Don't add "Commentary" header to test files

* lisp/emacs-lisp/checkdoc.el (checkdoc-file-comments-engine):
Don't add "Commentary:" header if it looks like a test file.

3 years agoAdd glyphless-char-display-control for Variation Selectors
Robert Pluim [Fri, 24 Sep 2021 12:13:24 +0000 (14:13 +0200)]
Add glyphless-char-display-control for Variation Selectors

* lisp/international/characters.el (update-glyphless-char-display):
(glyphless-char-display-control): Add control knob for U+FE00 through
U+FE0F, defaulting to 'thin-space'.
* doc/lispref/display.texi (Glyphless Chars): Document it.

3 years agoExplicitly make the rest of erc-compat.el obsolete
Stefan Kangas [Sun, 26 Sep 2021 16:14:27 +0000 (18:14 +0200)]
Explicitly make the rest of erc-compat.el obsolete

* lisp/obsolete/erc-compat.el (erc-decode-coding-string)
(erc-encode-coding-string, erc-set-write-file-functions)
(erc-emacs-build-time, erc-replace-match-subexpression-in-string)
(erc-member-if, erc-delete-if, erc-remove-if-not, erc-subseq):
Explicitly declare obsolete.
(erc-define-minor-mode): Make into obsolete function alias for
'define-minor-mode'.
(erc-user-emacs-directory): Make into obsolete variable alias for
'user-emacs-directory'.

3 years ago; Minor stylistic checkdoc fixes in test/**/*.el
Stefan Kangas [Sat, 25 Sep 2021 23:53:56 +0000 (01:53 +0200)]
; Minor stylistic checkdoc fixes in test/**/*.el

3 years ago; Clarify and simplify time-stamp comments
Stephen Gildea [Sun, 26 Sep 2021 15:23:29 +0000 (08:23 -0700)]
; Clarify and simplify time-stamp comments

* lisp/time-stamp.el (time-stamp-end, time-stamp-string-preprocess,
time-stamp-formatz-from-parsed-options): Simplify doc.
* test/lisp/time-stamp-tests.el (time-stamp-custom-pattern):
Refactor to set limit-number only once.

3 years ago; Fix some recent fixes to doc strings
Eli Zaretskii [Sun, 26 Sep 2021 13:50:11 +0000 (16:50 +0300)]
; Fix some recent fixes to doc strings

* lisp/whitespace.el (whitespace-empty-at-bob-regexp):
* lisp/vc/vc-dir.el (vc-dir-child-files-and-states):
* lisp/vc/vc-annotate.el
(vc-annotate-show-changeset-diff-revision-at-line):
* lisp/vc/ediff.el (ediff-merge-with-ancestor-command):
* lisp/gnus/nnvirtual.el (nnvirtual-update-xref-header)
(nnvirtual-map-article):
* lisp/emulation/viper-init.el (viper-ESC-keyseq-timeout):
* lisp/emulation/viper-cmd.el
(viper-set-parsing-style-toggling-macro):
* lisp/cedet/data-debug.el (data-debug-insert-hash-table-button):
"The first line of a doc string must be a complete sentence."
Also, fix some awkward wording in doc strings while at that.

3 years agoAdd fast-path to ert--explain-string-equal
Stefan Kangas [Sun, 26 Sep 2021 13:29:20 +0000 (15:29 +0200)]
Add fast-path to ert--explain-string-equal

* lisp/emacs-lisp/ert.el (ert--explain-string-equal): Add fast-path to
avoid doing extra work.
Problem reported by Mattias Engdegård <mattiase@acm.org>.

3 years ago* test/infra/gitlab-ci.yml (variables): Set DOCKER_BUILDKIT.
Michael Albinus [Sun, 26 Sep 2021 13:28:17 +0000 (15:28 +0200)]
* test/infra/gitlab-ci.yml (variables): Set DOCKER_BUILDKIT.

3 years agoRename "Homepage" field to "Website" in package description
Stefan Kangas [Sun, 26 Sep 2021 12:32:58 +0000 (14:32 +0200)]
Rename "Homepage" field to "Website" in package description

* lisp/emacs-lisp/package.el (describe-package-1): Rename
"Homepage" field to "Website".

* test/lisp/emacs-lisp/package-tests.el
(package-test-describe-package)
(package-test-describe-installed-multi-file-package)
(package-test-describe-non-installed-package)
(package-test-describe-non-installed-multi-file-package): Update tests.

3 years agoPrefer https for other domains than gnu.org in package URL
Stefan Kangas [Sun, 26 Sep 2021 12:29:41 +0000 (14:29 +0200)]
Prefer https for other domains than gnu.org in package URL

* lisp/emacs-lisp/package.el (describe-package-1): Prefer https for
some other common domains in the package URL.

3 years agoAdd test for lm-website
Stefan Kangas [Sun, 26 Sep 2021 12:13:03 +0000 (14:13 +0200)]
Add test for lm-website

* lisp/emacs-lisp/lisp-mnt.el (lm-website): Use rx.
* test/lisp/emacs-lisp/lisp-mnt-tests.el
(lm--tests-lm-website): New test.

3 years agoRx documentation touch-ups (bug#46910)
Mattias Engdegård [Sun, 26 Sep 2021 12:36:02 +0000 (14:36 +0200)]
Rx documentation touch-ups (bug#46910)

* doc/lispref/searching.texi (Rx Constructs, Rx Functions):
Add clarifications and improve naming of arguments.  Add examples
illustrating the differences between `rx` and `rx-to-string`.

3 years agoWarn about overly long docstring in lambda
Stefan Kangas [Fri, 24 Sep 2021 17:10:46 +0000 (19:10 +0200)]
Warn about overly long docstring in lambda

* lisp/emacs-lisp/bytecomp.el
(byte-compile-docstring-length-warn): Warn about overly long
docstring in lambda.  (Bug#44858)

(byte-compile--wide-docstring-p): Improve comment.
* test/lisp/emacs-lisp/bytecomp-tests.el
("warn-wide-docstring-defun.el"): Update to test for the above new
warning.

3 years agoAvoid warning about long docstring lines in defcustom
Stefan Kangas [Fri, 24 Sep 2021 15:44:40 +0000 (17:44 +0200)]
Avoid warning about long docstring lines in defcustom

* lisp/custom.el (defcustom): Avoid warning about long docstring
lines.  This was caused by the value of the defcustom being treated as
docstring due to it being wrapped in a lambda.

3 years agoFill some auto-generated docstring lines
Stefan Kangas [Fri, 24 Sep 2021 15:47:35 +0000 (17:47 +0200)]
Fill some auto-generated docstring lines

* lisp/cedet/mode-local.el (define-mode-local-override):
* lisp/cedet/semantic/decorate/mode.el (define-semantic-decoration-style):
* lisp/cedet/semantic/idle.el (define-semantic-idle-service):
* lisp/emacs-lisp/derived.el (derived-mode-make-docstring):
* lisp/emacs-lisp/eieio.el (defclass): Fill auto-generated docstring
lines.

3 years agoAvoid false positives in bytecomp docstring width warning
Stefan Kangas [Fri, 24 Sep 2021 15:45:37 +0000 (17:45 +0200)]
Avoid false positives in bytecomp docstring width warning

* lisp/emacs-lisp/bytecomp.el (byte-compile--wide-docstring-p):
Ignore more function argument lists.
* test/lisp/emacs-lisp/bytecomp-tests.el
(bytecomp-tests-byte-compile--wide-docstring-p): New test.

3 years agoImprove filling of generated docstring lines
Stefan Kangas [Fri, 24 Sep 2021 15:47:43 +0000 (17:47 +0200)]
Improve filling of generated docstring lines

* lisp/subr.el (internal--fill-string-single-line): Improve filling to
use full width.  Fix bug where line was not wrapped correctly.

3 years ago; Adjust overly long docstrings to fit 80 characters
Stefan Kangas [Fri, 24 Sep 2021 12:46:56 +0000 (14:46 +0200)]
; Adjust overly long docstrings to fit 80 characters

3 years agoert: Add basic explainer for string-equal
Stefan Kangas [Sun, 26 Sep 2021 11:18:29 +0000 (13:18 +0200)]
ert: Add basic explainer for string-equal

* lisp/emacs-lisp/ert.el (ert--explain-string-equal): Add basic
explainer for 'string-equal' based on 'ert--explain-equal'.

3 years agoUnbreak ert tests
Stefan Kangas [Sun, 26 Sep 2021 11:17:38 +0000 (13:17 +0200)]
Unbreak ert tests

* test/lisp/emacs-lisp/tabulated-list-test.el (tabulated-list-print)
(tabulated-list-sort): Update tests for recent change.

3 years ago; More instrumentation in autorevert-tests.el
Michael Albinus [Sun, 26 Sep 2021 10:40:55 +0000 (12:40 +0200)]
; More instrumentation in autorevert-tests.el

3 years agoDoc fix: mode name in local variables needs no suffix
Stefan Kangas [Sun, 26 Sep 2021 09:28:36 +0000 (11:28 +0200)]
Doc fix: mode name in local variables needs no suffix

* doc/emacs/custom.texi (Specifying File Variables): Clarify that a
mode name does not need the "-mode" suffix.  (Bug#50801)

3 years agocheckdoc: Library footer must match package.el requirement
Stefan Kangas [Sun, 26 Sep 2021 00:02:52 +0000 (02:02 +0200)]
checkdoc: Library footer must match package.el requirement

* lisp/emacs-lisp/checkdoc.el (checkdoc-file-comments-engine):
Don't accept footer format unless it matches the requirement in
package.el.

3 years ago; Improve documentation of 'with-environment-variables'
Eli Zaretskii [Sun, 26 Sep 2021 09:11:56 +0000 (12:11 +0300)]
; Improve documentation of 'with-environment-variables'

* lisp/env.el (with-environment-variables):
* doc/lispref/os.texi (System Environment): Improve the
documentation of 'with-environment-variables'.

3 years agoAdapt Tramp's make-process for macOS.
Michael Albinus [Sun, 26 Sep 2021 08:32:15 +0000 (10:32 +0200)]
Adapt Tramp's make-process for macOS.

* lisp/net/tramp-sh.el (tramp-check-remote-uname): New defun.
(tramp-sh-handle-file-ownership-preserved-p)
(tramp-sh-handle-make-process, tramp-find-executable)
(tramp-find-shell, tramp-get-remote-stat): Use it.  (Bug#50748)

* test/lisp/net/tramp-tests.el (tramp-check-remote-uname): Declare.
(tramp-test29-start-file-process, tramp-test30-make-process):
Instrument for macOS.
(tramp--test-hpux-p): Adapt function.
(tramp--test-macos-p): New defun.

3 years agoExpand the ` doc string slightly
Lars Ingebrigtsen [Sun, 26 Sep 2021 06:47:08 +0000 (08:47 +0200)]
Expand the ` doc string slightly

* lisp/emacs-lisp/backquote.el (backquote): Note that ` is used
for other things in some macros (bug#25462).

3 years agoFix rendering non-ASCII text with links
Lars Ingebrigtsen [Sun, 26 Sep 2021 06:29:38 +0000 (08:29 +0200)]
Fix rendering non-ASCII text with links

* lisp/gnus/mm-view.el (mm-text-html-renderer-alist): Add a new
form for links.
(mm-links-remove-leading-blank): Make obsolete.
(mm-inline-wash-with-file):
(mm-inline-render-with-file): Make obsolete -- they were awkwardly
defined and only used with links.
(mm-inline-render-with-links): New function.

3 years agoAdd new macro with-environment-variables
Lars Ingebrigtsen [Sun, 26 Sep 2021 06:27:51 +0000 (08:27 +0200)]
Add new macro with-environment-variables

* doc/lispref/os.texi (System Environment): Document it.

* lisp/env.el (with-environment-variables): New macro.

3 years agoRevert "; Fix capitalization of F1..F12 keys in docs"
Stefan Kangas [Sat, 25 Sep 2021 20:49:47 +0000 (22:49 +0200)]
Revert "; Fix capitalization of F1..F12 keys in docs"

This reverts commit fe5b20410f68546821e6c87577d7f826167491dc.

This change was not correct; these are Lisp symbols that should be in
lower-case.  Problem reported by Mattias Engdegård <mattiase@acm.org>.

3 years ago; Bump seq version to 2.23
Stefan Kangas [Sat, 25 Sep 2021 19:44:44 +0000 (21:44 +0200)]
; Bump seq version to 2.23

3 years agoRevert part of previous doc fix
Stefan Kangas [Sat, 25 Sep 2021 19:25:58 +0000 (21:25 +0200)]
Revert part of previous doc fix

* lisp/emacs-lisp/derived.el (define-derived-mode): Revert part of
previous doc fix.  This change made the text confusing.  (Bug#17567)

3 years ago* lisp/tab-bar.el (tab-bar-new-tab-to): Use ignore-window-parameters.
Juri Linkov [Sat, 25 Sep 2021 19:24:48 +0000 (22:24 +0300)]
* lisp/tab-bar.el (tab-bar-new-tab-to): Use ignore-window-parameters.

Suggested by Adam Porter <adam@alphapapa.net> in
https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg01758.html

3 years ago* lisp/tab-line.el: Add modified-buffer face
Adam Porter [Fri, 24 Sep 2021 04:47:56 +0000 (04:47 +0000)]
* lisp/tab-line.el: Add modified-buffer face

(tab-line-tab-modified): New face.
(tab-line-tab-face-modified): New function.
(tab-line-tab-face-functions): Use new function.

* etc/NEWS: Update.

3 years ago; Fix capitalization of F1..F12 keys in docs
Stefan Kangas [Sat, 25 Sep 2021 18:51:13 +0000 (20:51 +0200)]
; Fix capitalization of F1..F12 keys in docs

* doc/emacs/custom.texi (Function Keys):
* doc/misc/edt.texi (Unix):
* doc/misc/idlwave.texi (Custom Expression Examination):
* doc/misc/viper.texi (Improved Search, Vi Macros): Fix
capitalization of F1..F12 keys.

3 years ago; * lisp/wid-edit.el (natnum): rectify tag string
Mattias Engdegård [Sat, 25 Sep 2021 18:27:28 +0000 (20:27 +0200)]
; * lisp/wid-edit.el (natnum): rectify tag string

3 years agoFix byte-compiler crash for legal dynamic-binding code
Mattias Engdegård [Sat, 25 Sep 2021 10:15:21 +0000 (12:15 +0200)]
Fix byte-compiler crash for legal dynamic-binding code

This should really be taken care of by a syntax normalisation step in
the frontend, but there is no such step for non-lexbind code yet.

* lisp/emacs-lisp/byte-opt.el (byte-optimize-letX): Tolerate bindingsa
without initialising expressions.
* test/lisp/emacs-lisp/bytecomp-tests.el (bytecomp-tests--test-cases):
Add test cases.

3 years ago; * doc/emacs/help.texi (Misc Help): @key{f1} -> @key{F1}
Mattias Engdegård [Sat, 25 Sep 2021 07:09:58 +0000 (09:09 +0200)]
; * doc/emacs/help.texi (Misc Help): @key{f1} -> @key{F1}

3 years agoConstant-propagate variables bound outside loops
Mattias Engdegård [Wed, 22 Sep 2021 09:03:30 +0000 (11:03 +0200)]
Constant-propagate variables bound outside loops

Previously, variables bound outside `while` loops were not substituted
inside even in the absense of mutation.  Add the necessary mutation
checking inside loops to allow propagation of values and aliased
variables.

* lisp/emacs-lisp/byte-opt.el
(byte-optimize--inhibit-outside-loop-constprop): New variable.
(byte-optimize-form-code-walker): First traverse each loop without
substitution to discover mutation, then without restrictions.
* test/lisp/emacs-lisp/bytecomp-tests.el (bytecomp-test-loop): New.
(bytecomp-tests--test-cases): Add test cases.

3 years ago; Remove various duplicated words
Mattias Engdegård [Fri, 24 Sep 2021 12:18:57 +0000 (14:18 +0200)]
; Remove various duplicated words

* doc/lispref/searching.texi (Extending Rx):
* doc/lispref/strings.texi (Creating Strings):
* doc/misc/modus-themes.org (Measure color contrast (DIY)):
* etc/NEWS:
* lisp/find-file.el (ff-find-other-file):
* lisp/gnus/gnus-group.el (gnus-group-suspend):
* lisp/progmodes/cc-langs.el (c-ml-string-any-closer-re):
* lisp/progmodes/flymake.el (flymake-list-only-diagnostics):
* lisp/progmodes/xref.el (xref--group-name-for-display):
* lisp/transient.el (transient-child, transient-files)
(transient-infix-value):
* src/alloc.c:
* src/regex-emacs.c (regex_compile):

Remove duplicate words in comments, documentation etc.

3 years agoUse ambient lexical-binding value in ert-deftest body (bug#50738)
Mattias Engdegård [Thu, 23 Sep 2021 12:02:21 +0000 (14:02 +0200)]
Use ambient lexical-binding value in ert-deftest body (bug#50738)

* lisp/emacs-lisp/ert.el (ert-deftest):
Evaluate the body of `ert-deftest` with the `lexical-binding` value of
the source file (or more precisely the value in force when the
definition is evaluated), which is what everyone expected, instead of
always using dynamic binding which is what they got until now.
* test/lisp/emacs-lisp/ert-tests.el
(ert-test-deftest-lexical-binding-t): New test.

3 years agoRenege on anonymous &rest (bug#50268, bug#50720)
Mattias Engdegård [Thu, 23 Sep 2021 10:43:41 +0000 (12:43 +0200)]
Renege on anonymous &rest (bug#50268, bug#50720)

Allowing &rest without a variable name following turned out not to be
very useful, and it never worked properly.  Disallow it.

* lisp/emacs-lisp/bytecomp.el (byte-compile-check-lambda-list):
* src/eval.c (funcall_lambda):
Signal error for &rest without variable name.
* doc/lispref/functions.texi (Argument List): Adjust manual.
* etc/NEWS (file): Announce.
* test/src/eval-tests.el (eval-tests--bugs-24912-and-24913):
Extend test, also checking with and without lexical binding.
(eval-tests-accept-empty-optional-rest): Reduce to...
(eval-tests-accept-empty-optional): ...this, again checking
with and without lexical binding.

3 years agoClarify define-derived-mode docstring
Stefan Kangas [Sat, 25 Sep 2021 16:59:37 +0000 (18:59 +0200)]
Clarify define-derived-mode docstring

* lisp/emacs-lisp/derived.el (define-derived-mode): Doc fixes;
correctly mention that the mode name is used in the mode line, clarify
argument types, and how the mode hook is named.  (Bug17567)

(derived-mode-hook-name, derived-mode-map-name)
(derived-mode-syntax-table-name, derived-mode-abbrev-table-name):
Clarify that argument is a symbol.

3 years ago; Fix typo in ert.texi
Michael Albinus [Sat, 25 Sep 2021 16:50:32 +0000 (18:50 +0200)]
; Fix typo in ert.texi

3 years agoAdd myself as rcirc maintainer
Philip Kaludercic [Sat, 25 Sep 2021 16:32:33 +0000 (18:32 +0200)]
Add myself as rcirc maintainer

3 years ago* rcirc.el (rcirc-sentinel): Use process-status
Philip Kaludercic [Sat, 25 Sep 2021 15:59:52 +0000 (17:59 +0200)]
* rcirc.el (rcirc-sentinel): Use process-status

3 years ago* rcirc.texi (Using rcirc with bouncers): Remove confusing sentence
Philip Kaludercic [Sat, 25 Sep 2021 14:49:26 +0000 (16:49 +0200)]
* rcirc.texi (Using rcirc with bouncers): Remove confusing sentence

3 years ago* rcirc.el (rcirc-reconnect): Use rcirc-reconnect-delay
Philip Kaludercic [Sat, 25 Sep 2021 14:27:12 +0000 (16:27 +0200)]
* rcirc.el (rcirc-reconnect): Use rcirc-reconnect-delay

3 years ago* rcirc.el (rcirc-reconnect): Set rcirc-joined
Philip Kaludercic [Sat, 25 Sep 2021 14:25:03 +0000 (16:25 +0200)]
* rcirc.el (rcirc-reconnect): Set rcirc-joined

3 years ago* lisp/isearch.el (isearch-forward-regexp): Doc fix. (Bug22483)
Stefan Kangas [Sat, 25 Sep 2021 16:07:24 +0000 (18:07 +0200)]
* lisp/isearch.el (isearch-forward-regexp): Doc fix.  (Bug22483)

3 years agoMerge branch 'master' of git.savannah.gnu.org:/srv/git/emacs
Eli Zaretskii [Sat, 25 Sep 2021 15:57:17 +0000 (18:57 +0300)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

3 years ago; Another minor improvement in ERT manual
Eli Zaretskii [Sat, 25 Sep 2021 15:56:02 +0000 (18:56 +0300)]
; Another minor improvement in ERT manual

* doc/misc/ert.texi (Running Tests Interactively): State the
function run by each key, per conventions.

3 years agoMinor clarification of define-minor-mode :keymap argument
Stefan Kangas [Sat, 25 Sep 2021 15:54:49 +0000 (17:54 +0200)]
Minor clarification of define-minor-mode :keymap argument

* lisp/emacs-lisp/easy-mmode.el (define-minor-mode): Minor doc fix;
clarify by saying that ":keymap" should be an "unquoted variable
name".  (Bug#25505)

3 years ago; * doc/misc/ert.texi (Running Tests Interactively): Fix markup.
Eli Zaretskii [Sat, 25 Sep 2021 15:46:33 +0000 (18:46 +0300)]
; * doc/misc/ert.texi (Running Tests Interactively): Fix markup.

3 years agoButtonize functions in curved quotes in ERC
Stefan Kangas [Sat, 25 Sep 2021 15:03:13 +0000 (17:03 +0200)]
Buttonize functions in curved quotes in ERC

* lisp/erc/erc-button.el (erc-button-alist): Buttonize Emacs
functions in curved quotes.  (Bug#49964)

3 years agoExtend and improve ERT manual section on running interactively
Stefan Kangas [Sat, 25 Sep 2021 14:55:04 +0000 (16:55 +0200)]
Extend and improve ERT manual section on running interactively

* doc/misc/ert.texi (Running Tests Interactively): Format commands in
a table, improve indexing, and add several missing
commands.  (Bug#41829)

3 years ago; * lisp/mh-e/mh-scan.el: re-order variables to be actually alphabetical
Stephen Gildea [Sat, 25 Sep 2021 14:18:50 +0000 (07:18 -0700)]
; * lisp/mh-e/mh-scan.el: re-order variables to be actually alphabetical

3 years agoUpdate mh-scan regexp to match mh-note-allowlisted
Stephen Gildea [Sat, 25 Sep 2021 14:07:52 +0000 (07:07 -0700)]
Update mh-scan regexp to match mh-note-allowlisted

lisp/mh-e/mh-scan.el (mh-scan-good-msg-regexp, mh-scan-cmd-note-width):
Update to match new value ("A") of mh-note-allowlisted.

3 years ago; Fix omission in recent CONTRIBUTE doc change.
Basil L. Contovounesios [Sat, 25 Sep 2021 13:41:24 +0000 (14:41 +0100)]
; Fix omission in recent CONTRIBUTE doc change.

3 years ago; More instrumentation in autorevert-tests.el
Michael Albinus [Sat, 25 Sep 2021 10:20:46 +0000 (12:20 +0200)]
; More instrumentation in autorevert-tests.el

3 years agoDocument the new paren-space indentation rule
Lars Ingebrigtsen [Sat, 25 Sep 2021 10:11:26 +0000 (12:11 +0200)]
Document the new paren-space indentation rule

* doc/emacs/programs.texi (Lisp Indent): Mention the new
paren-space indentation rule.

3 years agoSome NEWS tagging
Lars Ingebrigtsen [Sat, 25 Sep 2021 09:57:13 +0000 (11:57 +0200)]
Some NEWS tagging

3 years ago'xref-search-program'-related doc string fixes
Lars Ingebrigtsen [Sat, 25 Sep 2021 09:54:13 +0000 (11:54 +0200)]
'xref-search-program'-related doc string fixes

* lisp/progmodes/xref.el (xref-search-program): Mention what this
variable controls.
(xref-matches-in-files): Mention the variables that controls it.

3 years agoDocument the 'string' thingatpt target
Lars Ingebrigtsen [Sat, 25 Sep 2021 09:45:30 +0000 (11:45 +0200)]
Document the 'string' thingatpt target

* doc/lispref/text.texi (Buffer Contents): Mention the 'string'
target.

3 years agoFix cursor motion around some Emoji sequences
Eli Zaretskii [Sat, 25 Sep 2021 09:18:27 +0000 (12:18 +0300)]
Fix cursor motion around some Emoji sequences

* src/character.h: Add TAG_SPACE and CANCEL_TAG to known Unicode
characters values.
* src/composite.c (char_composable_p): Recognize TAG characters
relevant to Emoji as composable regardless of their General
Category.  (Bug#39799)

3 years ago; Improve text about 'CONTRIBUTE'
Eli Zaretskii [Sat, 25 Sep 2021 07:45:38 +0000 (10:45 +0300)]
; Improve text about 'CONTRIBUTE'

* doc/emacs/trouble.texi (Contributing): Expand the
recently-changed text.

3 years agoUse explicit man-page section in references
Eli Zaretskii [Sat, 25 Sep 2021 07:30:27 +0000 (10:30 +0300)]
Use explicit man-page section in references

* lisp/dired-aux.el (dired-do-chmod): Use explicit man-page
section in the doc string.  This avoids inadvertently showing
the wrong man page, when several identically-named pages are
possible in different sections.  E.g., there's also chmod(2).

3 years ago; Improve recently added documentation
Eli Zaretskii [Sat, 25 Sep 2021 06:59:53 +0000 (09:59 +0300)]
; Improve recently added documentation

* etc/NEWS:
* doc/lispref/tips.texi (Documentation Tips): Improve and clarify
recently-added documentation of man page references.

3 years agosave-some-buffers-root doc string change
Lars Ingebrigtsen [Sat, 25 Sep 2021 05:32:48 +0000 (07:32 +0200)]
save-some-buffers-root doc string change

* lisp/files.el (save-some-buffers-root): Improve doc string.

3 years agoDo some NEWS tagging
Lars Ingebrigtsen [Sat, 25 Sep 2021 05:24:39 +0000 (07:24 +0200)]
Do some NEWS tagging

3 years agoDocument redisplay-skip-fontification-on-input
Lars Ingebrigtsen [Sat, 25 Sep 2021 05:22:07 +0000 (07:22 +0200)]
Document redisplay-skip-fontification-on-input

* doc/emacs/display.texi (Scrolling): Mention
redisplay-skip-fontification-on-input.

3 years ago; * doc/misc/gnus.texi (Gnus Registry Setup): Fix missing parenthesis.
Bastien Guerry [Sat, 25 Sep 2021 05:15:31 +0000 (07:15 +0200)]
; * doc/misc/gnus.texi (Gnus Registry Setup): Fix missing parenthesis.

3 years ago; tramp-auto-save-directory: set mode atomically when creating
Stephen Gildea [Sat, 25 Sep 2021 04:59:17 +0000 (21:59 -0700)]
; tramp-auto-save-directory: set mode atomically when creating

* lisp/net/tramp.el (tramp-handle-make-auto-save-file-name):
Use with-file-modes around make-directory.  We can do this because
Tramp now honors default file modes in make-directory.

3 years agoAdd new user option ispell-help-timeout
Lars Ingebrigtsen [Sat, 25 Sep 2021 02:22:57 +0000 (04:22 +0200)]
Add new user option ispell-help-timeout

* lisp/textmodes/ispell.el (ispell-help-timeout): New user option.
(ispell-help): Use it.

3 years agoSet :type of suggest-key-bindings to natnum
Stefan Kangas [Fri, 24 Sep 2021 23:25:47 +0000 (01:25 +0200)]
Set :type of suggest-key-bindings to natnum

* lisp/simple.el (suggest-key-bindings): Set :type to
natnum.  (Bug#15809)

3 years agoNew :type natnum for defcustom
Stefan Kangas [Fri, 24 Sep 2021 23:15:49 +0000 (01:15 +0200)]
New :type natnum for defcustom

* lisp/wid-edit.el (natnum): New widget type.  (Bug#15809)
* doc/lispref/customize.texi (Simple Types): Document it.

3 years ago* lisp/dired-aux.el (dired-do-chmod): Simplify docstring.
Stefan Kangas [Sat, 25 Sep 2021 02:00:09 +0000 (04:00 +0200)]
* lisp/dired-aux.el (dired-do-chmod): Simplify docstring.

3 years agoAdd support for man page hyperlinks in doc strings
Stefan Kangas [Sat, 25 Sep 2021 01:03:34 +0000 (03:03 +0200)]
Add support for man page hyperlinks in doc strings

* lisp/help-mode.el (help-man): New button type.
(help-xref-man-regexp): New const.
(help-make-xrefs): Use them to allow making man page buttons.
* doc/lispref/tips.texi (Documentation Tips): Document the new
hyperlink type.  (Bug#39215)

3 years agoFix some instances in the Emacs manual with misleading prefix syntax
Lars Ingebrigtsen [Sat, 25 Sep 2021 01:59:42 +0000 (03:59 +0200)]
Fix some instances in the Emacs manual with misleading prefix syntax

* doc/emacs/msdos.texi (Windows Keyboard):
* doc/emacs/misc.texi (Editing Binary Files):
* doc/emacs/macos.texi (Mac / GNUstep Events):
* doc/emacs/kmacro.texi (Basic Keyboard Macro):
* doc/emacs/glossary.texi (Glossary):
* doc/emacs/fixit.texi (Spelling): Fix some instances where the
syntax seems to imply we're talking about a prefix key (bug#50792).

3 years agoMake 'C-u C-x v v' handle unregistered files.
Manuel Giraud [Sat, 25 Sep 2021 01:38:43 +0000 (03:38 +0200)]
Make 'C-u C-x v v' handle unregistered files.

* lisp/vc/vc.el (vc-next-action): Make 'C-u C-x v v' handle
unregistered files (bug#50602).

3 years agoMention the 'r' key in ask-user-about-supersession-help
Daniel Martín [Fri, 24 Sep 2021 13:32:01 +0000 (15:32 +0200)]
Mention the 'r' key in ask-user-about-supersession-help

* lisp/userlock.el (ask-user-about-supersession-help): Replace "n, and
then M-x revert-buffer" in the help message with "r", which does the
same thing.  (Bug#50780)

3 years agoIndent bodies of local function definitions properly in elisp-mode
akater [Sat, 25 Sep 2021 01:27:29 +0000 (03:27 +0200)]
Indent bodies of local function definitions properly in elisp-mode

* lisp/emacs-lisp/lisp-mode.el (lisp-indent-function): Check for
local defforms (`cl-flet' and `cl-labels').
(lisp--local-defform-body): New auxiliary function (bug#9622).

3 years agoClarify where to find CONTRIBUTE
Stefan Kangas [Sat, 25 Sep 2021 01:24:14 +0000 (03:24 +0200)]
Clarify where to find CONTRIBUTE

* doc/emacs/trouble.texi (Contributing): Say that CONTRIBUTE is
found in the development version of Emacs.  (Bug#37414)

3 years agoUse gzip to uncompess .xz files on MacOS
Lars Ingebrigtsen [Sat, 25 Sep 2021 01:05:27 +0000 (03:05 +0200)]
Use gzip to uncompess .xz files on MacOS

* lisp/jka-cmpr-hook.el (jka-compr-compression-info-list): Use
gzip to uncompess .xz files on MacOS (bug#29235).

3 years agoUse `temporary-file-directory' in `with-existing-directory'
Lars Ingebrigtsen [Sat, 25 Sep 2021 00:55:55 +0000 (02:55 +0200)]
Use `temporary-file-directory' in `with-existing-directory'

* lisp/subr.el (with-existing-directory): Use
`temporary-file-directory' over TMPDIR.

3 years agoFix alignment on font size change in tabulated-list-mode
Stefan Kangas [Fri, 24 Sep 2021 22:33:21 +0000 (00:33 +0200)]
Fix alignment on font size change in tabulated-list-mode

* lisp/emacs-lisp/tabulated-list.el (tabulated-list-print-col): Fix
bug where the columns didn't align correctly when using
'text-scale-mode' to decrease the font size.  (Bug#48639)

3 years agoDoc fix; cl-random is only pseudo-random
Stefan Kangas [Fri, 24 Sep 2021 22:05:55 +0000 (00:05 +0200)]
Doc fix; cl-random is only pseudo-random

* lisp/emacs-lisp/cl-extra.el (cl-random): Doc fix; say it's only
pseudo-random.

3 years agocheckdoc: Don't ask to disambiguate mode names
Stefan Kangas [Fri, 24 Sep 2021 21:42:08 +0000 (23:42 +0200)]
checkdoc: Don't ask to disambiguate mode names

* lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine):
Don't ask to disambiguate mode names.  (Bug#4110)

3 years agoFix recently introduced bug in checkdoc
Stefan Kangas [Fri, 24 Sep 2021 21:00:57 +0000 (23:00 +0200)]
Fix recently introduced bug in checkdoc

* lisp/emacs-lisp/checkdoc.el (checkdoc-in-abbreviation-p): Fix
recently introduced bug where some abbreviations weren't recognized.
* test/lisp/emacs-lisp/checkdoc-tests.el
(checkdoc-tests-in-abbrevation-p/basic-case): Extend test.

3 years agoRevert change to use seq-random-elt in Tramp test
Stefan Kangas [Fri, 24 Sep 2021 20:17:04 +0000 (22:17 +0200)]
Revert change to use seq-random-elt in Tramp test

* test/lisp/net/tramp-tests.el (tramp-test44-asynchronous-requests):
Revert change to use seq-random-elt, as Tramp needs to be compatible
with Emacs 25, and the function was only added in 26.1.

3 years agocheckdoc: Improve wide line warning to decrease false positives
Stefan Kangas [Fri, 24 Sep 2021 20:04:55 +0000 (22:04 +0200)]
checkdoc: Improve wide line warning to decrease false positives

* lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine):
Respect 'byte-compile-docstring-max-column' if it is set.  Allow the
first line to be three characters longer than the others to account
for indentation and the opening string character.

3 years agoUse command substitution instead of raw keys in more places
Stefan Kangas [Fri, 24 Sep 2021 18:59:32 +0000 (20:59 +0200)]
Use command substitution instead of raw keys in more places

* admin/authors.el (authors):
* lisp/abbrev.el (abbrev-suggest-show-report):
* lisp/calc/calc.el (calc-display-trail, calc):
* lisp/completion.el (completion-locate-db-error):
* lisp/dired-x.el (dired-extra-startup):
* lisp/emacs-lisp/package.el (package-install-selected-packages):
* lisp/emulation/viper.el (viper-mode):
* lisp/facemenu.el (list-colors-display):
* lisp/mail/emacsbug.el (report-emacs-bug-hook):
* lisp/mail/sendmail.el (mail):
* lisp/menu-bar.el (menu-bar-mode):
* lisp/org/org.el (org-revert-all-org-buffers):
* lisp/progmodes/antlr-mode.el (antlr-help-rules-intro)
(antlr-insert-makefile-rules):
* lisp/progmodes/gdb-mi.el (gdb--check-interpreter):
* lisp/progmodes/xscheme.el (xscheme-process-sentinel):
* lisp/ps-print.el (ps-font-info-database):
* lisp/recentf.el (recentf-edit-list, recentf-open-files):
* lisp/vc/ediff-util.el (ediff-suspend):
* lisp/vc/pcvs.el (cvs-mode):
* lisp/vc/vc-bzr.el (vc-bzr-dir-extra-headers): Use command
substitution.

3 years agoPrefer seq-random-elt to nth+random
Stefan Kangas [Fri, 24 Sep 2021 17:41:03 +0000 (19:41 +0200)]
Prefer seq-random-elt to nth+random

* lisp/emacs-lisp/seq.el (seq-random-elt): Autoload.
* lisp/avoid.el (mouse-avoidance-random-shape):
* lisp/epa-ks.el (epa-ks--query-url):
* lisp/erc/erc-networks.el (erc-server-select):
* lisp/gnus/gnus-fun.el (gnus--random-face-with-type)
(gnus-fun-ppm-change-string):
* lisp/net/soap-inspect.el (soap-sample-value-for-xs-simple-type):
* lisp/obsolete/landmark.el (landmark-random-move):
* lisp/play/mpuz.el (mpuz-build-random-perm):
* lisp/play/zone.el (zone-pgm-stress):
* lisp/vc/add-log.el (add-change-log-entry):
* test/lisp/net/tramp-tests.el
(tramp-test44-asynchronous-requests): Prefer seq-random-elt to
nth+random.