]> git.eshelyaron.com Git - emacs.git/log
emacs.git
5 years agoMake Tramp compatible to recent progress-reporter-update
Michael Albinus [Sat, 15 Jun 2019 09:38:13 +0000 (11:38 +0200)]
Make Tramp compatible to recent progress-reporter-update

* lisp/net/tramp-compat.el (tramp-compat-progress-reporter-update):
New defalias.

* lisp/net/tramp.el (tramp-progress-reporter-update): Add optional SUFFIX.

5 years agoSome changes in process output read of Tramp
Michael Albinus [Sat, 15 Jun 2019 09:33:16 +0000 (11:33 +0200)]
Some changes in process output read of Tramp

* lisp/net/tramp.el (tramp-handle-file-notify-rm-watch):
Read pending output.

* test/lisp/net/tramp-tests.el (tramp-test31-interrupt-process):
Use a timeout when reading process output.

5 years agoTag remote autorevert tests as unstable
Michael Albinus [Sat, 15 Jun 2019 09:08:05 +0000 (11:08 +0200)]
Tag remote autorevert tests as unstable

* test/lisp/autorevert-tests.el (auto-revert--timeout):
Derive value from `auto-revert-interval'.
(auto-revert--deftest-remote): Tag it as `:unstable'.
(auto-revert-test05-global-notify, auto-revert-test06-write-file):
Suppress final newline.  Use `auto-revert--timeout'.

5 years agoRemove Lucid Emacs support from bookmark.el
Stefan Kangas [Wed, 12 Jun 2019 08:36:10 +0000 (10:36 +0200)]
Remove Lucid Emacs support from bookmark.el

* lisp/bookmark.el: Remove Lucid Emacs support.
(Bug#36179)

5 years agoImprove documentation of hash-code functions
Eli Zaretskii [Sat, 15 Jun 2019 08:16:49 +0000 (11:16 +0300)]
Improve documentation of hash-code functions

* src/fns.c (Fsxhash_eq, Fsxhash_eql, Fsxhash_equal):
* doc/lispref/hash.texi (Defining Hash): Warn against assuming
that sxhash returns consistent results.

5 years ago* configure.ac: Lower required cairo version to 1.8.0.
YAMAMOTO Mitsuharu [Sat, 15 Jun 2019 03:46:30 +0000 (12:46 +0900)]
* configure.ac: Lower required cairo version to 1.8.0.

5 years agoRemove non-Xdbe double-buffering code on cairo
YAMAMOTO Mitsuharu [Sat, 15 Jun 2019 03:44:56 +0000 (12:44 +0900)]
Remove non-Xdbe double-buffering code on cairo

* src/xterm.c (x_begin_cr_clip, x_update_end) [USE_CAIRO]: Don't do
handcrafted double-buffering with image surface.

5 years agoRework x_scroll_run on cairo
YAMAMOTO Mitsuharu [Sat, 15 Jun 2019 03:36:26 +0000 (12:36 +0900)]
Rework x_scroll_run on cairo

* src/xterm.c (x_scroll_run) [USE_CAIRO]: Use FRAME_CR_CONTEXT or surface type
for conditions to call XCopyArea rather than FRAME_X_DOUBLE_BUFFERED_P.
Set compositing operator to CAIRO_OPERATOR_SOURCE when copying image.

5 years agoRevert "Silence okuri-nasi count-up messaging during compilation"
Lars Ingebrigtsen [Fri, 14 Jun 2019 18:59:31 +0000 (20:59 +0200)]
Revert "Silence okuri-nasi count-up messaging during compilation"

This takes long enough on some systems that the messages are useful.

This reverts commit 1d2e4d22c922f94d6f4b75a5ead18cbc679c5dfe.

5 years agoFix problem in remote file notification
Michael Albinus [Fri, 14 Jun 2019 17:45:00 +0000 (19:45 +0200)]
Fix problem in remote file notification

* lisp/net/tramp-sh.el (tramp-sh-gio-monitor-process-filter)
(tramp-sh-gvfs-monitor-dir-process-filter)
(tramp-sh-inotifywait-process-filter): Do not kill the process.
Let `file-notify-rm-watch' do the job.

* test/lisp/filenotify-tests.el (file-notify-test03-events)
(file-notify-test05-file-validity)
(file-notify-test09-watched-file-in-watched-dir): Do not
special-case remote files.

5 years agoSilence okuri-nasi count-up messaging during compilation
Lars Ingebrigtsen [Fri, 14 Jun 2019 15:14:49 +0000 (17:14 +0200)]
Silence okuri-nasi count-up messaging during compilation

* lisp/international/ja-dic-cnv.el (skkdic-set-okuri-nasi): Remove
messaging while compilation to make compilation more regular.

5 years agoRevert "srecode/srt-mode compilation fix"
Lars Ingebrigtsen [Fri, 14 Jun 2019 15:03:59 +0000 (17:03 +0200)]
Revert "srecode/srt-mode compilation fix"

This led to a recursive require.

This reverts commit 9fac0e70e3f5b7d0b12b77cac50078e01f68ee70.

5 years agoFix previous object-print/cl-print-object changes
Lars Ingebrigtsen [Fri, 14 Jun 2019 14:57:35 +0000 (16:57 +0200)]
Fix previous object-print/cl-print-object changes

* lisp/cedet/srecode/insert.el
(srecode-insert-variable-secondname-handler):
* lisp/cedet/semantic/decorate/include.el
(semantic-decoration-fileless-include-describe):
(semantic-decoration-all-include-summary):
* lisp/cedet/semantic/db-find.el (semanticdb-find-log-activity):
* lisp/cedet/semantic/bovine/c.el
(semantic-c-describe-environment):
* lisp/cedet/semantic/analyze/debug.el
(semantic-analyzer-debug-insert-include-summary): Fix previous
object-print/cl-print-object changes that were nonsensical.

5 years agoAvoid using registerv-make in senator.el
Lars Ingebrigtsen [Fri, 14 Jun 2019 14:51:27 +0000 (16:51 +0200)]
Avoid using registerv-make in senator.el

* lisp/cedet/semantic/senator.el (senator-register): New class.
(register-val-jump-to, register-val-describe)
(register-val-insert): New methods.
(senator-copy-tag-to-register): Use this instead of the deprecated
registerv-make function.

5 years agoanalyze/debug compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:57:34 +0000 (15:57 +0200)]
analyze/debug compilation fix

* lisp/cedet/semantic/analyze/debug.el (pulse): Require to avoid
byte compilation warning.

5 years agosemantic/lex-spp compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:54:50 +0000 (15:54 +0200)]
semantic/lex-spp compilation fix

* lisp/cedet/semantic/lex-spp.el
(semantic-lex-spp-analyzer-push-tokens-for-symbol): Use new name
for `semantic-lex-spp-anlyzer-do-replace'.

5 years agoUse cl-typep instead of obsolete predicate functions throughout cedet
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:47:54 +0000 (15:47 +0200)]
Use cl-typep instead of obsolete predicate functions throughout cedet

* lisp/cedet/srecode/dictionary.el (srecode-create-dictionary):
(srecode-dictionary-add-entries):
(srecode-compound-toString):
(srecode-dump):
* lisp/cedet/srecode/compile.el (srecode-dump-code-list):
* lisp/cedet/semantic/util.el (semantic-something-to-tag-table):
* lisp/cedet/semantic/db-typecache.el (semanticdb-typecache-length):
* lisp/cedet/semantic/db-ref.el (semanticdb-check-references):
* lisp/cedet/semantic/db-find.el
(semanticdb-find-incomplete-cache-entries-p):
(semanticdb-find-translate-path-includes-default):
(semanticdb-find-results-p):
(semanticdb-find-result-with-nil-p):
* lisp/cedet/semantic/analyze/complete.el
(semantic-analyze-possible-completions): Use cl-typep instead of
functions like `srecode-dictionary-compound-value-child-p' etc.

5 years agosrecode/srt-mode compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:36:17 +0000 (15:36 +0200)]
srecode/srt-mode compilation fix

* lisp/cedet/srecode/srt-mode.el (srecode/insert): Require to
avoid compilation warning about unknown slot.  Remove function
declarations that point to that file.

5 years agosrecode/find compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:34:00 +0000 (15:34 +0200)]
srecode/find compilation fix

* lisp/cedet/srecode/find.el (srecode/compile): Require to
avoid compilation warning about unknown slot.  Remove function
declarations that point to that file.

5 years agosrecode/dictionary compilation warning fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:32:33 +0000 (15:32 +0200)]
srecode/dictionary compilation warning fix

* lisp/cedet/srecode/dictionary.el (srecode/fields): Require to
avoid compilation warning about unknown slot.  Remove function
declarations that point to that file.

5 years agosrecode/dictionary compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:31:03 +0000 (15:31 +0200)]
srecode/dictionary compilation fix

* lisp/cedet/srecode/ctxt.el (srecode/dictionary): Require to
avoid compilation warning about unknown slot.  Remove function
declarations that point to that file.

5 years agosrecode-inserter-prin-example compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:29:17 +0000 (15:29 +0200)]
srecode-inserter-prin-example compilation fix

* lisp/cedet/srecode/insert.el (srecode-inserter-prin-example):
Move prin1 example to file that defines the structure it prints.

5 years agoMove functions from semantic.el to analyze.el to avoid warnings
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:15:09 +0000 (15:15 +0200)]
Move functions from semantic.el to analyze.el to avoid warnings

* lisp/cedet/semantic.el (semantic-analyze-completion-at-point-function)
(semantic-analyze-notc-completion-at-point-function)
(semantic-analyze-nolongprefix-completion-at-point-function): Add
autoloads for the moved functions.

* lisp/cedet/semantic/analyze.el
(semantic-analyze-completion-at-point-function)
(semantic-analyze-notc-completion-at-point-function)
(semantic-analyze-nolongprefix-completion-at-point-function): Move
here from semantic.el to avoid getting compilation warnings about
unknown slot `bounds'.

5 years agoAdjust erc functions after previous erc-pre-send-function change
Lars Ingebrigtsen [Fri, 14 Jun 2019 12:56:23 +0000 (14:56 +0200)]
Adjust erc functions after previous erc-pre-send-function change

5 years agoAdjust erc functions after previous erc-pre-send-function change
Lars Ingebrigtsen [Fri, 14 Jun 2019 12:56:04 +0000 (14:56 +0200)]
Adjust erc functions after previous erc-pre-send-function change

* lisp/erc/erc-goodies.el (noncommands): Use
erc-pre-send-functions instead of the hook.
(erc-send-distinguish-noncommands): Adjust function to new interface.

* lisp/erc/erc-ring.el (ring): Ditto.
(erc-add-to-input-ring): Ditto.

* lisp/erc/erc.el (erc-send-this): Really make obsolete.
(erc-pre-send-functions): Change to a list of functions to allow
erc-goodies and erc-ring to work as before.

5 years agoUnobsolete string-to-multibyte
Lars Ingebrigtsen [Fri, 14 Jun 2019 12:37:29 +0000 (14:37 +0200)]
Unobsolete string-to-multibyte

* lisp/subr.el: Un-obsolete string-to-multibyte, because it's a
useful function.  string-to-unibyte has already been un-obsoleted.

5 years agoUse CLOS-style accessors in oref/oset
Lars Ingebrigtsen [Thu, 13 Jun 2019 16:01:42 +0000 (18:01 +0200)]
Use CLOS-style accessors in oref/oset

* lisp/cedet/srecode/texi.el (srecode-semantic-handle-:texitag):
* lisp/cedet/srecode/table.el (srecode-mode-table-new):
(srecode-dump):
* lisp/cedet/srecode/srt-mode.el (srecode-parse-this-macro):
(semantic-analyze-possible-completions):
* lisp/cedet/srecode/semantic.el (srecode-compound-toString):
(srecode-semantic-apply-tag-to-dict-default):
* lisp/cedet/srecode/mode.el (srecode-minor-mode-templates-menu):
(srecode-edit):
* lisp/cedet/srecode/insert.el (srecode-insert-method):
(srecode-inserter-apply-state):
(srecode-insert-ask-default):
(srecode-insert-method-ask):
(srecode-insert-method-field):
(srecode-insert-method-helper):
(srecode-parse-input):
(srecode-match-end):
(srecode-insert-include-lookup):
(srecode-insert-method):
* lisp/cedet/srecode/find.el (srecode-template-table-in-project-p):
(srecode-template-get-table):
(srecode-template-get-table-for-binding):
(srecode-all-template-hash):
* lisp/cedet/srecode/extract.el (srecode-inserter-extract):
(srecode-inserter-extract):
* lisp/cedet/srecode/el.el (srecode-semantic-apply-tag-to-dict):
* lisp/cedet/srecode/dictionary.el (initialize-instance):
(srecode-dictionary-add-template-table):
(srecode-compound-toString):
* lisp/cedet/srecode/cpp.el (srecode-semantic-apply-tag-to-dict):
* lisp/cedet/srecode/compile.el (srecode-compile-template-table):
(srecode-dump):
* lisp/cedet/srecode/args.el (srecode-semantic-handle-:project):
* lisp/cedet/semantic/texi.el (semantic-analyze-possible-completions):
* lisp/cedet/semantic/symref/list.el (semantic-symref-results-dump):
(semantic-symref-list-create-macro-on-open-hit):
(semantic-symref-list-rename-open-hits):
(semantic-symref-list-map-open-hits):
* lisp/cedet/semantic/symref/idutils.el
(semantic-symref-perform-search):
(semantic-symref-parse-tool-output-one-line):
* lisp/cedet/semantic/symref/global.el (semantic-symref-perform-search):
(semantic-symref-parse-tool-output-one-line):
* lisp/cedet/semantic/symref/cscope.el (semantic-symref-perform-search):
(semantic-symref-parse-tool-output-one-line):
* lisp/cedet/semantic/mru-bookmark.el
(semantic-mrub-ring-to-assoc-list):
* lisp/cedet/semantic/grammar.el
(semantic-analyze-possible-completions):
* lisp/cedet/semantic/decorate/include.el
(semantic-decoration-include-describe):
* lisp/cedet/semantic/debug.el (semantic-debug-highlight-lexical-token):
(semantic-debug-highlight-rule):
* lisp/cedet/semantic/db-typecache.el
(semanticdb-typecache-for-database):
* lisp/cedet/semantic/complete.el
(semantic-collector-calculate-completions-raw):
* lisp/cedet/semantic/bovine/make.el
(semantic-analyze-possible-completions):
* lisp/cedet/semantic/analyze/refs.el (semantic-analyze-refs-impl):
(semantic-analyze-refs-proto):
* lisp/cedet/semantic/analyze/debug.el
(semantic-analyzer-debug-describe-scope):
* lisp/cedet/semantic/analyze.el (semantic-analyze-interesting-tag):
(semantic-analyze-interesting-tag):
(semantic-analyze-pulse):
* lisp/cedet/ede/util.el (ede-update-version):
* lisp/cedet/ede/shell.el (ede-shell-run-something):
* lisp/cedet/ede/project-am.el (project-am-load-makefile):
(project-rescan):
(project-am-macro):
(ede-buffer-mine):
(project-compile-target-command):
(project-am-package-info):
* lisp/cedet/ede/files.el (ede--project-inode):
(ede-directory-get-open-project):
(ede-directory-get-toplevel-open-project):
(ede-find-subproject-for-directory):
(ede-toplevel-project):
* lisp/cedet/ede/cpp-root.el (initialize-instance):
(project-compile-project):
(project-compile-target):
* lisp/cedet/ede/config.el (ede-config-get-configuration):
(project-debug-target):
(project-run-target):
(project-compile-project):
(ede-preprocessor-map):
(ede-java-classpath):
* lisp/cedet/ede/base.el (ede-normalize-file/directory): Use
CLOS-style oref/oset accessors instead of eieio-style :colon
accessors.  This avoids compilation warnings and is allegedly
faster.

5 years agoObsolete erc-send-pre-hook and add new erc-pre-send-function
Lars Ingebrigtsen [Fri, 14 Jun 2019 12:05:24 +0000 (14:05 +0200)]
Obsolete erc-send-pre-hook and add new erc-pre-send-function

* lisp/erc/erc.el (erc-send-pre-hook): Make obsolete.
(erc-send-input): Ditto.
(erc-pre-send-function): New function.
(erc-send-input): Use the new function, and silence byte
compilation warning about the dynamic variable `str' used by the
now-obsolete hook.

5 years agoFix compilation warning in rmailmm
Lars Ingebrigtsen [Fri, 14 Jun 2019 11:30:13 +0000 (13:30 +0200)]
Fix compilation warning in rmailmm

* lisp/mail/rmailmm.el (rmail-mime-insert-bulk): Remove apparently
superfluous call to string-as-unibyte -- the buffer should be
unibyte already at this point.

5 years agoAvoid compilation warning in byte-run
Lars Ingebrigtsen [Fri, 14 Jun 2019 11:23:11 +0000 (13:23 +0200)]
Avoid compilation warning in byte-run

* lisp/emacs-lisp/byte-run.el (macro-declaration-function): Avoid
compilation warning by not using `symbol-function'.

5 years ago* lisp/gnus/message.el: Fix NNTP sending, broken by e51adfbdb7
Stefan Monnier [Fri, 14 Jun 2019 06:51:07 +0000 (02:51 -0400)]
* lisp/gnus/message.el: Fix NNTP sending, broken by e51adfbdb7

(message-check-news-header-syntax): `message--check-continuation-headers`
signals an error instead of returning nil on error.

5 years agoStop a tramp test leaving a file behind
Glenn Morris [Fri, 14 Jun 2019 00:24:41 +0000 (20:24 -0400)]
Stop a tramp test leaving a file behind

* test/lisp/net/tramp-tests.el
(tramp-test10-write-region-file-precious-flag):
Avoid leaving a backup file after we are done.

5 years ago* lisp/widget.el (define-widget-keywords): Use `declare`.
Stefan Monnier [Thu, 13 Jun 2019 21:42:58 +0000 (17:42 -0400)]
* lisp/widget.el (define-widget-keywords): Use `declare`.

5 years ago* lisp/progmodes/ps-mode.el (ps-mode-octal-region): Simplify.
Stefan Monnier [Thu, 13 Jun 2019 21:40:32 +0000 (17:40 -0400)]
* lisp/progmodes/ps-mode.el (ps-mode-octal-region): Simplify.

5 years agoFix typo in object-print cleanup
Lars Ingebrigtsen [Thu, 13 Jun 2019 15:42:21 +0000 (17:42 +0200)]
Fix typo in object-print cleanup

* lisp/cedet/srecode/insert.el
(srecode-insert-variable-secondname-handler): Fix typo in
object-print cleanup.

5 years agoRemove outdated FIXME
Lars Ingebrigtsen [Thu, 13 Jun 2019 15:19:32 +0000 (17:19 +0200)]
Remove outdated FIXME

* lisp/emacs-lisp/eieio-core.el (eieio--slot-name-index): Remove
comment about issuing a byte compilation warning about accessing
slots via :initarg -- it was implemented a few months later.

5 years agosemantic/senator.el byte compilation fix
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:58:58 +0000 (16:58 +0200)]
semantic/senator.el byte compilation fix

* lisp/cedet/semantic/senator.el (semantic/analyze): Require to
avoid compilation warnings about unknown slots, and remove
declare-function.

5 years agosemantic/idle.el compilation warning fix
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:57:50 +0000 (16:57 +0200)]
semantic/idle.el compilation warning fix

* lisp/cedet/semantic/idle.el (semantic/analyze): Require to
avoid compilation warnings about unknown slots, and remove
declare-function.

5 years agosemantic/grammar byte compilation fixes
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:56:01 +0000 (16:56 +0200)]
semantic/grammar byte compilation fixes

* lisp/cedet/semantic/grammar.el (semantic/analyze): Require to
avoid compilation warnings about unknown slots, and remove
declare-function.

5 years agosemantic/chart.el compilation warning fixes
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:53:10 +0000 (16:53 +0200)]
semantic/chart.el compilation warning fixes

* lisp/cedet/semantic/chart.el (semantic/db-typecache)
(semantic/scope): Require to avoid byte compilation warnings about
undefined slots.  Remove declare-functions from these packages.

5 years agoFix some cedet compilation warnings pertaining to semantic/db
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:33:06 +0000 (16:33 +0200)]
Fix some cedet compilation warnings pertaining to semantic/db

* lisp/cedet/ede/config.el (semantic/db)
(ede-preprocessor-map): Ditto.

* lisp/cedet/ede/cpp-root.el (semantic/db): Ditto.

* lisp/cedet/ede/emacs.el (semantic/db): Ditto.

* lisp/cedet/ede/linux.el (semantic/db): Require to avoid warnings
about unknown slot lexical-table, and remove declare-functions
from the now-required semantic/db.

5 years agoproject.el compilation warning fix
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:16:49 +0000 (16:16 +0200)]
project.el compilation warning fix

* lisp/progmodes/project.el (xref--regexp-to-extended)
(xref--convert-hits): Declare more xref functions to avoid
compilation warnings.

5 years agoDepessimize bits of CC Mode for long C macros.
Alan Mackenzie [Thu, 13 Jun 2019 14:07:06 +0000 (14:07 +0000)]
Depessimize bits of CC Mode for long C macros.

* lisp/progmodes/cc-engine.el (c-end-of-macro): Check for being in a
degenerate zero length "macro", when setting the macro cache.
(c-determine-+ve-limit): Add in a missing goto-char form for when start-pos is
non-nil.
(c-back-over-member-initializers): Add a search limit parameter.

* lisp/progmodes/cc-fonts.el (c-get-fontification-context): Add a search limit
to c-go-up-list-backward.
(c-font-lock-cut-off-declarators): Add a search limit to
c-back-over-member-initializers.

* lisp/progmodes/cc-mode.el (c-before-change-check-unbalanced-strings): Don't
set c-new-END to the end of logical line (which might be a long macro).
(c-after-change-mark-abnormal-strings): Calculate end-hwm in place of the
setting of c-new-END (above).  Use this as a search limit rather than
c-new-END.

5 years ago; * etc/NEWS: Small cleanup.
Stefan Kangas [Thu, 13 Jun 2019 14:04:40 +0000 (16:04 +0200)]
; * etc/NEWS: Small cleanup.

* etc/NEWS: Merge two bookmark items in NEWS (bug#36188).

5 years agoRemove XEmacs support from bookmark.el
Stefan Kangas [Thu, 13 Jun 2019 14:02:39 +0000 (16:02 +0200)]
Remove XEmacs support from bookmark.el

* lisp/bookmark.el (bookmark-store): Remove XEmacs compat code
(bug#36189).

5 years agoUse cl-print-object instead of object-print throughout cedet
Lars Ingebrigtsen [Thu, 13 Jun 2019 13:58:32 +0000 (15:58 +0200)]
Use cl-print-object instead of object-print throughout cedet

* lisp/cedet/semantic/db-find.el (semanticdb-find-log-activity):
Ditto.

* lisp/cedet/semantic/analyze/debug.el
(semantic-analyzer-debug-insert-include-summary): Ditto.

* lisp/cedet/semantic/bovine/c.el (semantic-c-describe-environment)
(semantic-c-describe-environment)
(semantic-c-describe-environment): Ditto.

* lisp/cedet/semantic/decorate/include.el
(semantic-decoration-fileless-include-describe): Ditto.
(semantic-decoration-all-include-summary): Ditto.

* lisp/cedet/srecode/insert.el
(srecode-insert-variable-secondname-handler): Use cl-print-object
instead of object-print.

5 years agoerc-dcc.el minor clean-ups
Lars Ingebrigtsen [Thu, 13 Jun 2019 12:37:25 +0000 (14:37 +0200)]
erc-dcc.el minor clean-ups

* lisp/erc/erc-dcc.el: Remove outdated comments.
(erc-dcc-get-file): Remove XEmacs compat code.

5 years agoFix erc-dcc server-close code and fix compilation warning
Lars Ingebrigtsen [Thu, 13 Jun 2019 12:35:30 +0000 (14:35 +0200)]
Fix erc-dcc server-close code and fix compilation warning

* lisp/erc/erc-dcc.el (erc-dcc-get-filter): We receive unibyte
data, so no need to convert to unibyte.
(erc-dcc-send-filter): Kill the process before killing the buffer
so that we're not queried about killing the process.

5 years agoMake erc-dcc-server work again by making synchronous
Lars Ingebrigtsen [Thu, 13 Jun 2019 12:26:18 +0000 (14:26 +0200)]
Make erc-dcc-server work again by making synchronous

* lisp/erc/erc-dcc.el (erc-dcc-server): :server and :nowait can't
be mixed, so remove the :nowait.

5 years agoEscape newlines when printing functions in timer list
Pip Cet [Thu, 13 Jun 2019 12:10:56 +0000 (14:10 +0200)]
Escape newlines when printing functions in timer list

* timer-list.el (list-timers): Bind `print-escape-newlines' to avoid
newlines in printed representation (bug#36187).

5 years agoCompilation fix for previous change
Lars Ingebrigtsen [Thu, 13 Jun 2019 11:56:16 +0000 (13:56 +0200)]
Compilation fix for previous change

5 years agoCompilation warning fix for disass.el
Lars Ingebrigtsen [Thu, 13 Jun 2019 11:54:53 +0000 (13:54 +0200)]
Compilation warning fix for disass.el

* lisp/emacs-lisp/disass.el (disassemble-1): Remove a
string-as-unibyte that probably doesn't do anything, because the
string in question should be unibyte anyway.  If the assert fails,
revert the patch.

5 years agoCC Mode: replace an erroneous re-search-forward with search-forward
Alan Mackenzie [Thu, 13 Jun 2019 10:06:33 +0000 (10:06 +0000)]
CC Mode: replace an erroneous re-search-forward with search-forward

Move two declarations to a more suitable point in the cc-engine.el.

* lisp/progmodes/cc-engine.el (c-after-change-unmark-raw-strings): Change an
re-search-forward to search-forward.
(c-semi-lit-near-cache, c-semi-near-cache-limit): Move the declarations.

5 years agoFix display of Hebrew text with precomposed characters
Eli Zaretskii [Thu, 13 Jun 2019 09:41:37 +0000 (12:41 +0300)]
Fix display of Hebrew text with precomposed characters

* lisp/language/hebrew.el (base): Include precomposed
Hebrew characters from the Alphabetic Presentation Forms in
the composition patterns.  (Bug#36171)

5 years agoMerge branch 'master' of git.savannah.gnu.org:/srv/git/emacs
Eli Zaretskii [Thu, 13 Jun 2019 08:53:18 +0000 (11:53 +0300)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

5 years agoFix text shaping of precomposed characters with HarfBuzz
Eli Zaretskii [Thu, 13 Jun 2019 08:49:30 +0000 (11:49 +0300)]
Fix text shaping of precomposed characters with HarfBuzz

* src/hbfont.c (hbfont_shape): Fix setting TO of lglyph for
the case when Lisp shape-gstring function performed some
compositions by itself.  This happens with hebrew.el.  See
https://lists.freedesktop.org/archives/harfbuzz/2019-June/007396.html
for the details of the problem this solves.

5 years agoMove declaration of c-syntax-table-hwm to avoid compiler warnings.
Alan Mackenzie [Thu, 13 Jun 2019 08:46:30 +0000 (08:46 +0000)]
Move declaration of c-syntax-table-hwm to avoid compiler warnings.

This variable was declared after an invocation of a defsubst which used it,
the defsubst being in another file.

* lisp/progmodes/cc-mode (c-syntax-table-hwm): Move the declaration to earlier
in the file.

5 years agoAllow for line breaks in a bytecomp test
Glenn Morris [Thu, 13 Jun 2019 02:31:00 +0000 (19:31 -0700)]
Allow for line breaks in a bytecomp test

* test/lisp/emacs-lisp/bytecomp-tests.el (test-suppression):
Warnings from the byte compiler may be filled.

5 years agoAvoid string-make-multibyte in ps-mode.el
Lars Ingebrigtsen [Thu, 13 Jun 2019 01:12:03 +0000 (03:12 +0200)]
Avoid string-make-multibyte in ps-mode.el

* lisp/progmodes/ps-mode.el (ps-mode-octal-region): Avoid usage of
string-make-multibyte, but work in both unibyte and multibyte buffers.

5 years agoAdd more ps-mode octal tests
Lars Ingebrigtsen [Thu, 13 Jun 2019 01:03:26 +0000 (03:03 +0200)]
Add more ps-mode octal tests

* test/lisp/progmodes/ps-mode-tests.el
(ps-mode-test-octal-region-multibyte): New test.

5 years agoRevert previous ps-mode.el change
Lars Ingebrigtsen [Thu, 13 Jun 2019 00:54:24 +0000 (02:54 +0200)]
Revert previous ps-mode.el change

* lisp/progmodes/ps-mode.el (ps-mode-octal-region): Revert
previous change because the `string-make-unibyte' insertion was
the previous single change (in 2013) to this file, so it must have
some subtle meaning or other.

5 years agoAdd ps-mode-tests.el and remove a compilation warning
Lars Ingebrigtsen [Thu, 13 Jun 2019 00:48:41 +0000 (02:48 +0200)]
Add ps-mode-tests.el and remove a compilation warning

* lisp/progmodes/ps-mode.el (ps-mode-octal-region): Remove a
string-make-unibyte that apparently had no effect here.
* test/lisp/progmodes/ps-mode-tests.el: New file.

5 years agoSuppress warnings in tildify.el
Lars Ingebrigtsen [Thu, 13 Jun 2019 00:23:40 +0000 (02:23 +0200)]
Suppress warnings in tildify.el

* lisp/textmodes/tildify.el (tildify--deprecated-ignore-evironments):
(tildify-tildify, tildify-mode): Suppress warnings about obsolete
internal function `tildify--pick-alist-entry'.  Apparently these
semi-deprecated functions rely on each other.

5 years agoAdd comment to clarify the use of `str'
Lars Ingebrigtsen [Thu, 13 Jun 2019 00:03:55 +0000 (02:03 +0200)]
Add comment to clarify the use of `str'

5 years agoRevert "Compilation warning fix for byte-run.el"
Glenn Morris [Thu, 13 Jun 2019 00:20:50 +0000 (17:20 -0700)]
Revert "Compilation warning fix for byte-run.el"

* lisp/emacs-lisp/byte-run.el (macro-declaration-function):
Revert change that causes a bootstrap failure.

; Ref eg https://hydra.nixos.org/build/94678649

5 years agoFix compilation warnings in rfc2104
Lars Ingebrigtsen [Wed, 12 Jun 2019 23:53:52 +0000 (01:53 +0200)]
Fix compilation warnings in rfc2104

* lisp/net/rfc2104.el (rfc2104-hash): Remove superflous calls to
string-make-unibyte and avoid two compilation warnings.

5 years agoNew file rfc2104-tests.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 23:51:44 +0000 (01:51 +0200)]
New file rfc2104-tests.el

* test/lisp/net/rfc2104-tests.el: New file to test rfc2104 hashes.

5 years agoGive more information in a bytecomp test failure
Glenn Morris [Wed, 12 Jun 2019 23:48:33 +0000 (16:48 -0700)]
Give more information in a bytecomp test failure

* test/lisp/emacs-lisp/bytecomp-tests.el (test-suppression):
More informative failure messages.

5 years agoFix compilation warning in qp.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 23:43:58 +0000 (01:43 +0200)]
Fix compilation warning in qp.el

* lisp/mail/qp.el (quoted-printable-encode-region): No need to
convert the regexp to multibyte before searching.

5 years agoFix warning about obsolete func calling obsolete func in etags.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 23:33:27 +0000 (01:33 +0200)]
Fix warning about obsolete func calling obsolete func in etags.el

* lisp/progmodes/etags.el (find-tag-other-frame): Don't give a
warning about an obsolete function calling another obsolete function.

5 years agoCompilation warning fix in feedmail.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 23:29:27 +0000 (01:29 +0200)]
Compilation warning fix in feedmail.el

* lisp/mail/feedmail.el (feedmail-scroll-buffer): Remove XEmacs
compat code (that gave a compilation warning).

5 years agoRemove XEmacs compat code from mml.el that gave a compilation warning
Lars Ingebrigtsen [Wed, 12 Jun 2019 23:27:36 +0000 (01:27 +0200)]
Remove XEmacs compat code from mml.el that gave a compilation warning

* lisp/gnus/mml.el (mml-mode): Remove XEmacs compat code

5 years agomessage.el byte compilation warning fix
Lars Ingebrigtsen [Wed, 12 Jun 2019 23:24:47 +0000 (01:24 +0200)]
message.el byte compilation warning fix

* lisp/gnus/message.el (message-inhibit-body-encoding): Move
earlier to avoid compilation warning.

5 years agoCompilation warning fix for byte-run.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 23:14:47 +0000 (01:14 +0200)]
Compilation warning fix for byte-run.el

* lisp/emacs-lisp/byte-run.el (macro-declaration-function):
Suppress warning about obsolete function used by obsolete variable.

5 years agotodo-mode.el compilation warning fix
Lars Ingebrigtsen [Wed, 12 Jun 2019 23:12:23 +0000 (01:12 +0200)]
todo-mode.el compilation warning fix

* lisp/calendar/todo-mode.el (hl-line-highlight): Declare to avoid
compilation warning.

5 years agoTouch ups to the XEmacs deletion patch for idlw-shell.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 22:16:17 +0000 (00:16 +0200)]
Touch ups to the XEmacs deletion patch for idlw-shell.el

* lisp/progmodes/idlw-shell.el (idlwave-xemacs-hack-mouse-track):
Fix up previous obsoletion.

5 years agoRemove XEmacs support from idlw-shell.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 22:08:57 +0000 (00:08 +0200)]
Remove XEmacs support from idlw-shell.el

* lisp/progmodes/idlw-shell.el (idlwave-shell-make-temp-file)
(idlwave-shell-mouse-examine)
(idlwave-xemacs-hack-mouse-track, idlwave-display-buffer)
(idlwave-shell-debug-line-map)
(idlwave-shell-make-new-bp-overlay, idlwave-shell-mode-map):
Remove XEmacs support.

5 years agoRemove XEmacs support from ido.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 21:38:55 +0000 (23:38 +0200)]
Remove XEmacs support from ido.el

* lisp/ido.el (ido-active, ido-completion-help)
(ido-minibuffer-setup): Remove XEmacs support.

5 years agoRemove compat code for XEmacs and pre-Emacs 20 Emacs in pcomplete.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 21:26:36 +0000 (23:26 +0200)]
Remove compat code for XEmacs and pre-Emacs 20 Emacs in pcomplete.el

* lisp/pcomplete.el (pcomplete-event-matches-key-specifier-p)
(pcomplete-read-event, pcomplete-show-completions): Remove XEmacs
support and mark now-trivial defaliases as obsolete.

5 years agoRemove XEmacs support from dig.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 21:17:02 +0000 (23:17 +0200)]
Remove XEmacs support from dig.el

* lisp/net/dig.el (dig-mode): Remove XEmacs support.

5 years agoRemove XEmacs support from goto-addr.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 21:15:18 +0000 (23:15 +0200)]
Remove XEmacs support from goto-addr.el

* lisp/net/goto-addr.el (goto-address-highlight-keymap): Remove
XEmacs support.

5 years agoRemove XEmacs support from dns.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 21:14:15 +0000 (23:14 +0200)]
Remove XEmacs support from dns.el

* lisp/net/dns.el (dns-read-string-name, dns-write, dns-read)
(dns-make-network-process, dns-query): Remove XEmacs support.

5 years agoRemove XEmacs compat code from tempo.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 20:49:19 +0000 (22:49 +0200)]
Remove XEmacs compat code from tempo.el

* lisp/tempo.el (tempo-insert-template): Remove XEmacs compat code.

5 years agoCC Mode: Add a workaround for syntax-ppss ignoring syntax-table prop changes
Alan Mackenzie [Wed, 12 Jun 2019 19:17:22 +0000 (19:17 +0000)]
CC Mode: Add a workaround for syntax-ppss ignoring syntax-table prop changes

* lisp/progmodes/cc-engine.el (c-truncate-lit-pos-cache): Maintain the new
variable c-syntax-table-hwm after buffer changes.

* lisp/progmodes/cc-mode.el (c-syntax-table-hwm): New variable.
(c-before-change): Set c-syntax-table-hwm to "infinity".
(c-after-change): Call syntax-ppss-flush-cache, just before a font locking is
due to take place.

5 years agoRestore image scaling support when there's no native image scaling
Lars Ingebrigtsen [Wed, 12 Jun 2019 17:00:37 +0000 (19:00 +0200)]
Restore image scaling support when there's no native image scaling

* lisp/net/shr.el (shr--image-type): New function.
(shr-rescale-image): Use it to allow image scaling on Emacsen with
ImageMagick support that does not have native image scaling support.

5 years agoRewrite the kmacro register function to avoid using obsolete functions
Lars Ingebrigtsen [Wed, 12 Jun 2019 16:21:35 +0000 (18:21 +0200)]
Rewrite the kmacro register function to avoid using obsolete functions

* lisp/kmacro.el (kmacro-register): New struct to replace the
general registerv struct.
(register-val-jump-to, register-val-describe)
(register-val-insert): New methods to implement the register
interface.
(kmacro-to-register): Use the kmacro-register struct.

5 years ago(beginning-of-defun-raw): Suppress warning about syntax-begin-function
Lars Ingebrigtsen [Wed, 12 Jun 2019 15:45:59 +0000 (17:45 +0200)]
(beginning-of-defun-raw): Suppress warning about syntax-begin-function

* lisp/emacs-lisp/lisp.el (beginning-of-defun-raw):
font-lock-compile-keywords also suppresses warnings about the
obsolete syntax-begin-function variable, so suppress the only
other use not in syntax.el.

5 years agoSuppress warning about pi not having a prefix
Lars Ingebrigtsen [Wed, 12 Jun 2019 15:40:42 +0000 (17:40 +0200)]
Suppress warning about pi not having a prefix

* lisp/emacs-lisp/float-sup.el (pi): Suppress warning about this
obsolete variable not having a prefix.

5 years ago* doc/lispref/text.texi (Base 64): Fix typos.
Richard Copley [Tue, 11 Jun 2019 20:14:11 +0000 (21:14 +0100)]
* doc/lispref/text.texi (Base 64): Fix typos.

Copyright-paperwork-exempt: yes.

5 years agoSuppress warning about obsolete function custom-show
Lars Ingebrigtsen [Wed, 12 Jun 2019 14:33:00 +0000 (16:33 +0200)]
Suppress warning about obsolete function custom-show

* lisp/cus-edit.el (custom-variable-value-create): Suppress
warning about obsolete function custom-show.  The widget this
supports has been obsolete since Emacs 24, but we should perhaps
be very conservative about removing widget types, so suppress the
warning instead of removing the widget type.

5 years agoSuppress warning in display-completion-list about itself
Lars Ingebrigtsen [Wed, 12 Jun 2019 14:18:34 +0000 (16:18 +0200)]
Suppress warning in display-completion-list about itself

* lisp/minibuffer.el (display-completion-list):
`display-completion-list' calls itself with the old, obsolete
callargs, so suppress this warning.

5 years agoSuppress interactive-only warnings in epa*.el
Lars Ingebrigtsen [Wed, 12 Jun 2019 14:17:25 +0000 (16:17 +0200)]
Suppress interactive-only warnings in epa*.el

* lisp/epa-mail.el (epa-mail-decrypt, epa-mail-verify)
(epa-mail-sign, epa-mail-encrypt): Ditto.

* lisp/epa.el (epa-verify-cleartext-in-region): Suppress warnings
about calling interactive-only functions, because these are
interactive-only thin wrappers around those functions.

5 years agoehelp.el: Suppress warning
Lars Ingebrigtsen [Wed, 12 Jun 2019 14:15:30 +0000 (16:15 +0200)]
ehelp.el: Suppress warning

* lisp/ehelp.el (electric-help-execute-extended): Suppress warning
about `execute-extended-command' only being interactive, because
we're still using it interactively, but via a wrapper.

5 years agoAdd the new macro with-suppressed-warnings
Lars Ingebrigtsen [Wed, 12 Jun 2019 13:59:19 +0000 (15:59 +0200)]
Add the new macro with-suppressed-warnings

* lisp/emacs-lisp/byte-run.el (with-suppressed-warnings): New macro.

* doc/lispref/compile.texi (Compiler Errors): Document
with-suppressed-warnings and deemphasise with-no-warnings
slightly.

* lisp/emacs-lisp/bytecomp.el (byte-compile--suppressed-warnings):
New internal variable.
(byte-compile-warning-enabled-p): Heed
byte-compile--suppressed-warnings, bound via with-suppressed-warnings.
(byte-compile-initial-macro-environment): Provide a macro
expansion of with-suppressed-warnings.
(byte-compile-file-form-with-suppressed-warnings): New byte hunk
handler for the suppressed symbol machinery.
(byte-compile-suppressed-warnings): Ditto for the byteop.
(byte-compile-file-form-defmumble): Ditto.
(byte-compile-form, byte-compile-normal-call)
(byte-compile-normal-call, byte-compile-variable-ref)
(byte-compile-set-default, byte-compile-variable-set)
(byte-compile-function-form, byte-compile-set-default)
(byte-compile-warn-obsolete, byte-compile--declare-var): Pass the
symbol being warned in to byte-compile-warning-enabled-p.

* test/lisp/emacs-lisp/bytecomp-tests.el (test-suppression): New
function.
(bytecomp-test--with-suppressed-warnings): Tests.

5 years agoFix to previous commit
Roland Winkler [Wed, 12 Jun 2019 03:17:30 +0000 (22:17 -0500)]
Fix to previous commit

* find-dired.el (find-dired-sentinel): Check whether
find-dired-refine-function is non-nil.

5 years agoAllow refining the *Find* buffer of find-dired. (Bug#29513)
Roland Winkler [Tue, 11 Jun 2019 21:04:45 +0000 (16:04 -0500)]
Allow refining the *Find* buffer of find-dired. (Bug#29513)

* find-dired.el (find-dired-refine-function): New user variable.
(find-dired-sentinel): Use it.  Simplify.
(find-dired-sort-by-filename): New function.

5 years agoKeep auto-revert-mode working when changing buffer file name (bug#36159)
Mattias EngdegÄrd [Mon, 10 Jun 2019 15:52:50 +0000 (17:52 +0200)]
Keep auto-revert-mode working when changing buffer file name (bug#36159)

* lisp/autorevert.el (after-set-visited-file-name-hook):
Add unconditionally.
(global-auto-revert-mode): Don't use
`after-set-visited-file-name-hook' here.
(auto-revert-set-visited-file-name): Rename from
`auto-revert--global-set-visited-file-name' and generalise.
* test/lisp/autorevert-tests.el (auto-revert-test06-write-file): New.

5 years agoMinor fixes on tramp-tests.el for w32
Michael Albinus [Tue, 11 Jun 2019 18:28:31 +0000 (20:28 +0200)]
Minor fixes on tramp-tests.el for w32

* test/lisp/net/tramp-tests.el (tramp-test32-shell-command):
Ignore absence of tput.
(tramp-test43-asynchronous-requests): Don't start watchdog on w32.

5 years agoMerge from origin/emacs-26
Glenn Morris [Tue, 11 Jun 2019 15:38:34 +0000 (08:38 -0700)]
Merge from origin/emacs-26

5ca093d (origin/emacs-26) Fix doc of 'display-buffer-in-previous-wind...
add2cac lisp/*.el: Minor docstring fixes

5 years ago; Merge from origin/emacs-26
Glenn Morris [Tue, 11 Jun 2019 15:38:34 +0000 (08:38 -0700)]
; Merge from origin/emacs-26

The following commit was skipped:

fdd1b3e Avoid assertion violation when comparing with main-thread