]> git.eshelyaron.com Git - emacs.git/log
emacs.git
18 months agoFix VC package build when doc file isn't in a subdir
Daniel Semyonov [Fri, 23 Jun 2023 05:40:57 +0000 (08:40 +0300)]
Fix VC package build when doc file isn't in a subdir

* lisp/emacs-lisp/package-vc.el (package-vc--build-documentation):
Expand 'file' before attempting to get its directory.  (Bug#64242)

18 months ago; * doc/emacs/package.texi (Fetching Package Sources): Fix typo (bug#64282).
Eli Zaretskii [Sun, 25 Jun 2023 14:57:31 +0000 (17:57 +0300)]
; * doc/emacs/package.texi (Fetching Package Sources): Fix typo (bug#64282).

18 months agoFix type check in tramp-get-buffer-string
Michael Albinus [Sun, 25 Jun 2023 12:31:23 +0000 (14:31 +0200)]
Fix type check in tramp-get-buffer-string

* lisp/net/tramp.el (tramp-get-buffer-string): Check, that BUFFER
is really a bufferp.

18 months ago; Fix typo in maintaining.texi (bug#64279)
Eshel Yaron [Sat, 24 Jun 2023 20:31:44 +0000 (23:31 +0300)]
; Fix typo in maintaining.texi (bug#64279)

* doc/emacs/maintaining.texi (Log Buffer): Fix a typo.

18 months ago; * doc/lispintro/emacs-lisp-intro.texi (car & cdr): Fix typo.
Eli Zaretskii [Sun, 25 Jun 2023 05:25:13 +0000 (08:25 +0300)]
; * doc/lispintro/emacs-lisp-intro.texi (car & cdr): Fix typo.

(cherry picked from commit 0ebedd0119c1bc3c1f55e873385a01e97f102766)

18 months agoClarify list terminology
Richard M. Stallman [Sat, 24 Jun 2023 23:19:53 +0000 (19:19 -0400)]
Clarify list terminology

* doc/lispintro/emacs-lisp-intro.texi (Lists diagrammed):
Mention "cons cell".  Add index entries.
(car & cdr): Simplify etymology of `car' and `cdr'.
Explain why for some purposes they are better than `first' and `rest'.
Mention cons cells.

(cherry picked from commit 188c90c7c111dbbdc3edd29c23b59ade26f97bfd)

18 months ago* lisp/emacs-lisp/shortdoc.el: More and better `substring` examples.
Mattias Engdegård [Fri, 23 Jun 2023 17:42:44 +0000 (19:42 +0200)]
* lisp/emacs-lisp/shortdoc.el: More and better `substring` examples.

Suggested by Juri Linkov.

18 months agoFix "C-x RET r" when the new encoding is UTF
Eli Zaretskii [Sat, 24 Jun 2023 08:49:14 +0000 (11:49 +0300)]
Fix "C-x RET r" when the new encoding is UTF

* src/fileio.c (Finsert_file_contents): Update point of
'conversion_buffer' before decoding the last block.  (Bug#64253)

18 months ago; Mention MinGW64 GCC 13.1 problems in PROBLEMS
Eli Zaretskii [Sat, 24 Jun 2023 07:23:07 +0000 (10:23 +0300)]
; Mention MinGW64 GCC 13.1 problems in PROBLEMS

* etc/PROBLEMS: Mention the problems building with MinGW64 GCC
13.1.  (Bug#63365)

18 months agoFix "vc-print-log does not erase buffer" and associated problems
Dmitry Gutov [Sat, 24 Jun 2023 02:57:18 +0000 (05:57 +0300)]
Fix "vc-print-log does not erase buffer" and associated problems

* lisp/vc/vc.el (vc-deduce-fileset): Make sure to retain the
buffer switch (if it did), bug#63949.

18 months agoAdd selector_expression indentation rule
Theodor Thornhill [Fri, 23 Jun 2023 13:37:04 +0000 (15:37 +0200)]
Add selector_expression indentation rule

* lisp/progmodes/go-ts-mode.el (go-ts-mode--indent-rules): New rule.

18 months agoAdd "nixd" LSP server to Eglot
Eli Zaretskii [Thu, 22 Jun 2023 16:33:31 +0000 (19:33 +0300)]
Add "nixd" LSP server to Eglot

* lisp/progmodes/eglot.el (eglot-server-programs): Add "nixd".
Patch by Brian Leung <leungbk@posteo.net>.  (Bug#64214)

18 months agoFix building --with-native-compilation=aot from release tarball
Eli Zaretskii [Thu, 22 Jun 2023 11:03:17 +0000 (14:03 +0300)]
Fix building --with-native-compilation=aot from release tarball

* lisp/Makefile.in (%.eln): Pattern rule for AOT native
compilation.
(compile-eln-targets, compile-eln-aot): New targets for AOT native
compilation.

* src/Makefile.in (../native-lisp): If NATIVE_COMPILATION_AOT is
set, also native-compile all the other Lisp files.
(Bug#64167)

18 months agoFix bug#64152 (Minibuffer sometimes goes "modal")
Alan Mackenzie [Wed, 21 Jun 2023 14:23:14 +0000 (14:23 +0000)]
Fix bug#64152 (Minibuffer sometimes goes "modal")

In particular, when a frame has no minibuffer and is using that
of a different "normal" frame, C-x 5 o, etc., and GUI
operations fail.

Fix by partially reverting the commit from 2022-07-07 15:38:09
+0000 "Remove obscure, obsolete code from do_switch_frame".  As
a consequent change, also revert the commit from 2022-07-08
20:19:03 +0000 "Remove now unused parameter TRACK from
do_switch_frame".

* src/frame.c (do_switch_frame): Restore the TRACK parameter.
Restore the code which redirects the frame focus when a new
frame gets selected.

* src/frame.c (Fselect_frame, Fhandle_switch_frame)
(delete_frame)
* src/keyboard.c (quit_throw_to_read_char)
* src/lisp.h (do_switch_frame prototype)
* src/minibuf.c (read_minibuf_unwind)
* src/window.c (Fset_window_configuration): Restore the TRACK
argument to do_switch_frame.

* src/xterm.c (x_try_restore_frame): Add a zero TRACK argument
to do_switch_frame.

18 months agoDisable target-async by default in gdb-mi.el
Eli Zaretskii [Wed, 21 Jun 2023 13:10:52 +0000 (16:10 +0300)]
Disable target-async by default in gdb-mi.el

* lisp/progmodes/gdb-mi.el (gdb-non-stop-setting): Disable until
bug#63084 is fixed.  (Bug#64186)

18 months agoRevert "Fix parsing of dn line if WITHDN is non-nil"
Filipp Gunbin [Tue, 20 Jun 2023 15:25:24 +0000 (18:25 +0300)]
Revert "Fix parsing of dn line if WITHDN is non-nil"

This reverts commits 71b27779a9a and d2246b26275, because they change
the return value of "ldap-search" in an incompatible way.  The fix
(a different one) will be done on master instead (bug#64089).

18 months agoDon't truncate filenames with "emacs.el" in them
Eli Zaretskii [Tue, 20 Jun 2023 13:35:09 +0000 (16:35 +0300)]
Don't truncate filenames with "emacs.el" in them

* lisp/emacs-lisp/find-func.el (find-function-search-for-symbol):
Avoid false positives when looking for "emacs.el" matches the
likes of "emacs.elpa".  (Bug#64143)

18 months agoImprove documentation of 'minibuffer-message'
Eli Zaretskii [Tue, 20 Jun 2023 12:31:57 +0000 (15:31 +0300)]
Improve documentation of 'minibuffer-message'

* doc/lispref/minibuf.texi (Minibuffer Misc): Clarify that
'minibuffer-message' behaves like 'message' if called from a
buffer that is not a minibuffer.

* lisp/minibuffer.el (minibuffer-message)
(set-minibuffer-message, clear-minibuffer-message): Doc fixes.
(Bug#64165)

18 months agoEglot: again fix positions of coinciding inlay hint overlays (bug#64101)
João Távora [Mon, 19 Jun 2023 22:31:03 +0000 (23:31 +0100)]
Eglot: again fix positions of coinciding inlay hint overlays (bug#64101)

This bug originated from the previous fix, and is reproducible on non
Mac OS platforms, as long as the very latest version (at time of
writing) of the rust-analyzer server is used.

* lisp/progmodes/eglot.el (eglot--update-hints-1): Reverse
priorities when pegging overlays after (i.e. when before-string is
used).

18 months ago; Update ChangeLog.4 and etc/AUTHORS. emacs-29.0.92
Eli Zaretskii [Sun, 18 Jun 2023 11:15:29 +0000 (07:15 -0400)]
; Update ChangeLog.4 and etc/AUTHORS.

18 months ago* lisp/ldefs-boot.el: Regenerate.
Eli Zaretskii [Sun, 18 Jun 2023 11:14:46 +0000 (07:14 -0400)]
* lisp/ldefs-boot.el: Regenerate.

18 months agoBump Emacs version to 29.0.92
Eli Zaretskii [Sun, 18 Jun 2023 10:47:21 +0000 (06:47 -0400)]
Bump Emacs version to 29.0.92

* README:
* configure.ac:
* nt/README.W32:
* msdos/sed2v2.inp: Bump version to 29.0.92.

18 months agoDescribe primarily the Emacs s-exp dialect for treesit queries
Mattias Engdegård [Sun, 18 Jun 2023 08:37:53 +0000 (10:37 +0200)]
Describe primarily the Emacs s-exp dialect for treesit queries

* doc/lispref/parsing.texi (Pattern Matching, Multiple Languages):
Writing tree-sitter queries as Emacs s-expressions is much more
convenient than using the native query notation inside a string,
so it makes sense to base the documentation on the former dialect
(bug#64017).

18 months ago; Improve documentation of overlay priorities
Eli Zaretskii [Sun, 18 Jun 2023 06:13:02 +0000 (09:13 +0300)]
; Improve documentation of overlay priorities

* doc/lispref/display.texi (Overlay Properties): Don't advise
against using overlay property values that are cons cells.
(Bug#64101)

18 months agoFix documentation of :predicate in 'define-globalized-minor-mode'
Eli Zaretskii [Sun, 18 Jun 2023 05:50:54 +0000 (08:50 +0300)]
Fix documentation of :predicate in 'define-globalized-minor-mode'

* doc/lispref/modes.texi (Defining Minor Modes):
* lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode):
Document that :predicate creates a customizable user option.
(Bug#64048)

18 months agoRevert "Fix some tree-sitter :match regexps"
Basil L. Contovounesios [Sat, 17 Jun 2023 19:39:16 +0000 (20:39 +0100)]
Revert "Fix some tree-sitter :match regexps"

This reverts commit 95091b77f0bbb2ae1aa94ef4a413626e7d434d58
of 2023-06-17, mistakenly pushed to emacs-29.

The patch will be installed on master instead, and backported later,
after Emacs 29.1 is released (bug#64019).

Do not merge to master.

18 months agoMerge branch 'emacs-29' of git.sv.gnu.org:/srv/git/emacs into emacs-29
Michael Albinus [Sat, 17 Jun 2023 16:16:24 +0000 (18:16 +0200)]
Merge branch 'emacs-29' of git.sv.gnu.org:/srv/git/emacs into emacs-29

18 months agoMerge branch 'emacs-29' of git.sv.gnu.org:/srv/git/emacs into emacs-29
Michael Albinus [Sat, 17 Jun 2023 16:15:47 +0000 (18:15 +0200)]
Merge branch 'emacs-29' of git.sv.gnu.org:/srv/git/emacs into emacs-29

18 months agoRequire ls-lisp in Tramp only when needed
Michael Albinus [Sat, 17 Jun 2023 16:15:09 +0000 (18:15 +0200)]
Require ls-lisp in Tramp only when needed

* lisp/net/tramp-compat.el (ls-lisp): Require only on MS Windows.
(Bug#64124)

* lisp/net/tramp-sh.el (ls-lisp-use-insert-directory-program): Declare.
(tramp-sh-handle-insert-directory): Simplify.

* lisp/net/tramp.el (ls-lisp-use-insert-directory-program): Declare.
(tramp-handle-insert-directory): Require ls-lisp.  Simplify.

18 months agoAfter minibuffer action, don't make the minibuffer current
Alan Mackenzie [Sat, 17 Jun 2023 16:14:14 +0000 (16:14 +0000)]
After minibuffer action, don't make the minibuffer current

This fixes bug#63967.

* src/minibuf.c (minibuffer_unwind): After restoring the next
minibuffer outwards to the mini window (when
enable-recursive-minibuffers is non-nil), don't call
Fset_frame_selected_window, which used to set the current
window to be the mini window.

18 months agoFix some tree-sitter :match regexps
Basil L. Contovounesios [Tue, 13 Jun 2023 12:53:31 +0000 (13:53 +0100)]
Fix some tree-sitter :match regexps

The shy groups were caught by modified versions of the GNU ELPA
packages xr and relint:
- https://github.com/mattiase/xr/pull/6
- https://github.com/mattiase/relint/pull/14

* lisp/progmodes/ruby-ts-mode.el (ruby-ts--s-p-query): Quote special
character in regexp.
* lisp/progmodes/java-ts-mode.el (java-ts-mode--font-lock-settings):
* lisp/progmodes/js.el (js--plain-method-re):
(js--treesit-font-lock-settings):
* lisp/progmodes/rust-ts-mode.el (rust-ts-mode--font-lock-settings):
* lisp/progmodes/typescript-ts-mode.el
(typescript-ts-mode--font-lock-settings): Replace character
alternative [\\d], which matches '\' or 'd', with the most likely
intention [0-9].  Fix shy groups mistyped as optional colons.
Remove unneeded numbered :match group in rust-ts-mode (bug#64019).

18 months agoEglot: fix relative position of coinciding inlay hint overlays (bug#64101)
João Távora [Sat, 17 Jun 2023 14:25:30 +0000 (15:25 +0100)]
Eglot: fix relative position of coinciding inlay hint overlays (bug#64101)

Only seems to happen on certain platforms, like Mac OS.  Reason
unknown reason so far, but this defensive fix seems safe.

* lisp/progmodes/eglot.el (eglot--update-hints-1): Explicitly put
priority in inlay hint overalys.

18 months ago; * doc/lispref/display.texi (Display Tables): Remove extra parens.
Eli Zaretskii [Sat, 17 Jun 2023 13:13:38 +0000 (16:13 +0300)]
; * doc/lispref/display.texi (Display Tables): Remove extra parens.

18 months agoFix documentation of comment-dwim (bug#64104)
Eli Zaretskii [Sat, 17 Jun 2023 08:37:19 +0000 (11:37 +0300)]
Fix documentation of comment-dwim (bug#64104)

* lisp/newcomment.el (comment-dwim): Doc fix.

* doc/emacs/programs.texi (Comment Commands): More accurate
description of what 'M-;' does when there's no active region.

18 months ago; * lisp/net/ldap.el (ldap-search-internal): Fix last change. (Bug#64089)
Eli Zaretskii [Sat, 17 Jun 2023 07:59:44 +0000 (10:59 +0300)]
; * lisp/net/ldap.el (ldap-search-internal): Fix last change.  (Bug#64089)

18 months agoFix parsing of dn line if WITHDN is non-nil
Jens Schmidt [Thu, 15 Jun 2023 22:04:04 +0000 (00:04 +0200)]
Fix parsing of dn line if WITHDN is non-nil

Function `ldap-search' errors out with `wrong-type-argument listp'
when called with WITHDN non-nil.
* lisp/net/ldap.el (ldap-search-internal): Parse the dn line
correctly so that `ldap-search' can grok it.  (Bug#64089)

18 months ago; Fix example in the Flymake manual
Eli Zaretskii [Sat, 17 Jun 2023 07:49:45 +0000 (10:49 +0300)]
; Fix example in the Flymake manual

* doc/misc/flymake.texi (An annotated example backend): Fix the
example.  (Bug#64070)

18 months ago* doc/misc/calc.texi (Advanced Math Functions): Correct calc
Andreas Schwab [Thu, 15 Jun 2023 14:18:58 +0000 (16:18 +0200)]
* doc/misc/calc.texi (Advanced Math Functions): Correct calc
algebraic syntax.

18 months agoConsider 'dired-kill-when-opening-new-dired-buffer' in mouse clicks
Eli Zaretskii [Thu, 15 Jun 2023 13:12:24 +0000 (16:12 +0300)]
Consider 'dired-kill-when-opening-new-dired-buffer' in mouse clicks

* lisp/dired.el (dired-mouse-find-file): Honor the value of
'dired-kill-when-opening-new-dired-buffer'.  (Bug#64079)

18 months ago; Fix use-package.texi markup
Robert Pluim [Thu, 15 Jun 2023 10:23:29 +0000 (12:23 +0200)]
; Fix use-package.texi markup

* doc/misc/use-package.texi (Best practices): It's a subsection, not a
subheading.

18 months ago; * doc/misc/calc.texi (Advanced Math Functions): Fix last change.
Eli Zaretskii [Thu, 15 Jun 2023 08:38:32 +0000 (11:38 +0300)]
; * doc/misc/calc.texi (Advanced Math Functions): Fix last change.

18 months agoFix Gamma function definition in calc.texi
Eli Zaretskii [Thu, 15 Jun 2023 07:39:55 +0000 (10:39 +0300)]
Fix Gamma function definition in calc.texi

* doc/misc/calc.texi (Advanced Math Functions): Fix definition
of Gamma function.  Use @sup in @infoline lines.  (Bug#64077)

18 months agoFix subscripts in the Calc manual
Eli Zaretskii [Thu, 15 Jun 2023 07:08:55 +0000 (10:08 +0300)]
Fix subscripts in the Calc manual

* doc/misc/calc.texi (Musical Notes): Use @sub instead of TeX-only
'_' notation.  For the details, see the discussion in
https://lists.gnu.org/archive/html/emacs-devel/2023-06/msg00096.html.

18 months agoImprove documentation of 'declare' forms
Eli Zaretskii [Thu, 15 Jun 2023 06:28:26 +0000 (09:28 +0300)]
Improve documentation of 'declare' forms

* lisp/simple.el (read-extended-command-predicate): Mention the
'(declare completion ...' form in the doc string.

* doc/lispref/functions.texi (Declare Form): Clarify
'completion-predicate' and 'modes'; add cross-references.
(Bug#64045)

18 months ago; * src/lread.c (bytecode_from_rev_list): Avoid C++ comment.
Po Lu [Wed, 14 Jun 2023 05:54:53 +0000 (13:54 +0800)]
; * src/lread.c (bytecode_from_rev_list): Avoid C++ comment.

18 months agoImprove tree-sitter docs
Basil L. Contovounesios [Sun, 11 Jun 2023 14:19:28 +0000 (15:19 +0100)]
Improve tree-sitter docs

* doc/lispref/positions.texi (List Motion): Incorporate more
accurate description of treesit-defun-type-regexp from
'(elisp) Tree-sitter Major Modes', replacing that duplicate
entry (bug#64018).

* doc/lispref/parsing.texi (Parsing Program Source)
(Language Grammar, Using Parser, Retrieving Nodes)
(Accessing Node Information, Pattern Matching, Multiple Languages):
(Tree-sitter Major Modes):
* doc/lispref/modes.texi (Parser-based Font Lock): Improve wording,
grammar, punctuation, and markup.  Fix typos.
(Parser-based Indentation): Ditto.  Document indent rule presets
field-is, catch-all, nth-sibling, grand-parent, and
great-grand-parent.

* lisp/treesit.el (treesit-simple-indent-presets): Mention field-is,
catch-all, nth-sibling, grand-parent, great-grand-parent in
docstring.
(treesit-major-mode-setup, treesit-explore-mode): Improve
docstring/commentary grammar.

18 months agoFix some Texinfo markup in manuals
Basil L. Contovounesios [Mon, 12 Jun 2023 13:42:31 +0000 (14:42 +0100)]
Fix some Texinfo markup in manuals

* doc/emacs/macos.texi (Mac / GNUstep Customization):
* doc/lispintro/emacs-lisp-intro.texi (condition-case):
* doc/lispref/control.texi (pcase Macro):
* doc/lispref/debugging.texi (Internals of Debugger):
* doc/lispref/internals.texi (Building Emacs):
* doc/lispref/modes.texi (Imenu):
(Parser-based Font Lock, Parser-based Indentation):
* doc/lispref/parsing.texi (Retrieving Nodes, Tree-sitter C API):
* doc/lispref/processes.texi (Network, Bindat Types):
* doc/lispref/searching.texi (Rx Functions):
* doc/lispref/text.texi (Replacing):
* doc/lispref/windows.texi (Textual Scrolling):
* doc/misc/calc.texi (Killing From Stack, Customizing Calc):
* doc/misc/cc-mode.texi (Misc Font Locking, List Line-Up):
* doc/misc/ede.texi (ede-cpp-root-project)
(ede-proj-target-makefile, ede-sourcecode):
* doc/misc/ert.texi (Running Tests in Batch Mode):
* doc/misc/eudc.texi (Emacs-only Configuration, The Server Hotlist):
* doc/misc/eww.texi (Advanced):
* doc/misc/flymake.texi (Starting Flymake)
(Proc customization variables):
* doc/misc/tramp.texi (File name completion):
* doc/misc/gnus.texi (Summary Buffer Lines, Gnus Registry Setup)
(Fancy splitting to parent, Customizing the IMAP Connection)
(Mail Source Specifiers, Agent as Cache): Consistently mark up nil
and t as @code.  Also fix the markup and wording of some surrounding
text (bug#64016).

* doc/lispref/display.texi (SVG Images, Icons):
* doc/lispref/modes.texi (Customizing Keywords): Prefer ASCII
apostrophe over Unicode right single quotation mark.

18 months agoFix bol/bos anchors in tree-sitter :match regexps
Basil L. Contovounesios [Tue, 13 Jun 2023 12:45:08 +0000 (13:45 +0100)]
Fix bol/bos anchors in tree-sitter :match regexps

Further regexp fixes to follow separately (bug#64019#29).

* lisp/progmodes/c-ts-mode.el (c-ts-mode--font-lock-settings):
* lisp/progmodes/cmake-ts-mode.el
(cmake-ts-mode--font-lock-settings):
* lisp/progmodes/java-ts-mode.el (java-ts-mode--font-lock-settings):
* lisp/progmodes/js.el (js--treesit-font-lock-settings):
* lisp/progmodes/python.el (python--treesit-settings):
* lisp/progmodes/rust-ts-mode.el (rust-ts-mode--font-lock-settings):
* lisp/progmodes/sh-script.el (sh-mode--treesit-settings):
* lisp/progmodes/typescript-ts-mode.el
(typescript-ts-mode--font-lock-settings):
* test/src/treesit-tests.el (treesit-query-api): Anchor :match
regexps at beginning/end of string, not line.

18 months ago; * src/xdisp.c (syms_of_xdisp) <display-line-numbers>: Fix typo
Gregory Heytings [Tue, 13 Jun 2023 13:12:55 +0000 (13:12 +0000)]
; * src/xdisp.c (syms_of_xdisp) <display-line-numbers>: Fix typo

18 months ago; Fix last change in tex-mode.el
Eli Zaretskii [Tue, 13 Jun 2023 11:11:41 +0000 (14:11 +0300)]
; Fix last change in tex-mode.el

* lisp/textmodes/tex-mode.el (tex-cmd-doc-view): Remove the second
argument.  (Bug#63956)

18 months ago* lisp/subr.el (with-restriction): Tweak indent rule
Stefan Monnier [Tue, 13 Jun 2023 02:43:44 +0000 (22:43 -0400)]
* lisp/subr.el (with-restriction): Tweak indent rule

18 months ago; Fix previous change
Robert Pluim [Mon, 12 Jun 2023 17:02:29 +0000 (19:02 +0200)]
; Fix previous change

* lisp/window.el (display-tex-shell-buffer-action): Fix default
value's type.  (Bug#63956)

18 months agoFix setting region in the minibuffer
Eli Zaretskii [Mon, 12 Jun 2023 15:47:04 +0000 (18:47 +0300)]
Fix setting region in the minibuffer

* lisp/minibuffer.el (minibuffer-beginning-of-buffer): Fix setting
region.  (Bug#64022)

18 months agoFix setting $DBUS_SESSION_BUS_ADDRESS after Emacs has started
Michael Albinus [Mon, 12 Jun 2023 10:45:38 +0000 (12:45 +0200)]
Fix setting $DBUS_SESSION_BUS_ADDRESS after Emacs has started

* doc/misc/dbus.texi (Alternative Buses): Explain using
$DBUS_SESSION_BUS_ADDRESS after Emacs has started.

* src/dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Use egetenv.

18 months agoFix tex-mode display-buffer issues
Eli Zaretskii [Sun, 11 Jun 2023 06:15:01 +0000 (09:15 +0300)]
Fix tex-mode display-buffer issues

* lisp/window.el (display-tex-shell-buffer-action): New defcustom.
* lisp/textmodes/tex-mode.el (tex-display-shell)
(tex-cmd-doc-view, tex-recenter-output-buffer): Use it.
(Bug#63956)

18 months agoAdd test for when 'completion-auto-help' is 'visible'
Morgan Smith [Tue, 6 Jun 2023 19:02:57 +0000 (15:02 -0400)]
Add test for when 'completion-auto-help' is 'visible'

* test/lisp/minibuffer-tests.el (completion-auto-help-test): Add
test for when 'completion-auto-help' is 'visible'.  Also test
for successful completion message.  (Bug#63913)

18 months agoAvoid errors in 'apropos-documentation' after 'eval-buffer'
Eli Zaretskii [Sat, 10 Jun 2023 17:48:21 +0000 (20:48 +0300)]
Avoid errors in 'apropos-documentation' after 'eval-buffer'

* lisp/apropos.el (apropos--map-preloaded-atoms): Support the case
where an element of 'load-history' has nil as its car.  (Bug#63881)

18 months ago; * doc/emacs/indent.texi (Indentation Commands): Fix last change.
Eli Zaretskii [Sat, 10 Jun 2023 11:16:22 +0000 (14:16 +0300)]
; * doc/emacs/indent.texi (Indentation Commands): Fix last change.

18 months agoMention indent-rigidly in the Emacs manual
Daniel Martín [Sat, 10 Jun 2023 10:36:53 +0000 (12:36 +0200)]
Mention indent-rigidly in the Emacs manual

* doc/emacs/indent.texi (Indentation Commands): Rewrite the first
sentence of 'C-x TAB' to mention the command that it executes, and
without using passive voice.  (Bug#63997)

18 months agoDon't ding when completion succeeded
Morgan Smith [Mon, 5 Jun 2023 17:34:59 +0000 (13:34 -0400)]
Don't ding when completion succeeded

* lisp/minibuffer.el (minibuffer-completion-help): Ensure 'ding'
is not called on a successful completion.  Ensure 'ding' is not
called on a failure if 'completion-fail-discreetly' is set.
Also change "No completions" to "No match" as that is what is
used elsewhere.  (Bug#63913)

18 months ago; * admin/git-bisect-start: Update failing commits
Gregory Heytings [Sat, 10 Jun 2023 08:50:47 +0000 (08:50 +0000)]
; * admin/git-bisect-start: Update failing commits

18 months ago; * src/xdisp.c (redisplay_tool_bar): Fix a typo in a comment.
Eli Zaretskii [Fri, 9 Jun 2023 16:19:07 +0000 (19:19 +0300)]
; * src/xdisp.c (redisplay_tool_bar): Fix a typo in a comment.

18 months agoImprove documentation of color-related functions
Eli Zaretskii [Fri, 9 Jun 2023 07:28:36 +0000 (10:28 +0300)]
Improve documentation of color-related functions

* doc/lispref/frames.texi (Color Names): Document
'color-name-to-rgb' and 'color-dark-p'.

18 months agoRevert "* package.el (package--get-activatable-pkg): Prefer source packages"
Eli Zaretskii [Thu, 8 Jun 2023 09:23:11 +0000 (12:23 +0300)]
Revert "* package.el (package--get-activatable-pkg): Prefer source packages"

This reverts commit fb87d5008e21d1bc03547c1edf2280fb4cb8311e.
It caused problems when new versions of packages are installed
without deleting old versions.  (Bug#63757)

18 months ago; Update my mail address
Andrea Corallo [Thu, 8 Jun 2023 08:59:41 +0000 (10:59 +0200)]
; Update my mail address

* lisp/emacs-lisp/comp-cstr.el: Update author mail.
* lisp/emacs-lisp/comp.el: Likewise.
* src/comp.c: Likewise.
* test/lisp/emacs-lisp/comp-cstr-tests.el: Likewise.
* test/src/comp-resources/comp-test-funcs-dyn.el: Likewise.
* test/src/comp-resources/comp-test-funcs.el: Likewise.
* test/src/comp-resources/comp-test-pure.el: Likewise.
* test/src/comp-tests.el: Likewise.

18 months agoFix connection-local user options handling (bug#63300)
Michael Albinus [Thu, 8 Jun 2023 07:59:06 +0000 (09:59 +0200)]
Fix connection-local user options handling (bug#63300)

* lisp/files-x.el (connection-local-set-profiles)
(connection-local-set-profile-variables): Avoid saving the changed
user option to file unless triggered explicitly by user.  (Bug#63300)

18 months agoDocument 'startup-redirect-eln-cache'
Eli Zaretskii [Thu, 8 Jun 2023 05:50:54 +0000 (08:50 +0300)]
Document 'startup-redirect-eln-cache'

* doc/lispref/compile.texi (Native Compilation)
(Native-Compilation Functions): Document
'startup-redirect-eln-cache'.

* etc/PROBLEMS: Fix last change.
* etc/NEWS: Mark 'startup-redirect-eln-cache' as documented.

18 months ago; * etc/PROBLEMS: Entry about crashes due to anti-virus (bug#57880).
Eli Zaretskii [Thu, 8 Jun 2023 05:30:18 +0000 (08:30 +0300)]
; * etc/PROBLEMS: Entry about crashes due to anti-virus (bug#57880).

18 months agoFix `emacs-lisp-native-compile-and-load' for C-h f (bug#58314)
Andrea Corallo [Tue, 6 Jun 2023 09:27:13 +0000 (11:27 +0200)]
Fix `emacs-lisp-native-compile-and-load' for C-h f (bug#58314)

* lisp/emacs-lisp/comp.el (comp-write-bytecode-file): New function
spilling code from `batch-byte+native-compile'.
(batch-byte+native-compile): Make use of.
* lisp/progmodes/elisp-mode.el
(emacs-lisp-native-compile-and-load): Produce the elc file and ask
to have it loaded.

18 months agoAdd 'infer' as a keyword to typescript-ts-mode (bug#63880)
Theodor Thornhill [Tue, 6 Jun 2023 04:26:43 +0000 (06:26 +0200)]
Add 'infer' as a keyword to typescript-ts-mode (bug#63880)

* lisp/progmodes/typescript-ts-mode.el (typescript-ts-mode--keywords):
New keyword.

18 months ago; * etc/NEWS: Mention the issue with PGTK on WSL (bug#63384).
Eli Zaretskii [Mon, 5 Jun 2023 11:50:00 +0000 (14:50 +0300)]
; * etc/NEWS: Mention the issue with PGTK on WSL (bug#63384).

18 months agoRevert changes to the order in which package descs are loaded
Philip Kaludercic [Sun, 4 Jun 2023 13:21:04 +0000 (15:21 +0200)]
Revert changes to the order in which package descs are loaded

* lisp/emacs-lisp/package.el (package-load-all-descriptors):  Remove
NOSORT argument to 'directory-files', reverting back to the behaviour
as of Emacs 28.  (Bug#63757)

18 months ago; * etc/NEWS: Improve instructions for grammar libraries.
Eli Zaretskii [Sun, 4 Jun 2023 07:57:07 +0000 (10:57 +0300)]
; * etc/NEWS: Improve instructions for grammar libraries.

18 months agoHandle point in last file-name component in minibuffer completion
Spencer Baugh [Sat, 3 Jun 2023 00:57:32 +0000 (20:57 -0400)]
Handle point in last file-name component in minibuffer completion

This is a followup to commit e338a8ac41d4a9fd798dda90275abe75ac071335
(Handle point not at EOB in minibuffer-choose-completion).
That commit added a heuristic, but the heuristic was insufficient:
It still had the original wrong behavior when completing the last
file-name component (i.e., the completion category is 'file' and
there's no slash after point).  This patch makes the heuristic
cover that case as well.
* lisp/minibuffer.el (minibuffer-next-completion)
(minibuffer-choose-completion): If in file completion and there's no
slash after point, clear what's after point when we complete.
(Bug#62700)

18 months agoMerge branch 'emacs-29' of git.savannah.gnu.org:/srv/git/emacs into emacs-29
Eli Zaretskii [Sat, 3 Jun 2023 16:22:22 +0000 (19:22 +0300)]
Merge branch 'emacs-29' of git.savannah.gnu.org:/srv/git/emacs into emacs-29

18 months agoAvoid asking redundant question in emacsbug.el
Eli Zaretskii [Sat, 3 Jun 2023 16:20:23 +0000 (19:20 +0300)]
Avoid asking redundant question in emacsbug.el

* lisp/mail/emacsbug.el (report-emacs-bug-hook): Don't ask the
question about saving email setup if we cannot save it anyway.
(Bug#63816)

18 months ago* test/infra/Dockerfile.emba (emacs-base): Don't install gawk.
Michael Albinus [Sat, 3 Jun 2023 15:52:46 +0000 (17:52 +0200)]
* test/infra/Dockerfile.emba (emacs-base): Don't install gawk.

18 months agotypescript-ts-mode: Add a rule for function_signature
Dmitry Gutov [Sat, 3 Jun 2023 12:00:41 +0000 (15:00 +0300)]
typescript-ts-mode: Add a rule for function_signature

* lisp/progmodes/typescript-ts-mode.el
(typescript-ts-mode--font-lock-settings):
Add a rule for function_signature (bug#63867)

18 months ago* admin/unidata/emoji-zwj.awk: Avoid sprint buffer overflow
Mattias Engdegård [Sat, 3 Jun 2023 10:50:21 +0000 (12:50 +0200)]
* admin/unidata/emoji-zwj.awk: Avoid sprint buffer overflow

Some AWK implementations have a fixed buffer for sprintf; for mawk the
default size is 8192 bytes.  Hoist a string concatenation from
a sprintf call to avoid running into that limit.  See discussion at
https://lists.gnu.org/archive/html/emacs-devel/2023-06/msg00090.html .

(cherry picked from commit b5f17fe07c6624380ba8d0c7a400a6b89f225209)

18 months ago; Fix last change
Eli Zaretskii [Sat, 3 Jun 2023 08:34:11 +0000 (11:34 +0300)]
; Fix last change

* lisp/progmodes/rust-ts-mode.el
(rust-ts-mode--syntax-propertize): Doc fix.  (Bug#63708)

18 months agoFix apostrophe handling in rust-ts-mode and go-ts-mode (Bug#63708)
Йордан Миладинов [Fri, 26 May 2023 14:23:26 +0000 (17:23 +0300)]
Fix apostrophe handling in rust-ts-mode and go-ts-mode (Bug#63708)

* lisp/progmodes/rust-ts-mode.el (rust-ts-mode--syntax-propertize):
Treat apostrophes as strings if used to define character literals.
Treat LT and GT as pairs if used to define type parameters (formerly
they were treated as pairs only for type arguments).
* lisp/progmodes/go-ts-mode.el (go-ts-mode--syntax-table): Treat
apostrophes as strings if used to define rune literals.

Copyright-paperwork-exempt: yes

18 months ago* test/infra/Dockerfile.emba (emacs-base): Install also gawk.
Michael Albinus [Sat, 3 Jun 2023 07:54:52 +0000 (09:54 +0200)]
* test/infra/Dockerfile.emba (emacs-base): Install also gawk.

18 months agoFix 'python-util-clone-local-variables'
Eli Zaretskii [Sat, 3 Jun 2023 07:20:08 +0000 (10:20 +0300)]
Fix 'python-util-clone-local-variables'

* lisp/progmodes/python.el (python-util-clone-local-variables):
Avoid signaling an error when a local variable is unbound.
Patch by Ernesto Alfonso <erjoalgo@gmail.com>.  (Bug#63818)

18 months agoRevert "Enhance Python font-lock to support multilines"
kobarity [Fri, 2 Jun 2023 13:52:57 +0000 (22:52 +0900)]
Revert "Enhance Python font-lock to support multilines"

This reverts commit 4915ca5dd4245a909c046e6691e8d4a1919890c8.

We have found that there are performance issues when editing a large
file.  The issue can be reproduced as follows:

1. emacs -Q
2. Open large Python file (e.g. turtle.py in Python)
3. Near the top of the buffer, enter open paren and some characters.

The above commit extends the region to be font-locked using
`python-nav-end-of-statement'.  However, if there are unbalanced
parens, it may move point to the end of the buffer.  This causes
almost the entire buffer to be font-locked, which is not acceptable
for large files.

18 months agoFix typo in calc.texi
Eli Zaretskii [Sat, 3 Jun 2023 06:14:44 +0000 (09:14 +0300)]
Fix typo in calc.texi

* doc/misc/calc.texi (Programming Tutorial): Fix a typo.
Suggested by Vladimir Nikishkin <lockywolf@gmail.com>.

18 months agoUpdate to Transient v0.4.1
Jonas Bernoulli [Fri, 2 Jun 2023 21:26:45 +0000 (23:26 +0200)]
Update to Transient v0.4.1

18 months agoAvoid errors in 'delete-forward-char' deleting static compositions
Eli Zaretskii [Fri, 2 Jun 2023 12:42:42 +0000 (15:42 +0300)]
Avoid errors in 'delete-forward-char' deleting static compositions

* lisp/simple.el (delete-forward-char): Fix recognition of static
compositions.  (Bug#63837)

18 months agoMake VS-15 and VS-16 compositions work correctly
Robert Pluim [Fri, 2 Jun 2023 11:54:56 +0000 (13:54 +0200)]
Make VS-15 and VS-16 compositions work correctly

There is a conflict between forward matching and backward matching
composition rules involving the same codepoint, which can cause the
backward matching ones not to be invoked.  Ensure that VS-15 (U+FE0E)
and VS-16 (U+FE0F) are composed by forward matching rules instead in
order to avoid this issue.

* admin/unidata/emoji-zwj.awk: Add rules for CHAR+VS-15 and CHAR+VS-16.
* lisp/composite.el: remove backward matching rule for VS-15.  (Bug#63731)

18 months agoFix project-name for vc-aware backend in non-file buffers
Dmitry Gutov [Fri, 2 Jun 2023 02:10:15 +0000 (05:10 +0300)]
Fix project-name for vc-aware backend in non-file buffers

* lisp/progmodes/project.el (project-name): Make sure
project-vc-name is picked up from dir-locals in all
non-file-visiting buffers too (mentioned in bug#63469).

18 months ago; Fix 'package-install-upgrade-built-in' check for package menu
Philip Kaludercic [Sat, 27 May 2023 08:13:21 +0000 (10:13 +0200)]
; Fix 'package-install-upgrade-built-in' check for package menu

* lisp/emacs-lisp/package.el (package-menu--find-upgrades): Use
correct check to verify if a built-in packages in the package menu can
be upgraded or not.

This change improves upon a faulty assumption from
ba2c76fa2bc3aabfda7d1d09cc5148f3f9d8e08e.  (Bug#63587)

18 months agoAdd type_predicate 'is' as keyword in typescript-ts-mode (bug#63810)
Theodor Thornhill [Wed, 31 May 2023 18:47:06 +0000 (20:47 +0200)]
Add type_predicate 'is' as keyword in typescript-ts-mode (bug#63810)

* lisp/progmodes/typescript-ts-mode.el (typescript-ts-mode--keywords):
New keyword 'is'.

18 months agoFix infloop in info-look.el
Eli Zaretskii [Wed, 31 May 2023 14:50:53 +0000 (17:50 +0300)]
Fix infloop in info-look.el

* lisp/info-look.el (info-lookup-guess-gdb-script-symbol): Fix
infloop when there are no completions.  (Bug#63808)

18 months agoFix several todo-mode.el item editing bugs (bug#63811)
Stephen Berman [Wed, 31 May 2023 14:15:48 +0000 (16:15 +0200)]
Fix several todo-mode.el item editing bugs (bug#63811)

* lisp/calendar/todo-mode.el (todo-insert-item--basic): With
insertion type 'here', ensure item is inserted on the todo-mode
line where the command was invoked.
(todo-edit-item--cat, todo-edit-item--pos): New variables.
(todo-edit-item--text): Restrict the scope of nil-valued
buffer-read-only to the functions that change buffer text.  If
user moved point while editing a single-line todo item or a done
item comment, or while inserting a done item comment, restore
point, and for comments, make sure the done items section is
displayed.  For multiline items, set the new variables so
todo-edit-quit can use them.
(todo-edit-quit): Use the values of the new variables to restore
point in the todo-mode buffer if it had been moved while editing.
(todo-edit-item--header): Avoid clobbering match data when editing
a todo item header.

18 months agodockerfile-ts-mode: Prevent empty categories in imenu (Bug#63759)
Randy Taylor [Sun, 28 May 2023 00:52:37 +0000 (20:52 -0400)]
dockerfile-ts-mode: Prevent empty categories in imenu (Bug#63759)

* lisp/progmodes/dockerfile-ts-mode.el (dockerfile-ts-mode--imenu):
Don't include empty categories.

18 months agoBrush up doc strings and terminology in plstore.el
Jens Schmidt [Mon, 22 May 2023 19:47:13 +0000 (21:47 +0200)]
Brush up doc strings and terminology in plstore.el

* lisp/plstore.el (plstore-encoded, plstore-passphrase-callback-function)
(plstore--init-from-buffer, plstore-revert, plstore-close)
(plstore--merge-secret, plstore--decrypt, plstore--match, plstore-find)
(plstore-get, plstore-put, plstore-delete, plstore--insert-buffer)
(plstore-save, plstore--encode, plstore--decode)
(plstore--write-contents-functions, plstore-mode-decoded)
(plstore-mode): Brush up doc strings and documentation in general.
Fix terminology, in particular spurious occurences of all uppercase
"PLSTORE".  (Bug#63627)

18 months agoAdd internal documentation on plstore.el
Jens Schmidt [Sun, 21 May 2023 19:37:35 +0000 (21:37 +0200)]
Add internal documentation on plstore.el

* lisp/plstore.el: Add internal documentation and some words of
warning in the user documentation.  (Bug#63627)

18 months agoAdd compact_constructor_declaration font-locking to java-ts-mode
Theodor Thornhill [Tue, 30 May 2023 13:29:38 +0000 (15:29 +0200)]
Add compact_constructor_declaration font-locking to java-ts-mode

* lisp/progmodes/java-ts-mode.el (java-ts-mode--font-lock-settings):
New pattern.

18 months ago* lisp/tmm.el (tmm-completion-delete-prompt): Add more checks (bug#63754).
Juri Linkov [Mon, 29 May 2023 17:34:53 +0000 (20:34 +0300)]
* lisp/tmm.el (tmm-completion-delete-prompt): Add more checks (bug#63754).

In case when 'completions-header-format' is nil, the first 'mouse-face'
property is at the beginning of the buffer.  So first use 'get-text-property'
at point-min.

18 months agoAllow to disable the DWIMish behavior of 'x' in package menu
Eli Zaretskii [Mon, 29 May 2023 13:44:48 +0000 (16:44 +0300)]
Allow to disable the DWIMish behavior of 'x' in package menu

* lisp/emacs-lisp/package.el
(package-menu-use-current-if-no-marks): New defcustom.
(package-menu-execute): Use it.  (Bug#62563)

* etc/NEWS: Announce the new option.

18 months agoAllow dired to invoke secondary browser
Robert Pluim [Tue, 25 Apr 2023 10:28:47 +0000 (12:28 +0200)]
Allow dired to invoke secondary browser

'browse-url-of-dired-file' always invokes the primary browser, but
sometimes it's handy to call a different browser, which is why
'browse-url-secondary-browser-function' exists.

* lisp/net/browse-url.el (browse-url-of-dired-file): Call
'browse-url-secondary-browser-function' when invoked with a prefix
argument.
* etc/NEWS: Announce the change.