]> git.eshelyaron.com Git - emacs.git/log
emacs.git
2 years agoImprove scheme-mode syntax-rules indentation
Lars Ingebrigtsen [Mon, 6 Jun 2022 13:32:03 +0000 (15:32 +0200)]
Improve scheme-mode syntax-rules indentation

* lisp/progmodes/scheme.el (syntax-rules): Indent syntax-rules
with a parameter better (bug#40869).

2 years agoImprove find-sibling-file error reporting
Lars Ingebrigtsen [Mon, 6 Jun 2022 12:34:41 +0000 (14:34 +0200)]
Improve find-sibling-file error reporting

* lisp/files.el (find-sibling-file): Improve error reporting.

2 years agoUpdate comments in X error handling code
Po Lu [Mon, 6 Jun 2022 12:23:20 +0000 (20:23 +0800)]
Update comments in X error handling code

* src/xterm.c (struct x_error_message_stack, x_error_message)
(x_error_catcher, x_catch_errors, x_had_errors_p)
(x_clear_errors): Long-overdue comment update.  Describe the
fields of the error message stack, and the fact that
`x_error_message' is a stack, not a pointer to a string (which
has been true since 2006).  Also describe the updated conditions
used to find an applicable error handler and to call
x_uncatch_errors_after_check.

2 years agoAdd drag-and-drop API tests
Po Lu [Mon, 6 Jun 2022 11:51:47 +0000 (19:51 +0800)]
Add drag-and-drop API tests

* test/lisp/dnd-tests.el: New file.
(dnd-tests-begin-text-drag):
(dnd-tests-begin-file-drag):
(dnd-tests-begin-drag-files): New tests.

2 years agoImprove handling of remote files during drag-and-drop
Po Lu [Mon, 6 Jun 2022 11:05:36 +0000 (19:05 +0800)]
Improve handling of remote files during drag-and-drop

* lisp/dnd.el (dnd-begin-drag-files): Don't fail if one remote
file couldn't be downloaded.

2 years agoTest warning suppressions with lexical binding
Mattias Engdegård [Mon, 6 Jun 2022 08:47:42 +0000 (10:47 +0200)]
Test warning suppressions with lexical binding

* test/lisp/emacs-lisp/bytecomp-tests.el
(test-byte-comp-compile-and-load): Add lexical cookie to file being
compiled as part of the test.
(bytecomp-test--with-suppressed-warnings): Comment out the test
for suppressing warnings when attempting to let-bind `nil`,
as that (1) doesn't work and (2) is a silly thing to do anyway.

2 years agoFix several more issues with running Lisp during drag-and-drop
Po Lu [Mon, 6 Jun 2022 08:01:41 +0000 (16:01 +0800)]
Fix several more issues with running Lisp during drag-and-drop

* src/xterm.c (handle_one_xevent): Fix _NET_WM_PING cycle again
and set mouse_moved flags during drag-and-drop so reading mouse
events from Lisp continues to work.

2 years agoSignal an error XdndSelection was lost during drag-and-drop
Po Lu [Mon, 6 Jun 2022 04:48:40 +0000 (12:48 +0800)]
Signal an error XdndSelection was lost during drag-and-drop

* src/xselect.c (x_handle_selection_clear): Signal an error if
ownership of XdndSelection was lost during drag-and-drop.

2 years agoMake mouse input work properly inside the debugger during DND
Po Lu [Mon, 6 Jun 2022 04:33:41 +0000 (12:33 +0800)]
Make mouse input work properly inside the debugger during DND

* src/xterm.c (x_dnd_begin_drag_and_drop): Set
`x_dnd_recursion_depth'.
(handle_one_xevent): If the recursive edit level is higher than
when DND started, handle mouse events normally.

2 years agocl-typep: Emit warning when using a type not known to be a type
Stefan Monnier [Mon, 6 Jun 2022 04:04:00 +0000 (00:04 -0400)]
cl-typep: Emit warning when using a type not known to be a type

`cl-typep` has used a heuristic that if there's a `<foo>-p` function,
then <foo> can be used as a type.  This made sense in the past where
most types were not officially declared to be (cl-)types, but nowadays
this just encourages abuses such as using `cl-typecase` with
"types" like `fbound`.  It's also a problem for EIEIO objects, where
for historical reasons `<foo>-p` tests if the object is of type
exactly `<foo>` whereas (cl-typep OBJ <foo>) should instead test
if OBJ is a *subtype* of `<foo>`.

So we change `cl-typep` to emit a warning whenever this "-p" heuristic
is used, to discourage abuses, encourage the use of explicit
`cl-deftype` declarations, and try and detect some misuses of
`<foo>-p` for EIEIO objects.

* lisp/emacs-lisp/eieio.el (defclass): Define as type not only at
run-time but also for the current compilation unit.

* lisp/emacs-lisp/eieio-core.el (class, eieio-object): Define as types.

* lisp/emacs-lisp/cl-preloaded.el (cl-struct-define): Don't abuse the
"-p" heuristic.

* lisp/emacs-lisp/cl-macs.el (cl-deftype-satisfies):
Add entries for frames, windows, markers, and overlays.
(cl-typep): Emit a warning when using a predicate that is not known to
correspond to a type.

* lisp/files.el (file-relative-name): Fix error that can trigger if
there's an(other) error between loading `files.el` and loading
`minibuffer.el`.

2 years agoRework X selections to make it safe to run the debugger inside converters
Po Lu [Mon, 6 Jun 2022 03:08:19 +0000 (11:08 +0800)]
Rework X selections to make it safe to run the debugger inside converters

* src/keyboard.c (prev_kbd_event): Delete function.
(readable_events): Return 1 if
x_detect_pending_selection_requests returns true.
(kbd_buffer_unget_event): Also delete function, since nested
selection requests are really handled correctly.
(kbd_buffer_get_event): Handle events from the special X
deferred selection queue as well.

* src/keyboard.h: Update prototypes.

* src/xselect.c (struct selection_event_queue)
(selection_input_event_equal, x_queue_event)
(x_start_queuing_selection_requests)
(x_stop_queuing_selection_requests): Delete structs, since they
are no longer required.
(x_handle_selection_request, x_handle_selection_event): Allow
nested selection events.

* src/xterm.c (struct x_selection_request_event): New struct.
(x_handle_pending_selection_requests_1)
(x_handle_pending_selection_requests): Handle all events in the
new selection event queue.
(x_push_selection_request, x_detect_pending_selection_requests):
New functions.
(x_dnd_begin_drag_and_drop): Drain the selection queue here as
well.
(handle_one_xevent): When inside a nested event loop, just push
selections to that queue.
(XTread_socket): Allow reading X events if x_dnd_unwind_flag is
true, even though DND is in progress.
(x_delete_display): Delete pending selection events for the
display that is going away.

* src/xterm.h: Update prototypes.

2 years agopcomplete.el: Fix part of bug#50470
Stefan Monnier [Sun, 5 Jun 2022 23:51:29 +0000 (19:51 -0400)]
pcomplete.el: Fix part of bug#50470

Try and handle the case where `pcomplete-parse-arguments-function`
directly returns a list of completions.

* lisp/pcomplete.el (pcomplete-parse-arguments): Don't modify the
buffer if we're not allowed to.  Instead use the buffer's current
content as the "pattern to be completed" and return the list
of completions as is.  Also, use `try-completions` to simplify the
previous code.

2 years agoAdd nohandle-guide images for tree-widget
Lars Ingebrigtsen [Sun, 5 Jun 2022 22:42:56 +0000 (00:42 +0200)]
Add nohandle-guide images for tree-widget

These are copies of the guide.* files

2 years agoRe-re-fix previous describe-function change
Lars Ingebrigtsen [Sun, 5 Jun 2022 20:52:59 +0000 (22:52 +0200)]
Re-re-fix previous describe-function change

* lisp/help-fns.el (describe-function): Put back binding removed
by mistake in previous change.

2 years agoFix key binding buffer issue in describe-function better
Lars Ingebrigtsen [Sun, 5 Jun 2022 20:48:28 +0000 (22:48 +0200)]
Fix key binding buffer issue in describe-function better

* lisp/help-fns.el (describe-function): Revert previous change here.
(describe-function-1): Just use describe-function-orig-buffer
instead of the key-buffer binding -- this will also make the
rendering results correct when hitting `g' and `l'.

2 years agoClarify syntax-ppss doc string
Lars Ingebrigtsen [Sun, 5 Jun 2022 20:37:32 +0000 (22:37 +0200)]
Clarify syntax-ppss doc string

* lisp/emacs-lisp/syntax.el (syntax-ppss): Clarify doc string.

2 years agoSimplify set-goal-column
Lars Ingebrigtsen [Sun, 5 Jun 2022 20:29:08 +0000 (22:29 +0200)]
Simplify set-goal-column

* lisp/simple.el (set-goal-column): Simplify the code.

2 years agoMake `C-h f' look up key bindings in the current buffer again
Lars Ingebrigtsen [Sun, 5 Jun 2022 19:48:21 +0000 (21:48 +0200)]
Make `C-h f' look up key bindings in the current buffer again

* lisp/help-fns.el (describe-function): Pass in the correct buffer
to look up key bindings in.
(describe-function-1): Use it.

2 years agoMake the goal column work for the scrolling commands, too
Lars Ingebrigtsen [Sun, 5 Jun 2022 19:35:56 +0000 (21:35 +0200)]
Make the goal column work for the scrolling commands, too

* doc/emacs/basic.texi (Moving Point): Document it.
* lisp/simple.el (set-goal-column): Update doc string.

* lisp/window.el (scroll-up-command, scroll-down-command): Make
the goal column take effect for these commands, too (bug#17346).

2 years agoMove two more variables from autoload.el to loaddefs-gen.el
Lars Ingebrigtsen [Sun, 5 Jun 2022 18:32:01 +0000 (20:32 +0200)]
Move two more variables from autoload.el to loaddefs-gen.el

* lisp/emacs-lisp/loaddefs-gen.el (generated-autoload-file)
(generated-autoload-load-name): Move the remaining two autoload.el
variables used by loaddefs-gen.el from autoload.el.

2 years agoMake finder/cus-dep scraping use generate-lisp-file functions
Lars Ingebrigtsen [Sun, 5 Jun 2022 18:17:30 +0000 (20:17 +0200)]
Make finder/cus-dep scraping use generate-lisp-file functions

* lisp/finder.el (finder-compile-keywords):
* lisp/cus-dep.el (custom-make-dependencies): Use
generate-lisp-file functions directly instead of piggy-backing on
the autoload.el functions.  (This is part of making autoload.el obsolete.)

2 years agoDon't generate separate autoload file for htmlfontify
Stefan Kangas [Sun, 5 Jun 2022 16:23:17 +0000 (18:23 +0200)]
Don't generate separate autoload file for htmlfontify

* lisp/hfy-cmap.el: Update file local to no longer put htmlfontify
autoloads in htmlfontify-loaddefs.el.
* lisp/htmlfontify.el (htmlfontify-loaddefs): Don't require.
* test/lisp/htmlfontify-tests.el (htmlfontify-autoload): Delete
test (bug#52400).

2 years agoRename generate-file to generate-lisp-file
Lars Ingebrigtsen [Sun, 5 Jun 2022 15:48:29 +0000 (17:48 +0200)]
Rename generate-file to generate-lisp-file

* lisp/url/url-cookie.el (url-cookie-write-file):
* lisp/international/titdic-cnv.el (tit-process-header)
(miscdic-convert):
* lisp/international/ja-dic-cnv.el (skkdic-convert):
* lisp/international/emoji.el (emoji--generate-file):
* lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--rubric):
* admin/unidata/unidata-gen.el (unidata-gen-file)
(unidata-gen-charprop): Adjust callers.

* lisp/emacs-lisp/generate-lisp-file.el: Renamed from
generate-file.el.  Also rename some keyword parameters and require
a generator function.

2 years ago; * etc/NEWS: Fix wording of entry about 'file-expand-wildcards'.
Eli Zaretskii [Sun, 5 Jun 2022 14:53:43 +0000 (17:53 +0300)]
; * etc/NEWS: Fix wording of entry about 'file-expand-wildcards'.

2 years agoAdd convenience functions for generating Emacs Lisp files
Lars Ingebrigtsen [Sun, 5 Jun 2022 14:36:25 +0000 (16:36 +0200)]
Add convenience functions for generating Emacs Lisp files

* lisp/url/url-cookie.el (url-cookie-write-file):
* lisp/international/titdic-cnv.el (tit-process-header):
* lisp/international/ja-dic-cnv.el (skkdic-convert):
* lisp/international/emoji.el (emoji--generate-file):
* lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--rubric)

* admin/unidata/unidata-gen.el (unidata-gen-file)
(unidata-gen-charprop): Use the new functions.

* lisp/emacs-lisp/generate-file.el: New file to provide
convenience functions for generated files.  It's not always
trivial to know which parts of the trailer that has to be
obfuscated to avoid not getting byte-compiled etc, and some parts
of the headers/trailers are usually forgotten when hand-coding
these.

2 years ago; * lisp/international/fontset.el (setup-default-fontset): Fix comment.
Eli Zaretskii [Sun, 5 Jun 2022 14:08:49 +0000 (17:08 +0300)]
; * lisp/international/fontset.el (setup-default-fontset): Fix comment.

2 years agoAdd a fallback font for Tamil Supplement characters
समीर सिंह Sameer Singh [Sun, 5 Jun 2022 11:39:40 +0000 (17:09 +0530)]
Add a fallback font for Tamil Supplement characters

* lisp/international/fontset.el (setup-default-fontset): Add
and entry for "Noto Sans Tamil Supplement".  (Bug#55807)

2 years agoMake the Unicode tree widget prettier
JD Smith [Sun, 5 Jun 2022 13:59:37 +0000 (15:59 +0200)]
Make the Unicode tree widget prettier

* lisp/tree-widget.el (tree-widget-nohandle-guide): New widget:
"One small change is needed to accommodate this
style. `tree-widget-guide’ specifies a single vertical bar “guide”
widget. In the unicode tree, two separate vertical bars are needed
— one “plain” (│), and one which connects to the horizontal
“handle” preceding the node (├)."
(tree-widget--cursors):
(tree-widget):
(tree-widget-value-create): Use it.

Copyright-paperwork-exempt: yes

2 years agoAdd new command find-sibling-file
Lars Ingebrigtsen [Sun, 5 Jun 2022 13:43:38 +0000 (15:43 +0200)]
Add new command find-sibling-file

* doc/emacs/files.texi (Visiting): Document it.
* lisp/files.el (file-expand-wildcards): Fix up the regexp expansion.
(find-sibling-rules, find-sibling-file): New user option and command.
(find-sibling-file--search): New helper function.

2 years agoFix file name encoding of Motif drop protocol file selections
Po Lu [Sun, 5 Jun 2022 13:16:09 +0000 (21:16 +0800)]
Fix file name encoding of Motif drop protocol file selections

* lisp/select.el (xselect-convert-to-filename):
(xselect-convert-to-dt-netfile): Encode in the file name coding
system instead of `raw-text-unix'.

2 years agoExtend file-expand-wildcards to allow regexps
Lars Ingebrigtsen [Sun, 5 Jun 2022 12:08:31 +0000 (14:08 +0200)]
Extend file-expand-wildcards to allow regexps

* doc/lispref/files.texi (Contents of Directories): Document it.
* lisp/files.el (file-expand-wildcards): Extend to allow regexps.

* lisp/emacs-lisp/shortdoc.el (file): Expand the
file-expand-wildcards example.

2 years agoFix drag-and-drop of files with multibyte filenames
Po Lu [Sun, 5 Jun 2022 07:34:49 +0000 (15:34 +0800)]
Fix drag-and-drop of files with multibyte filenames

* lisp/dired.el (dired-mouse-drag): Fix re-signalling of errors.

* lisp/select.el (xselect-convert-to-filename):
(xselect-convert-to-text-uri-list):
(xselect-convert-to-dt-netfile): Encode in raw-text-unix.

* src/xgselect.c (suppress_xg_select, release_xg_select): New
functions.
(xg_select): Respect xg_select suppression by delegating to
pselect.
* src/xgselect.h: Update prototypes.

* src/xterm.c (x_dnd_begin_drag_and_drop): Suppress xg_select
during the nested event loop.
(handle_one_xevent): Handle cases where hold_quit is nil inside
a selection event handler during DND.

2 years agoFix sorting in ls-lisp.el under -v
Eli Zaretskii [Sun, 5 Jun 2022 06:52:09 +0000 (09:52 +0300)]
Fix sorting in ls-lisp.el under -v

* lisp/ls-lisp.el (ls-lisp-version-lessp): Handle correctly the
case where strings begin with numerical parts.  More faithful
implementation of the 'strverscmp' spec for fractional parts.
(Bug#55787)

* test/lisp/ls-lisp-tests.el (ls-lisp-test-bug55787): New test.

2 years agoFix bug#55779
Po Lu [Sun, 5 Jun 2022 05:03:55 +0000 (13:03 +0800)]
Fix bug#55779

* src/xterm.c (x_update_opaque_region): Don't make GTK reset the
opaque region if F is a child frame.

2 years agoBetter respect window manager stacking order
Po Lu [Sun, 5 Jun 2022 05:02:58 +0000 (13:02 +0800)]
Better respect window manager stacking order

* src/xfns.c (x_frame_list_z_order, Fx_frame_list_z_order): Use
_NET_CLIENT_LIST_STACKING if supported.
* src/xterm.c (x_wm_supports_1): New function.  Accept dpyinfo
instead of frame.
(x_wm_supports): Use that function instead.

* src/xterm.h: Update prototypes.

2 years agoMerge from origin/emacs-28
Stefan Kangas [Sun, 5 Jun 2022 04:30:25 +0000 (06:30 +0200)]
Merge from origin/emacs-28

1b8719835a Update to Org 9.5.4
92c5faafd7 Clarify documentation of 'string-to-unibyte'
2848512654 ; * lisp/files.el (find-file): Avoid too short lines in do...
672f9f787f Improve keystrokes in doc strings in some find-file functions
ef5651cc77 Fix segfaults when starting on 80x26 TTY frames
bfa647972f ; Fix doc string of 'delete-selection-repeat-replace-region'
a95d46e00f Make it explicit that a couple of _s in lispref are unders...
5c74c25123 Remove from FAQ the MS-Windows info about BDF fonts
edb48646f2 Fix Display Property manual example

2 years agoFix positioning of non-system tooltips on GTK builds
Po Lu [Sun, 5 Jun 2022 02:02:55 +0000 (10:02 +0800)]
Fix positioning of non-system tooltips on GTK builds

* src/xfns.c (compute_tip_xy): Fix coding style.
* src/xterm.c (handle_one_xevent): Set tooltip size immediately
on GTK builds.

2 years agoAdjust last change for GTK+ 2.x
Po Lu [Sun, 5 Jun 2022 01:30:45 +0000 (09:30 +0800)]
Adjust last change for GTK+ 2.x

* src/xterm.c (x_tooltip_window_to_frame): Fix build on GTK 2.x.

2 years agoMake `mouse-position' work correctly with GTK tooltips
Po Lu [Sun, 5 Jun 2022 01:24:20 +0000 (09:24 +0800)]
Make `mouse-position' work correctly with GTK tooltips

* src/xterm.c (x_tooltip_window_to_frame): New parameter
`unrelated_tooltip_p'.
(XTmouse_position): Pass that, and if it turns out to be true,
look beneath the tooltip window.

2 years agoUpdate to Org 9.5.4
Kyle Meyer [Sat, 4 Jun 2022 20:21:06 +0000 (16:21 -0400)]
Update to Org 9.5.4

2 years agoMake loaddefs-generate--parse-file more robust
Lars Ingebrigtsen [Sat, 4 Jun 2022 16:41:10 +0000 (18:41 +0200)]
Make loaddefs-generate--parse-file more robust

* lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file):
Ensure that we don't have an autoload cookie on the first column
inside a string.

2 years agoMake skkdic-convert replacements literal
Lars Ingebrigtsen [Sat, 4 Jun 2022 13:07:01 +0000 (15:07 +0200)]
Make skkdic-convert replacements literal

* lisp/international/ja-dic-cnv.el (skkdic-convert): The
replacement is literal and fixed-case.  (The build on EMBA is
failing mysteriously with "Match data clobbered by buffer
modification hooks", so this is mainly a stab in the dark at
fixing that, but it's also generally correct.)

2 years agoMake vc-mtn obsolete
Lars Ingebrigtsen [Sat, 4 Jun 2022 12:16:26 +0000 (14:16 +0200)]
Make vc-mtn obsolete

* lisp/obsolete/vc-mtn.el: Make obsolete (bug#6513).

2 years agoFix failing shortdoc test
Lars Ingebrigtsen [Sat, 4 Jun 2022 12:04:41 +0000 (14:04 +0200)]
Fix failing shortdoc test

* lisp/emacs-lisp/shortdoc.el (string): Each example section is
supposed to contain only examples of using the function in
question (as policed by the FAILED  shortdoc-examples test).

2 years agoFix error during DND from both Emacs and GTK at the same time
Po Lu [Sat, 4 Jun 2022 12:00:40 +0000 (20:00 +0800)]
Fix error during DND from both Emacs and GTK at the same time

* src/xterm.c (x_dnd_get_target_window): Make mapping and
releasing the COW atomic.  This is to fix a rare bug when
MPX (multi-pointer X) is in use and the user tries to drag
from both GTK and Emacs at the same time using multiple seats.

2 years agoFurther raise-sexp doc string improvement
Lars Ingebrigtsen [Sat, 4 Jun 2022 12:00:10 +0000 (14:00 +0200)]
Further raise-sexp doc string improvement

* lisp/emacs-lisp/lisp.el (raise-sexp): Fix the key binding syntax
in the doc string.

2 years agoImprove the raise-sexp doc string
Lars Ingebrigtsen [Sat, 4 Jun 2022 11:57:08 +0000 (13:57 +0200)]
Improve the raise-sexp doc string

* lisp/emacs-lisp/lisp.el (raise-sexp): Try to explain what the
command does (bug#55788).

2 years agoFix warnings introduced by the lisp-mode-autoload-regexp change
Lars Ingebrigtsen [Sat, 4 Jun 2022 11:50:07 +0000 (13:50 +0200)]
Fix warnings introduced by the lisp-mode-autoload-regexp change

* lisp/emacs-lisp/lisp-mode.el (lisp-fdefs): The package name bit
in ###;;;foo-autoload may be missing, so do a lax match (bug#55784).

2 years agoAdd a face to \\= doc string escapes
Lars Ingebrigtsen [Sat, 4 Jun 2022 11:43:58 +0000 (13:43 +0200)]
Add a face to \\= doc string escapes

* lisp/emacs-lisp/lisp-mode.el (lisp-fdefs): Add a face to \\= doc
string escapes (bug#55783).

2 years agoFurther notes about quotation marks in the manual
Lars Ingebrigtsen [Sat, 4 Jun 2022 11:29:53 +0000 (13:29 +0200)]
Further notes about quotation marks in the manual

* doc/lispref/tips.texi (Documentation Tips): Note that we
previously recommended using single quotation marks (bug#55780).

2 years agoAllow keyboard modifiers to control the action taken during dired DND
Po Lu [Sat, 4 Jun 2022 10:07:20 +0000 (18:07 +0800)]
Allow keyboard modifiers to control the action taken during dired DND

* doc/emacs/dired.texi (Misc Dired Features): Update
documentation.
* lisp/dired.el (dired-mouse-drag-files): Update defcustom for
new values.
(dired-mouse-drag): Recognize more values of
`dired-mouse-drag-files' and keyboard modifiers.
(dired-mouse-drag-files-map): Add C-down-mouse-1, M-down-mouse-1
and S-down-mouse-1.

2 years ago* lisp/emacs-lisp/shortdoc.el (string): Add `string-collate-lessp'.
Michael Albinus [Sat, 4 Jun 2022 09:23:53 +0000 (11:23 +0200)]
* lisp/emacs-lisp/shortdoc.el (string): Add `string-collate-lessp'.

2 years agoAdd support for the Grantha script (bug#55782)
समीर सिंह Sameer Singh [Wed, 1 Jun 2022 16:59:24 +0000 (22:29 +0530)]
Add support for the Grantha script (bug#55782)

* lisp/language/indian.el ("Grantha"): New language environment.
Add composition rules for Grantha. Add sample text and input method.
* lisp/international/fontset.el (script-representative-chars)
(setup-default-fontset): Support Grantha.
* lisp/leim/quail/indian.el ("grantha"): New input method.

* etc/HELLO: Add two Grantha greetings.
* etc/NEWS: Announce the new language environment.

2 years agoFix file drag-and-drop on GNUstep
Po Lu [Sat, 4 Jun 2022 08:19:01 +0000 (16:19 +0800)]
Fix file drag-and-drop on GNUstep

* src/nsselect.m (ns_decode_data_to_pasteboard): Convert URL to
path names when we're using NSFilenamesPboardType.
* src/nsterm.m: ([EmacsView performDragOperation:]): Handle
cases where plist is a string.

2 years agoSupport dragging multiple files on NS
Po Lu [Sat, 4 Jun 2022 07:45:41 +0000 (15:45 +0800)]
Support dragging multiple files on NS

This has to use a deprecated pasteboard type, since Emacs uses
the "old" (but not deprecated) dragImage: method for
drag-and-drop, which can't drop file URLs.

* lisp/term/ns-win.el (x-begin-drag): Update accordingly.
* src/nsselect.m (ns_decode_data_to_pasteboard):
(Fns_begin_drag): Allow files to be a list of filenames as well.

2 years agoFix splurious drag-mouse-1 events after NS drag-and-drop
Po Lu [Sat, 4 Jun 2022 07:41:39 +0000 (15:41 +0800)]
Fix splurious drag-mouse-1 events after NS drag-and-drop

* src/nsterm.m ([EmacsWindow beginDrag:...]): Clear
dpyinfo->grabbed.

2 years agoClear mouse face during drag-and-drop
Po Lu [Sat, 4 Jun 2022 07:17:50 +0000 (15:17 +0800)]
Clear mouse face during drag-and-drop

* src/xterm.c (handle_one_xevent): Clear mouse face during drag
and drop, since note_mouse_highlight isn't called.

2 years agoClarify documentation of 'string-to-unibyte'
Eli Zaretskii [Sat, 4 Jun 2022 07:06:43 +0000 (10:06 +0300)]
Clarify documentation of 'string-to-unibyte'

* doc/lispref/nonascii.texi (Converting Representations): Clarify
what 'string-to-unibyte' does.  Reported by Richard Hansen
<rhansen@rhansen.org>.  (Bug#55777)

2 years agoAnother attempt to void compiler warnings on macOS (bug#55595)
Eli Zaretskii [Sat, 4 Jun 2022 06:05:35 +0000 (09:05 +0300)]
Another attempt to void compiler warnings on macOS (bug#55595)

* configure.ac (WERROR_CFLAGS): Use "-Wno-unknown-pragmas" with
Clang.

2 years agoImprove doc of `mouse-drag-mode-line-buffer'
Po Lu [Sat, 4 Jun 2022 05:27:03 +0000 (13:27 +0800)]
Improve doc of `mouse-drag-mode-line-buffer'

* doc/emacs/frames.texi (Mouse Commands): Document
`mouse-drag-mode-line-buffer'.
* etc/NEWS: Explain where that option is supported.
* lisp/mouse.el (mouse-drag-mode-line-buffer): Likewise.

2 years agoMake XTmouse_position faster during dragging with lots of frames
Po Lu [Sat, 4 Jun 2022 04:27:11 +0000 (12:27 +0800)]
Make XTmouse_position faster during dragging with lots of frames

* src/xterm.c (x_tooltip_window_to_frame): New function.
(XTmouse_position): Use that to find tooltip frames underneath
the pointer instead.

2 years agoFix leak of toplevel data
Po Lu [Sat, 4 Jun 2022 02:05:44 +0000 (10:05 +0800)]
Fix leak of toplevel data

* src/xterm.c (x_dnd_compute_toplevels): Make sure to free
`data'.

2 years agoFix leak of DND toplevels when return-frame is non-nil
Po Lu [Sat, 4 Jun 2022 01:51:33 +0000 (09:51 +0800)]
Fix leak of DND toplevels when return-frame is non-nil

* src/xterm.c (x_dnd_free_toplevels): Don't leak DND toplevels
if returning a frame.
(x_dnd_begin_drag_and_drop): Make this function reentrant from
the IO error handler.

2 years agoPost-review additions
Dmitry Gutov [Sat, 4 Jun 2022 00:42:00 +0000 (03:42 +0300)]
Post-review additions

* lisp/progmodes/project.el (project-vc-include-untracked):
Add :version.
(project--vc-list-files): Use 'and' instead of 'when'.

2 years agoAdd new user option project-vc-include-untracked
Jan Synáček [Thu, 2 Jun 2022 18:59:53 +0000 (20:59 +0200)]
Add new user option project-vc-include-untracked

* doc/emacs/maintaining.texi (Projects): Document it.
* lisp/progmodes/project.el (project--vc-list-files): Use it.

2 years agoproject-query-replace-regexp: Filter out non-regular files
Dmitry Gutov [Sat, 4 Jun 2022 00:13:42 +0000 (03:13 +0300)]
project-query-replace-regexp: Filter out non-regular files

* lisp/progmodes/project.el (project-query-replace-regexp):
Filter out non-regular files (bug#55382).

2 years agoFix Tramp test
Michael Albinus [Fri, 3 Jun 2022 17:55:30 +0000 (19:55 +0200)]
Fix Tramp test

* test/lisp/net/tramp-tests.el (tramp-test31-signal-process):
Skip on MS Windows.

2 years agoAdd remote file functions to shortdoc
Michael Albinus [Fri, 3 Jun 2022 17:54:31 +0000 (19:54 +0200)]
Add remote file functions to shortdoc

* lisp/net/tramp-integration.el (shortdoc-add-function)
(shortdoc--groups): Declare.
(shortdoc): Configure shortdoc.el to recognize file name functions
for remote access.

2 years agoFix dired drag and drop actions
Po Lu [Fri, 3 Jun 2022 12:36:24 +0000 (20:36 +0800)]
Fix dired drag and drop actions

* lisp/dired.el (dired-mouse-drag): Make `link' values work
again.

2 years agoHandle dragging multiple files on Haiku
Po Lu [Fri, 3 Jun 2022 12:13:27 +0000 (12:13 +0000)]
Handle dragging multiple files on Haiku

* lisp/term/haiku-win.el (haiku-dnd-selection-converters)
(haiku-dnd-convert-file-name, x-begin-drag): Handle vector
values of selection data.

2 years ago; Improve documentation of 'battery-update-functions'
Eli Zaretskii [Fri, 3 Jun 2022 12:04:42 +0000 (15:04 +0300)]
; Improve documentation of 'battery-update-functions'

* lisp/battery.el (battery-update-functions)
(display-battery-mode): Improve wording of doc strings.
(Bug#55770)

2 years ago; Improve documentation of new drag-and-drop APIs
Eli Zaretskii [Fri, 3 Jun 2022 11:50:11 +0000 (14:50 +0300)]
; Improve documentation of new drag-and-drop APIs

* lisp/dnd.el (dnd-begin-text-drag, dnd-begin-file-drag):
* doc/lispref/frames.texi (Drag and Drop): Improve wording of
documentation of 'dnd-begin-text-drag' and 'dnd-begin-file-drag'.

2 years agoAllow dragging multiple files from a Dired buffer
Po Lu [Fri, 3 Jun 2022 11:43:06 +0000 (19:43 +0800)]
Allow dragging multiple files from a Dired buffer

* doc/lispref/frames.texi (Drag and Drop): Document new function
`dnd-begin-drag-files'.
* lisp/dired.el (dired-mouse-drag-files): Update doc string.
(dired-map-over-marks): Accept a new value of ARG `marked',
meaning to not fall back to the current file if no marks were
found.
(dired-mouse-drag): Handle marked files in an intuitive way.

* lisp/dnd.el (dnd-last-dragged-remote-file): Allow list values
as well.
(dnd-remove-last-dragged-remote-file): Handle list values.
(dnd-begin-file-drag): Fix file name expansion.
(dnd-begin-drag-files): New function.
* lisp/select.el (xselect-convert-to-filename): Handle mutiple
files
(a vector of file names):.

2 years agoDon't issue warnings for Unicode quotes for now
Lars Ingebrigtsen [Fri, 3 Jun 2022 11:09:25 +0000 (13:09 +0200)]
Don't issue warnings for Unicode quotes for now

* lisp/emacs-lisp/bytecomp.el (byte-compile-docstring-style-warn):
Remove warning for "Unicode quotes" for now (bug#55780).

2 years agoRevert the `...' documentation back to actual usage
Lars Ingebrigtsen [Fri, 3 Jun 2022 11:04:13 +0000 (13:04 +0200)]
Revert the `...' documentation back to actual usage

* doc/lispref/tips.texi (Documentation Tips): Document how `...'
is really used now (bug#55780).  ‘...’ is not really used in the
Emacs sources.

2 years agoLet ?\LF signal an error (bug#55738)
Mattias Engdegård [Fri, 3 Jun 2022 08:12:24 +0000 (10:12 +0200)]
Let ?\LF signal an error (bug#55738)

As suggested by Stefan Monnier.

* src/lread.c (read_escape):
Signal an error for ?\LF since it cannot reasonably be intended.
* test/src/lread-tests.el (lread-escaped-lf): Update test.
* etc/NEWS: Announce.

2 years agoFix wrong value in idlwave-comment-indent-char
Mattias Engdegård [Fri, 3 Jun 2022 09:05:18 +0000 (11:05 +0200)]
Fix wrong value in idlwave-comment-indent-char

* lisp/progmodes/idlwave.el (idlwave-comment-indent-char):
Use a space since that is clearly what was meant.
?\ at the end of a line (ie, ?\LF) never was well-defined and produced
-1 most of the time, but will soon raise an error (bug#55738).
This doesn't matter much becaue this variable is unused.

2 years agoAdd new user option `mouse-drag-mode-line-buffer'
Po Lu [Fri, 3 Jun 2022 07:20:23 +0000 (15:20 +0800)]
Add new user option `mouse-drag-mode-line-buffer'

* etc/NEWS: Announce new option.  Also add missing entries for
an earlier change.
* lisp/mouse.el (mouse-drag-mode-line-buffer): New user option.
(mouse-drag-mode-line): Implement that option.

2 years agoAdd easier-to-use interfaces for initiating drag-and-drop
Po Lu [Fri, 3 Jun 2022 04:32:17 +0000 (12:32 +0800)]
Add easier-to-use interfaces for initiating drag-and-drop

The previous interface required that users know intricacies of
the data types used to transfer data on each platform Emacs
supports.

* doc/lispref/frames.texi (Drag and Drop): Document new
functions.
* lisp/dired.el (dired-last-dragged-remote-file)
(dired-remove-last-dragged-local-file): Delete functions.
(dired-mouse-drag): Use `dnd-begin-file-drag'.
* lisp/dnd.el (dnd-last-dragged-remote-file)
(dnd-remove-last-dragged-remote-file): New variables and
functions.
(dnd-begin-text-drag, dnd-begin-file-drag): New functions.
* src/xterm.c (x_dnd_begin_drag_and_drop): Add porting note.

2 years agoAdd a new user option battery-update-functions
Lars Ingebrigtsen [Fri, 3 Jun 2022 03:56:44 +0000 (05:56 +0200)]
Add a new user option battery-update-functions

* doc/emacs/display.texi (Optional Mode Line): Document it.
* lisp/battery.el (battery-update-functions): New user option
(bug#55770).
(battery-update): Use it.

2 years agoRemove window-max-characters-per-line
Lars Ingebrigtsen [Fri, 3 Jun 2022 03:20:16 +0000 (05:20 +0200)]
Remove window-max-characters-per-line

* doc/lispref/windows.texi (Window Sizes):
* doc/lispref/display.texi (Size of Displayed Text): Remove
documentation.
* lisp/fringe.el (fringe-mode): Point to the right function.

* lisp/window.el (window-char-pixel-width)
(window-char-pixel-height, window-max-characters-per-line): Remove
functions -- this was already added as window-max-chars-per-line.

* src/window.c (Fwindow_body_width): Adjust doc string.

2 years agoFix GTK build
Po Lu [Fri, 3 Jun 2022 01:43:42 +0000 (09:43 +0800)]
Fix GTK build

* src/xterm.c (x_dnd_begin_drag_and_drop) [USE_GTK]: Adjust call
to x_dnd_free_toplevels as well.

2 years agoDon't call XSelectInput on a dying display when cancelling drag-and-drop
Po Lu [Fri, 3 Jun 2022 00:51:49 +0000 (08:51 +0800)]
Don't call XSelectInput on a dying display when cancelling drag-and-drop

* src/xterm.c (x_dnd_free_toplevels): New argument
`display_alive'.
(x_dnd_cleanup_drag_and_drop, x_dnd_begin_drag_and_drop)
(handle_one_xevent): Change calls to `x_dnd_free_toplevels'.
(x_connection_closed, x_delete_terminal): Set it to false.

2 years agoMake checkdoc-file-comments-engine match more ;;;### forms
Lars Ingebrigtsen [Thu, 2 Jun 2022 17:14:00 +0000 (19:14 +0200)]
Make checkdoc-file-comments-engine match more ;;;### forms

* lisp/emacs-lisp/checkdoc.el (checkdoc-file-comments-engine): Use
the more general lisp-mode-autoload-regexp instead of
generate-autoload-cookie (i.e., also match ;;;###tramp-autoload).

2 years agoMake `M-x grep' work better with "git grep"
Lars Ingebrigtsen [Thu, 2 Jun 2022 13:06:27 +0000 (15:06 +0200)]
Make `M-x grep' work better with "git grep"

* lisp/progmodes/compile.el (compilation-start): Bind PAGER to ""
to avoid errors in output from "git grep" and similar commands
(bug#4359).

2 years agoMake ?\LF generate 10, not -1 (bug#55738)
Mattias Engdegård [Thu, 2 Jun 2022 09:46:18 +0000 (11:46 +0200)]
Make ?\LF generate 10, not -1 (bug#55738)

The old -1 value was an artefact of the reader implementation.

* src/lread.c (read_escape): Remove the `stringp` argument; assume
character literal syntax.  Never return -1.
(read_string_literal): Handle string-specific escape semantics here
and simplify.
* test/src/lread-tests.el (lread-escaped-lf): New test.

2 years ago* src/lread.c (skip_lazy_string): Fix uninitialised variable.
Mattias Engdegård [Thu, 2 Jun 2022 13:42:40 +0000 (15:42 +0200)]
* src/lread.c (skip_lazy_string): Fix uninitialised variable.

2 years ago; * lisp/files.el (find-file): Avoid too short lines in doc string.
Eli Zaretskii [Thu, 2 Jun 2022 13:04:38 +0000 (16:04 +0300)]
; * lisp/files.el (find-file): Avoid too short lines in doc string.

2 years ago* lisp/play/morse.el: Doc fixes.
Stefan Kangas [Thu, 2 Jun 2022 12:55:35 +0000 (14:55 +0200)]
* lisp/play/morse.el: Doc fixes.

2 years agoImprove keystrokes in doc strings in some find-file functions
Ikumi Keita [Thu, 2 Jun 2022 12:29:38 +0000 (14:29 +0200)]
Improve keystrokes in doc strings in some find-file functions

* lisp/files.el (find-file):
(find-file-other-window):
(find-file-other-frame): Include the correct keymap so that
keystrokes are displayed better (bug#55761).

Copyright-paperwork-exempt: yes

2 years agoMore gracefully handle errors during Motif drag window creation
Po Lu [Thu, 2 Jun 2022 11:54:09 +0000 (19:54 +0800)]
More gracefully handle errors during Motif drag window creation

* src/xterm.c (xm_drag_window_error_handler): Store whether or
not an error happened.
(xm_get_drag_window): Handle errors during XCreateWindow and
XChangeProperty without leaking anything.
(x_error_handler): Fix coding style.

2 years agoFix out-of-tree build problems with loaddefs.el
Lars Ingebrigtsen [Thu, 2 Jun 2022 11:52:58 +0000 (13:52 +0200)]
Fix out-of-tree build problems with loaddefs.el

* lisp/Makefile.in ($(lisp)/loaddefs.el): Use the new function.

* lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate): Pass in
whether to inhibit a partial build (to make the code more general).
(loaddefs-generate--emacs-batch): Add a new function specially for
the Emacs build that has the special rules needed.  (This also
fixes out-of-tree builds.)
loaddefs-generate-batch can be used in general for packages etc.
(loaddefs-generate-batch): Remove the special code for Emacs builds.

2 years agoFix segfaults when starting on 80x26 TTY frames
Eli Zaretskii [Thu, 2 Jun 2022 10:41:59 +0000 (13:41 +0300)]
Fix segfaults when starting on 80x26 TTY frames

* src/dispnew.c (adjust_frame_glyphs_for_frame_redisplay): Make
sure we have valid frame glyph matrices for the interactive
session.  (Bug#55760)
(adjust_frame_glyphs): Add assertions for when we fail to allocate
valid frame glyph matrices for a TTY frame.

2 years agoReinstate the Qload file name handler
Lars Ingebrigtsen [Thu, 2 Jun 2022 09:51:09 +0000 (11:51 +0200)]
Reinstate the Qload file name handler

* src/lread.c (Fload): Reinstate the Qload file name handler
(bug#12598).  This makes loading non-ASCII elc.gz files work.

2 years agoUse `read-process-output-max' when creating pipes on GNU/Linux
Frédéric Giquel [Thu, 2 Jun 2022 09:38:56 +0000 (11:38 +0200)]
Use `read-process-output-max' when creating pipes on GNU/Linux

* src/process.c (syms_of_process): Note max size.
(create_process): Set the pipe size from `read-process-output-max'
(bug#55737).

Copyright-paperwork-exempt: yes

2 years agoFix usage of absolute :height in manoj-dark-theme
yilkalargaw [Thu, 2 Jun 2022 09:30:23 +0000 (11:30 +0200)]
Fix usage of absolute :height in manoj-dark-theme

* etc/themes/manoj-dark-theme.el (manoj-dark): Avoid using
absolute heights (bug#55759).

2 years agoSpeed up loaddefs-generate on slow disks
Lars Ingebrigtsen [Thu, 2 Jun 2022 09:13:08 +0000 (11:13 +0200)]
Speed up loaddefs-generate on slow disks

* lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate): Make file
update comparisons faster.

2 years agoFix rare crash when async input happens while creating xm drag window
Po Lu [Thu, 2 Jun 2022 08:36:03 +0000 (16:36 +0800)]
Fix rare crash when async input happens while creating xm drag window

* src/xterm.c (xm_get_drag_window): Work around XCloseDisplay
freezing upon being interrupted by a signal.

2 years agoMerge branch 'master' of git.savannah.gnu.org:/srv/git/emacs
Eli Zaretskii [Thu, 2 Jun 2022 07:52:19 +0000 (10:52 +0300)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

2 years ago; * src/emacs.c (main): Move -version output after initialization.
Eli Zaretskii [Thu, 2 Jun 2022 07:51:37 +0000 (10:51 +0300)]
; * src/emacs.c (main): Move -version output after initialization.