]> git.eshelyaron.com Git - emacs.git/log
emacs.git
5 years agoImprove documentation of 'display-buffer-*' functions
Eli Zaretskii [Sat, 3 Aug 2019 09:15:03 +0000 (12:15 +0300)]
Improve documentation of 'display-buffer-*' functions

* lisp/window.el (display-buffer-in-atom-window)
(display-buffer-in-side-window, display-buffer-same-window)
(display-buffer--maybe-same-window)
(display-buffer-reuse-window)
(display-buffer-reuse-mode-window)
(display-buffer-pop-up-frame, display-buffer-pop-up-window)
(display-buffer--maybe-pop-up-frame-or-window)
(display-buffer--maybe-pop-up-frame)
(display-buffer-in-child-frame, display-buffer-in-direction)
(display-buffer-below-selected, display-buffer-at-bottom)
(display-buffer-in-previous-window)
(display-buffer-use-some-window, display-buffer-no-window):
More details about the ALIST argument in the doc string.  (Bug#19461)

5 years agomacroexp doc fixes
Lars Ingebrigtsen [Fri, 2 Aug 2019 21:11:28 +0000 (23:11 +0200)]
macroexp doc fixes

* lisp/emacs-lisp/macroexp.el (macroexp-progn): Doc clarification
(bug#19371).
(macroexp-let*): Doc fix.

5 years agomacroexp--cons doc fix
Lars Ingebrigtsen [Fri, 2 Aug 2019 21:03:47 +0000 (23:03 +0200)]
macroexp--cons doc fix

* lisp/emacs-lisp/macroexp.el (macroexp--cons): Doc fix (bug#19371).

5 years agoFix some minor inconsistencies in the Package examples
Lars Ingebrigtsen [Fri, 2 Aug 2019 20:36:38 +0000 (22:36 +0200)]
Fix some minor inconsistencies in the Package examples

* doc/lispref/package.texi (Simple Packages): Use one of the
approved keywords (bug#19490).

* doc/lispref/tips.texi (Library Headers): Use URL instead of
Homepage to make things consistent with "Simple Packages".

5 years agoDon't but out on ~/.git files in ede
Lars Ingebrigtsen [Fri, 2 Aug 2019 20:04:38 +0000 (22:04 +0200)]
Don't but out on ~/.git files in ede

* lisp/cedet/ede/detect.el (ede--detect-ldf-root-predicate): Make
this work with ~/ as the dir (bug#19521).

5 years agobrowse-url doc string fixup
Lars Ingebrigtsen [Fri, 2 Aug 2019 19:45:19 +0000 (21:45 +0200)]
browse-url doc string fixup

* lisp/net/browse-url.el (browse-url-browser-function)
(browse-url-secondary-browser-function): Mention each other in the
doc strings.

5 years agoMake Info-find-file ensure that Info is initialised
Lars Ingebrigtsen [Fri, 2 Aug 2019 19:25:29 +0000 (21:25 +0200)]
Make Info-find-file ensure that Info is initialised

* lisp/info.el (Info-find-file): Ensure that Info is initialised,
because libraries call that function (bug#19880).

5 years agoFix progression in hideshow.el
Lars Ingebrigtsen [Fri, 2 Aug 2019 19:21:23 +0000 (21:21 +0200)]
Fix progression in hideshow.el

* lisp/progmodes/hideshow.el (hs-hide-all): Ensure progression in
a less brittle fashion (bug#19892).

5 years agoFix example code in hideshow.el
Michael Heerdegen [Fri, 2 Aug 2019 19:04:22 +0000 (21:04 +0200)]
Fix example code in hideshow.el

* lisp/progmodes/hideshow.el: The original example would infloop
(bug#19892).

5 years agoUse default value of `parse-time-months' in tramp-smb.el
Michael Albinus [Fri, 2 Aug 2019 18:14:23 +0000 (20:14 +0200)]
Use default value of `parse-time-months' in tramp-smb.el

* lisp/net/tramp-smb.el (tramp-smb-read-file-entry): Use default
value of `parse-time-months'.

5 years ago; Fix typo in filenotify-tests.el
Michael Albinus [Fri, 2 Aug 2019 18:13:44 +0000 (20:13 +0200)]
; Fix typo in filenotify-tests.el

5 years agoImprove pretty-printing of multiple JSON snippets in a region
Tassilo Horn [Fri, 2 Aug 2019 16:05:13 +0000 (18:05 +0200)]
Improve pretty-printing of multiple JSON snippets in a region

* lisp/json.el (json-pretty-print): Improve pretty-printing of
multiple JSON snippets in a region.  Don't lose the region contents
starting with the first non-JSON-parseable text.  Also, don't swallow
errors that occurred while parsing (bug#34160).

5 years ago; Docfixes for recent browse-url.el additions
Basil L. Contovounesios [Fri, 2 Aug 2019 13:39:53 +0000 (16:39 +0300)]
; Docfixes for recent browse-url.el additions

* lisp/net/browse-url.el (browse-url-secondary-browser-function)
(browse-url-button-copy): Fix punctuation in and clarify docstrings.

5 years agoCC Mode: Fix error in macro cache. This fixes bug #36802
Alan Mackenzie [Fri, 2 Aug 2019 13:38:13 +0000 (13:38 +0000)]
CC Mode: Fix error in macro cache.  This fixes bug #36802

* lisp/progmodes/cc-engine.el (c-invalidate-macro-cache): Add in a cond arm
to handle the change position being less than the recorded CPP contruct end.

5 years agoMake gravatar.el more configurable
Basil L. Contovounesios [Mon, 22 Jul 2019 20:57:39 +0000 (21:57 +0100)]
Make gravatar.el more configurable

For discussion, see the following thread:
https://lists.gnu.org/archive/html/emacs-devel/2019-07/msg00528.html

* etc/NEWS: Announce changes in gravatar.el user options.

* lisp/image/gravatar.el (gravatar-cache-ttl): Change :type to
number of seconds without changing the default value and while still
accepting other timestamp formats.
(gravatar-rating): Restrict :type to ratings recognized by Gravatar.
(gravatar-size): Allow nil as a value, in which case Gravatar's
default size is used.
(gravatar-default-image, gravatar-force-default): New user options
controlling the Gravatar query parameters 'default' and
'forcedefault', respectively.
(gravatar-base-url): Use HTTPS.
(gravatar--query-string): New helper function to facilitate testing.
(gravatar-build-url): Use it.

* test/lisp/image/gravatar-tests.el (gravatar-size)
(gravatar-default-image, gravatar-force-default)
(gravatar-build-url): New tests.

5 years agoFix some minor gravatar.el issues
Basil L. Contovounesios [Mon, 22 Jul 2019 20:48:45 +0000 (21:48 +0100)]
Fix some minor gravatar.el issues

For discussion, see the following thread:
https://lists.gnu.org/archive/html/emacs-devel/2019-07/msg00528.html
* lisp/image/gravatar.el (gravatar-hash): Trim leading and trailing
whitespace in given address, as per the Gravatar docs.
(gravatar-retrieve-synchronously): Silence call to
url-retrieve-synchronously for consistency with gravatar-retrieve.
(gravatar-retrieved): Only cache buffer on successful retrieval.
* test/lisp/image/gravatar-tests.el: New file.

5 years agoDRY in gravatar.el
Basil L. Contovounesios [Mon, 22 Jul 2019 20:49:47 +0000 (21:49 +0100)]
DRY in gravatar.el

For discussion, see the following thread:
https://lists.gnu.org/archive/html/emacs-devel/2019-07/msg00528.html
* lisp/image/gravatar.el (gravatar-data->image): Remove.
(gravatar-retrieve, gravatar-retrieve-synchronously): Reuse
url-fetch-from-cache and gravatar-retrieved to reduce duplication.
(gravatar-retrieved): Only cache buffer if url-current-object is
non-nil and return result of callback.  This affords reusing this
function in cached URL buffers.

5 years agoUse lexical-binding for Gravatar support
Basil L. Contovounesios [Mon, 22 Jul 2019 21:06:22 +0000 (22:06 +0100)]
Use lexical-binding for Gravatar support

For discussion, see the following thread:
https://lists.gnu.org/archive/html/emacs-devel/2019-07/msg00528.html
* lisp/gnus/gnus-gravatar.el: Use lexical-binding.  Link custom
group 'gnus-gravatar' to 'gravatar'.
(gnus-gravatar-size, gnus-gravatar-too-ugly): Doc fix.
(gnus-gravatar-insert): Check liveness of article buffer sooner.
(gnus-treat-from-gravatar, gnus-treat-mail-gravatar): Use
interactive spec "p" instead of emulating it.
* lisp/image/gravatar.el: Use lexical-binding.
(gravatar-cache-expired): Remove.  Change all callers to use
url-cache-expired instead.
(gravatar-get-data, gravatar-retrieve)
(gravatar-retrieve-synchronously): Simplify.

5 years agoCC Mode: Fix spurious recognition of operators beginning with, e.g. "or"
Alan Mackenzie [Fri, 2 Aug 2019 12:57:40 +0000 (12:57 +0000)]
CC Mode: Fix spurious recognition of operators beginning with, e.g. "or"

This fixes bug #36801.

* lisp/progmodes/cc-langs.el (c-pre-lambda-tokens-re): Use c-make-keywords-re
rather than regexp-opt to make an optimised regexp out of a list of tokens.

5 years agopdb doc clarification
Lars Ingebrigtsen [Fri, 2 Aug 2019 12:46:48 +0000 (14:46 +0200)]
pdb doc clarification

* lisp/progmodes/gud.el (pdb): Clarify what the parameters mean
(bug#20106).

5 years agoMention that some dired commands work on the current file, too
Lars Ingebrigtsen [Fri, 2 Aug 2019 12:16:25 +0000 (14:16 +0200)]
Mention that some dired commands work on the current file, too

* lisp/dired-aux.el (dired-do-search): Mention that it works on
file under point (bug#20194).
(dired-do-find-regexp-and-replace): Ditto.
(dired-do-find-regexp): Ditto.

5 years agoCC Mode: Fix the timing of application and removal of string fence properties
Alan Mackenzie [Fri, 2 Aug 2019 11:24:38 +0000 (11:24 +0000)]
CC Mode: Fix the timing of application and removal of string fence properties

This fixes bug #36897.

* lisp/progmodes/cc-mode.el (c-before-change-check-unbalanced-strings): Check
string fence text properties are actually present on string delimiters before
trying to remove them.
(c-before-change): Amend the nesting of unwind-protect, widen,
c-restore-string-fences, and c-clear-string-fences.  Move
invalidate-state-cache to outside of the widening.
(c-after-change): Amend the nesting of unwind-protect, widen,
c-restore-string-fences, and c-clear-string-fences.

5 years agoUse "rebinding keys" in the "Rebinding" section of the manual
Lars Ingebrigtsen [Fri, 2 Aug 2019 10:44:31 +0000 (12:44 +0200)]
Use "rebinding keys" in the "Rebinding" section of the manual

* doc/emacs/custom.texi (Rebinding): Use the term "rebinding keys"
instead of "redefining keys", because the former seems more
logical (bug#21036).

5 years agoClean up file-size-function
Mattias EngdegÄrd [Mon, 22 Jul 2019 15:10:37 +0000 (17:10 +0200)]
Clean up file-size-function

It is now called `byte-count-to-string-function', and used instead of
calling `file-size-human-readable' directly where appropriate.

* lisp/files.el (file-size-human-readable-iec): New.
(file-size-function): Rename to byte-count-to-string-function.  Better
default value.  Eliminate lambda.  Better default for custom choice.
Put in group `files'.  More descriptive doc string.  Move.
(out-of-memory-warning-percentage, warn-maybe-out-of-memory)
(get-free-disk-space):
* lisp/dired.el (dired-number-of-marked-files):
* lisp/url/url-http.el (url-http-simple-after-change-function)
(url-http-content-length-after-change-function):
Use byte-count-to-string-function.
* test/lisp/files-test.el (files-test-file-size-human-readable):
Test file-size-human-readable-iec.

5 years agoMention font-backend related crashes in PROBLEMS
Eli Zaretskii [Fri, 2 Aug 2019 09:24:53 +0000 (12:24 +0300)]
Mention font-backend related crashes in PROBLEMS

* etc/PROBLEMS: Mention the crash in the Cairo build when
.emacs.desktop messes with font-backend.  (Bug#36835)

5 years agoFix two parse-time-months invalid assumptions
Paul Eggert [Thu, 1 Aug 2019 22:34:35 +0000 (15:34 -0700)]
Fix two parse-time-months invalid assumptions

* lisp/gnus/nnimap.el: Do not require parse-time.
* lisp/gnus/nnimap.el (nnimap-find-expired-articles):
* lisp/net/pop3.el (pop3-make-date):
Just use system-time-locale and format-time-string; no need to
refer to parse-time-months.
* lisp/net/pop3.el (parse-time-months): Remove defvar.
* lisp/net/tramp-smb.el (tramp-smb-read-file-entry):
Add FIXME comment about this.

5 years agoPort standard-test-interval to Los Angeles
Paul Eggert [Thu, 1 Aug 2019 22:31:07 +0000 (15:31 -0700)]
Port standard-test-interval to Los Angeles

* test/lisp/calendar/iso8601-tests.el (standard-test-interval):
Use UTC to avoid DST glitches in the test.

5 years agoDocument that --eval makes emacsclient ignore -n
Lars Ingebrigtsen [Thu, 1 Aug 2019 22:15:13 +0000 (00:15 +0200)]
Document that --eval makes emacsclient ignore -n

* doc/man/emacsclient.1: Mention that -n is ignored if --eval is
given (bug#20524).

5 years agoDocument batch-byte-compile directory behavior
Lars Ingebrigtsen [Thu, 1 Aug 2019 21:16:24 +0000 (23:16 +0200)]
Document batch-byte-compile directory behavior

* lisp/emacs-lisp/bytecomp.el (batch-byte-compile): Document the
behaviour with directories (bug#20867).

5 years ago* lisp/gnus/message.el (message-sendmail-f-is-evil): Update :version
Stefan Monnier [Thu, 1 Aug 2019 20:55:03 +0000 (16:55 -0400)]
* lisp/gnus/message.el (message-sendmail-f-is-evil): Update :version

5 years agoUpdate URL in comment in gomoku.el
Lars Ingebrigtsen [Thu, 1 Aug 2019 19:52:46 +0000 (21:52 +0200)]
Update URL in comment in gomoku.el

* lisp/play/gomoku.el: Update the URL in the comments (bug#21300).

5 years agoFix reference to `tags-loop-continue' in doc string
Lars Ingebrigtsen [Thu, 1 Aug 2019 19:21:59 +0000 (21:21 +0200)]
Fix reference to `tags-loop-continue' in doc string

* lisp/dired-aux.el (dired-do-search): Refer to
`fileloop-continue' instead of the obsolete `tags-loop-continue'
(bug#21475).

5 years agoMention `C-h b' in the Keymaps node
Lars Ingebrigtsen [Thu, 1 Aug 2019 18:54:17 +0000 (20:54 +0200)]
Mention `C-h b' in the Keymaps node

* doc/emacs/custom.texi (Keymaps): Mention `C-h b' here (bug#21653).

5 years agoAdd PDF to the DocBook notation class
Daniel Barrett [Thu, 1 Aug 2019 17:47:43 +0000 (19:47 +0200)]
Add PDF to the DocBook notation class

* etc/schema/dbnotn.rnc: PDF is among the document types accepted
(bug#21882).

Copyright-paperwork-exempt: yes

5 years agoSay that while returns nil
Lars Ingebrigtsen [Thu, 1 Aug 2019 17:27:19 +0000 (19:27 +0200)]
Say that while returns nil

* src/eval.c (Fwhile): Say that while always returns nil
(bug#22006).

5 years ago* doc/lispref/display.texi (SVG Images): Add menu for subsection.
Glenn Morris [Thu, 1 Aug 2019 15:40:28 +0000 (08:40 -0700)]
* doc/lispref/display.texi (SVG Images): Add menu for subsection.

Again.  This is needed for makeinfo-4.13.

5 years agoFix the ELisp manual part of a recent commit
Eli Zaretskii [Thu, 1 Aug 2019 14:21:22 +0000 (17:21 +0300)]
Fix the ELisp manual part of a recent commit

* doc/lispref/display.texi (SVG Images): Fix markup of "SVG
Path Commands".  It is no longer a @node, but a @subheading.

5 years agoFix property stripping in image-file-yank-handler
Basil L. Contovounesios [Thu, 1 Aug 2019 13:30:15 +0000 (16:30 +0300)]
Fix property stripping in image-file-yank-handler

Fix proposed by Martin Rudalics <rudalics@gmx.at> in:
https://lists.gnu.org/archive/html/emacs-devel/2008-12/msg00945.html
* lisp/image-file.el (image-file-yank-handler): Handle case when
yank-excluded-properties is t.

5 years agoFix usage of remove-text-properties
Basil L. Contovounesios [Thu, 1 Aug 2019 12:59:46 +0000 (15:59 +0300)]
Fix usage of remove-text-properties

* lisp/allout-widgets.el (allout-decorate-item-icon):
* lisp/emacs-lisp/chart.el (chart-goto-xy):
* lisp/forms.el (forms--make-format)
(forms--make-format-elt-using-text-properties):
* lisp/htmlfontify.el (hfy-unmark-trailing-whitespace):
* lisp/net/newst-plainview.el (newsticker-hide-entry)
(newsticker-show-entry):
* lisp/nxml/nxml-mode.el (nxml-cleanup):
* lisp/obsolete/longlines.el (longlines-unshow-hard-newlines)
(longlines-encode-region):
* lisp/org/ob-exp.el (org-babel-exp-process-buffer):
* lisp/org/org-agenda.el (org-agenda-show-new-time):
* lisp/progmodes/cc-defs.el
(c-clear-char-property-with-value-function)
(c-clear-char-property-with-value-on-char-function):
* lisp/progmodes/ebrowse.el (ebrowse--hide):
* lisp/progmodes/gdb-mi.el (gdb-send):
* lisp/progmodes/idlw-shell.el
(idlwave-retrieve-expression-from-level):
* lisp/progmodes/make-mode.el (makefile-fill-paragraph):
* lisp/progmodes/prog-mode.el (prettify-symbols--post-command-hook):
* lisp/progmodes/ruby-mode.el (ruby-syntax-propertize):
* lisp/tmm.el (tmm-remove-inactive-mouse-face):
Always pass an explicit plist to remove-text-properties.

* lisp/dired.el (dired--unhide):
* lisp/facemenu.el (facemenu-add-face):
* lisp/htmlfontify.el (hfy-fontify-buffer):
* lisp/iimage.el (iimage-mode-buffer):
* lisp/image-file.el (image-file-yank-handler):
* lisp/progmodes/prog-mode.el (prettify-symbols--compose-symbol):
* lisp/textmodes/tex-mode.el (latex-env-before-change):
* test/src/undo-tests.el (undo-test0):
Use remove-list-of-text-properties in place of
remove-text-properties where appropriate.

5 years ago; Auto-commit of loaddefs files.
Glenn Morris [Thu, 1 Aug 2019 13:26:06 +0000 (06:26 -0700)]
; Auto-commit of loaddefs files.

5 years agoDoc string clarification for defcustom
Lars Ingebrigtsen [Thu, 1 Aug 2019 12:48:09 +0000 (14:48 +0200)]
Doc string clarification for defcustom

* lisp/custom.el (defcustom): Mention `custom-declare-variable' in
the doc string(bug#22703).

5 years agoMake `C-u RET' in erc use the secondary browser
Lars Ingebrigtsen [Thu, 1 Aug 2019 11:59:01 +0000 (13:59 +0200)]
Make `C-u RET' in erc use the secondary browser

* lisp/erc/erc-button.el (erc-button-alist): Use the version of
`browse-url' that interprets `C-u RET' as using the secondary browser.

5 years agoUse decoded-time accessors in vc-cvs
Lars Ingebrigtsen [Thu, 1 Aug 2019 11:48:08 +0000 (13:48 +0200)]
Use decoded-time accessors in vc-cvs

* lisp/vc/vc-cvs.el (vc-cvs-parse-entry): Use decoded-time
accessors for results from `parse-time-string'.

5 years agoUse decoded-time accessors in gnus-demon
Lars Ingebrigtsen [Thu, 1 Aug 2019 11:47:04 +0000 (13:47 +0200)]
Use decoded-time accessors in gnus-demon

* lisp/gnus/gnus-demon.el (gnus-demon-time-to-step): Use
decoded-time accessors for results from `parse-time-string'.

5 years agoUse decoded-time accessors in esh-util
Lars Ingebrigtsen [Thu, 1 Aug 2019 11:46:28 +0000 (13:46 +0200)]
Use decoded-time accessors in esh-util

* lisp/eshell/esh-util.el (eshell-parse-ange-ls): Use decoded-time
accessors for results from `parse-time-string'.

5 years agoRemove some compat code in esh-util
Lars Ingebrigtsen [Thu, 1 Aug 2019 11:38:41 +0000 (13:38 +0200)]
Remove some compat code in esh-util

* lisp/eshell/esh-util.el (eshell-parse-ange-ls): Remove
older-Emacs compat code.

5 years ago; Use more decoded time accessors in time-date.el
Basil L. Contovounesios [Thu, 1 Aug 2019 11:07:18 +0000 (14:07 +0300)]
; Use more decoded time accessors in time-date.el

These were overlooked in a recent change.
* lisp/calendar/time-date.el (time-date--day-in-year): Use decoded
time accessors.

5 years agoAdd example for removing scroll bars/fringes from mini windows (Bug#8868)
Martin Rudalics [Thu, 1 Aug 2019 07:56:44 +0000 (09:56 +0200)]
Add example for removing scroll bars/fringes from mini windows (Bug#8868)

* doc/lispref/display.texi (Fringe Size/Pos): Mention example
for how to permenantly remove fringes from minibuffer windows.
(Scroll Bars): Add example for how to permanently remove
scroll bars and fringes from minibuffer windows.

5 years agoformat-time-string subsumes time-zone-format
Paul Eggert [Thu, 1 Aug 2019 02:21:50 +0000 (19:21 -0700)]
format-time-string subsumes time-zone-format

* lisp/calendar/time-date.el (time-zone-format):
* test/lisp/calendar/time-date-tests.el (test-time-zone-format):
Remove.
* lisp/gnus/nnrss.el (nnrss-normalize-date):
Use format-time-string instead of time-zone-format.

5 years agoRevert "Revert "Add support for paths to svg.el""
Lars Ingebrigtsen [Wed, 31 Jul 2019 20:29:29 +0000 (22:29 +0200)]
Revert "Revert "Add support for paths to svg.el""

This reverts commit 0a2461be9edb218bf9ca56156d8966a2421f13a7.

Copyright paperwork is now in place, so the patch mistakenly applied
can now be re-applied.

5 years agoRestore `replace-region-contents' in json-pretty-print
Lars Ingebrigtsen [Wed, 31 Jul 2019 20:18:57 +0000 (22:18 +0200)]
Restore `replace-region-contents' in json-pretty-print

* lisp/json.el (json-pretty-print): Switch back to using
`replace-region-contents' to preserve markers and fonts which went
missing when fixing the bug
(bug#34160).
(json-pretty-print-max-secs): Restore, too.

5 years agoAdd more icalendar tests (for the isodatetime parser)
Lars Ingebrigtsen [Wed, 31 Jul 2019 19:04:50 +0000 (21:04 +0200)]
Add more icalendar tests (for the isodatetime parser)

* test/lisp/calendar/icalendar-tests.el
(icalendar-tests--decode-isodatetime): Test
`icalendar--decode-isodatetime'.

5 years agoRewrite `url-dav-process-date-property' to use parse-time
Lars Ingebrigtsen [Wed, 31 Jul 2019 13:25:46 +0000 (15:25 +0200)]
Rewrite `url-dav-process-date-property' to use parse-time

* lisp/url/url-dav.el (url-dav-iso8601-regexp): Remove.
(url-dav-process-date-property): Rewrite to use
`parse-iso8601-time-string'.

5 years agoFix time zone in previous rewrite of newsticker--decode-iso8601-date
Lars Ingebrigtsen [Wed, 31 Jul 2019 13:18:03 +0000 (15:18 +0200)]
Fix time zone in previous rewrite of newsticker--decode-iso8601-date

* lisp/net/newst-backend.el (newsticker--decode-iso8601-date):
According to the tests, this function should default to the Z time
zone.

5 years agoRewrite `parse-iso8601-time-string' to use `iso8601-parse'
Lars Ingebrigtsen [Wed, 31 Jul 2019 13:17:04 +0000 (15:17 +0200)]
Rewrite `parse-iso8601-time-string' to use `iso8601-parse'

* lisp/calendar/parse-time.el (parse-iso8601-time-string): Use
`iso8601-parse'.
(parse-time-iso8601-regexp): Remove.

5 years agoAllow timezone defaults in decoded-time-set-defaults
Lars Ingebrigtsen [Wed, 31 Jul 2019 13:15:47 +0000 (15:15 +0200)]
Allow timezone defaults in decoded-time-set-defaults

* lisp/calendar/time-date.el (decoded-time-set-defaults): Allow
passing in a default time zone, as this seems to be something
callers seem to do.

5 years agoDefault DST to "undecided" in decoded-time-set-defaults
Lars Ingebrigtsen [Wed, 31 Jul 2019 13:10:38 +0000 (15:10 +0200)]
Default DST to "undecided" in decoded-time-set-defaults

* lisp/calendar/time-date.el (decoded-time-set-defaults): When we
don't have a zone or a DST, set DST to "undecided".

5 years agodecoded-time-dst doc fix
Lars Ingebrigtsen [Tue, 30 Jul 2019 15:22:08 +0000 (17:22 +0200)]
decoded-time-dst doc fix

* lisp/simple.el (decoded-time): Doc fix for dst (note -1 value).

5 years agoUse iso8601-parse in nnrss
Lars Ingebrigtsen [Tue, 30 Jul 2019 15:01:35 +0000 (17:01 +0200)]
Use iso8601-parse in nnrss

* lisp/gnus/nnrss.el (nnrss-normalize-date): Use iso8601-parse
instead of hand-rolled parser.

* test/lisp/gnus/nnrss-tests.el: New file.

5 years agoMake time-zone-format take a SHORT parameter
Lars Ingebrigtsen [Tue, 30 Jul 2019 14:59:31 +0000 (16:59 +0200)]
Make time-zone-format take a SHORT parameter

* lisp/calendar/time-date.el (time-zone-format): Accept an
optional SHORT parameter.

5 years agoAdd new function time-zone-format
Lars Ingebrigtsen [Tue, 30 Jul 2019 14:56:12 +0000 (16:56 +0200)]
Add new function time-zone-format

* lisp/calendar/time-date.el (time-zone-format): New function.

5 years ago`decoded-time-set-defaults' refactored out from iso8601 code
Lars Ingebrigtsen [Tue, 30 Jul 2019 14:46:10 +0000 (16:46 +0200)]
`decoded-time-set-defaults' refactored out from iso8601 code

* lisp/calendar/iso8601.el (iso8601--encode-time):
* lisp/calendar/time-date.el (decoded-time-set-defaults):
Refactor out from `iso8601--encode-time', because it's helpful
in other contexts.

5 years agoHave newsticker use iso8601 to parse dates
Lars Ingebrigtsen [Tue, 30 Jul 2019 14:20:40 +0000 (16:20 +0200)]
Have newsticker use iso8601 to parse dates

* lisp/net/newst-backend.el (newsticker--decode-iso8601-date): Use
iso8601 to parse.

5 years agoCall file notification actions properly in filenotify-tests.el
Michael Albinus [Wed, 31 Jul 2019 19:22:48 +0000 (21:22 +0200)]
Call file notification actions properly in filenotify-tests.el

* test/lisp/filenotify-tests.el (file-notify--test-wait-for-events):
Rename from `file-notify--wait-for-events'.  Adapt all callees.
(file-notify--test-cleanup): Reset also `file-notify--test-event'
and `file-notify--test-file nil'.
(file-notify--test-event-desc, file-notify--test-event-action):
New accessor functions.
(file-notify-test02-rm-watch, file-notify--test-event-test)
(file-notify--test-with-actions-check)
(file-notify--test-with-actions-explainer): Use them.
(file-notify--test-with-actions-check)
(file-notify--test-with-actions-explainer)
(file-notify--test-with-actions): Rename them from *-events-*.
Rename also internal variables accordingly.  Adapt all callees.

5 years agoDistinguish different file notification events
Michael Albinus [Wed, 31 Jul 2019 19:22:05 +0000 (21:22 +0200)]
Distinguish different file notification events

* lisp/filenotify.el (file-notify--watch): Add docstring.
(file-notify-descriptors, file-notify--rm-descriptor)
(file-notify--pending-rename): Adapt docstring.
(file-notify): New defstruct.
(file-notify-handle-event): Rename argument to OBJECT.  Use
accessor functions of the defstruct.

5 years agoAvoid intern calls for builtin syms
Paul Eggert [Wed, 31 Jul 2019 17:40:44 +0000 (10:40 -0700)]
Avoid intern calls for builtin syms

* src/casefiddle.c (Fdowncase_region):
* src/eval.c (Fdefvaralias):
Use builtin symbol rather than calling intern.

5 years agoFix Fload infile problem
Paul Eggert [Wed, 31 Jul 2019 17:38:34 +0000 (10:38 -0700)]
Fix Fload infile problem

* src/lread.c (Fload): Close window of vulnerability
where the wrong stream could have been closed.

5 years ago* src/lread.c (close_infile_unwind): Remove leftover debug code
Stefan Monnier [Wed, 31 Jul 2019 15:48:43 +0000 (11:48 -0400)]
* src/lread.c (close_infile_unwind): Remove leftover debug code

5 years ago* src/lread.c (infile): Set/reset it like a dynamically scoped variable
Stefan Monnier [Wed, 31 Jul 2019 15:19:39 +0000 (11:19 -0400)]
* src/lread.c (infile): Set/reset it like a dynamically scoped variable

I've seen segfaults where `infile` is nil when we get to
readbyte_from_file, presumably because Fload set it to NULL (via
close_infile_unwind) just before returning to its caller which was
probably itself within another read/load and for some reason
readevalloop didn't get to re-set `infile` like it used to do at every
iteration.  I was not able to really track down the bug, but the way
`infile` was set/reset seemed fragile and managing it like a standard
dynamically-scoped var seems both safer (and more efficient since we
don't need readevalloop to constantly re-set it).

(readchar): Assert that `infile` is set if using a function the depends on it.
(readbyte_from_file): Assert that `infile` is set.
(close_infile_unwind): Reset `infile` to its previous value rather than
to NULL.
(Fload): Remember the previous value of `infile` before chaning it.
(readevalloop): Don't set `infile` any more.

5 years agoClarify (lognot bignum)
Paul Eggert [Wed, 31 Jul 2019 13:56:14 +0000 (06:56 -0700)]
Clarify (lognot bignum)

* doc/lispref/numbers.texi (Bitwise Operations):
Say that (= (lognot n) (- -1 n)).

5 years agoFix an error in tramp-sh-inotifywait-process-filter
Michael Albinus [Wed, 31 Jul 2019 12:54:08 +0000 (14:54 +0200)]
Fix an error in tramp-sh-inotifywait-process-filter

* lisp/net/tramp-sh.el (tramp-sh-inotifywait-process-filter):
Add default FILE to returned event, if inotifywait doesn't tell us.

5 years agoRemove no-longer relevant xref
Noam Postavsky [Wed, 31 Jul 2019 12:33:28 +0000 (08:33 -0400)]
Remove no-longer relevant xref

* doc/lispref/positions.texi (List Motion): Remove xref, the text it
references was removed in 2018-02-15 "Document
open-paren-in-column-0-is-defun-start being of less importance".

5 years agoMerge from origin/emacs-26
Glenn Morris [Wed, 31 Jul 2019 04:42:34 +0000 (21:42 -0700)]
Merge from origin/emacs-26

8fbe462 (origin/emacs-26) ; * doc/lispref/positions.texi (List Motion...
1d9efc0 Add index for "\( in strings" (Bug#25195)
304e96f Fix doc-string of 'fit-window-to-buffer' (Bug#36848)
d4c4987 Update view-mode docstring
d6ca1fc ; * lisp/term.el: Add missing / to esc seq commentary.
b3e2073 Fix subproc listening when setting filter to non-t (Bug#36591)
f671950 * etc/NEWS.25: Belatedly announce rcirc-reconnect-delay.
7f42277 Mention term.el's \032 dir tracking in commentary (Bug#19524)
16a529e Remove upload functionality of package-x from the elisp manual
78e6c2a * etc/AUTHORS: Update.
086a56e Clarify Gravatar docs
0592467 * doc/lispref/display.texi (Defining Faces): Say a face can't...

# Conflicts:
# doc/emacs/programs.texi
# etc/AUTHORS
# lisp/term.el

5 years ago* lisp/emacs-lisp/let-alist.el: Bump version to 1.0.6 (Bug#23244).
Noam Postavsky [Wed, 31 Jul 2019 01:13:04 +0000 (21:13 -0400)]
* lisp/emacs-lisp/let-alist.el: Bump version to 1.0.6 (Bug#23244).

5 years ago* lisp/gnus/message.el: Reduce redundancy with send-mail-function
Stefan Monnier [Tue, 30 Jul 2019 20:37:01 +0000 (16:37 -0400)]
* lisp/gnus/message.el: Reduce redundancy with send-mail-function

(message-send-mail-function) <function>: Remove `local-library` tests
for libs distributed with Emacs.
(message-use-send-mail-function): New function.
(message-default-send-mail-function): Default to it, and remove cases
already handled by it.
(message--default-send-mail-function): New function.
(message-send-mail-function) <variable>: Use it as new default.
(message-sendmail-f-is-evil): Obey mail-specify-envelope-from if available.
(message-check, message-with-reply-buffer): Use `declare`.
(message-smtpmail-send-it): smtpmail accepts mail-header-separator,
so simplify and declare obsolete.
(message-send-mail-with-mailclient): Declare obsolete.
(message-check-news-body-syntax): Don't presume that the checksum is
a fixnum.

5 years ago* lisp/bindings.el (mode-line-defining-kbd-macro): New defvar.
Juri Linkov [Tue, 30 Jul 2019 20:35:42 +0000 (23:35 +0300)]
* lisp/bindings.el (mode-line-defining-kbd-macro): New defvar.

(minor-mode-alist): Use it for `defining-kbd-macro'.  (Bug#36564)

5 years ago* lisp/mail/sendmail.el (sendmail-send-it): Add FIXMEs.
Stefan Monnier [Tue, 30 Jul 2019 20:14:10 +0000 (16:14 -0400)]
* lisp/mail/sendmail.el (sendmail-send-it): Add FIXMEs.

Remove redundant :groups in the file, as well.

5 years agoMerge commit '9b480db6732c6d2e886838f112d9bd46fc8989bf'
Stephen Leake [Tue, 30 Jul 2019 18:03:15 +0000 (11:03 -0700)]
Merge commit '9b480db6732c6d2e886838f112d9bd46fc8989bf'

5 years agoImprove doc strings for some -search-path variables
Stephen Leake [Tue, 30 Jul 2019 18:02:03 +0000 (11:02 -0700)]
Improve doc strings for some -search-path variables

* lisp/emacs-lisp/bytecomp.el (emacs-lisp-compilation-search-path):
Improve doc string.

* lisp/progmodes/compile.el (compilation-search-path): Improve doc
string.

* lisp/progmodes/grep.el (grep-search-path): Improve doc string.

5 years ago; * doc/lispref/positions.texi (List Motion): Fix last change.
Eli Zaretskii [Tue, 30 Jul 2019 14:50:32 +0000 (17:50 +0300)]
; * doc/lispref/positions.texi (List Motion): Fix last change.

5 years agoMake `C-u RET' on URLs in Gnus buffers use the secondary browser
Lars Ingebrigtsen [Tue, 30 Jul 2019 14:07:38 +0000 (16:07 +0200)]
Make `C-u RET' on URLs in Gnus buffers use the secondary browser

* lisp/gnus/gnus-art.el (gnus-button-alist): Make `C-u RET' on
URLs use the secondary browse-url browser.

5 years agoTweak `browse-url-add-buttons' for better button.el comp
Lars Ingebrigtsen [Tue, 30 Jul 2019 14:06:51 +0000 (16:06 +0200)]
Tweak `browse-url-add-buttons' for better button.el comp

* lisp/net/browse-url.el (browse-url-add-buttons): Make browse-url
buttons be understood by `forward-button' and the like.

5 years agoAdd a new conveniency function to browse-url
Lars Ingebrigtsen [Tue, 30 Jul 2019 14:06:00 +0000 (16:06 +0200)]
Add a new conveniency function to browse-url

* lisp/net/browse-url.el (browse-url-button-open-url): Add a new
conveniency function.

5 years agoSupport filename matches in etags xref backend
Dmitry Gutov [Tue, 30 Jul 2019 13:59:32 +0000 (16:59 +0300)]
Support filename matches in etags xref backend

* lisp/progmodes/etags.el (etags--xref-find-definitions):
Support filename matches (bug#32510).

5 years ago; Re-enable all Flymake tests on Hydra
Dmitry Gutov [Tue, 30 Jul 2019 13:56:43 +0000 (16:56 +0300)]
; Re-enable all Flymake tests on Hydra

To see if the recent improvements fixed something

5 years agoGuard against flymake-no-changes-timeout being nil
Dmitry Gutov [Tue, 30 Jul 2019 13:55:33 +0000 (16:55 +0300)]
Guard against flymake-no-changes-timeout being nil

* test/lisp/progmodes/flymake-tests.el
(flymake-tests--wait-for-backends): Guard against
flymake-no-changes-timeout being nil (in personal configurations)
to help when running tests interactively.

5 years agoCall out the Gnus widget->button makeover in NEWS
Lars Ingebrigtsen [Tue, 30 Jul 2019 13:36:03 +0000 (15:36 +0200)]
Call out the Gnus widget->button makeover in NEWS

5 years agoConvert Emacs article buffers from widget.el to button.el
Lars Ingebrigtsen [Tue, 30 Jul 2019 13:24:55 +0000 (15:24 +0200)]
Convert Emacs article buffers from widget.el to button.el

* lisp/gnus/gnus-art.el (gnus-mime-button-map)
(gnus-url-button-commands, gnus-insert-mime-button)
(gnus-mime-display-alternative)
(gnus-article-extend-url-button, gnus-article-add-button)
(gnus-insert-prev-page-button, gnus-insert-next-page-button)
(gnus-mime-security-button-map)
(gnus-insert-mime-security-button): Ditto.

* lisp/gnus/gnus-html.el (gnus-html-displayed-image-map)
(gnus-html-wash-images, gnus-html-put-image): Ditto.

* lisp/gnus/gnus-icalendar.el (gnus-icalendar-insert-button): Ditto.

* lisp/gnus/gnus-sum.el (gnus-summary-widget-forward)
(gnus-summary-button-forward, gnus-summary-widget-backward)
(gnus-summary-button-backward, gnus-collect-urls-primary-text)
(gnus-collect-urls, gnus-summary-browse-url): Stop using widgets
and star using button.el buttons instead.

* lisp/gnus/mm-decode.el (mm-shr, mm-handle-filename): Don't
convert shr buttons into widgets.

5 years agoMark shr buttons as button.el buffers
Lars Ingebrigtsen [Tue, 30 Jul 2019 13:23:22 +0000 (15:23 +0200)]
Mark shr buttons as button.el buffers

* lisp/net/shr.el (shr-urlify): Mark buttons as button.el buffers
for easier reuse in buttonified buffers.

5 years agoConvert ` to ' in two recent NEWS entries
Lars Ingebrigtsen [Tue, 30 Jul 2019 13:22:01 +0000 (15:22 +0200)]
Convert ` to ' in two recent NEWS entries

5 years agoExtend button.el to take callback data
Lars Ingebrigtsen [Tue, 30 Jul 2019 13:21:29 +0000 (15:21 +0200)]
Extend button.el to take callback data

* doc/lispref/display.texi (Button Buffer Commands)
(Button Buffer Commands): Document this.
* lisp/button.el (backward-button, forward-button): Accept a
NO-ERROR parameter.
(button-activate): Make it possible to have specific data in the
callback action.

5 years agoAdd index for "\( in strings" (Bug#25195)
Noam Postavsky [Sun, 28 Jul 2019 16:15:33 +0000 (12:15 -0400)]
Add index for "\( in strings" (Bug#25195)

* doc/emacs/programs.texi (Left Margin Paren): Add index for "\( in
strings".
* doc/lispref/positions.texi (List Motion): Add index, and cross
reference.

5 years agoRe-fix dired-pop-to-buffer obsoletion reference
Lars Ingebrigtsen [Tue, 30 Jul 2019 11:34:53 +0000 (13:34 +0200)]
Re-fix dired-pop-to-buffer obsoletion reference

* lisp/dired.el (dired-pop-to-buffer): Re-fix obsoletion reference
(bug#26243).

5 years agoRevert "Make `ispell-change-dictionary' only list installed dictionaries"
Lars Ingebrigtsen [Tue, 30 Jul 2019 11:18:36 +0000 (13:18 +0200)]
Revert "Make `ispell-change-dictionary' only list installed dictionaries"

This reverts commit 848712b481e16f5c96fed6344c2f7d71a8d52ed1.

There could be dictionaries available (set via command-line options for the
speller, for instance) that would not be returned.

5 years agoUse decoded time accessors in ediff-mult
Lars Ingebrigtsen [Tue, 30 Jul 2019 11:11:38 +0000 (13:11 +0200)]
Use decoded time accessors in ediff-mult

* lisp/vc/ediff-mult.el (ediff-format-date): Use decoded time
accessors.

5 years agoUse decoded time accessors in pop3
Lars Ingebrigtsen [Tue, 30 Jul 2019 11:11:14 +0000 (13:11 +0200)]
Use decoded time accessors in pop3

* lisp/net/pop3.el (pop3-make-date): Use decoded time
accessors.

5 years agoUse decoded time accessors in esh-util
Lars Ingebrigtsen [Tue, 30 Jul 2019 11:10:42 +0000 (13:10 +0200)]
Use decoded time accessors in esh-util

* lisp/eshell/esh-util.el (eshell-parse-ange-ls): Use decoded time
accessors.

5 years agoUse decoded time accessors in in em-ls
Lars Ingebrigtsen [Tue, 30 Jul 2019 11:10:03 +0000 (13:10 +0200)]
Use decoded time accessors in in em-ls

* lisp/eshell/em-ls.el (eshell-ls-file): Use decoded time
accessors.

5 years agoUse decoded time accessors in timer
Lars Ingebrigtsen [Tue, 30 Jul 2019 11:08:49 +0000 (13:08 +0200)]
Use decoded time accessors in timer

* lisp/emacs-lisp/timer.el (run-at-time): Use decoded time
accessors.

5 years agoUse decoded time accessors in timeclock
Lars Ingebrigtsen [Tue, 30 Jul 2019 11:08:21 +0000 (13:08 +0200)]
Use decoded time accessors in timeclock

* lisp/calendar/timeclock.el (timeclock-day-base): Use decoded time
accessors.