]> git.eshelyaron.com Git - emacs.git/log
emacs.git
6 years agoFix last change in editfns.c
Eli Zaretskii [Sat, 21 Jul 2018 19:27:33 +0000 (22:27 +0300)]
Fix last change in editfns.c

* src/editfns.c (Freplace_buffer_contents): Fix last change: always
call buffer modification hooks, even if nothing was deleted/inserted.
(bug#32237)

6 years agoFix calls to buffer modification hooks from replace-buffer-contents
Eli Zaretskii [Sat, 21 Jul 2018 18:05:52 +0000 (21:05 +0300)]
Fix calls to buffer modification hooks from replace-buffer-contents

* src/editfns.c (Freplace_buffer_contents): Don't call buffer
modification hooks if nothing was deleted/inserted.  (Bug#32237)

6 years ago; etc/NEWS: Remove unnecessary reference to a bug number.
Eli Zaretskii [Sat, 21 Jul 2018 16:44:38 +0000 (19:44 +0300)]
; etc/NEWS: Remove unnecessary reference to a bug number.

6 years agoFix Bug#32226
Michael Albinus [Sat, 21 Jul 2018 10:29:06 +0000 (12:29 +0200)]
Fix Bug#32226

* lisp/shadowfile.el (shadow-site-name, shadow-name-site):
Use "[-.[:word:]]+" as hostname regexp.  (Bug#32226)

* test/lisp/shadowfile-tests.el (shadow-test06-literal-groups)
(shadow-test07-regexp-groups, shadow-test08-shadow-todo)
(shadow-test09-shadow-copy-files): Skip if needed.

6 years agoImprove doc strings of several variables in keyboard.c
Eli Zaretskii [Sat, 21 Jul 2018 09:28:11 +0000 (12:28 +0300)]
Improve doc strings of several variables in keyboard.c

* src/keyboard.c (syms_of_keyboard) <debug-on-event>
<attempt-stack-overflow-recovery>
<attempt-orderly-shutdown-on-fatal-signal>: Make sure the first
sentence of the doc string fits on a single line.

6 years agoFix (Bug#32218). Do not merge with master
Michael Albinus [Fri, 20 Jul 2018 08:56:41 +0000 (10:56 +0200)]
Fix (Bug#32218).  Do not merge with master

* doc/misc/trampver.texi:
* lisp/net/trampver.el: Change version to "2.3.4.26.2".
(customize-package-emacs-version-alist): Add Tramp version
integrated in Emacs 26.2.

* lisp/net/tramp.el (tramp-handle-file-truename):
* lisp/net/tramp-adb.el (tramp-adb-handle-file-truename):
* lisp/net/tramp-sh.el (tramp-sh-handle-file-truename): Fix problem
with trailing slash.  (Bug#32218)

* test/lisp/net/tramp-tests.el (tramp-test21-file-links):
Remove `tramp--test-emacs27-p' check.

6 years agoImprove documentation of 'pcase-defmacro rx'
Eli Zaretskii [Fri, 20 Jul 2018 08:44:36 +0000 (11:44 +0300)]
Improve documentation of 'pcase-defmacro rx'

* lisp/emacs-lisp/rx.el (rx): Clarify and improve the doc string.
For the details, see the discussion starting at
http://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00399.html.

6 years agoFix TTY colors breakage by 'clear-face-cache'
Eli Zaretskii [Thu, 19 Jul 2018 17:44:32 +0000 (20:44 +0300)]
Fix TTY colors breakage by 'clear-face-cache'

Without examining the right frame, 'tty-color-24bit' was erroneously
treating a GUI frame as a 24-bit TTY frame.
* lisp/term/tty-colors.el (tty-color-24bit): Accept optional
argument DISPLAY and pass it to display-color-cells.  Doc fix.
(tty-color-define, tty-color-desc): Pass the FRAME argument to
tty-color-24bit.  (Bug#32072)

6 years ago* admin/MAINTAINERS: Add files maintained by me (Michael Albinus).
Michael Albinus [Wed, 18 Jul 2018 14:52:12 +0000 (16:52 +0200)]
* admin/MAINTAINERS: Add files maintained by me (Michael Albinus).

6 years agoAdapt shadowfile.el for Tramp (Bug#4526, Bug#4846)
Michael Albinus [Wed, 18 Jul 2018 14:51:56 +0000 (16:51 +0200)]
Adapt shadowfile.el for Tramp  (Bug#4526, Bug#4846)

* etc/NEWS: Mention changes in shadowfile.el.

* lisp/shadowfile.el (top): Require 'tramp instead of 'ange-ftp.
(shadow-cluster): New defstruct.
(shadow-make-cluster, shadow-cluster-name, shadow-cluster-primary)
(shadow-cluster-regexp, shadow-get-user)
(shadow-parse-fullname): Remove.
(shadow-info-file, shadow-todo-file, shadow-system-name)
(shadow-homedir, shadow-regexp-superquote, shadow-suffix)
(shadow-set-cluster, shadow-get-cluster, shadow-site-name)
(shadow-name-site, shadow-site-primary, shadow-site-cluster)
(shadow-read-site, shadow-parse-name, shadow-make-fullname)
(shadow-replace-name-component, shadow-local-file)
(shadow-expand-cluster-in-file-name, shadow-contract-file-name)
(shadow-same-site, shadow-file-match, shadow-define-cluster)
(shadow-define-literal-group, shadow-define-regexp-group)
(shadow-make-group, shadow-shadows-of-1, shadow-read-files)
(shadow-write-info-file, shadow-write-todo-file)
(shadow-initialize): Adapt variables and functions.

* test/lisp/shadowfile-tests.el: New file.

6 years agoFix auth-source-delete (Bug#26184)
Noam Postavsky [Wed, 18 Jul 2018 01:00:27 +0000 (21:00 -0400)]
Fix auth-source-delete (Bug#26184)

* lisp/auth-source.el (auth-source-delete): Fix `auth-source-search'
call.
* test/lisp/auth-source-tests.el (auth-source-delete): New test.

6 years agoAvoid assertion violations in gnutls.c
Eli Zaretskii [Tue, 17 Jul 2018 16:58:27 +0000 (19:58 +0300)]
Avoid assertion violations in gnutls.c

* src/gnutls.c (Fgnutls_hash_digest, gnutls_symmetric)
(Fgnutls_hash_mac): Check CONSP before invoking XCDR.  (Bug#32187)
Report values of invalid arguments when signaling an error.

6 years agoDon't use a literal "C-u" in ispell.el help message text
Eli Zaretskii [Sat, 14 Jul 2018 15:53:40 +0000 (18:53 +0300)]
Don't use a literal "C-u" in ispell.el  help message text

* lisp/textmodes/ispell.el (ispell-command-loop): Use
"\\[universal-argument]" instead of a literal "C-u".  (Bug#32142)

6 years agoImprove documentation of 'seqp'
Eli Zaretskii [Sat, 14 Jul 2018 08:18:04 +0000 (11:18 +0300)]
Improve documentation of 'seqp'

* doc/lispref/sequences.texi (Sequence Functions): Add text to
explain the relation between 'seqp' and 'sequencep'.  (Bug#32125)

6 years agoClarify usage and dependencies between several Flyspell features
Eli Zaretskii [Sat, 14 Jul 2018 07:43:32 +0000 (10:43 +0300)]
Clarify usage and dependencies between several Flyspell features

* lisp/textmodes/flyspell.el (flyspell-region)
(flyspell-small-region, flyspell-persistent-highlight):
Documentation improvements.  (Bug#32142)

6 years agoUse consistent function names in thread-tests.el
Michael Albinus [Fri, 13 Jul 2018 12:28:12 +0000 (14:28 +0200)]
Use consistent function names in thread-tests.el

* test/src/thread-tests.el (threads-call-error, threads-custom)
(threads-errors, threads-sticky-point, threads-signal-early):
Rename, using naming convention to prefix with "threads-".

6 years agoFix format error in Faccept_process_output
Michael Albinus [Fri, 13 Jul 2018 12:27:33 +0000 (14:27 +0200)]
Fix format error in Faccept_process_output

* src/process.c (Faccept_process_output): Do not use format spec
"%p", it isn't valid for error().

6 years agoLessen stack consumption in recursive read1
Paul Eggert [Fri, 13 Jul 2018 03:23:07 +0000 (20:23 -0700)]
Lessen stack consumption in recursive read1

* src/lread.c (read1): Shrink local buffer size from
MAX_ALLOCA to 128 (Bug#31995).

6 years agoMatch w32 paths in grep sans --null hits (Bug#32051)
Noam Postavsky [Mon, 9 Jul 2018 20:56:47 +0000 (16:56 -0400)]
Match w32 paths in grep sans --null hits (Bug#32051)

* lisp/progmodes/grep.el (grep-regexp-alist): Add an optional part to
match paths starting with C: (other drive letters).
* test/lisp/progmodes/compile-tests.el
(compile-tests--grep-regexp-testcases)
(compile-tests--grep-regexp-tricky-testcases)
(compile-test-grep-regexps): New tests.
(compile--test-error-line): Return `compilation-message'.

6 years agoFix previous make-network-process change
Noam Postavsky [Thu, 12 Jul 2018 23:41:03 +0000 (19:41 -0400)]
Fix previous make-network-process change

* src/process.c (Fmake_network_process): On 2018-07-09 "Explicitly
reject :server and :nowait (Bug#31903)", the sense of the SERVER check
was accidentally reversed so that we ended up looking for the wrong
ADDRESS.  Reported by T.V Raman in
<https://lists.gnu.org/archive/html/emacs-devel/2018-07/msg00437.html>.

6 years agoAnother documentation improvement in flyspell.el
Eli Zaretskii [Thu, 12 Jul 2018 16:24:06 +0000 (19:24 +0300)]
Another documentation improvement in flyspell.el

* lisp/textmodes/flyspell.el (flyspell-persistent-highlight): Doc
fix.

6 years agoImprove documentation of Flyspell
Eli Zaretskii [Thu, 12 Jul 2018 15:59:18 +0000 (18:59 +0300)]
Improve documentation of Flyspell

For the background, see
http://lists.gnu.org/archive/html/help-gnu-emacs/2018-07/msg00099.html.

* doc/emacs/fixit.texi (Spelling): Add a couple of caveats.
* lisp/textmodes/flyspell.el: Update commentary.

6 years agoProvide feature 'threads
Michael Albinus [Thu, 12 Jul 2018 08:49:06 +0000 (10:49 +0200)]
Provide feature 'threads

* src/thread.c (syms_of_threads): Provide feature "threads".

* test/src/thread-tests.el (top): Declare the functions.
(all): Use (featurep 'threads) check.

6 years agoSave the server alias on reconnect (Bug#29657)
Miciah Masters [Mon, 11 Dec 2017 01:14:09 +0000 (20:14 -0500)]
Save the server alias on reconnect (Bug#29657)

rcirc does not retain the server alias on reconnect.  As a result, rcirc
fails to re-use server and channel buffers when an alias is used.  Further
problems may ensue when aliases are used to differentiate multiple
connections to the same host, for example when using a single IRC bouncer
or proxy to connect to multiple IRC networks.

Save the server alias when connecting to a server so that reconnect will
retain the alias.
* lisp/net/rcirc.el (rcirc-connect): Include server-alias when setting
rcirc-connection-info.

Copyright-paperwork-exempt: yes

6 years agoRefer to "proper lists" instead of "true lists"
Basil L. Contovounesios [Wed, 11 Jul 2018 02:51:28 +0000 (19:51 -0700)]
Refer to "proper lists" instead of "true lists"

* doc/lispref/lists.texi (Cons Cells, Building Lists):
* doc/lispref/sequences.texi (Vector Functions): Use the more
popular term "proper", rather than "true", to qualify nil-terminated
lists.

For discussion, see the following emacs-devel subthreads:
https://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00112.html
https://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00138.html

6 years agoAvoid turning on the global-minor-mode recursively
John Shahid [Sat, 23 Jun 2018 15:12:44 +0000 (11:12 -0400)]
Avoid turning on the global-minor-mode recursively

* lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Clear
the buffer-list inside MODE-enable-in-buffers to avoid enabling the
mode recursively.  (Bug#31793)

6 years agoFix Bug#32085
Michael Albinus [Tue, 10 Jul 2018 07:49:49 +0000 (09:49 +0200)]
Fix Bug#32085

* doc/misc/tramp.texi (GVFS based methods): `dav' and `davs' do
not support paths in the volume name.  (Bug#32085)

6 years agoStop using indent-line-to in lisp-indent-line (Bug#32014)
Noam Postavsky [Fri, 29 Jun 2018 23:58:58 +0000 (19:58 -0400)]
Stop using indent-line-to in lisp-indent-line (Bug#32014)

This is partial revert of "Remove ignored argument from
lisp-indent-line", because `indent-line-to' doesn't respect field
boundaries.
* lisp/emacs-lisp/lisp-mode.el (lisp-indent-line): Use delete-region
and indent-to instead of `indent-line-to'.
* test/lisp/emacs-lisp/lisp-mode-tests.el
(lisp-indent-with-read-only-field): Expect to pass.

Don't merge to master, we will fix indent-line-to there instead.

6 years ago; Test for Bug#32014
Noam Postavsky [Sat, 30 Jun 2018 00:15:10 +0000 (20:15 -0400)]
; Test for Bug#32014

* test/lisp/emacs-lisp/lisp-mode-tests.el
(lisp-indent-with-read-only-field): New test.

6 years agoExplicitly reject :server and :nowait (Bug#31903)
Noam Postavsky [Thu, 5 Jul 2018 23:37:28 +0000 (19:37 -0400)]
Explicitly reject :server and :nowait (Bug#31903)

* src/process.c (Fmake_network_process): Explicitly check for and
signal an error when passed both :server and :nowait non-nil.  In
Emacs 25, :nowait would be ignored in this case, but as of Emacs 26.1
this gives an error, albeit an unclear one.  Also remove obsolete
comment regarding configurations lacking non-blocking mode, the
corresponding code was removed in 2012-11-17 "Assume POSIX 1003.1-1988
or later for fcntl.h."

6 years agoFix Bug#32090
Michael Albinus [Mon, 9 Jul 2018 14:03:49 +0000 (16:03 +0200)]
Fix Bug#32090

* lisp/files-x.el (connection-local-normalize-criteria): Do not
use PROPERTIES anymore.
(connection-local-get-profiles): Rewrite, in order to accept any
property as optional.  (Bug#32090)
(connection-local-set-profiles):
Adapt ´connection-local-normalize-criteria' call.

* test/lisp/files-x-tests.el
(files-x-test-connection-local-set-profiles)
(files-x-test-hack-connection-local-variables-apply): Extend tests.

6 years agoFix floating point exceptions on Alpha (Bug#32086)
Paul Eggert [Sun, 8 Jul 2018 17:51:00 +0000 (10:51 -0700)]
Fix floating point exceptions on Alpha (Bug#32086)

Backport from master.
* admin/merge-gnulib (GNULIB_MODULES): Add fpieee.
* m4/fpieee.m4: New file, copied from Gnulib.
* m4/gnulib-comp.m4: Regenerate.

6 years agoFix bootstrap infloop in GNU/Linux alpha
Paul Eggert [Sun, 8 Jul 2018 16:04:02 +0000 (09:04 -0700)]
Fix bootstrap infloop in GNU/Linux alpha

* src/emacs.c (main): Do not re-exec if EMACS_HEAP_EXEC
is already set (Bug#32083).

6 years agoMinor fix of a recent documentation change
Eli Zaretskii [Sun, 8 Jul 2018 15:22:51 +0000 (18:22 +0300)]
Minor fix of a recent documentation change

* lisp/net/gnutls.el (gnutls-algorithm-priority): Clarify the doc
string.

6 years agoMention the NSM in the gnutls variable doc strings
Lars Ingebrigtsen [Sun, 24 Jun 2018 12:48:30 +0000 (14:48 +0200)]
Mention the NSM in the gnutls variable doc strings

* gnutls.el (gnutls-algorithm-priority): Mention the Network
Security Manager here since this variable is an obvious place
for people concerned about network security to look.
(gnutls-verify-error): Ditto.
(gnutls-min-prime-bits): Ditto.

6 years agoRemove test code from last commit
Michael Albinus [Sun, 8 Jul 2018 11:08:05 +0000 (13:08 +0200)]
Remove test code from last commit

6 years agoFix Bug#32084
Michael Albinus [Sun, 8 Jul 2018 11:02:19 +0000 (13:02 +0200)]
Fix Bug#32084

* test/lisp/net/dbus-tests.el (dbus-test02-register-service-own-bus):
Unset $DISPLAY when calling dbus-launch, in order to avoid
possible X11 authentication errors.  (Bug#32084)

6 years agoFix (length NON-SEQUENCE) documentation
Basil L. Contovounesios [Sat, 7 Jul 2018 16:33:08 +0000 (19:33 +0300)]
Fix (length NON-SEQUENCE) documentation

Suggested by Eli Zaretskii <eliz@gnu.org> in the following threads:
https://lists.gnu.org/archive/html/emacs-devel/2018-07/msg00171.html
https://lists.gnu.org/archive/html/emacs-devel/2018-07/msg00206.html

* doc/lispref/sequences.texi (Sequence Functions): Mention that
'length' signals a 'wrong-type-argument' also when given a
non-sequencep argument.

6 years agoFix bug #11732
Eli Zaretskii [Sat, 7 Jul 2018 11:30:00 +0000 (14:30 +0300)]
Fix bug #11732

* src/w32fns.c (w32_wnd_proc): Fix handling of Windows input
methods.  (Bug#11732)

6 years agoImprove documentation of 'emacs-lock-mode'
Eli Zaretskii [Sat, 7 Jul 2018 09:50:22 +0000 (12:50 +0300)]
Improve documentation of 'emacs-lock-mode'

* lisp/emacs-lock.el (emacs-lock-mode): Mention in the doc string
the special handling of some major modes due to
'emacs-lock-unlockable-modes'.

6 years ago* lisp/imenu.el (imenu-generic-expression): Doc fix. (Bug#32016)
Eli Zaretskii [Sat, 7 Jul 2018 09:34:26 +0000 (12:34 +0300)]
* lisp/imenu.el (imenu-generic-expression): Doc fix.  (Bug#32016)

6 years agoImprove indexing of 'eval-defun' in ELisp manual
Eli Zaretskii [Sat, 7 Jul 2018 08:37:43 +0000 (11:37 +0300)]
Improve indexing of 'eval-defun' in ELisp manual

* doc/lispref/display.texi (Defining Faces):
* doc/lispref/debugging.texi (Explicit Debug):
* doc/lispref/customize.texi (Variable Definitions):
* doc/lispref/variables.texi (Defining Variables): Add index
entries for 'eval-defun'.  (Bug#32066)

6 years agoFix (length CIRCULAR) documentation
Paul Eggert [Fri, 6 Jul 2018 17:59:53 +0000 (10:59 -0700)]
Fix (length CIRCULAR) documentation

* doc/lispref/sequences.texi (Sequence Functions):
Correct documentation of what (length X) does when
X is a circular list.

6 years agoTramp editorials
Michael Albinus [Fri, 6 Jul 2018 12:03:42 +0000 (14:03 +0200)]
Tramp editorials

* doc/misc/tramp.texi (Android shell setup): Mention Termux.

* lisp/net/tramp-sh.el (tramp-remote-process-environment):
Use proper spelling "Tramp" in docstring.

6 years agoClarify and improve doc strings of 'eval-last-sexp' and friends
Eli Zaretskii [Fri, 6 Jul 2018 09:31:51 +0000 (12:31 +0300)]
Clarify and improve doc strings of 'eval-last-sexp' and friends

* lisp/simple.el (eval-expression, eval-expression-print-format):
* lisp/progmodes/elisp-mode.el (eval-last-sexp): Doc fixes.
(Bug#32064)

6 years agoAutomate upload of Emacs manuals to gnu.org
Glenn Morris [Fri, 6 Jul 2018 04:50:18 +0000 (21:50 -0700)]
Automate upload of Emacs manuals to gnu.org

* admin/make-manuals, admin/upload-manuals: New scripts.
* admin/admin.el (make-manuals, make-manuals-dist): Handle batch mode.
* admin/make-tarball.txt: Update web-page details.

6 years agoFix MH-E mail composition with GNU Mailutils (SF#485)
Mike Kupfer [Wed, 4 Jul 2018 22:43:04 +0000 (15:43 -0700)]
Fix MH-E mail composition with GNU Mailutils (SF#485)

* lisp/mh-e/mh-comp.el (mh-bare-components): Recursively delete
the temporary folder.

6 years agoSpeed up 'replace-buffer-contents' some more
Eli Zaretskii [Tue, 3 Jul 2018 19:16:20 +0000 (22:16 +0300)]
Speed up 'replace-buffer-contents' some more

* src/editfns.c (EXTRA_CONTEXT_FIELDS): New members beg_a and beg_b.
(Freplace_buffer_contents): Set up ctx.beg_a and ctx.beg_b.
(buffer_chars_equal): Use ctx->beg_a and ctx->beg_b instead of
calling BUF_BEGV, which is expensive.  This speeds up the recipe
in bug#31888 by 30%.

6 years ago* doc/emacs/docstyle.texi: Avoid messing up the html output.
Glenn Morris [Tue, 3 Jul 2018 05:37:22 +0000 (22:37 -0700)]
* doc/emacs/docstyle.texi: Avoid messing up the html output.

Previously the @hyphenation commands somehow caused the <head>
section to go missing, with makeinfo 4.13 at least.

6 years ago; Auto-commit of loaddefs files.
Glenn Morris [Tue, 3 Jul 2018 00:45:00 +0000 (20:45 -0400)]
; Auto-commit of loaddefs files.

6 years ago; Fix ChangeLog typo.
Paul Eggert [Sun, 1 Jul 2018 15:36:30 +0000 (08:36 -0700)]
; Fix ChangeLog typo.

6 years ago; make change-history-commit
Paul Eggert [Sun, 1 Jul 2018 15:35:18 +0000 (08:35 -0700)]
; make change-history-commit

6 years ago* etc/HISTORY: Cite Brinkoff on early history.
Paul Eggert [Sun, 1 Jul 2018 15:25:46 +0000 (08:25 -0700)]
* etc/HISTORY: Cite Brinkoff on early history.

6 years agoDocument internal use of 'above-suspended' z-group frame parameter
Martin Rudalics [Sun, 1 Jul 2018 08:22:59 +0000 (10:22 +0200)]
Document internal use of 'above-suspended' z-group frame parameter

* src/w32fns.c (w32_dialog_in_progress, x_set_z_group):
* src/xterm.c (x_set_z_group): Clarify the internal use of
'above-suspended' when setting a frame's 'z-group' parameter.

6 years agoIncrease max-lisp-eval-depth adjustment while in debugger (bug#31919)
Gemini Lasswell [Wed, 20 Jun 2018 20:58:33 +0000 (13:58 -0700)]
Increase max-lisp-eval-depth adjustment while in debugger (bug#31919)

* src/eval.c (call_debugger): Increase the amount of extra Lisp
evaluation depth given to the debugger to allow it to call cl-print.
* lisp/emacs-lisp/debug.el (debugger-setup-buffer): Add a comment
to suggest updating call_debugger when changing print-level.

6 years agoImprove on last change in replace-buffer-contents
Eli Zaretskii [Sat, 30 Jun 2018 13:50:31 +0000 (16:50 +0300)]
Improve on last change in replace-buffer-contents

* src/editfns.c (Freplace_buffer_contents): Call modification
hooks only for the actual region where changes are made.
(Bug#31888)

6 years agoFix a factual error in Introduction to Emacs Lisp
Eli Zaretskii [Sat, 30 Jun 2018 13:13:01 +0000 (16:13 +0300)]
Fix a factual error in Introduction to Emacs Lisp

* doc/lispintro/emacs-lisp-intro.texi (Buffer Names): Update the
key that exits the splash screen.  (Bug#32019)

6 years ago; * lisp/files.el (buffer-offer-save): Doc fix. (Bug#32000)
Eli Zaretskii [Sat, 30 Jun 2018 09:54:58 +0000 (12:54 +0300)]
; * lisp/files.el (buffer-offer-save): Doc fix.  (Bug#32000)

6 years agoMinor improvements in documentation of imenu.el
Eli Zaretskii [Sat, 30 Jun 2018 09:22:05 +0000 (12:22 +0300)]
Minor improvements in documentation of imenu.el

* lisp/imenu.el (imenu-generic-skip-comments-and-strings)
(imenu--generic-function): Doc fixes.  (Bug#31962)

6 years agoAvoid errors with recentering in 'skeleton-insert'
Eli Zaretskii [Sat, 30 Jun 2018 09:07:24 +0000 (12:07 +0300)]
Avoid errors with recentering in 'skeleton-insert'

* lisp/skeleton.el (skeleton-insert): Don't recenter if we are
running in a buffer other than the one displayed in the selected
window.  (Bug#31950)

6 years ago* src/lisp.h: Omit obsolete comment re bytecode stack.
Paul Eggert [Fri, 29 Jun 2018 18:14:36 +0000 (11:14 -0700)]
* src/lisp.h: Omit obsolete comment re bytecode stack.

6 years agoSpeed up replace-buffer-contents
Eli Zaretskii [Fri, 29 Jun 2018 13:55:20 +0000 (16:55 +0300)]
Speed up replace-buffer-contents

* src/editfns.c (EXTRA_CONTEXT_FIELDS): Add a_unibyte and
b_unibyte members.
(rbc_quitcounter): New static variable.
(Freplace_buffer_contents): Initialize a_unibyte, b_unibyte, and
rbc_quitcounter.  Inhibit modification hooks if they were not
already inhibited.  Use rarely_quit to allow user to quit, to
avoid calling maybe_quit too frequently (which hurts performance).
Remove redundant assertions (which hurt performance too much).
Call signal_after_change and update_compositions after all the
changes are done.
(buffer_chars_equal): Remove redundant assertions (which hurt
performance).  Avoid using BUF_FETCH_CHAR_AS_MULTIBYTE, which
hurts performance by referencing Lisp symbols; instead, use
lower-level macros with explicit tests to select which macro to
use.  (Bug#31888)

6 years agoRemove extra process call from vc-git-find-file-hook
Dmitry Gutov [Thu, 28 Jun 2018 00:14:56 +0000 (03:14 +0300)]
Remove extra process call from vc-git-find-file-hook

* lisp/vc/vc-git.el (vc-git-find-file-hook): Resolve FIXMEs.

6 years ago; Update some commentary
Dmitry Gutov [Thu, 28 Jun 2018 00:05:19 +0000 (03:05 +0300)]
; Update some commentary

* lisp/vc/vc-git.el (vc-git-state): Remove outdated commentary.
(vc-git-dir-status-goto-stage): Move a TODO here.
(vc-git-conflicted-files): From here.
(vc-git-find-file-hook): Add a FIXME.

6 years agoSpeed up vc-git-dir-status-files
Dmitry Gutov [Thu, 28 Jun 2018 00:03:36 +0000 (03:03 +0300)]
Speed up vc-git-dir-status-files

* lisp/vc/vc-git.el (vc-git-dir-status-goto-stage): Call 'git
ls-files -u' for the ls-files-conflict stage
(https://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00885.html).

6 years agoAvoid compiler warning using coding.h
Eli Zaretskii [Wed, 27 Jun 2018 15:02:45 +0000 (18:02 +0300)]
Avoid compiler warning using coding.h

* src/coding.h: Add INLINE_HEADER_BEGIN..INLINE_HEADER_END, since
this header now has an extern INLINE function.

6 years agoSync with Tramp 2.3.4. Do not merge with master
Michael Albinus [Wed, 27 Jun 2018 11:08:18 +0000 (13:08 +0200)]
Sync with Tramp 2.3.4.  Do not merge with master

* doc/misc/trampver.texi:
* lisp/net/trampver.el: Change version to "2.3.4".

* lisp/net/tramp-smb.el (tramp-smb-handle-delete-directory):
Check, that the directory has been removed indeed.

* test/lisp/net/tramp-tests.el (tramp-test21-file-links): Adapt test.
(tramp--test-emacs25-p): New defun.
(tramp-test34-vc-registered): Use it.

6 years ago* src/xdisp.c (Vmouse_autoselect_window): Clarify doc-string (Bug#31975)
Martin Rudalics [Wed, 27 Jun 2018 07:07:59 +0000 (09:07 +0200)]
* src/xdisp.c (Vmouse_autoselect_window): Clarify doc-string (Bug#31975)

6 years agoDetect a non-list package archive content properly (Bug#22311)
Noam Postavsky [Sat, 16 Jun 2018 22:59:43 +0000 (18:59 -0400)]
Detect a non-list package archive content properly (Bug#22311)

* lisp/emacs-lisp/package.el (package--download-one-archive): Use
`read' instead of `read-from-string'; the latter always returns a
cons, so the `listp' check on its return value doesn't make sense.  It
was changed from `read' to `read-from-string' in 2015-04-01 "*
emacs-lisp/package.el: Implement asynchronous refreshing", but that
change was not needed because `read' works fine on strings as well as
buffers.

6 years agoAdd ido-fallback special variable (Bug#31707)
Christophe Junke [Mon, 4 Jun 2018 08:39:43 +0000 (10:39 +0200)]
Add ido-fallback special variable (Bug#31707)

Before ido.el switch to lexical-binding, it was possible for other
packages to modify the 'fallback' variables declared inside
'ido-file-internal' and 'ido-buffer-internal'.
* lisp/ido.el (ido-fallback): New variable.
(ido-buffer-internal, ido-file-internal): Reset ido-fallback to nil
before prompting user.  Use ido-fallback when ido-exit is 'fallback'.
(ido-fallback-command): Add optional FALLBACK-COMMAND argument.

Copyright-paperwork-exempt: yes

6 years agoMerge branch 'emacs-26' of git.sv.gnu.org:/srv/git/emacs into emacs-26
Michael Albinus [Mon, 25 Jun 2018 18:40:37 +0000 (20:40 +0200)]
Merge branch 'emacs-26' of git.sv.gnu.org:/srv/git/emacs into emacs-26

6 years agoTighten a cross-reference in documentation
Karl Fogel [Mon, 25 Jun 2018 17:23:23 +0000 (12:23 -0500)]
Tighten a cross-reference in documentation

* doc/lispref/internals.texi (Writing Emacs Primitives): Switch to
  a simple parenthetical cross-reference, following up to my
  commit 9a53b6d426 of 2018-06-24.

See discussion:

  https://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00826.html
  From: Eli Zaretskii
  Subject: Re: [Emacs-diffs] \
           emacs-26 9a53b6d: Say how to override a primitive interactive spec
  To: Karl Fogel
CC: Stefan Monnier, Emacs Devel
  Date: Mon, 25 Jun 2018 17:41:53 +0300
  Message-Id: <83r2kvrkr2.fsf@gnu.org>

6 years agoFix last change in tramp-sh.el
Michael Albinus [Mon, 25 Jun 2018 14:25:41 +0000 (16:25 +0200)]
Fix last change in tramp-sh.el

* lisp/net/tramp-sh.el (tramp-do-copy-or-rename-file-directly):
Use "-R" rather than "-r" for recursive copy of directories.

6 years agoRevert previous patch; comment was OK after all.
Paul Eggert [Mon, 25 Jun 2018 06:46:18 +0000 (23:46 -0700)]
Revert previous patch; comment was OK after all.

6 years agoFix lead comment for count_trailing_zero_bits
Paul Eggert [Mon, 25 Jun 2018 06:21:01 +0000 (23:21 -0700)]
Fix lead comment for count_trailing_zero_bits

* src/data.c (count_trailing_zero_bits): Fix comment to match code.

6 years ago; * doc/emacs/files.texi (Interlocking): Fix a non-portable @xref.
Eli Zaretskii [Sun, 24 Jun 2018 16:23:13 +0000 (19:23 +0300)]
; * doc/emacs/files.texi (Interlocking): Fix a non-portable @xref.

6 years ago* lisp/emacs-lisp/regexp-opt.el (regexp-opt): Fix docstring quotes.
Noam Postavsky [Sun, 24 Jun 2018 14:57:12 +0000 (10:57 -0400)]
* lisp/emacs-lisp/regexp-opt.el (regexp-opt): Fix docstring quotes.

6 years agoMake a minor update to the CSS mode docstring
Simen Heggestøyl [Sun, 24 Jun 2018 12:23:57 +0000 (14:23 +0200)]
Make a minor update to the CSS mode docstring

* lisp/textmodes/css-mode.el (css-mode): Mention 'fill-paragraph'.

6 years agoSay how to override a primitive interactive spec
Karl Fogel [Sun, 24 Jun 2018 12:10:43 +0000 (07:10 -0500)]
Say how to override a primitive interactive spec

* doc/lispref/internals.texi (Writing Emacs Primitives): Mention that
  the `interactive-form' property can be used to override a primitive
  interactive specification, and refer to the detailed documentation
  for setting that property.

From this thread on Emacs Devel:

  https://lists.gnu.org/archive/html/emacs-devel/2018-03/msg00923.html
  From: Eli Zaretskii
  To: Karl Fogel
CC: Juri Linkov, Emacs Devel
  Subject: Re: [Emacs-diffs] \
           master b88e7c8: Make transpose-regions interactive (Bug#30343)
  Date: Thu, 29 Mar 2018 14:38:15 +0300
  Message-Id: <834lkzdsd4.fsf@gnu.org>

6 years agoFix Bug#31941
Michael Albinus [Sun, 24 Jun 2018 08:24:26 +0000 (10:24 +0200)]
Fix Bug#31941

* lisp/net/tramp-sh.el (tramp-do-copy-or-rename-file): In case of
FILENAME being a directory, check whether `copy-directory' could
be avoided.  Suggested by Stephen Nutt <stnutt@gmail.com>.  (Bug#31941)
(tramp-do-copy-or-rename-file-directly): Call "cp" with "-r".

6 years agoFix previous change in minibuffer-default-add-dired-shell-commands
Leo Liu [Tue, 12 Jun 2018 04:24:09 +0000 (12:24 +0800)]
Fix previous change in minibuffer-default-add-dired-shell-commands

The mailcap minibuffer completion used dynamic binding.  Locally set
a dynamic variable.
* lisp/dired-aux.el (minibuffer-default-add-dired-shell-commands):
Store list of files in 'minibuffer-completion-table'.  (Bug#31794)

6 years ago* src/editfns.c (Fformat): Make %x easier to spot in doc string. (Bug#31945)
Eli Zaretskii [Sat, 23 Jun 2018 12:34:14 +0000 (15:34 +0300)]
* src/editfns.c (Fformat): Make %x easier to spot in doc string.  (Bug#31945)

6 years agoImprove responsiveness while in 'replace-buffer-contents'
Eli Zaretskii [Sat, 23 Jun 2018 11:03:10 +0000 (14:03 +0300)]
Improve responsiveness while in 'replace-buffer-contents'

* src/editfns.c (buffer_chars_equal): Avoid calling
buf_charpos_to_bytepos when the buffer is plain-ASCII.
Suggested by Milan Stanojević <mstanojevic@janestreet.com>.
Call maybe_quit to improve responsiveness.
(Freplace_buffer_contents): Call maybe_quit.  Warn in the doc
string that the function could be slow.  (Bug#31888)

6 years agoImprove documentation of 'server-start' and friends
Eli Zaretskii [Sat, 23 Jun 2018 07:50:58 +0000 (10:50 +0300)]
Improve documentation of 'server-start' and friends

* lisp/server.el (server-start, server-running-p): Document how to
reliably check that the current Emacs process started the server.
(Bug#31859)

6 years agoClarify wording about functions' argument lists
Eli Zaretskii [Sat, 23 Jun 2018 07:38:44 +0000 (10:38 +0300)]
Clarify wording about functions' argument lists

* doc/lispref/functions.texi (Argument List): Clarify the
wording.  (Bug#31872)

6 years ago* lisp/doc-view.el: Fix typos in the commentary. (Bug#31937)
Eli Zaretskii [Sat, 23 Jun 2018 07:26:33 +0000 (10:26 +0300)]
* lisp/doc-view.el: Fix typos in the commentary.  (Bug#31937)

6 years agoMerge branch 'emacs-26' of git.savannah.gnu.org:/srv/git/emacs into emacs-26
Eli Zaretskii [Fri, 22 Jun 2018 18:26:45 +0000 (21:26 +0300)]
Merge branch 'emacs-26' of git.savannah.gnu.org:/srv/git/emacs into emacs-26

6 years agoFix a typo in emacs-lisp-intro.texi
Eli Zaretskii [Fri, 22 Jun 2018 18:25:55 +0000 (21:25 +0300)]
Fix a typo in emacs-lisp-intro.texi

* doc/lispintro/emacs-lisp-intro.texi (kill-ring-yank-pointer):
Add a missing quote.  Reported by Jean-Christophe Helary
<brandelune@gmail.com> in emacs-devel.

6 years agoFix doc typo: missing double-quote
Paul Eggert [Fri, 22 Jun 2018 18:13:15 +0000 (11:13 -0700)]
Fix doc typo: missing double-quote

6 years agoAvoid segfaults in replace-buffer-contents with large buffers
Eli Zaretskii [Fri, 22 Jun 2018 12:57:47 +0000 (15:57 +0300)]
Avoid segfaults in replace-buffer-contents with large buffers

* src/editfns.c (Freplace_buffer_contents): Don't release
malloc'ed memory as long as we are using it.  (Bug#31888)

6 years agoAdjust for scaling for mode-line popup menus (Bug#31880)
Robert Pluim [Fri, 22 Jun 2018 07:59:47 +0000 (09:59 +0200)]
Adjust for scaling for mode-line popup menus (Bug#31880)

* src/xmenu.c (menu_position_func) [HAVE_GTK3]: Take scaling
into account when calculating screen size.

6 years agoChange name of `seqp' argument (Bug#26411)
Simen Heggestøyl [Sun, 9 Apr 2017 09:06:44 +0000 (11:06 +0200)]
Change name of `seqp' argument (Bug#26411)

* lisp/emacs-lisp/seq.el (seqp): Change argument name.

* doc/lispref/sequences.texi: Update the documentation for seqp.

6 years agoChange index of ";" to better reflect it's usage (Bug#31623)
Noam Postavsky [Wed, 20 Jun 2018 12:40:51 +0000 (08:40 -0400)]
Change index of ";" to better reflect it's usage (Bug#31623)

* doc/lispref/objects.texi (Comments): "; for commenting" fits better
with the following text about how a semicolon begins a comment.  Also
mention that only unescaped semicolons start a comment.

6 years agoFix bug of 'mouse-drag-and-drop-region' to detect edges of region (Bug#31905)
Tak Kunihiro [Wed, 20 Jun 2018 07:27:50 +0000 (09:27 +0200)]
Fix bug of 'mouse-drag-and-drop-region' to detect edges of region (Bug#31905)

* lisp/mouse.el (mouse-drag-and-drop-region): Detect both the
beginning and the end of character of region during dragging
text.

6 years agoFix #'fun handling inside `labels' (Bug#31792)
Noam Postavsky [Tue, 12 Jun 2018 22:41:46 +0000 (18:41 -0400)]
Fix #'fun handling inside `labels' (Bug#31792)

* lisp/emacs-lisp/cl.el (labels): Apply the equivalent of the
cl-labels change from 2015-01-16 "* lisp/emacs-lisp/cl-macs.el: Fix
last change".
* test/lisp/emacs-lisp/cl-tests.el (labels-function-quoting): New
test.
* lisp/emacs-lisp/cl-macs.el (cl-flet, cl-labels): Improve docstring,
link to relevant manual page.
* doc/misc/cl.texi (Function Bindings): Don't imply that function
cells of symbols are modified by cl-flet.  Don't claim that cl-flet or
cl-labels affect references of the form (quote FUNC).

6 years agoFix vertical-motion with 'visual' line-number display
Eli Zaretskii [Mon, 18 Jun 2018 16:39:16 +0000 (19:39 +0300)]
Fix vertical-motion with 'visual' line-number display

* src/indent.c (Fvertical_motion): Don't exempt 'visual' sty;e of
line-number display from X coordinate adjustments.  (Bug#31875)

6 years ago; CONTRIBUTE: Add a couple of nits.
Eli Zaretskii [Mon, 18 Jun 2018 16:34:55 +0000 (19:34 +0300)]
; CONTRIBUTE: Add a couple of nits.

6 years agoHandle NSAttributedString inputs (bug#29837)
Alan Third [Sun, 24 Dec 2017 15:40:03 +0000 (15:40 +0000)]
Handle NSAttributedString inputs (bug#29837)

; Do not merge to master.

* src/nsterm.m (EmacsView::insertText): Handle NSAttributedString.

6 years agoAllow inserting non-BMP characters
Philipp Stephani [Mon, 25 Dec 2017 21:00:00 +0000 (22:00 +0100)]
Allow inserting non-BMP characters

* src/coding.h (UTF_16_HIGH_SURROGATE_P, UTF_16_LOW_SURROGATE_P): Move
from coding.c and document.
(surrogates_to_codepoint): New function.

* src/nsterm.m (insertText:): Properly handle surrogate pairs.

(cherry picked from commit 703ac3ea1c1ce381f385469a0e88bc29d3fe83c2)

6 years agoPrevent errant scroll on mouse click (Bug#31546)
Aaron Jensen [Thu, 24 May 2018 10:45:03 +0000 (03:45 -0700)]
Prevent errant scroll on mouse click (Bug#31546)

* src/nsterm.m (ns_mouse_position): Use correct frame when determining
  mouse position.
* lisp/mouse.el (mouse-drag-track): Only account for mode-line height
  if `mode-line-format' is non-nil.