]> git.eshelyaron.com Git - emacs.git/log
emacs.git
2 years ago; Prefer string-join in image-dired
Stefan Kangas [Tue, 13 Sep 2022 16:54:14 +0000 (18:54 +0200)]
; Prefer string-join in image-dired

* lisp/image/image-dired-dired.el (subr-x): Require.
(image-dired-dired-display-properties): Prefer string-join.
* lisp/image/image-dired.el (subr-x): Require.
(image-dired-update-header-line): Prefer string-join.

2 years agoFix recently-added cl-macs tests
Lars Ingebrigtsen [Wed, 14 Sep 2022 00:30:54 +0000 (02:30 +0200)]
Fix recently-added cl-macs tests

* test/lisp/emacs-lisp/cl-macs-tests.el (cl-case-error)
(cl-case-warning): Fix warning matches.

2 years agoMake help-fns--generalized-variable more resilient
Lars Ingebrigtsen [Tue, 13 Sep 2022 16:32:30 +0000 (18:32 +0200)]
Make help-fns--generalized-variable more resilient

* lisp/help-fns.el (help-fns--generalized-variable): Don't bug out
when a key binding isn't a symbol.

2 years agoPrefer defvar-keymap for repeat-map in outline.el
Juri Linkov [Tue, 13 Sep 2022 18:17:55 +0000 (21:17 +0300)]
Prefer defvar-keymap for repeat-map in outline.el

* lisp/outline.el (outline-navigation-repeat-map)
(outline-editing-repeat-map): Prefer defvar-keymap.

2 years agoPort alignas definition to C23
Paul Eggert [Tue, 13 Sep 2022 17:41:34 +0000 (12:41 -0500)]
Port alignas definition to C23

* src/lisp.h (alignas): C23 is removing the __alignas_is_defined
macro, so do not rely on it. Instead, do not define alignas if C23
or later, or if C++11 or later.

2 years ago; * etc/NEWS: Fix wording of 'image-crop' entry.
Eli Zaretskii [Tue, 13 Sep 2022 17:00:30 +0000 (20:00 +0300)]
; * etc/NEWS: Fix wording of 'image-crop' entry.

2 years agoFix wallpaper.el build warning
Lars Ingebrigtsen [Tue, 13 Sep 2022 16:28:14 +0000 (18:28 +0200)]
Fix wallpaper.el build warning

* lisp/image/wallpaper.el (require): Fix build warning.

2 years agoRevert "Fix help--analyze-key problem when not called from menu"
Lars Ingebrigtsen [Tue, 13 Sep 2022 16:25:32 +0000 (18:25 +0200)]
Revert "Fix help--analyze-key problem when not called from menu"

This reverts commit 7e374b96635ce70f574fba351defc765e9a52da9.

This should not be needed -- perhaps it was triggered by
an ephemeral code change in my running Emacs.

2 years agoUse wallpaper-set in thumbs.el
Stefan Kangas [Tue, 13 Sep 2022 16:02:21 +0000 (18:02 +0200)]
Use wallpaper-set in thumbs.el

* lisp/thumbs.el (wallpaper): Require.
(thumbs-setroot-command): Make defcustom obsolete.
(thumbs-call-setroot-command): Make obsolete in favor of
wallpaper-set.
(thumbs-set-image-at-point-to-root-window, thumbs-set-root)
(thumbs-dired-setroot): Use wallpaper-set instead of
thumbs-call-setroot-command.
(thumbs-before-setroot-hook, thumbs-after-setroot-hook): Make
obsolete.

2 years agoAdd new command image-dired-set-wallpaper
Stefan Kangas [Tue, 13 Sep 2022 15:56:22 +0000 (17:56 +0200)]
Add new command image-dired-set-wallpaper

* lisp/image/image-dired.el (wallpaper): Require.
(image-dired-set-wallpaper): New command.
(image-dired-thumbnail-mode-map): Bind above new command to "W".

2 years agoAdd new library wallpaper.el
Stefan Kangas [Tue, 13 Sep 2022 14:57:01 +0000 (16:57 +0200)]
Add new library wallpaper.el

* lisp/image/wallpaper.el: New file.

2 years ago; image-dired: Delete unnecessary :group arg
Stefan Kangas [Tue, 13 Sep 2022 15:16:33 +0000 (17:16 +0200)]
; image-dired: Delete unnecessary :group arg

* lisp/image/image-dired.el (image-dired-db-file): Delete unnecessary
:group arg.

2 years agoRemove a nil cl-case case
Lars Ingebrigtsen [Tue, 13 Sep 2022 16:24:14 +0000 (18:24 +0200)]
Remove a nil cl-case case

* lisp/emacs-lisp/testcover.el (testcover-coverage-combine):
Remove the nil case, which will never match (bug#51368).

2 years agoFix some misleading quoting in cl-case
Lars Ingebrigtsen [Tue, 13 Sep 2022 16:19:26 +0000 (18:19 +0200)]
Fix some misleading quoting in cl-case

* lisp/progmodes/compile.el (compilation-auto-jump):
* lisp/image/image-crop.el (image-crop--crop-image-1):
(image-crop--crop-image-1):
* lisp/image/exif.el (exif--process-value):
* lisp/image-mode.el (image-mode--next-file):
* lisp/dnd.el (dnd-begin-text-drag):
(dnd-begin-file-drag):
(dnd-begin-drag-files): Fix misleading quoting in cl-case (bug#51368).

2 years ago; * etc/NEWS: More detail about 'image-crop' and 'image-elide'.
Eli Zaretskii [Tue, 13 Sep 2022 15:58:21 +0000 (18:58 +0300)]
; * etc/NEWS: More detail about 'image-crop' and 'image-elide'.

2 years agoRegenerated ldefs-boot.el
Lars Ingebrigtsen [Tue, 13 Sep 2022 15:27:20 +0000 (17:27 +0200)]
Regenerated ldefs-boot.el

2 years agoHave 'cl-case' warn about suspicious cases
Philipp Stephani [Tue, 13 Sep 2022 15:12:57 +0000 (17:12 +0200)]
Have 'cl-case' warn about suspicious cases

* lisp/emacs-lisp/cl-macs.el (cl-case): Warn if the user passes a nil
key list (which would never match).  Warn about quoted symbols that
should probably be unquoted.

* test/lisp/emacs-lisp/cl-macs-tests.el (cl-case-warning): New unit
test (bug#51368).

2 years agoSignal an error if a fallback cl-case is misplaced
Philipp Stephani [Tue, 13 Sep 2022 15:11:53 +0000 (17:11 +0200)]
Signal an error if a fallback cl-case is misplaced

* lisp/emacs-lisp/cl-macs.el (cl-case): Warn if the user passes a nil
key list (which would never match).  Warn about quoted symbols that
should probably be unquoted.

* test/lisp/emacs-lisp/cl-macs-tests.el (cl-case-warning): New unit
test (bug#51368).

2 years agoMove imagep in image.c from the debugging section
Lars Ingebrigtsen [Tue, 13 Sep 2022 14:37:31 +0000 (16:37 +0200)]
Move imagep in image.c from the debugging section

* lisp/simple.el (imagep): Remove.
* src/image.c (Fimagep): Always define.

2 years agoFix help--analyze-key problem when not called from menu
Lars Ingebrigtsen [Tue, 13 Sep 2022 14:14:37 +0000 (16:14 +0200)]
Fix help--analyze-key problem when not called from menu

* lisp/help.el (help--analyze-key): Don't bug out when not called
from the menu.

2 years ago; * src/image.c (svg_load_image): Another minor cleanup. (Bug#51104)
Eli Zaretskii [Tue, 13 Sep 2022 14:12:40 +0000 (17:12 +0300)]
; * src/image.c (svg_load_image): Another minor cleanup.  (Bug#51104)

2 years agoAdd new commands 'image-crop' and 'image-elide'
Lars Ingebrigtsen [Tue, 13 Sep 2022 13:52:56 +0000 (15:52 +0200)]
Add new commands 'image-crop' and 'image-elide'

* doc/lispref/display.texi (Showing Images): Document it.

* lisp/image.el (image-map): Bind commands.

* lisp/image/image-crop.el: New file (bug#51331).

2 years agoAdd new function imagep
Lars Ingebrigtsen [Tue, 13 Sep 2022 13:49:18 +0000 (15:49 +0200)]
Add new function imagep

* lisp/simple.el (imagep): New function.

2 years ago; Add commentary to comp-tests.el
Eli Zaretskii [Tue, 13 Sep 2022 13:49:02 +0000 (16:49 +0300)]
; Add commentary to comp-tests.el

Sigh... why do people insist on removing useful comments and leave
their tricky code more obfuscated than it must be??
* test/src/comp-tests.el (comp-tests-type-spec-tests): Add a
comment explaining why the expressions are quoted.  (Bug#51104)

2 years agoFix whitespace-tests on macOS
Gerd Möllmann [Tue, 13 Sep 2022 13:37:56 +0000 (15:37 +0200)]
Fix whitespace-tests on macOS

* test/lisp/whitespace-tests.el (whitespace-tests--empty-bob):
(whitespace-tests--empty-eob): Use C-a/C-e instead of
<home>/<end> (bug#57763).

2 years agoMerge branch 'master' of git.savannah.gnu.org:/srv/git/emacs
Eli Zaretskii [Tue, 13 Sep 2022 13:39:26 +0000 (16:39 +0300)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

2 years ago; * src/image.c (svg_load_image): Always free 'err' if non-NULL.
Eli Zaretskii [Tue, 13 Sep 2022 13:38:50 +0000 (16:38 +0300)]
; * src/image.c (svg_load_image): Always free 'err' if non-NULL.

2 years agocomp-tests.el: Enable compilation again
Stefan Monnier [Tue, 13 Sep 2022 13:36:21 +0000 (09:36 -0400)]
comp-tests.el: Enable compilation again

Rather than disable byte-compilation to circumvent bug#51104,
change the ELisp code so that `most-positive/negative-fixnum` does
not end up hardcoded in the `.elc` file.

* test/src/comp-tests.el (comp-tests-define-type-spec-test):
Don't quote the type expressions.
(comp-tests-type-spec-tests): Quote them here instead.

2 years agoFix last change in image.c
Eli Zaretskii [Tue, 13 Sep 2022 13:26:50 +0000 (16:26 +0300)]
Fix last change in image.c

* src/image.c (svg_load_image): Don't call Lisp to remove trailing
whitespace from librsvg error messages, do it in C instead; this
reduces consing and is much cleaner.  Don't display empty error
reason if librsvg happens to return an empty message text.
(syms_of_image): Don't DEFSYM string-trim-right.  (Bug#57755)

2 years agoPrefer defvar-keymap in several cases
Stefan Kangas [Tue, 13 Sep 2022 13:05:28 +0000 (15:05 +0200)]
Prefer defvar-keymap in several cases

* lisp/calc/calc-embed.el (calc-override-minor-modes-map):
* lisp/calc/calc-yank.el (calc-edit-mode-map):
* lisp/calc/calc.el (calc-trail-mode-map):
* lisp/cedet/semantic/mru-bookmark.el (semantic-mru-bookmark-mode-map):
* lisp/cedet/semantic/util-modes.el (semantic-highlight-edits-mode-map)
(semantic-show-unmatched-syntax-mode-map)
(semantic-show-parser-state-mode-map)
(semantic-stickyfunc-mode-map, semantic-highlight-func-mode-map):
* lisp/cedet/srecode/srt-mode.el (srecode-template-mode-map):
* lisp/gnus/gnus-art.el (gnus-prev-page-map, gnus-next-page-map):
* lisp/gnus/gnus-search.el (gnus-search-minibuffer-map):
* lisp/gnus/score-mode.el (gnus-score-mode-map):
* lisp/gnus/smime.el (smime-mode-map):
* lisp/indent.el (edit-tab-stops-map):
* lisp/isearch.el (minibuffer-local-isearch-map):
* lisp/printing.el (pr-interface-map):
* lisp/progmodes/prog-mode.el (prog-mode-map):
* lisp/progmodes/subword.el (subword-mode-map):
* lisp/reveal.el (reveal-mode-map):
* lisp/strokes.el (strokes-mode-map):
* lisp/textmodes/flyspell.el (flyspell-mouse-map):
* lisp/textmodes/less-css-mode.el (less-css-mode-map):
* lisp/textmodes/remember.el (remember-mode-map)
(remember-notes-mode-map):
* lisp/wid-browse.el (widget-browse-mode-map):
* lisp/wid-edit.el (widget-key-sequence-map): Prefer defvar-keymap in
some easy-to-convert cases.

2 years agoEnable undo in eww buffers
Lars Ingebrigtsen [Tue, 13 Sep 2022 12:31:59 +0000 (14:31 +0200)]
Enable undo in eww buffers

* lisp/net/eww.el (eww-render): Enable undo after rendering.  This
allows using `undo' in text input boxes.
(eww-setup-buffer): Disable undo before rendering (bug#57750).

* lisp/net/shr.el (shr-image-fetched): Inhibit undo tracking.

2 years agoIndirect Buffers manual improvement
Lars Ingebrigtsen [Tue, 13 Sep 2022 12:07:40 +0000 (14:07 +0200)]
Indirect Buffers manual improvement

* doc/emacs/buffers.texi (Indirect Buffers): There's no point in
mentioning both clone-indirect-buffer and
clone-indirect-buffer-other-window here since they do the pretty
much the same (bug#57753).

2 years ago; * test/src/comp-tests.el: Explain the last change.
Eli Zaretskii [Tue, 13 Sep 2022 12:21:54 +0000 (15:21 +0300)]
; * test/src/comp-tests.el: Explain the last change.

2 years agoAvoid double svg error reporting and segfaults
dickmao [Tue, 13 Sep 2022 11:57:44 +0000 (13:57 +0200)]
Avoid double svg error reporting and segfaults

* src/image.c (svg_load_image): Use g_error_free directly instead
of the helder g_clear_error (since we're only calling it with
non-nil values).
(svg_load_image): Avoid segfault and double reporting errors.
* test/manual/image-tests.el (image-tests-load-image/svg-too-big)
(image-tests-load-image/svg-invalid): Test it (bug#57755).

2 years ago; Fix last change in test/manual/image-tests.el
Stefan Kangas [Tue, 13 Sep 2022 09:06:11 +0000 (11:06 +0200)]
; Fix last change in test/manual/image-tests.el

* test/manual/image-tests.el (image-skip-unless):
(image-tests-image-metadata/gif): Fix last change.

2 years agoPrefer defvar-keymap in pixel-scroll-precision-mode-map
Stefan Kangas [Mon, 12 Sep 2022 15:03:26 +0000 (17:03 +0200)]
Prefer defvar-keymap in pixel-scroll-precision-mode-map

* lisp/pixel-scroll.el (pixel-scroll-precision-mode-map): Prefer
defvar-keymap.

2 years agoPrefer defvar-keymap in tab-line.el
Stefan Kangas [Mon, 12 Sep 2022 14:53:26 +0000 (16:53 +0200)]
Prefer defvar-keymap in tab-line.el

* lisp/tab-line.el (tab-line-tab-map, tab-line-add-map)
(tab-line-tab-close-map, tab-line-left-map, tab-line-right-map):
Prefer defvar-keymap.

2 years agoPrefer defvar-keymap in lisp/epa*.el
Stefan Kangas [Mon, 12 Sep 2022 14:47:53 +0000 (16:47 +0200)]
Prefer defvar-keymap in lisp/epa*.el

* lisp/epa-ks.el (epa-ks-search-mode-map):
* lisp/epa.el (epa-key-list-mode-map, epa-key-mode-map): Prefer
defvar-keymap.

2 years agoFix frames with explicit parent being unmapped after parent shuts down
Po Lu [Tue, 13 Sep 2022 06:28:54 +0000 (14:28 +0800)]
Fix frames with explicit parent being unmapped after parent shuts down

* src/xterm.c (handle_one_xevent): Delete leftover _XEMBED_INFO
property after parent shuts down.

2 years agoMerge from origin/emacs-28
Stefan Kangas [Tue, 13 Sep 2022 04:30:41 +0000 (06:30 +0200)]
Merge from origin/emacs-28

86f0601392 ; * admin/notes/www: Fix typos.
2cdb9d03fd ; * admin/make-tarball.txt: Minor clarifications.

2 years ago; Merge from origin/emacs-28
Stefan Kangas [Tue, 13 Sep 2022 04:30:41 +0000 (06:30 +0200)]
; Merge from origin/emacs-28

The following commit was skipped:

f771f122d2 ; Bump Emacs version past 28.2

2 years agoMerge from origin/emacs-28
Stefan Kangas [Tue, 13 Sep 2022 04:30:40 +0000 (06:30 +0200)]
Merge from origin/emacs-28

739b5d0e52 Update HISTORY for Emacs 28.2

2 years ago; * admin/notes/www: Fix typos.
Stefan Kangas [Tue, 13 Sep 2022 02:53:06 +0000 (04:53 +0200)]
; * admin/notes/www: Fix typos.

2 years agoFix comp-tests.el problem after reconfiguring
Paul Eggert [Mon, 12 Sep 2022 20:31:36 +0000 (15:31 -0500)]
Fix comp-tests.el problem after reconfiguring

* test/src/comp-tests.el: Do not byte-compile, as the .elc
file would be machine-dependent (bug#51104).

2 years agoDocument the recently added branch commands (bug#50344)
Juri Linkov [Mon, 12 Sep 2022 19:12:50 +0000 (22:12 +0300)]
Document the recently added branch commands (bug#50344)

* doc/emacs/maintaining.texi (VC Directory Commands): Change the
prefix key from "B" to "b".  Replace vc-create-tag with vc-create-branch,
and vc-retrieve-tag with vc-switch-branch.
(Switching Branches): Mention vc-switch-branch bound to 'C-x v b s'.
(Creating Branches): Mention vc-create-branch bound to 'C-x v b c'.

* lisp/vc/vc-dir.el (vc-dir-mode-map): In branch keymap 'b' rebind
"c" from vc-create-tag to vc-create-branch, and "s" from
vc-retrieve-tag to vc-switch-branch.

2 years ago* lisp/vc/vc.el (vc-print-branch-log): Fix interactive spec.
Juri Linkov [Mon, 12 Sep 2022 18:41:17 +0000 (21:41 +0300)]
* lisp/vc/vc.el (vc-print-branch-log): Fix interactive spec.

For reading vc-read-revision in the interactive spec use the same 'backend'
and 'rootdir' as in the body of the same function.

2 years ago'C-x v b' prefix key is used for branch commands to create/switch/print branch
Juri Linkov [Mon, 12 Sep 2022 18:07:05 +0000 (21:07 +0300)]
'C-x v b' prefix key is used for branch commands to create/switch/print branch

* lisp/vc/vc.el (vc-create-branch): New command.
(vc-retrieve-tag): Add new optional arg 'branchp'.
(vc-switch-branch): New command (bug#50344).

* lisp/vc/vc-hooks.el (vc-prefix-map): Bind "b c" to vc-create-branch,
"b l" to vc-print-branch-log, "b s" to vc-switch-branch.  Remove obsolete
and suppressed "b" from vc-switch-backend.

* lisp/vc/vc-dir.el (vc-dir-mode-map): Rebind 'branch-map' from "B" to "b"
for consistency with 'vc-prefix-map'.

* lisp/vc/vc-git.el (vc-git-create-tag): For a new branch read
its start-point.  Ask a confirmation if modified files exist.

2 years ago; * etc/NEWS: Fix typo and wording of recently added entry.
Eli Zaretskii [Mon, 12 Sep 2022 17:02:59 +0000 (20:02 +0300)]
; * etc/NEWS: Fix typo and wording of recently added entry.

2 years ago; etc/NEWS: Fix typo.
Sean Whitton [Mon, 12 Sep 2022 15:28:17 +0000 (08:28 -0700)]
; etc/NEWS: Fix typo.

2 years ago; etc/NEWS: Update for last change.
Sean Whitton [Mon, 12 Sep 2022 15:08:16 +0000 (08:08 -0700)]
; etc/NEWS: Update for last change.

2 years agoAdd new C-x w prefix map
Sean Whitton [Mon, 12 Sep 2022 14:30:07 +0000 (07:30 -0700)]
Add new C-x w prefix map

* window.el (window-prefix-map): New map.
(ctl-x-map): Unbind split-root-window-below and
split-root-window-right.  Bind window-prefix-map to C-x w.

2 years agoSkip manual GIF metadata test on MS-Windows
Stefan Kangas [Mon, 12 Sep 2022 13:14:42 +0000 (15:14 +0200)]
Skip manual GIF metadata test on MS-Windows

* test/manual/image-tests.el
(image-skip-unless): Add new arg CONDITION.
(image-tests-image-metadata/gif): Skip test on MS-Windows when
using native image API.  (Bug#57691)

2 years agoDon't overwrite error message in `x' in package.el
Lars Ingebrigtsen [Mon, 12 Sep 2022 12:17:25 +0000 (14:17 +0200)]
Don't overwrite error message in `x' in package.el

* lisp/emacs-lisp/package.el (package-menu--perform-transaction):
Return whether there were errors.
(package-menu-execute): Don't overwrite the error message(s) with
a success message (bug#51201).

2 years agoRemove some XEmacs references in speedbar.el
Lars Ingebrigtsen [Mon, 12 Sep 2022 11:09:23 +0000 (13:09 +0200)]
Remove some XEmacs references in speedbar.el

* lisp/speedbar.el (speedbar-toggle-etags): Remove some references
to etags support being XEmacs specific (bug#51102).

2 years agoDocument :vert-only tool bar property
Lars Ingebrigtsen [Mon, 12 Sep 2022 10:57:34 +0000 (12:57 +0200)]
Document :vert-only tool bar property

* doc/lispref/keymaps.texi (Tool Bar): Document what :vert-only
does (bug#51049).  This is not what it was intended to do -- but
what it intended to do didn't really make that much sense either,
so perhaps the prop should just be renamed :image-only?

2 years agoRemove edebug props in edebug-remove-instrumentation
Arthur Miller [Mon, 12 Sep 2022 10:38:09 +0000 (12:38 +0200)]
Remove edebug props in edebug-remove-instrumentation

* lisp/emacs-lisp/edebug.el (edebug--strip-plist): New function
(bug#51026).
(edebug-remove-instrumentation): Use it to remove pros added while
running edebug.

2 years agoFix length issues in gnus-cloud-make-chunk
Lars Ingebrigtsen [Mon, 12 Sep 2022 10:23:52 +0000 (12:23 +0200)]
Fix length issues in gnus-cloud-make-chunk

* lisp/gnus/gnus-cloud.el (gnus-cloud-make-chunk): Make buffer
unibyte (bug#50988).

2 years ago; * admin/make-tarball.txt: Minor clarifications.
Stefan Kangas [Mon, 12 Sep 2022 10:15:01 +0000 (12:15 +0200)]
; * admin/make-tarball.txt: Minor clarifications.

2 years ago; Bump Emacs version past 28.2
Stefan Kangas [Mon, 12 Sep 2022 10:02:32 +0000 (12:02 +0200)]
; Bump Emacs version past 28.2

* README:
* configure.ac:
* nt/README.W32:
* msdos/sed2v2.inp:
* etc/NEWS: Bump Emacs version to 28.2.50.

2 years agoConsider key=val labels when renumbering
Arash Esbati [Mon, 12 Sep 2022 07:34:23 +0000 (09:34 +0200)]
Consider key=val labels when renumbering

* lisp/textmodes/reftex-global.el (reftex-translate): Recognize
key=val labels given in the optional or mandatory argument of
environments (AUCTeX bug#57720).

* test/lisp/textmodes/reftex-tests.el
(reftex-renumber-simple-labels): New Test.

2 years agoFix Tramp test
Michael Albinus [Mon, 12 Sep 2022 06:52:08 +0000 (08:52 +0200)]
Fix Tramp test

* lisp/net/tramp-compat.el (tramp-compat-rx):
Add `tramp-autoload' function property.

2 years agoFix focus restoration upon x_mouse_leave again
Po Lu [Mon, 12 Sep 2022 06:01:52 +0000 (14:01 +0800)]
Fix focus restoration upon x_mouse_leave again

* src/xterm.c (x_mouse_leave): Call xi_handle_focus_change after
changing the implicit focus.

2 years agoUpdate HISTORY for Emacs 28.2 emacs-28.2
Stefan Kangas [Mon, 12 Sep 2022 00:47:11 +0000 (02:47 +0200)]
Update HISTORY for Emacs 28.2

* etc/HISTORY: Update for the Emacs 28.2 release.

2 years ago* lisp/progmodes/xref.el: Bump the version.
Dmitry Gutov [Sun, 11 Sep 2022 21:45:12 +0000 (00:45 +0300)]
* lisp/progmodes/xref.el: Bump the version.

2 years agoRestrict replace-*-in-region to the bounds defined by caller
Kévin Le Gouguec [Sun, 11 Sep 2022 17:55:01 +0000 (19:55 +0200)]
Restrict replace-*-in-region to the bounds defined by caller

* lisp/subr.el (replace-string-in-region, replace-regexp-in-region):
Narrow to region before iterating over matches, instead of giving a
bound to the search functions.
* test/lisp/subr-tests.el (test-replace-string-in-region): Add
regression tests (bug#57733).

2 years agoDisable Tramp cache for relative file names
Michael Albinus [Sun, 11 Sep 2022 12:53:14 +0000 (14:53 +0200)]
Disable Tramp cache for relative file names

* lisp/net/tramp.el (tramp-file-name-unify):
Return `tramp-cache-undefined' if LOCALNAME is a relative file name.

* lisp/net/tramp-cache.el (tramp-get-file-property)
(tramp-set-file-property, tramp-file-property-p)
(tramp-flush-file-property, tramp-flush-file-upper-properties)
(tramp-flush-file-properties): Handle KEY being
`tramp-cache-undefined'.
(tramp-flush-file-function): Revert last change.

2 years agowhitespace: Redo BoB/EoB empty line highlighting
Richard Hansen [Tue, 28 Jun 2022 20:25:43 +0000 (16:25 -0400)]
whitespace: Redo BoB/EoB empty line highlighting

* lisp/whitespace.el (whitespace--empty-at-bob-matcher,
whitespace--empty-at-eob-matcher, whitespace--update-bob-eob,
whitespace-color-off, whitespace-color-on,
whitespace-empty-at-bob-regexp, whitespace-empty-at-eob-regexp,
whitespace-looking-back, whitespace-post-command-hook): Redo the
`empty' line highlighting logic to ensure that a buffer change causes
all affected `empty' lines to become (un)highlighted (bug#37467).
Also, for improved UX, don't highlight BoB empty lines at or below
point (not just when point is at 1), or EoB empty lines at or above
point (not just when point is `eobp').
(whitespace-bob-marker, whitespace-eob-marker): Clarify documentation.
* test/lisp/whitespace-tests.el (whitespace--with-test-buffer,
whitespace--fu, whitespace-tests--empty-bob,
whitespace-tests--empty-eob): Add tests.

2 years agowhitespace: Include empty final line in BoB empty match
Richard Hansen [Tue, 28 Jun 2022 19:05:04 +0000 (15:05 -0400)]
whitespace: Include empty final line in BoB empty match

* lisp/whitespace.el (whitespace-empty-at-bob-regexp): Include any
last line trailing whitespace in the BoB empty line match to ensure
that those characters get highlighted.

2 years agowhitespace: Reset `whitespace-buffer-changed' when refontifying
Richard Hansen [Wed, 22 Jun 2022 21:29:39 +0000 (17:29 -0400)]
whitespace: Reset `whitespace-buffer-changed' when refontifying

* lisp/whitespace.el (whitespace-post-command-hook): Add missing reset
of `whitespace-buffer-changed' back to nil between commands.

2 years ago; whitespace: Use `defvar-local' for buffer-local vars
Richard Hansen [Wed, 22 Jun 2022 23:02:42 +0000 (19:02 -0400)]
; whitespace: Use `defvar-local' for buffer-local vars

2 years ago; whitespace: Delete unused `whitespace-font-lock-refontify' var
Richard Hansen [Wed, 22 Jun 2022 22:06:49 +0000 (18:06 -0400)]
; whitespace: Delete unused `whitespace-font-lock-refontify' var

2 years agoert-x: New `ert-with-test-buffer-selected' convenience macro
Richard Hansen [Tue, 28 Jun 2022 05:10:48 +0000 (01:10 -0400)]
ert-x: New `ert-with-test-buffer-selected' convenience macro

* lisp/emacs-lisp/ert-x.el (ert-with-test-buffer-selected): New
convenience macro that extends `ert-with-test-buffer' by displaying
the test buffer in a temporary selected window.  This makes it easier
to simulate user input in the body via `execute-kbd-macro'.
* test/lisp/emacs-lisp/ert-x-tests.el
(ert-test-test-buffer-selected/*): Add tests.

2 years agoRevert "Add new command 'toggle-theme'"
Philip Kaludercic [Sun, 11 Sep 2022 11:28:38 +0000 (13:28 +0200)]
Revert "Add new command 'toggle-theme'"

This reverts commit f31b9d86a67f1b3fd70339f277dff52478890351.

2 years agoRevert "Add new user option 'custom-ensure-single-theme'"
Philip Kaludercic [Sun, 11 Sep 2022 11:28:36 +0000 (13:28 +0200)]
Revert "Add new user option 'custom-ensure-single-theme'"

This reverts commit b4dbf7184cd68ecd8d1a27fbc1407be0eae7e64c.

2 years ago; Use US spelling docstring
Philip Kaludercic [Sun, 11 Sep 2022 11:12:39 +0000 (13:12 +0200)]
; Use US spelling docstring

* lisp/vc/diff-mode.el (diff-add-log-use-relative-names): Update docstring.

2 years agoAdd new user option 'custom-ensure-single-theme'
Philip Kaludercic [Tue, 6 Sep 2022 19:04:08 +0000 (21:04 +0200)]
Add new user option 'custom-ensure-single-theme'

* etc/NEWS: Mention it.
* lisp/custom.el (custom-ensure-single-active-theme): Add it.
(load-theme): Use it.

2 years agoAdd new command 'toggle-theme'
Philip Kaludercic [Tue, 6 Sep 2022 18:53:35 +0000 (20:53 +0200)]
Add new command 'toggle-theme'

* doc/emacs/custom.texi (Custom Themes): Mention it.
* etc/themes/leuven-dark-theme.el (leuven-dark): Add dual theme.
* etc/themes/leuven-theme.el (leuven): Add dual theme.
* etc/themes/tango-dark-theme.el (tango-dark): Add dual theme.
* etc/themes/tango-theme.el (tango): Add dual theme.
* etc/themes/tsdh-dark-theme.el (tsdh-dark): Add dual theme.
* etc/themes/tsdh-light-theme.el (tsdh-light): Add dual theme.
* lisp/cus-theme.el (describe-theme-1): Say if a theme has a dual.
* lisp/custom.el (toggle-theme): Add new command.

2 years agoImprove some shell highlight doc strings
Miha Rihtaršič [Sun, 11 Sep 2022 10:59:02 +0000 (12:59 +0200)]
Improve some shell highlight doc strings

* lisp/shell.el (shell-highlight-undef-mode-restart): Rename function.
* lisp/shell.el (shell-comint-fl-enable):
(shell--highlight-undef-indirect)
* lisp/ielm.el (ielm-comint-fl-enable):
* lisp/comint.el: (comint--fl-fontify-region): Improve doc strings.

2 years agoMake it easier to clear the Motif drag window for debugging
Po Lu [Sun, 11 Sep 2022 08:50:16 +0000 (16:50 +0800)]
Make it easier to clear the Motif drag window for debugging

* src/xterm.c (xm_get_drag_window_1): Add comment explaining
side effect of x_special_window_exists_p.
(handle_one_xevent): Clear Motif drag window upon DestroyNotify.
In addition to debugging, it also reduces syncs necessary to
communicate via the Motif protocol after a defective/old client
sets the drag window without setting the disconnect mode.

2 years ago* lisp/vc/vc.el (vc-diff-patch-string): Fix arg in revert-buffer-function.
Juri Linkov [Sun, 11 Sep 2022 08:22:11 +0000 (11:22 +0300)]
* lisp/vc/vc.el (vc-diff-patch-string): Fix arg in revert-buffer-function.

2 years ago* lisp/vc/vc.el (vc-deduce-backend): Handle eshell-mode.
Sean Whitton [Sun, 11 Sep 2022 06:10:45 +0000 (23:10 -0700)]
* lisp/vc/vc.el (vc-deduce-backend): Handle eshell-mode.

2 years agoFix project-remember-projects-under when recursing
ookami [Sat, 10 Sep 2022 12:56:08 +0000 (14:56 +0200)]
Fix project-remember-projects-under when recursing

* lisp/progmodes/project.el (project-remember-projects-under):
Actually recurse into directories (bug#57714).

Copyright-paperwork-exempt: yes

2 years agoEnsure, that Tramp cache works over absolute file names
Michael Albinus [Sat, 10 Sep 2022 11:10:47 +0000 (13:10 +0200)]
Ensure, that Tramp cache works over absolute file names

* lisp/net/tramp.el (tramp-skeleton-directory-files)
(tramp-skeleton-directory-files-and-attributes)
(tramp-skeleton-set-file-modes-times-uid-gid)
(tramp-handle-add-name-to-file, tramp-handle-file-exists-p)
(tramp-handle-file-readable-p, tramp-handle-file-writable-p):
* lisp/net/tramp-adb.el (tramp-adb-handle-file-executable-p)
(tramp-adb-handle-file-exists-p)
(tramp-adb-handle-file-readable-p)
(tramp-adb-handle-file-writable-p)
* lisp/net/tramp-gvfs.el (tramp-gvfs-info, tramp-gvfs-handle-delete-file)
(tramp-gvfs-get-directory-attributes)
(tramp-gvfs-get-root-attributes)
(tramp-gvfs-handle-file-executable-p):
* lisp/net/tramp-sh.el (tramp-sh-handle-make-symbolic-link)
(tramp-sh-handle-file-exists-p)
(tramp-sh-handle-set-visited-file-modtime)
(tramp-sh-handle-file-selinux-context)
(tramp-sh-handle-set-file-selinux-context)
(tramp-sh-handle-file-acl, tramp-sh-handle-file-executable-p)
(tramp-sh-handle-file-readable-p)
(tramp-sh-handle-file-directory-p)
(tramp-sh-handle-file-writable-p)
(tramp-sh-handle-file-ownership-preserved-p)
(tramp-sh-handle-add-name-to-file)
(tramp-sh-handle-copy-directory, tramp-sh-handle-delete-file)
(tramp-sh-handle-dired-compress-file):
* lisp/net/tramp-sudoedit.el (tramp-sudoedit-handle-add-name-to-file)
(tramp-sudoedit-handle-delete-file)
(tramp-sudoedit-handle-file-acl)
(tramp-sudoedit-handle-file-executable-p)
(tramp-sudoedit-handle-file-exists-p)
(tramp-sudoedit-handle-file-readable-p)
(tramp-sudoedit-handle-file-selinux-context)
(tramp-sudoedit-handle-file-writable-p)
(tramp-sudoedit-handle-make-symbolic-link)
(tramp-sudoedit-handle-set-file-selinux-context):
Use `expand-file-name'.  (Bug#57572)

* lisp/net/tramp-cache.el (tramp-flush-file-function):
Expand `buffer-file-name'.  (Bug#57676)

* lisp/net/tramp.el (tramp-file-name-unify): Extend error message.

* lisp/net/tramp-sh.el (tramp-sh-handle-make-symbolic-link):
* lisp/net/tramp-smb.el (tramp-smb-handle-make-symbolic-link):
* lisp/net/tramp-sudoedit.el (tramp-sudoedit-handle-make-symbolic-link):
Do not check remoteness of TARGET anymore.

2 years agoFix compliance with the XDND specification when dropping on a proxy
Po Lu [Sat, 10 Sep 2022 10:49:53 +0000 (18:49 +0800)]
Fix compliance with the XDND specification when dropping on a proxy

* src/xterm.c (x_dnd_send_enter, x_dnd_send_position)
(x_dnd_send_leave, x_dnd_send_drop, x_dnd_do_drop): New
parameter `toplevel'.  Use it as the window in sent client
messages.
(x_dnd_cancel_dnd_early, x_dnd_cleanup_drag_and_drop)
(x_dnd_process_quit, x_dnd_update_state, handle_one_xevent)
(x_connection_closed): Give the right toplevel to the client
message sending functions.

2 years ago; * lisp/minibuffer.el (format-prompt): Doc fix.
Eli Zaretskii [Sat, 10 Sep 2022 08:48:11 +0000 (11:48 +0300)]
; * lisp/minibuffer.el (format-prompt): Doc fix.

2 years agoMake wdired match dired with symlink permissions
Paul Eggert [Sat, 10 Sep 2022 06:20:31 +0000 (08:20 +0200)]
Make wdired match dired with symlink permissions

* lisp/wdired.el (wdired-do-perm-changes): Do not follow symlinks,
to be consistent with plain dired (bug#50189).

2 years agoMake `format-prompt' use `substitute-command-keys'
Lars Ingebrigtsen [Sat, 10 Sep 2022 06:13:21 +0000 (08:13 +0200)]
Make `format-prompt' use `substitute-command-keys'

* doc/lispref/minibuf.texi (Text from Minibuffer): Mention it.
* lisp/minibuffer.el (format-prompt): Run through
`substitute-command-keys' (bug#51040).

2 years agoFix diff-mode.el compilation warnings
Lars Ingebrigtsen [Sat, 10 Sep 2022 06:01:55 +0000 (08:01 +0200)]
Fix diff-mode.el compilation warnings

* lisp/vc/diff-mode.el (diff-auto-refine-mode): Suppress
byte-compile warnings.

2 years agoNew function substitute-quotes
Stefan Kangas [Sat, 10 Sep 2022 05:37:36 +0000 (07:37 +0200)]
New function substitute-quotes

* lisp/help.el (substitute-quotes): New function.  (Bug#51040)
* doc/lispref/help.texi (Keys in Documentation): Document
substitute-quotes.
* test/lisp/help-tests.el (help-tests-substitute-quotes): New test.

* lisp/cedet/srecode/srt-mode.el (srecode-macro-help):
* lisp/cus-theme.el (describe-theme-1):
* lisp/emacs-lisp/cl-extra.el (cl--describe-class):
* lisp/emacs-lisp/eieio-opt.el (eieio-help-constructor):
* lisp/emacs-lisp/package.el (describe-package-1):
* lisp/help-fns.el (help-fns--parent-mode, help-fns--var-risky)
(help-fns--var-file-local, help-fns--var-bufferlocal)
(describe-face):
* lisp/help.el (substitute-command-keys):
* lisp/progmodes/octave.el (octave-help): Use the new function
instead of 'substitute-command-keys'.

2 years agoDoc fixes for 'text-quoting-style'
Stefan Kangas [Sat, 10 Sep 2022 05:29:48 +0000 (07:29 +0200)]
Doc fixes for 'text-quoting-style'

* doc/lispref/help.texi (Keys in Documentation): Remove duplicate
entry for 'text-quoting-style'.  Document the function with the same
name instead.
* src/doc.c (Ftext_quoting_style): Doc fix: clarify the return values.
(syms_of_doc) <Vtext_quoting_style>: Doc fix: clarify that you should
not read the value of this variable directly; use Ftext_quoting_style
instead (bug#51040).

2 years agoMake a flymake.texi code example more resilient
Lars Ingebrigtsen [Sat, 10 Sep 2022 04:52:39 +0000 (06:52 +0200)]
Make a flymake.texi code example more resilient

* doc/misc/flymake.texi (An annotated example backend): Make the
example code resilient wrt. narrowed buffers (bug#51437).

2 years ago* src/w32image.c (w32_can_use_native_image_api): Fix comment.
Stefan Kangas [Sat, 10 Sep 2022 03:29:54 +0000 (05:29 +0200)]
* src/w32image.c (w32_can_use_native_image_api): Fix comment.

2 years agoSupport outline-minor-mode in emacs-authors-mode
Stefan Kangas [Sat, 10 Sep 2022 03:03:58 +0000 (05:03 +0200)]
Support outline-minor-mode in emacs-authors-mode

* lisp/textmodes/emacs-authors-mode.el (emacs-authors-mode):
Support and enable outline-minor-mode.

2 years ago; * src/alloc.c (check_pure_size): Fix last change.
Po Lu [Sat, 10 Sep 2022 01:39:14 +0000 (09:39 +0800)]
; * src/alloc.c (check_pure_size): Fix last change.

2 years agoFix several printfs for 32 bit systems
Po Lu [Sat, 10 Sep 2022 01:35:49 +0000 (09:35 +0800)]
Fix several printfs for 32 bit systems

* lib-src/emacsclient.c (main): Use right length modifier when
printing uintmax_t.
* src/alloc.c (check_pure_size): Use right length modifier when
printing ptrdiff_t.

2 years ago* lisp/subr.el (string-split): New alias for split-string.
Stefan Kangas [Fri, 9 Sep 2022 21:51:05 +0000 (23:51 +0200)]
* lisp/subr.el (string-split): New alias for split-string.

2 years agoSet vc-git-annotate-switches to "-w" in .dir-locals.el
Stefan Kangas [Fri, 9 Sep 2022 21:39:24 +0000 (23:39 +0200)]
Set vc-git-annotate-switches to "-w" in .dir-locals.el

* .dir-locals.el: Set vc-git-annotate-switches to "-w".
Ref: https://lists.gnu.org/r/emacs-devel/2022-09/msg00453.html

2 years agoAccept "-w" as safe value for vc-git-annotate-switches
Stefan Kangas [Fri, 9 Sep 2022 21:56:24 +0000 (23:56 +0200)]
Accept "-w" as safe value for vc-git-annotate-switches

* lisp/vc/vc-git.el
(vc-git-annotate-switches-safe-p): New predicate function.
(vc-git-annotate-switches): Use above new predicate function to
check if it's :safe.

2 years agoFix problem with Glib 2.73.2+ and SIGCHLD handler
Paul Eggert [Fri, 9 Sep 2022 20:22:16 +0000 (15:22 -0500)]
Fix problem with Glib 2.73.2+ and SIGCHLD handler

This code fix is by Stefan Monnier (Bug#57699).
* src/process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
Adjust to Glib 2.73.2 behavior change on Linux kernel 5.3+.

2 years ago; Fix doc strings in shell.el
Eli Zaretskii [Fri, 9 Sep 2022 19:10:00 +0000 (22:10 +0300)]
; Fix doc strings in shell.el

* lisp/shell.el (shell-highlight-undef-defined-face)
(shell-highlight-undef-remote-file-name-inhibit-cache)
(shell--highlight-undef-exec-cache): Fix wording and typos.