Fix building on Emacs 24.3

This fixes the following error:
use-package-core.el:60:32:Error: Cannot open load file: subr-x

Fix tests on Emacs 26 or older

This fixes the following error in Emacs 25.3:

In toplevel form:
bind-key.el:549:1:Error: the function ‘mapcan’ is not known to be defined.

Merge pull request from andreyorst/face-spec-set-third-argument

GitHub-reference: https://github.com/jwiegley/use-package/issues/1009

Allow passing the SPEC-TYPE argument via :custom-face

GitHub-reference: https://github.com/jwiegley/use-package/issues/1008
Copyright-paperwork-exempt: yes

Merge pull request from bhankas/master

GitHub-reference: https://github.com/jwiegley/use-package/issues/1007

Bump version to 2.4.3

bind-key.el: Bump version for ELPA

Merge pull request from andreyorst/face-spec-set

GitHub-reference: https://github.com/jwiegley/use-package/issues/1004

Merge pull request from bhankas/master

GitHub-reference: https://github.com/jwiegley/use-package/issues/1006

Update version to 2.4.2

In preparation for inclusion to GNU ELPA.

Merge pull request from bhankas/master

GitHub-reference: https://github.com/jwiegley/use-package/issues/1005

Update copyright for submission to ELPA

- Update year to 2022
- Set copyright to Free Software Foundation, Inc.

Use face-spec-set instead of custom-set-faces

GitHub-reference: https://github.com/jwiegley/use-package/issues/934
Copyright-paperwork-exempt: yes

Merge pull request from conao3/add-commands-keyword

GitHub-reference: https://github.com/jwiegley/use-package/issues/917

Merge pull request from sdwolfz/native-compiler-warning

GitHub-reference: https://github.com/jwiegley/use-package/issues/998

Fix emacs native compilation warning for bind-key

To reproduce, have emacs built with native compilation and notice the
compilation logs. You can then open the offending file and run `M-x
emacs-lisp-native-compile-and-load` before and after the changes to see
the warning is removed.

```
 ■  Warning (comp): bind-key.el:150:2: Warning: docstring has wrong
usage of unescaped single quotes (use \= or different quoting)
```

Merge pull request from CeleritasCelery/master

GitHub-reference: https://github.com/jwiegley/use-package/issues/743

Merge pull request from sdwolfz/native-compiler-warning

GitHub-reference: https://github.com/jwiegley/use-package/issues/997

Fix emacs native compilation warning

```
 ■  Warning (comp): use-package-core.el:907:2: Warning: docstring has
wrong usage of unescaped single quotes (use \= or different quoting)
 ■  Warning (comp): use-package-core.el:930:2: Warning: docstring has
wrong usage of unescaped single quotes (use \= or different quoting)
```

To reproduce, have emacs build with native compilation and notice the
compilation logs. You can then open this file and run `M-x
emacs-lisp-native-compile-and-load` before and after the changes to see the
warning is removed.

Revert "Remove use-package-font-lock-keywords"

This reverts commit 4938167bfffcf08279445827d2eaae78c9557675.

Merge pull request from belak/remove-extra-font-lock-keywords

GitHub-reference: https://github.com/jwiegley/use-package/issues/859

Merge pull request from realcomplex/override-global-mode-fix

GitHub-reference: https://github.com/jwiegley/use-package/issues/993

Go back to making `override-global-mode` non-global

Copyright-paperwork-exempt: yes

Make sure that bind-key's `override-global-mode` is initially on

In 4004dde the arguments to `define-minor-mode` were changed
erroneously. Whereas the `override-global-mode` was initially defined
as `(define-minor-mode override-global-mode "..." t "")`, the two
latter arguments where changed to `:global t :lighter ""`. However,
the two original arguments corresponded to the keywords `:init-value`
and `:lighter`, respectively.

With `:init-value t` now missing, the minor mode isn't enabled by
default, and `bind-key*` appears not to work.

Copyright-paperwork-exempt: yes

Merge pull request from tarsiiformes/quote-quote

GitHub-reference: https://github.com/jwiegley/use-package/issues/990

Quote single quotes in docstrings or use different quoting

The byte-compiler started pointing this out:
  Warning: docstring has wrong usage of unescaped single
  quotes (use \= or different quoting)

Merge pull request from tarsiiformes/cleanup-manual

GitHub-reference: https://github.com/jwiegley/use-package/issues/968

manual: Regenerate texi file

Merge pull request from conao3/fix-declare-style

GitHub-reference: https://github.com/jwiegley/use-package/issues/760

Merge pull request from waymondo/ensure-system-packages-use-package-as-one

GitHub-reference: https://github.com/jwiegley/use-package/issues/774

Merge pull request from waymondo/use-package-hook-handler-flatten-mode-symbols

GitHub-reference: https://github.com/jwiegley/use-package/issues/775

Merge pull request from waymondo/use-package-chords-autoloading-and-mapping-improvements

GitHub-reference: https://github.com/jwiegley/use-package/issues/778

Merge pull request from matzebond/master

GitHub-reference: https://github.com/jwiegley/use-package/issues/787

Merge pull request from wcy123/master

GitHub-reference: https://github.com/jwiegley/use-package/issues/822

Merge pull request from phst/lex

GitHub-reference: https://github.com/jwiegley/use-package/issues/848

Merge pull request from phst/flet

GitHub-reference: https://github.com/jwiegley/use-package/issues/849

Merge pull request from conao3/add-custom-face-description

GitHub-reference: https://github.com/jwiegley/use-package/issues/863

Merge pull request from iaeerfung/master

GitHub-reference: https://github.com/jwiegley/use-package/issues/912

Merge pull request from wyuenho/set-default-use-package-enable-imenu-support

GitHub-reference: https://github.com/jwiegley/use-package/issues/920

Merge pull request from wyuenho/statistics-sorting

GitHub-reference: https://github.com/jwiegley/use-package/issues/921

Merge pull request from Hugo-Heagren/bind-keys-repeat-map

GitHub-reference: https://github.com/jwiegley/use-package/issues/974

Merge pull request from danielpza/add-update-custom-package

GitHub-reference: https://github.com/jwiegley/use-package/issues/930

Merge pull request from tarsiiformes/silencio

GitHub-reference: https://github.com/jwiegley/use-package/issues/936

Merge pull request from DamienCassou/update-texi

GitHub-reference: https://github.com/jwiegley/use-package/issues/979

Merge pull request from skangas/fix-typo

GitHub-reference: https://github.com/jwiegley/use-package/issues/987

Add: 'local' keyword

Avoid positional arguments to define-minor-mode

Back in Emacs-21.1, `define-minor-mode' grew keyword arguments to
replace its old positional arguments.  Starting with Emacs-28.1
a warning will be omitted if positional arguments are still used.

Fix typo in use-package docstring

Update use-package.texi

optimization: constand folding for read-kbd-macro

to boost startup performance, it is better to avoid invoking
`read-kbd-macro` at run time which requires 'cl-lib.

it takes ~20ms to load cl-lib

Copyright-paperwork-exempt: yes

bind-keys-form: error for repeat sub-keywords without :repeat-map

Error descriptively if :continue or :exit is specified without
:repeat-map.

bind-key-form: allow :continue keyword inside repeat map

Purely syntactic sugar, using :continue is the same as not using any
keyword inside :repeat-map at all.

Amend end of function to pass repeat-map value onto next invocation in
recursive uses. This allows for the same repeat map to be used for
:exit and :continue.

bind-key-form: allow :exit keyword inside repeat map

Keys bound inside the scope of :exit are bound inside the repeat map,
but do not have their repeat-map property set (so they run a function,
but 'exit' the map).

bind-keys-form: new keyword :repeat-map, for defining repeat maps

use-package-normalize/:bind: allow keyword :repeat-map.

bind-keys-form: Add keyword :repeat-map. Specifying a symbol as the
repeat-map defines a keymap with that name (and with the docstring
`repeat-doc', if specified). Symbols for functions bound to keys under
the scope of :repeat-map have their 'repeat-map property set to this
map. Update docstring (and that of `bind-keys') to reflect changes.

Rename `doc' to `prefix-doc' for clarity and consistency with
'repeat-doc'.

Fix tests and documentation for hook

Auto detect mode suffix in hook keyword

feat: add update custom packages command

Copyright-paperwork-exempt: yes

Properly sort use-package-statistics-report

Fix void-variable use-package-enable-imenu-support

Remove uses of deprecated ‘flet’ macro

Instead, use the non-deprecated ‘cl-flet’ and ‘cl-letf’ macros from the
‘cl-lib’ package.

This also allows us to remove the ‘plist-delete’ helper function, which was
only used to effectively un-deprecate ‘flet’.

add testcase

add autoload keyword

:autoload is similar to :command but this generate autoload
statement as *no-interactive* function.

fix docstring. was: invalid function name

Copyright-paperwork-exempt: yes

Merge pull request from minad/improved-unbind

GitHub-reference: https://github.com/jwiegley/use-package/issues/910

unbind-key: Ensure that keys are removed from the keymap

* The removal from the keymap is performed by bind-key--remove
* Use the same argument normalization as bind-key

bind-key: Use new symbols for kmapvar

Merge pull request from tzz/tzz/use-package-use-theme

Add use-package-use-theme and avoid missing theme errors
GitHub-reference: https://github.com/jwiegley/use-package/issues/907

Add use-package-use-theme and avoid missing theme errors

Merge pull request from kljohann/custom-use-single-let

Use a single let binding when expanding consecutive :custom forms
GitHub-reference: https://github.com/jwiegley/use-package/issues/906

Use a single let binding when expanding consecutive :custom forms

Copyright-paperwork-exempt: yes

Merge pull request from tzz/tzz/remove-use-package-from-custom-enabled-themes

Remove use-package theme from global list of custom-enabled-themes
GitHub-reference: https://github.com/jwiegley/use-package/issues/899

Remove use-package theme from global list of custom-enabled-themes

* eval-when-compile for cases where use-package is only required at
  compile time

* remove the 'use-package theme from custom-enabled-themes so e.g.
  (mapc #'disable-theme custom-enabled-themes)
  won't kill user settings.

Merge pull request from tzz/tzz/set-comment-and-synthetic-theme

GitHub-reference: https://github.com/jwiegley/use-package/issues/881

Create new "use-package" themse and use it for :custom with custom-theme-set-variables

set property theme-value to avoid saving variable

Revert "use-package-core.el: use the Emacs set-default function to avoid saving :custom vars twice"

This reverts commit 8c31c57106e2938d627bf4107627c003620d2dd5.

set saved-variable-comment from :custom

GitHub-reference: https://github.com/jwiegley/use-package/issues/861

Update version to 2.4.1

add multiple and eval :custom-face usage

This commit follows suggestion at https://github.com/jwiegley/use-package/issues/696, https://github.com/jwiegley/use-package/issues/821

Remove use-package-font-lock-keywords

Copyright-paperwork-exempt: yes

Merge pull request from wyuenho/patch-1

GitHub-reference: https://github.com/jwiegley/use-package/issues/846

Migrate remaining files to lexical binding

Merge branch 'master' into patch-1

Merge pull request from tzz/custom-set-default

GitHub-reference: https://github.com/jwiegley/use-package/issues/855

Update the documentation for :custom as per

GitHub-reference: https://github.com/jwiegley/use-package/issues/850

Fix broken test due to

GitHub-reference: https://github.com/jwiegley/use-package/issues/850

better tests

add test for

GitHub-reference: https://github.com/jwiegley/use-package/issues/845

Support keymap symbol in bind-key

GitHub-reference: fix https://github.com/jwiegley/use-package/issues/845

Merge pull request from tzz/custom-set-default

use-package-core.el: use the Emacs set-default function to avoid saving :custom vars twice
GitHub-reference: https://github.com/jwiegley/use-package/issues/850

use-package-core.el: use the Emacs set-default function to avoid saving :custom vars twice

Merge pull request from jjlee/call-hooks-even-if-no-config

GitHub-reference: https://github.com/jwiegley/use-package/issues/840

Merge branch 'master' into call-hooks-even-if-no-config

Merge pull request from nahuel/patch-1

GitHub-reference: https://github.com/jwiegley/use-package/issues/843

typo, should be a vector, not a bytecode object

Solves https://github.com/jwiegley/use-package/issues/842

Add special value back again, in case needed for backwards compat

I don't know why this special value exists, but perhaps old client code uses it.

The additional `t' in the macro expansion is accidental but not harmful I guess.

Copyright-paperwork-exempt: yes

Even when there's no :config, run any pre/post config hooks

i.e., following the existing docs for use-package-inject-hooks, these hooks are
run:

use-package--foo--pre-config-hook
use-package--foo--post-config-hook

This should make config customisations more predictable (for example, spacemacs
uses these hooks extensively to allow 'layers' to be customised).

I got rid of the "special" default value for :config, because it doesn't seem to
be treated any differently than nil.

Fixes https://github.com/jwiegley/use-package/issues/785

Copyright-paperwork-exempt: yes

Merge pull request from jwiegley/johnw/clarify

Clarify the documentation for :after
GitHub-reference: https://github.com/jwiegley/use-package/issues/820

Clarify the documentation for :after

Merge pull request from DamienCassou/typos

Fix typos
GitHub-reference: https://github.com/jwiegley/use-package/issues/808