Glenn Morris [Tue, 14 Sep 2021 23:27:42 +0000 (16:27 -0700)]
* test/Makefile.in (XDG_CONFIG_HOME): Don't export (bug#50577).
Glenn Morris [Tue, 14 Sep 2021 21:27:41 +0000 (14:27 -0700)]
* doc/misc/flymake.texi: Avoid xrefs in @copying.
This isn't really what @copying is for, and doesn't work with
makeinfo 4.13.
João Távora [Tue, 14 Sep 2021 18:22:28 +0000 (19:22 +0100)]
Unbreak make bootstrap (don't use cl-defun's &aux parameters)
* lisp/progmodes/flymake.el (flymake--handle-report): Don't use &aux.
Harald Jörg [Tue, 14 Sep 2021 15:53:52 +0000 (17:53 +0200)]
cperl-mode.el: Allow non-ASCII Perl identifiers
Replace all "A-Z" regexp literals with unicode-aware rx constructs
wherever Perl allows non-ASCII identifiers.
* lisp/progmodes/cperl-mode.el (cperl-after-sub-regexp)
(cperl-after-label. cperl-sniff-for-indent)
(cperl-find-pods-heres, cperl-indent-exp)
(cperl-fix-line-spacing, cperl-imenu--create-perl-index)
(cperl-init-faces, cperl-find-tags):
Replace ASCII regex literals by unicode-aware rx constructs.
(cperl-init-faces): Eliminate unused lexical `font-lock-anchored'.
(cperl-have-help-regexp, cperl-word-at-point-hard): Allow non-ASCII
word characters.
* test/lisp/progmodes/cperl-mode-tests.el
(cperl-test-fontify-special-variables): New test for $^T
and $^{VARNAME}.
(cperl-test-ws-rx cperl-test-ws+-rx),
(cperl-test-version-regexp, cperl-test-package-regexp): Skip
for perl-mode.
(cperl-test-identifier-rx, cperl--test-unicode-setup)
(cperl-test-unicode-labels, cperl-test-unicode-sub)
(cperl-test-unicode-varname)
(cperl-test-unicode-varname-list, cperl-test-unicode-arrays)
(cperl-test-unicode-hashes, cperl-test-unicode-hashref)
(cperl-test-unicode-proto, cperl-test-unicode-fhs)
(cperl-test-unicode-hashkeys, cperl-test-word-at-point):
New tests for unicode identifiers.
(cperl-test-imenu-index): Add a unicode identifier to the test.
* test/lisp/progmodes/cperl-mode-resources/grammar.pl: Add a
function with non-ASCII name for imenu tests.
Glenn Morris [Tue, 14 Sep 2021 15:05:29 +0000 (08:05 -0700)]
* lisp/emacs-lisp/checkdoc.el (checkdoc-symbol-words): Fix type.
Alan Third [Tue, 14 Sep 2021 12:03:37 +0000 (13:03 +0100)]
A further fix for toolbar visibility problems on macOS (bug#50534)
* src/nsterm.m (ns_update_begin): Ensure the toolbar's visibility is
set correctly.
Eli Zaretskii [Tue, 14 Sep 2021 13:47:40 +0000 (16:47 +0300)]
Fix recent changes in Flymake manual
* doc/misc/flymake.texi: Fix typos. Downcase the first word of
each index entry, for more reliable sorting.
(Starting Flymake, Finding diagnostics, Troubleshooting): Fix
typos.
Lars Ingebrigtsen [Tue, 14 Sep 2021 11:44:15 +0000 (13:44 +0200)]
Make `find-function-source-path' into obsolete alias
* lisp/finder.el (finder-commentary): Adjust usage.
* lisp/emacs-lisp/find-func.el (find-function-source-path): Made
into obsolete alias (bug#50508).
(find-library-source-path): New name.
(find-library-name, find-library, find-function-noselect)
(find-variable-noselect, find-definition-noselect): Adjust usage
and update doc strings.
João Távora [Sun, 12 Sep 2021 21:16:35 +0000 (22:16 +0100)]
Re-organize and rewrite parts of the Flymake manual
bug#50244
* doc/misc/flymake.texi (Starting Flymake): New section.
(Finding diagnostics): New section, now contains info previously in
"Listing diagnostics"
(Mode line status): Renamed from "Mode-line syntax check status"
(Troubleshooting): Renamed from "Backend exceptions".
(Flymake error types): Tweak phrasing.
João Távora [Wed, 1 Sep 2021 22:45:53 +0000 (23:45 +0100)]
Add support for project-wide diagnostics in Flymake (bug#50244)
This is done with two new concepts: "foreign diagnostics" and
"list-only diagnostics". The manual has been updated with a
description of these new concepts.
* doc/misc/flymake.texi (Flymake utility functions):
Explain creation of foreign diagnostics.
(Foreign and list-only diagnostics): New subsection.
(Listing diagnostics): New subsection.
* lisp/progmodes/flymake.el
(Version): Bump to 1.2.1
(project): Require project.
(flymake--diag): Add new slots 'orig-beg' and 'orig-end'. Rename
'buffer' slot to 'locus'.
(flymake-make-diagnostic): Rework docstring. Accept stringp
LOCUS arg.
(flymake-diagnostic-beg, flymake-diagnostic-end)
(flymake-diagnostic-buffer): Simplify definition.
(flymake--equal-diagnostic-p): New helper
(flymake--highlight-line): Rework. Accept FOREIGN arg.
(flymake--state): Work docstring. Add new slot 'foreign-diags'
(flymake--handle-report): Call
flymake--update-diagnostics-listings.
(flymake--handle-report): New helper.
(flymake--mode): Forward declare.
(flymake--handle-report): Rework for foreign diagnostics.
(flymake-mode): When turning on, notice any Flymake diagnostics
for current buffer. When turning off update diagnostics listings.
(flymake-kill-buffer-hook): Turn off flymake explicitly before
killing.
(flymake--mode-line-counter): Use flymake-diagnostics to collect
diagnostics.
(flymake-show-diagnostic): Visit buffer of file-specific
diagnostic.
(flymake--tabulated-entries-1): New helper extracted from
flymake--diagnostic-buffer-entries.
(flymake--diagnostics-buffer-entries): Rework.
(flymake--diagnostics-base-tabulated-list-format): New helper.
(flymake--diagnostics-buffer-name): Adjust.
(flymake-list-only-diagnostics): New variable.
(flymake--project-diagnostic-list-project): New variable.
(flymake--clear-list-only-diagnostics): New helper.
(flymake-project-diagnostics-mode): New major mode.
(flymake--project-diagnostics)
(flymake--project-diagnostics-entries)
(flymake--project-diagnostics-buffer): New helpers.
(flymake-show-project-diagnostics): New command.
(flymake--update-diagnostics-listings): New helper.
(flymake-show-buffer-diagnostics): Renamed from flymake-diagnostics-buffer.
* etc/NEWS: Mention change.
João Távora [Mon, 13 Sep 2021 16:43:43 +0000 (17:43 +0100)]
Bump lisp/progmodes/project.el version to 0.7.1
Amont other things exposes the new project-buffers generic function to
ELPA users.
* lisp/progmodes/project.el (Version): Bump to 0.7.1
João Távora [Mon, 30 Aug 2021 15:24:25 +0000 (16:24 +0100)]
Keep and report "foreign" diangnostics in flymake-cc Flymake backend
This includes diagnostics for .h files that sprang up when checking a
c file. Those diagnostics are reported to the Flymake infrastructure
which does not (yet) do anything with them.
This includes a change to the test fixtures, too.
* lisp/progmodes/flymake-cc.el (flymake-cc--make-diagnostics): Rework
* test/lisp/progmodes/flymake-resources/another-problematic-file.c:
New file.
* test/lisp/progmodes/flymake-resources/some-problems.h:
Add a function declaration..
João Távora [Fri, 3 Sep 2021 18:03:51 +0000 (19:03 +0100)]
Abbreviate Flymake backend name in flymake-show-diagnostics-buffer
* lisp/progmodes/flymake.el (flymake--diagnostics-buffer-entries):
(flymake-diagnostics-buffer-mode): Report abbreviated backend, too.
João Távora [Tue, 31 Aug 2021 17:32:58 +0000 (18:32 +0100)]
Unbreak M-x compile-defun of functions using flymake-log
* lisp/progmodes/flymake.el (flymake-log): Check if compilation unit
is indeed a string before treating it as a file name.
João Távora [Tue, 31 Aug 2021 17:43:12 +0000 (18:43 +0100)]
Refactor some Flymake functions
* lisp/progmodes/flymake.el (flymake-diagnostic-buffer): New
helper.
(flymake-diagnostic-beg, flymake-diagnostic-end): Tweak docstring.
(flymake--handle-report): Simplify.
(flymake--publish-diagnostics): Helper for flymake--handle-report.
(flymake--mode-line-counter, flymake-show-diagnostic)
(flymake--diagnostics-buffer-entries): Use
flymake-diagnostic-buffer, flymake-diagonstic-type,
flymake-diagnostic-beg.
João Távora [Sun, 29 Aug 2021 21:35:46 +0000 (22:35 +0100)]
Rename flymake--backend-state to flymake--state
The previous name was confusing and akward and dreadful to type and
read.
* lisp/progmodes/flymake.el (flymake--state): Rename from
flymake--backend-state.
(flymake--with-backend-state): Use flymake--state.
(flymake--handle-report): Use flymake--state.
(flymake--collect): Use flymake--state.
(flymake-running-backends): Use flymake--state.
(flymake--disable-backend): Use flymake--state.
(flymake--run-backend): Use flymake--state.
(flymake-start): Use flymake--state.
(flymake-mode): Use flymake--state.
(flymake--mode-line-title): Use flymake--state.
(flymake--mode-line-exception): Use flymake--state.
(flymake--mode-line-counter): Use flymake--state.
Lars Ingebrigtsen [Tue, 14 Sep 2021 11:21:47 +0000 (13:21 +0200)]
Project File Commands manual clarification
* doc/emacs/maintaining.texi (Project File Commands): Clarify what
happens with the file name under point.
Alan Third [Mon, 13 Sep 2021 19:09:22 +0000 (20:09 +0100)]
Fix incorrectly appearing toolbar on NS (bug#50534)
* src/nsmenu.m (update_frame_tool_bar): Ensure both sides of the test
are booleans.
* src/nsterm.m ([EmacsWindow createToolbar:]): Make the toolbar
non-visible initially, in case things get out of sync. Remove call to
update_frame_tool_bar: the window isn't yet associated with the view,
so it will return immediately.
Alan Third [Thu, 9 Sep 2021 21:33:01 +0000 (22:33 +0100)]
Fix libgccjit detection on macOS
* configure.ac: Combine the Homebrew and MacPorts detection so they
will not create nonsense flags if both are installed.
Juri Linkov [Tue, 14 Sep 2021 06:42:11 +0000 (09:42 +0300)]
* lisp/tab-bar.el: Close tab only on mouse-1, not down-mouse-1 (bug#41343)
* lisp/tab-bar.el (tab-bar-mouse-select-tab): Don't close the tab
when clicked on the close button.
(tab-bar-mouse-close-tab-from-button): New function.
(tab-bar-map): Bind [mouse-1] to 'tab-bar-mouse-close-tab-from-button'.
(tab-bar-mouse-move-tab): Do nothing on non-tab events.
Stefan Kangas [Tue, 14 Sep 2021 06:15:15 +0000 (08:15 +0200)]
; * lisp/emacs-lisp/checkdoc.el: Fix typo in previous commit.
Stefan Kangas [Tue, 14 Sep 2021 05:55:56 +0000 (07:55 +0200)]
; More minor docfixes found by checkdoc
Stefan Kangas [Mon, 13 Sep 2021 19:57:13 +0000 (21:57 +0200)]
Add user option to avoid checkdoc warning for unescaped left paren
* lisp/emacs-lisp/checkdoc.el
(checkdoc-column-zero-backslash-before-paren): New user option to
avoid warning on unescaped left parenthesis in column zero.
(checkdoc-this-string-valid-engine): Respect above new option.
Stefan Kangas [Mon, 13 Sep 2021 05:17:50 +0000 (07:17 +0200)]
Minor improvements to checkdoc
* lisp/emacs-lisp/checkdoc.el (checkdoc-symbol-words): Add ignored
values.
(checkdoc-proper-noun-list): Remove XEmacs from list of words to
capitalize; there is little need to insist on consistency here.
(checkdoc-in-abbreviation-p): Add abbreviation "etc." and sort entries
alphabetically.
Dmitry Gutov [Mon, 13 Sep 2021 21:56:20 +0000 (00:56 +0300)]
Use the term "future history" rather than "default"
* lisp/progmodes/project.el
(project-find-file, project-or-external-find-file):
Update docstring.
(project--read-file-cpd-relative, project--read-file-absolute)
(project--completing-read-strict): Rename DEFAULT to MB-DEFAULT.
(project-find-file-in): Rename FILENAME to SUGGESTED-FILENAME.
Dmitry Gutov [Mon, 13 Sep 2021 21:53:05 +0000 (00:53 +0300)]
Make sure to return some valid project root
* lisp/progmodes/project.el (project-prompt-project-dir):
If the user just pressed RET on prompt, prompt again.
Juri Linkov [Mon, 13 Sep 2021 18:41:24 +0000 (21:41 +0300)]
* lisp/progmodes/elisp-mode.el (elisp-context-menu): New function (bug#9054)
(emacs-lisp-mode): Add elisp-context-menu to context-menu-functions.
Juri Linkov [Mon, 13 Sep 2021 18:18:30 +0000 (21:18 +0300)]
* lisp/isearch.el: Improve 'isearch-allow-motion' feature (bug#50466)
* lisp/isearch.el: Add recenter to 'isearch-motion' property of
'end-of-buffer' to maximize the number of search hits on the screen.
In 'isearch-motion' property of 'scroll-up-command' use 'recenter 0'
for the first line of the screen.
(isearch-beginning-of-buffer)
(isearch-end-of-buffer): Sync logic from 'isearch-allow-motion' part
of isearch-pre-command-hook. Direct users to isearch-allow-motion
in the docstrings.
(isearch-pre-command-hook): Don't override shifted 'isearch-yank-on-move'
in 'isearch-allow-motion'.
Mattias Engdegård [Mon, 13 Sep 2021 16:38:59 +0000 (18:38 +0200)]
Remove duplication of `find` file pattern arguments
* lisp/cedet/semantic/symref/grep.el
(semantic-symref-derive-find-filepatterns): Avoid including the same
pattern twice.
Andrea Corallo [Mon, 13 Sep 2021 14:43:33 +0000 (16:43 +0200)]
* Clean-up some unnecessary macro usage in comp.c
* src/comp.c (emit_static_object)
(Fcomp_native_driver_options_effective_p, add_driver_options)
(Fcomp__compile_ctxt_to_file, Fcomp_libgccjit_version): Clean-up
unenecessary 'defined (WINDOWSNT)' usage.
Lars Ingebrigtsen [Mon, 13 Sep 2021 14:18:30 +0000 (16:18 +0200)]
Continue NEWS tag checking
Lars Ingebrigtsen [Mon, 13 Sep 2021 13:32:20 +0000 (15:32 +0200)]
Fix typo in previous files.el change
Lars Ingebrigtsen [Mon, 13 Sep 2021 13:17:02 +0000 (15:17 +0200)]
Mention unibyte issues in insert-file-contents-literally doc string
* lisp/files.el (insert-file-contents-literally): Mention possible
issues with multibyte buffers (bug#50560).
Stefan Monnier [Mon, 13 Sep 2021 13:14:05 +0000 (09:14 -0400)]
* doc/lispref/variables.texi (named-let): Document TCO
Dmitry Gutov [Mon, 13 Sep 2021 12:47:45 +0000 (15:47 +0300)]
Fix the tests
* test/lisp/progmodes/xref-tests.el
(xref--xref-file-name-display-is-abs)
(xref--xref-file-name-display-is-nondirectory)
(xref--xref-file-name-display-is-relative-to-project-root):
Update for the latest change in xref.el.
Lars Ingebrigtsen [Mon, 13 Sep 2021 11:35:53 +0000 (13:35 +0200)]
Use a fringe mark in bookmark instead of a whole background line
* lisp/bookmark.el (bookmark-face): Adjust colors.
(bookmark-fringe-mark): New bitmap.
(bookmark--fontify): Use a fringe instead of marking the whole line.
(bookmark--unfontify): Adjust to remove.
(bookmark--jump-via): Ditto.
(bookmark-set-fringe-mark): Renamed from bookmark-fontify.
(bookmark--set-fringe-mark, bookmark--remove-fringe-mark): Renamed
from --*fontify. Callers adjusted.
Lars Ingebrigtsen [Mon, 13 Sep 2021 11:02:16 +0000 (13:02 +0200)]
NEWS copy edits and tagging
Lars Ingebrigtsen [Mon, 13 Sep 2021 10:56:15 +0000 (12:56 +0200)]
Correct nroff-mode NEWS entry after `M-o' changes
Lars Ingebrigtsen [Mon, 13 Sep 2021 10:41:34 +0000 (12:41 +0200)]
Mention how to disable auto-fill-mode in the auto-fill section
* doc/lispref/text.texi (Margins): Mention how to disable
auto-fill-mode.
Lars Ingebrigtsen [Mon, 13 Sep 2021 10:35:50 +0000 (12:35 +0200)]
Document backtrace-on-error-noninteractive in the --batch section
* doc/emacs/cmdargs.texi (Initial Options): Mention
backtrace-on-error-noninteractive.
Lars Ingebrigtsen [Mon, 13 Sep 2021 10:32:10 +0000 (12:32 +0200)]
Further NEWS tagging updates
Lars Ingebrigtsen [Mon, 13 Sep 2021 10:20:57 +0000 (12:20 +0200)]
completions-annotations doc string clarification
* lisp/minibuffer.el (completions-annotations): Mention that it's
not always used.
Lars Ingebrigtsen [Mon, 13 Sep 2021 10:13:01 +0000 (12:13 +0200)]
Update some more NEWS tagging
Lars Ingebrigtsen [Mon, 13 Sep 2021 10:08:58 +0000 (12:08 +0200)]
Mention `benchmark-call' in the manual
* doc/lispref/debugging.texi (Profiling): Mention `benchmark-call'.
Lars Ingebrigtsen [Mon, 13 Sep 2021 09:59:56 +0000 (11:59 +0200)]
Update some pcase NEWS tags for already-documented functions
Lars Ingebrigtsen [Mon, 13 Sep 2021 09:58:56 +0000 (11:58 +0200)]
Update NEWS tagging for string helper functions
Lars Ingebrigtsen [Mon, 13 Sep 2021 09:53:18 +0000 (11:53 +0200)]
Document named-let and update some NEWS tags
* doc/lispref/variables.texi (Local Variables): Document `named-let'.
Lars Ingebrigtsen [Mon, 13 Sep 2021 08:40:56 +0000 (10:40 +0200)]
Clarify bookmark-fontify NEWS entry
Lars Ingebrigtsen [Mon, 13 Sep 2021 08:35:17 +0000 (10:35 +0200)]
package-menu-execute doc string clarification
* lisp/emacs-lisp/package.el (package-menu-execute): Say what
happens to upgrade-marked packages (bug#50551).
Lars Ingebrigtsen [Mon, 13 Sep 2021 08:29:08 +0000 (10:29 +0200)]
* etc/NEWS: Clarify insert-into-buffer (bug#50558).
Juri Linkov [Mon, 13 Sep 2021 08:14:32 +0000 (11:14 +0300)]
Support mouse events clicked on the tab bar but outside of any tab (bug#41343)
* lisp/tab-bar.el (tab-bar--key-to-number): Return non-nil non-numeric t
when no tab is used. Return nil for current-tab.
(tab-bar-mouse-select-tab, tab-bar-mouse-close-tab): Do nothing
when tab-bar--key-to-number returns non-nil non-numeric t
for click events outside of any tab.
(tab-bar-mouse-context-menu): Add context menu when mouse is clicked
outside of tabs. Add "Duplicate" alongside with "Close" to the menu
used when mouse is clicked on a tab.
(toggle-tab-bar-mode-from-frame, toggle-frame-tab-bar): Move code
closer to 'tab-bar-show'.
* src/xdisp.c (handle_tab_bar_click): Return Qtab_bar with empty list
when mouse is clicked on the tab bar but outside of any tab.
Lars Ingebrigtsen [Mon, 13 Sep 2021 08:03:24 +0000 (10:03 +0200)]
Only do multi-isearch in eww if there's next/prev links
* lisp/net/eww.el (eww-handle-link): Only do multi-isearch if
there's a next/prev link in the HTML (bug#50497).
(eww-setup-buffer): Clear the function.
(eww-mode): Don't set it here.
Juri Linkov [Mon, 13 Sep 2021 07:58:44 +0000 (10:58 +0300)]
Change value of DEFAULT_TAB_BAR_BUTTON_MARGIN from 4 to 1 (bug#50424)
Juri Linkov [Mon, 13 Sep 2021 07:56:51 +0000 (10:56 +0300)]
* doc/emacs/frames.texi (Tab Bars): Improve documentation.
Lars Ingebrigtsen [Mon, 13 Sep 2021 07:39:45 +0000 (09:39 +0200)]
Fix detection of char regions in print-fontset-element
* lisp/international/mule-diag.el (print-fontset-element): Fix the
regexp for "foo .. bar " (bug#50519).
Lars Ingebrigtsen [Mon, 13 Sep 2021 07:24:46 +0000 (09:24 +0200)]
Add some search-whitespace-regexp examples
* lisp/isearch.el (search-whitespace-regexp): Add some
alternatives in the defcustom.
Lars Ingebrigtsen [Mon, 13 Sep 2021 07:20:21 +0000 (09:20 +0200)]
Mention get-byte in shortdoc
* lisp/emacs-lisp/shortdoc.el (buffer): Mention `get-byte' here.
Tassilo Horn [Mon, 13 Sep 2021 05:22:50 +0000 (07:22 +0200)]
bug-reference.el: Adapt default debbugs bug regexp for IRC modes
* lisp/progmodes/bug-reference.el (bug-reference-setup-from-irc-alist):
Adapt regexp so that group 1 defines overlay region.
Tassilo Horn [Mon, 13 Sep 2021 05:11:05 +0000 (07:11 +0200)]
bug-reference.el: Adapt default debbugs bug regexp for mail modes
* lisp/progmodes/bug-reference.el (bug-reference-setup-from-mail-alist):
Adapt regexp so that group 1 defines overlay region.
Stefan Kangas [Mon, 13 Sep 2021 04:29:54 +0000 (06:29 +0200)]
Declare unused function cperl-inside-parens-p obsolete
* lisp/progmodes/cperl-mode.el (cperl-inside-parens-p): Declare
unused function obsolete.
Stefan Kangas [Mon, 13 Sep 2021 04:04:32 +0000 (06:04 +0200)]
; Minor doc fixes found by checkdoc
Stefan Kangas [Mon, 13 Sep 2021 04:03:44 +0000 (06:03 +0200)]
Improve checkdoc abbreviation handling
* lisp/emacs-lisp/checkdoc.el
(checkdoc-in-abbreviation-p): New helper function.
(checkdoc-sentencespace-region-engine): Fix handling abbreviations
after escaped parenthesis.
* test/lisp/emacs-lisp/checkdoc-tests.el
(checkdoc-tests-in-abbrevation-p)
(checkdoc-tests-in-abbrevation-p/with-parens)
(checkdoc-tests-in-abbrevation-p/with-escaped-parens): New tests.
Stefan Kangas [Mon, 13 Sep 2021 02:41:15 +0000 (04:41 +0200)]
Remove some remaining references to XEmacs
* lisp/allout.el (allout-overlay-preparations):
* lisp/cedet/semantic/decorate/include.el
(semantic-decoration-unknown-include-menu)
(semantic-decoration-fileless-include-menu):
* lisp/cedet/semantic/idle.el (semantic-idle-scheduler-setup-timers):
* lisp/vc/ediff-init.el:
* lisp/vc/ediff-util.el (ediff-mode): Remove some remaining references
to XEmacs.
Dmitry Gutov [Sun, 12 Sep 2021 22:33:31 +0000 (01:33 +0300)]
Extend xref-file-name-display to elisp and etags definitions
And all other types of locations (with a looks-like-file-name check).
* lisp/progmodes/xref.el (xref--group-name-for-display): Extract
from xref-buffer-location's implementation of xref-location-group.
(xref-file-location): Define trivial reader for the 'file' slot.
(xref-location-group): Update docstring.
(xref--analyze): Use the new function here, to be able to format
group names coming from any location type.
Amin Bandali [Sun, 12 Sep 2021 18:12:50 +0000 (14:12 -0400)]
ERC: Use 'string-replace' only on Emacs 28 and later
* lisp/erc/erc-dcc.el (erc-dcc-unquote-filename):
* lisp/erc/erc.el (erc-quit-reason-zippy, erc-part-reason-zippy)
(erc-update-mode-line-buffer, erc-message-english-PART): Use
'string-replace' only on Emacs 28 and later, otherwise use
'replace-regexp-in-string' on older Emacsen.
Amin Bandali [Sun, 12 Sep 2021 18:09:53 +0000 (14:09 -0400)]
ERC: Use 'string-search' only on Emacs 28 and later
* lisp/erc/erc-backend.el (erc-parse-server-response):
* lisp/erc/erc-dcc.el (erc-dcc-member):
* lisp/erc/erc-speedbar.el (erc-speedbar-expand-server)
(erc-speedbar-expand-channel, erc-speedbar-expand-user):
* lisp/erc/erc.el (erc-send-input): Use 'string-search' only on
Emacs 28 and later, otherwise use 'string-match' on older Emacsen.
Juri Linkov [Sun, 12 Sep 2021 18:30:06 +0000 (21:30 +0300)]
* lisp/tab-bar.el (tab-bar-get-buffer-tab): Use 'remq' instead of 'seq-remove'
Juri Linkov [Sun, 12 Sep 2021 17:55:57 +0000 (20:55 +0300)]
Allow region-related context menu to be used on selected region with one click
* lisp/mouse.el (mouse-drag-track): Don't deactivate the mark for
the context menu invoked by down-mouse-3.
https://lists.gnu.org/archive/html/emacs-devel/2021-08/msg01577.html
Juri Linkov [Sun, 12 Sep 2021 17:32:02 +0000 (20:32 +0300)]
* lisp/thingatpt.el (thing-at-mouse): New function (bug#50256).
* lisp/net/dictionary.el: Add 'context-menu-dictionary' to
'context-menu-functions'.
(dictionary-search-word-at-mouse): New function.
(context-menu-dictionary): New function that uses 'thing-at-mouse'.
(dictionary-mouse-popup-matching-words): Remove stray 'selected-window'.
* lisp/textmodes/flyspell.el (flyspell-context-menu): Add '_click' arg.
Juri Linkov [Sun, 12 Sep 2021 17:11:52 +0000 (20:11 +0300)]
* lisp/mouse.el (context-menu-map): Add 'click' arg to called funs (bug#50256)
(context-menu-toolbar, context-menu-global, context-menu-local)
(context-menu-minor, context-menu-buffers, context-menu-vc)
(context-menu-undo, context-menu-region, context-menu-ffap): Add 'click' arg.
* lisp/dired.el (dired-context-menu):
* lisp/help-mode.el (help-mode-context-menu):
* lisp/info.el (Info-context-menu):
* lisp/net/eww.el (eww-context-menu):
* lisp/net/goto-addr.el (goto-address-context-menu):
* lisp/progmodes/prog-mode.el (prog-context-menu): Add 'click' arg.
Eli Zaretskii [Sun, 12 Sep 2021 16:51:06 +0000 (19:51 +0300)]
Fix quoting style in Lisp comments
* lisp/textmodes/rst.el:
* lisp/progmodes/elisp-mode.el (elisp--xref-find-definitions):
* lisp/org/org.el:
* lisp/org/org-list.el (org-list-to-generic):
* lisp/org/org-compat.el:
* lisp/hexl.el (hexl-ascii-region):
* lisp/emacs-lisp/lisp-mode.el:
* lisp/calendar/calendar.el: In comments, quote 'like this'.
Juri Linkov [Sun, 12 Sep 2021 16:47:20 +0000 (19:47 +0300)]
* lisp/mouse.el (context-menu-map): Remove duplicate separators (bug#50067).
* lisp/mouse.el (context-menu-undo, context-menu-region):
* lisp/progmodes/prog-mode.el (prog-context-menu):
Use 'when' instead of ':visible' that allows to remove duplicate separators
created between empty submenus.
Stefan Kangas [Sun, 12 Sep 2021 16:33:03 +0000 (18:33 +0200)]
; Fix symbol quoting typos
Juri Linkov [Sun, 12 Sep 2021 16:31:49 +0000 (19:31 +0300)]
Use window-point in event-start and event-end (bug#50256)
* lisp/subr.el (event-start, event-end): Provide window-point
as an arg for posn-at-point, and for the constructed list.
* lisp/help-mode.el (help-mode-context-menu): Remove a kludge
that checked if window-buffer is current-buffer.
Juri Linkov [Sun, 12 Sep 2021 16:10:02 +0000 (19:10 +0300)]
* lisp/tab-bar.el: Improve logic of 'ignore-current-tab'.
* lisp/tab-bar.el (tab-bar-get-buffer-tab): Prefer the current tab
when 'ignore-current-tab' is nil.
(display-buffer-in-tab): Use alist entry 'ignore-current-tab'
as the third arg of 'tab-bar-get-buffer-tab'. Improve docstring.
Suggested by Feng Shu <tumashu@163.com>
https://lists.gnu.org/archive/html/emacs-devel/2021-09/msg00955.html
Hanno Perrey [Sun, 12 Sep 2021 15:22:25 +0000 (17:22 +0200)]
; * lisp/eshell/em-unix.el (nil-blank-string): Doc fix
* lisp/eshell/em-unix.el (nil-blank-string): Fix doc string
(bug#50549).
Copyright-paperwork-exempt: yes
Eli Zaretskii [Sun, 12 Sep 2021 15:04:02 +0000 (18:04 +0300)]
Minor copyedits in Emacs FAQ
* doc/misc/efaq.texi (What was XEmacs?, Colors on a TTY): Fix
wording and improve the description.
Stefan Kangas [Sun, 12 Sep 2021 11:14:34 +0000 (13:14 +0200)]
; * doc/misc/efaq.texi (What was XEmacs?): Restore pre-merge text.
Lars Ingebrigtsen [Sun, 12 Sep 2021 12:11:53 +0000 (14:11 +0200)]
Fix read-no-blanks-input doc string typo
* lisp/minibuffer.el (read-no-blanks-input): Fix doc string typo.
dick r. chiang [Sun, 12 Sep 2021 12:11:16 +0000 (14:11 +0200)]
Fix read-no-blanks-input history argument
* lisp/minibuffer.el (read-no-blanks-input): Use the
`minibuffer-history' symbol, not the value (bug#50535).
Mattias Engdegård [Tue, 7 Sep 2021 16:21:57 +0000 (18:21 +0200)]
Infer identifier namespace in elisp xref backend
Improve the accuracy of `xref-find-definitions` by inferring the
likely namespace of the sought identifier from its context.
This reduces the number of irrelevant search hits when it is clear
what kind of identifier is being looked for (such as showing a
variable when the user looks for a function).
Co-written with Dmitry Gutov.
* lisp/progmodes/elisp-mode.el (elisp--xref-list-index)
(elisp--xref-infer-namespace, xref-backend-identifier-at-point): New.
(xref-backend-definitions): Use the buffer position for inferring.
(elisp--xref-find-definitions): Use the inferred namespace.
(xref-backend-apropos): Adapt call.
* test/lisp/progmodes/elisp-mode-tests.el (elisp-mode-test--with-buffer)
(elisp-mode-with-buffer, elisp-mode-infer-namespace): New tests.
Martin Rudalics [Sun, 12 Sep 2021 09:38:24 +0000 (11:38 +0200)]
;* lisp/window.el (switch-to-prev-buffer): Fix typo in doc-string.
Martin Rudalics [Sun, 12 Sep 2021 09:11:41 +0000 (11:11 +0200)]
Improve doc-strings of some buffer display options (Bug#50518)
* lisp/window.el (pop-up-frame-alist, same-window-buffer-names)
(same-window-regexps, pop-up-frames, pop-up-windows): In
doc-strings say that these options are maintained for backward
compatibility only (Bug#50518).
Eli Zaretskii [Sun, 12 Sep 2021 08:02:58 +0000 (11:02 +0300)]
Improve documentation of tab bars in the Emacs manual
* doc/emacs/frames.texi (Tab Bars): Improve wording, indexing, and
cross-references. Make sure each command is mentioned by its name
when it is called out by the key sequence. Index entries should
precede @item lines in a @table.
Eli Zaretskii [Sun, 12 Sep 2021 07:01:38 +0000 (10:01 +0300)]
Improve documentation of some tab-bar features
* lisp/tab-bar.el (tab-bar-show, toggle-frame-tab-bar): Doc
fixes.
* etc/NEWS: Update the corresponding entries.
Olivier Certner [Thu, 14 Jan 2021 17:36:08 +0000 (18:36 +0100)]
ERC: Track: Fix a perceived minor bug in mode line face selection
* lisp/erc/erc-track.el (erc-track-modified-channels): Fix what is a
probable bug when a new insert event happens for a buffer that was not
tracked or for which no mode line face was selected: in this case,
stop treating the latest buffer's face (first in list) as the previous
one, which could be overridden with an older one (in FACES' rest), as
if it had happened after.
Olivier Certner [Thu, 14 Jan 2021 17:26:38 +0000 (18:26 +0100)]
ERC: Track: Rewrite 'erc-track-find-face' as 'erc-track-select-mode-line-face'
* lisp/erc/erc-track.el (erc-track-find-face): Declare obsolete and
rewrite as 'erc-track-select-mode-line-face', changing the function
arguments, so that it is very clear what the current algorithm is.
No functional changes. Performance improvements. Clarify the
documentation and remove the part on some faces being lists, which
clearly does not apply.
(erc-track-modified-channels): Replace calls to 'erc-track-find-face'
with calls to 'erc-track-select-mode-line-face', preserving the
existing behavior.
(erc-modified-channels-alist): Change the reference to
'erc-track-select-mode-line-face' in the documentation following the
rename.
* etc/NEWS: Announce the change.
Co-authored-by: Amin Bandali <bandali@gnu.org>
Amin Bandali [Sun, 12 Sep 2021 03:03:57 +0000 (23:03 -0400)]
Merge from origin/emacs-27
d7f4cc0974 ERC: Track: Clarify documentation on tracked buffers and a...
fb1f0dfec9 ERC: Track: Fix documentation of structure of 'erc-modifie...
252a769b11 ; * doc/lispref/files.texi (Changing Files): Fix xref to f...
edc93a5ce6 ; Fix grammar in efaq.texi on Emacs vs XEmacs.
# Conflicts:
# doc/misc/efaq.texi
Olivier Certner [Thu, 14 Jan 2021 17:20:26 +0000 (18:20 +0100)]
ERC: Track: Clarify documentation on tracked buffers and add references
* lisp/erc/erc-track.el (erc-modified-channels-alist): Clarify what
the list contains. Add references to variables and functions involved
in displaying tracked buffers from this list.
(erc-make-mode-line-buffer-name): Describe exactly the algorithm, and
reference custom variables that influence it.
Olivier Certner [Wed, 13 Jan 2021 16:39:54 +0000 (17:39 +0100)]
ERC: Track: Fix documentation of structure of 'erc-modified-channels-alist'
* lisp/erc/erc-track.el (erc-modified-channels-alist): Fix the
docstring: each element is a dotted list where the last cdr is
sometimes a proper list, making the element only sometimes a proper
list.
Dmitry Gutov [Sun, 12 Sep 2021 00:28:38 +0000 (03:28 +0300)]
Re-fix bug#16897
* lisp/vc/vc-git.el (vc-git--file-list-is-rootdir):
Extract from 'vc-git-command'.
(vc-git--literal-pathspecs): Use it here as well.
Tassilo Horn [Sat, 11 Sep 2021 20:49:29 +0000 (22:49 +0200)]
Refactor bug-reference setup for software forges
* lisp/progmodes/bug-reference.el (bug-reference-gitea-instances)
(bug-reference-gitlab-instances,bug-reference-sourcehut-instances):
Delete defvars. Those are replaced with bug-reference-forge-alist.
(bug-reference-forge-alist): New variable.
(bug-reference--build-forge-setup-entry): New cl-defgeneric with
methods for github, gitlab, gitea, and sourcehut instances.
(bug-reference--setup-from-vc-alist): Use bug-reference-forge-alist
and bug-reference--build-forge-setup-entry.
* doc/emacs/maintaining.texi (Bug Reference): Mention that the first
group in bug-reference-bug-regexp defines the overlay bounds. Also
mention bug-reference-forge-alist in VCS setup section.
Mattias Engdegård [Sat, 11 Sep 2021 15:13:14 +0000 (17:13 +0200)]
Fix byte-compilation warnings
* lisp/calc/calc-graph.el (calc-gnuplot-check-for-errors):
* lisp/calendar/holidays.el (list-holidays):
Dodge 'save-excursion+set-buffer' warnings that appeared after
the progn flattening was introduced.
Mattias Engdegård [Sat, 11 Sep 2021 12:46:45 +0000 (14:46 +0200)]
Remove obsolete variable
* lisp/emacs-lisp/byte-opt.el
(byte-optimize--vars-outside-condition): Remove.
(byte-optimize-form-code-walker): Remove bindings.
Mattias Engdegård [Fri, 30 Jul 2021 11:44:07 +0000 (13:44 +0200)]
Propagate aliased lexical variables in byte compiler
Replace uses of a variable aliasing another variable with that aliased
variable, to allow for variable removal when possible. This also
enables opportunities for other optimisations. Example:
(let ((y x)) (f y)) => (f x)
The optimisation is only performed if both aliased and aliasing
variables are lexically bound. Shadowing bindings are α-renamed when
necessary for correctness. Example:
(let* ((b a) (a EXPR)) (f a b))
=> (let* ((a{new} EXPR)) (f a{new} a))
* lisp/emacs-lisp/byte-opt.el (byte-optimize--aliased-vars): New.
(byte-optimize-form-code-walker): Cancel aliasing upon mutation.
(byte-optimize--rename-var-body, byte-optimize--rename-var): New.
(byte-optimize-let-form): Add the optimisation.
* test/lisp/emacs-lisp/bytecomp-tests.el (bytecomp-tests--test-cases):
Add relevant test cases.
Eli Zaretskii [Sat, 11 Sep 2021 14:50:42 +0000 (17:50 +0300)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs
Eli Zaretskii [Sat, 11 Sep 2021 14:50:08 +0000 (17:50 +0300)]
; * src/w32term.c (w32_read_socket): Avoid compiler warning.
Augusto Stoffel [Sat, 11 Sep 2021 13:39:13 +0000 (15:39 +0200)]
Keep python.el compatible with older Emacsen
* progmodes/python.el (python-shell-send-string): Don't assume
comint-max-line-length is defined (bug#50503).
Michael Albinus [Sat, 11 Sep 2021 13:35:51 +0000 (15:35 +0200)]
Tramp code cleanup
* lisp/net/tramp-gvfs.el (tramp-gvfs-handle-make-directory): Simplify.
* lisp/net/tramp-sh.el (tramp-methods) <telnet, nc>: Don't use
"%n" marker.
* test/lisp/net/tramp-tests.el (tramp-test13-make-directory): Merge with
`tramp-test-make-directory-helper' and
`tramp-test13-make-directory-with-file-modes'.
(tramp-test44-asynchronous-requests): Use always the same
operation in timer.
Augusto Stoffel [Sat, 11 Sep 2021 13:02:04 +0000 (15:02 +0200)]
Allow using 'python-shell-send-file' across machines
* progmodes/python.el (python-shell-eval-file-setup-code): Look for a
file coding cookie on the Python rather than on the Emacs side, to
avoid additional file transfers.
(python-shell--save-temp-file): Allow argument to be a buffer.
(python-shell-send-file): Address the case where the selected file and
the inferior process are on different machines (bug#50516).