]> git.eshelyaron.com Git - emacs.git/log
emacs.git
5 years ago; Merge from origin/emacs-26
Glenn Morris [Sat, 15 Jun 2019 16:50:33 +0000 (09:50 -0700)]
; Merge from origin/emacs-26

The following commit was skipped:

200f63c (origin/emacs-26) tramp-test42-auto-load: Add expected-result.

5 years agoMerge from origin/emacs-26
Glenn Morris [Sat, 15 Jun 2019 16:50:33 +0000 (09:50 -0700)]
Merge from origin/emacs-26

7a8f22b * test/lisp/url/url-file-tests.el (url-file): Use file:///, n...
0c5f6c6 Fix doc of srecompile-compile-split-code (Bug#36200)

5 years ago; Merge from origin/emacs-26
Glenn Morris [Sat, 15 Jun 2019 16:50:33 +0000 (09:50 -0700)]
; Merge from origin/emacs-26

The following commits were skipped:

e587338 Make sure Gnus imap group names are decoded before searching
746d42f Remove failing test erroneously added in backport

5 years agoMerge from origin/emacs-26
Glenn Morris [Sat, 15 Jun 2019 16:50:33 +0000 (09:50 -0700)]
Merge from origin/emacs-26

6242324 * lisp/net/sieve-manage.el (sieve-manage-parse-capability): D...

5 years ago; Merge from origin/emacs-26
Glenn Morris [Sat, 15 Jun 2019 16:50:32 +0000 (09:50 -0700)]
; Merge from origin/emacs-26

The following commits were skipped:

9473231 (tag: emacs-26.2.90) ; * lisp/ldefs-boot.el: Update.
fb1c966 Bump Emacs version to 26.2.90
2b705cd * etc/AUTHORS: Update.

5 years agoMerge from origin/emacs-26
Glenn Morris [Sat, 15 Jun 2019 16:50:32 +0000 (09:50 -0700)]
Merge from origin/emacs-26

f53ce87 ; ChangeLog.3 update
eca2677 Fix description of 'display-buffer-in-previous-window' again ...
7be50cd Consistently use @minus{} for negative arguments

# Conflicts:
# ChangeLog.3

5 years agoUpdate hash value in pdumper.c
Eli Zaretskii [Sat, 15 Jun 2019 16:45:29 +0000 (19:45 +0300)]
Update hash value in pdumper.c

* src/pdumper.c (dump_fwd_buffer_obj) [CHECK_STRUCTS]: Update
the hash in HASH_Lisp_Buffer_Objfwd.  (Bug#36225)

5 years agoImprove error message when dmpstruct.h needs to be updated
Eli Zaretskii [Sat, 15 Jun 2019 16:28:51 +0000 (19:28 +0300)]
Improve error message when dmpstruct.h needs to be updated

* src/pdumper.c (dump_cons, dump_interval_tree, dump_string)
(dump_marker, dump_overlay, dump_finalizer)
(dump_bignum, dump_float, dump_fwd_int, dump_fwd_bool)
(dump_fwd_obj, dump_fwd_buffer_obj, dump_fwd_kboard_obj)
(dump_fwd, dump_blv, dump_symbol, dump_vectorlike_generic)
(dump_hash_table, dump_buffer, dump_bool_vector, dump_subr)
(dump_vectorlike, dump_object, dump_charset) [CHECK_STRUCTS]:
Make the error message more specific where to find the comment
to CHECK_STRUCTS.

5 years agoProbably fix the `helper' argument in feedmail.el
Lars Ingebrigtsen [Sat, 15 Jun 2019 15:46:23 +0000 (17:46 +0200)]
Probably fix the `helper' argument in feedmail.el

* lisp/mail/feedmail.el (feedmail-queue-send-edit-prompt-inner):
Return the helper function (instead of the symbol `helper') so
that the caller can actually call it.

5 years agoFix compilation warning in esh-cmd.el
Lars Ingebrigtsen [Sat, 15 Jun 2019 15:42:09 +0000 (17:42 +0200)]
Fix compilation warning in esh-cmd.el

* lisp/eshell/esh-cmd.el (pcomplete--here): Declare function to
avoid byte compilation warning, which is what erc-notify.el also
does in a similar situation.

5 years agoFix build warning in srecode/srt-mode
Lars Ingebrigtsen [Sat, 15 Jun 2019 15:34:48 +0000 (17:34 +0200)]
Fix build warning in srecode/srt-mode

* lisp/cedet/srecode/srt-mode.el (srecode-inserter-prin-example):
Declare and require before use.

5 years agoSilence warnings about obsolete functions in obsolete/vip.el
Lars Ingebrigtsen [Sat, 15 Jun 2019 15:13:38 +0000 (17:13 +0200)]
Silence warnings about obsolete functions in obsolete/vip.el

* lisp/obsolete/vip.el (ex-tag): Silence warnings about obsolete
functions because this is an obsolete file.

5 years agoSuppress compilation warnings in obsolete/otodo-mode.el
Lars Ingebrigtsen [Sat, 15 Jun 2019 15:12:10 +0000 (17:12 +0200)]
Suppress compilation warnings in obsolete/otodo-mode.el

* lisp/obsolete/otodo-mode.el (lexical): Suppress warnings about
non-prefixed variables because this file is obsolete.

5 years agoSilence warning in obsolete/complete.el
Lars Ingebrigtsen [Sat, 15 Jun 2019 15:10:53 +0000 (17:10 +0200)]
Silence warning in obsolete/complete.el

* lisp/obsolete/complete.el (PC-do-completion): Suppress warning
about obsolete variable in obsolete function.

5 years agoMake obsolete function zip-lists work again
Lars Ingebrigtsen [Sat, 15 Jun 2019 15:09:08 +0000 (17:09 +0200)]
Make obsolete function zip-lists work again

* lisp/obsolete/cl-compat.el (zip-lists): Use cl-mapcan instead of
mapcan; mapcan now takes only two parameters.

5 years agoSuppress compilation warning in supercite.el
Lars Ingebrigtsen [Sat, 15 Jun 2019 14:59:21 +0000 (16:59 +0200)]
Suppress compilation warning in supercite.el

* lisp/mail/supercite.el (curline): Suppress warning about
non-prefixed variable used by forms in the `sc-mail-glom-frame'
variable.

5 years agoSuppress warning in mailheader.el
Lars Ingebrigtsen [Sat, 15 Jun 2019 14:54:51 +0000 (16:54 +0200)]
Suppress warning in mailheader.el

* lisp/mail/mailheader.el (headers): Suppress warning about
non-prefixed variable part of the advertised interface.

5 years agoSuppress warning about non-prefixed variable in mailalias.el
Lars Ingebrigtsen [Sat, 15 Jun 2019 14:53:52 +0000 (16:53 +0200)]
Suppress warning about non-prefixed variable in mailalias.el

* lisp/mail/mailalias.el (patters): Suppress warning about
non-prefixed variable used by `mail-complete-alist'.

5 years agoFix byte compilation warning in bindat.el
Lars Ingebrigtsen [Sat, 15 Jun 2019 14:33:05 +0000 (16:33 +0200)]
Fix byte compilation warning in bindat.el

* lisp/emacs-lisp/bindat.el (bindat--unpack-item): Avoid a byte
compilation warning by using unibyte-string instead of concat +
string-make-unibyte.

5 years agoAvoid printing entering/leaving messages in second stage bootstrap
Lars Ingebrigtsen [Sat, 15 Jun 2019 14:29:23 +0000 (16:29 +0200)]
Avoid printing entering/leaving messages in second stage bootstrap

* src/Makefile.in (%.elc): Default to not printing the
entering/leaving lines when compiling .el files in the second
stage of bootstrapping Emacs.  V=1 will output them.

5 years agoAlso test unpacking
Lars Ingebrigtsen [Sat, 15 Jun 2019 14:10:28 +0000 (16:10 +0200)]
Also test unpacking

5 years agoRefactor for reuse
Lars Ingebrigtsen [Sat, 15 Jun 2019 14:06:38 +0000 (16:06 +0200)]
Refactor for reuse

5 years agoNew file to test bindat functions
Lars Ingebrigtsen [Sat, 15 Jun 2019 13:57:01 +0000 (15:57 +0200)]
New file to test bindat functions

5 years agoSuppress warning about `entry' in calendar
Lars Ingebrigtsen [Sat, 15 Jun 2019 12:30:50 +0000 (14:30 +0200)]
Suppress warning about `entry' in calendar

* lisp/calendar/cal-china.el (entry):
* lisp/calendar/cal-hebrew.el (entry): Suppress warning about
dynamically bound `entry', which has to be bound for
diary-chinese-anniversary and diary-hebrew-birthday to work.
These function can be used in the sexp part of users' diary files.

5 years agoSuppress warning about prefixless date variable in calendar
Lars Ingebrigtsen [Sat, 15 Jun 2019 12:22:38 +0000 (14:22 +0200)]
Suppress warning about prefixless date variable in calendar

* lisp/calendar/lunar.el (date):
* lisp/calendar/cal-persia.el (date):
* lisp/calendar/cal-mayan.el (date):
* lisp/calendar/cal-julian.el (date):
* lisp/calendar/cal-iso.el (date):
* lisp/calendar/cal-islam.el (date):
* lisp/calendar/cal-hebrew.el (date):
* lisp/calendar/cal-french.el (date):
* lisp/calendar/cal-coptic.el (date):
* lisp/calendar/cal-china.el (date):
* lisp/calendar/cal-bahai.el (date): Suppress warning about this
prefix-less dynamic variable, because it's part of the documented
calling convention used in the sexp part of users' diary files.

5 years agoClean up verilog-mode.el documentation examples to match behavior.
Wilson Snyder [Sat, 15 Jun 2019 12:16:05 +0000 (08:16 -0400)]
Clean up verilog-mode.el documentation examples to match behavior.

* verilog-mode.el (verilog-auto, verilog-auto-arg)
(verilog-auto-ascii-enum, verilog-auto-inout)
(verilog-auto-inout-comp, verilog-auto-inout-in)
(verilog-auto-inout-modport, verilog-auto-inout-module)
(verilog-auto-inout-param, verilog-auto-input)
(verilog-auto-insert-lisp, verilog-auto-inst)
(verilog-auto-inst-param, verilog-auto-inst-param-value)
(verilog-auto-output, verilog-auto-output-every, verilog-auto-reg)
(verilog-auto-reg-input, verilog-auto-reset, verilog-auto-sense)
(verilog-auto-tieoff, verilog-auto-undef, verilog-auto-unused)
(verilog-auto-wire, verilog-inject-auto, verilog-read-sub-decls):
Clean up documentation examples to match behavior.

5 years agoMake url-tramp more robust
Michael Albinus [Sat, 15 Jun 2019 10:19:01 +0000 (12:19 +0200)]
Make url-tramp more robust

* lisp/url/url-tramp.el (url-tramp-convert-url-to-tramp)
(url-tramp-convert-tramp-to-url): Check, that obj is non-nil.

5 years agoMerge branch 'master' of git.savannah.gnu.org:/srv/git/emacs
Eli Zaretskii [Sat, 15 Jun 2019 10:16:36 +0000 (13:16 +0300)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

5 years agoRemove another variable obsolete since Emacs 22
Stefan Kangas [Mon, 10 Jun 2019 01:42:27 +0000 (03:42 +0200)]
Remove another variable obsolete since Emacs 22

* lisp/progmodes/cc-langs.el: Remove obsolete variable
c-opt-op-identitier-prefix.
* etc/NEWS: Announce it.  (Bug#36173)

5 years agoLet tramp-archive unmount clean
Michael Albinus [Sat, 15 Jun 2019 09:46:04 +0000 (11:46 +0200)]
Let tramp-archive unmount clean

* lisp/net/tramp-archive.el (tramp-archive-cleanup-hash):
Don't check for a proper method.

5 years agoMake Tramp compatible to recent progress-reporter-update
Michael Albinus [Sat, 15 Jun 2019 09:38:13 +0000 (11:38 +0200)]
Make Tramp compatible to recent progress-reporter-update

* lisp/net/tramp-compat.el (tramp-compat-progress-reporter-update):
New defalias.

* lisp/net/tramp.el (tramp-progress-reporter-update): Add optional SUFFIX.

5 years agoSome changes in process output read of Tramp
Michael Albinus [Sat, 15 Jun 2019 09:33:16 +0000 (11:33 +0200)]
Some changes in process output read of Tramp

* lisp/net/tramp.el (tramp-handle-file-notify-rm-watch):
Read pending output.

* test/lisp/net/tramp-tests.el (tramp-test31-interrupt-process):
Use a timeout when reading process output.

5 years agoTag remote autorevert tests as unstable
Michael Albinus [Sat, 15 Jun 2019 09:08:05 +0000 (11:08 +0200)]
Tag remote autorevert tests as unstable

* test/lisp/autorevert-tests.el (auto-revert--timeout):
Derive value from `auto-revert-interval'.
(auto-revert--deftest-remote): Tag it as `:unstable'.
(auto-revert-test05-global-notify, auto-revert-test06-write-file):
Suppress final newline.  Use `auto-revert--timeout'.

5 years agoRemove Lucid Emacs support from bookmark.el
Stefan Kangas [Wed, 12 Jun 2019 08:36:10 +0000 (10:36 +0200)]
Remove Lucid Emacs support from bookmark.el

* lisp/bookmark.el: Remove Lucid Emacs support.
(Bug#36179)

5 years agoImprove documentation of hash-code functions
Eli Zaretskii [Sat, 15 Jun 2019 08:16:49 +0000 (11:16 +0300)]
Improve documentation of hash-code functions

* src/fns.c (Fsxhash_eq, Fsxhash_eql, Fsxhash_equal):
* doc/lispref/hash.texi (Defining Hash): Warn against assuming
that sxhash returns consistent results.

5 years agotramp-test42-auto-load: Add expected-result.
Juanma Barranquero [Sat, 15 Jun 2019 05:23:25 +0000 (07:23 +0200)]
tramp-test42-auto-load: Add expected-result.

* test/lisp/net/tramp-tests.el (tramp-test42-auto-load):
Expect a failed result if remote file access is not enabled,
as it happens while doing the test on Windows.

5 years ago* configure.ac: Lower required cairo version to 1.8.0.
YAMAMOTO Mitsuharu [Sat, 15 Jun 2019 03:46:30 +0000 (12:46 +0900)]
* configure.ac: Lower required cairo version to 1.8.0.

5 years agoRemove non-Xdbe double-buffering code on cairo
YAMAMOTO Mitsuharu [Sat, 15 Jun 2019 03:44:56 +0000 (12:44 +0900)]
Remove non-Xdbe double-buffering code on cairo

* src/xterm.c (x_begin_cr_clip, x_update_end) [USE_CAIRO]: Don't do
handcrafted double-buffering with image surface.

5 years agoRework x_scroll_run on cairo
YAMAMOTO Mitsuharu [Sat, 15 Jun 2019 03:36:26 +0000 (12:36 +0900)]
Rework x_scroll_run on cairo

* src/xterm.c (x_scroll_run) [USE_CAIRO]: Use FRAME_CR_CONTEXT or surface type
for conditions to call XCopyArea rather than FRAME_X_DOUBLE_BUFFERED_P.
Set compositing operator to CAIRO_OPERATOR_SOURCE when copying image.

5 years ago* test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://.
Juanma Barranquero [Sat, 15 Jun 2019 03:29:03 +0000 (05:29 +0200)]
* test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://.

5 years agoFix doc of srecompile-compile-split-code (Bug#36200)
Juanma Barranquero [Fri, 14 Jun 2019 23:37:27 +0000 (01:37 +0200)]
Fix doc of srecompile-compile-split-code (Bug#36200)

* lisp/cedet/srecode/compile.el (srecode-compile-split-code):
Remove leftover text from docstring.

5 years agoRevert "Silence okuri-nasi count-up messaging during compilation"
Lars Ingebrigtsen [Fri, 14 Jun 2019 18:59:31 +0000 (20:59 +0200)]
Revert "Silence okuri-nasi count-up messaging during compilation"

This takes long enough on some systems that the messages are useful.

This reverts commit 1d2e4d22c922f94d6f4b75a5ead18cbc679c5dfe.

5 years agoFix problem in remote file notification
Michael Albinus [Fri, 14 Jun 2019 17:45:00 +0000 (19:45 +0200)]
Fix problem in remote file notification

* lisp/net/tramp-sh.el (tramp-sh-gio-monitor-process-filter)
(tramp-sh-gvfs-monitor-dir-process-filter)
(tramp-sh-inotifywait-process-filter): Do not kill the process.
Let `file-notify-rm-watch' do the job.

* test/lisp/filenotify-tests.el (file-notify-test03-events)
(file-notify-test05-file-validity)
(file-notify-test09-watched-file-in-watched-dir): Do not
special-case remote files.

5 years agoSilence okuri-nasi count-up messaging during compilation
Lars Ingebrigtsen [Fri, 14 Jun 2019 15:14:49 +0000 (17:14 +0200)]
Silence okuri-nasi count-up messaging during compilation

* lisp/international/ja-dic-cnv.el (skkdic-set-okuri-nasi): Remove
messaging while compilation to make compilation more regular.

5 years agoMake sure Gnus imap group names are decoded before searching
Eric Abrahamsen [Thu, 13 Jun 2019 22:09:24 +0000 (15:09 -0700)]
Make sure Gnus imap group names are decoded before searching

do not merge (fix unnecessary in Emacs 27)

* lisp/gnus/nnir.el (nnir-run-imap): Ensure that non-ascii group names
  have been fully decoded before passing them to imap search.

5 years agoRevert "srecode/srt-mode compilation fix"
Lars Ingebrigtsen [Fri, 14 Jun 2019 15:03:59 +0000 (17:03 +0200)]
Revert "srecode/srt-mode compilation fix"

This led to a recursive require.

This reverts commit 9fac0e70e3f5b7d0b12b77cac50078e01f68ee70.

5 years agoFix previous object-print/cl-print-object changes
Lars Ingebrigtsen [Fri, 14 Jun 2019 14:57:35 +0000 (16:57 +0200)]
Fix previous object-print/cl-print-object changes

* lisp/cedet/srecode/insert.el
(srecode-insert-variable-secondname-handler):
* lisp/cedet/semantic/decorate/include.el
(semantic-decoration-fileless-include-describe):
(semantic-decoration-all-include-summary):
* lisp/cedet/semantic/db-find.el (semanticdb-find-log-activity):
* lisp/cedet/semantic/bovine/c.el
(semantic-c-describe-environment):
* lisp/cedet/semantic/analyze/debug.el
(semantic-analyzer-debug-insert-include-summary): Fix previous
object-print/cl-print-object changes that were nonsensical.

5 years agoAvoid using registerv-make in senator.el
Lars Ingebrigtsen [Fri, 14 Jun 2019 14:51:27 +0000 (16:51 +0200)]
Avoid using registerv-make in senator.el

* lisp/cedet/semantic/senator.el (senator-register): New class.
(register-val-jump-to, register-val-describe)
(register-val-insert): New methods.
(senator-copy-tag-to-register): Use this instead of the deprecated
registerv-make function.

5 years agoanalyze/debug compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:57:34 +0000 (15:57 +0200)]
analyze/debug compilation fix

* lisp/cedet/semantic/analyze/debug.el (pulse): Require to avoid
byte compilation warning.

5 years agosemantic/lex-spp compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:54:50 +0000 (15:54 +0200)]
semantic/lex-spp compilation fix

* lisp/cedet/semantic/lex-spp.el
(semantic-lex-spp-analyzer-push-tokens-for-symbol): Use new name
for `semantic-lex-spp-anlyzer-do-replace'.

5 years agoUse cl-typep instead of obsolete predicate functions throughout cedet
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:47:54 +0000 (15:47 +0200)]
Use cl-typep instead of obsolete predicate functions throughout cedet

* lisp/cedet/srecode/dictionary.el (srecode-create-dictionary):
(srecode-dictionary-add-entries):
(srecode-compound-toString):
(srecode-dump):
* lisp/cedet/srecode/compile.el (srecode-dump-code-list):
* lisp/cedet/semantic/util.el (semantic-something-to-tag-table):
* lisp/cedet/semantic/db-typecache.el (semanticdb-typecache-length):
* lisp/cedet/semantic/db-ref.el (semanticdb-check-references):
* lisp/cedet/semantic/db-find.el
(semanticdb-find-incomplete-cache-entries-p):
(semanticdb-find-translate-path-includes-default):
(semanticdb-find-results-p):
(semanticdb-find-result-with-nil-p):
* lisp/cedet/semantic/analyze/complete.el
(semantic-analyze-possible-completions): Use cl-typep instead of
functions like `srecode-dictionary-compound-value-child-p' etc.

5 years agosrecode/srt-mode compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:36:17 +0000 (15:36 +0200)]
srecode/srt-mode compilation fix

* lisp/cedet/srecode/srt-mode.el (srecode/insert): Require to
avoid compilation warning about unknown slot.  Remove function
declarations that point to that file.

5 years agosrecode/find compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:34:00 +0000 (15:34 +0200)]
srecode/find compilation fix

* lisp/cedet/srecode/find.el (srecode/compile): Require to
avoid compilation warning about unknown slot.  Remove function
declarations that point to that file.

5 years agosrecode/dictionary compilation warning fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:32:33 +0000 (15:32 +0200)]
srecode/dictionary compilation warning fix

* lisp/cedet/srecode/dictionary.el (srecode/fields): Require to
avoid compilation warning about unknown slot.  Remove function
declarations that point to that file.

5 years agosrecode/dictionary compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:31:03 +0000 (15:31 +0200)]
srecode/dictionary compilation fix

* lisp/cedet/srecode/ctxt.el (srecode/dictionary): Require to
avoid compilation warning about unknown slot.  Remove function
declarations that point to that file.

5 years agosrecode-inserter-prin-example compilation fix
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:29:17 +0000 (15:29 +0200)]
srecode-inserter-prin-example compilation fix

* lisp/cedet/srecode/insert.el (srecode-inserter-prin-example):
Move prin1 example to file that defines the structure it prints.

5 years agoMove functions from semantic.el to analyze.el to avoid warnings
Lars Ingebrigtsen [Fri, 14 Jun 2019 13:15:09 +0000 (15:15 +0200)]
Move functions from semantic.el to analyze.el to avoid warnings

* lisp/cedet/semantic.el (semantic-analyze-completion-at-point-function)
(semantic-analyze-notc-completion-at-point-function)
(semantic-analyze-nolongprefix-completion-at-point-function): Add
autoloads for the moved functions.

* lisp/cedet/semantic/analyze.el
(semantic-analyze-completion-at-point-function)
(semantic-analyze-notc-completion-at-point-function)
(semantic-analyze-nolongprefix-completion-at-point-function): Move
here from semantic.el to avoid getting compilation warnings about
unknown slot `bounds'.

5 years agoAdjust erc functions after previous erc-pre-send-function change
Lars Ingebrigtsen [Fri, 14 Jun 2019 12:56:23 +0000 (14:56 +0200)]
Adjust erc functions after previous erc-pre-send-function change

5 years agoAdjust erc functions after previous erc-pre-send-function change
Lars Ingebrigtsen [Fri, 14 Jun 2019 12:56:04 +0000 (14:56 +0200)]
Adjust erc functions after previous erc-pre-send-function change

* lisp/erc/erc-goodies.el (noncommands): Use
erc-pre-send-functions instead of the hook.
(erc-send-distinguish-noncommands): Adjust function to new interface.

* lisp/erc/erc-ring.el (ring): Ditto.
(erc-add-to-input-ring): Ditto.

* lisp/erc/erc.el (erc-send-this): Really make obsolete.
(erc-pre-send-functions): Change to a list of functions to allow
erc-goodies and erc-ring to work as before.

5 years agoUnobsolete string-to-multibyte
Lars Ingebrigtsen [Fri, 14 Jun 2019 12:37:29 +0000 (14:37 +0200)]
Unobsolete string-to-multibyte

* lisp/subr.el: Un-obsolete string-to-multibyte, because it's a
useful function.  string-to-unibyte has already been un-obsoleted.

5 years agoUse CLOS-style accessors in oref/oset
Lars Ingebrigtsen [Thu, 13 Jun 2019 16:01:42 +0000 (18:01 +0200)]
Use CLOS-style accessors in oref/oset

* lisp/cedet/srecode/texi.el (srecode-semantic-handle-:texitag):
* lisp/cedet/srecode/table.el (srecode-mode-table-new):
(srecode-dump):
* lisp/cedet/srecode/srt-mode.el (srecode-parse-this-macro):
(semantic-analyze-possible-completions):
* lisp/cedet/srecode/semantic.el (srecode-compound-toString):
(srecode-semantic-apply-tag-to-dict-default):
* lisp/cedet/srecode/mode.el (srecode-minor-mode-templates-menu):
(srecode-edit):
* lisp/cedet/srecode/insert.el (srecode-insert-method):
(srecode-inserter-apply-state):
(srecode-insert-ask-default):
(srecode-insert-method-ask):
(srecode-insert-method-field):
(srecode-insert-method-helper):
(srecode-parse-input):
(srecode-match-end):
(srecode-insert-include-lookup):
(srecode-insert-method):
* lisp/cedet/srecode/find.el (srecode-template-table-in-project-p):
(srecode-template-get-table):
(srecode-template-get-table-for-binding):
(srecode-all-template-hash):
* lisp/cedet/srecode/extract.el (srecode-inserter-extract):
(srecode-inserter-extract):
* lisp/cedet/srecode/el.el (srecode-semantic-apply-tag-to-dict):
* lisp/cedet/srecode/dictionary.el (initialize-instance):
(srecode-dictionary-add-template-table):
(srecode-compound-toString):
* lisp/cedet/srecode/cpp.el (srecode-semantic-apply-tag-to-dict):
* lisp/cedet/srecode/compile.el (srecode-compile-template-table):
(srecode-dump):
* lisp/cedet/srecode/args.el (srecode-semantic-handle-:project):
* lisp/cedet/semantic/texi.el (semantic-analyze-possible-completions):
* lisp/cedet/semantic/symref/list.el (semantic-symref-results-dump):
(semantic-symref-list-create-macro-on-open-hit):
(semantic-symref-list-rename-open-hits):
(semantic-symref-list-map-open-hits):
* lisp/cedet/semantic/symref/idutils.el
(semantic-symref-perform-search):
(semantic-symref-parse-tool-output-one-line):
* lisp/cedet/semantic/symref/global.el (semantic-symref-perform-search):
(semantic-symref-parse-tool-output-one-line):
* lisp/cedet/semantic/symref/cscope.el (semantic-symref-perform-search):
(semantic-symref-parse-tool-output-one-line):
* lisp/cedet/semantic/mru-bookmark.el
(semantic-mrub-ring-to-assoc-list):
* lisp/cedet/semantic/grammar.el
(semantic-analyze-possible-completions):
* lisp/cedet/semantic/decorate/include.el
(semantic-decoration-include-describe):
* lisp/cedet/semantic/debug.el (semantic-debug-highlight-lexical-token):
(semantic-debug-highlight-rule):
* lisp/cedet/semantic/db-typecache.el
(semanticdb-typecache-for-database):
* lisp/cedet/semantic/complete.el
(semantic-collector-calculate-completions-raw):
* lisp/cedet/semantic/bovine/make.el
(semantic-analyze-possible-completions):
* lisp/cedet/semantic/analyze/refs.el (semantic-analyze-refs-impl):
(semantic-analyze-refs-proto):
* lisp/cedet/semantic/analyze/debug.el
(semantic-analyzer-debug-describe-scope):
* lisp/cedet/semantic/analyze.el (semantic-analyze-interesting-tag):
(semantic-analyze-interesting-tag):
(semantic-analyze-pulse):
* lisp/cedet/ede/util.el (ede-update-version):
* lisp/cedet/ede/shell.el (ede-shell-run-something):
* lisp/cedet/ede/project-am.el (project-am-load-makefile):
(project-rescan):
(project-am-macro):
(ede-buffer-mine):
(project-compile-target-command):
(project-am-package-info):
* lisp/cedet/ede/files.el (ede--project-inode):
(ede-directory-get-open-project):
(ede-directory-get-toplevel-open-project):
(ede-find-subproject-for-directory):
(ede-toplevel-project):
* lisp/cedet/ede/cpp-root.el (initialize-instance):
(project-compile-project):
(project-compile-target):
* lisp/cedet/ede/config.el (ede-config-get-configuration):
(project-debug-target):
(project-run-target):
(project-compile-project):
(ede-preprocessor-map):
(ede-java-classpath):
* lisp/cedet/ede/base.el (ede-normalize-file/directory): Use
CLOS-style oref/oset accessors instead of eieio-style :colon
accessors.  This avoids compilation warnings and is allegedly
faster.

5 years agoObsolete erc-send-pre-hook and add new erc-pre-send-function
Lars Ingebrigtsen [Fri, 14 Jun 2019 12:05:24 +0000 (14:05 +0200)]
Obsolete erc-send-pre-hook and add new erc-pre-send-function

* lisp/erc/erc.el (erc-send-pre-hook): Make obsolete.
(erc-send-input): Ditto.
(erc-pre-send-function): New function.
(erc-send-input): Use the new function, and silence byte
compilation warning about the dynamic variable `str' used by the
now-obsolete hook.

5 years agoFix compilation warning in rmailmm
Lars Ingebrigtsen [Fri, 14 Jun 2019 11:30:13 +0000 (13:30 +0200)]
Fix compilation warning in rmailmm

* lisp/mail/rmailmm.el (rmail-mime-insert-bulk): Remove apparently
superfluous call to string-as-unibyte -- the buffer should be
unibyte already at this point.

5 years agoAvoid compilation warning in byte-run
Lars Ingebrigtsen [Fri, 14 Jun 2019 11:23:11 +0000 (13:23 +0200)]
Avoid compilation warning in byte-run

* lisp/emacs-lisp/byte-run.el (macro-declaration-function): Avoid
compilation warning by not using `symbol-function'.

5 years ago* lisp/gnus/message.el: Fix NNTP sending, broken by e51adfbdb7
Stefan Monnier [Fri, 14 Jun 2019 06:51:07 +0000 (02:51 -0400)]
* lisp/gnus/message.el: Fix NNTP sending, broken by e51adfbdb7

(message-check-news-header-syntax): `message--check-continuation-headers`
signals an error instead of returning nil on error.

5 years agoRemove failing test erroneously added in backport
Eli Zaretskii [Fri, 14 Jun 2019 06:40:40 +0000 (09:40 +0300)]
Remove failing test erroneously added in backport

* test/src/thread-tests.el (threads-test-bug33073): Remove
test which cannot work on the emacs-26 branch.  Do not merge
to master.  Reported by Juanma Barranquero <lekktu@gmail.com>.

5 years ago* lisp/net/sieve-manage.el (sieve-manage-parse-capability): Doc fix.
Juanma Barranquero [Fri, 14 Jun 2019 00:24:52 +0000 (02:24 +0200)]
* lisp/net/sieve-manage.el (sieve-manage-parse-capability): Doc fix.

5 years agoStop a tramp test leaving a file behind
Glenn Morris [Fri, 14 Jun 2019 00:24:41 +0000 (20:24 -0400)]
Stop a tramp test leaving a file behind

* test/lisp/net/tramp-tests.el
(tramp-test10-write-region-file-precious-flag):
Avoid leaving a backup file after we are done.

5 years ago* lisp/widget.el (define-widget-keywords): Use `declare`.
Stefan Monnier [Thu, 13 Jun 2019 21:42:58 +0000 (17:42 -0400)]
* lisp/widget.el (define-widget-keywords): Use `declare`.

5 years ago* lisp/progmodes/ps-mode.el (ps-mode-octal-region): Simplify.
Stefan Monnier [Thu, 13 Jun 2019 21:40:32 +0000 (17:40 -0400)]
* lisp/progmodes/ps-mode.el (ps-mode-octal-region): Simplify.

5 years agoFix typo in object-print cleanup
Lars Ingebrigtsen [Thu, 13 Jun 2019 15:42:21 +0000 (17:42 +0200)]
Fix typo in object-print cleanup

* lisp/cedet/srecode/insert.el
(srecode-insert-variable-secondname-handler): Fix typo in
object-print cleanup.

5 years agoRemove outdated FIXME
Lars Ingebrigtsen [Thu, 13 Jun 2019 15:19:32 +0000 (17:19 +0200)]
Remove outdated FIXME

* lisp/emacs-lisp/eieio-core.el (eieio--slot-name-index): Remove
comment about issuing a byte compilation warning about accessing
slots via :initarg -- it was implemented a few months later.

5 years agosemantic/senator.el byte compilation fix
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:58:58 +0000 (16:58 +0200)]
semantic/senator.el byte compilation fix

* lisp/cedet/semantic/senator.el (semantic/analyze): Require to
avoid compilation warnings about unknown slots, and remove
declare-function.

5 years agosemantic/idle.el compilation warning fix
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:57:50 +0000 (16:57 +0200)]
semantic/idle.el compilation warning fix

* lisp/cedet/semantic/idle.el (semantic/analyze): Require to
avoid compilation warnings about unknown slots, and remove
declare-function.

5 years agosemantic/grammar byte compilation fixes
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:56:01 +0000 (16:56 +0200)]
semantic/grammar byte compilation fixes

* lisp/cedet/semantic/grammar.el (semantic/analyze): Require to
avoid compilation warnings about unknown slots, and remove
declare-function.

5 years agosemantic/chart.el compilation warning fixes
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:53:10 +0000 (16:53 +0200)]
semantic/chart.el compilation warning fixes

* lisp/cedet/semantic/chart.el (semantic/db-typecache)
(semantic/scope): Require to avoid byte compilation warnings about
undefined slots.  Remove declare-functions from these packages.

5 years agoFix some cedet compilation warnings pertaining to semantic/db
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:33:06 +0000 (16:33 +0200)]
Fix some cedet compilation warnings pertaining to semantic/db

* lisp/cedet/ede/config.el (semantic/db)
(ede-preprocessor-map): Ditto.

* lisp/cedet/ede/cpp-root.el (semantic/db): Ditto.

* lisp/cedet/ede/emacs.el (semantic/db): Ditto.

* lisp/cedet/ede/linux.el (semantic/db): Require to avoid warnings
about unknown slot lexical-table, and remove declare-functions
from the now-required semantic/db.

5 years agoproject.el compilation warning fix
Lars Ingebrigtsen [Thu, 13 Jun 2019 14:16:49 +0000 (16:16 +0200)]
project.el compilation warning fix

* lisp/progmodes/project.el (xref--regexp-to-extended)
(xref--convert-hits): Declare more xref functions to avoid
compilation warnings.

5 years agoDepessimize bits of CC Mode for long C macros.
Alan Mackenzie [Thu, 13 Jun 2019 14:07:06 +0000 (14:07 +0000)]
Depessimize bits of CC Mode for long C macros.

* lisp/progmodes/cc-engine.el (c-end-of-macro): Check for being in a
degenerate zero length "macro", when setting the macro cache.
(c-determine-+ve-limit): Add in a missing goto-char form for when start-pos is
non-nil.
(c-back-over-member-initializers): Add a search limit parameter.

* lisp/progmodes/cc-fonts.el (c-get-fontification-context): Add a search limit
to c-go-up-list-backward.
(c-font-lock-cut-off-declarators): Add a search limit to
c-back-over-member-initializers.

* lisp/progmodes/cc-mode.el (c-before-change-check-unbalanced-strings): Don't
set c-new-END to the end of logical line (which might be a long macro).
(c-after-change-mark-abnormal-strings): Calculate end-hwm in place of the
setting of c-new-END (above).  Use this as a search limit rather than
c-new-END.

5 years ago; * etc/NEWS: Small cleanup.
Stefan Kangas [Thu, 13 Jun 2019 14:04:40 +0000 (16:04 +0200)]
; * etc/NEWS: Small cleanup.

* etc/NEWS: Merge two bookmark items in NEWS (bug#36188).

5 years agoRemove XEmacs support from bookmark.el
Stefan Kangas [Thu, 13 Jun 2019 14:02:39 +0000 (16:02 +0200)]
Remove XEmacs support from bookmark.el

* lisp/bookmark.el (bookmark-store): Remove XEmacs compat code
(bug#36189).

5 years agoUse cl-print-object instead of object-print throughout cedet
Lars Ingebrigtsen [Thu, 13 Jun 2019 13:58:32 +0000 (15:58 +0200)]
Use cl-print-object instead of object-print throughout cedet

* lisp/cedet/semantic/db-find.el (semanticdb-find-log-activity):
Ditto.

* lisp/cedet/semantic/analyze/debug.el
(semantic-analyzer-debug-insert-include-summary): Ditto.

* lisp/cedet/semantic/bovine/c.el (semantic-c-describe-environment)
(semantic-c-describe-environment)
(semantic-c-describe-environment): Ditto.

* lisp/cedet/semantic/decorate/include.el
(semantic-decoration-fileless-include-describe): Ditto.
(semantic-decoration-all-include-summary): Ditto.

* lisp/cedet/srecode/insert.el
(srecode-insert-variable-secondname-handler): Use cl-print-object
instead of object-print.

5 years agoerc-dcc.el minor clean-ups
Lars Ingebrigtsen [Thu, 13 Jun 2019 12:37:25 +0000 (14:37 +0200)]
erc-dcc.el minor clean-ups

* lisp/erc/erc-dcc.el: Remove outdated comments.
(erc-dcc-get-file): Remove XEmacs compat code.

5 years agoFix erc-dcc server-close code and fix compilation warning
Lars Ingebrigtsen [Thu, 13 Jun 2019 12:35:30 +0000 (14:35 +0200)]
Fix erc-dcc server-close code and fix compilation warning

* lisp/erc/erc-dcc.el (erc-dcc-get-filter): We receive unibyte
data, so no need to convert to unibyte.
(erc-dcc-send-filter): Kill the process before killing the buffer
so that we're not queried about killing the process.

5 years agoMake erc-dcc-server work again by making synchronous
Lars Ingebrigtsen [Thu, 13 Jun 2019 12:26:18 +0000 (14:26 +0200)]
Make erc-dcc-server work again by making synchronous

* lisp/erc/erc-dcc.el (erc-dcc-server): :server and :nowait can't
be mixed, so remove the :nowait.

5 years agoEscape newlines when printing functions in timer list
Pip Cet [Thu, 13 Jun 2019 12:10:56 +0000 (14:10 +0200)]
Escape newlines when printing functions in timer list

* timer-list.el (list-timers): Bind `print-escape-newlines' to avoid
newlines in printed representation (bug#36187).

5 years agoCompilation fix for previous change
Lars Ingebrigtsen [Thu, 13 Jun 2019 11:56:16 +0000 (13:56 +0200)]
Compilation fix for previous change

5 years agoCompilation warning fix for disass.el
Lars Ingebrigtsen [Thu, 13 Jun 2019 11:54:53 +0000 (13:54 +0200)]
Compilation warning fix for disass.el

* lisp/emacs-lisp/disass.el (disassemble-1): Remove a
string-as-unibyte that probably doesn't do anything, because the
string in question should be unibyte anyway.  If the assert fails,
revert the patch.

5 years agoCC Mode: replace an erroneous re-search-forward with search-forward
Alan Mackenzie [Thu, 13 Jun 2019 10:06:33 +0000 (10:06 +0000)]
CC Mode: replace an erroneous re-search-forward with search-forward

Move two declarations to a more suitable point in the cc-engine.el.

* lisp/progmodes/cc-engine.el (c-after-change-unmark-raw-strings): Change an
re-search-forward to search-forward.
(c-semi-lit-near-cache, c-semi-near-cache-limit): Move the declarations.

5 years agoFix display of Hebrew text with precomposed characters
Eli Zaretskii [Thu, 13 Jun 2019 09:41:37 +0000 (12:41 +0300)]
Fix display of Hebrew text with precomposed characters

* lisp/language/hebrew.el (base): Include precomposed
Hebrew characters from the Alphabetic Presentation Forms in
the composition patterns.  (Bug#36171)

5 years agoMerge branch 'master' of git.savannah.gnu.org:/srv/git/emacs
Eli Zaretskii [Thu, 13 Jun 2019 08:53:18 +0000 (11:53 +0300)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

5 years agoFix text shaping of precomposed characters with HarfBuzz
Eli Zaretskii [Thu, 13 Jun 2019 08:49:30 +0000 (11:49 +0300)]
Fix text shaping of precomposed characters with HarfBuzz

* src/hbfont.c (hbfont_shape): Fix setting TO of lglyph for
the case when Lisp shape-gstring function performed some
compositions by itself.  This happens with hebrew.el.  See
https://lists.freedesktop.org/archives/harfbuzz/2019-June/007396.html
for the details of the problem this solves.

5 years agoMove declaration of c-syntax-table-hwm to avoid compiler warnings.
Alan Mackenzie [Thu, 13 Jun 2019 08:46:30 +0000 (08:46 +0000)]
Move declaration of c-syntax-table-hwm to avoid compiler warnings.

This variable was declared after an invocation of a defsubst which used it,
the defsubst being in another file.

* lisp/progmodes/cc-mode (c-syntax-table-hwm): Move the declaration to earlier
in the file.

5 years agoAllow for line breaks in a bytecomp test
Glenn Morris [Thu, 13 Jun 2019 02:31:00 +0000 (19:31 -0700)]
Allow for line breaks in a bytecomp test

* test/lisp/emacs-lisp/bytecomp-tests.el (test-suppression):
Warnings from the byte compiler may be filled.

5 years agoAvoid string-make-multibyte in ps-mode.el
Lars Ingebrigtsen [Thu, 13 Jun 2019 01:12:03 +0000 (03:12 +0200)]
Avoid string-make-multibyte in ps-mode.el

* lisp/progmodes/ps-mode.el (ps-mode-octal-region): Avoid usage of
string-make-multibyte, but work in both unibyte and multibyte buffers.

5 years agoAdd more ps-mode octal tests
Lars Ingebrigtsen [Thu, 13 Jun 2019 01:03:26 +0000 (03:03 +0200)]
Add more ps-mode octal tests

* test/lisp/progmodes/ps-mode-tests.el
(ps-mode-test-octal-region-multibyte): New test.

5 years agoRevert previous ps-mode.el change
Lars Ingebrigtsen [Thu, 13 Jun 2019 00:54:24 +0000 (02:54 +0200)]
Revert previous ps-mode.el change

* lisp/progmodes/ps-mode.el (ps-mode-octal-region): Revert
previous change because the `string-make-unibyte' insertion was
the previous single change (in 2013) to this file, so it must have
some subtle meaning or other.

5 years agoAdd ps-mode-tests.el and remove a compilation warning
Lars Ingebrigtsen [Thu, 13 Jun 2019 00:48:41 +0000 (02:48 +0200)]
Add ps-mode-tests.el and remove a compilation warning

* lisp/progmodes/ps-mode.el (ps-mode-octal-region): Remove a
string-make-unibyte that apparently had no effect here.
* test/lisp/progmodes/ps-mode-tests.el: New file.

5 years agoSuppress warnings in tildify.el
Lars Ingebrigtsen [Thu, 13 Jun 2019 00:23:40 +0000 (02:23 +0200)]
Suppress warnings in tildify.el

* lisp/textmodes/tildify.el (tildify--deprecated-ignore-evironments):
(tildify-tildify, tildify-mode): Suppress warnings about obsolete
internal function `tildify--pick-alist-entry'.  Apparently these
semi-deprecated functions rely on each other.

5 years agoAdd comment to clarify the use of `str'
Lars Ingebrigtsen [Thu, 13 Jun 2019 00:03:55 +0000 (02:03 +0200)]
Add comment to clarify the use of `str'