]> git.eshelyaron.com Git - emacs.git/log
emacs.git
5 years agoDon't manipulate gnus-newsrc-alist if it hasn't been initalized
Eric Abrahamsen [Thu, 3 Oct 2019 23:21:02 +0000 (16:21 -0700)]
Don't manipulate gnus-newsrc-alist if it hasn't been initalized

* lisp/gnus/gnus-group.el (gnus-group-set-info): Packages that use
Gnus summary mode without actually booting Gnus might end up in this
situation. See bug#36903

5 years agoFix bugs found by 2019-09-29 regexp scanner
Paul Eggert [Fri, 4 Oct 2019 21:38:22 +0000 (14:38 -0700)]
Fix bugs found by 2019-09-29 regexp scanner

Problems reported by Mattias Engdegård in:
https://lists.gnu.org/r/emacs-devel/2019-09/threads.html
* lisp/calendar/iso8601.el (iso8601--year-match)
(iso8601--full-date-match, iso8601--without-day-match)
(iso8601--week-date-match, iso8601--ordinal-date-match)
(iso8601--zone-match):
* lisp/textmodes/rst.el (rst-re-alist-def):
Put ‘-’ at the end of bracketed ranges, following the style
suggestion in the Elisp manual.
(iso8601--time-match): Use \([0-9]*\) instead of \([0-9]+\)?
to pacify the regexp scanner.
(iso8601-parse-time): Adjust accordingly.
* lisp/language/burmese.el (burmese-composable-pattern):
* lisp/language/indian.el (devanagari-composable-pattern)
(bengali-composable-pattern, gurmukhi-composable-pattern)
(gujarati-composable-pattern, oriya-composable-pattern)
(telugu-composable-pattern, kannada-composable-pattern)
(malayalam-composable-pattern):
Prefer [ab] to [a-b] when the characters differ by 1,
to pacify the regexp scanner.
* lisp/language/burmese.el (burmese-composable-pattern):
Fix missing-‘\u’ typos.
* lisp/language/indian.el (gurmukhi-composable-pattern):
Fix missing-‘\’ typo.
* lisp/language/tibetan.el (tibetan-regexp):
Quote ‘+’ in regexp to pacify the regexp scanner.  Simplify.
* lisp/textmodes/rst.el (rst-re-alist-def): Fix ‘[]-'...]’
typo by putting the ‘-’ at end of the bracketed expression.

5 years agoMinor style tweaks for recent tab changes
Paul Eggert [Fri, 4 Oct 2019 19:30:28 +0000 (12:30 -0700)]
Minor style tweaks for recent tab changes

* src/dispextern.h (MR_PARTIALLY_VISIBLE_AT_TOP):
* src/window.c (Fwindow_mode_line_height)
(Fwindow_header_line_height, Fwindow_tab_line_height)
(Fwindow_right_divider_width, Fwindow_bottom_divider_width)
(Fwindow_scroll_bar_width, Fwindow_scroll_bar_height):
(Fset_window_configuration, Fcurrent_window_configuration):
Omit unnecessary parens.
* src/dispextern.h (CURRENT_MODE_LINE_HEIGHT)
(CURRENT_HEADER_LINE_HEIGHT, CURRENT_TAB_LINE_HEIGHT):
Add parens needed to make these macros function-like.
* src/window.c (window_resize_check):
* src/window.h (WINDOW_TAB_BAR_P):
* src/xdisp.c (tab_bar_item_info): Reindent.
* src/window.c (window_wants_mode_line)
(window_wants_header_line, window_wants_tab_line):
Simplify (a && b ? 1 : 0) to (a && b).

5 years agoMake mouse scroll show a message instead of dinging at buffer limits
Stefan Kangas [Fri, 9 Aug 2019 07:39:16 +0000 (09:39 +0200)]
Make mouse scroll show a message instead of dinging at buffer limits

* lisp/mwheel.el (mwheel-scroll): Show a message instead of dinging at
end of buffer and beginning of buffer.  This should be less intrusive,
especially when using a trackpad.  (Bug#16196)

5 years agoBind Scroll_Lock to scroll-lock-mode globally
Stefan Kangas [Tue, 20 Aug 2019 17:04:16 +0000 (19:04 +0200)]
Bind Scroll_Lock to scroll-lock-mode globally

* lisp/bindings.el (global-map): Bind Scroll_Lock to
scroll-lock-mode.  (Bug#6861)
* lisp/scroll-lock.el (scroll-lock-mode): Note that the binding will
not work if 'w32-scroll-lock-modifier' is non-nil.
* etc/NEWS: Announce it.

5 years agoAdd tests for secure-hash and improve doc string (Bug#37420)
Stefan Kangas [Mon, 16 Sep 2019 21:42:56 +0000 (23:42 +0200)]
Add tests for secure-hash and improve doc string (Bug#37420)

* src/fns.c (Fsecure_hash_algorithms): Fix typo.
(Fsecure_hash): Add algorithm list to doc string.
* test/src/fns-tests.el (test-secure-hash): New test.

5 years agoDeclare unused vhdl code in align.el obsolete
Stefan Kangas [Thu, 26 Sep 2019 10:31:37 +0000 (12:31 +0200)]
Declare unused vhdl code in align.el obsolete

* lisp/align.el (align-vhdl-rules-list, align-set-vhdl-rules): Declare
obsolete.  (Bug#6207)
(align-dq-string-modes, align-open-comment-modes): Move vhdl-mode to
definition instead of adding it later.

5 years agoFix error in gnu compilation-mode regexp (bug#37582)
Mattias Engdegård [Fri, 4 Oct 2019 13:29:31 +0000 (15:29 +0200)]
Fix error in gnu compilation-mode regexp (bug#37582)

* lisp/progmodes/compile.el (compilation-error-regexp-alist-alist):
Fix a mistake introduced when the regexp was translated to rx.
* test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data)
(compile-test-error-regexps): Add test case.
* etc/compilation.txt: Add example.

5 years agoMake compile-tests re-runnable
Mattias Engdegård [Fri, 4 Oct 2019 13:23:13 +0000 (15:23 +0200)]
Make compile-tests re-runnable

* test/lisp/progmodes/compile-tests.el (compile-test-error-regexps):
Don't rely on compilation-num-errors (etc) all being zero, which they
aren't if the test has been run before.
(compile-tests--test-regexps-data): Change defvar to defconst.

5 years agoRemove semantic-make-local-hook call from CEDET
Lars Ingebrigtsen [Fri, 4 Oct 2019 13:29:30 +0000 (15:29 +0200)]
Remove semantic-make-local-hook call from CEDET

* lisp/cedet/semantic/wisent/grammar.el
(wisent-grammar-setupcode-builder):
* lisp/cedet/semantic/util-modes.el (semantic-highlight-edits-mode)
(semantic-show-unmatched-syntax-mode)
(semantic-show-parser-state-mode):
* lisp/cedet/semantic/mru-bookmark.el (semantic-mru-bookmark-mode):
* lisp/cedet/semantic/imenu.el (semantic-create-imenu-index):
* lisp/cedet/semantic/grammar.el (semantic-grammar-mode):
* lisp/cedet/semantic/grammar-wy.el
(semantic-grammar-wy--install-parser):
* lisp/cedet/semantic/decorate/mode.el
(semantic-decorate-add-pending-decoration)
(semantic-decoration-mode):
* lisp/cedet/semantic.el (semantic--set-buffer-cache): Remove all
calls to the function.

* lisp/cedet/semantic/fw.el (semantic-make-local-hook): Made
obsolete alias for #'ignore by removing XEmacs compat code.

5 years agoRemove some XEmacs compat code from ispell.el
Lars Ingebrigtsen [Fri, 4 Oct 2019 13:24:42 +0000 (15:24 +0200)]
Remove some XEmacs compat code from ispell.el

* lisp/textmodes/ispell.el (ispell-word): Remove XEmacs compat code.

5 years agoRemove some XEmacs compat code from ezimage.el
Lars Ingebrigtsen [Fri, 4 Oct 2019 13:23:54 +0000 (15:23 +0200)]
Remove some XEmacs compat code from ezimage.el

* lisp/ezimage.el (defezimage): Remove XEmacs compat code.

5 years agoRemove XEmacs compat code from re-builder.el
Stefan Kangas [Fri, 4 Oct 2019 00:20:28 +0000 (02:20 +0200)]
Remove XEmacs compat code from re-builder.el

* lisp/emacs-lisp/re-builder.el (top-level)
(reb-color-display-p): Remove XEmacs compat code.

5 years agoRemove some XEmacs compat code from ediff*.el
Lars Ingebrigtsen [Fri, 4 Oct 2019 13:20:41 +0000 (15:20 +0200)]
Remove some XEmacs compat code from ediff*.el

* lisp/vc/ediff-diff.el (ediff-goto-word): Ditto.

* lisp/vc/ediff-init.el (ediff-has-face-support-p)
(ediff-current-diff-A, ediff-current-diff-B)
(ediff-current-diff-C, ediff-current-diff-Ancestor)
(ediff-fine-diff-A, ediff-fine-diff-B, ediff-fine-diff-C)
(ediff-fine-diff-Ancestor, ediff-even-diff-A)
(ediff-even-diff-B, ediff-even-diff-C)
(ediff-even-diff-Ancestor, ediff-odd-diff-A, ediff-odd-diff-B)
(ediff-odd-diff-C, ediff-odd-diff-Ancestor)
(ediff-with-syntax-table): Ditto.

* lisp/vc/ediff-mult.el (ediff-dir-diffs-buffer-map)
(ediff-setup-meta-map, ediff-set-meta-overlay): Ditto.

* lisp/vc/ediff-util.el (ediff-setup-keymap)
(ediff-toggle-wide-display, ediff-toggle-multiframe)
(ediff-toggle-use-toolbar, ediff-really-quit)
(ediff-good-frame-under-mouse)
(ediff-make-bullet-proof-overlay): Ditto.

* lisp/vc/ediff-wind.el (ediff-setup-control-frame)
(ediff-refresh-control-frame): Remove XEmacs compat code.

5 years ago* lisp/subr.el (generate-new-buffer): Move (from files.el) before first use
Stefan Monnier [Fri, 4 Oct 2019 12:56:18 +0000 (08:56 -0400)]
* lisp/subr.el (generate-new-buffer): Move (from files.el) before first use

(with-temp-file, with-output-to-string): Use it.

* lisp/files.el (generate-new-buffer): Move to subr.el.

5 years ago(project--vc-list-files): Optimize the Hg implementation
Dmitry Gutov [Fri, 4 Oct 2019 12:50:16 +0000 (15:50 +0300)]
(project--vc-list-files): Optimize the Hg implementation

* lisp/progmodes/project.el (project--vc-list-files):
Optimize the Hg implementation.

5 years agoRemove some more XEmacs compat code from viper*.el
Lars Ingebrigtsen [Fri, 4 Oct 2019 12:44:34 +0000 (14:44 +0200)]
Remove some more XEmacs compat code from viper*.el

* lisp/emulation/viper-ex.el (viper-ex-read-file-name): Ditto.

* lisp/emulation/viper-init.el (viper-ms-style-os-p)
(viper-has-face-support-p, viper-deactivate-input-method)
(viper-activate-input-method, viper-set-input-method): Ditto.

* lisp/emulation/viper-util.el
(viper-get-saved-cursor-color-in-replace-mode)
(viper-get-saved-cursor-color-in-insert-mode)
(viper-get-saved-cursor-color-in-emacs-mode)
(viper-set-replace-overlay, viper-key-to-emacs-key)
(viper-set-unread-command-events): Ditto.

* lisp/emulation/viper.el (viper-go-away, viper-set-hooks)
(viper-non-hook-settings): Remove XEmacs compat code.

5 years agoRemove more XEmacs compat code from viper-*.el
Lars Ingebrigtsen [Fri, 4 Oct 2019 12:29:58 +0000 (14:29 +0200)]
Remove more XEmacs compat code from viper-*.el

* lisp/emulation/viper-cmd.el (viper-special-read-and-insert-char)
(viper-next-line-carefully, viper-next-line)
(viper-previous-line): Ditto.

* lisp/emulation/viper-mous.el (viper-surrounding-word)
(viper-parse-mouse-key): Remove XEmacs compat code.

5 years agoRemove XEmacs-only code from snake.el
Lars Ingebrigtsen [Fri, 4 Oct 2019 12:25:17 +0000 (14:25 +0200)]
Remove XEmacs-only code from snake.el

* lisp/play/snake.el (snake-mode): Remove XEmacs-only code.

5 years agoRemove XEmacs code from tetris.el
Lars Ingebrigtsen [Fri, 4 Oct 2019 12:24:36 +0000 (14:24 +0200)]
Remove XEmacs code from tetris.el

* lisp/play/tetris.el (tetris-mode): Remove XEmacs-only code.

5 years agoRemove XEmacs compat code from idlw-shell.el
Lars Ingebrigtsen [Fri, 4 Oct 2019 12:22:41 +0000 (14:22 +0200)]
Remove XEmacs compat code from idlw-shell.el

* lisp/progmodes/idlw-shell.el (idlwave-shell-make-temp-file):
Make into obsolete alias.
(idlwave-shell-temp-file): Adjust callers.

5 years agoRevert "Improve docstrings auto-generated by `define-minor-mode'"
Juanma Barranquero [Fri, 4 Oct 2019 12:02:13 +0000 (14:02 +0200)]
Revert "Improve docstrings auto-generated by `define-minor-mode'"

This reverts commit a397fa06d18d6ae37a3a1288f269e1ae9eb3b569.
The original change breaks bootstrapping because of a circular dependency.

5 years ago; Fix reported warnings
Dmitry Gutov [Fri, 4 Oct 2019 08:29:49 +0000 (11:29 +0300)]
; Fix reported warnings

5 years agoUse file-name-as-directory
Dmitry Gutov [Fri, 4 Oct 2019 08:08:38 +0000 (11:08 +0300)]
Use file-name-as-directory

* lisp/progmodes/project.el (project--vc-list-files): Use
file-name-as-directory, to be on the safe side.

5 years agoRemove more XEmacs compat code in cperl-mode.el
Stefan Kangas [Thu, 3 Oct 2019 23:54:56 +0000 (01:54 +0200)]
Remove more XEmacs compat code in cperl-mode.el

* lisp/progmodes/cperl-mode.el (condition-case, cperl-problems)
(cperl-problems-old-emaxen, cperl-init-faces)
(cperl-word-at-point): Remove more XEmacs compat code.

5 years agoImprove docstrings auto-generated by `define-minor-mode'
Juanma Barranquero [Thu, 3 Oct 2019 23:26:07 +0000 (01:26 +0200)]
Improve docstrings auto-generated by `define-minor-mode'

* lisp/emacs-lisp/easy-mmode.el (easy-mmode--mode-docstring):
When using `easy-mmode--arg-docstring' to auto-generate a
docstring, refill it up to `emacs-lisp-docstring-fill-column'.

5 years agoMore doc fixes in package.el (Bug#37544)
Stefan Kangas [Sun, 22 Sep 2019 00:21:54 +0000 (02:21 +0200)]
More doc fixes in package.el (Bug#37544)

* lisp/emacs-lisp/package.el (package-menu-hide-low-priority)
(package-pinned-packages, package-load-descriptor)
package-archive-version, package-archive-contents)
package--read-archive-file, package-read-archive-contents)
(package-unsigned-archives, package-read-all-archive-contents)
(package--download-and-read-archives, package-install):
* lisp/subr.el (package--description-file):
* test/lisp/emacs-lisp/package-tests.el: Doc fixes.

5 years agoSpeed up project-files for Git projects
Dmitry Gutov [Thu, 3 Oct 2019 23:03:04 +0000 (02:03 +0300)]
Speed up project-files for Git projects

* lisp/progmodes/project.el (project-files): New method.
Implementation for VC projects that uses 'git ls-files' or 'hg
status --all' for listing.  With gratitude to Tassilo Horn who has
done most of the legwork and wrote the first version of the code
(https://lists.gnu.org/archive/html/emacs-devel/2019-10/msg00069.html).
(project--vc-list-files): New function, to be used by the above.
(project--find-regexp-in-files):
Silence warnings about nonexistent files.

5 years agoFurther improve button.el support for help-echo
Basil L. Contovounesios [Thu, 26 Sep 2019 23:04:33 +0000 (00:04 +0100)]
Further improve button.el support for help-echo

The last change to forward-button added support for help-echo values
that are functions.  This patch fixes the arguments passed to such
functions and further adds support for help-echo values that are
forms (bug#37515).
* doc/lispref/display.texi (Button Properties): Fix description of
help-echo button property.
* lisp/button.el (button--help-echo): New function.
(forward-button): Use it.
(backward-button): Clarify help-echo reference in docstring.
* test/lisp/button-tests.el (button--help-echo-string)
(button--help-echo-form, button--help-echo-function): New tests.

5 years agoUse lexical-binding in button.el
Basil L. Contovounesios [Tue, 1 Oct 2019 01:22:31 +0000 (02:22 +0100)]
Use lexical-binding in button.el

* lisp/button.el: Use lexical-binding.  Expand Keywords header.
Quote function symbols as such.  Use ;;;-comments where appropriate.
(button): Remove outdated commentary of defface.
(define-button-type, make-button, insert-button, make-text-button)
(insert-text-button): Clarify in docstring that PROPERTIES argument
is a plist.
(button-type-subtype-p, button-has-type-p): Do not overspecify
return value in docstring.
(button-put): Fix typo in commentary.

5 years agoPreserve point better in hs-hide-comment-region
John Yates [Thu, 3 Oct 2019 16:55:35 +0000 (18:55 +0200)]
Preserve point better in hs-hide-comment-region

* lisp/progmodes/hideshow.el (hs-hide-comment-region): Preserve point
better when collapsing the region (bug#10856).

Copyright-paperwork-exempt: yes

5 years agoMake lisp-do-defun do the right thing with trailing comments
Lars Ingebrigtsen [Thu, 3 Oct 2019 16:07:12 +0000 (18:07 +0200)]
Make lisp-do-defun do the right thing with trailing comments

* lisp/progmodes/inf-lisp.el (lisp-do-defun): Avoid including
trailing comments in the region (bug#7974).

5 years agoFix bytecomp.el warning a different way than the previous patch
Lars Ingebrigtsen [Thu, 3 Oct 2019 15:17:50 +0000 (17:17 +0200)]
Fix bytecomp.el warning a different way than the previous patch

* lisp/emacs-lisp/bytecomp.el (emacs-lisp-compilation-mode-map):
No need to use set-keymap-parent here; `define-derived-mode' will
do that automatically.

5 years agoFix comment in previous doc-view patch
Lars Ingebrigtsen [Thu, 3 Oct 2019 14:57:03 +0000 (16:57 +0200)]
Fix comment in previous doc-view patch

* lisp/doc-view.el (doc-view-open-text): Comment fix.

5 years agoIn doc-view, keep point on the equivalent page in the text version
Lars Ingebrigtsen [Thu, 3 Oct 2019 14:54:44 +0000 (16:54 +0200)]
In doc-view, keep point on the equivalent page in the text version

* lisp/doc-view.el (doc-view-open-text): After opening the text
version, put point on the page the user was reading (bug#16541).

5 years ago* lisp/pcomplete.el: Mark 'pcomplete' command as obsolete
Stefan Monnier [Thu, 3 Oct 2019 14:36:00 +0000 (10:36 -0400)]
* lisp/pcomplete.el: Mark 'pcomplete' command as obsolete

Remove redundant ':group's.
(pcomplete, pcomplete-help): Mark as obsolete.

5 years agoMention the vc diff switches in diff-switches
Lars Ingebrigtsen [Thu, 3 Oct 2019 14:32:55 +0000 (16:32 +0200)]
Mention the vc diff switches in diff-switches

* lisp/vc/diff.el (diff-switches): Mention the vc diff switches in
the doc string (bug#4422).

5 years agoC++ Mode: Correct the fontification of const auto foo
Alan Mackenzie [Thu, 3 Oct 2019 14:26:14 +0000 (14:26 +0000)]
C++ Mode: Correct the fontification of const auto foo

* lisp/progmodes/cc-engine.el (c-forward-decl-or-cast-1): Correct a coding
error involving `and' and `or'.

5 years agoTouch up previous shr-dom-to-xml encoding change
Lars Ingebrigtsen [Thu, 3 Oct 2019 14:15:15 +0000 (16:15 +0200)]
Touch up previous shr-dom-to-xml encoding change

* lisp/net/shr.el (shr-dom-to-xml): Include an XML declaration if
we're encoding the data.
(shr-parse-image-data): Add comment about why encoding is necessary.

5 years agoFix up previous SVG-multibyte fix
Lars Ingebrigtsen [Wed, 2 Oct 2019 11:19:17 +0000 (13:19 +0200)]
Fix up previous SVG-multibyte fix

* lisp/net/shr.el (shr-dom-to-xml): For SVG images, take an
optional charset parameter to return unibyte data.
(shr-parse-image-data): Use it.
(shr-tag-svg): Ditto.
(svg--wrap-svg): Revert previous kludge.

5 years agoC++ Mode: Fontify correctly declarators with identifier preceded by &
Alan Mackenzie [Thu, 3 Oct 2019 12:50:08 +0000 (12:50 +0000)]
C++ Mode: Fontify correctly declarators with identifier preceded by &

The problem was bar in the following being spuriously recognised as a
function, and foo as a type, as though the & were a *: Foo foo (&bar);.

* lisp/progmodes/cc-engine.el (c-forward-decl-or-cast-1): New variable
got-function-name-prefix, which is set when an operator like * (but not &)
precedes the putative identifer in parentheses.  Test this variable when
deciding whether or not to "move the type backwards" to the previous
identifier.

* lisp/progmodes/cc-langs.el (c-type-decl-operator-prefix-key): New lang const
and var.

5 years agoFix typo in last commit
Michael Albinus [Thu, 3 Oct 2019 08:47:12 +0000 (10:47 +0200)]
Fix typo in last commit

5 years agoFurther adaptions for shadowfile-tests.el
Michael Albinus [Thu, 3 Oct 2019 08:44:02 +0000 (10:44 +0200)]
Further adaptions for shadowfile-tests.el

* test/lisp/shadowfile-tests.el: Change some traces.
(shadow-test-remote-temporary-file-directory): Adapt also remote
home directory.
(shadow--tests-cleanup): Cleanup Tramp.

5 years agoDon't use obsolete name in em-cmpl.el
Stefan Kangas [Thu, 3 Oct 2019 02:08:11 +0000 (04:08 +0200)]
Don't use obsolete name in em-cmpl.el

* lisp/eshell/em-cmpl.el (eshell-complete-lisp-symbol): Update
reference to 'elisp-completion-at-point' from its obsolete name.
Reported by Carlos Pita <carlosjosepita@gmail.com>.  (Bug#31906)

5 years ago* lisp/tab-bar.el (tab-bar-show): New defcustom.
Juri Linkov [Wed, 2 Oct 2019 20:18:01 +0000 (23:18 +0300)]
* lisp/tab-bar.el (tab-bar-show): New defcustom.

* lisp/tab-bar.el (tab-bar-close-current-tab, tab-bar-close-tab):
(tab-bar-new-tab): Use tab-bar-show.

* doc/emacs/frames.texi (Tab Bars): Add tab-bar-show.

* lisp/speedbar.el (speedbar-mode): Set buffer-local tab-bar-mode
and tab-line-format to nil to not show in dedicated speedbar frame.

5 years ago* src/w32inevt.c: Take into account FRAME_TAB_BAR_LINES.
Juri Linkov [Wed, 2 Oct 2019 19:54:56 +0000 (22:54 +0300)]
* src/w32inevt.c: Take into account FRAME_TAB_BAR_LINES.

* src/w32inevt.c (resize_event, maybe_generate_resize_event):
Subtract FRAME_TAB_BAR_LINES from FRAME_MENU_BAR_LINES.

5 years agoFix MS-Windows error when a directory on PATH doesn't exist
Eli Zaretskii [Wed, 2 Oct 2019 16:42:43 +0000 (19:42 +0300)]
Fix MS-Windows error when a directory on PATH doesn't exist

* src/w32.c (faccessat): Support more MS-Windows native error
codes that should be translated to ENOENT.  (Bug#37576)

5 years agoDon't mention server-socket-dir in FAQ
Stefan Kangas [Wed, 2 Oct 2019 13:25:57 +0000 (15:25 +0200)]
Don't mention server-socket-dir in FAQ

server-socket-dir is a defvar, and users should use the defcustom
server-name instead.

* doc/misc/efaq.texi (Using an already running Emacs process): Remove
details on server-socket-dir, refer to Emacs Manual.  (Bug#20675)

5 years agoFix a typo in url-http.el
Eli Zaretskii [Wed, 2 Oct 2019 15:24:03 +0000 (18:24 +0300)]
Fix a typo in url-http.el

* lisp/url/url-http.el (url-http-parse-headers): Fix a typo.
Reported by Mattias Engdegård <mattiase@acm.org>.

5 years agoDon't add trailing whitespace when passing argument to GDB
Sergio Durigan Junior [Sun, 15 Sep 2019 18:50:17 +0000 (14:50 -0400)]
Don't add trailing whitespace when passing argument to GDB

* lisp/progmodes/gdb-mi.el (gdb-send): Don't append whitespace to
'gdb-continuation'.  (Bug#25488)

5 years agoUpdate a substitute-command-keys test
Glenn Morris [Wed, 2 Oct 2019 00:35:26 +0000 (17:35 -0700)]
Update a substitute-command-keys test

* test/src/doc-tests.el (doc-test-substitute-command-keys):
Update for recent minibuffer map change.

5 years agoGnus registry shutdown should also run the unload-hook
Eric Abrahamsen [Tue, 1 Oct 2019 23:25:11 +0000 (16:25 -0700)]
Gnus registry shutdown should also run the unload-hook

* lisp/gnus/gnus-registry.el (gnus-registry-clear): Clearing the
registry should also run the unload hooks.
  (gnus-registry-article-marks-to-names,
  gnus-registry-article-marks-to-chars): Now we can use a more general
  test here.

5 years agoMerge branch 'feature/tabs'
Juri Linkov [Tue, 1 Oct 2019 20:15:03 +0000 (23:15 +0300)]
Merge branch 'feature/tabs'

5 years agoRemove unused code and reformat to 70 columns.
Juri Linkov [Tue, 1 Oct 2019 20:01:08 +0000 (23:01 +0300)]
Remove unused code and reformat to 70 columns.

5 years agoAvoid bugging out on multibyte SVG data in shr
Lars Ingebrigtsen [Tue, 1 Oct 2019 19:51:23 +0000 (21:51 +0200)]
Avoid bugging out on multibyte SVG data in shr

* lisp/net/shr.el (svg--wrap-svg): Ensure that the SVG data is
unibyte.

5 years agoRespect buffer-local values in comint-read-input-ring
Lars Ingebrigtsen [Tue, 1 Oct 2019 19:22:21 +0000 (21:22 +0200)]
Respect buffer-local values in comint-read-input-ring

* lisp/comint.el (comint-read-input-ring): Use the buffer-local
values (bug#6432).

5 years agoRemove old commented out XEmacs compat code from syntax.el (Bug#37524)
Stefan Kangas [Sat, 14 Sep 2019 13:44:54 +0000 (15:44 +0200)]
Remove old commented out XEmacs compat code from syntax.el (Bug#37524)

* lisp/emacs-lisp/syntax.el: Remove ancient commented out XEmacs
compat code.  This code has been commented out since 2001.

5 years agoRemove XEmacs compat code from url-*.el (Bug#37524)
Stefan Kangas [Sat, 14 Sep 2019 13:35:09 +0000 (15:35 +0200)]
Remove XEmacs compat code from url-*.el (Bug#37524)

* lisp/url/url-file.el (url-file-build-filename, url-file)
* lisp/url/url-privacy.el (url-setup-privacy-info): Remove XEmacs
compat code.
(url-device-type): Declare obsolete.

5 years agoRemove XEmacs compat code from winner.el (Bug#37524)
Stefan Kangas [Sat, 14 Sep 2019 13:23:57 +0000 (15:23 +0200)]
Remove XEmacs compat code from winner.el (Bug#37524)

* lisp/winner.el (winner-active-region, winner-edges)
(winner-window-list, winner-sorted-window-list, winner-win-data)
(winner-make-point-alist): Remove XEmacs compat code.

5 years agoRemove XEmacs compat code from term.el (Bug#37524)
Stefan Kangas [Sat, 14 Sep 2019 13:15:27 +0000 (15:15 +0200)]
Remove XEmacs compat code from term.el (Bug#37524)

* lisp/term.el (term-mode-map, term-raw-map, term-mouse-paste):
Remove XEmacs compat code.

5 years agoAdd support for Dired file marking from image-mode
Lars Ingebrigtsen [Tue, 1 Oct 2019 17:53:48 +0000 (19:53 +0200)]
Add support for Dired file marking from image-mode

* doc/emacs/files.texi (File Conveniences): Document them.

* lisp/image-mode.el (image-mode--mark-file): New function.
(image-mode-unmark-file, image-mode-mark-file)
(image-mode-copy-file-name-as-kill): New commands and keystrokes.

5 years agoMove url-ns.el to obsolete/
Stefan Kangas [Tue, 1 Oct 2019 14:20:02 +0000 (16:20 +0200)]
Move url-ns.el to obsolete/

* lisp/url/url-ns.el: Move from here...
* lisp/obsolete/url-ns.el: ...to here.  (Bug#19822)

5 years agoTweak mouse highlights in ediff-help
Lars Ingebrigtsen [Tue, 1 Oct 2019 14:55:48 +0000 (16:55 +0200)]
Tweak mouse highlights in ediff-help

* lisp/vc/ediff-help.el (ediff-set-help-overlays): Only put the
mouse-face overlay on the actual commands (bug#5079).  This avoids
a problem when you have very wide frames: The leading blank
portion of the buffer would get the mouse highlights.

5 years agoRemove XEmacs compat code from ediff-help.el
Lars Ingebrigtsen [Tue, 1 Oct 2019 14:51:45 +0000 (16:51 +0200)]
Remove XEmacs compat code from ediff-help.el

* lisp/vc/ediff-help.el (ediff-help-region-map)
(ediff-set-help-overlays, ediff-help-for-quick-help): Remove
XEmacs compat code.

5 years agoMake the help page mention the customizeable global mode variable
Lars Ingebrigtsen [Tue, 1 Oct 2019 14:45:24 +0000 (16:45 +0200)]
Make the help page mention the customizeable global mode variable

* lisp/help-fns.el (help-fns--customize-variable): Factor out into
own function for reuse.
(help-fns--globalized-minor-mode): Use it to mention the
equivalent variable.

* lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode):
Mark globalized minor modes as such (bug#7177).

5 years agoFix build error in bytecomp.el from previous change
Lars Ingebrigtsen [Tue, 1 Oct 2019 14:40:57 +0000 (16:40 +0200)]
Fix build error in bytecomp.el from previous change

5 years agoAdd a new command in *Compile-Log* buffers to re-byte-compile
Lars Ingebrigtsen [Tue, 1 Oct 2019 13:39:59 +0000 (15:39 +0200)]
Add a new command in *Compile-Log* buffers to re-byte-compile

* lisp/emacs-lisp/bytecomp.el (emacs-lisp-compilation-recompile):
New command (bug#4516).
(emacs-lisp-compilation--current-file)
(emacs-lisp-compilation-mode-map): New variables with new `g'
binding.
(byte-compile-log-file): Set variable so that `g' can recompile it.

5 years ago; Auto-commit of loaddefs files.
Glenn Morris [Tue, 1 Oct 2019 13:26:28 +0000 (06:26 -0700)]
; Auto-commit of loaddefs files.

5 years agoAllow 'M-<' in the minibuffer to behave more logically
Lars Ingebrigtsen [Tue, 1 Oct 2019 13:01:52 +0000 (15:01 +0200)]
Allow 'M-<' in the minibuffer to behave more logically

* doc/lispref/minibuf.texi (Completion Commands)
(Text from Minibuffer): Document it.

* lisp/minibuffer.el (minibuffer-beginning-of-buffer): New command
(bug#3447).
(map): Bind it.

5 years agoCorrect some custom type typos
Robert Pluim [Tue, 1 Oct 2019 08:50:47 +0000 (10:50 +0200)]
Correct some custom type typos

* lisp/image.el (image-use-external-converter):
* lisp/progmodes/sql.el (sql-use-indent-support):
* lisp/vc/add-log.el (add-log-dont-create-changelog-file): Fix
misspelled 'boolean custom type.

* lisp/progmodes/flymake-cc.el (flymake-cc-command): Correct custom
type specification.  (Bug#30990)

5 years agoMove undocumented time-stamp formats closer to format-time-string
Stephen Gildea [Tue, 1 Oct 2019 03:22:51 +0000 (20:22 -0700)]
Move undocumented time-stamp formats closer to format-time-string

* time-stamp.el (time-stamp-string-preprocess): Update some undocumented
formatting characters of time-stamp format for closer (still incomplete)
alignment with format-time-string.  They have displayed a warning since
Emacs 20 (released in 1997), so it is unlikely anyone is using them.

* time-stamp-tests.el: Update tests to match new expectations.

5 years agotime-stamp doc: recommend formats closer to format-time-string
Stephen Gildea [Tue, 1 Oct 2019 03:06:16 +0000 (20:06 -0700)]
time-stamp doc: recommend formats closer to format-time-string

* time-stamp.el (time-stamp-format, time-stamp-pattern): Update
recommended (documented) formats.  No code changes, just documentation.
All recommended formats are compatible at least as far back as Emacs
22.1 (released in 2007) and are now closer to compatibility with
format-time-string.

* time-stamp-tests.el: Update test comments to match.

5 years agoBump up max_specpdl_size to 1600
Juanma Barranquero [Tue, 1 Oct 2019 02:33:28 +0000 (04:33 +0200)]
Bump up max_specpdl_size to 1600

* src/eval.c (init_eval_once): Set max_specpdl_size to 1600.
* doc/lispref/variables.texi (Local Variables): Document it.

5 years agoUpdate calling convention for nnmaildir-close-server
Eric Abrahamsen [Mon, 30 Sep 2019 19:30:31 +0000 (12:30 -0700)]
Update calling convention for nnmaildir-close-server

* lisp/gnus/nnmaildir.el (nnmaildir-close-server): To take an optional
"defs" arg, as changed in 2712187.

5 years ago* lisp/gnus/mm-uu.el: Use lexical-binding and cl-defstruct
Stefan Monnier [Mon, 30 Sep 2019 19:08:41 +0000 (15:08 -0400)]
* lisp/gnus/mm-uu.el: Use lexical-binding and cl-defstruct

(mm-uu-type-alist): Make functions visible to byte-compiler.
(mm-uu-entry): New defstruct.
(mm-uu-configure): Use mapconcat.
(mm-uu-dissect): Avoid setq on `func`.

5 years agoFix quoting in gnutls.c comments and strings
Eli Zaretskii [Mon, 30 Sep 2019 18:59:58 +0000 (21:59 +0300)]
Fix quoting in gnutls.c comments and strings

* src/gnutls.c (gnutls_make_error, emacs_gnutls_global_init)
(Fgnutls_symmetric_encrypt, Fgnutls_symmetric_decrypt)
(Fgnutls_hash_mac, Fgnutls_hash_digest): Fix quoting in doc
strings and comments.

5 years agoMake doc-view error message more informative
Lars Ingebrigtsen [Mon, 30 Sep 2019 15:39:38 +0000 (17:39 +0200)]
Make doc-view error message more informative

* lisp/doc-view.el (doc-view-initiate-display): Make error message
clearer (bug#3827).

5 years agoFix problem with non-ASCII MML description strings
Lars Ingebrigtsen [Mon, 30 Sep 2019 15:13:10 +0000 (17:13 +0200)]
Fix problem with non-ASCII MML description strings

* lisp/gnus/mml.el (mml-insert-tag): Quote non-ASCII parameters.
(mml-insert-mime-headers): Make it possible to have non-ASCII
descriptions (bug#37555).

5 years agoMention locale-related complications in format-time-string doc string
Lars Ingebrigtsen [Mon, 30 Sep 2019 14:47:48 +0000 (16:47 +0200)]
Mention locale-related complications in format-time-string doc string

* src/timefns.c (Fformat_time_string): Mention that the width in
specifiers like %NX is often in bytes, not characters (bug#20258).

5 years agoFix recent mm-uu.el typo
Lars Ingebrigtsen [Mon, 30 Sep 2019 13:51:42 +0000 (15:51 +0200)]
Fix recent mm-uu.el typo

* lisp/gnus/mm-uu.el (mm-uu-pgp-signed-extract-1): Fix typo in
mm-uu introduced by previous patch.

5 years agoImprove description of face merging
Eli Zaretskii [Mon, 30 Sep 2019 07:49:50 +0000 (10:49 +0300)]
Improve description of face merging

* doc/lispref/display.texi (Displaying Faces): More accurate
description of merging face attributes of "underlying text".
(Bug#1222)

5 years agoMake elisp- and emacs-index-search and default to the thing under point
Lars Ingebrigtsen [Mon, 30 Sep 2019 06:57:45 +0000 (08:57 +0200)]
Make elisp- and emacs-index-search and default to the thing under point

* lisp/menu-bar.el (elisp-index-search): Default to the thing
under point interactively (bug#1119).
(emacs-index-search): Ditto.
(emacs-index--prompt): New helper function.

5 years agoRefactor mm-decode and friends to be explicit about when errors happen
Lars Ingebrigtsen [Mon, 30 Sep 2019 06:41:43 +0000 (08:41 +0200)]
Refactor mm-decode and friends to be explicit about when errors happen

* lisp/gnus/mm-decode.el (mm-sec-status):
(mm-sec-error): New functions to handle decryption problems more
explicitly (bug#18393).
(mm-possibly-verify-or-decrypt): Use the `sec-error' data to
determine whether the operation failed or not.

* lisp/gnus/mml-smime.el: Ditto.

* lisp/gnus/mml2015.el: Used throughout.

5 years agoFix rendering of degenerate tables some more in shr.el
Lars Ingebrigtsen [Mon, 30 Sep 2019 05:27:46 +0000 (07:27 +0200)]
Fix rendering of degenerate tables some more in shr.el

* lisp/net/shr.el (shr--fix-tbody): New function (bug#31665).
(shr--fix-table): Use it to fix the
<table><tbody>foo</tbody></table> case.

5 years agoshr table fix refactoring
Lars Ingebrigtsen [Mon, 30 Sep 2019 05:17:12 +0000 (07:17 +0200)]
shr table fix refactoring

* lisp/net/shr.el (shr--fix-table): Refactor out into own function
from...
(shr-tag-table): ... this function.

5 years agoChange the commands in image-converter--converters to lists
Lars Ingebrigtsen [Mon, 30 Sep 2019 04:29:27 +0000 (06:29 +0200)]
Change the commands in image-converter--converters to lists

* lisp/image/image-converter.el (image-converter--converters):
Change format of the commands to lists.
(image-converter--probe, image-converter--convert): Adjust usages.

5 years agoRename the new convert-images-externally variable
Lars Ingebrigtsen [Mon, 30 Sep 2019 04:00:52 +0000 (06:00 +0200)]
Rename the new convert-images-externally variable

* doc/emacs/files.texi (File Conveniences): Adjust documentation.

* lisp/image.el (image-use-external-converter): Rename from
convert-images-externally.

5 years agoSilence byte-compiler warning
Juanma Barranquero [Mon, 30 Sep 2019 01:31:53 +0000 (03:31 +0200)]
Silence byte-compiler warning

* lisp/obsolete/info-edit.el (ibuffer-help-buffer-modes): Defvar it.

5 years ago* lisp/dired-x.el (dired-virtual): Fix typo.
Stefan Kangas [Sun, 29 Sep 2019 22:42:47 +0000 (00:42 +0200)]
* lisp/dired-x.el (dired-virtual): Fix typo.

5 years ago* lisp/nxml/rng-valid.el: Use define-minor-mode
Stefan Monnier [Sun, 29 Sep 2019 22:15:56 +0000 (18:15 -0400)]
* lisp/nxml/rng-valid.el: Use define-minor-mode

Remove redundant `:group`s.
(rng-validate-mode): Use define-minor-mode.
(rng-validate-clear): Let-bind rng-current-schema instead of passing
a `no-change-schema` argument.

5 years agoFix indenting in perl functions with doc-comments
Tom Willemse [Sun, 11 Oct 2015 22:45:49 +0000 (00:45 +0200)]
Fix indenting in perl functions with doc-comments

* lisp/progmodes/perl-mode.el (perl-calculate-indent): Skip
doc-comments as well as comments and skip the entire comment, not just
the line.  (Bug#21647)

5 years agoUpdate iso8601-tests for new interface
Lars Ingebrigtsen [Sun, 29 Sep 2019 19:57:59 +0000 (21:57 +0200)]
Update iso8601-tests for new interface

5 years agoMake iso8601-parse take a FORM parameter like `decode-time'
Lars Ingebrigtsen [Sun, 29 Sep 2019 19:55:20 +0000 (21:55 +0200)]
Make iso8601-parse take a FORM parameter like `decode-time'

* lisp/calendar/iso8601.el (iso8601-parse-time, iso8601-parse):
Take a FORM parameter like `decode-time'.

5 years agoAdd support for sub-second ISO8601 strings
Lars Ingebrigtsen [Sun, 29 Sep 2019 19:22:29 +0000 (21:22 +0200)]
Add support for sub-second ISO8601 strings

* lisp/calendar/iso8601.el (iso8601--decimalize): New function.
(iso8601-parse-time): Support sub-second ISO8601 times.

5 years ago* src/timefns.c (Fdecode_time): Improve doc string.
Paul Eggert [Sun, 29 Sep 2019 18:11:59 +0000 (13:11 -0500)]
* src/timefns.c (Fdecode_time): Improve doc string.

5 years agoClarify recent ert manual change
Stefan Kangas [Sun, 29 Sep 2019 16:26:50 +0000 (18:26 +0200)]
Clarify recent ert manual change

* doc/misc/ert.texi (Running Tests in Batch Mode): Say that ert test
selector strings are regular expressions.

5 years agoRemove the compilation-arrow-overlay on a major mode change/reinitialization
Alan Mackenzie [Sun, 29 Sep 2019 15:39:16 +0000 (15:39 +0000)]
Remove the compilation-arrow-overlay on a major mode change/reinitialization

At the same time, remove the 2-character left margin.

* lisp/progmodes/compile.el (compilation-set-up-arrow-spec-in-margin): put
compilation-tear-down-arrow-spec-in-margin onto change-major-mode-hook.

5 years agoAdd `rx-submatch-n' for compatibility (bug#37517)
Mattias Engdegård [Sun, 29 Sep 2019 14:59:58 +0000 (16:59 +0200)]
Add `rx-submatch-n' for compatibility (bug#37517)

It was an internal symbol in the old `rx' implementation, used in old
versions of the `flycheck' package.

* lisp/emacs-lisp/rx.el (rx-submatch-n): Alias of `rx-to-string'.
* test/lisp/emacs-lisp/rx-tests.el (rx-compat): Test it.

5 years agoFix reverting doc-view buffers
Lars Ingebrigtsen [Sun, 29 Sep 2019 12:58:38 +0000 (14:58 +0200)]
Fix reverting doc-view buffers

* lisp/doc-view.el (doc-view--revert-buffer): Actually use the new
version of the PDF data (bug#26996).

5 years agoAllow customising pdf-to-text parameters
Lars Ingebrigtsen [Sun, 29 Sep 2019 12:26:26 +0000 (14:26 +0200)]
Allow customising pdf-to-text parameters

* lisp/doc-view.el (doc-view-pdf->txt): Allow customising the
parameters (bug#8519).
(doc-view-pdftotext-program-args): New variable.