Fix pixel scrolling upwards in Info buffers

* lisp/pixel-scroll.el (pixel-point-and-height-at-unseen-line):
Don't blindly trust window start to be the beginning of a
visual line.

Remove unused let-bindings from pixel-scroll.el

* lisp/pixel-scroll.el
(pixel-scroll-precision-scroll-down-page): Remove unused
bindings.

Fix precision scrolling for stretch glyphs

* lisp/pixel-scroll.el
(pixel-scroll-precision-scroll-down-page): Simplify logic.
(pixel-scroll-precision-interpolate): Block throw-on-input
when actually scrolling.

* lisp/time.el (world-clock-mode-map): Convert to defvar-keymap.

; * lisp/Makefile.in: Fix typo.

; * lisp/htmlfontify.el: Remove some commented out code.

Fix logic in 'compute_window_start_on_continuation_line'

* src/xdisp.c (compute_window_start_on_continuation_line): Fix a
thinko in logic.  Patch by dickmao <dick.r.chiang@gmail.com>.
(Bug#52378)

Fix thinko in Tramp test

* test/lisp/net/tramp-tests.el (tramp-test07-abbreviate-file-name):
Fix thinko.

Improve lock-pid handling in Tramp

* lisp/net/tramp-cache.el: Remove comment.

* lisp/net/tramp-gvfs.el (tramp-gvfs-maybe-open-connection):
* lisp/net/tramp-rclone.el (tramp-rclone-maybe-open-connection):
* lisp/net/tramp-sshfs.el (tramp-sshfs-maybe-open-connection):
* lisp/net/tramp-sudoedit.el (tramp-sudoedit-maybe-open-connection):
Do not set "lock-pid" connection-property.
(tramp-sudoedit-handle-delete-file): Use "rm -f".

* lisp/net/tramp.el (tramp-test-message): Extend for buffers w/o
remote default-directory.
(tramp-lock-pid): New defvar.
(tramp-get-lock-pid): Reimplement.

Merge from origin/emacs-28

1821844357 Add missing K key documentation for Cangjie input methods
be860c1385 Fix manual entry of 'quit-restore-window' (Bug#52328)
35a96139df Clarify a comment in xdisp.c
6ba2f028cf Revert "Grep alias `all' shall not match parent directory"
eb9e33e238 ; * etc/NEWS: Non-nil repeat-keep-prefix is not the defaul...
538fc1d0e0 Fix mode-line display in Calendar mode

# Conflicts:
# etc/NEWS
# lisp/help.el

; Merge from origin/emacs-28

The following commit was skipped:

c8c7822c51 * etc/tutorials/TUTORIAL.it (CONCLUSIONI): Reword paragraph.

Add missing K key documentation for Cangjie input methods

* lisp/international/titdic-cnv.el (tsang-quick-converter): Add the
missing K key in input method documentation. (Bug#52264)

Make precision scrolling up work over display strings

* lisp/pixel-scroll.el
(pixel-point-and-height-at-unseen-line): Use
`window-text-pixel-size'.
(pixel-scroll-precision-scroll-up-page): Use delta as vscroll
directly.

Fix pixel scrolling over lines with different sized glyphs

* lisp/pixel-scroll.el
(pixel-scroll-precision-scroll-down-page): Calculate desired
vscroll with `window-text-pixel-size'.

Fix manual entry of 'quit-restore-window' (Bug#52328)

* doc/lispref/windows.texi (Quitting Windows): Fix bug in
description of 'quit-restore-window' (Bug#52328).

Clarify a comment in xdisp.c

* src/xdisp.c (compute_window_start_on_continuation_line): Clarify
a comment.  (Bug#52378)

Fix jumping cursor during interpolated scrolls

* lisp/pixel-scroll.el
(pixel-scroll-precision-scroll-down-page): Go to next position
before setting start or vscroll.

Allow customizing step between each interpolated scroll

* lisp/pixel-scroll.el (pixel-scroll-precision-interpolate):
Use new option.
(pixel-scroll-precision-interpolation-between-scroll): New user
option.

image-dired: Show image info in header line

* lisp/image-dired.el
(image-dired-update-header-line): New function to show image
information in the header line.
(image-dired-display-thumb-properties): Make obsolete.
(image-dired-track-thumbnail)
(image-dired--display-thumb-properties-fun)
(image-dired-forward-image, image-dired-next-line)
(image-dired-previous-line, image-dired-beginning-of-buffer)
(image-dired-end-of-buffer, image-dired-read-comment): Use
image-dired-update-header-line instead of
image-dired-display-thumb-properties.

image-dired: Go to next image when marking

* lisp/image-dired.el
(image-dired-marking-shows-next): New user option to show the next
image after marking, unmarking or flagging an image.
(image-dired--do-mark-command): New macro.
(image-dired-mark-thumb-original-file)
(image-dired-unmark-thumb-original-file)
(image-dired-flag-thumb-original-file)
(image-dired-toggle-mark-thumb-original-file)
(image-dired-unmark-all-marks): Use above new macro.

image-dired: Remove some TODOs

To the extent that these TODOs are relevant or useful, it would be
better to add such features to image-mode directly.
* lisp/image-dired.el: Remove some TODOs.

Revert "Grep alias `all' shall not match parent directory"

This reverts commit 856cd948d1a5a016ad36721246a049d33451902f.

Emacs got better at quoting shell arguments and the original value
works correctly for vc-git-grep. At the same time, the value
introduced on that commit caused a regression on lgrep.

* lisp/progmodes/grep.el (grep-files-aliases): Use previous value for
`all'. Fixes bug#52367

* test/lisp/emacs-lisp/subr-x-tests.el (subr-x-named-let): New test

* test/lisp/emacs-lisp/cl-macs-tests.el: Avoid `with-suppressed-warnings`

* test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs--progv): Use a proper
namespace prefix for the global vars.

lisp/mouse.el: Fix some lambdas quoted with ` or '

Also prefer #' to quote named functions.

* lisp/mouse.el (minor-mode-menu-from-indicator, context-menu-entry)
([C-down-mouse-3]): Don't abuse lambda lists for functions.
(context-menu-mode): Remove redundant `:group`.
(mouse-drag-line): Remove unused var `draggable`.
(mouse-yank-primary): Make it work for non-mouse events.

* lisp/mouse.el (context-menu-entry): Bind to make-sparse-keymap, not ignore.

Then where-is-internal does not run context-menu-map from the :filter,
and no context menu functions are called by e.g. describe-mode in wrong buffer
(bug#9923)

; * etc/NEWS: Non-nil repeat-keep-prefix is not the default anymore.

Define some more keymaps in one step

* lisp/calc/calc-store.el (calc-var-name-map):
* lisp/mail/rmailsum.el (rmail-summary-edit-map):
* lisp/speedbar.el (speedbar-buffers-key-map): Define in one step.
* lisp/progmodes/ebrowse.el (ebrowse-global-submap-4)
(ebrowse-global-submap-5): Define in one step and use defvar-keymap.

; * lisp/calc/calc-ext.el: Fix warnings in my last commit.

Fix mode-line display in Calendar mode

* lisp/help.el (substitute-command-keys): New optional argument
NO-FACE, to avoid putting the 'help-key-binding' face on the key
bindings.
* lisp/calendar/calendar.el (calendar-mode-line-entry): Call
'substitute-command-keys' with the new optional argument non-nil.
(Bug#52366)

* doc/lispref/help.texi (Keys in Documentation): Document the new
optional argument of 'substitute-command-keys'.

* etc/NEWS: Announce the addition of a new argument to
'substitute-command-keys'.

* etc/tutorials/TUTORIAL.it (CONCLUSIONI): Reword paragraph.

Don't merge to master.

Define calc-help-map in one step

* lisp/calc/calc-ext.el (calc-help-map): Define in one step and
convert to defvar-keymap.

Convert shortdoc-mode-map to defvar-keymap

* lisp/emacs-lisp/shortdoc.el (shortdoc-mode-map): Convert to
defvar-keymap.

; Merge from origin/emacs-28

The following commit was skipped:

0a2507ff90 Backport: Make a more robust check in Tramp using scripts

Merge from origin/emacs-28

ce5bca4913 Document native-comp-async-report-warning-errors more
1933cd5307 Doc fix; Epiphany has been renamed to GNOME Web
b80d7568e4 * lisp/dired-aux.el (dired-check-process): Doc fix.  (Bug#...
0f30227f97 ; * lisp/net/browse-url.el (browse-url-epiphany): Fix typo.
d34009db66 Remove dead link from newsticker

# Conflicts:
# lisp/net/browse-url.el

Fix coarse scroll deltas on macOS

* src/nsterm.m (- mouseDown): Multiply deltas as appropriate.

Clear scroll interpolation when interpolated scroll completes

* lisp/pixel-scroll.el (pixel-scroll-precision-interpolate): Set
saved interpolation to nil upon completion.

Improve precision scroll interpolation

* lisp/pixel-scroll.el
(pixel-scroll-precision-interpolation-total-time)
(pixel-scroll-precision-interpolation-factor): Add better
default values.

(pixel-scroll-precision-interpolate): Save deltas and run loop
inside `while-no-input' instead.

; * etc/NEWS: Fix typos.

Backport: Make a more robust check in Tramp using scripts

* lisp/net/tramp-sh.el (tramp-find-inline-encoding):
Check, whether scripts in `tramp-remote-coding-commands' are
expandable.

(cherry picked from commit 1d0a60113fd155c77ef5ea4ea44fcba3504adcbf)

Fix last change

* lisp/pixel-scroll.el
(pixel-scroll-precision-interpolation-total-time)
(pixel-scroll-precision-interpolation-factor): Fix declared versions.

Make interpolated scrolling work better

* lisp/pixel-scroll.el (pixel-scroll-precision-interpolate):
Stop using `while-no-input'.

Allow customizing precision scroll interpolation

* lisp/pixel-scroll.el
(pixel-scroll-precision-interpolation-total-time)
(pixel-scroll-precision-interpolation-factor): New user
options.
(pixel-scroll-precision-interpolate): Use these new options.

(pixel-scroll-precision-mode): Set
`make-cursor-line-fully-visible' to nil.

Send scroll stop events to xwidgets correctly

* src/xterm.c (handle_one_xevent): Record stop events manually.

* src/xwidget.h (xwidget_scroll):
* src/xwidget.c (xwidget_scroll): New parameter `stop_p'.

Convert etc-authors-mode-map to defvar-keymap

* lisp/textmodes/etc-authors-mode.el (etc-authors-mode-map):
Convert to defvar-keymap.

Pacify svg_load_image compiler warning

* src/image.c (svg_load_image): Fix compiler warning from gcc
(Debian 11.2.0-10).

; * lisp/textmodes/texinfo.el: Remove stale comment.

The referenced variable was removed two decades ago.

Check decoding results in webp_load before using it

* src/image.c (webp_load): Check whether we were able to decode
the image before using it.

image-dired: Navigate from image display buffer

* lisp/image-dired.el
(image-dired-mark-thumb-original-file)
(image-dired-unmark-thumb-original-file)
(image-dired-flag-thumb-original-file)
(image-dired-toggle-mark-thumb-original-file)
(image-dired-unmark-all-marks)
(image-dired-display-next-thumbnail-original)
(image-dired-display-previous-thumbnail-original): Make commands
usable from image-dired-display-image-mode.
(image-dired-display-image-mode-map): Bind above commands.
(image-dired--with-thumbnail-buffer): New macro.

Improve yanking in the middle of comint process output

* lisp/comint.el
(comint--unmark-string-as-output): New function to remove unwanted
properties from text yanked from comint buffers.

(comint-mode): Use it as a 'filter-buffer-substring-function'.

(comint-output-filter): Set 'insert-in-front-hooks' text property on
process output such that text yanked by the user in the middle of
process output is marked as process output (Bug#3735).

(comint--mark-as-output): New function.
(comint--mark-yanked-as-output): New function.

browse-url: Refactor code to find executable

* lisp/net/browse-url.el (browse-url--find-executable): Extract from...
(browse-url-firefox-program, browse-url-chrome-program)
(browse-url-chromium-program): ...here.

Document native-comp-async-report-warning-errors more

The docstring has a description of how fix problems in lisp code
detected by native compilation, but not the Emacs Lisp manual, so
document it there as well.

* doc/lispref/compile.texi (Native-Compilation Functions): Refer to
'native-comp-async-report-warning-errors'
(Native-Compilation Variables): Explain potential cause of warnings
from native compilation.

browse-url: Remove support for Galeon

* lisp/net/browse-url.el (browse-url-galeon-program)
(browse-url-galeon-arguments)
(browse-url-galeon-startup-arguments)
(browse-url-galeon-new-window-is-tab, browse-url-galeon)
(browse-url-galeon-sentinel): Delete, thus removing support for the long
defunct Galeon web browser.
* etc/NEWS: Announce its removal.

* etc/tutorials/TUTORIAL.he: Add section about package management.

Doc fix; Epiphany has been renamed to GNOME Web

* lisp/net/browse-url.el: Doc fix; Epiphany is called GNOME Web
since GNOME 3.4, released in 2012.
Ref: https://help.gnome.org/misc/release-notes/3.4/

Improve before-make-frame-hook and after-make-frame-functions docs.

* lisp/frame.el (before-make-frame-hook)
(after-make-frame-functions):
* doc/lispref/frames.texi (Creating Frames): Mention that these
functions will be run for the initial frame only if added to the
hook in early-init file.  (Bug#38143)

* lisp/dired-aux.el (dired-check-process): Doc fix.  (Bug#52337)

; * lisp/net/browse-url.el (browse-url-epiphany): Fix typo.

Remove dead link from newsticker

* lisp/net/newst-backend.el (newsticker--parse-rss-0.91):
* lisp/net/newsticker.el: Remove dead link.

browse-url: Remove support for Netscape

* lisp/net/browse-url.el (browse-url-netscape-program)
(browse-url-netscape-arguments)
(browse-url-netscape-startup-arguments)
(browse-url-netscape-new-window-is-tab)
(browse-url-netscape-version, browse-url-netscape)
(browse-url-netscape-sentinel, browse-url-netscape-reload)
(browse-url-netscape-send): Delete, thus removing support for the long
defunct Netscape web browser.
* etc/NEWS: Announce its removal.

* doc/misc/eshell.texi (Built-ins): Fix xref.

Make a more robust check in Tramp using scripts

* lisp/net/tramp-sh.el (tramp-find-inline-encoding):
Check, whether scripts in `tramp-remote-coding-commands' are
expandable.

Add the new packages section to the Italian tutorial

* etc/tutorials/TUTORIAL.it (INSTALLAZIONE DI ULTERIORI PACCHETTI):
Translate from recently added INSTALLING PACKAGES section in the English
version.  (Bug#52345)
(CONCLUSIONI): Reword paragraph, to better convey the original intent.

Remove some unnecessary references to Emacs 22

* lisp/cedet/semantic/fw.el:
* lisp/emacs-lisp/bytecomp.el (byte-compile-from-buffer):
* lisp/emulation/viper-util.el (viper-frame-value):
* lisp/mail/rmail.el (rmail-delete-headers):
* lisp/mh-e/mh-e.el (mh-inc-spool-list): Remove some unnecessary
references to Emacs 22.

* etc/tutorials/TUTORIAL: Say that there is usually a delete key.

image-dired: Fix behavior of slideshow command

* lisp/image-dired.el (image-dired-slideshow-start): Fix behavior
to match documentation.  Minor simplification of docstring.

Remove obsolete values from image-mode-auto-resize

* lisp/image-mode.el (image-auto-resize): Remove obsolete options
fit-height and fit-width.
(image-transform-resize): Document that fit-height and fit-width
are obsolete.

(image-auto-resize-max-scale-percent): Fix defcustom const :tag.

* lisp/view.el (view-mode-map): Convert to defvar-keymap.

Remove XEmacs compat code from strokes.el

* lisp/strokes.el (strokes-mode): Remove XEmacs compat code;
select-frame-hook does not exist in Emacs.

Add vc-git-stash-pop to vc-dir-git-mode

* lisp/vc/vc-git.el (vc-dir-git-mode-map): Add vc-git-stash-pop
(bug#52158).

Merge from origin/emacs-28

da23e607d3 Select the right buffer for event in context-menu function...

Cancel xwidget progress timer when buffer is killed

* lisp/xwidget.el (xwidget-webkit-buffer-kill): New function.
(xwidget-webkit-mode): Add `xwidget-webkit-buffer-kill' to
`kill-buffer-hook'.  (bug#52344)

When registering Gnus message ids, guard against no registry

* lisp/gnus/gnus-registry.el (gnus-registry-register-message-ids):
There are situations where this code is called without a full Gnus
startup (eg, debbugs). If the registry doesn't exist, just skip this
process.

Silence byte-compiler in two tests

* test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:
* test/lisp/mail/mail-utils-tests.el
(mail-utils-tests-mail-rfc822-time-zone): Silence byte-compiler.

Remove spurious space in byte-compiler warning

* lisp/emacs-lisp/bytecomp.el
(byte-compile-docstring-length-warn): Remove spurious space in
byte-compiler warning.
* test/lisp/emacs-lisp/bytecomp-tests.el
("warn-wide-docstring-defun.el"): Update test.

Assume unfilled byte-compiler warnings in tests

* test/lisp/emacs-lisp/bytecomp-tests.el
(bytecomp--define-warning-file-test): Remove workaround for filled
byte-compilation warnings.  See Bug#52281.

Fix previous shr-parse-style change

* lisp/net/shr.el (shr-parse-style): Fix previous clean-up here
(which wasn't well thought through).

dired.texi: Document dired-create-destination-dirs-on-trailing-dirsep

* doc/emacs/dired.texi (Operating on Files): Document new option
dired-create-destination-dirs-on-trailing-dirsep.

Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

Revert "Avoid small parasitic button on mode line"

This reverts commit c9e901f4a612646be4ce06e1619897edfb073bf0.

Turns out without that "ghost" button min-width doesn't work
on the mode line at all...

Tramp code cleanup

* lisp/net/tramp.el (tramp-get-default-directory)
(tramp-get-buffer-string): New defsubsts.
(tramp-message, tramp-error-with-buffer)
(tramp-file-name-for-operation, tramp-command-completion-p)
(tramp-action-login, tramp-action-yesno, tramp-action-yn)
(tramp-action-terminal, tramp-action-confirm-message)
(tramp-wait-for-regexp, tramp-call-process)
(tramp-call-process-region, tramp-read-passwd):
* lisp/net/tramp-cmds.el (tramp-list-remote-buffers)
(tramp-reporter-dump-variable):
* lisp/net/tramp-gvfs.el (tramp-gvfs-monitor-process-filter):
* lisp/net/tramp-sh.el (tramp-sh-handle-insert-directory)
(tramp-sh-handle-process-file, tramp-sh-handle-write-region)
(tramp-sh-gio-monitor-process-filter):
* lisp/net/tramp-smb.el (tramp-smb-action-set-acl):
* lisp/net/tramp-sudoedit.el
(tramp-sudoedit-handle-file-name-all-completions):
* test/lisp/net/tramp-tests.el (tramp--test-instrument-test-case)
(tramp-test32-shell-command): Use them.

Fix mode-line display on TTY frames

* lisp/bindings.el (mode-line-frame-control): Remove the leading
'-' before '%F' on TTY frames.  It has no real purpose, and looks
ugly nowadays, since it's preceded by a blank, due to the new
min-width feature.

Select the right buffer for event in context-menu functions (bug#9923)

* lisp/mouse.el (context-menu-region):
* lisp/progmodes/prog-mode.el (prog-context-menu):
Switch to the buffer displayed by the window of the event
before using syntax-ppss, char-after.

Avoid small parasitic button on mode line

* lisp/bindings.el (mode-line-position): Remove stray space
character, which caused a "ghost" button on the mode line.
(Bug#52332)

; * etc/tutorials/TUTORIAL.sv: Re-adjust to latest change in TUTORIAL.

; * etc/tutorials/TUTORIAL: Minor wording change in recent addition.

Merge remote-tracking branch 'origin/emacs-28' into trunk

lisp/minibuffer.el: Fix for bug#52169 regression

* lisp/minibuffer.el (completion-table-subvert): Make sure we return
a boundary that's not outside of the limit of the string.

* etc/tutorials/TUTORIAL.sv: Adjust to latest change in TUTORIAL.

; * etc/tutorials/TUTORIAL: Fix typo in last commit.

Add package management to tutorial and startup screen

* etc/tutorials/TUTORIAL: Add section about package installation.
* lisp/startup.el (fancy-startup-tail): Add button for
package-list-packages.

This was discussed in:
https://lists.gnu.org/r/emacs-devel/2021-12/msg00079.html

image.c: Remove some dead code

* src/image.c (gui_put_x_image): Remove dead code, commented out since
2004.

Update org-compat doc string

* lisp/org/org-compat.el (file-attribute-modification-time):
Update doc string to match that of builtin Emacs.

Fix minor clock skew issues

* lisp/midnight.el (clean-buffer-list):
* lisp/progmodes/vhdl-mode.el (vhdl-template-replace-header-keywords):
* lisp/net/rcirc.el (rcirc-connect):
Don’t assume that getting the current time twice in rapid
succession will yield the same date and time.

Avoid timestamp info loss in mh-alias-tstamp

* lisp/mh-e/mh-alias.el (mh-alias-tstamp):
Don’t lose subsecond info when setting mh-alias-tstamp.

Simplify by using format-time-string

* lisp/mail/sendmail.el (mail-do-fcc):
* lisp/net/tramp.el (tramp-debug-message):
Prefer format-time-string to doing time formatting by hand.

Simplify RFC 5322 time zone generation

* lisp/mail/feedmail.el (feedmail-rfc822-time-zone)
(feedmail-rfc822-date, feedmail-default-message-id-generator):
* lisp/mail/mail-utils.el (mail-rfc822-time-zone, mail-rfc822-date):
* lisp/timezone.el (timezone-make-arpa-date):
Simplify by using format-time-string with %z.

* lisp/mail/feedmail.el (feedmail-rfc822-time-zone):
* lisp/mail/mail-utils.el (mail-rfc822-time-zone):
Mark these should-have-been-internal functions obsolete.

Fix image load timekeeping bug

* lisp/image.el (image-animate-timeout): Fix bug that caused the
local variable time-to-load-image to be practically zero, instead
of the time it actually took to load the image.  I think
this bug was introduced in 2013-02-16T03:29:30Z!rgm@gnu.org.

Use time-convert in with-decoded-time-value

* lisp/calendar/time-date.el (with-decoded-time-value):
Prefer time-convert to current-time on the off chance that code
will use this obsolete macro even after current-time returns pairs.

Simplify message-make-expires

* lisp/gnus/message.el (message-make-expires):
Use time-add instead of doing it by hand.  This also calculates the
expiration time more accurately than the old code did.