]> git.eshelyaron.com Git - emacs.git/log
emacs.git
3 years agoImprove detection of suspicious reordering in source code
Eli Zaretskii [Sat, 6 Nov 2021 10:33:26 +0000 (12:33 +0200)]
Improve detection of suspicious reordering in source code

* src/bidi.c (bidi_find_first_overridden): Detect suspiciously
reordered EN types as well.

* test/src/xdisp-tests.el
(xdisp-tests--find-directional-overrides-case-1): Rename from
'xdisp-tests--find-directional-overrides'.
(xdisp-tests--find-directional-overrides-case-2): New test.

3 years ago; * etc/NEWS: Fix a typo.
Eli Zaretskii [Sat, 6 Nov 2021 09:38:08 +0000 (11:38 +0200)]
; * etc/NEWS: Fix a typo.

3 years ago; * etc/NEWS.28: Merge recent changes from emacs-28 branch.
Eli Zaretskii [Sat, 6 Nov 2021 09:23:39 +0000 (11:23 +0200)]
; * etc/NEWS.28: Merge recent changes from emacs-28 branch.

3 years agoMerge from origin/emacs-28
Eli Zaretskii [Sat, 6 Nov 2021 09:21:43 +0000 (11:21 +0200)]
Merge from origin/emacs-28

9bdb1d0 ; * etc/PROBLEMS: Describe a crash in xwidgets due to Bubblew...
550887c ; * etc/PROBLEMS: Rearrange and update the section about cras...
c2e3cd6 Clarify "text area of a window" in the documentation
4e7e78d Improve docstring of kmacro-set-format

3 years ago; Merge from origin/emacs-28
Eli Zaretskii [Sat, 6 Nov 2021 09:21:41 +0000 (11:21 +0200)]
; Merge from origin/emacs-28

The following commit was skipped:

d8c9a9d Revert "* lisp/wid-edit.el (widget-field): Add subtle border ...

3 years agoMerge from origin/emacs-28
Eli Zaretskii [Sat, 6 Nov 2021 09:21:39 +0000 (11:21 +0200)]
Merge from origin/emacs-28

# Conflicts:
# etc/NEWS

3 years ago; Merge from origin/emacs-28
Eli Zaretskii [Sat, 6 Nov 2021 09:21:08 +0000 (11:21 +0200)]
; Merge from origin/emacs-28

The following commits were skipped:

b1885ac ; * etc/NEWS: slightly more careful wording
6ee929c Use current face foreground for SVG icons in customize
82529b9 ; * etc/NEWS: Improve wording of a recently changed entry.
e9c7a49 ; * etc/NEWS: Improve NEWS entry for Image-Dired.
2de7be4 ; * etc/NEWS: Various fixes.

3 years agoMerge from origin/emacs-28
Eli Zaretskii [Sat, 6 Nov 2021 09:21:07 +0000 (11:21 +0200)]
Merge from origin/emacs-28

b5ccad3 * doc/emacs/building.texi (Compilation Mode): Add next-error-...

3 years ago; * etc/PROBLEMS: Describe a crash in xwidgets due to Bubblewrap.
Eli Zaretskii [Sat, 6 Nov 2021 08:49:54 +0000 (10:49 +0200)]
; * etc/PROBLEMS: Describe a crash in xwidgets due to Bubblewrap.

3 years ago; * etc/PROBLEMS: Rearrange and update the section about crashes.
Eli Zaretskii [Sat, 6 Nov 2021 08:45:58 +0000 (10:45 +0200)]
; * etc/PROBLEMS: Rearrange and update the section about crashes.

3 years agoClarify "text area of a window" in the documentation
Eli Zaretskii [Sat, 6 Nov 2021 06:59:09 +0000 (08:59 +0200)]
Clarify "text area of a window" in the documentation

* src/keyboard.c (Fposn_at_x_y): Clarify that the Y coordinate
includes the header-line and the tab-line.  (Bug#51590)

* doc/lispref/windows.texi (Window Sizes, Splitting Windows)
(Textual Scrolling, Coordinates and Windows): Fix/remove improper
or confusing uses of "text area" of a window.

3 years agoInhibit isearching over message-insert-screenshot data
Lars Ingebrigtsen [Sat, 6 Nov 2021 05:26:57 +0000 (06:26 +0100)]
Inhibit isearching over message-insert-screenshot data

* lisp/gnus/message.el (message-insert-screenshot): Inhibit
isearch over the image data.

3 years agoImprove docstring of kmacro-set-format
Stefan Kangas [Sat, 6 Nov 2021 04:37:08 +0000 (05:37 +0100)]
Improve docstring of kmacro-set-format

* lisp/kmacro.el (kmacro-set-format): Improve docstring.
(kmacro-insert-counter, kmacro-display-counter)
(kmacro-set-counter, kmacro-add-counter): Add cross-references
to the info manual.

3 years agoUpdate help-tests after separator line changes
Lars Ingebrigtsen [Sat, 6 Nov 2021 04:22:26 +0000 (05:22 +0100)]
Update help-tests after separator line changes

3 years agoAllow 'insert-image' to inhibit isearches or not
Lars Ingebrigtsen [Sat, 6 Nov 2021 04:18:32 +0000 (05:18 +0100)]
Allow 'insert-image' to inhibit isearches or not

* doc/lispref/display.texi (Showing Images): Mention it.
* lisp/image.el (insert-image): Take an optional parameter to
inhibit isearch of the STRING argument.

3 years agoIntroduce a new 'inhibit-isearch' text property
Lars Ingebrigtsen [Sat, 6 Nov 2021 03:59:05 +0000 (04:59 +0100)]
Introduce a new 'inhibit-isearch' text property

* doc/lispref/text.texi (Special Properties): Mention it.

* lisp/image.el (insert-image): Make `C-s' skip over the image data.
* lisp/isearch.el (isearch--search-skip-inhibited): New function.
(isearch-search-string): Use it.
(isearch--invisible-p): New function.
(isearch-range-invisible): Use it.

3 years agoRe-rename the minibuffer heading
Lars Ingebrigtsen [Sat, 6 Nov 2021 02:58:43 +0000 (03:58 +0100)]
Re-rename the minibuffer heading

* lisp/minibuffer.el: There's more here than completion functions
(bug#49844).

3 years agoCorrect minibuffer.el heading
Lars Ingebrigtsen [Sat, 6 Nov 2021 02:41:11 +0000 (03:41 +0100)]
Correct minibuffer.el heading

* lisp/minibuffer.el: There's more here than completion functions
(bug#49844).

3 years agoUse underline on non-graphical terminals in make-separator-line
Lars Ingebrigtsen [Sat, 6 Nov 2021 02:31:51 +0000 (03:31 +0100)]
Use underline on non-graphical terminals in make-separator-line

* lisp/simple.el (separator-line):
(make-separator-line): Use an underline on terminals (bug#32950).

3 years agoNormalize usage of variable erc-server-reconnecting
F. Jason Park [Sat, 6 Nov 2021 02:15:24 +0000 (03:15 +0100)]
Normalize usage of variable erc-server-reconnecting

* lisp/erc/erc-backend.el (erc-server-reconnecting-p):
Don't consider erc-server-reconnecting when rendering verdict.
(erc-process-sentinel-2): ensure local variable
erc-server-reconnecting is t when timers are scheduled or running and
trying to reconnect, and nil otherwise, including after no retries
remain. Previously, its use and meaning in erc-backend were convoluted
and conflicted with its use in erc-cmd-RECONNECT (bug#50007).

3 years agoDon't send empty lines for implicit targets in ERC
F. Jason Park [Sat, 6 Nov 2021 02:09:43 +0000 (03:09 +0100)]
Don't send empty lines for implicit targets in ERC

* erc.el (erc-send-input-line): Previously, any line typed into a
query or channel buffer without an explicit user-command
handler (meaning most lines), would be sent twice because a trailing
newline (linefeed) would be appended. This has been verified by
checking IRCd server logs. IRCds won't return an error upon receiving
an empty message, but they also won't forward them to channel
subscribers and DM pals.

* erc-tests.el: Add test for erc-process-input-line, which also
indirectly tests erc-send-input-line. It also tests the command
lookup and dispatch facility (bug#50008).

3 years agoRemove messaging in pp-display-expression.
Lars Ingebrigtsen [Sat, 6 Nov 2021 01:20:06 +0000 (02:20 +0100)]
Remove messaging in pp-display-expression.

* lisp/emacs-lisp/pp.el (pp-display-expression): Remove confusing
message -- we don't usually say that we've popped up a new buffer when
we do so.

3 years agoAllow getting verbose results on erts 'C-u C-c C-c'
Lars Ingebrigtsen [Sat, 6 Nov 2021 00:54:25 +0000 (01:54 +0100)]
Allow getting verbose results on erts 'C-u C-c C-c'

* lisp/progmodes/erts-mode.el (erts-run-test): Allow getting a
diff buffer of the differences with `C-u C-c C-c'.

3 years agoImprove behavior of 'electric-pair-mode' in 'cc-mode'
Jim Porter [Sat, 6 Nov 2021 00:21:35 +0000 (01:21 +0100)]
Improve behavior of 'electric-pair-mode' in 'cc-mode'

* lisp/progmodes/cc-mode.el (c-electric-pair-inhibit-predicate):
Inhibit insertion of paired quote in fewer cases.
* test/lisp/electric-tests.el (define-electric-pair-test):
Add 'c-mode' to list of modes to test by default (bug#50538).

This ensures that quotes are paired correctly within comments, allows for
insertion of quote pairs immediately before another quote, and allows
inserting quote pairs within a string (thus splitting the string in two).

3 years agoMake 'C-x v v' on an unregistered file use the most specific backend
Manuel Giraud [Sat, 6 Nov 2021 00:13:49 +0000 (01:13 +0100)]
Make 'C-x v v' on an unregistered file use the most specific backend

* lisp/vc/vc.el (vc-next-action): Mention this.

* lisp/vc/vc.el (vc-backend-for-registration): Choose the most
specific backend (bug#50572).

3 years agoTweak `eww' new-buffer parameters
Lars Ingebrigtsen [Fri, 5 Nov 2021 23:17:18 +0000 (00:17 +0100)]
Tweak `eww' new-buffer parameters

* lisp/net/eww.el (eww): Don't require that the function be called
with 4 to open a new buffer (bug#51613).

3 years agoFix GNUstep build (ns_compute_glyph_string_overhangs)
Daniel Martín [Fri, 5 Nov 2021 22:24:27 +0000 (23:24 +0100)]
Fix GNUstep build (ns_compute_glyph_string_overhangs)

* src/nsterm.m (ns_compute_glyph_string_overhangs): Declare the font
variable so that it's in scope for the GNUstep code.

3 years agoAdd "N.B." abbreviation to checkdoc
Stefan Kangas [Fri, 5 Nov 2021 21:31:42 +0000 (22:31 +0100)]
Add "N.B." abbreviation to checkdoc

* lisp/emacs-lisp/checkdoc.el (checkdoc-in-abbreviation-p): Add
abbreviation "N.B.".

3 years agoDon't hardcode "Commentary" section in checkdoc
Stefan Kangas [Fri, 5 Nov 2021 21:31:17 +0000 (22:31 +0100)]
Don't hardcode "Commentary" section in checkdoc

* lisp/emacs-lisp/checkdoc.el
(checkdoc-commentary-header-string): New defvar.
(checkdoc-file-comments-engine): Insert value of above new
variable instead of hardcoding what is inserted for the
"Commentary" section.

3 years agoUse correct compiler options for building with libwebp
Eli Zaretskii [Fri, 5 Nov 2021 20:20:04 +0000 (22:20 +0200)]
Use correct compiler options for building with libwebp

* src/Makefile.in (WEBP_CFLAGS): Define.
(EMACS_CFLAGS): Use it.  (Bug#51611)

3 years agoImprove `file-has-changed-p'
Michael Albinus [Fri, 5 Nov 2021 19:46:35 +0000 (20:46 +0100)]
Improve `file-has-changed-p'

* doc/lispref/files.texi (File Attributes): Be precise when
filename does not exist in `file-has-changed-p'.

* lisp/files.el (file-has-changed-p): Suppress remote file caches.
Handle the case FILE does not exists.

3 years agorsvg_handle_get_dimensions is deprecated in 2.52.0
Paul Eggert [Fri, 5 Nov 2021 18:51:46 +0000 (11:51 -0700)]
rsvg_handle_get_dimensions is deprecated in 2.52.0

In Bug#44655#32 (2020-11-19) it was reported that
rsvg_handle_get_dimensions was not deprecated.  However, it became
deprecated in librsvg 2.52.0 (2021-09-15), and because of this Emacs
builds with --enable-gcc-warnings fail in Fedora 35 (2025-11-02)
with the diagnostic “‘rsvg_handle_get_dimensions’ is deprecated:
Use 'rsvg_handle_get_intrinsic_size_in_pixels' instead
[-Werror=deprecated-declarations]”.
* src/image.c (rsvg_handle_get_dimensions): Define as a DLL
function only if < librsvg 2.46.0, since it’s not used
in 2.46.0 or later.
(svg_load_image): Use rsvg_handle_get_dimensions only if librsvg <
2.46.0, since it isn’t needed if >= 2.46.0.

3 years agoAllow 'pp' to limit the line widths
Lars Ingebrigtsen [Fri, 5 Nov 2021 14:27:03 +0000 (15:27 +0100)]
Allow 'pp' to limit the line widths

* lisp/emacs-lisp/pp.el (pp-max-width, pp-use-max-width): New user
options (bug#11934).
(pp-to-string): Use it.
(pp--insert-lisp): Tweak whether to use standard-output or not.
(pp--max-width): New function.

3 years ago; Fix documentation of a recent change
Eli Zaretskii [Fri, 5 Nov 2021 13:51:08 +0000 (15:51 +0200)]
; Fix documentation of a recent change

* doc/emacs/misc.texi (emacsclient Options): No need to use @dfn
more than once for the same term.

* etc/NEWS (emacsclient): Don't use passive voice.

3 years ago; Fix doc strings of a recent commit
Eli Zaretskii [Fri, 5 Nov 2021 13:47:00 +0000 (15:47 +0200)]
; Fix doc strings of a recent commit

* lisp/image-dired.el (image-dired-gallery-image-root-url)
(image-dired-gallery-thumb-image-root-url)
(image-dired-gallery-dir): Don't use "path" for file names and
URLs.

3 years agoEnhance 'highlight-confusing-reorderings'
Eli Zaretskii [Fri, 5 Nov 2021 13:40:37 +0000 (15:40 +0200)]
Enhance 'highlight-confusing-reorderings'

* lisp/international/mule-cmds.el (confusingly-reordered): Make
sure the face looks distinct on displays that don't support the
"wavy" underline attribute.
(highlight-confusing-reorderings): Add a tooltip explaining why
the text was highlighted.  Allow to remove the highlighting by
invoking the command with a prefix argument.

3 years agoRevert "* lisp/wid-edit.el (widget-field): Add subtle border to face."
Stefan Kangas [Fri, 5 Nov 2021 07:24:02 +0000 (08:24 +0100)]
Revert "* lisp/wid-edit.el (widget-field): Add subtle border to face."

This reverts commit 8b024a6ff10f7907445ea60c4db8355638616ed1.

This lead to some alignment issues.  (Bug#51550)
Don't merge to master, where we will continue investigating.

3 years agoMatch dummy output even with non-default rl config
Carlos Pita [Thu, 14 Oct 2021 00:09:40 +0000 (21:09 -0300)]
Match dummy output even with non-default rl config

* lisp/progmodes/python.el
(python-shell-completion-native-get-completions): Match dummy output
even when readline is configured in non-default ways.  (Bug#51010)

3 years ago* etc/PROBLEMS: Mention X forwarding slowdowns. (Bug#7092)
Stefan Kangas [Fri, 5 Nov 2021 06:49:39 +0000 (07:49 +0100)]
* etc/PROBLEMS: Mention X forwarding slowdowns.  (Bug#7092)

3 years agoFix (un)compressing directories in Tramp
Tino Calancha [Fri, 5 Nov 2021 03:35:08 +0000 (04:35 +0100)]
Fix (un)compressing directories in Tramp

* lisp/net/tramp-sh.el (tramp-sh-handle-dired-compress-file):
Check whether the file is a directory (bug#50581).

3 years agoFix 'diff-font-lock-prettify' breaking display of outline headers
Matthias Meulien [Fri, 5 Nov 2021 02:50:01 +0000 (03:50 +0100)]
Fix 'diff-font-lock-prettify' breaking display of outline headers

* lisp/vc/diff-mode.el (diff-outline-level): Make hunk headers be
at level 2.
(diff-mode): Use prettified line as outline header.
(diff--outline-level): New function (bug#51016).

* lisp/vc/vc.el (vc-diff-internal): Fix diff mode being set before
content inserted (bug#51016).

3 years agoFix buffer overflow in ns_compute_glyph_string_overhangs
Daniel Martín [Sat, 9 Oct 2021 19:10:20 +0000 (21:10 +0200)]
Fix buffer overflow in ns_compute_glyph_string_overhangs

* src/nsterm.m (ns_compute_glyph_string_overhangs): When the first
glyph of a glyph string is a composite glyph, `s->nchars' is 0, so
"s->char2b + s->nchars - 1" dereferenced a position before buffer
`s->char2b'.  Instead, rewrite part of the function to distinguish
between character glyphs and composite glyphs.  For character glyphs,
calculate the font metrics using the `text_extents' function, passing
it the entire glyph string; for composite glyphs, call
`composition_gstring_width'. (Bug#51105)

3 years ago; * doc/man/emacsclient.1: Bump date after last change.
Stefan Kangas [Fri, 5 Nov 2021 00:10:32 +0000 (01:10 +0100)]
; * doc/man/emacsclient.1: Bump date after last change.

3 years agoimage-dired: Delete commented out code
Stefan Kangas [Fri, 5 Nov 2021 00:06:38 +0000 (01:06 +0100)]
image-dired: Delete commented out code

* lisp/image-dired.el: Delete broken and commented out speedbar code;
it is not clear what, if anything, it is supposed to do.  If anyone
wants to work on this, they are better off starting from scratch.

3 years agoimage-dired: New defgroup and section for gallery support
Stefan Kangas [Thu, 4 Nov 2021 23:47:00 +0000 (00:47 +0100)]
image-dired: New defgroup and section for gallery support

* lisp/image-dired.el: Add new section header "Gallery support" to
improve file organization.  Move relevant TODO:s there.

(image-dired-gallery): New defgroup.
(image-dired-gallery-dir, image-dired-gallery-image-root-url)
(image-dired-gallery-thumb-image-root-url)
(image-dired-gallery-hidden-tags): Add options to above new defgroup.

(image-dired-add-to-file-comment-list)
(image-dired-create-gallery-lists)
(image-dired-add-to-tag-file-lists, image-dired-hidden-p): Rename to...
(image-dired--add-to-file-comment-list)
(image-dired--create-gallery-lists)
(image-dired--add-to-tag-file-lists, image-dired--hidden-p):
...this, to make it more clear that these functions are internal.
Make the old names obsolete function aliases.
(image-dired-add-to-tag-file-list): Make unused function obsolete.

3 years agoNew emacsclient option to either create or reuse an existing frame.
Gregory Heytings [Thu, 4 Nov 2021 23:14:30 +0000 (00:14 +0100)]
New emacsclient option to either create or reuse an existing frame.

* doc/emacs/misc.texi (emacsclient Options): Document the new option.

* doc/man/emacsclient.1: Mention the new option (bug#51374).
* etc/NEWS: Mention the new option.

* lib-src/emacsclient.c (reuse_frame): New variable.
(longopts): New option.
(decode_options): Decode the new option.
(print_help_and_exit): Document the new option.
(main): Use the new option.

3 years agoTry harder to keep lines short in pp-emacs-lisp-code
Lars Ingebrigtsen [Thu, 4 Nov 2021 22:32:51 +0000 (23:32 +0100)]
Try harder to keep lines short in pp-emacs-lisp-code

* lisp/emacs-lisp/pp.el (pp--insert): Try harder to keep lines short.

3 years agoTweak multi-line expressions in pp--format-function
Lars Ingebrigtsen [Thu, 4 Nov 2021 22:16:47 +0000 (23:16 +0100)]
Tweak multi-line expressions in pp--format-function

* lisp/emacs-lisp/pp.el (pp--format-function): Fix up multi-line
expressions.

3 years agoFix up some list folding in pp-emacs-lisp-code
Lars Ingebrigtsen [Thu, 4 Nov 2021 21:31:15 +0000 (22:31 +0100)]
Fix up some list folding in pp-emacs-lisp-code

* lisp/emacs-lisp/pp.el (pp--insert-lisp, pp--format-list)
(pp--insert): Touch up list folding.

3 years agoIndent lambdas/closures better
Lars Ingebrigtsen [Thu, 4 Nov 2021 21:07:48 +0000 (22:07 +0100)]
Indent lambdas/closures better

* lisp/emacs-lisp/pp.el (pp--format-function): Indent lambdas and
closures better.

3 years agoMake lambda/closure help buttons format as Emacs Lisp
Lars Ingebrigtsen [Thu, 4 Nov 2021 20:52:56 +0000 (21:52 +0100)]
Make lambda/closure help buttons format as Emacs Lisp

* lisp/help.el (help--describe-command): Format lambda/closures as
Emacs Lisp.

* lisp/emacs-lisp/pp.el (pp-display-expression): Allow formatting
as Emacs Lisp.

3 years agoAdd new basic Emacs Lisp code formatting function
Lars Ingebrigtsen [Thu, 4 Nov 2021 20:44:46 +0000 (21:44 +0100)]
Add new basic Emacs Lisp code formatting function

* lisp/emacs-lisp/pp.el (pp-emacs-lisp-code): New interface function.
(pp): Mention it.
(pp--insert-lisp, pp--format-vector, pp--format-list)
(pp--format-function, pp--format-definition, pp--insert-binding)
(pp--insert, pp--indent-buffer): New helper functions.

3 years ago; Comment on the code in a recent commit
Eli Zaretskii [Thu, 4 Nov 2021 19:46:07 +0000 (21:46 +0200)]
; Comment on the code in a recent commit

* lisp/international/mule-cmds.el
(highlight-confusing-reorderings): Comment on the strategy of
highlighting suspicious text.

3 years ago* lisp/custom.el (defgroup): Document the :prefix keyword.
Stefan Kangas [Thu, 4 Nov 2021 19:20:07 +0000 (20:20 +0100)]
* lisp/custom.el (defgroup): Document the :prefix keyword.

3 years agoFix allout point movement problem
Stephen Berman [Thu, 4 Nov 2021 18:39:01 +0000 (19:39 +0100)]
Fix allout point movement problem

* lisp/allout.el (allout-next-visible-heading): Ensure that we
move to the next physical line (bug#51530).

3 years ago; Fix typo
Stefan Kangas [Thu, 4 Nov 2021 18:05:44 +0000 (19:05 +0100)]
; Fix typo

* lisp/image-dired.el (image-dired-display-current-image-full):
Fix typo.

3 years agoBetter detection of potentially malicious bidi text
Eli Zaretskii [Thu, 4 Nov 2021 18:33:26 +0000 (20:33 +0200)]
Better detection of potentially malicious bidi text

* src/bidi.c (bidi_find_first_overridden): Extend to detect more
subtle effects of directional formatting controls, to include
embeddings and isolates.
* src/xdisp.c (Fbidi_find_overridden_directionality): Accept an
additional argument BASE-DIR to specify the base direction of the
paragraphs.

* lisp/international/mule-cmds.el (confusingly-reordered): New
face.
(reorder-starters, reorder-enders): New variables.
(highlight-confusing-reorderings): New command to detect and
highlight suspiciously reordered text.

* test/src/xdisp-tests.el
(xdisp-tests--find-directional-overrides): New test.

* etc/NEWS: Announce the new and improved features.
* etc/tutorials/TUTORIAL.he: Fix embeddings with incorrect
directions.

3 years agofont-lock-type-face doc string improvement
Lars Ingebrigtsen [Thu, 4 Nov 2021 18:28:06 +0000 (19:28 +0100)]
font-lock-type-face doc string improvement

* lisp/font-lock.el (font-lock-type-face): Fix grammar in doc
string (bug#51574).

3 years agoImprove defface error message
Lars Ingebrigtsen [Thu, 4 Nov 2021 18:23:07 +0000 (19:23 +0100)]
Improve defface error message

* lisp/cus-face.el (custom-declare-face): Improve the error
message when there's a missing doc string (bug#51576).

3 years agoDocument ibuffer-auto-mode in ibuffer-mode doc string
Thibault Polge [Thu, 4 Nov 2021 18:08:30 +0000 (19:08 +0100)]
Document ibuffer-auto-mode in ibuffer-mode doc string

* lisp/ibuffer.el (ibuffer-mode): Mention ibuffer-auto-mode in the
ibuffer-mode doc string (bug#51584).

3 years agoDon't have `M-x term' call `term-mode' twice
Lars Ingebrigtsen [Thu, 4 Nov 2021 18:02:23 +0000 (19:02 +0100)]
Don't have `M-x term' call `term-mode' twice

* lisp/term.el (term): Don't call `term-mode' twice (bug#51589).

3 years agoDocument that `unspecified' isn't valid in defface
Lars Ingebrigtsen [Thu, 4 Nov 2021 17:58:21 +0000 (18:58 +0100)]
Document that `unspecified' isn't valid in defface

* doc/lispref/display.texi (Face Attributes): Mention that
unspecified isn't valid in defface (bug#51595).

3 years agoReset mailcap entries only when mailcap files are read again
Gregory Heytings [Thu, 4 Nov 2021 17:48:35 +0000 (18:48 +0100)]
Reset mailcap entries only when mailcap files are read again

* lisp/net/mailcap.el (mailcap-parse-mailcaps): Move the clear and
load defaults operations at their appropriate place.  Fixes bug#51600.

3 years agoFix return value of python-nav-end-of-defun
Lars Ingebrigtsen [Thu, 4 Nov 2021 17:47:04 +0000 (18:47 +0100)]
Fix return value of python-nav-end-of-defun

* lisp/progmodes/python.el (python-nav-end-of-defun): Return
non-nil if in a def/class, as the doc string implies (bug#51601).

3 years ago* doc/emacs/frames.texi (Tab Bars): Reorder toggle-frame-tab-bar.
Juri Linkov [Thu, 4 Nov 2021 17:33:31 +0000 (19:33 +0200)]
* doc/emacs/frames.texi (Tab Bars): Reorder toggle-frame-tab-bar.

3 years agoRename button-buttonize to buttonize
Lars Ingebrigtsen [Thu, 4 Nov 2021 17:14:23 +0000 (18:14 +0100)]
Rename button-buttonize to buttonize

* lisp/help.el (help--describe-command):
* lisp/emacs-lisp/memory-report.el (memory-report--buffers):
* lisp/button.el (button-buttonize):
* doc/lispref/display.texi (Making Buttons): Rename
button-buttonize to just buttonize and adjust callers.

3 years agoRevert "* lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete."
Mattias Engdegård [Thu, 4 Nov 2021 09:14:15 +0000 (10:14 +0100)]
Revert "* lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete."

This reverts commit f56408a6f0152cd46d1ea8a0985fbfeeb839ea06.

As commented by Dmitry Gutov in [1], obsoleting `xref-pop-marker-stack`
makes sense.

[1] https://lists.gnu.org/archive/html/emacs-devel/2021-10/msg01870.html

3 years ago; * etc/NEWS: slightly more careful wording
Mattias Engdegård [Thu, 4 Nov 2021 08:57:18 +0000 (09:57 +0100)]
; * etc/NEWS: slightly more careful wording

3 years agoUse current face foreground for SVG icons in customize
Stefan Kangas [Tue, 2 Nov 2021 19:14:13 +0000 (20:14 +0100)]
Use current face foreground for SVG icons in customize

It turns out these few icons were missed when the color and size
information was removed from the SVG icons that replaced XPM icons for
Customize buffer.
* etc/images/down.svg:
* etc/images/left.svg:
* etc/images/right.svg:
* etc/images/up.svg: Don't define foreground; this means they will use
the foreground of the currently defined face instead.  (Bug#51556)

(cherry picked from commit 11702a6dd7cb8286f28b7cb986057d2d2c66a914)

3 years ago; * etc/NEWS: Improve wording of a recently changed entry.
Eli Zaretskii [Thu, 4 Nov 2021 08:04:04 +0000 (10:04 +0200)]
; * etc/NEWS: Improve wording of a recently changed entry.

3 years agoAdd a Gnus command to emojize symbols
Lars Ingebrigtsen [Thu, 4 Nov 2021 05:38:22 +0000 (06:38 +0100)]
Add a Gnus command to emojize symbols

* doc/misc/gnus.texi (Article Display): Document it.

* lisp/gnus/gnus-art.el (gnus-treat-emojize-symbols): New user option.
(gnus-treatment-function-alist): Map.
(article-emojize-symbols): New command and keystroke.

3 years agoAdd new user option mml-attach-file-at-the-end
Lars Ingebrigtsen [Thu, 4 Nov 2021 05:09:08 +0000 (06:09 +0100)]
Add new user option mml-attach-file-at-the-end

* lisp/gnus/mml.el (mml-attach-file-at-the-end): New user option.
(mml-attach-file): Use it.

3 years agoimage-dired: Set default-directory in thumbnail buffer
Stefan Kangas [Thu, 4 Nov 2021 04:10:28 +0000 (05:10 +0100)]
image-dired: Set default-directory in thumbnail buffer

* lisp/image-dired.el (image-dired-show-all-from-dir): Set
default-directory.  This fixes e.g. 'dired-jump'.

3 years agoMake image-dired-display-image-mode inherit from image-mode
Stefan Kangas [Thu, 4 Nov 2021 01:05:29 +0000 (02:05 +0100)]
Make image-dired-display-image-mode inherit from image-mode

* lisp/image-dired.el (image-dired-display-image-mode):
Inherit from 'image-mode'.  (Bug#10758)
(image-dired-display-image): Don't generate a temporary image, which
is no longer needed with the above change.
(image-dired-display-thumbnail-original-image)
(image-dired-dired-display-image)
(image-dired-mouse-display-image): Simplify.

(image-dired-temp-image-file)
(image-dired-cmd-create-temp-image-program)
(image-dired-cmd-create-temp-image-options)
(image-dired-display-window-width-correction)
(image-dired-display-window-height-correction)
(image-dired-display-window-width)
(image-dired-display-window-height)
(image-dired-display-current-image-full)
(image-dired-display-current-image-sized)
(image-dired-window-height-pixels): Make obsolete.
(image-dired-create-display-image-buffer): Make into obsolete
function alias for 'ignore'.
(image-dired-display-image-mode-map): Simplify by removing things
duplicated from `image-mode-map'.  Disable some commands from
`image-mode-map' that doesn't make sense for Image-Dired.
(image-dired-display-image-mode-menu): Remove menu, as it no longer
contains anything useful.
(image-dired-minor-mode):
* doc/emacs/dired.texi (Image-Dired): Update documentation for the
above change.

3 years ago; * lisp/image-dired.el: Remove redundant :group args.
Stefan Kangas [Wed, 3 Nov 2021 22:25:23 +0000 (23:25 +0100)]
; * lisp/image-dired.el: Remove redundant :group args.

3 years agoImprove theming of image-dired-thumb-mark
Stefan Kangas [Wed, 3 Nov 2021 22:23:02 +0000 (23:23 +0100)]
Improve theming of image-dired-thumb-mark

* etc/themes/adwaita-theme.el (adwaita):
* etc/themes/deeper-blue-theme.el (deeper-blue):
* etc/themes/dichromacy-theme.el (dichromacy):
* etc/themes/leuven-theme.el (leuven):
* etc/themes/manoj-dark-theme.el (manoj-dark):
* etc/themes/whiteboard-theme.el (whiteboard): Add definitions for
the 'image-dired-thumb-flagged' face.

3 years ago; * etc/NEWS: Improve NEWS entry for Image-Dired.
Stefan Kangas [Wed, 3 Nov 2021 21:50:56 +0000 (22:50 +0100)]
; * etc/NEWS: Improve NEWS entry for Image-Dired.

3 years agoimage-dired: Add face for flagged files
Stefan Kangas [Wed, 3 Nov 2021 21:34:51 +0000 (22:34 +0100)]
image-dired: Add face for flagged files

* lisp/image-dired.el (image-dired-thumb-mark): New defface.
(image-dired-thumb-update-marks): Mark flagged file with above new defface.
(image-dired-dired-file-marked-p)
(image-dired-thumb-file-marked-p): Add optional argument to be
used by 'image-dired-*-flagged-p' functions below.
(image-dired-dired-file-flagged-p)
(image-dired-thumb-file-flagged-p): New defuns.
(image-dired-thumb-mark): Improve definition with color classes.
(image-dired-thumb-visible-marks): Doc fix.

3 years agoFix declaration syntax of 'image-dired--on-file-in-dired-buffer'.
Philipp Stephani [Wed, 3 Nov 2021 20:48:13 +0000 (21:48 +0100)]
Fix declaration syntax of 'image-dired--on-file-in-dired-buffer'.

* lisp/image-dired.el (image-dired--on-file-in-dired-buffer): Fix
declaration syntax.

3 years agoFix encoding issues in gitmerge.el, make it work on MS-Windows
Eli Zaretskii [Wed, 3 Nov 2021 18:50:34 +0000 (20:50 +0200)]
Fix encoding issues in gitmerge.el, make it work on MS-Windows

* admin/gitmerge.el (gitmerge-emacs-version, gitmerge-show-log)
(gitmerge-show-diff, gitmerge-show-files, gitmerge-missing)
(gitmerge-setup-log-buffer, gitmerge-resolve)
(gitmerge-commit-message, gitmerge-apply)
(gitmerge-resolve-unmerged, gitmerge-repo-clean)
(gitmerge-commit): Bind coding-system-for-read/write to the
appropriate vc-git values.
(gitmerge-apply) [windows-nt]: Pass long merge log messages via a
temporary file.
(gitmerge): Clarify the description of the "R" flag.

3 years ago; * etc/NEWS: Various fixes.
Juri Linkov [Wed, 3 Nov 2021 18:38:39 +0000 (20:38 +0200)]
; * etc/NEWS: Various fixes.

Mark with +++ entries documented in the manual.
Move 'lossage-size' closer to 'view-lossage'.

3 years ago* doc/emacs/building.texi (Compilation Mode): Add next-error-message-highlight
Juri Linkov [Wed, 3 Nov 2021 18:34:04 +0000 (20:34 +0200)]
* doc/emacs/building.texi (Compilation Mode): Add next-error-message-highlight

The variable 'next-error-message-highlight' already has vindex,
so describe it in the text as well (bug#51444).

3 years agoMerge from origin/emacs-28
Eli Zaretskii [Wed, 3 Nov 2021 18:26:28 +0000 (20:26 +0200)]
Merge from origin/emacs-28

3e4eb54 ; * etc/PROBLEMS: Minor copyedits of the last change.  (Bug#5...
35bc211 Document a macOS error message when opening Emacs
4df9998 Fix header-line and tab-line when mode-line-compact is set
81915a9 Add manual section about how to avoid regexp problems
a16e66c Clarify build environment
6ab6b2f Clarify build directory structure
9d61620 * src/pdumper.c (dump_do_dump_relocation): Add sanity check.

3 years ago; * etc/PROBLEMS: Minor copyedits of the last change. (Bug#51571)
Eli Zaretskii [Wed, 3 Nov 2021 18:23:58 +0000 (20:23 +0200)]
; * etc/PROBLEMS: Minor copyedits of the last change.  (Bug#51571)

3 years agoDocument a macOS error message when opening Emacs
Daniel Martín [Tue, 2 Nov 2021 18:45:18 +0000 (19:45 +0100)]
Document a macOS error message when opening Emacs

* etc/PROBLEMS: Document a potential error message when opening Emacs
on macOS for the first time.

3 years agoFix widgets in Outline mode on TTY frames
Eli Zaretskii [Wed, 3 Nov 2021 18:13:04 +0000 (20:13 +0200)]
Fix widgets in Outline mode on TTY frames

* lisp/outline.el (outline--valid-emoji-p): Don't try to probe
support for display of Emoji characters on TTY frames.  (Bug#51578)

3 years agoMerge branch 'master' of git.savannah.gnu.org:/srv/git/emacs
Eli Zaretskii [Wed, 3 Nov 2021 14:14:28 +0000 (16:14 +0200)]
Merge branch 'master' of git.savannah.gnu.org:/srv/git/emacs

3 years agoA better fix for bug#51583
Eli Zaretskii [Wed, 3 Nov 2021 14:13:32 +0000 (16:13 +0200)]
A better fix for bug#51583

* src/w32.c (w32_get_resource): Move from here...
* src/w32fns.c (w32_get_resource): ...to here.
(w32_applytheme): No longer a no-op for Cygwin w32 builds.
(globals_of_w32fns): Do attempt to load dwmapi.dll and uxtheme.dll
in the Cygwin w32 build.

3 years ago; cperl-mode.el: Fix one match-count in my commit 2021-09-14
Harald Jörg [Wed, 3 Nov 2021 14:04:10 +0000 (15:04 +0100)]
; cperl-mode.el: Fix one match-count in my commit 2021-09-14

* lisp/progmodes/cperl-mode.el (cperl-init-faces): Matching group needs
to be adjusted according to the regexp change in my previous commit

3 years agoFix the Cygwin w32 build broken by adding the dark theme support
Eli Zaretskii [Wed, 3 Nov 2021 14:02:15 +0000 (16:02 +0200)]
Fix the Cygwin w32 build broken by adding the dark theme support

* src/w32fns.c (w32_applytheme): Make a no-op for Cygwin w32
builds.
(globals_of_w32fns): Don't attempt to load dwmapi.dll and
uxtheme.dll in the Cygwin w32 build.  (Bug#51583)

3 years agoFix header-line and tab-line when mode-line-compact is set
Eli Zaretskii [Wed, 3 Nov 2021 12:57:51 +0000 (14:57 +0200)]
Fix header-line and tab-line when mode-line-compact is set

* src/xdisp.c (display_mode_line): Make 'mode-line-compact' apply
only to mode lines.  (Bug#51558)

3 years agoAdd manual section about how to avoid regexp problems
Mattias Engdegård [Wed, 3 Nov 2021 12:42:25 +0000 (13:42 +0100)]
Add manual section about how to avoid regexp problems

Help users affected by our NFA engine's stack overflows and occasional
poor performance, replacing old text that was more limited in scope.

* doc/lispref/elisp.texi (Top):
* doc/lispref/searching.texi (Regular Expressions): Add menu entries.
(Regexp Problems): New node.
(Regexp Special):
* etc/PROBLEMS: Remove superseded text.

3 years agoClarify build environment
Phillip Lord [Wed, 3 Nov 2021 11:03:00 +0000 (11:03 +0000)]
Clarify build environment

* admin/nt/dist-build/README-scripts:

3 years agoClarify build directory structure
Phillip Lord [Wed, 3 Nov 2021 10:30:02 +0000 (10:30 +0000)]
Clarify build directory structure

* admin/nt/dist-build/README-scripts: Clarify build directory structure

3 years agoImprove theming of image-dired-thumb-mark
Stefan Kangas [Wed, 3 Nov 2021 07:21:26 +0000 (08:21 +0100)]
Improve theming of image-dired-thumb-mark

* etc/themes/adwaita-theme.el (adwaita):
* etc/themes/deeper-blue-theme.el (deeper-blue):
* etc/themes/dichromacy-theme.el (dichromacy):
* etc/themes/leuven-theme.el (leuven):
* etc/themes/manoj-dark-theme.el (manoj-dark):
* etc/themes/whiteboard-theme.el (whiteboard): Add definitions for
the 'image-dired-thumb-mark' face.

3 years ago* src/image.c: Fix building with giflib 4.
YAMAMOTO Mitsuharu [Wed, 3 Nov 2021 07:16:28 +0000 (16:16 +0900)]
* src/image.c: Fix building with giflib 4.

3 years agoimage-dired: Improve marking behavior
Stefan Kangas [Wed, 3 Nov 2021 06:14:21 +0000 (07:14 +0100)]
image-dired: Improve marking behavior

* lisp/image-dired.el (image-dired-thumb-mark): Use DarkOrange as
background to better match the 'dired-marked' face.
(image-dired-show-all-from-dir): Disable all marks when entering a
full directory.
(image-dired-unmark-all-marks): Add mode tag.
(image-dired-thumbnail-mode-map): Bind 'image-dired-unmark-all-marks'
to "U".

3 years agoimage-dired: Cleanup of four commands
Stefan Kangas [Wed, 3 Nov 2021 06:02:13 +0000 (07:02 +0100)]
image-dired: Cleanup of four commands

* lisp/image-dired.el
(image-dired--on-file-in-dired-buffer): New macro.
(image-dired-mark-thumb-original-file)
(image-dired-unmark-thumb-original-file)
(image-dired-flag-thumb-original-file)
(image-dired-toggle-mark-thumb-original-file): Rewrite using
above new macro.
(image-dired-modify-mark-on-thumb-original-file): Make obsolete in
favor of above new macro.

3 years agoimage-dired: Support wrap-around in display-next-thumbnail-original
Stefan Kangas [Wed, 3 Nov 2021 02:34:28 +0000 (03:34 +0100)]
image-dired: Support wrap-around in display-next-thumbnail-original

* lisp/image-dired.el (image-dired-forward-image): Support negative
prefix argument.  Optionally wrap-around, which means to continue from
first image after reaching the last one and vice versa.
(image-dired-backward-image): Reimplement in terms of
'image-dired-forward-image'.
(image-dired-display-next-thumbnail-original)
(image-dired-display-previous-thumbnail-original): Wrap around; when
reaching the last image, continue from the first one.  Add optional
prefix argument to move more than one image at a time.

3 years agoimage-dired: Improve menus
Stefan Kangas [Wed, 3 Nov 2021 02:00:23 +0000 (03:00 +0100)]
image-dired: Improve menus

* lisp/image-dired.el (image-dired-toggle-append-browsing)
(image-dired-toggle-movement-tracking): Improve messages.
(image-dired-thumbnail-mode-menu, image-dired-minor-mode-menu):
Make toggle entries into checkboxes.  Add separators.  Remove
obsoleted commands accidentally added back in merge.