]> git.eshelyaron.com Git - emacs.git/log
emacs.git
3 years agoSimplify RFC 5322 time zone generation
Paul Eggert [Mon, 6 Dec 2021 06:43:55 +0000 (22:43 -0800)]
Simplify RFC 5322 time zone generation

* lisp/mail/feedmail.el (feedmail-rfc822-time-zone)
(feedmail-rfc822-date, feedmail-default-message-id-generator):
* lisp/mail/mail-utils.el (mail-rfc822-time-zone, mail-rfc822-date):
* lisp/timezone.el (timezone-make-arpa-date):
Simplify by using format-time-string with %z.

* lisp/mail/feedmail.el (feedmail-rfc822-time-zone):
* lisp/mail/mail-utils.el (mail-rfc822-time-zone):
Mark these should-have-been-internal functions obsolete.

3 years agoFix image load timekeeping bug
Paul Eggert [Mon, 6 Dec 2021 03:30:27 +0000 (19:30 -0800)]
Fix image load timekeeping bug

* lisp/image.el (image-animate-timeout): Fix bug that caused the
local variable time-to-load-image to be practically zero, instead
of the time it actually took to load the image.  I think
this bug was introduced in 2013-02-16T03:29:30Z!rgm@gnu.org.

3 years agoUse time-convert in with-decoded-time-value
Paul Eggert [Mon, 6 Dec 2021 03:11:59 +0000 (19:11 -0800)]
Use time-convert in with-decoded-time-value

* lisp/calendar/time-date.el (with-decoded-time-value):
Prefer time-convert to current-time on the off chance that code
will use this obsolete macro even after current-time returns pairs.

3 years agoSimplify message-make-expires
Paul Eggert [Mon, 6 Dec 2021 02:39:28 +0000 (18:39 -0800)]
Simplify message-make-expires

* lisp/gnus/message.el (message-make-expires):
Use time-add instead of doing it by hand.  This also calculates the
expiration time more accurately than the old code did.

3 years agoSimplify message-unique-id etc.
Paul Eggert [Mon, 6 Dec 2021 02:35:27 +0000 (18:35 -0800)]
Simplify message-unique-id etc.

* lisp/gnus/message.el (message-unique-id):
* lisp/net/sasl.el (sasl-unique-id-function):
Avoid unnecessary consing and reliance on internal timestamp
format by using (time-convert nil 'integer) which typically does
no consing, instead of using (current-time) and then ignoring
the subsecond parts of the generated list.

3 years agoPrefer nil to (current-time) when either will do
Paul Eggert [Mon, 6 Dec 2021 02:25:46 +0000 (18:25 -0800)]
Prefer nil to (current-time) when either will do

* lisp/emacs-lisp/timer.el (timer-event-handler, run-at-time):
* lisp/gnus/gnus-score.el (gnus-score-date):
* lisp/gnus/gnus-search.el (gnus-search-query-parse-date)
(gnus-search-imap-handle-date):
* lisp/gnus/gnus-sum.el (gnus-user-date)
(gnus-summary-create-article):
* lisp/image-dired.el (image-dired-create-thumb-1):
* lisp/image/gravatar.el (gravatar-retrieve)
(gravatar--prune-cache):
* lisp/net/dbus.el (dbus-monitor-handler):
* lisp/net/tramp-gvfs.el (tramp-gvfs-handle-set-file-times):
* lisp/net/tramp-sh.el (tramp-sh-handle-set-file-times):
* lisp/net/tramp-sudoedit.el (tramp-sudoedit-handle-set-file-times):
* test/lisp/autorevert-tests.el (auto-revert--wait-for-revert)
(auto-revert-tests--write-file, auto-revert-test--wait-for):
* test/lisp/net/tramp-tests.el (tramp--test-print-duration):
Prefer nil to (current-time) when either will do, as this avoids
some consing.  Similarly, prefer omitting (current-time) arg
when this is equivalent.

3 years agoSimplify cedet-utest-elapsed-time
Paul Eggert [Mon, 6 Dec 2021 01:58:11 +0000 (17:58 -0800)]
Simplify cedet-utest-elapsed-time

* test/manual/cedet/cedet-utests.el (cedet-utest-elapsed-time):
Copy newer (circa-2011) implementation from elp.el, so that the
code matches its documentation again.

3 years agoUse time-equal-p to compare timestamps in tests
Paul Eggert [Mon, 6 Dec 2021 01:44:02 +0000 (17:44 -0800)]
Use time-equal-p to compare timestamps in tests

* test/lisp/calendar/time-date-tests.el (test-days-to-time)
(test-time-since): Use time-equal-p to compare timestamps,
since the default form shouldn’t matter.

3 years agoAdd time-convert tests
Paul Eggert [Mon, 6 Dec 2021 01:38:58 +0000 (17:38 -0800)]
Add time-convert tests

* test/src/timefns-tests.el (time-convert-forms): New test.

3 years agoAdded dired-create-destination-dirs-on-trailing-dirsep
NightMachinary [Tue, 9 Nov 2021 12:49:45 +0000 (16:19 +0330)]
Added dired-create-destination-dirs-on-trailing-dirsep

* lisp/dired-aux.el
(dired-create-destination-dirs-on-trailing-dirsep): New customization
option.
(dired-do-create-files): Use it.
(dired-create-destination-dirs): Mention the new option in the
docstring.

3 years agoMerge from origin/emacs-28
Stefan Kangas [Mon, 6 Dec 2021 05:47:44 +0000 (06:47 +0100)]
Merge from origin/emacs-28

e3427faf55 Fix typos and improve consistency in ERC manual
0bf10d5082 * test/Makefile.in (check-declare): Add missing --batch.
34f5656137 Document the subtleties of the 'cursor' text property

3 years agoMake the Git stash commands available in vc-dir Git buffers
Lars Ingebrigtsen [Mon, 6 Dec 2021 05:41:25 +0000 (06:41 +0100)]
Make the Git stash commands available in vc-dir Git buffers

* lisp/vc/vc-dir.el (vc-dir): Call the backend-specific minor mode
if it exists.
* lisp/vc/vc-git.el (vc-dir-git-mode-map): New map.
(vc-dir-git-mode): New minor mode.

3 years agoMake gnus-check-backend-function mode `debug-on-signal' friendly
Lars Ingebrigtsen [Mon, 6 Dec 2021 03:29:43 +0000 (04:29 +0100)]
Make gnus-check-backend-function mode `debug-on-signal' friendly

* lisp/gnus/gnus.el (gnus-check-backend-function): Allow running
with `debug-on-signal'.

3 years ago; Small doc fix in recent eieio-opt.el change
Stefan Kangas [Mon, 6 Dec 2021 02:18:34 +0000 (03:18 +0100)]
; Small doc fix in recent eieio-opt.el change

* lisp/emacs-lisp/eieio-opt.el (eieio-help-constructor): Quote
functions to make links work in help-mode.

3 years agoEIEIO: Remove redundant type info in help
Stefan Monnier [Mon, 6 Dec 2021 02:07:58 +0000 (21:07 -0500)]
EIEIO: Remove redundant type info in help

`C-h o` returned redundant info when used on EIEIO classes, listing
the same thing both for the type name and for the constructor name.

* lisp/emacs-lisp/eieio.el (help-fns-describe-function-functions):
Remove special case for defclass constructors.
* lisp/emacs-lisp/eieio-opt.el (eieio-help-constructor): Declare it obsolete.

3 years agoimage-dired: Use string-match-p in one case
Stefan Kangas [Mon, 6 Dec 2021 01:53:31 +0000 (02:53 +0100)]
image-dired: Use string-match-p in one case

* lisp/image-dired.el (image-dired-get-thumbnail-image): Use
string-match-p.

3 years agoimage-dired: Don't disable mouse dragging
Stefan Kangas [Mon, 6 Dec 2021 01:48:55 +0000 (02:48 +0100)]
image-dired: Don't disable mouse dragging

* lisp/image-dired.el (image-dired-thumbnail-mode-map): Don't
disable mouse dragging.  (Bug#52201)

3 years agoFix jittering when precision scrolling over images
Po Lu [Mon, 6 Dec 2021 01:40:38 +0000 (09:40 +0800)]
Fix jittering when precision scrolling over images

* lisp/pixel-scroll.el
(pixel-scroll-precision-initial-velocity-factor): Default to
nil.
(pixel-scroll-precision-scroll-down-page): Always set window
start.

3 years agovc-git--program-version to support Git for macOS version string
Justin Schell [Mon, 6 Dec 2021 01:27:52 +0000 (02:27 +0100)]
vc-git--program-version to support Git for macOS version string

`git version` on macOS returns e.g., "git version 2.30.1 (Apple
Git-130)" and `vc-git--program-version` currently returns "0" instead
of "2.30.1".

* lisp/vc/vc-git.el (vc-git--program-version): Ignore text after
the version number when parsing git versions (bug#52172).

Copyright-paperwork-exempt: yes

3 years agoDon't fill byte-compilation warnings in batch mode
Lars Ingebrigtsen [Mon, 6 Dec 2021 01:23:02 +0000 (02:23 +0100)]
Don't fill byte-compilation warnings in batch mode

* lisp/emacs-lisp/warnings.el (display-warning): Don't break up
byte-compilation into several lines when in batch mode, because
that makes it difficult for some tools to parse them (bug#52281).

3 years agoAudit `string-match' usage in shr.el
Lars Ingebrigtsen [Mon, 6 Dec 2021 00:16:23 +0000 (01:16 +0100)]
Audit `string-match' usage in shr.el

* lisp/net/shr.el (shr-descend):
(shr-insert):
(shr-expand-url):
(shr-image-from-data):
(shr-dom-print):
(shr-parse-style):
(shr-tag-object):
(shr-tag-img):
(shr-render-td-1): Prefer string-match-p and string-search over
string-match where possible.

3 years agoFix typos and improve consistency in ERC manual
Christer Enfors [Sun, 5 Dec 2021 21:46:58 +0000 (22:46 +0100)]
Fix typos and improve consistency in ERC manual

* doc/misc/erc.texi (Sample Session, Special Features, History): Fix
typos and improve consistency.  (Bug52318)

3 years ago; * src/image.c (webp_load): Minor stylistic fix-up to previous change
Lars Ingebrigtsen [Sun, 5 Dec 2021 22:31:36 +0000 (23:31 +0100)]
; * src/image.c (webp_load): Minor stylistic fix-up to previous change

* src/image.c (webp_load): Minor stylistic fix-up to previous change.

3 years agoAdd workaround to compilation warning in gcc 10.x in image.c
dickmao [Sun, 5 Dec 2021 22:29:51 +0000 (23:29 +0100)]
Add workaround to compilation warning in gcc 10.x in image.c

* src/image.c (webp_load): Work around a (wrong) compiler warning
in gcc 10.x (bug#52276).

3 years ago; * etc/themes/manoj-dark-theme.el: Remove not defined face info-menu-5
YugaEgo [Sun, 5 Dec 2021 21:18:18 +0000 (22:18 +0100)]
; * etc/themes/manoj-dark-theme.el: Remove not defined face info-menu-5

* etc/themes/manoj-dark-theme.el (manoj-dark): Remove reference to
face removed in 2005 (bug#52303).

3 years agoUpdate comment about `declare-function'
Lars Ingebrigtsen [Sun, 5 Dec 2021 21:12:26 +0000 (22:12 +0100)]
Update comment about `declare-function'

* lisp/subr.el (declare-function): Fix comment --
`byte-compile-declare-function' doesn't exist.

3 years ago* lisp/info.el (info-menu-star): Improve documentation
YugaEgo [Sun, 5 Dec 2021 21:05:41 +0000 (22:05 +0100)]
* lisp/info.el (info-menu-star): Improve documentation

* lisp/info.el (info-menu-star): Improve the doc string (bug#52315).

3 years agoFix wording in eieio.texi (Generics)
Lars Ingebrigtsen [Sun, 5 Dec 2021 21:03:24 +0000 (22:03 +0100)]
Fix wording in eieio.texi (Generics)

* doc/misc/eieio.texi (Generics): Fix wording in paragraph
(bug#52317).

3 years agoFix regression introduced by previous context-menu-map change
Lars Ingebrigtsen [Sun, 5 Dec 2021 20:20:03 +0000 (21:20 +0100)]
Fix regression introduced by previous context-menu-map change

* lisp/mouse.el (context-menu-map): Make the context mode work
with flyspell again  (bug#52237).

3 years agoRevert "Clarify Creating Frames documentation"
Lars Ingebrigtsen [Sun, 5 Dec 2021 20:15:00 +0000 (21:15 +0100)]
Revert "Clarify Creating Frames documentation"

This reverts commit 5d7eb2979bc7eec01cff7e7908dbbd3edb38ea0c.

The new documentation was incorrect.

3 years agoRevert "Improve before-make-frame-hook and after-make-frame-functions docs"
Lars Ingebrigtsen [Sun, 5 Dec 2021 20:14:26 +0000 (21:14 +0100)]
Revert "Improve before-make-frame-hook and after-make-frame-functions docs"

This reverts commit 7842a606b76dfabd1540da1c130728064e8f02ed.

The new documentation was incorrect.

3 years agoFix fancy-about-screen point placement
Lars Ingebrigtsen [Sun, 5 Dec 2021 19:53:47 +0000 (20:53 +0100)]
Fix fancy-about-screen point placement

* lisp/startup.el (fancy-about-screen): Make point placement more
resilient (bug#43636).

3 years ago* test/Makefile.in (check-declare): Add missing --batch.
Glenn Morris [Sun, 5 Dec 2021 18:27:18 +0000 (10:27 -0800)]
* test/Makefile.in (check-declare): Add missing --batch.

3 years agoLight copy-edits to recent additions to ERC manual
Stefan Kangas [Sun, 5 Dec 2021 18:21:05 +0000 (19:21 +0100)]
Light copy-edits to recent additions to ERC manual

* doc/misc/erc.texi (Introduction, Getting Started): Light copy-edits.

3 years agoRemove no-op calls to decode-char with 'ucs' arg
Stefan Kangas [Sun, 5 Dec 2021 18:09:48 +0000 (19:09 +0100)]
Remove no-op calls to decode-char with 'ucs' arg

* lisp/gnus/mm-util.el (mm-ucs-to-char):
* lisp/language/hanja-util.el (hangul-to-hanja-char):
* lisp/leim/quail/hangul.el (hangul3-input-method-internal)
(hangul390-input-method-internal):
* lisp/nxml/rng-cmpct.el (rng-c-process-escapes):
* lisp/nxml/xsd-regexp.el (xsdre-compile-single-char)
(xsdre-range-list-to-char-alternative):
* lisp/xml.el (xml-parse-string, xml--entity-replacement-text)
(xml-substitute-special): Remove calls to decode-char where first
argument is 'ucs'; that is now a no-op.  Discussed in Bug#52263.

* lisp/nxml/xmltok.el (xmltok-unicode-to-char): Make into obsolete
function alias for 'identity'.  Update single caller.

3 years agoUse gnus-error to report mail-source failures
Eric Abrahamsen [Sat, 4 Dec 2021 20:37:14 +0000 (12:37 -0800)]
Use gnus-error to report mail-source failures

* lisp/gnus/mail-source.el (mail-source-fetch): Instead of querying
the user on mail sources errors -- in effect asking "do you want to
continue, or halt the process?" -- log the error with `gnus-error',
severity 5. The query didn't provide any meaningful control; error
reporting is all that's needed.
(mail-source-ignore-errors): Obsolete this option; users can see the
error or not by configuring `gnus-verbose'.
* doc/misc/gnus.texi (Mail Source Customization): Remove mention of
the above option from the manual.

3 years ago; Another protection from out-of-bounds access to it->stack[].
Eli Zaretskii [Sun, 5 Dec 2021 16:03:40 +0000 (18:03 +0200)]
; Another protection from out-of-bounds access to it->stack[].

3 years agoFix out-of-bounds access in xdisp.c
Eli Zaretskii [Sun, 5 Dec 2021 15:34:05 +0000 (17:34 +0200)]
Fix out-of-bounds access in xdisp.c

* src/xdisp.c (produce_stretch_glyph): Avoid indexing it->stack
with a negative index.  Reported by Po Lu <luangruo@yahoo.com>.

3 years agoDocument the subtleties of the 'cursor' text property
Eli Zaretskii [Sun, 5 Dec 2021 14:38:49 +0000 (16:38 +0200)]
Document the subtleties of the 'cursor' text property

* doc/lispref/text.texi (Special Properties): Update the
documentation of the 'cursor' property per bug#8627.

3 years agoInterpolate large pixel scrolls
Po Lu [Sun, 5 Dec 2021 13:34:54 +0000 (21:34 +0800)]
Interpolate large pixel scrolls

* lisp/pixel-scroll.el
(pixel-scroll-precision-large-scroll-height): New user option.
(pixel-scroll-precision-interpolate): New function.
(pixel-scroll-precision): Interpolate scrolls under some
circumstances.

3 years agoSilence byte-compiler in generator-tests.el
Stefan Kangas [Sun, 5 Dec 2021 11:54:53 +0000 (12:54 +0100)]
Silence byte-compiler in generator-tests.el

* test/lisp/emacs-lisp/generator-tests.el (cps-let*-shadow-empty)
(cps-let-shadow-empty, cps-let*-parallel): Silence byte-compiler.

3 years agoSilence warnings about testing obsolete functions and macros
Stefan Kangas [Sun, 5 Dec 2021 11:49:52 +0000 (12:49 +0100)]
Silence warnings about testing obsolete functions and macros

* test/lisp/emacs-lisp/cl-generic-tests.el:
* test/lisp/emacs-lisp/edebug-tests.el:
* test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:
* test/lisp/emacs-lisp/eieio-tests/eieio-tests.el: Silence
byte-compiler warnings about testing obsolete functions and macros.

3 years agoRemove hacks for broken `with-suppressed-warnings'
Stefan Kangas [Sun, 5 Dec 2021 11:08:27 +0000 (12:08 +0100)]
Remove hacks for broken `with-suppressed-warnings'

* test/lisp/obsolete/cl-tests.el (labels-function-quoting):
* test/lisp/tar-mode-tests.el (tar-mode-test-tar-grind-file-mode):
Remove hack for broken `with-suppressed-warnings'.

3 years ago; * doc/misc/eshell.texi (Built-ins): Improve markup, fix typos.
Eli Zaretskii [Sun, 5 Dec 2021 10:12:00 +0000 (12:12 +0200)]
; * doc/misc/eshell.texi (Built-ins): Improve markup, fix typos.

3 years agoMerge from origin/emacs-28
Stefan Kangas [Sun, 5 Dec 2021 05:30:35 +0000 (06:30 +0100)]
Merge from origin/emacs-28

c086358574 Update to Org 9.5.1-15-gdb4805
fef3e60061 * lisp/emacs-lisp/edebug.el (edebug-eval-defun): Minor doc...
a1e30e4106 ; Fix most remaining AUTHORS warnings
f3e6a432c5 ; * doc/misc/efaq.texi (New in Emacs 28): Add more news.
00236cc802 Fix the enumeration values returned by 'try_scrolling'

3 years agoRemove hack from seq-tests.el for broken `with-suppressed-warnings'
Lars Ingebrigtsen [Sun, 5 Dec 2021 03:20:55 +0000 (04:20 +0100)]
Remove hack from seq-tests.el for broken `with-suppressed-warnings'

* test/lisp/emacs-lisp/seq-tests.el: `with-suppressed-warnings'
now works better in erf-deftests, so remove hack that works around
it (bug#36568).

3 years agoImprove before-make-frame-hook and after-make-frame-functions docs
Lars Ingebrigtsen [Sun, 5 Dec 2021 03:12:55 +0000 (04:12 +0100)]
Improve before-make-frame-hook and after-make-frame-functions docs

* lisp/frame.el (before-make-frame-hook):
(after-make-frame-functions): Note when the functions are run.

3 years agoClarify Creating Frames documentation
Lars Ingebrigtsen [Sun, 5 Dec 2021 03:09:33 +0000 (04:09 +0100)]
Clarify Creating Frames documentation

* doc/lispref/frames.texi (Creating Frames): Remove misleading
explanation -- even if the hooks are set, they won't be run
(bug#38143).

3 years agoUpdate to Org 9.5.1-15-gdb4805
Kyle Meyer [Sun, 5 Dec 2021 02:27:59 +0000 (21:27 -0500)]
Update to Org 9.5.1-15-gdb4805

3 years agoFix tty mouse wheel on window systems other than X
Po Lu [Sun, 5 Dec 2021 01:59:45 +0000 (09:59 +0800)]
Fix tty mouse wheel on window systems other than X

* lisp/mwheel.el (mouse-wheel-down-alternate-event)
(mouse-wheel-up-alternate-event)
(mouse-wheel-left-alternate-event)
(mouse-wheel-right-alternate-event): Set appropriately for
non-X systems.

3 years agoMake help--describe-command more robust
Lars Ingebrigtsen [Sun, 5 Dec 2021 01:57:43 +0000 (02:57 +0100)]
Make help--describe-command more robust

* lisp/help.el (help--describe-command): `help-function' buttons
are defined in help-mode.el, so it might not exist yet when
calling `documentation' directly (bug#52291).

3 years agoAdd IRC introduction to the ERC manual
Christer Enfors [Sun, 5 Dec 2021 01:44:35 +0000 (02:44 +0100)]
Add IRC introduction to the ERC manual

* doc/misc/erc.texi (Getting Started): Mention libera.char (bug#52287).
(Introduction): Explain what IRC is.

Copyright-paperwork-exempt: yes

3 years agoMake pixel scrolling through images less jumpy
Po Lu [Sun, 5 Dec 2021 01:44:06 +0000 (09:44 +0800)]
Make pixel scrolling through images less jumpy

* lisp/pixel-scroll.el
(pixel-scroll-precision-scroll-down-page): Improve detection of
situations where vscroll must directly be set.

3 years agoUpdate the Info documentation of Eshell's built-in commands
Earl Hyatt [Sun, 5 Dec 2021 01:41:39 +0000 (02:41 +0100)]
Update the Info documentation of Eshell's built-in commands

* doc/misc/eshell.texi (Built-in commands): Add the remaining
built-in Eshell commands to the list of built-ins.  Expand some of
the descriptions and mention user options affecting command
behavior.  Sort these commands in alphabetical order (bug#52289).

3 years agoMake package-dir-info more resilient
Lars Ingebrigtsen [Sun, 5 Dec 2021 01:13:00 +0000 (02:13 +0100)]
Make package-dir-info more resilient

* lisp/emacs-lisp/package.el (package-dir-info): Check that the
file exists before using it (bug#41489).

3 years agoTweak fancy-about-text
Lars Ingebrigtsen [Sun, 5 Dec 2021 00:53:31 +0000 (01:53 +0100)]
Tweak fancy-about-text

* lisp/startup.el (fancy-about-text): Mention that Emacs is an
editor, because people don't know that (bug#43636).

3 years agoFill Emacs version on about screen
Lars Ingebrigtsen [Sun, 5 Dec 2021 00:51:12 +0000 (01:51 +0100)]
Fill Emacs version on about screen

* lisp/startup.el (fancy-about-text): Fill the Emacs version,
since it's too long these days.

3 years agoFurther gnus-inews-insert-gcc fixes
Lars Ingebrigtsen [Sat, 4 Dec 2021 22:47:17 +0000 (23:47 +0100)]
Further gnus-inews-insert-gcc fixes

* lisp/gnus/gnus-msg.el (gnus-inews-insert-gcc): Use a single
comma to separate groups, since that's what the splitter expects
(bug#52274).

3 years agoAvoid having gud bug out if `C-x C-a' has been bound
Lars Ingebrigtsen [Sat, 4 Dec 2021 20:44:58 +0000 (21:44 +0100)]
Avoid having gud bug out if `C-x C-a' has been bound

* lisp/progmodes/gdb-mi.el (gud-global-map): Use gud-global-map.
* lisp/progmodes/gud.el (gud-global-map): Define a map instead of
assuming that `C-x C-a' is undefined (bug#6035).
(gud-def): Use the map.

3 years agoDon't swallow gnus-search errors when creating nnselect groups
Eric Abrahamsen [Sat, 4 Dec 2021 21:41:23 +0000 (13:41 -0800)]
Don't swallow gnus-search errors when creating nnselect groups

* lisp/gnus/gnus-search.el (gnus-search-run-query): Modify
condition-case to re-signal any gnus-search related errors; the user
should see them.
(gnus-search-error): Define a new parent error for all gnus-search
errors.

3 years ago* lisp/isearch.el (isearch-delete-char): Reopen hidden overlays (bug#52248).
Juri Linkov [Sat, 4 Dec 2021 20:04:37 +0000 (22:04 +0200)]
* lisp/isearch.el (isearch-delete-char): Reopen hidden overlays (bug#52248).

(isearch-filter-visible): Move text-property-not-all higher
to not call isearch-range-invisible on inhibit-isearch text.
Remove min/max since arguments are always in the right order.

3 years agoFix pixel-fill--fill-line infloop for certain unbreakable lines
Lars Ingebrigtsen [Sat, 4 Dec 2021 19:38:22 +0000 (20:38 +0100)]
Fix pixel-fill--fill-line infloop for certain unbreakable lines

* lisp/textmodes/pixel-fill.el (pixel-fill--fill-line): Fix
infloops for certain line widths (bug#52271).

3 years agoAdd a comma between groups in gnus-inews-insert-gcc
Lars Ingebrigtsen [Sat, 4 Dec 2021 19:22:44 +0000 (20:22 +0100)]
Add a comma between groups in gnus-inews-insert-gcc

* lisp/gnus/gnus-msg.el (gnus-inews-insert-gcc): Insert a comma
between group names to get more mail-like syntax (bug#52274).

3 years agoImprove bookmark-maybe-historicize-string doc string
Lars Ingebrigtsen [Sat, 4 Dec 2021 04:56:32 +0000 (05:56 +0100)]
Improve bookmark-maybe-historicize-string doc string

* lisp/bookmark.el (bookmark-maybe-historicize-string): Clarify
that this isn't about menus (but calls from bmenu) (bug#12504).

3 years agoAdd ".crate" to Tramp archive file suffixes.
Michael Albinus [Sat, 4 Dec 2021 19:02:07 +0000 (20:02 +0100)]
Add ".crate" to Tramp archive file suffixes.

* doc/misc/tramp.texi (Archive file names):
* lisp/net/tramp-archive.el (tramp-archive-suffixes): Add ".crate".

3 years agoeieio-core.el: Allow assignment to cl-structs through `slot-value`
Stefan Monnier [Sat, 4 Dec 2021 18:47:19 +0000 (13:47 -0500)]
eieio-core.el: Allow assignment to cl-structs through `slot-value`

* lisp/emacs-lisp/eieio-core.el (eieio--validate-slot-value):
Obey the `:read-only` property of the slot.
(eieio-oset): Allow use on cl-structs as well.
(eieio-read-only): New error.

* test/lisp/emacs-lisp/eieio-tests/eieio-tests.el (eieio-test--struct):
Make the last field read-only.
(eieio-test-defstruct-slot-value): Test that cl-struct slots can be
assigned via `slot-value`.

3 years agoFix (date-to-time "2021-12-04")
Paul Eggert [Sat, 4 Dec 2021 18:33:32 +0000 (10:33 -0800)]
Fix (date-to-time "2021-12-04")

This should complete the fix for Bug#52209.
* lisp/calendar/time-date.el (date-to-time): Apply
decoded-time-set-defaults only to the output of (parse-time-string
date), and only when the output has a year (to avoid confusion
when dates lack years).  There is no point applying it after
timezone-make-date-arpa-standard since the latter fills in all the
blanks.  And the former code mistakenly called encode-time on an
already-encoded time.  This goes back to the code a couple of days
ago, except with changed behavior (to fix Bug#52209) only when
timezone-make-date-arpa-standard is not called.
* test/lisp/calendar/time-date-tests.el (test-date-to-time)
(test-days-between): New tests.

3 years agoFurther changes on directory summary line in Tramp
Michael Albinus [Sat, 4 Dec 2021 17:43:45 +0000 (18:43 +0100)]
Further changes on directory summary line in Tramp

* lisp/net/tramp-gvfs.el (tramp-gvfs-handle-file-system-info):
Do not assume 0 in case of missing information.

* lisp/net/tramp-sh.el (tramp-sh-handle-insert-directory):
* lisp/net/tramp-smb.el (tramp-smb-handle-insert-directory):
Revert previous change, it doesn't fly.

3 years agoSilence byte-compiler in some tests
Stefan Kangas [Sat, 4 Dec 2021 14:49:42 +0000 (15:49 +0100)]
Silence byte-compiler in some tests

* test/lisp/dired-tests.el:
* test/lisp/emacs-lisp/cl-macs-tests.el:
* test/lisp/emacs-lisp/derived-tests.el:
* test/lisp/emacs-lisp/eieio-tests/eieio-tests.el:
* test/lisp/emacs-lisp/generator-tests.el:
* test/lisp/emacs-lisp/lisp-tests.el:
* test/lisp/emacs-lisp/seq-tests.el (test-seq-let)
(test-seq-setq):
* test/lisp/emacs-lisp/subr-x-tests.el (subr-x-test-if-let*-false)
(subr-x-test-if-let*-and-laziness-is-preserved)
(subr-x-test-when-let*-false)
(subr-x-test-when-let*-and-laziness-is-preserved):
* test/lisp/emacs-lisp/timer-tests.el
(timer-tests-debug-timer-check):
* test/lisp/format-spec-tests.el (format-spec-do-flags-truncate)
(format-spec-do-flags-pad):
* test/lisp/ls-lisp-tests.el (ls-lisp-test-bug27762):
* test/lisp/obsolete/cl-tests.el (labels-function-quoting):
* test/lisp/progmodes/elisp-mode-tests.el:
* test/lisp/replace-tests.el (replace-regexp-bug45973):
* test/lisp/ses-tests.el:
* test/lisp/subr-tests.el:
* test/lisp/tar-mode-tests.el (tar-mode-test-tar-grind-file-mode):
* test/src/data-tests.el (data-tests--set-default-per-buffer):
* test/src/search-tests.el
(test-replace-match-modification-hooks): Silence byte-compiler.

3 years ago* lisp/emacs-lisp/edebug.el (edebug-eval-defun): Minor doc fix.
Stefan Kangas [Sat, 4 Dec 2021 12:23:35 +0000 (13:23 +0100)]
* lisp/emacs-lisp/edebug.el (edebug-eval-defun): Minor doc fix.

3 years agoFix the MinGW build broken by recent changes in image.c
Eli Zaretskii [Sat, 4 Dec 2021 11:42:25 +0000 (13:42 +0200)]
Fix the MinGW build broken by recent changes in image.c

* src/image.c (rsvg_handle_get_intrinsic_size_in_pixels)
[WINDOWSNT]: Fix prototype.  (Bug#44655)

3 years ago; Fix removal of obsolete newsticker function
Stefan Kangas [Sat, 4 Dec 2021 11:22:58 +0000 (12:22 +0100)]
; Fix removal of obsolete newsticker function

* lisp/net/newst-plainview.el (newsticker-close-buffer)
(newsticker-mark-all-items-of-feed-as-read)
(newsticker-mark-all-items-as-read): Use 'newsticker--cache-save'
instead of removed obsolete function 'newsticker--cache-update'.
* etc/NEWS: Don't mention obsolete internal variables.

3 years ago; Fix most remaining AUTHORS warnings
Stefan Kangas [Sat, 4 Dec 2021 10:48:50 +0000 (11:48 +0100)]
; Fix most remaining AUTHORS warnings

* admin/authors.el (authors-ignored-files)
(authors-renamed-files-alist): Further updates for Emacs 28.
* ChangeLog.3: Further fixes.
* etc/AUTHORS: Update accordingly.

3 years agoMake use of Trash on macOS (bug#21340)
Alan Third [Fri, 3 Dec 2021 22:17:45 +0000 (22:17 +0000)]
Make use of Trash on macOS (bug#21340)

* src/nsfns.m (Fsystem_move_file_to_trash): New function.

3 years ago; Silence byte-compiler warning in test
Stefan Kangas [Sat, 4 Dec 2021 10:33:43 +0000 (11:33 +0100)]
; Silence byte-compiler warning in test

* test/lisp/dired-aux-tests.el (dired-test-bug28834): Silence
byte-compiler.

3 years ago; * doc/misc/efaq.texi (New in Emacs 28): Add more news.
Eli Zaretskii [Sat, 4 Dec 2021 09:11:08 +0000 (11:11 +0200)]
; * doc/misc/efaq.texi (New in Emacs 28): Add more news.

3 years agoYet another place inside redisplay_window to prevent quitting
Eli Zaretskii [Sat, 4 Dec 2021 08:37:40 +0000 (10:37 +0200)]
Yet another place inside redisplay_window to prevent quitting

* src/xdisp.c (handle_single_display_spec): Inhibit quitting
around the call to 'lookup_derived_face' (which can QUIT).
(Bug#44448)

3 years agoFix the enumeration values returned by 'try_scrolling'
Eli Zaretskii [Sat, 4 Dec 2021 08:19:56 +0000 (10:19 +0200)]
Fix the enumeration values returned by 'try_scrolling'

* src/xdisp.c (try_scrolling): Make the enum values match the
commentary.  Reported by Po Lu <luangruo@yahoo.com>.

3 years agoFix dependencies for files in the 'nt' subdirectory
Eli Zaretskii [Sat, 4 Dec 2021 07:07:12 +0000 (09:07 +0200)]
Fix dependencies for files in the 'nt' subdirectory

* Makefile.in ($(NTDIR)): If non-empty, depend on 'lib'.  That's
because some files in nt/ include generated Gnulib headers.

3 years agoMake precision pixel scrolling work in an hscrolled window
Po Lu [Sat, 4 Dec 2021 06:01:59 +0000 (14:01 +0800)]
Make precision pixel scrolling work in an hscrolled window

* lisp/pixel-scroll.el
(pixel-scroll-precision-scroll-down-page)
(pixel-scroll-precision-scroll-up-page): Use beginning of visual
line as window start if hscrolled.
(pixel-scroll-precision): Don't delegate to mwheel-scroll if
window is hscrolled.

3 years agoMerge from origin/emacs-28
Stefan Kangas [Sat, 4 Dec 2021 05:30:32 +0000 (06:30 +0100)]
Merge from origin/emacs-28

745a732ae4 ; Further author fixes in authors.el
bef17bca21 * src/dosfns.c (Fint86): Doc fix; don't use obsolete names.
bc55dc04af * doc/misc/erc.texi (Keystroke Summary): Fix doc for TAB.
ef4d216eb3 Remove reference to variable obsolete since 24.1
7282e492d5 * doc/misc/efaq.texi (New in Emacs 28): New node.
eafcccd38f ; FAQ: Normalize references to the NEWS.NN file
c006c490eb ; * doc/misc/efaq.texi (Latest version of Emacs): Update v...
9fbc4fa0e7 Add Tramp version integrated in Emacs 28.1

3 years ago; Merge from origin/emacs-28
Stefan Kangas [Sat, 4 Dec 2021 05:30:32 +0000 (06:30 +0100)]
; Merge from origin/emacs-28

The following commit was skipped:

1dfcac6e10 Update Tramp version (don't merge with master)

3 years agoMerge from origin/emacs-28
Stefan Kangas [Sat, 4 Dec 2021 05:30:32 +0000 (06:30 +0100)]
Merge from origin/emacs-28

5d6f828799 Unbreak build after 9c222b9c1a7f91497a37567b4d7de3a511fff069.

3 years ago* lisp/minibuffer.el: Don't return a boundary outside its arg
Stefan Monnier [Sat, 4 Dec 2021 05:02:01 +0000 (00:02 -0500)]
* lisp/minibuffer.el: Don't return a boundary outside its arg

* lisp/minibuffer.el (completion-table-subvert): Fix out of string
start boundary for the odd case where `string` is shorter than `s1`.

3 years agoMake the error message in epa-display-error more helpful
Lars Ingebrigtsen [Sat, 4 Dec 2021 04:39:25 +0000 (05:39 +0100)]
Make the error message in epa-display-error more helpful

* lisp/epa.el (epa-display-error): Output a more helpful error
message when reading a keyring file (bug#12923).

3 years agoFix keymap-lookup implementation
Lars Ingebrigtsen [Sat, 4 Dec 2021 04:24:54 +0000 (05:24 +0100)]
Fix keymap-lookup implementation

* lisp/keymap.el (keymap-lookup): Make this actually work for
looking up keys.

3 years agoFix highlighting of "Exit*" phrases in f90-mode
Lars Ingebrigtsen [Sat, 4 Dec 2021 04:07:41 +0000 (05:07 +0100)]
Fix highlighting of "Exit*" phrases in f90-mode

* lisp/progmodes/f90.el (f90-font-lock-keywords-2): Don't
highlight phrases that start with "Exit" as an exit statement
(bug#14442).

3 years agoMake `mouse-1' restart the cua-rect rectangle
Lars Ingebrigtsen [Sat, 4 Dec 2021 03:06:27 +0000 (04:06 +0100)]
Make `mouse-1' restart the cua-rect rectangle

* lisp/emulation/cua-rect.el (cua-mouse-set-rectangle-mark):
Restart the rectangle on mouse-1 (bug#51557).

3 years agoMake last change work for deltas that are multiples of max-height
Po Lu [Sat, 4 Dec 2021 01:43:44 +0000 (09:43 +0800)]
Make last change work for deltas that are multiples of max-height

* lisp/pixel-scroll.el (pixel-scroll-precision-scroll-down-page)
(pixel-scroll-precision-scroll-up-page): Use `max-height' that
is slightly less than the text height of the window.

3 years agoMake it work to pixel scroll by deltas larger than the window
Po Lu [Sat, 4 Dec 2021 01:09:28 +0000 (09:09 +0800)]
Make it work to pixel scroll by deltas larger than the window

* lisp/pixel-scroll.el
(pixel-scroll-precision-scroll-down-page):
(pixel-scroll-precision-scroll-up-page): New functions.

(pixel-scroll-precision-scroll-up)
(pixel-scroll-precision-scroll-down): Make it safe to scroll
by deltas larger than the current window.

3 years ago; Further author fixes in authors.el
Stefan Kangas [Sat, 4 Dec 2021 00:11:01 +0000 (01:11 +0100)]
; Further author fixes in authors.el

* admin/authors.el (authors-aliases): Add some missing entries.
* etc/AUTHORS: Update accordingly.

3 years ago* src/dosfns.c (Fint86): Doc fix; don't use obsolete names.
Stefan Kangas [Sat, 4 Dec 2021 00:00:04 +0000 (01:00 +0100)]
* src/dosfns.c (Fint86): Doc fix; don't use obsolete names.

3 years ago* doc/misc/erc.texi (Keystroke Summary): Fix doc for TAB.
Stefan Kangas [Fri, 3 Dec 2021 21:57:48 +0000 (22:57 +0100)]
* doc/misc/erc.texi (Keystroke Summary): Fix doc for TAB.

3 years agoEnsure that MAIN_FIRST have finished compilation before doing the rest
Lars Ingebrigtsen [Fri, 3 Dec 2021 21:21:41 +0000 (22:21 +0100)]
Ensure that MAIN_FIRST have finished compilation before doing the rest

* lisp/Makefile.in (main-first): Ensure that we're done with the
main bits before starting on the rest.
(GREP_OPTIONS): Depend on main-first.
(MAIN_FIRST): Compile cconv.el before c-by.el (bug#8764).

3 years agoPort to Tiny C on x86-64
Paul Eggert [Fri, 3 Dec 2021 21:05:31 +0000 (13:05 -0800)]
Port to Tiny C on x86-64

This allows Emacs to build on Ubuntu 21.10 x86-64 with
‘./configure --without-modules CC=tcc’.
* configure.ac (GC_SETJMP_WORKS):
Accept __x86_64__ as an alias for __amd64__.
* src/lisp.h (alignas): Provide a no-op substitute.

3 years agoRevert "emacs-lisp-mode: Use error face for "/d" indicator"
Eli Zaretskii [Fri, 3 Dec 2021 19:55:10 +0000 (21:55 +0200)]
Revert "emacs-lisp-mode: Use error face for "/d" indicator"

This reverts commit ddc875d9f75bdd1d5dda6a721489f43317b0f8b5.

I disagree with the need to make it more prominent than the
warning face.  The warning face is prominent enough.  We
never decided to annoy people like that.

3 years agoAdd more dired-x tests
Eli Zaretskii [Fri, 3 Dec 2021 19:52:49 +0000 (21:52 +0200)]
Add more dired-x tests

* test/lisp/dired-x-tests.el (dired-x--string-to-number): Add more
tests with various thousands separators.

3 years ago; * etc/NEWS: Move incompatible changes into a separate section.
Eli Zaretskii [Fri, 3 Dec 2021 19:44:26 +0000 (21:44 +0200)]
; * etc/NEWS: Move incompatible changes into a separate section.

3 years agoRemove reference to variable obsolete since 24.1
Stefan Kangas [Fri, 3 Dec 2021 19:41:38 +0000 (20:41 +0100)]
Remove reference to variable obsolete since 24.1

* doc/emacs/custom.texi (Minibuffer Maps, Minibuffer Maps): Remove
reference to variable 'minibuffer-local-filename-must-match-map',
obsolete since 24.1.

3 years agoRemove some more items obsolete since Emacs 23
Stefan Kangas [Fri, 3 Dec 2021 18:53:46 +0000 (19:53 +0100)]
Remove some more items obsolete since Emacs 23

* lisp/emacs-lisp/shadow.el (find-emacs-lisp-shadows):
* lisp/net/newst-backend.el (newsticker-cache-filename)
(newsticker--cache-save-version1, newsticker--cache-update)
(newsticker--cache-read-version1):
* lisp/obsolete/vc-arch.el (vc-arch-command): Remove items
obsolete since Emacs 23.