* lread.c (Fload, readevalloop, read1): Rename locals to avoid shadowing.

* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):

Rename locals to avoid shadowing.

* lread.c (read1): Rewrite so as not to use empty "else".

* print.c (Fredirect_debugging_output): Fix pointer signedess.

* lisp.h (debug_output_compilation_hack): Add decl here, to avoid

warning when compiling print.c.

* font.c (font_sort_entities): Mark var as initialized.

* font.c (font_unparse_fcname): Abort in an "impossible" situation

instead of using an uninitialized var.

* font.c: (font_style_to_value, font_prop_validate_style, font_unparse_fcname):

(font_update_drivers, Ffont_get_glyphs, font_add_log):
Rename or move locals to avoid shadowing.

* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

* font.c (font_get_spec): Remove; unused.

* font.c (font_delete_unmatched): Now static.

* font.c (font_parse_fcname): Remove unused vars.

* font.c (font_unparse_xlfd): Don't mix pointers to variables with

pointers to constants.

* fns.c (Ffillarray): Rename locals to avoid shadowing.

* fns.c (require_nesting_list, require_unwind): Now static.

* floatfns.c (Ffrexp, Fldexp): Rename locals to avoid shadowing.

* floatfns.c (domain_error2): Define only if needed.

* eval.c (Fdefvar): Rename locals to avoid shadowing.

* alloc.c (mark_backtrace): Move decl from here ...

* lisp.h: ... to here, so that it can be checked.

* eval.c (lisp_indirect_variable): Name an expression,

to avoid gcc -Wbad-function-cast warning.

* eval.c (Fdefvar): Rewrite so as not to use empty "else".

* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.

* callint.c: Use const pointer when appropriate.

* callint.c (Fcall_interactively): Rename locals to avoid shadowing.

* callint.c (quotify_arg, quotify_args): Now static.

* editfns.c (Ftranslate_region_internal): Mark var as initialized.

* editfns.c: (Fformat_time_string, Fencode_time, Finsert_char):

(Ftranslate_region_internal, Fformat):
Rename or remove local vars to avoid shadowing.

Move editfns decls to lisp.h to check interfaces.

* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):

(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
some of which prompt warnings from gcc -Wbad-function-cast.

* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to

avoid shadowing.

* data.c (do_blv_forwarding, do_symval_forwarding): Remove; unused.

* data.c (Fmake_variable_buffer_local, Fmake_local_variable): Mark

variables as initialized.

* lisp.h (eassert): Check that the argument compiles, even if

ENABLE_CHECKING is not defined.

* data.c (store_symval_forwarding): Rename local to avoid shadowing.

* data.c (default_value, arithcompare, arith_driver, arith_error): Now static.

* data.c (Findirect_variable): Name an expression, to avoid

gcc -Wbad-function-cast warning.

* alloc.c (Fmemory_limit): Cast sbrk's returned value to char *.

* alloc.c (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if

! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
needed otherwise.
(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
(GC_STRING_CHARS): Remove; not used.

* alloc.c (mark_stack): Move local variables into the #ifdef region where

they're used.

* alloc.c: (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):

Rename locals to avoid shadowing.

* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.

* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
avoids undefined behavior in theory.

* character.h (PREV_CHAR_BOUNDARY): Rename local to avoid shadowing.

* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

Fix typo in ChangeLog.

* editfns.c (Fchar_equal): Remove no-longer-needed workaround for

the race-condition problem the old DOWNCASE.

Add ChangeLog entry for previous change.

Use functions, not macros, for up- and down-casing.

* regex.c (RETALLOC_IF): Define only if needed.

(WORDCHAR_P): Likewise.  This one is never needed, but is used
only in a comment talking about a compiler bug, so put inside
the #if 0 of that comment.
(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
Remove; unused.

* regex.c (regex_compile, re_match_2_internal): Mark locals as initialized.

* regex.c (FREE_VAR): Rewrite so as not to use empty "else",

which gcc can warn about.

* regex.c (re_match_2_internals): Fix one more "not".

* regex.c: (regex_compile, re_search_2, re_match_2_internal):

Remove unused local vars.

* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):

Rename locals to avoid shadowing.
(regex_compile, re_match_2_internal): Move locals to avoid shadowing.

* search.c (boyer_moore): Rename locals to avoid shadowing.

* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE): Likewise.

* search.c (simple_search): Remove unused var.

* dired.c (compile_pattern): Move decl from here ...

* lisp.h: ... to here, so that it can be checked.
(struct re_registers): New forward decl.

* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

* indent.c (Fvertical_motion): Mark locals as initialized.

* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.

All uses changed.
(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
Rename locals to avoid shadowing.

* casefiddle.c (casify_region): Mark local as initialized.

* casefiddle.c (casify_object, casify_region): Now static.

* cmds.c (internal_self_insert): Rename local to avoid shadowing.

* lisp.h: New macros GCPRO2_VAR, GCPRO3_VAR, etc.

* dired.c (directory_files_internal, file_name_completion):

Rename locals to avoid shadowing.

Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).

An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
dired.c's scmp function, had undefined behavior.
* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
* buffer.h: ... to here, because these macros use current_buffer,
and the new implementation with inline functions needs to have
current_buffer in scope now, rather than later when the macros
are used.
(downcase, upcase1): New static inline functions.
(DOWNCASE, UPCASE1): Reimplement using these functions.
This avoids undefined behavior in expressions like
DOWNCASE (x) == DOWNCASE (y), which previously suffered
from race conditions in accessing the global variables
case_temp1 and case_temp2.
* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
* lisp.h (case_temp1, case_temp2): Remove their decls.
* character.h (ASCII_CHAR_P): Move from here ...
* lisp.h: ... to here, so that the inline functions mentioned
above can use them.

* dired.c (directory_files_internal_unwind): Now static.

* fileio.c: (Fset_file_times, Finsert_file_contents, auto_save_error):

Rename locals to avoid shadowing.

* fileio.c (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer

signedness issues.

* fileio.c (Fmake_directory_internal, Fread_file_name): Remove unused vars.

* fileio.c (file_name_as_directory): Use const pointers when appropriate.

(Fexpand_file_name): Likewise.  In particular, newdir might
point at constant storage, so make it a const pointer.

* fileio.c (file_name_as_directory, directory_file_name):

(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
Now static.

* minibuf.c (Ftry_completion, Fall_completions): Rename or remove locals

to avoid shadowing.

* minibuf.c (choose_minibuf_frame_1): Now static.

* marker.c (bytepos_to_charpos): Remove; unused.

* lisp.h (verify_bytepos, count_markers): New decls,

so that gcc does not warn that these functions aren't declared.

* insdel.c (copy_text): Remove unused local var.

* insdel.c (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.

* insdel.c (check_markers, make_gap_larger, make_gap_smaller):

(reset_var_on_error, Fcombine_after_change_execute_1): Now static.

* filelock.c (lock_file_1): Rename local to avoid shadowing.

* filelock.c (within_one_second): Now static.

* buffer.c (fix_overlays_before): Mark locals as initialized.

(fix_start_end_in_overlays): Likewise.  This function should be
simplified by using pointers-to-pointers, but that's a different
matter.

* buffer.c: (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):

(report_overlay_modification): Rename locals to avoid shadowing.

* buffer.c (switch_to_buffer_1): Now static.

* sysdep.c (MAXPATHLEN): Define only if needed.

* sysdep.c (sys_subshell): Mark local as volatile if checking for lint,

to suppress a gcc -Wclobbered warning that does not seem to be right.

* sysdep.c: Fix pointer signedness issue.

* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.

* process.c (serial_open, serial_configure): Move decls from here ...

* systty.h: ... to here, so that they can be checked.

* fns.c (get_random, seed_random): Move extern decls from here ...

* lisp.h: ... to here, so that they can be checked.

* sysdep.c (wait_for_termination_signal): Remove; unused.

* sysdep.c (reset_io): Now static.

* keymap.c: (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):

(describe_map_tree):
Rename locals to avoid shadowing.

* keymap.c (DENSE_TABLE_SIZE): Remove; unused.

* keymap.c (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.

* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):

(copy_keymap_item, append_key, push_text_char_description):
Now static.

* keyboard.c (read_char): Mark local as initialized.

* keyboard.c (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.

* keyboard.c (read_key_sequence): Mark locals as initialized.

* keyboard.c: (read_char, kbd_buffer_get_event, make_lispy_position):

(make_lispy_event, make_lispy_movement, apply_modifiers):
(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
(Fread_key_sequence_vector): Rename locals to avoid shadowing.

* keyboard.h (mark_kboards): Move decl here ...

* alloc.c (mark_kboards): ... from here.