]> git.eshelyaron.com Git - emacs.git/log
emacs.git
5 years agoExpand <<- heredocs in sh
Lars Ingebrigtsen [Wed, 16 Oct 2019 07:20:06 +0000 (09:20 +0200)]
Expand <<- heredocs in sh

* lisp/progmodes/sh-script.el (sh--maybe-here-document): Make <<-
expansion work, too.

5 years agoAllow event description to be empty
Robert Pluim [Tue, 15 Oct 2019 10:00:34 +0000 (12:00 +0200)]
Allow event description to be empty

The previous fix for this was incomplete.

* lisp/gnus/gnus-icalendar.el (gnus-icalendar-event->org-entry):
Allow description to be nil.

5 years agoFix some &rest body edebug specs
Lars Ingebrigtsen [Wed, 16 Oct 2019 02:44:22 +0000 (04:44 +0200)]
Fix some &rest body edebug specs

* lisp/ses.el (ses--letref):

* lisp/emacs-lisp/crm.el (crm--completion-command): Fix edebug
&rest body spec (bug#28747).

* lisp/emacs-lisp/easy-mmode.el (easy-mmode-define-navigation):

* lisp/emacs-lisp/inline.el (inline--leteval)
(inline--letlisteval, inline-letevals):

5 years agoTweak heredoc expansion in shell-script-mode
Lars Ingebrigtsen [Wed, 16 Oct 2019 01:47:12 +0000 (03:47 +0200)]
Tweak heredoc expansion in shell-script-mode

* lisp/progmodes/sh-script.el (sh--maybe-here-document): Allow
expanding <<E, too.

5 years agoDeclare tab-bar-tabs the single source of truth in regard to current tab name
Juri Linkov [Tue, 15 Oct 2019 21:42:31 +0000 (00:42 +0300)]
Declare tab-bar-tabs the single source of truth in regard to current tab name

* lisp/tab-bar.el: Replace all calls of tab-bar-tabs
with '(funcall tab-bar-tabs-function)'.
(tab-bar-tabs): Update the current tab name here
instead of tab-bar-make-keymap-1.
(tab-bar-make-keymap-1): Move the current tab name updating
to tab-bar-tabs.

5 years agoAllow tabs to have consistent given names
Robert Cochran [Mon, 7 Oct 2019 20:41:47 +0000 (13:41 -0700)]
Allow tabs to have consistent given names

* lisp/tab-bar.el (tab-bar--tab): Pull automatic name information from
current tab
(tab-bar--current-tab): Pull automatic name information from current
tab, or from new optional template argument
(tab-bar-select-tab): Pass the target tab as a template when setting
it as current tab
(tab-bar-rename-tab, tab-bar-rename-tab-by-name): New functions
* doc/emacs/frames.texi (Tab Bars): Document new tab rename functionality.

5 years ago* lisp/tab-bar.el (tab-bar-select-tab-modifiers): New defcustom.
Juri Linkov [Tue, 15 Oct 2019 20:38:18 +0000 (23:38 +0300)]
* lisp/tab-bar.el (tab-bar-select-tab-modifiers): New defcustom.

(tab-bar-mode): Use tab-bar-select-tab-modifiers to bind
tab-bar-select-tab.
Don't override user customized key bindings of C-TAB, C-S-TAB.
On disabling tab-bar-mode, unset only keys bound by tab-bar.

5 years agoDon't use expand-file-name to find images for tabs.
Juri Linkov [Tue, 15 Oct 2019 19:44:10 +0000 (22:44 +0300)]
Don't use expand-file-name to find images for tabs.

* lisp/tab-bar.el (tab-bar-mode):
* lisp/tab-line.el (tab-line-new-button, tab-line-close-button):
Remove expand-file-name with data-directory.

5 years agoNew variable tab-bar-position
Juri Linkov [Tue, 15 Oct 2019 19:41:40 +0000 (22:41 +0300)]
New variable tab-bar-position

* lisp/cus-start.el: Add customization for tab-bar-position.
* src/dispnew.c (syms_of_display): New variable Vtab_bar_position.
(adjust_frame_glyphs_for_window_redisplay): Use it.

5 years ago* lisp/rect.el (string-rectangle): Inherit input method in minibuffer
Stefan Monnier [Tue, 15 Oct 2019 15:08:03 +0000 (11:08 -0400)]
* lisp/rect.el (string-rectangle): Inherit input method in minibuffer

5 years agoFix test data broken by removing trailing whitespace.
Eric Ludlam [Tue, 15 Oct 2019 00:57:06 +0000 (20:57 -0400)]
Fix test data broken by removing trailing whitespace.

5 years agoAdapt the CEDET SRecoder getset tests to use ERT
Eric Ludlam [Tue, 15 Oct 2019 00:53:24 +0000 (20:53 -0400)]
Adapt the CEDET SRecoder getset tests to use ERT

These tests were copied from CEDET from SourceForge.
Author: Eric Ludlam <zappo@gnu.org>

5 years agoAdapt the CEDET SRecoder template test to use ERT
Eric Ludlam [Tue, 15 Oct 2019 00:52:52 +0000 (20:52 -0400)]
Adapt the CEDET SRecoder template test to use ERT

These tests were copied from CEDET from SourceForge.
Author: Eric Ludlam <zappo@gnu.org>

5 years agoCopy CEDET/Semantic's tag formatter test suite to be an
Eric Ludlam [Tue, 15 Oct 2019 00:48:16 +0000 (20:48 -0400)]
Copy CEDET/Semantic's tag formatter test suite to be an

automated test.
These tests were copied from CEDET on Sourceforge and adapted to use ERT.
Author: Eric Ludlam <zappo@gnu.org>

5 years agoUpdate CEDET manual tests so that they run.
Eric Ludlam [Tue, 15 Oct 2019 00:46:01 +0000 (20:46 -0400)]
Update CEDET manual tests so that they run.

To run visit test/manual/cedet/cedet-utests.el
M-x eval-buffer
M-x cedet-utest
Author: Eric Ludlam <zappo@gnu.org>

5 years agoConvert manual CEDET tests from test/manual/cedet to be
Eric Ludlam [Tue, 15 Oct 2019 00:43:28 +0000 (20:43 -0400)]
Convert manual CEDET tests from test/manual/cedet to be

automated tests in test/lisp/cedet.
Author: Eric Ludlam <zappo@gnu.org>

5 years agoFix duplicated words in lispref
Robert Pluim [Tue, 15 Oct 2019 12:41:43 +0000 (14:41 +0200)]
Fix duplicated words in lispref

* doc/lispref/text.texi (Base 64):
* doc/lispref/internals.texi (Window Internals): Remove duplicated
words.

5 years agoFix duplicated words in comments
Robert Pluim [Mon, 14 Oct 2019 18:31:33 +0000 (20:31 +0200)]
Fix duplicated words in comments

* src/coding.c (encode_string_utf_8):
* src/keyboard.c (syms_of_keyboard):
* src/mini-gmp.c (gmp_lucas_mod, mpz_export):
* src/pdumper.c (dump_set_referrer, dump_queue_compute_score):
* src/timefns.c (Ftime_convert): Remove duplicated words.

5 years agoFix recording keyboard macros in Calc
Eli Zaretskii [Tue, 15 Oct 2019 12:09:55 +0000 (15:09 +0300)]
Fix recording keyboard macros in Calc

* lisp/calc/calc.el (calc-unread-command): Prevent recording
key twice when defining a keyboard macro.  Patch by Christoph
Arenz <tiga.arenz@web.de>.

Copyright-paperwork-exempt: yes

5 years agoauth-source: Fix wrong-type-argument when searching plstore
Daiki Ueno [Tue, 15 Oct 2019 10:42:37 +0000 (12:42 +0200)]
auth-source: Fix wrong-type-argument when searching plstore

`auth-source-search' can be called with an integer port number from
`network-stream-certificate`, while the backend implementation doesn't
allow non-string attributes.

* lisp/auth-source.el (auth-source-plstore-search): Ensure attributes
are string.

5 years agoRevert "Remove XEmacs code from tetris.el"
Lars Ingebrigtsen [Tue, 15 Oct 2019 09:06:40 +0000 (11:06 +0200)]
Revert "Remove XEmacs code from tetris.el"

This reverts commit 68b91333d5a070c84afeadc273fd5c44df70f0a6.

This should be ported to Emacs instead.

5 years agoRevert "Remove XEmacs-only code from snake.el"
Lars Ingebrigtsen [Tue, 15 Oct 2019 09:06:14 +0000 (11:06 +0200)]
Revert "Remove XEmacs-only code from snake.el"

This reverts commit 7174a2b59f4cb883beb70bb3d182d59ab425e2f1.

This should be ported to Emacs instead.

5 years ago; Minor copyedits in recently installed documentation changes
Eli Zaretskii [Tue, 15 Oct 2019 08:20:22 +0000 (11:20 +0300)]
; Minor copyedits in recently installed documentation changes

* lisp/files.el (require-final-newline):
* etc/NEWS: Improve wording in recent documentation changes.

5 years agoMake auth-source work with non-ASCII passwords again
Lars Ingebrigtsen [Tue, 15 Oct 2019 06:42:28 +0000 (08:42 +0200)]
Make auth-source work with non-ASCII passwords again

* lisp/auth-source.el (auth-source--obfuscate): Convert the string
to bytes before obfuscating.
(auth-source--deobfuscate): Convert back into a string (bug#37758).

5 years agoAdd new macro `benchmark-progn'
Lars Ingebrigtsen [Tue, 15 Oct 2019 06:19:08 +0000 (08:19 +0200)]
Add new macro `benchmark-progn'

* doc/lispref/debugging.texi (Profiling): Mention it.

* lisp/emacs-lisp/benchmark.el (benchmark-progn): New macro.

5 years agoFix python-shell font-lock cleanup for unclosed quotes (Bug#32390)
Carlos Pita [Tue, 4 Dec 2018 22:35:09 +0000 (19:35 -0300)]
Fix python-shell font-lock cleanup for unclosed quotes (Bug#32390)

The problem originating this report was:

-------------
In [15]: "
  File "<ipython-input-15-3b7a06bb1102>", line 1
    "
     ^
SyntaxError: EOL while scanning string literal

In [16]:   string face still here"
-------------

This happens because
python-shell-font-lock-comint-output-filter-function is called twice,
first for the error output and then for the "In [16]: " part.  The
first time python-shell-comint-end-of-output-p returns nil since
we're *not* at the end of an input prompt.  The second time it returns
0 since we're at the end of *just* an input prompt.  So we don't call
python-shell-font-lock-cleanup-buffer either time.

The current code is relying in a very weak rule: it considers "just an
input prompt" to be a continuation prompt.  Another unreliable aspect
of the current rule is that sometimes

    (python-shell-comint-end-of-output-p (ansi-color-filter-apply output))

returns 1 and not 0 for continuation prompts.  In short, the rule does
a very poor job identifying continuations.

* lisp/progmodes/python.el (python-shell-font-lock-cleanup-buffer):
Don't check for empty OUTPUT since python-shell-comint-end-of-output-p
returns nil for that anyway.  Don't check for
python-shell-comint-end-of-output-p returning a specific number
because it's unreliable, just check for any non-nil.  Identify
continuation prompts by looking for "...".

5 years agoAdd images on tab-bar buttons the first time the tab bar is activated
Juri Linkov [Mon, 14 Oct 2019 22:43:45 +0000 (01:43 +0300)]
Add images on tab-bar buttons the first time the tab bar is activated

* lisp/tab-bar.el (tab-bar-mode): Set display property with image files
on tab-bar-new-button and tab-bar-close-button when tab-bar-mode is enabled
the first time.
(tab-bar-new-button, tab-bar-close-button): Use default values
without display image properties.  (Bug#37685)

5 years agolisp/*.el: Force non-nil result to t, to match docstring
Juanma Barranquero [Mon, 14 Oct 2019 21:52:21 +0000 (23:52 +0200)]
lisp/*.el: Force non-nil result to t, to match docstring

* lisp/ido.el (ido-ignore-item-p):
* lisp/simple.el (use-region-p):
* lisp/whitespace.el (whitespace-style-face-p)
(whitespace-style-mark-p):
* lisp/calendar/cal-islam.el (calendar-islamic-leap-year-p):
* lisp/mail/rmail.el (rmail-is-text-p):
* lisp/mh-e/mh-alias.el (mh-alias-for-from-p):
* lisp/net/imap.el (imap-message-flag-permanent-p):
* lisp/progmodes/tcl.el (tcl-real-comment-p):
* lisp/textmodes/table.el (table--point-in-cell-p):
Normalize boolean result.

5 years agoSet tab-line face height to 0.9.
Juri Linkov [Mon, 14 Oct 2019 21:50:24 +0000 (00:50 +0300)]
Set tab-line face height to 0.9.

* lisp/tab-line.el (tab-line): Set :height to 0.9.
* lisp/tab-bar.el (tab-bar): Remove :height.

5 years agoRemove the find-file-visit-truename safe-local-variable
Lars Ingebrigtsen [Mon, 14 Oct 2019 21:36:51 +0000 (23:36 +0200)]
Remove the find-file-visit-truename safe-local-variable

* lisp/files.el (find-file-visit-truename): Remove the
safe-local-variable put, because the variable is checked too late
to actually make a difference (bug#36830).

5 years agoquail/py-b5: Use U+3007 for ideographic zero (bug#3179)
Štěpán Němec [Mon, 14 Oct 2019 21:12:00 +0000 (23:12 +0200)]
quail/py-b5: Use U+3007 for ideographic zero (bug#3179)

* leim/leim-ext.el ("quail/PY-b5"): Use U+3007 instead of U+25CB for
ideographic zero.  U+25CB (used previously) is only one of the several
lookalikes (bug#3179).

5 years agorequire-final-newline doc string clarification
Lars Ingebrigtsen [Mon, 14 Oct 2019 20:49:22 +0000 (22:49 +0200)]
require-final-newline doc string clarification

* lisp/files.el (require-final-newline): Mention that the variable
applies to visited files (bug#34986).

5 years agoUse variable-pitch fonts in tab-bar and tab-line faces
Juri Linkov [Mon, 14 Oct 2019 20:07:23 +0000 (23:07 +0300)]
Use variable-pitch fonts in tab-bar and tab-line faces

* lisp/tab-bar.el (tab-bar):
* lisp/tab-line.el (tab-line):
Inherit face from variable-pitch.

5 years agoClarify C void type description in semantic
Stefan Kangas [Mon, 14 Oct 2019 19:36:14 +0000 (21:36 +0200)]
Clarify C void type description in semantic

* admin/grammars/c.by: Clarify void type.  (Bug#9222)

5 years agodired-do-shell-command doc string fix
Lars Ingebrigtsen [Mon, 14 Oct 2019 19:29:48 +0000 (21:29 +0200)]
dired-do-shell-command doc string fix

* lisp/dired-aux.el (dired-do-shell-command): Mention the guesser
variables (bug#16562).

5 years agoFix initial value of frame-inhibit-implied-resize
Juri Linkov [Mon, 14 Oct 2019 19:14:15 +0000 (22:14 +0300)]
Fix initial value of frame-inhibit-implied-resize

* src/frame.c (syms_of_frame): Update doc string and default value of
frame-inhibit-implied-resize in NS to include 'tab-bar-lines.

5 years agoMinor fixes in Introduction to Emacs Lisp
Eli Zaretskii [Mon, 14 Oct 2019 17:23:53 +0000 (20:23 +0300)]
Minor fixes in Introduction to Emacs Lisp

* doc/lispintro/emacs-lisp-intro.texi (if, save-excursion):
'defun' is a macro, not a special form anymore.  (Bug#37747)

5 years ago* lisp/tab-bar.el (tab-bar-tab-name-current): Fix with buffer-name.
Juri Linkov [Mon, 14 Oct 2019 16:51:51 +0000 (19:51 +0300)]
* lisp/tab-bar.el (tab-bar-tab-name-current): Fix with buffer-name.

5 years ago; Minor copyedits of recent documentation changes
Eli Zaretskii [Mon, 14 Oct 2019 14:35:42 +0000 (17:35 +0300)]
; Minor copyedits of recent documentation changes

* etc/NEWS:
* doc/lispref/display.texi (Face Attributes): Fix
documentation of the ':extend' face attribute.

5 years agoImprove documentation of dired-do-chmod
Stefan Kangas [Mon, 14 Oct 2019 14:00:05 +0000 (16:00 +0200)]
Improve documentation of dired-do-chmod

* lisp/dired-aux.el (dired-do-chmod): Doc fix.  The part about
MS-Windows was written by Eli Zaretskii.  (Bug#24897)

5 years agoEnable modules by default.
Philipp Stephani [Sun, 13 Oct 2019 15:26:10 +0000 (17:26 +0200)]
Enable modules by default.

The interface has been stable since Emacs 25, and most bugs are fixed
by now.

* configure.ac: Enable modules by default.

5 years agoSuppress eager completion on not connected hosts in Tramp
Michael Albinus [Mon, 14 Oct 2019 12:53:29 +0000 (14:53 +0200)]
Suppress eager completion on not connected hosts in Tramp

* lisp/net/tramp.el (tramp-completion-handle-file-name-completion):
Bind `non-essential' to t.

5 years agoMerge branch 'feature/extend_face_id'
Jimmy Aguilar Mena [Mon, 14 Oct 2019 12:29:47 +0000 (14:29 +0200)]
Merge branch 'feature/extend_face_id'

New face attribute :extend to control the face extension after
EOL.

necessary, # especially if it merges an updated upstream into a topic
branch.  # # Lines starting with '#' will be ignored, and an empty
message aborts # the commit.

5 years agoFix issue calling face_at_pos. feature/extend_face_id
Jimmy Aguilar Mena [Sun, 13 Oct 2019 21:20:22 +0000 (23:20 +0200)]
Fix issue calling face_at_pos.

*src/xdisp.c (extend_face_to_end_of_line): Add extra condition when
producing glyphs from a C string to not call face_at_pos.

5 years agoModify face_at_pos to not modify change IT.
Jimmy Aguilar Mena [Sun, 13 Oct 2019 14:56:50 +0000 (16:56 +0200)]
Modify face_at_pos to not modify change IT.

src/xdisp.c (face_at_pos): Removed code to that modified
it->start_of_box_run_p and it->face_box_p.  This function should not
modify it.
(handle_face_prop): Added code to update it->start_of_box_run_p and
it->face_box_p.
(underlying_face_id): Input IT made CONST.

5 years ago; extend_face_id and fill_column_indicator corrections
Jimmy Aguilar Mena [Wed, 9 Oct 2019 14:44:21 +0000 (16:44 +0200)]
; extend_face_id and fill_column_indicator corrections

*etc/NEWS: Correction for extend face and add some comments in the
code.

5 years ago*etc/NEWS: Added comment about :extend face attribute in NEWS.
Jimmy Aguilar Mena [Sun, 29 Sep 2019 19:41:00 +0000 (21:41 +0200)]
*etc/NEWS: Added comment about :extend face attribute in NEWS.

5 years agoDocument new :extend face attribute in manuals.
Jimmy Aguilar Mena [Sat, 21 Sep 2019 21:34:40 +0000 (23:34 +0200)]
Document new :extend face attribute in manuals.

Some stylistic corrections in src/xdisp.c and src/xfaces.c.

5 years agoFixed merge_face_ref recursive calls.
Jimmy Aguilar Mena [Sat, 21 Sep 2019 18:33:38 +0000 (20:33 +0200)]
Fixed merge_face_ref recursive calls.

* src/xfaces.c (merge_face_ref): Fixed recursive calls to consider
filter when CONSP (face_ref).

5 years agoOptimization in extend_face
Jimmy Aguilar Mena [Sat, 21 Sep 2019 17:57:17 +0000 (19:57 +0200)]
Optimization in extend_face

* src/xdisp.c (extend_face_to_end_of_line): Optimization to void
calls to face_at_pos.

5 years agoExtend_face simplify.
Jimmy Aguilar Mena [Sat, 21 Sep 2019 15:04:09 +0000 (17:04 +0200)]
Extend_face simplify.

* src/dispextern.h (struct it): Removed extend_face unneeded members.
* src/xdisp.c (handle_face_prop_general): renamed to face_at_pos and
removed input parameter initial_face_id. Updated all occurrences.

5 years agoAdded parameter attr_filter to face_at_string_position.
Jimmy Aguilar Mena [Sun, 15 Sep 2019 21:14:48 +0000 (23:14 +0200)]
Added parameter attr_filter to face_at_string_position.

Update all the occurrences in src/xdisp.c and src/xfaces.c

5 years agoExtend face hl-line after end-of-line
Jimmy Aguilar Mena [Sat, 14 Sep 2019 21:46:10 +0000 (23:46 +0200)]
Extend face hl-line after end-of-line

* lisp/hl-line.el (face hl-line): Added extend attribute to hl-line
face.

5 years agoFix last change in append_space_for_newline.
Jimmy Aguilar Mena [Sat, 14 Sep 2019 21:43:32 +0000 (23:43 +0200)]
Fix last change in append_space_for_newline.

 * src/xdisp.c (append_space_for_newline): Code refactor and
 simplification.

5 years agoAdd space for cursor to work also in terminal.
Jimmy Aguilar Mena [Sat, 14 Sep 2019 19:15:17 +0000 (21:15 +0200)]
Add space for cursor to work also in terminal.

* src/xdisp.c (append_space_for_newline): Modified to add the space
with the last face also in terminal interface.
(fill_column_indicator_column): Modified to group more conditions.
(extend_face_to_end_of_line): Simplified code in
fill_column_indicator to use the new function.

5 years agoChanged handle_face_prop_general prototype.
Jimmy Aguilar Mena [Mon, 9 Sep 2019 14:10:57 +0000 (16:10 +0200)]
Changed handle_face_prop_general prototype.

* src/xdisp.h (handle_face_prop_general): Changed function prototype
to receive different arguments.

5 years agoFixed extend face filtered for prop.
Jimmy Aguilar Mena [Sun, 8 Sep 2019 12:41:31 +0000 (14:41 +0200)]
Fixed extend face filtered for prop.

* src/xfaces.c (face_at_buffer_position): Pass ATTR_FILTER to
merge_face_ref in when !NILP (prop).

5 years agoCall handle_face_prop_general to extend face.
Jimmy Aguilar Mena [Sat, 12 Oct 2019 17:51:46 +0000 (19:51 +0200)]
Call handle_face_prop_general to extend face.

* src/xdisp.c (extend_face_to_end_of_line): Added a call to
handle_face_prop_general to extend face after EOL according to
parameter :extend in the faces.

5 years agoUpdate dfci code with new extend_face code.
Jimmy Aguilar Mena [Sat, 12 Oct 2019 17:15:32 +0000 (19:15 +0200)]
Update dfci code with new extend_face code.

* src/xdisp.c (extend_face_to_end_of_line): Updated the
column-indicator code to use the new version of the function
fill_column_indicator_column.

5 years agoNew parameter to control the face extension..
Jimmy Aguilar Mena [Sat, 12 Oct 2019 16:10:48 +0000 (18:10 +0200)]
New parameter to control the face extension..

* src/xdisp.c (handle_face_prop_general): New function to specialize
handle_face_prop with ATTR_FILTER.
* src/dispextern.h (face_at_buffer_position): Added
LFACE_ATTRIBUTE_INDEX.
* src/xfaces.c (merge_face_ref): Added LFACE_ATTRIBUTE_INDEX to merge
conditionally.

5 years agoAdded face parameter :extend.
Jimmy Aguilar Mena [Wed, 4 Sep 2019 15:27:28 +0000 (17:27 +0200)]
Added face parameter :extend.

This is an initial change to add a parameter :extend that will be used
in the display engine later.

5 years agoSimplify struct face to use only underline.
Jimmy Aguilar Mena [Wed, 28 Aug 2019 09:47:50 +0000 (11:47 +0200)]
Simplify struct face to use only underline.

* src/dispextern.h (enum face_underline_type): Add FACE_NO_UNDERLINE = 0.
(struct face): Merge `underline_type` and `underline_p` into `underline`.
Update all the occurrences in src/xdisp.c, src/xfaces.c, and src/xterm.c.

5 years agoFix directory-files-recursively doc typo
Robert Pluim [Mon, 14 Oct 2019 09:43:12 +0000 (11:43 +0200)]
Fix directory-files-recursively doc typo

* lisp/files.el (directory-files-recursively): Fix doc string.

5 years agoFix bug recently introduced in 'fit-window-to-buffer' (Bug#37743)
Martin Rudalics [Mon, 14 Oct 2019 08:53:07 +0000 (10:53 +0200)]
Fix bug recently introduced in 'fit-window-to-buffer' (Bug#37743)

* lisp/window.el (fit-window-to-buffer): Call 'window-combined-p'
with right argument (Bug#37743).

5 years agoFix up previous dired change again
Lars Ingebrigtsen [Mon, 14 Oct 2019 06:47:02 +0000 (08:47 +0200)]
Fix up previous dired change again

* lisp/dired.el (dired-set-id): Fix the name of the face after the
previous change.

5 years agoFix typo in previous dired change
Lars Ingebrigtsen [Mon, 14 Oct 2019 06:43:36 +0000 (08:43 +0200)]
Fix typo in previous dired change

* lisp/dired.el (dired-set-idguid): Remove superfluous '
introduced by previous change (bug#37742).

5 years ago; Minor fixes in documentation
Eli Zaretskii [Mon, 14 Oct 2019 06:33:51 +0000 (09:33 +0300)]
; Minor fixes in documentation

* doc/emacs/xresources.texi (Table of Resources):
* doc/emacs/cmdargs.texi (Misc X):
* etc/NEWS: Fix recent changes in documentation.

5 years ago(help-fns--var-aliases): Fix compilation warning in previous patch.
Lars Ingebrigtsen [Mon, 14 Oct 2019 05:49:25 +0000 (07:49 +0200)]
(help-fns--var-aliases): Fix compilation warning in previous patch.

5 years agoMake `C-h v' list all aliases a variable has
Lars Ingebrigtsen [Mon, 14 Oct 2019 05:47:53 +0000 (07:47 +0200)]
Make `C-h v' list all aliases a variable has

* lisp/help-fns.el (help-fns--var-aliases): New function (bug#15179).

5 years agoMake url-hexify-string accept a list of allowed chars (bug#26469)
Hong Xu [Mon, 14 Oct 2019 04:46:47 +0000 (06:46 +0200)]
Make url-hexify-string accept a list of allowed chars (bug#26469)

* lisp/url/url-util.el (url-hexify-string): Accept a list of allowed
chars.
* doc/misc/url.texi (URI Encoding): Update url-hexify-string doc and
index improvements (bug#24694).

5 years agoTweak ispell-init-process messaging
Lars Ingebrigtsen [Mon, 14 Oct 2019 04:08:19 +0000 (06:08 +0200)]
Tweak ispell-init-process messaging

* lisp/textmodes/ispell.el (ispell-init-process): Output a "done"
after the "starting" message (bug#12828).

5 years agoAdd a new tar-copy-preserve-time variable
Lars Ingebrigtsen [Mon, 14 Oct 2019 03:41:45 +0000 (05:41 +0200)]
Add a new tar-copy-preserve-time variable

* lisp/tar-mode.el (tar-copy-preserve-time): New variable (bug#11882).
(tar-copy): Use it.

5 years agoClarify message about newer source file
Lars Ingebrigtsen [Mon, 14 Oct 2019 03:19:37 +0000 (05:19 +0200)]
Clarify message about newer source file

* src/lread.c (Fload): Mention which file was actually used
instead of just saying that the .el is newer than the .elc (bug#10637).

5 years agoAllow zap-to-char to use a history
Lars Ingebrigtsen [Mon, 14 Oct 2019 03:09:32 +0000 (05:09 +0200)]
Allow zap-to-char to use a history

* doc/emacs/killing.texi (Other Kill Commands): Document it.

* lisp/simple.el (read-char-with-history): New function (bug#10477).
(zap-to-char): Use it to have a history.

5 years agoFont-lock suid/guid files in Dired
Lars Ingebrigtsen [Mon, 14 Oct 2019 01:31:33 +0000 (03:31 +0200)]
Font-lock suid/guid files in Dired

* lisp/dired.el (dired-font-lock-keywords): Font-lock suid/guid
permissions (bug#8186).
(dired-sguid): New face.

5 years agoFurther changes to ensure that copy-keymap doesn't segfault
Lars Ingebrigtsen [Mon, 14 Oct 2019 00:52:25 +0000 (02:52 +0200)]
Further changes to ensure that copy-keymap doesn't segfault

* src/keymap.c (copy_keymap_1, copy_keymap_set_char_table): Ensure
we don't recurse infinitely when using non-sparse keymaps, too.

This change makes this form not segfault:

(let ((map (make-keymap)))
  (define-key map " " map)
  (copy-keymap map))

5 years agoClarify mouse commands section in manual
Stefan Kangas [Fri, 11 Oct 2019 00:21:08 +0000 (02:21 +0200)]
Clarify mouse commands section in manual

* doc/emacs/frames.texi (Mouse Commands): Clarify section on mouse
wheel somewhat.  (Bug#28182)

5 years agoDon't display the number of windows in tab name in tab-bar by default.
Juri Linkov [Sun, 13 Oct 2019 22:00:38 +0000 (01:00 +0300)]
Don't display the number of windows in tab name in tab-bar by default.

* lisp/tab-bar.el (tab-bar-tab-name-function): Change the default value.
(tab-bar-tab-name-current): Rename from tab-bar-tab-name-selected-window.
(tab-bar-tab-name-current-with-count): New function.
(tab-bar-tab-name-all): Rename from tab-bar-tab-name-all-windows.

5 years ago* lisp/window.el (next-buffer, previous-buffer): Add repeat count arg.
Juri Linkov [Sun, 13 Oct 2019 21:18:56 +0000 (00:18 +0300)]
* lisp/window.el (next-buffer, previous-buffer): Add repeat count arg.

* doc/emacs/buffers.texi (Select Buffer): Mention arg as repeat count.
(Bug#37514)

5 years agoMake list-buffers--refresh preserve marks
Lars Ingebrigtsen [Sun, 13 Oct 2019 20:56:38 +0000 (22:56 +0200)]
Make list-buffers--refresh preserve marks

* lisp/buff-menu.el (list-buffers--refresh): Preserve the marked
buffers when refreshing the list (bug#6491).

5 years agoEnable tab-bar-mode from X resources
Juri Linkov [Sun, 13 Oct 2019 20:56:17 +0000 (23:56 +0300)]
Enable tab-bar-mode from X resources

* lisp/startup.el (x-apply-session-resources): Enable tab-bar-mode
when X resource "tabBar" class "TabBar" is "on", "yes" or "1".

* doc/man/emacs.1.in:
* doc/emacs/xresources.texi (Table of Resources):
Document X resource "tabBar" (class "TabBar").

5 years agoFix initial value of frame-inhibit-implied-resize
Juri Linkov [Sun, 13 Oct 2019 20:47:33 +0000 (23:47 +0300)]
Fix initial value of frame-inhibit-implied-resize

* src/frame.c (syms_of_frame): Update doc string and default value of
frame-inhibit-implied-resize in NS to not include 'tab-bar-lines,
and non-toolkit X builds to include 'tab-bar-lines.

5 years agoFix hitting RET on some text in compilation-mode
Lars Ingebrigtsen [Sun, 13 Oct 2019 20:22:31 +0000 (22:22 +0200)]
Fix hitting RET on some text in compilation-mode

* lisp/progmodes/compile.el (compilation-next-error-function):
Don't bug out with an incomprehensible error message on "make[2]:"
texts (bug#5316).
(compilation-find-file): Protect against there being no file name.

5 years ago* src/xdisp.c (note_tab_bar_highlight): Simplify HAVE_NS ifdefs.
Paul Eggert [Sun, 13 Oct 2019 19:55:12 +0000 (12:55 -0700)]
* src/xdisp.c (note_tab_bar_highlight): Simplify HAVE_NS ifdefs.

5 years agoAdd a new action in save-some-buffers to view the buffer
Lars Ingebrigtsen [Sun, 13 Oct 2019 19:36:57 +0000 (21:36 +0200)]
Add a new action in save-some-buffers to view the buffer

* doc/emacs/files.texi (Save Commands): Document it.

* lisp/files.el (save-some-buffers-action-alist): Offer to pop to
the buffer and then quit (bug#3625).
(save-some-buffers): Implement it.
(save-some-buffers--switch-window-callback): New variable.

5 years agoCorrectly explain test failures with mixed uni/multibyte strings
Mattias Engdegård [Thu, 10 Oct 2019 19:20:20 +0000 (21:20 +0200)]
Correctly explain test failures with mixed uni/multibyte strings

* lisp/emacs-lisp/ert.el (ert--explain-equal-rec):
* test/lisp/emacs-lisp/ert-tests.el (ert-test-explain-equal):
When explaining a difference between a unibyte and a multibyte string,
first convert both to multibyte.  Otherwise, we might end up comparing
unibyte char C to multibyte char C, 127<C<256, and not detect the
difference (bug#30219).

5 years agoMention shifted alphabetical control GUI sequences
Lars Ingebrigtsen [Sun, 13 Oct 2019 18:06:19 +0000 (20:06 +0200)]
Mention shifted alphabetical control GUI sequences

* doc/emacs/custom.texi (Modifier Keys): Mention that you can bind
shifted alphabetical control sequences in GUI frames (bug#23247).

5 years agoAvoid compiler warnings on macOS.
Philipp Stephani [Sun, 13 Oct 2019 15:24:10 +0000 (17:24 +0200)]
Avoid compiler warnings on macOS.

* src/xdisp.c (note_tab_bar_highlight): Define variables 'dpyinfo' and
'mouse_down_p' only if needed.

5 years agoFix with-coding-priority markup in Elisp manual
Basil L. Contovounesios [Sun, 13 Oct 2019 15:36:02 +0000 (16:36 +0100)]
Fix with-coding-priority markup in Elisp manual

* doc/lispref/nonascii.texi (Specifying Coding Systems): Don't use
'&rest' in conjunction with 'body...' in arglist of
with-coding-priority.  Fix typo and cross-referencing (2-arg @pxref
adds a trailing period).

5 years agoMinor tweaks to time-stamp documentation strings
Stephen Gildea [Sun, 13 Oct 2019 14:58:55 +0000 (07:58 -0700)]
Minor tweaks to time-stamp documentation strings

* time-stamp.el (time-stamp): Reformat the explanation of the
variables that affect time-stamp, for easier reading.  In particular,
wrap the documentation to 75 characters, so that it displays neatly as
a before-save-hook customization option.

* time-stamp-tests.el (with-time-stamp-test-env): Use imperative voice,
per checkdoc.

5 years agoIn compilation-tear-down-arrow-spec-in-margin, test compilation-arrow-overlay
Alan Mackenzie [Sun, 13 Oct 2019 13:15:35 +0000 (13:15 +0000)]
In compilation-tear-down-arrow-spec-in-margin, test compilation-arrow-overlay

* lisp/progmodes/compile.el (compilation-tear-down-arrow-spec-in-margin): Make
sure compilation-arrow-overlay is an overlay before performing overlay
operations on it.  This fixes bug #37733.

5 years ago; Minor copyedits in a recent ELisp manual change.
Eli Zaretskii [Sun, 13 Oct 2019 07:59:18 +0000 (10:59 +0300)]
; Minor copyedits in a recent ELisp manual change.

* doc/lispref/tips.texi (Coding Conventions): Make the
guideline against '-p' in variable names less mandatory and
more constructive.

5 years ago; Fix recent additions to ELisp manual
Eli Zaretskii [Sun, 13 Oct 2019 07:50:30 +0000 (10:50 +0300)]
; Fix recent additions to ELisp manual

* doc/lispref/files.texi (Contents of Directories): Fix
recently added documentation of 'locate-dominating-file'.

5 years agoMake the previous-matching-history-element prompt clearer
Lars Ingebrigtsen [Sun, 13 Oct 2019 05:14:03 +0000 (07:14 +0200)]
Make the previous-matching-history-element prompt clearer

* lisp/simple.el (previous-matching-history-element): Put the
default into the prompt (bug#380).

5 years agoMake diff-mode understand git-format-patch separators
Konstantin Kharlamov [Sun, 13 Oct 2019 03:52:21 +0000 (05:52 +0200)]
Make diff-mode understand git-format-patch separators

* lisp/vc/diff-mode.el (diff-prev-line-if-patch-separator):
A function to return prev. line if it has git-format-patch
separator.
(diff-end-of-hunk): Make use of
diff-prev-line-if-patch-separator
diff-buffer-type: whether a buffer is a git-diff
(define-derived-mode): set diff-buffer-type to appropriate
value (bug#37395).

5 years agoTCL indentation fix outside functions
Rolf Ade [Sun, 13 Oct 2019 03:18:36 +0000 (05:18 +0200)]
TCL indentation fix outside functions

* lisp/progmodes/tcl.el (tcl-calculate-indent): Indent code
correctly outside of function definitions (bug#23565).

Copyright-paperwork-exempt: yes

5 years agoHide passwords more in `read-password'
Lars Ingebrigtsen [Sun, 13 Oct 2019 03:15:18 +0000 (05:15 +0200)]
Hide passwords more in `read-password'

* lisp/subr.el (read-password--hide-password): Factor out (bug#17127).
(read-passwd): Use it in post-command-hook instead of
after-change-functions to ensure that we hide the password no
matter what inserts text.

5 years agoUse quit-window in some functions
Andreas Politz [Sun, 13 Oct 2019 03:08:37 +0000 (05:08 +0200)]
Use quit-window in some functions

* lisp/strokes.el:
* lisp/startup.el (fancy-startup-tail):
* lisp/progmodes/verilog-mode.el (verilog-complete-word)
(verilog-show-completions):
* lisp/progmodes/idlwave.el (idlwave-quit-help): Use `quit-window'
(bug#24213).

5 years agoAdd -unknown to version-regexp-alist
Lars Ingebrigtsen [Sun, 13 Oct 2019 02:59:44 +0000 (04:59 +0200)]
Add -unknown to version-regexp-alist

* lisp/epg-config.el (epg-find-configuration): Remove the -unknown
hack, because it led to further problems later when comparing
versions.

* lisp/subr.el (version-regexp-alist): Rate -unknown versions the
same as -alpha releases (bug#37556).

5 years agoAdd "next" and "previous" shortcuts in eww-history buffers
Raimon Grau [Sun, 13 Oct 2019 02:26:39 +0000 (04:26 +0200)]
Add "next" and "previous" shortcuts in eww-history buffers

* lisp/net/eww.el (eww-history-mode-map): Add "n" and "p" for
"next-line" and "previous-line" (bug#37648).