From: Tassilo Horn <tsdh@gnu.org>
Date: Mon, 14 Dec 2015 17:23:31 +0000 (+0100)
Subject: Fix rx matcher overflow without limiting
X-Git-Tag: emacs-25.0.90~471
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=fe27e037663d36be3e5741c2ce86ab4ee8017db1;p=emacs.git

Fix rx matcher overflow without limiting

* lisp/textmodes/reftex-vars.el (reftex-label-regexps): Improve last
change to the regexp without imposing a limit on the length of the
options.
---

diff --git a/lisp/textmodes/reftex-vars.el b/lisp/textmodes/reftex-vars.el
index fcab1367f7d..9bc1d2d3af8 100644
--- a/lisp/textmodes/reftex-vars.el
+++ b/lisp/textmodes/reftex-vars.el
@@ -877,7 +877,17 @@ DOWNCASE    t:   Downcase words before using them."
       "\\\\label{\\(?1:[^}]*\\)}"
       ;; keyvals [..., label = {foo}, ...] forms used by ctable,
       ;; listings, minted, ...
-      "\\[[^][]\\{0,2000\\}\\<label[[:space:]]*=[[:space:]]*{?\\(?1:[^],}]+\\)}?")
+      ;;
+      ;; If you think the first shy group is a bit strange, it is like
+      ;; that in order not to overflow the regexp matcher stack in the
+      ;; presence of unbalanced brackets, i.e., a [ and then no
+      ;; closing bracket anymore.  In "[^[],]*,", the "*" repetition
+      ;; will be done without any need to record state for eventual
+      ;; backtracking because the "," is mutually exclusive with the
+      ;; "[^][,]", and the regexp matcher includes a special
+      ;; optimization for that case since it's common and very
+      ;; useful).  (Hint by Stefan Monnier)
+      "\\[\\(?:[^][,]*,\\)*[ \t]*\\<label[[:space:]]*=[[:space:]]*{?\\(?1:[^],}]+\\)}?")
     "List of regexps matching \\label definitions.
 The default value matches usual \\label{...} definitions and
 keyval style [..., label = {...}, ...] label definitions.  It is