From: Alan Third <alan@idiocy.org>
Date: Mon, 28 Oct 2019 11:21:29 +0000 (+0000)
Subject: Prevent text flicker with macOS input methods (bug#23412)
X-Git-Tag: emacs-27.0.90~797
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=fd1b720028064c2566ff4dcc3ad898346a0f6b77;p=emacs.git

Prevent text flicker with macOS input methods (bug#23412)

* src/nsterm.m ([EmacsView setMarkedText:selectedRange:]): Don't
always delete the working text as ns-put-working-text does that.
---

diff --git a/src/nsterm.m b/src/nsterm.m
index 5583c6105cb..afe7069aaed 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -6435,15 +6435,17 @@ not_in_argv (NSString *arg)
            (unsigned long)selRange.length,
            (unsigned long)selRange.location);
 
-  if (workingText != nil)
-    [self deleteWorkingText];
   if ([str length] == 0)
-    return;
+    {
+      [self deleteWorkingText];
+      return;
+    }
 
   if (!emacs_event)
     return;
 
   processingCompose = YES;
+  [workingText release];
   workingText = [str copy];
   ns_working_text = build_string ([workingText UTF8String]);