From: Martin Rudalics Date: Sat, 10 Jan 2009 09:51:28 +0000 (+0000) Subject: (tool-bar-mode): Modify all frame parameters when X-Git-Tag: emacs-pretest-23.0.90~578 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=fca863b8166ed9d153f747c8055c3ed0d85ecb7a;p=emacs.git (tool-bar-mode): Modify all frame parameters when toggling tool bars on. (Bug#1754) --- diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 54cdb4fd16e..91bd9efe560 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2009-01-10 Martin Rudalics + + * tool-bar.el (tool-bar-mode): Modify all frame parameters when + toggling tool bars on. (Bug#1754) + 2009-01-09 Chong Yidong * faces.el (face-valid-attribute-values): Use string as value for diff --git a/lisp/tool-bar.el b/lisp/tool-bar.el index a08df3124a8..226b1ddba5c 100644 --- a/lisp/tool-bar.el +++ b/lisp/tool-bar.el @@ -54,9 +54,12 @@ conveniently adding tool bar items." :group 'frames (if tool-bar-mode (progn - (dolist (frame (frame-list)) - (if (display-graphic-p frame) - (set-frame-parameter frame 'tool-bar-lines 1))) + ;; Make one tool-bar-line for any - including non-graphical - + ;; terminal, see Bug#1754. If this causes problems, we should + ;; handle the problem in `modify-frame-parameters' or do not + ;; call `modify-all-frames-parameters' when toggling the tool + ;; bar off either. + (modify-all-frames-parameters (list (cons 'tool-bar-lines 1))) (if (= 1 (length (default-value 'tool-bar-map))) ; not yet setup (tool-bar-setup))) (modify-all-frames-parameters (list (cons 'tool-bar-lines 0)))))