From: Stefan Kangas <stefan@marxist.se>
Date: Mon, 27 Dec 2021 23:09:08 +0000 (+0100)
Subject: Fix read-multiple-choice tests
X-Git-Tag: emacs-29.0.90~3406
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=fb9b7b70f55dd49d3019a9c69663076e942d857e;p=emacs.git

Fix read-multiple-choice tests

* lisp/emacs-lisp/rmc.el (rmc--add-key-description): Fix typo.
* test/lisp/emacs-lisp/rmc-tests.el
(test-rmc--add-key-description)
(test-rmc--add-key-description/with-attributes)
(test-rmc--add-key-description/non-graphical-display): Fix tests.
---

diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
index 9d5fe40f9aa..ed764f5350e 100644
--- a/lisp/emacs-lisp/rmc.el
+++ b/lisp/emacs-lisp/rmc.el
@@ -41,7 +41,7 @@
             (format "%s %s"
                     (if graphical-terminal
                         (propertize desc 'face 'read-multiple-choice-face)
-                      (propertize desc 'face 'help-key-name))
+                      (propertize desc 'face 'help-key-binding))
                     name))
            ;; The prompt character is in the name, so highlight
            ;; it on graphical terminals.
diff --git a/test/lisp/emacs-lisp/rmc-tests.el b/test/lisp/emacs-lisp/rmc-tests.el
index 5a79c505ae2..c1e838d051e 100644
--- a/test/lisp/emacs-lisp/rmc-tests.el
+++ b/test/lisp/emacs-lisp/rmc-tests.el
@@ -34,9 +34,9 @@
     (should (equal (rmc--add-key-description '(?y "yes"))
                    '(?y . "yes")))
     (should (equal (rmc--add-key-description '(?n "foo"))
-                   '(?n . "[n] foo")))
+                   '(?n . "n foo")))
     (should (equal (rmc--add-key-description '(?\s "foo bar"))
-                   `(?\s . "[SPC] foo bar")))))
+                   `(?\s . "SPC foo bar")))))
 
 (ert-deftest test-rmc--add-key-description/with-attributes ()
   (cl-letf (((symbol-function 'display-supports-face-attributes-p) (lambda (_ _) t)))
@@ -45,10 +45,10 @@
              `(?y . ,(concat (propertize "y" 'face 'read-multiple-choice-face) "es"))))
     (should (equal-including-properties
              (rmc--add-key-description '(?n "foo"))
-             `(?n . ,(concat "[" (propertize "n" 'face 'read-multiple-choice-face) "] foo"))))
+             `(?n . ,(concat (propertize "n" 'face 'read-multiple-choice-face) " foo"))))
     (should (equal-including-properties
              (rmc--add-key-description '(?\s "foo bar"))
-             `(?\s . ,(concat "[" (propertize "SPC" 'face 'read-multiple-choice-face) "] foo bar"))))))
+             `(?\s . ,(concat (propertize "SPC" 'face 'read-multiple-choice-face) " foo bar"))))))
 
 (ert-deftest test-rmc--add-key-description/non-graphical-display ()
   (cl-letf (((symbol-function 'display-supports-face-attributes-p) (lambda (_ _) nil)))
@@ -57,7 +57,7 @@
              '(?y . "[Y]es")))
     (should (equal-including-properties
              (rmc--add-key-description '(?n "foo"))
-             '(?n . "[n] foo")))))
+             `(?n . ,(concat (propertize "n" 'face 'help-key-binding) " foo"))))))
 
 (ert-deftest test-read-multiple-choice ()
   (dolist (char '(?y ?n))